)]}'
{"manila_tempest_tests/common/waiters.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b5c436ee62a3953b7cf50499bc4c339451c419f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"886c4596_02120b1c","updated":"2021-01-20 22:04:23.000000000","message":"Atleast some of these methods look like they can be de-duplicated with little code.. Can you see if that\u0027s possible?","commit_id":"8787764137be43c76864546f89845f543ebbf762"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f4375602cf9cb0e23b7fecf38f2705efef7a951d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d74d7d24_939baa84","in_reply_to":"886c4596_02120b1c","updated":"2021-01-21 08:16:09.000000000","message":"I agree there is too much code duplication here.\nI remember I merged volume resources waiters in tempest a few years ago, but I relied on\nthe client names. In tempest for each resource there is a separated client, here in manila\nthere is one client for each version. I think it\u0027s important to know to which resource the\nwaiter is referring to for debugging. So I suggest for now to leave it as it is.","commit_id":"8787764137be43c76864546f89845f543ebbf762"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ec95b010752403e6a22ce9b96d7a9be7efeadda4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3ce819fa_124379f4","in_reply_to":"d74d7d24_939baa84","updated":"2021-01-21 17:41:37.000000000","message":"couldn\u0027t \"resource_type\" and \"resource_id\" be parameters? We could create a dict of resource_types to corresponding GET API methods if necessary; just a thought - i don\u0027t mind not doing all that consolidation in this change.","commit_id":"8787764137be43c76864546f89845f543ebbf762"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b5c436ee62a3953b7cf50499bc4c339451c419f","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    while instance_status !\u003d status:"},{"line_number":38,"context_line":"        time.sleep(client.build_interval)"},{"line_number":39,"context_line":"        body \u003d client.get_share(instance_id)"},{"line_number":40,"context_line":"        instance_status \u003d body[\u0027status\u0027]"},{"line_number":41,"context_line":"        if instance_status \u003d\u003d status:"},{"line_number":42,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"23e4afaf_f30c919e","line":39,"range":{"start_line":39,"start_character":22,"end_line":39,"end_character":31},"updated":"2021-01-20 22:04:23.000000000","message":"this has to be get_share_instance","commit_id":"8787764137be43c76864546f89845f543ebbf762"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f4375602cf9cb0e23b7fecf38f2705efef7a951d","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    while instance_status !\u003d status:"},{"line_number":38,"context_line":"        time.sleep(client.build_interval)"},{"line_number":39,"context_line":"        body \u003d client.get_share(instance_id)"},{"line_number":40,"context_line":"        instance_status \u003d body[\u0027status\u0027]"},{"line_number":41,"context_line":"        if instance_status \u003d\u003d status:"},{"line_number":42,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"0c2d706e_a6cf643a","line":39,"range":{"start_line":39,"start_character":22,"end_line":39,"end_character":31},"in_reply_to":"23e4afaf_f30c919e","updated":"2021-01-21 08:16:09.000000000","message":"Nice catch!","commit_id":"8787764137be43c76864546f89845f543ebbf762"}]}