)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf382aab3105caad3635cd142244ffb2c0de08f0","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-01-22 11:41:15 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added test_create_access_rule_cephx_admin_user testcase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I01157147e749ae6068e9878bffe322cb3993fb60"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f9745ab1_125d36cd","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":0},"updated":"2021-01-22 17:43:51.000000000","message":"Please mention what the intent of this test case is, briefly. \nIt\u0027d be good to call out that we\u0027re testing the fix for\nCVE-2020-27781","commit_id":"0552f3be9b354794ddc32309e7b5553dd3a9f1a2"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"271ed8c0fbb17b04e6dfae9cc175fc77120be392","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-01-22 11:41:15 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added test_create_access_rule_cephx_admin_user testcase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I01157147e749ae6068e9878bffe322cb3993fb60"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"452c53d5_2b0f8111","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":0},"in_reply_to":"f9745ab1_125d36cd","updated":"2021-01-22 21:13:04.000000000","message":"Done","commit_id":"0552f3be9b354794ddc32309e7b5553dd3a9f1a2"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"ec7cbc54c81ca4c9ac9c63dfa8f4290811149574","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added test_create_access_rule_cephx_admin_user testcase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This test case is used to validate fix to CVE-2020-27781."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I01157147e749ae6068e9878bffe322cb3993fb60"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f85003a7_0218fab0","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":56},"updated":"2021-01-24 14:25:04.000000000","message":"Thanks Vida,\nIt would be a nice if you could add some information\nabout this fix so that everyone will understand what \nthe test is testing.","commit_id":"4a1acad01f79e7f74865fe7162be5268878cc881"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7d8b383dc564249e1a75830d3c90d6c321ba2459","unresolved":true,"context_lines":[{"line_number":13,"context_line":"This step should return success, but the access rule for"},{"line_number":14,"context_line":"\"admin\" will be set to \"error\"."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://bugs.launchpad.net/manila/+bug/1904015"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I01157147e749ae6068e9878bffe322cb3993fb60"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"72ac85c6_83af4492","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":50},"updated":"2021-01-26 06:33:46.000000000","message":"Thanks Vida!\nPlease remove this line and add the bellow metadata:\nRelated-Bug: #1904015\n\nHere\u0027s a guide for writing a commit message.\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"14e6e48fe1262415e94f2297caa233920fa1b962"}],"manila_tempest_tests/tests/api/test_rules_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf382aab3105caad3635cd142244ffb2c0de08f0","unresolved":true,"context_lines":[{"line_number":402,"context_line":"                          self.share[\"id\"], self.access_type, access_to)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":405,"context_line":"    def test_create_access_rule_cephx_admin_user(self):"},{"line_number":406,"context_line":"        self.assertRaises(share_exceptions.AccessRuleBuildErrorException,"},{"line_number":407,"context_line":"                          self.allow_access,"},{"line_number":408,"context_line":"                          self.share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b690177_3c345b54","line":405,"range":{"start_line":405,"start_character":0,"end_line":405,"end_character":55},"updated":"2021-01-22 17:43:51.000000000","message":"this test needs a UUID/idempotent ID\n\nCan you also add a docstring here that describes that this test is used to validate the\nfix to CVE-2020-27781","commit_id":"0552f3be9b354794ddc32309e7b5553dd3a9f1a2"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"271ed8c0fbb17b04e6dfae9cc175fc77120be392","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                          self.share[\"id\"], self.access_type, access_to)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":405,"context_line":"    def test_create_access_rule_cephx_admin_user(self):"},{"line_number":406,"context_line":"        self.assertRaises(share_exceptions.AccessRuleBuildErrorException,"},{"line_number":407,"context_line":"                          self.allow_access,"},{"line_number":408,"context_line":"                          self.share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c008def_72928d50","line":405,"range":{"start_line":405,"start_character":0,"end_line":405,"end_character":55},"in_reply_to":"4b690177_3c345b54","updated":"2021-01-22 21:13:04.000000000","message":"Done","commit_id":"0552f3be9b354794ddc32309e7b5553dd3a9f1a2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf382aab3105caad3635cd142244ffb2c0de08f0","unresolved":true,"context_lines":[{"line_number":407,"context_line":"                          self.allow_access,"},{"line_number":408,"context_line":"                          self.share[\u0027id\u0027],"},{"line_number":409,"context_line":"                          access_to\u003d\u0027admin\u0027,"},{"line_number":410,"context_line":"                          access_type\u003d\u0027user\u0027,"},{"line_number":411,"context_line":"                          status\u003d\u0027error\u0027)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027dd8be44c-c7e8-42fe-b81c-095a1c66730c\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4601c86a_ebfc3bc5","line":410,"range":{"start_line":410,"start_character":39,"end_line":410,"end_character":43},"updated":"2021-01-22 17:43:51.000000000","message":"this has to be self.access_type or \"cephx\"","commit_id":"0552f3be9b354794ddc32309e7b5553dd3a9f1a2"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"271ed8c0fbb17b04e6dfae9cc175fc77120be392","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                          self.allow_access,"},{"line_number":408,"context_line":"                          self.share[\u0027id\u0027],"},{"line_number":409,"context_line":"                          access_to\u003d\u0027admin\u0027,"},{"line_number":410,"context_line":"                          access_type\u003d\u0027user\u0027,"},{"line_number":411,"context_line":"                          status\u003d\u0027error\u0027)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027dd8be44c-c7e8-42fe-b81c-095a1c66730c\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"956de6c4_4553450b","line":410,"range":{"start_line":410,"start_character":39,"end_line":410,"end_character":43},"in_reply_to":"4601c86a_ebfc3bc5","updated":"2021-01-22 21:13:04.000000000","message":"Done","commit_id":"0552f3be9b354794ddc32309e7b5553dd3a9f1a2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db4ac54919f938c55836d232be39f5279a95a95","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                          self.share[\"id\"],"},{"line_number":412,"context_line":"                          access_type\u003dself.access_type,"},{"line_number":413,"context_line":"                          access_to\u003d\u0027admin\u0027,"},{"line_number":414,"context_line":"                          status\u003d\u0027error\u0027)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    @decorators.idempotent_id(\u0027dd8be44c-c7e8-42fe-b81c-095a1c66730c\u0027)"},{"line_number":417,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"48bf4487_7dd5eb5d","line":414,"range":{"start_line":414,"start_character":26,"end_line":414,"end_character":40},"updated":"2021-03-12 07:09:19.000000000","message":"This test is failing because of this ^\n\nWhen you expect an \"error\" status, the \"allow_access\" call does not raise a BuildError exception.\nIf you remove this expectation (the default expected status is \"active\"), the method raises a BuildError if it goes to \"error\"","commit_id":"eb60d1f2a13e4a4104d9ccbd059d9b70d69c191b"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"17713089efa95981415d3c0198f9696d84eb0c94","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                          self.share[\"id\"],"},{"line_number":412,"context_line":"                          access_type\u003dself.access_type,"},{"line_number":413,"context_line":"                          access_to\u003d\u0027admin\u0027,"},{"line_number":414,"context_line":"                          status\u003d\u0027error\u0027)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    @decorators.idempotent_id(\u0027dd8be44c-c7e8-42fe-b81c-095a1c66730c\u0027)"},{"line_number":417,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"89f83a05_1b158662","line":414,"range":{"start_line":414,"start_character":26,"end_line":414,"end_character":40},"in_reply_to":"48bf4487_7dd5eb5d","updated":"2021-03-12 16:34:31.000000000","message":"The test is expected to pass when status \u003d \u0027error\u0027, and is expected to fail when status \u003d \u0027active\u0027.","commit_id":"eb60d1f2a13e4a4104d9ccbd059d9b70d69c191b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"001422a456ecb153995ce16d98ebbb7a403cbbf3","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                          self.share[\"id\"],"},{"line_number":412,"context_line":"                          access_type\u003dself.access_type,"},{"line_number":413,"context_line":"                          access_to\u003d\u0027admin\u0027,"},{"line_number":414,"context_line":"                          status\u003d\u0027error\u0027)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    @decorators.idempotent_id(\u0027dd8be44c-c7e8-42fe-b81c-095a1c66730c\u0027)"},{"line_number":417,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"e30cddc0_0c7c5167","line":414,"range":{"start_line":414,"start_character":26,"end_line":414,"end_character":40},"in_reply_to":"89f83a05_1b158662","updated":"2021-03-12 17:20:41.000000000","message":"Yes, but your assert here has two expectations:\n\n-\u003e Wait for AccessRuleBuildErrorException to occur on allow_access\n-\u003e Wait for the status to be \u0027error\u0027\n\nIf the second becomes true, the code bails out -\u003e it doesn\u0027t raise a AccessRuleBuildErrorException\nSee: https://opendev.org/openstack/manila-tempest-plugin/src/commit/f7fc5b6494b0cd6aaeface59fe1c378ba72b5677/manila_tempest_tests/common/waiters.py#L88-L100\n\nWhat you really want is just one of these expectations, not both.","commit_id":"eb60d1f2a13e4a4104d9ccbd059d9b70d69c191b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"449c6c709c8527a6bde7aa0c4ca2a68342985142","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                          self.share[\"id\"],"},{"line_number":412,"context_line":"                          access_type\u003dself.access_type,"},{"line_number":413,"context_line":"                          access_to\u003d\u0027admin\u0027,"},{"line_number":414,"context_line":"                          status\u003d\u0027error\u0027)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    @decorators.idempotent_id(\u0027dd8be44c-c7e8-42fe-b81c-095a1c66730c\u0027)"},{"line_number":417,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"b9d05d98_f7242b66","line":414,"range":{"start_line":414,"start_character":26,"end_line":414,"end_character":40},"in_reply_to":"9bb659f4_f9f50a23","updated":"2021-03-14 20:49:15.000000000","message":"this test is failing: https://d0d1e4aea63f370b3f33-3819aef22f5431ed2315de5729776833.ssl.cf1.rackcdn.com/772064/7/check/manila-tempest-plugin-cephfs-native/289af3e/testr_results.html\n\nHowever the ceph-native job here is non-voting","commit_id":"eb60d1f2a13e4a4104d9ccbd059d9b70d69c191b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"6f4e0c43a5e903ea24d44e33bf61c2193775ed6d","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                          self.share[\"id\"],"},{"line_number":412,"context_line":"                          access_type\u003dself.access_type,"},{"line_number":413,"context_line":"                          access_to\u003d\u0027admin\u0027,"},{"line_number":414,"context_line":"                          status\u003d\u0027error\u0027)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    @decorators.idempotent_id(\u0027dd8be44c-c7e8-42fe-b81c-095a1c66730c\u0027)"},{"line_number":417,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9bb659f4_f9f50a23","line":414,"range":{"start_line":414,"start_character":26,"end_line":414,"end_character":40},"in_reply_to":"e30cddc0_0c7c5167","updated":"2021-03-14 13:13:36.000000000","message":"Oh my mistake, thanks Goutham.\nWeird, how the gates passed.","commit_id":"eb60d1f2a13e4a4104d9ccbd059d9b70d69c191b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44ec5ac23a369bd93ae92ef0b5509cd28126695b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from testtools import testcase as tc"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from manila_tempest_tests.common import constants"},{"line_number":24,"context_line":"from manila_tempest_tests.common import waiters"},{"line_number":25,"context_line":"from manila_tempest_tests.tests.api import base"},{"line_number":26,"context_line":"from manila_tempest_tests import utils"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"2b1570a3_89bd9683","side":"PARENT","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":47},"updated":"2021-03-15 19:21:49.000000000","message":"You should retain this line","commit_id":"9efbc94e963613a617631d27917ba278429566f5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ac09e19adc58430cdb542566f6dca56e3b25ec4","unresolved":true,"context_lines":[{"line_number":445,"context_line":"        self.assertEqual(\u0027error\u0027, share_alt_updated[\u0027access_rules_status\u0027])"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    @decorators.idempotent_id(\u00271a9f46f0-d4e1-40ac-8726-aedd0320d583\u0027)"},{"line_number":448,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":449,"context_line":"    def test_can_apply_new_cephx_rules_when_one_is_in_error_state(self):"},{"line_number":450,"context_line":"        # Create share on \"primary\" tenant"},{"line_number":451,"context_line":"        share_primary \u003d self.create_share()"}],"source_content_type":"text/x-python","patch_set":9,"id":"0cdd4905_2707c491","line":448,"range":{"start_line":448,"start_character":37,"end_line":448,"end_character":44},"updated":"2021-03-16 01:35:04.000000000","message":"This is an unrelated change, please revert","commit_id":"aa8a936e9bda2193d81bfe97ac151c37547a296f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ac09e19adc58430cdb542566f6dca56e3b25ec4","unresolved":true,"context_lines":[{"line_number":483,"context_line":"class ShareRulesNegativeTest(base.BaseSharesMixedTest):"},{"line_number":484,"context_line":"    # Tests independent from rule type and share protocol"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    @classmethod"},{"line_number":487,"context_line":"    def resource_setup(cls):"},{"line_number":488,"context_line":"        super(ShareRulesNegativeTest, cls).resource_setup()"},{"line_number":489,"context_line":"        if not (any(p in CONF.share.enable_ip_rules_for_protocols"},{"line_number":490,"context_line":"                    for p in cls.protocols) or"},{"line_number":491,"context_line":"                any(p in CONF.share.enable_user_rules_for_protocols"}],"source_content_type":"text/x-python","patch_set":9,"id":"775c2499_547c273f","line":488,"range":{"start_line":486,"start_character":4,"end_line":488,"end_character":59},"updated":"2021-03-16 01:35:04.000000000","message":"this is an unrelated changem please revert","commit_id":"aa8a936e9bda2193d81bfe97ac151c37547a296f"}]}