)]}'
{"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0407bed28fc62c07f62955dab693a68ec2fbd83f","unresolved":true,"context_lines":[{"line_number":1238,"context_line":"            server_id\u003dshare_server_id)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"class BaseSharesMixedTest(BaseSharesAdminTest):"},{"line_number":1242,"context_line":"    \"\"\"Base test case class for all Shares API tests with all user roles.\"\"\""},{"line_number":1243,"context_line":"    credentials \u003d (\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027)"},{"line_number":1244,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a8b79641_a80e2327","line":1241,"range":{"start_line":1241,"start_character":0,"end_line":1241,"end_character":47},"updated":"2021-02-11 15:00:14.000000000","message":"This change makes it such that the default share_v1/share_v2 clients are now using the admin user - that\u0027d be incorrect. the reason for this class\u0027s existence was to be able to use the primary user for testing most things, and the admin user optionally.","commit_id":"10508af7921ebc85a74ffdb9a85754bd8738ed3b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"31fc309936f65e39efd9ec2efdc73befab26ff75","unresolved":true,"context_lines":[{"line_number":1238,"context_line":"            server_id\u003dshare_server_id)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"class BaseSharesMixedTest(BaseSharesAdminTest):"},{"line_number":1242,"context_line":"    \"\"\"Base test case class for all Shares API tests with all user roles.\"\"\""},{"line_number":1243,"context_line":"    credentials \u003d (\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027)"},{"line_number":1244,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ca0dff2_6047f275","line":1241,"range":{"start_line":1241,"start_character":0,"end_line":1241,"end_character":47},"in_reply_to":"3d074eaf_d6353938","updated":"2021-02-14 06:30:24.000000000","message":"Thanks for the wording.\nNow it is certainly clearer what the purpose of the class is.","commit_id":"10508af7921ebc85a74ffdb9a85754bd8738ed3b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"ab130b7bf04b472f37100cd6d59278f1051aeb5b","unresolved":true,"context_lines":[{"line_number":1238,"context_line":"            server_id\u003dshare_server_id)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"class BaseSharesMixedTest(BaseSharesAdminTest):"},{"line_number":1242,"context_line":"    \"\"\"Base test case class for all Shares API tests with all user roles.\"\"\""},{"line_number":1243,"context_line":"    credentials \u003d (\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027)"},{"line_number":1244,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d14c19d8_bf45ef37","line":1241,"range":{"start_line":1241,"start_character":0,"end_line":1241,"end_character":47},"in_reply_to":"a8b79641_a80e2327","updated":"2021-02-12 05:57:51.000000000","message":"Why the default is admin user ? it depends on which client you\u0027re using.\nBoth classes initialize admin credential.\nThe clients are initialized in \"setup_clients\" methods and for each user there is a separated client.\nfor admin \u003d\u003e \"admin_shares_client\" for primary \u003d\u003e \"shares_client\".\nBeyond that \"BaseSharesMixedTest\" class is used in many places within the admin test suite.","commit_id":"10508af7921ebc85a74ffdb9a85754bd8738ed3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0806337bf73ad41fdb838d2de6acaca8741400d1","unresolved":true,"context_lines":[{"line_number":1238,"context_line":"            server_id\u003dshare_server_id)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"class BaseSharesMixedTest(BaseSharesAdminTest):"},{"line_number":1242,"context_line":"    \"\"\"Base test case class for all Shares API tests with all user roles.\"\"\""},{"line_number":1243,"context_line":"    credentials \u003d (\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027)"},{"line_number":1244,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3d074eaf_d6353938","line":1241,"range":{"start_line":1241,"start_character":0,"end_line":1241,"end_character":47},"in_reply_to":"bb22507c_2511a425","updated":"2021-02-12 19:50:31.000000000","message":"Ah, I see - I assumed we were initializing the \"default share clients\" (v1/v2) based on the class. However, it\u0027s based on the first value in the \"credentials\" list: https://github.com/openstack/manila-tempest-plugin/blob/540e74ac3da07cf62a00ab7976fb9382cf2e59a8/manila_tempest_tests/tests/api/base.py#L165-L169\n\nSo, because the first value is \"primary\", we get the non-privileged user\u0027s credentials.I like this change then as a simplification. \n\nCan you expand the class\u0027s docstring so the next person doesn\u0027t get confused like me:\n\n\"\"\"Base test case class for all Shares API tests with all user roles.\n\n\n   Tests deriving from this class can use the primary project\u0027s clients \n   (self.shares_client, self.shares_v2_client) and the alt project user\u0027s\n   clients (self.alt_shares_client, self.alt_shares_v2_client) to perform\n   API calls and validations. Although admin clients are available for use,\n   their use should be limited to performing bootstrapping (e.g., creating\n   a share type, or resetting state of a resource, etc.). No API validation\n   must be performed against admin APIs. Use BaseAdminTest as a base class\n   for such tests.\n\"\"\"","commit_id":"10508af7921ebc85a74ffdb9a85754bd8738ed3b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9abc3106eea932f7e72ec966adda972ff7f046bf","unresolved":true,"context_lines":[{"line_number":1238,"context_line":"            server_id\u003dshare_server_id)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"class BaseSharesMixedTest(BaseSharesAdminTest):"},{"line_number":1242,"context_line":"    \"\"\"Base test case class for all Shares API tests with all user roles.\"\"\""},{"line_number":1243,"context_line":"    credentials \u003d (\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027)"},{"line_number":1244,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bb22507c_2511a425","line":1241,"range":{"start_line":1241,"start_character":0,"end_line":1241,"end_character":47},"in_reply_to":"d14c19d8_bf45ef37","updated":"2021-02-12 06:21:23.000000000","message":"So it\u0027s not really accurate to say it\u0027s used for primary user and admin user is optional.","commit_id":"10508af7921ebc85a74ffdb9a85754bd8738ed3b"}]}