)]}'
{"manila_tempest_tests/tests/api/admin/test_multi_backend.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"56fd02cbc24313e6fbbf709f9476108e7050c49a","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                \"driver_handles_share_servers\":"},{"line_number":68,"context_line":"                    CONF.share.multitenancy_enabled,"},{"line_number":69,"context_line":"            }"},{"line_number":70,"context_line":"            st \u003d cls.create_share_type(name\u003dst_name, extra_specs\u003dextra_specs)"},{"line_number":71,"context_line":"            cls.sts.append(st[\"share_type\"])"},{"line_number":72,"context_line":"            st_id \u003d st[\"share_type\"][\"id\"]"},{"line_number":73,"context_line":"            share_data_list.append({\"kwargs\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"79442ca7_84812680","line":70,"range":{"start_line":70,"start_character":21,"end_line":70,"end_character":38},"updated":"2021-03-04 14:46:11.000000000","message":"Formerly you added extra specs onto those already set whereas now you are using only the backend name and DHSS.  Are you sure that we don\u0027t need stuff like the snapshot support capabilities here?","commit_id":"3024bb2bae37a9c2d8cc84fabe998f01f0f434f8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a62d25ea570b4bd62a1951d7c2e05f6ca6310695","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \"driver_handles_share_servers\":"},{"line_number":68,"context_line":"                    CONF.share.multitenancy_enabled,"},{"line_number":69,"context_line":"            }"},{"line_number":70,"context_line":"            st \u003d cls.create_share_type(name\u003dst_name, extra_specs\u003dextra_specs)"},{"line_number":71,"context_line":"            cls.sts.append(st[\"share_type\"])"},{"line_number":72,"context_line":"            st_id \u003d st[\"share_type\"][\"id\"]"},{"line_number":73,"context_line":"            share_data_list.append({\"kwargs\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"386286c6_ff90346e","line":70,"range":{"start_line":70,"start_character":21,"end_line":70,"end_character":38},"in_reply_to":"437e53e1_9817f806","updated":"2021-03-07 07:31:28.000000000","message":"Thanks Goutham,\nThis clean up requires changes in many tests for the reason of using ddt for testing different API versions. \nSo let\u0027s get this patch merged and the clean up will be done later.","commit_id":"3024bb2bae37a9c2d8cc84fabe998f01f0f434f8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"564cfa94c308a42a2de746ac9a5dce60b4659e54","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                \"driver_handles_share_servers\":"},{"line_number":68,"context_line":"                    CONF.share.multitenancy_enabled,"},{"line_number":69,"context_line":"            }"},{"line_number":70,"context_line":"            st \u003d cls.create_share_type(name\u003dst_name, extra_specs\u003dextra_specs)"},{"line_number":71,"context_line":"            cls.sts.append(st[\"share_type\"])"},{"line_number":72,"context_line":"            st_id \u003d st[\"share_type\"][\"id\"]"},{"line_number":73,"context_line":"            share_data_list.append({\"kwargs\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"e40f2459_ecaccb42","line":70,"range":{"start_line":70,"start_character":21,"end_line":70,"end_character":38},"in_reply_to":"79442ca7_84812680","updated":"2021-03-04 15:03:03.000000000","message":"In the existing tests there isn\u0027t snapshot creation. So here we don\u0027t need this capability.\nIn case we extend the tests to snapshot creation, I\u0027ll make the necessary changes.\nBut currently there is no need.","commit_id":"3024bb2bae37a9c2d8cc84fabe998f01f0f434f8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ec0b42055d17b3cd56d0418a743923cb04fe9507","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \"driver_handles_share_servers\":"},{"line_number":68,"context_line":"                    CONF.share.multitenancy_enabled,"},{"line_number":69,"context_line":"            }"},{"line_number":70,"context_line":"            st \u003d cls.create_share_type(name\u003dst_name, extra_specs\u003dextra_specs)"},{"line_number":71,"context_line":"            cls.sts.append(st[\"share_type\"])"},{"line_number":72,"context_line":"            st_id \u003d st[\"share_type\"][\"id\"]"},{"line_number":73,"context_line":"            share_data_list.append({\"kwargs\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"437e53e1_9817f806","line":70,"range":{"start_line":70,"start_character":21,"end_line":70,"end_character":38},"in_reply_to":"886be561_2145fd1f","updated":"2021-03-04 19:17:06.000000000","message":"One of the objectives that we had when we started creating share types on the fly was this. A test can setup whatever extra specs it needs in the share types it creates.\n\nBut we have a bit of an issue here, until API version 2.24, \"snapshot_support\" *is a required extra-spec* and we added ``create_share_from_snapshot_support`` alongside it, defaulting to the value of \"snapshot_support\" - but allowing an override. All other capabilities are added when needed. \n\nI wanted to get this stuff cleaned up. We always seem to create share types with the latest version configured in the config file. API version 2.24 is too old for us to maintain compatibility for. I\u0027ve no problem ensuring that tempest always tests older microversions, but, we can stop supporting setting \"LATEST_MICROVERSION\u003d2.23\" (or lesser). That way, we can fix \"add_extra_specs_to_dict\" to stop adding \"snapshot_support\" and \"create_share_from_snapshot_support\" automatically. We can request them in the snapshot and snapshot cloning tests explicitly.","commit_id":"3024bb2bae37a9c2d8cc84fabe998f01f0f434f8"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9260ca0c9f4aaad815924be4c46e70a38937451e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \"driver_handles_share_servers\":"},{"line_number":68,"context_line":"                    CONF.share.multitenancy_enabled,"},{"line_number":69,"context_line":"            }"},{"line_number":70,"context_line":"            st \u003d cls.create_share_type(name\u003dst_name, extra_specs\u003dextra_specs)"},{"line_number":71,"context_line":"            cls.sts.append(st[\"share_type\"])"},{"line_number":72,"context_line":"            st_id \u003d st[\"share_type\"][\"id\"]"},{"line_number":73,"context_line":"            share_data_list.append({\"kwargs\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"886be561_2145fd1f","line":70,"range":{"start_line":70,"start_character":21,"end_line":70,"end_character":38},"in_reply_to":"e40f2459_ecaccb42","updated":"2021-03-04 16:22:54.000000000","message":"OK, thanks.","commit_id":"3024bb2bae37a9c2d8cc84fabe998f01f0f434f8"}]}