)]}'
{"manila_tempest_tests/tests/api/test_public_shares.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7271bc7f9bd6ab659e30123309023d229c649c92","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(PublicSharesTest, cls).resource_setup()"},{"line_number":29,"context_line":"        # create share_type"},{"line_number":30,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":31,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @decorators.idempotent_id(\u0027557a0474-9e30-47b4-a766-19e2afb13e66\u0027)"},{"line_number":34,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":4,"id":"d3c8bf45_700d7136","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":48},"updated":"2021-02-23 08:06:05.000000000","message":"You can remove cls prefix of share_type variable, it\u0027s only used in this classmethod\nIt\u0027s not critical but I think it\u0027s unnecessary to set two parameters for this.","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf9e112995ca653a300346200c4fb96408c37062","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(PublicSharesTest, cls).resource_setup()"},{"line_number":29,"context_line":"        # create share_type"},{"line_number":30,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":31,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @decorators.idempotent_id(\u0027557a0474-9e30-47b4-a766-19e2afb13e66\u0027)"},{"line_number":34,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":4,"id":"89210028_09e49083","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":48},"in_reply_to":"d3c8bf45_700d7136","updated":"2021-02-23 15:14:42.000000000","message":"Done","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7271bc7f9bd6ab659e30123309023d229c649c92","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            name\u003d\u0027private_share\u0027,"},{"line_number":49,"context_line":"            description\u003d\u0027private share in the primary user project\u0027,"},{"line_number":50,"context_line":"            share_type_id\u003dself.share_type_id,"},{"line_number":51,"context_line":"            is_public\u003dFalse,"},{"line_number":52,"context_line":"            cleanup_in_class\u003dFalse,"},{"line_number":53,"context_line":"            version\u003dLATEST_MICROVERSION"},{"line_number":54,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f5f1357_e864fc9a","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":27},"updated":"2021-02-23 08:06:05.000000000","message":"You can remove it, the default is private","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf9e112995ca653a300346200c4fb96408c37062","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            name\u003d\u0027private_share\u0027,"},{"line_number":49,"context_line":"            description\u003d\u0027private share in the primary user project\u0027,"},{"line_number":50,"context_line":"            share_type_id\u003dself.share_type_id,"},{"line_number":51,"context_line":"            is_public\u003dFalse,"},{"line_number":52,"context_line":"            cleanup_in_class\u003dFalse,"},{"line_number":53,"context_line":"            version\u003dLATEST_MICROVERSION"},{"line_number":54,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"c38d34b4_e3b4e05e","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":27},"in_reply_to":"2f5f1357_e864fc9a","updated":"2021-02-23 15:14:42.000000000","message":"ack, was being explicit for readability","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7271bc7f9bd6ab659e30123309023d229c649c92","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        share \u003d self.create_share(name\u003dshare_name,"},{"line_number":81,"context_line":"                                  description\u003d\u0027a share we will update\u0027,"},{"line_number":82,"context_line":"                                  share_type_id\u003dself.share_type_id,"},{"line_number":83,"context_line":"                                  is_public\u003dFalse,"},{"line_number":84,"context_line":"                                  cleanup_in_class\u003dFalse,"},{"line_number":85,"context_line":"                                  version\u003dLATEST_MICROVERSION)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a1239fe_aeb79fb3","line":83,"range":{"start_line":83,"start_character":34,"end_line":83,"end_character":49},"updated":"2021-02-23 08:06:05.000000000","message":"Same here","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf9e112995ca653a300346200c4fb96408c37062","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        share \u003d self.create_share(name\u003dshare_name,"},{"line_number":81,"context_line":"                                  description\u003d\u0027a share we will update\u0027,"},{"line_number":82,"context_line":"                                  share_type_id\u003dself.share_type_id,"},{"line_number":83,"context_line":"                                  is_public\u003dFalse,"},{"line_number":84,"context_line":"                                  cleanup_in_class\u003dFalse,"},{"line_number":85,"context_line":"                                  version\u003dLATEST_MICROVERSION)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"be896d6e_21ae2035","line":83,"range":{"start_line":83,"start_character":34,"end_line":83,"end_character":49},"in_reply_to":"5a1239fe_aeb79fb3","updated":"2021-02-23 15:14:42.000000000","message":"same","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"}],"manila_tempest_tests/tests/api/test_public_shares_negative.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7271bc7f9bd6ab659e30123309023d229c649c92","unresolved":true,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from tempest import config"},{"line_number":14,"context_line":"from tempest.lib import decorators"},{"line_number":15,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":16,"context_line":"from testtools import testcase as tc"}],"source_content_type":"text/x-python","patch_set":4,"id":"6e602ff7_ef910225","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":26},"updated":"2021-02-23 08:06:05.000000000","message":"You can remove it, it is not used anywhere","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf9e112995ca653a300346200c4fb96408c37062","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from tempest import config"},{"line_number":14,"context_line":"from tempest.lib import decorators"},{"line_number":15,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":16,"context_line":"from testtools import testcase as tc"}],"source_content_type":"text/x-python","patch_set":4,"id":"10c1ceba_53d11ace","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":26},"in_reply_to":"6e602ff7_ef910225","updated":"2021-02-23 15:14:42.000000000","message":"Done","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7271bc7f9bd6ab659e30123309023d229c649c92","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila_tempest_tests.tests.api import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"CONF \u003d config.CONF"},{"line_number":21,"context_line":"LATEST_MICROVERSION \u003d CONF.share.max_api_microversion"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class PublicSharesNegativeTest(base.BaseSharesMixedTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1699887a_19bed3b9","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":53},"updated":"2021-02-23 08:06:05.000000000","message":"You can remove it, it is not used anywhere","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf9e112995ca653a300346200c4fb96408c37062","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila_tempest_tests.tests.api import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"CONF \u003d config.CONF"},{"line_number":21,"context_line":"LATEST_MICROVERSION \u003d CONF.share.max_api_microversion"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class PublicSharesNegativeTest(base.BaseSharesMixedTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"88af3572_b794aa2e","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":53},"in_reply_to":"1699887a_19bed3b9","updated":"2021-02-23 15:14:42.000000000","message":"thanks, done","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7271bc7f9bd6ab659e30123309023d229c649c92","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(PublicSharesNegativeTest, cls).resource_setup()"},{"line_number":29,"context_line":"        # create share_type"},{"line_number":30,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":31,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":32,"context_line":"        # create a public share - manila\u0027s default RBAC only allows"},{"line_number":33,"context_line":"        # administrator users operating at system scope to create public shares"}],"source_content_type":"text/x-python","patch_set":4,"id":"8590b9cb_9001b8b0","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":11},"updated":"2021-02-23 08:06:05.000000000","message":"You can remove cls prefix, it\u0027s only used in this classmethod","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7271bc7f9bd6ab659e30123309023d229c649c92","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        super(PublicSharesNegativeTest, cls).resource_setup()"},{"line_number":29,"context_line":"        # create share_type"},{"line_number":30,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":31,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":32,"context_line":"        # create a public share - manila\u0027s default RBAC only allows"},{"line_number":33,"context_line":"        # administrator users operating at system scope to create public shares"},{"line_number":34,"context_line":"        cls.share \u003d cls.create_share("}],"source_content_type":"text/x-python","patch_set":4,"id":"976f6942_06cfa2f2","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":11},"updated":"2021-02-23 08:06:05.000000000","message":"Same","commit_id":"ff22629dd56a85c504ecf894c31f1731e8b5ce5e"}]}