)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55f29206a8ad68561f21a14cb5b38fddf24137eb","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaixin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-06 16:50:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add share size check when create share with max min size specified in share type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-on: I5ce0fabf59bfca5ebaf0be5ffe9986e2b0480295"},{"line_number":10,"context_line":"Part-of blueprint share-size-limited-by-share-type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4fdd0c70_4e523c87","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":80},"updated":"2021-03-07 21:44:46.000000000","message":"nit: Keep under 50 characters.\n\n Add tests for share size limited by share type\n\nperhaps?","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ad0d88768a15bd4ad13980e721d4d77599dc1a6b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaixin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-06 16:50:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add share size check when create share with max min size specified in share type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-on: I5ce0fabf59bfca5ebaf0be5ffe9986e2b0480295"},{"line_number":10,"context_line":"Part-of blueprint share-size-limited-by-share-type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f28c0292_1a49112c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":80},"in_reply_to":"4fdd0c70_4e523c87","updated":"2021-03-08 02:12:27.000000000","message":"i sounds more concision.","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55f29206a8ad68561f21a14cb5b38fddf24137eb","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add share size check when create share with max min size specified in share type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-on: I5ce0fabf59bfca5ebaf0be5ffe9986e2b0480295"},{"line_number":10,"context_line":"Part-of blueprint share-size-limited-by-share-type"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I14e71ccb5f8f4f1851bc023586d6c96841ad68f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6ee8fb8e_c36835a8","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"updated":"2021-03-07 21:44:46.000000000","message":"Partially implements:","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ad0d88768a15bd4ad13980e721d4d77599dc1a6b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add share size check when create share with max min size specified in share type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-on: I5ce0fabf59bfca5ebaf0be5ffe9986e2b0480295"},{"line_number":10,"context_line":"Part-of blueprint share-size-limited-by-share-type"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I14e71ccb5f8f4f1851bc023586d6c96841ad68f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a67e4cd4_ce69bac1","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"in_reply_to":"6ee8fb8e_c36835a8","updated":"2021-03-08 02:12:27.000000000","message":"Done","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"}],"manila_tempest_tests/tests/api/test_shares_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55f29206a8ad68561f21a14cb5b38fddf24137eb","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        # create share_type"},{"line_number":148,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":149,"context_line":"        cls.share_type_min_2_max_5 \u003d cls._create_share_type("},{"line_number":150,"context_line":"            specs\u003d{\u0027provisioning:max_share_size\u0027: \u00275\u0027,"},{"line_number":151,"context_line":"                   \u0027provisioning:min_share_size\u0027: \u00272\u0027})"},{"line_number":152,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":153,"context_line":"        cls.share_type_min_2_max_5_id \u003d cls.share_type_min_2_max_5[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"d4c163a1_9b21ce80","line":150,"range":{"start_line":150,"start_character":50,"end_line":150,"end_character":53},"updated":"2021-03-07 21:44:46.000000000","message":"int(CONF.share.share_size) + 5","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ad0d88768a15bd4ad13980e721d4d77599dc1a6b","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        # create share_type"},{"line_number":148,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":149,"context_line":"        cls.share_type_min_2_max_5 \u003d cls._create_share_type("},{"line_number":150,"context_line":"            specs\u003d{\u0027provisioning:max_share_size\u0027: \u00275\u0027,"},{"line_number":151,"context_line":"                   \u0027provisioning:min_share_size\u0027: \u00272\u0027})"},{"line_number":152,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":153,"context_line":"        cls.share_type_min_2_max_5_id \u003d cls.share_type_min_2_max_5[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"c8672c6c_52effb4d","line":150,"range":{"start_line":150,"start_character":50,"end_line":150,"end_character":53},"in_reply_to":"d4c163a1_9b21ce80","updated":"2021-03-08 02:12:27.000000000","message":"maybe int(CONF.share.share_size) + 4.","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55f29206a8ad68561f21a14cb5b38fddf24137eb","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":149,"context_line":"        cls.share_type_min_2_max_5 \u003d cls._create_share_type("},{"line_number":150,"context_line":"            specs\u003d{\u0027provisioning:max_share_size\u0027: \u00275\u0027,"},{"line_number":151,"context_line":"                   \u0027provisioning:min_share_size\u0027: \u00272\u0027})"},{"line_number":152,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":153,"context_line":"        cls.share_type_min_2_max_5_id \u003d cls.share_type_min_2_max_5[\u0027id\u0027]"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"63acbb1b_dd35609e","line":151,"range":{"start_line":151,"start_character":51,"end_line":151,"end_character":52},"updated":"2021-03-07 21:44:46.000000000","message":"int(CONF.share.share_size)+1","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ad0d88768a15bd4ad13980e721d4d77599dc1a6b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":149,"context_line":"        cls.share_type_min_2_max_5 \u003d cls._create_share_type("},{"line_number":150,"context_line":"            specs\u003d{\u0027provisioning:max_share_size\u0027: \u00275\u0027,"},{"line_number":151,"context_line":"                   \u0027provisioning:min_share_size\u0027: \u00272\u0027})"},{"line_number":152,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":153,"context_line":"        cls.share_type_min_2_max_5_id \u003d cls.share_type_min_2_max_5[\u0027id\u0027]"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6ad97708_c6e6972b","line":151,"range":{"start_line":151,"start_character":51,"end_line":151,"end_character":52},"in_reply_to":"63acbb1b_dd35609e","updated":"2021-03-08 02:12:27.000000000","message":"Done","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55f29206a8ad68561f21a14cb5b38fddf24137eb","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                          self.shares_client.delete_share, \u0027\u0027)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    @decorators.idempotent_id(\u0027b8097d56-067e-4d7c-8401-31bc7021fe86\u0027)"},{"line_number":285,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":286,"context_line":"    def test_create_share_size_greater_than_specified_in_share_type(self):"},{"line_number":287,"context_line":"        # Should not be able to create share if size too large"},{"line_number":288,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":2,"id":"97d5dd93_87566ce2","line":285,"range":{"start_line":285,"start_character":44,"end_line":285,"end_character":45},"updated":"2021-03-07 21:44:46.000000000","message":"this test must be skipped for microversion less than 2.61","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ad0d88768a15bd4ad13980e721d4d77599dc1a6b","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                          self.shares_client.delete_share, \u0027\u0027)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    @decorators.idempotent_id(\u0027b8097d56-067e-4d7c-8401-31bc7021fe86\u0027)"},{"line_number":285,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":286,"context_line":"    def test_create_share_size_greater_than_specified_in_share_type(self):"},{"line_number":287,"context_line":"        # Should not be able to create share if size too large"},{"line_number":288,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a718e2c1_eb9f2fd1","line":285,"range":{"start_line":285,"start_character":44,"end_line":285,"end_character":45},"in_reply_to":"97d5dd93_87566ce2","updated":"2021-03-08 02:12:27.000000000","message":"Done","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55f29206a8ad68561f21a14cb5b38fddf24137eb","unresolved":true,"context_lines":[{"line_number":287,"context_line":"        # Should not be able to create share if size too large"},{"line_number":288,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":289,"context_line":"                          self.shares_client.create_share,"},{"line_number":290,"context_line":"                          size\u003d6,"},{"line_number":291,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @decorators.idempotent_id(\u0027b8097d56-067e-4d7c-8401-31bc7021fe87\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9e6a274a_674f48f7","line":290,"range":{"start_line":290,"start_character":31,"end_line":290,"end_character":32},"updated":"2021-03-07 21:44:46.000000000","message":"int(CONF.share.share_size) + 6","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ad0d88768a15bd4ad13980e721d4d77599dc1a6b","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        # Should not be able to create share if size too large"},{"line_number":288,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":289,"context_line":"                          self.shares_client.create_share,"},{"line_number":290,"context_line":"                          size\u003d6,"},{"line_number":291,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @decorators.idempotent_id(\u0027b8097d56-067e-4d7c-8401-31bc7021fe87\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d8b7d69e_f06ae236","line":290,"range":{"start_line":290,"start_character":31,"end_line":290,"end_character":32},"in_reply_to":"9e6a274a_674f48f7","updated":"2021-03-08 02:12:27.000000000","message":"Done","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55f29206a8ad68561f21a14cb5b38fddf24137eb","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @decorators.idempotent_id(\u0027b8097d56-067e-4d7c-8401-31bc7021fe87\u0027)"},{"line_number":294,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":295,"context_line":"    def test_create_share_size_less_than_specified_in_share_type(self):"},{"line_number":296,"context_line":"        # Should not be able to create share if size too small"},{"line_number":297,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":2,"id":"453d7053_1757c83b","line":294,"range":{"start_line":294,"start_character":44,"end_line":294,"end_character":45},"updated":"2021-03-07 21:44:46.000000000","message":"this test must be skipped for microversion less than 2.61","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ad0d88768a15bd4ad13980e721d4d77599dc1a6b","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @decorators.idempotent_id(\u0027b8097d56-067e-4d7c-8401-31bc7021fe87\u0027)"},{"line_number":294,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":295,"context_line":"    def test_create_share_size_less_than_specified_in_share_type(self):"},{"line_number":296,"context_line":"        # Should not be able to create share if size too small"},{"line_number":297,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":2,"id":"587ba6de_573071b8","line":294,"range":{"start_line":294,"start_character":44,"end_line":294,"end_character":45},"in_reply_to":"453d7053_1757c83b","updated":"2021-03-08 02:12:27.000000000","message":"Done","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55f29206a8ad68561f21a14cb5b38fddf24137eb","unresolved":true,"context_lines":[{"line_number":295,"context_line":"    def test_create_share_size_less_than_specified_in_share_type(self):"},{"line_number":296,"context_line":"        # Should not be able to create share if size too small"},{"line_number":297,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":298,"context_line":"                          self.shares_client.create_share,"},{"line_number":299,"context_line":"                          size\u003d1,"},{"line_number":300,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"58da1858_9830393f","line":298,"range":{"start_line":298,"start_character":31,"end_line":298,"end_character":44},"updated":"2021-03-07 21:44:46.000000000","message":"shares_v2_client","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ad0d88768a15bd4ad13980e721d4d77599dc1a6b","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    def test_create_share_size_less_than_specified_in_share_type(self):"},{"line_number":296,"context_line":"        # Should not be able to create share if size too small"},{"line_number":297,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":298,"context_line":"                          self.shares_client.create_share,"},{"line_number":299,"context_line":"                          size\u003d1,"},{"line_number":300,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bef359ea_8491d27c","line":298,"range":{"start_line":298,"start_character":31,"end_line":298,"end_character":44},"in_reply_to":"58da1858_9830393f","updated":"2021-03-08 02:12:27.000000000","message":"Done","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55f29206a8ad68561f21a14cb5b38fddf24137eb","unresolved":true,"context_lines":[{"line_number":296,"context_line":"        # Should not be able to create share if size too small"},{"line_number":297,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":298,"context_line":"                          self.shares_client.create_share,"},{"line_number":299,"context_line":"                          size\u003d1,"},{"line_number":300,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"34db6243_67d8e7a1","line":299,"range":{"start_line":299,"start_character":31,"end_line":299,"end_character":32},"updated":"2021-03-07 21:44:46.000000000","message":"int(CONF.share.share_size)","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ad0d88768a15bd4ad13980e721d4d77599dc1a6b","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        # Should not be able to create share if size too small"},{"line_number":297,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":298,"context_line":"                          self.shares_client.create_share,"},{"line_number":299,"context_line":"                          size\u003d1,"},{"line_number":300,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f6d7d9a1_f9fb74f3","line":299,"range":{"start_line":299,"start_character":31,"end_line":299,"end_character":32},"in_reply_to":"34db6243_67d8e7a1","updated":"2021-03-08 02:12:27.000000000","message":"Done","commit_id":"8e362ccd48ae8e4db9a429938c66195631fe6188"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a1738f354c84c2fc6a334760f8c0d1500951f8f7","unresolved":true,"context_lines":[{"line_number":289,"context_line":"    def test_create_share_size_greater_than_specified_in_share_type(self):"},{"line_number":290,"context_line":"        # Should not be able to create share if size too large"},{"line_number":291,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":292,"context_line":"                          self.shares_v2_client.create_share,"},{"line_number":293,"context_line":"                          size\u003dint(CONF.share.share_size) + 5,"},{"line_number":294,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"55e394af_121222a0","line":292,"range":{"start_line":292,"start_character":31,"end_line":292,"end_character":60},"updated":"2021-03-08 17:21:56.000000000","message":"create_share\n\nIf you use the client directly, you\u0027ll need to also include a share network - which you\u0027re not currently doing. If you don\u0027t have a share network, when DHSS\u003dTrue, you\u0027ll get a different HTTP400: https://zuul.opendev.org/t/openstack/build/2a3f8de6c498449b8fc830d77863ce94/log/controller/logs/tempest_log.txt#59239-59243\n\n\nWorks fine when DHSS\u003dFalse:\nhttps://zuul.opendev.org/t/openstack/build/b5b2865405ab46318867b49bdf99f57a/log/controller/logs/tempest_log.txt#35732-35737","commit_id":"b4d5c84d42d6ebaa39b4ac28a233291d61dc9ff9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a3f3548a28136f4b1a8f464f7806e5fec38b7233","unresolved":true,"context_lines":[{"line_number":289,"context_line":"    def test_create_share_size_greater_than_specified_in_share_type(self):"},{"line_number":290,"context_line":"        # Should not be able to create share if size too large"},{"line_number":291,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":292,"context_line":"                          self.shares_v2_client.create_share,"},{"line_number":293,"context_line":"                          size\u003dint(CONF.share.share_size) + 5,"},{"line_number":294,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"0600b3d9_4c19e17c","line":292,"range":{"start_line":292,"start_character":31,"end_line":292,"end_character":60},"in_reply_to":"55e394af_121222a0","updated":"2021-03-09 01:31:18.000000000","message":"yes, i will add DHSS\u003dFalse when create share type.","commit_id":"b4d5c84d42d6ebaa39b4ac28a233291d61dc9ff9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a1738f354c84c2fc6a334760f8c0d1500951f8f7","unresolved":true,"context_lines":[{"line_number":299,"context_line":"    def test_create_share_size_less_than_specified_in_share_type(self):"},{"line_number":300,"context_line":"        # Should not be able to create share if size too small"},{"line_number":301,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":302,"context_line":"                          self.shares_v2_client.create_share,"},{"line_number":303,"context_line":"                          size\u003dint(CONF.share.share_size),"},{"line_number":304,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"28a3d03a_f4762583","line":302,"range":{"start_line":302,"start_character":31,"end_line":302,"end_character":60},"updated":"2021-03-08 17:21:56.000000000","message":"same","commit_id":"b4d5c84d42d6ebaa39b4ac28a233291d61dc9ff9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a3f3548a28136f4b1a8f464f7806e5fec38b7233","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    def test_create_share_size_less_than_specified_in_share_type(self):"},{"line_number":300,"context_line":"        # Should not be able to create share if size too small"},{"line_number":301,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":302,"context_line":"                          self.shares_v2_client.create_share,"},{"line_number":303,"context_line":"                          size\u003dint(CONF.share.share_size),"},{"line_number":304,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4dfac17b_45d48002","line":302,"range":{"start_line":302,"start_character":31,"end_line":302,"end_character":60},"in_reply_to":"28a3d03a_f4762583","updated":"2021-03-09 01:31:18.000000000","message":"Done","commit_id":"b4d5c84d42d6ebaa39b4ac28a233291d61dc9ff9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eade3000250c928b7f7b9722ffe8eefe02782e4d","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":149,"context_line":"        cls.share_type_min_2_max_5 \u003d cls._create_share_type("},{"line_number":150,"context_line":"            specs\u003d{"},{"line_number":151,"context_line":"                \"driver_handles_share_servers\": False,"},{"line_number":152,"context_line":"                \u0027provisioning:max_share_size\u0027: int(CONF.share.share_size) + 4,"},{"line_number":153,"context_line":"                \u0027provisioning:min_share_size\u0027: int(CONF.share.share_size) + 1"},{"line_number":154,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":4,"id":"e93491f6_36d47410","line":151,"range":{"start_line":151,"start_character":16,"end_line":151,"end_character":54},"updated":"2021-03-09 01:42:54.000000000","message":"This would be incorrect. the value of DHSS is configured in tempest.conf: https://opendev.org/openstack/manila-tempest-plugin/src/branch/master/manila_tempest_tests/config.py#L49-L53\n\nIt is automatically added to share types because it is a required extra-spec: https://opendev.org/openstack/manila-tempest-plugin/src/branch/master/manila_tempest_tests/tests/api/base.py#L856-L879","commit_id":"d520cd4b175cd4300d7dfda95e8ad9db8eea8daa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ef11cc1a43432ef9d8acd4e7d3cec95cc5a61c8","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":149,"context_line":"        cls.share_type_min_2_max_5 \u003d cls._create_share_type("},{"line_number":150,"context_line":"            specs\u003d{"},{"line_number":151,"context_line":"                \"driver_handles_share_servers\": False,"},{"line_number":152,"context_line":"                \u0027provisioning:max_share_size\u0027: int(CONF.share.share_size) + 4,"},{"line_number":153,"context_line":"                \u0027provisioning:min_share_size\u0027: int(CONF.share.share_size) + 1"},{"line_number":154,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":4,"id":"8ee6e4bd_59bdbac3","line":151,"range":{"start_line":151,"start_character":16,"end_line":151,"end_character":54},"in_reply_to":"67660b47_30bd5395","updated":"2021-03-09 03:02:56.000000000","message":"Guess what i\u0027m trying to get at is that these tests are agnostic to DHSS driver modes, and should work for both driver modes. So just changing the call below from shares_v2_client.create_share to self.create_share should get you that agnostic behavior","commit_id":"d520cd4b175cd4300d7dfda95e8ad9db8eea8daa"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d05456e05b5ad6bcc847a829f70af2bcbeca4dbc","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":149,"context_line":"        cls.share_type_min_2_max_5 \u003d cls._create_share_type("},{"line_number":150,"context_line":"            specs\u003d{"},{"line_number":151,"context_line":"                \"driver_handles_share_servers\": False,"},{"line_number":152,"context_line":"                \u0027provisioning:max_share_size\u0027: int(CONF.share.share_size) + 4,"},{"line_number":153,"context_line":"                \u0027provisioning:min_share_size\u0027: int(CONF.share.share_size) + 1"},{"line_number":154,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":4,"id":"e5b6eedf_a68a522b","line":151,"range":{"start_line":151,"start_character":16,"end_line":151,"end_character":54},"in_reply_to":"8ee6e4bd_59bdbac3","updated":"2021-03-09 03:11:39.000000000","message":"yes, it will be good for this behavior, i will change it.","commit_id":"d520cd4b175cd4300d7dfda95e8ad9db8eea8daa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6ea3bcf186798cbfae8ca5bb4bfbce897bb8cb9d","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":149,"context_line":"        cls.share_type_min_2_max_5 \u003d cls._create_share_type("},{"line_number":150,"context_line":"            specs\u003d{"},{"line_number":151,"context_line":"                \"driver_handles_share_servers\": False,"},{"line_number":152,"context_line":"                \u0027provisioning:max_share_size\u0027: int(CONF.share.share_size) + 4,"},{"line_number":153,"context_line":"                \u0027provisioning:min_share_size\u0027: int(CONF.share.share_size) + 1"},{"line_number":154,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":4,"id":"67660b47_30bd5395","line":151,"range":{"start_line":151,"start_character":16,"end_line":151,"end_character":54},"in_reply_to":"9e9eb170_69952f68","updated":"2021-03-09 03:01:36.000000000","message":"Sure it updates it, but how will this work for drivers that have (and for CI jobs that configure) DHSS\u003dTrue?","commit_id":"d520cd4b175cd4300d7dfda95e8ad9db8eea8daa"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"53a1dcf97b952d4c0ba79a09cb6b762b5afc338b","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        cls.share_type \u003d cls._create_share_type()"},{"line_number":149,"context_line":"        cls.share_type_min_2_max_5 \u003d cls._create_share_type("},{"line_number":150,"context_line":"            specs\u003d{"},{"line_number":151,"context_line":"                \"driver_handles_share_servers\": False,"},{"line_number":152,"context_line":"                \u0027provisioning:max_share_size\u0027: int(CONF.share.share_size) + 4,"},{"line_number":153,"context_line":"                \u0027provisioning:min_share_size\u0027: int(CONF.share.share_size) + 1"},{"line_number":154,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":4,"id":"9e9eb170_69952f68","line":151,"range":{"start_line":151,"start_character":16,"end_line":151,"end_character":54},"in_reply_to":"e93491f6_36d47410","updated":"2021-03-09 02:05:22.000000000","message":"although  https://opendev.org/openstack/manila-tempest-plugin/src/branch/master/manila_tempest_tests/tests/api/base.py#L864-L866 specifies the dhss by CONF.share.multitenancy_enabled.\nbut https://opendev.org/openstack/manila-tempest-plugin/src/branch/master/manila_tempest_tests/tests/api/base.py#L876-L877 update dhss to false if we specified dhss\u003dFalse in extra specs, no matter what multitenancy_enabled is.\nis that right?","commit_id":"d520cd4b175cd4300d7dfda95e8ad9db8eea8daa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eade3000250c928b7f7b9722ffe8eefe02782e4d","unresolved":true,"context_lines":[{"line_number":290,"context_line":"    def test_create_share_size_greater_than_specified_in_share_type(self):"},{"line_number":291,"context_line":"        # Should not be able to create share if size too large"},{"line_number":292,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":293,"context_line":"                          self.shares_v2_client.create_share,"},{"line_number":294,"context_line":"                          size\u003dint(CONF.share.share_size) + 5,"},{"line_number":295,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"6948c1d8_38700d59","line":293,"range":{"start_line":293,"start_character":26,"end_line":293,"end_character":61},"updated":"2021-03-09 01:42:54.000000000","message":"see comment below","commit_id":"d520cd4b175cd4300d7dfda95e8ad9db8eea8daa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eade3000250c928b7f7b9722ffe8eefe02782e4d","unresolved":true,"context_lines":[{"line_number":300,"context_line":"    def test_create_share_size_less_than_specified_in_share_type(self):"},{"line_number":301,"context_line":"        # Should not be able to create share if size too small"},{"line_number":302,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":303,"context_line":"                          self.shares_v2_client.create_share,"},{"line_number":304,"context_line":"                          size\u003dint(CONF.share.share_size),"},{"line_number":305,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b35fc6eb_fa95a08a","line":303,"range":{"start_line":303,"start_character":26,"end_line":303,"end_character":60},"updated":"2021-03-09 01:42:54.000000000","message":"Change this to self.create_share instead\nbecause create_share handles the share network if it is necessary.","commit_id":"d520cd4b175cd4300d7dfda95e8ad9db8eea8daa"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d05456e05b5ad6bcc847a829f70af2bcbeca4dbc","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    def test_create_share_size_less_than_specified_in_share_type(self):"},{"line_number":301,"context_line":"        # Should not be able to create share if size too small"},{"line_number":302,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":303,"context_line":"                          self.shares_v2_client.create_share,"},{"line_number":304,"context_line":"                          size\u003dint(CONF.share.share_size),"},{"line_number":305,"context_line":"                          share_type_id\u003dself.share_type_min_2_max_5_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3228fc2c_d1538ed0","line":303,"range":{"start_line":303,"start_character":26,"end_line":303,"end_character":60},"in_reply_to":"b35fc6eb_fa95a08a","updated":"2021-03-09 03:11:39.000000000","message":"Done","commit_id":"d520cd4b175cd4300d7dfda95e8ad9db8eea8daa"}]}