)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"185787b8b4f5fcefdf1404c90b3013cc0128250c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"``capability_snapshot_support``"},{"line_number":23,"context_line":"``capability_create_share_from_snapshot_support``"},{"line_number":24,"context_line":"``run_snapshot_tests``"},{"line_number":25,"context_line":"``run_manage_unmanage_snapshot_tests``"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This patch adds a new decorator used to set an attr for each"},{"line_number":28,"context_line":"share feature and skips a test in case the environment does"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"eec13268_165ad5b1","line":25,"updated":"2025-04-22 09:17:50.000000000","message":"Pls add \u0027run_manage_unmanage_tests\u0027 to the removed list","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"``capability_snapshot_support``"},{"line_number":23,"context_line":"``capability_create_share_from_snapshot_support``"},{"line_number":24,"context_line":"``run_snapshot_tests``"},{"line_number":25,"context_line":"``run_manage_unmanage_snapshot_tests``"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This patch adds a new decorator used to set an attr for each"},{"line_number":28,"context_line":"share feature and skips a test in case the environment does"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"378403b9_e042e4aa","line":25,"in_reply_to":"1b1ca443_9e0245db","updated":"2026-01-29 18:58:59.000000000","message":"Done","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"6300a0436df9bafce20ef6fabc184c30585bdd4d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"``capability_snapshot_support``"},{"line_number":23,"context_line":"``capability_create_share_from_snapshot_support``"},{"line_number":24,"context_line":"``run_snapshot_tests``"},{"line_number":25,"context_line":"``run_manage_unmanage_snapshot_tests``"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This patch adds a new decorator used to set an attr for each"},{"line_number":28,"context_line":"share feature and skips a test in case the environment does"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"1b1ca443_9e0245db","line":25,"in_reply_to":"eec13268_165ad5b1","updated":"2025-04-22 10:11:16.000000000","message":"Thanks Vida\nDone","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"5e01cde0827c91fa445d36d63171a6e610102acc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"d0c97442_466749f8","updated":"2021-10-20 14:05:08.000000000","message":"I\u0027m not sure if it\u0027s a problem here, but if you supports multiple backends and not all of them supports the same feature, make sure you define your variables in a way that allows you to test only the features which are supported on each backend.","commit_id":"b0259ae2c6deb8263e5b9edf00804e7baaac0607"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"034628e85e9a63bd1b8ea54642862c73a0e87bf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"2664ee79_01fa0ed3","updated":"2021-10-21 05:57:32.000000000","message":"recheck","commit_id":"b0259ae2c6deb8263e5b9edf00804e7baaac0607"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0ffe5e1c1c8acdfe60872a877834dd46ad6639a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"2ecee50e_a7a0a602","in_reply_to":"d0c97442_466749f8","updated":"2021-10-21 06:52:01.000000000","message":"Yes I already thought about it. I think we can handle it.","commit_id":"b0259ae2c6deb8263e5b9edf00804e7baaac0607"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e03ac840f42026d224a6edffd2e9fa57703cf28e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"ae42b2b1_e4634740","updated":"2024-06-27 23:46:12.000000000","message":"Sorry to come back here after a looong time; but thanks for your patience, Liron. I\u0027ve a couple of comments inline that might make you refactor a bit more.. ptal","commit_id":"1dfcc82e131e48328978c7ddab510591ddf60297"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"917a1ba5e8bfdd1431be5fa1f0ceffebe0f88626","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"7b3045a4_bc3d9cb0","updated":"2024-11-05 19:04:50.000000000","message":"Thank you for working on this change, Liron. That\u0027s a very nice way to approach this issue. I agree with Goutham\u0027s comments though. Could you please take a look and also rebase this change?","commit_id":"1dfcc82e131e48328978c7ddab510591ddf60297"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"16ee9d1c6f39da4bc4fd20f9522c0dc8e2621709","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"cb8f95d6_fb945182","updated":"2024-11-07 09:25:01.000000000","message":"Thanks for reviving this patch!","commit_id":"a4e972142d494bbaa37e0c23bdfb87f2b421dd62"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"185787b8b4f5fcefdf1404c90b3013cc0128250c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"21870822_377d6a07","updated":"2025-04-22 09:17:50.000000000","message":"Checks verified, thanks for the change Liron.","commit_id":"0751ed5c542e3b0000b2988a3162fee1bf8de3cc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"441237452f1ae54d3d7c525076b632ab24863698","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"34fd8de2_5d4a8a0b","updated":"2025-03-27 11:58:44.000000000","message":"LGTM, thanks for your patience with this change, Liron!\nApparently we got unlucky in the first run with the LVM driver jobs, let\u0027s see how the second run goes.","commit_id":"0751ed5c542e3b0000b2988a3162fee1bf8de3cc"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"bfbb38e7b5ac9cefb27a376210d2993e79b5c838","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"e45df875_353579bf","updated":"2025-03-27 11:44:28.000000000","message":"recheck","commit_id":"0751ed5c542e3b0000b2988a3162fee1bf8de3cc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"347200959ea50c2d833b3e1295ab4fe9828b03ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"43cbaf7b_d0628042","updated":"2026-01-06 15:46:30.000000000","message":"Hey, just rebased this change. Let\u0027s get some fresh logs and try getting it merged!","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"619ebd4e500384b8fdfa10ba3bde048bc4d28792","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":32,"id":"9ca95408_f8b9b322","updated":"2026-01-07 20:23:51.000000000","message":"Hi Liron, \n\nMostly LGTM except the snapshot opts:\n\nBefore this commit, there were two snapshot-related options:\n    - [share] run_snapshot_tests - used to skip tests\n    - [share] capability_snapshot_support - used to configure share types\n    \nWith this commit I see that we\u0027re trying to combine the two into one option:\n\n    - [share-feature-enabled] snapshot - used to skip tests, and to configure share types\n    \n\nSo this part needs a bit more work to resolve.. please see comments inline","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"5cc3669a_3c860626","in_reply_to":"539af50f_5686c3fc","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b0c26f6f5ebc08e3289f5885452429888b1d843c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":32,"id":"539af50f_5686c3fc","in_reply_to":"9ca95408_f8b9b322","updated":"2026-01-08 10:56:39.000000000","message":"Thanks, Goutham.\nI hope I’ve addressed all the comments.","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"1210ea3e_52529c4b","updated":"2026-01-29 18:58:59.000000000","message":"I\u0027ll push up a patch to this addressing the comments","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"117302eb_b701b4b6","updated":"2026-01-29 19:12:22.000000000","message":"Thanks for the changes @lkuchlan@redhat.com; i\u0027ll monitor this through this CI run and post updates if necessary.","commit_id":"c74ad76d1dd6f154c26d9a184a719b9a4c75e9fc"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"337f4b79549e2b0c78965380fc1c9bc378239fbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"982b56d4_be7adfbb","updated":"2026-02-05 16:34:21.000000000","message":"Checks passed, thanks for the enhancements.","commit_id":"00026c86fa3e3c415b5aef309a5cdb11ebd14bf0"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e03ac840f42026d224a6edffd2e9fa57703cf28e","unresolved":true,"context_lines":[{"line_number":377,"context_line":"                                   title\u003d\u0027Enabled Share Features\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"ShareFeaturesGroup \u003d ["},{"line_number":380,"context_line":"    cfg.BoolOpt(\u0027snapshot\u0027,"},{"line_number":381,"context_line":"                default\u003dFalse,"},{"line_number":382,"context_line":"                help\u003d\u0027Does the environment support the creation of share \u0027"},{"line_number":383,"context_line":"                     \u0027snapshot?\u0027),"}],"source_content_type":"text/x-python","patch_set":25,"id":"6cd9d0ed_186c0b05","line":380,"range":{"start_line":380,"start_character":16,"end_line":380,"end_character":27},"updated":"2024-06-27 23:46:12.000000000","message":"all these options should include the deprecated names/group (\"share\"): https://docs.openstack.org/oslo.config/latest/reference/deprecating.html \n\nso that we can support the older config options for a few releases..","commit_id":"1dfcc82e131e48328978c7ddab510591ddf60297"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7e07da17d76308db7106e999b29fffd3d2825a09","unresolved":false,"context_lines":[{"line_number":377,"context_line":"                                   title\u003d\u0027Enabled Share Features\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"ShareFeaturesGroup \u003d ["},{"line_number":380,"context_line":"    cfg.BoolOpt(\u0027snapshot\u0027,"},{"line_number":381,"context_line":"                default\u003dFalse,"},{"line_number":382,"context_line":"                help\u003d\u0027Does the environment support the creation of share \u0027"},{"line_number":383,"context_line":"                     \u0027snapshot?\u0027),"}],"source_content_type":"text/x-python","patch_set":25,"id":"41f31ef1_a99b1471","line":380,"range":{"start_line":380,"start_character":16,"end_line":380,"end_character":27},"in_reply_to":"6cd9d0ed_186c0b05","updated":"2024-11-07 09:27:44.000000000","message":"Done","commit_id":"1dfcc82e131e48328978c7ddab510591ddf60297"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"619ebd4e500384b8fdfa10ba3bde048bc4d28792","unresolved":true,"context_lines":[{"line_number":414,"context_line":"share_feature_group \u003d cfg.OptGroup(name\u003d\u0027share-feature-enabled\u0027,"},{"line_number":415,"context_line":"                                   title\u003d\u0027Enabled Share Features\u0027)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"ShareFeaturesGroup \u003d ["},{"line_number":418,"context_line":"    cfg.BoolOpt(\u0027snapshot\u0027,"},{"line_number":419,"context_line":"                deprecated_name\u003d\u0027capability_snapshot_support\u0027,"},{"line_number":420,"context_line":"                deprecated_group\u003d\u0027share\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"be9b3850_c9d38397","line":417,"updated":"2026-01-07 20:23:51.000000000","message":"because these options are replacing older ones we need to have some logic to specify which one wins.. for example, If the config file has:\n\n```\n  [share]\n  run_snapshot_tests \u003d false\n  [share-feature-enabled]\n  snapshot \u003d true\n```\n\nCurrently, there\u0027s no validation to catch this conflicting configuration. Tests will skip inconsistently based on which decorator runs first?","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b0c26f6f5ebc08e3289f5885452429888b1d843c","unresolved":false,"context_lines":[{"line_number":414,"context_line":"share_feature_group \u003d cfg.OptGroup(name\u003d\u0027share-feature-enabled\u0027,"},{"line_number":415,"context_line":"                                   title\u003d\u0027Enabled Share Features\u0027)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"ShareFeaturesGroup \u003d ["},{"line_number":418,"context_line":"    cfg.BoolOpt(\u0027snapshot\u0027,"},{"line_number":419,"context_line":"                deprecated_name\u003d\u0027capability_snapshot_support\u0027,"},{"line_number":420,"context_line":"                deprecated_group\u003d\u0027share\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"ae829fb7_0a8a8e61","line":417,"in_reply_to":"be9b3850_c9d38397","updated":"2026-01-08 10:56:39.000000000","message":"Done","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"619ebd4e500384b8fdfa10ba3bde048bc4d28792","unresolved":true,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"ShareFeaturesGroup \u003d ["},{"line_number":418,"context_line":"    cfg.BoolOpt(\u0027snapshot\u0027,"},{"line_number":419,"context_line":"                deprecated_name\u003d\u0027capability_snapshot_support\u0027,"},{"line_number":420,"context_line":"                deprecated_group\u003d\u0027share\u0027,"},{"line_number":421,"context_line":"                default\u003dFalse,"},{"line_number":422,"context_line":"                help\u003d\u0027Does the environment support the creation of share \u0027"},{"line_number":423,"context_line":"                     \u0027snapshot?\u0027),"}],"source_content_type":"text/x-python","patch_set":32,"id":"d2bb4cee_33c0d3df","line":420,"range":{"start_line":419,"start_character":16,"end_line":420,"end_character":41},"updated":"2026-01-07 20:23:51.000000000","message":"this one is really replacing two options: \"run_snapshot_tests\" and \"capability_snapshot_support\"\n\nHow do we deal with this?\n\nI think this mapping can be done in plugin.py after we register and read the opts:\n\n```\nif conf.share.run_snapshot_tests and not conf.share_feature_enabled.snapshot:\n      conf.set_default(\"snapshot\", conf.share.run_snapshot_tests,\n                      group\u003d\"share_feature_enabled\")\n```\n\nAnd we should be sure to call this out in the release notes..","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b0c26f6f5ebc08e3289f5885452429888b1d843c","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"ShareFeaturesGroup \u003d ["},{"line_number":418,"context_line":"    cfg.BoolOpt(\u0027snapshot\u0027,"},{"line_number":419,"context_line":"                deprecated_name\u003d\u0027capability_snapshot_support\u0027,"},{"line_number":420,"context_line":"                deprecated_group\u003d\u0027share\u0027,"},{"line_number":421,"context_line":"                default\u003dFalse,"},{"line_number":422,"context_line":"                help\u003d\u0027Does the environment support the creation of share \u0027"},{"line_number":423,"context_line":"                     \u0027snapshot?\u0027),"}],"source_content_type":"text/x-python","patch_set":32,"id":"771c04b7_8439c571","line":420,"range":{"start_line":419,"start_character":16,"end_line":420,"end_character":41},"in_reply_to":"d2bb4cee_33c0d3df","updated":"2026-01-08 10:56:39.000000000","message":"Done","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ec4efdd9bdb7076af3f224b1c1e342a47df6110f","unresolved":true,"context_lines":[{"line_number":138,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":139,"context_line":"                deprecated_reason\u003d\"New configuration section for share \""},{"line_number":140,"context_line":"                                  \"features, called \u0027share-feature-enabled\u0027\"),"},{"line_number":141,"context_line":"    cfg.BoolOpt(\"capability_revert_to_snapshot_support\","},{"line_number":142,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":143,"context_line":"                deprecated_reason\u003d\"Redundant configuration option. Please use \""},{"line_number":144,"context_line":"                                  \"\u0027run_revert_to_snapshot_tests\u0027 config \""},{"line_number":145,"context_line":"                                  \"option instead.\","},{"line_number":146,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":147,"context_line":"                     \"capability called \u0027revert_to_snapshot_support\u0027 \""},{"line_number":148,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":149,"context_line":"                     \"Defaults to the value of run_revert_to_snapshot_tests.\"),"},{"line_number":150,"context_line":"    cfg.StrOpt(\"capability_sg_consistent_snapshot_support\","},{"line_number":151,"context_line":"               choices\u003d[\"host\", \"pool\", None],"},{"line_number":152,"context_line":"               help\u003d\"Backend capability to create consistent snapshots of \""}],"source_content_type":"text/x-python","patch_set":37,"id":"23573324_88bf009e","line":149,"range":{"start_line":141,"start_character":0,"end_line":149,"end_character":79},"updated":"2026-01-29 19:11:27.000000000","message":"weird double deprecation.. hopefully we\u0027ll be able to clean this up soon","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":139,"context_line":"                deprecated_reason\u003d\"New configuration section for share \""},{"line_number":140,"context_line":"                                  \"features, called \u0027share-feature-enabled\u0027\"),"},{"line_number":141,"context_line":"    cfg.BoolOpt(\"capability_revert_to_snapshot_support\","},{"line_number":142,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":143,"context_line":"                deprecated_reason\u003d\"Redundant configuration option. Please use \""},{"line_number":144,"context_line":"                                  \"\u0027run_revert_to_snapshot_tests\u0027 config \""},{"line_number":145,"context_line":"                                  \"option instead.\","},{"line_number":146,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":147,"context_line":"                     \"capability called \u0027revert_to_snapshot_support\u0027 \""},{"line_number":148,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":149,"context_line":"                     \"Defaults to the value of run_revert_to_snapshot_tests.\"),"},{"line_number":150,"context_line":"    cfg.StrOpt(\"capability_sg_consistent_snapshot_support\","},{"line_number":151,"context_line":"               choices\u003d[\"host\", \"pool\", None],"},{"line_number":152,"context_line":"               help\u003d\"Backend capability to create consistent snapshots of \""}],"source_content_type":"text/x-python","patch_set":37,"id":"8249ea70_6ecf9aba","line":149,"range":{"start_line":141,"start_character":0,"end_line":149,"end_character":79},"in_reply_to":"23573324_88bf009e","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ec4efdd9bdb7076af3f224b1c1e342a47df6110f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":255,"context_line":"                deprecated_reason\u003d\"New configuration section for share \""},{"line_number":256,"context_line":"                                  \"features, called \u0027share-feature-enabled\u0027\"),"},{"line_number":257,"context_line":"    cfg.BoolOpt(\"run_revert_to_snapshot_tests\","},{"line_number":258,"context_line":"                default\u003dFalse,"},{"line_number":259,"context_line":"                help\u003d\"Defines whether to run tests that revert shares \""},{"line_number":260,"context_line":"                     \"to snapshots or not. Enable this feature if used \""},{"line_number":261,"context_line":"                     \"driver supports it.\"),"},{"line_number":262,"context_line":"    cfg.BoolOpt(\"run_share_group_tests\","},{"line_number":263,"context_line":"                default\u003dTrue,"},{"line_number":264,"context_line":"                deprecated_name\u003d\"run_consistency_group_tests\","}],"source_content_type":"text/x-python","patch_set":37,"id":"718b033b_b9e1cd78","line":261,"range":{"start_line":257,"start_character":0,"end_line":261,"end_character":44},"updated":"2026-01-29 19:11:27.000000000","message":"moved this one too","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ec4efdd9bdb7076af3f224b1c1e342a47df6110f","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":305,"context_line":"                deprecated_reason\u003d\"New configuration section for share \""},{"line_number":306,"context_line":"                                  \"features, called \u0027share-feature-enabled\u0027\"),"},{"line_number":307,"context_line":"    cfg.BoolOpt(\"run_mount_snapshot_tests\","},{"line_number":308,"context_line":"                default\u003dFalse,"},{"line_number":309,"context_line":"                help\u003d\"Enable or disable mountable snapshot tests.\"),"},{"line_number":310,"context_line":"    cfg.BoolOpt(\"run_negative_migration_replica_tests\","},{"line_number":311,"context_line":"                default\u003dFalse,"},{"line_number":312,"context_line":"                help\u003d\"Enable or disable negative migration with replica \""}],"source_content_type":"text/x-python","patch_set":37,"id":"92457f4f_3e6b809a","line":309,"range":{"start_line":307,"start_character":0,"end_line":309,"end_character":68},"updated":"2026-01-29 19:11:27.000000000","message":"moving this one seems easy, i tried that","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":418,"context_line":"    cfg.BoolOpt(\u0027snapshot\u0027,"},{"line_number":419,"context_line":"                deprecated_name\u003d\u0027capability_snapshot_support\u0027,"},{"line_number":420,"context_line":"                deprecated_group\u003d\u0027share\u0027,"},{"line_number":421,"context_line":"                default\u003dFalse,"},{"line_number":422,"context_line":"                help\u003d\u0027Does the environment support the creation of share \u0027"},{"line_number":423,"context_line":"                     \u0027snapshot? This option replaces both \u0027"},{"line_number":424,"context_line":"                     \u0027share.run_snapshot_tests and \u0027"}],"source_content_type":"text/x-python","patch_set":37,"id":"2772d536_ced42863","line":421,"range":{"start_line":421,"start_character":24,"end_line":421,"end_character":29},"updated":"2026-01-29 18:58:59.000000000","message":"This should default to True because the old options that it is replacing defaulted to True","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    cfg.BoolOpt(\u0027snapshot\u0027,"},{"line_number":419,"context_line":"                deprecated_name\u003d\u0027capability_snapshot_support\u0027,"},{"line_number":420,"context_line":"                deprecated_group\u003d\u0027share\u0027,"},{"line_number":421,"context_line":"                default\u003dFalse,"},{"line_number":422,"context_line":"                help\u003d\u0027Does the environment support the creation of share \u0027"},{"line_number":423,"context_line":"                     \u0027snapshot? This option replaces both \u0027"},{"line_number":424,"context_line":"                     \u0027share.run_snapshot_tests and \u0027"}],"source_content_type":"text/x-python","patch_set":37,"id":"b6248d79_7e60b6db","line":421,"range":{"start_line":421,"start_character":24,"end_line":421,"end_character":29},"in_reply_to":"2772d536_ced42863","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/plugin.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"619ebd4e500384b8fdfa10ba3bde048bc4d28792","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_opt_lists(self):"},{"line_number":45,"context_line":"        return [(config_share.share_group.name, config_share.ShareGroup),"},{"line_number":46,"context_line":"                (\u0027service_available\u0027, [config_share.service_option]),"},{"line_number":47,"context_line":"                (\u0027enforce_scope\u0027, [config_share.manila_scope_enforcement])]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_service_clients(self):"}],"source_content_type":"text/x-python","patch_set":32,"id":"badce944_4bd0a8b8","line":46,"updated":"2026-01-07 20:23:51.000000000","message":"```\n(config_share.share_feature_group.name, config_share.ShareFeaturesGroup),\n```\n\nneed to be added here","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b0c26f6f5ebc08e3289f5885452429888b1d843c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_opt_lists(self):"},{"line_number":45,"context_line":"        return [(config_share.share_group.name, config_share.ShareGroup),"},{"line_number":46,"context_line":"                (\u0027service_available\u0027, [config_share.service_option]),"},{"line_number":47,"context_line":"                (\u0027enforce_scope\u0027, [config_share.manila_scope_enforcement])]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_service_clients(self):"}],"source_content_type":"text/x-python","patch_set":32,"id":"7b0bf61a_c6bcf952","line":46,"in_reply_to":"badce944_4bd0a8b8","updated":"2026-01-08 10:56:39.000000000","message":"Done","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"}],"manila_tempest_tests/tests/api/admin/test_admin_actions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e03ac840f42026d224a6edffd2e9fa57703cf28e","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        cls.bad_status \u003d \"error_deleting\""},{"line_number":39,"context_line":"        # create share type"},{"line_number":40,"context_line":"        extra_specs \u003d {}"},{"line_number":41,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":42,"context_line":"                CONF.share.capability_snapshot_support):"},{"line_number":43,"context_line":"            extra_specs.update({\u0027snapshot_support\u0027: True})"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":25,"id":"b2a0d22e_aced3a0c","line":42,"range":{"start_line":41,"start_character":13,"end_line":42,"end_character":54},"updated":"2024-06-27 23:46:12.000000000","message":"we wouldn\u0027t need this if we did the option deprecation via the config..","commit_id":"1dfcc82e131e48328978c7ddab510591ddf60297"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7e07da17d76308db7106e999b29fffd3d2825a09","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.bad_status \u003d \"error_deleting\""},{"line_number":39,"context_line":"        # create share type"},{"line_number":40,"context_line":"        extra_specs \u003d {}"},{"line_number":41,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":42,"context_line":"                CONF.share.capability_snapshot_support):"},{"line_number":43,"context_line":"            extra_specs.update({\u0027snapshot_support\u0027: True})"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":25,"id":"e6bf153d_5cfd4d26","line":42,"range":{"start_line":41,"start_character":13,"end_line":42,"end_character":54},"in_reply_to":"b2a0d22e_aced3a0c","updated":"2024-11-07 09:27:44.000000000","message":"Done","commit_id":"1dfcc82e131e48328978c7ddab510591ddf60297"}],"manila_tempest_tests/tests/api/admin/test_admin_actions_negative.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ffaf61edb887813e600f25d41877f777db606cb8","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            cls.admin_client.get_instances_of_share("},{"line_number":47,"context_line":"                cls.share[\"id\"])[\u0027share_instances\u0027][0]"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":50,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":51,"context_line":"            cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":52,"context_line":"                cls.share[\"id\"], client\u003dcls.admin_client)"}],"source_content_type":"text/x-python","patch_set":29,"id":"3bfcfb26_48ea733c","line":49,"range":{"start_line":49,"start_character":48,"end_line":49,"end_character":50},"updated":"2025-03-26 19:49:30.000000000","message":"maybe and?\nif we have run_snapshot_tests, shouldn\u0027t we ensure that we also have share_feature_enabled.snapshot set to true?","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3632ee02537024448207c86edc5bfaf751ab3a50","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            cls.admin_client.get_instances_of_share("},{"line_number":47,"context_line":"                cls.share[\"id\"])[\u0027share_instances\u0027][0]"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":50,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":51,"context_line":"            cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":52,"context_line":"                cls.share[\"id\"], client\u003dcls.admin_client)"}],"source_content_type":"text/x-python","patch_set":29,"id":"e8f3ed31_7bc0582b","line":49,"range":{"start_line":49,"start_character":48,"end_line":49,"end_character":50},"in_reply_to":"3bfcfb26_48ea733c","updated":"2025-03-27 09:07:35.000000000","message":"run_snapshot_tests is deprecated for removal as you can see here:\nhttps://opendev.org/openstack/manila-tempest-plugin/src/commit/4d18a1486809ed0696ac7f267981388f2f95ec56/manila_tempest_tests/config.py#L244\n\nI think or is the correct operator, but I might be wrong.","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            cls.admin_client.get_instances_of_share("},{"line_number":47,"context_line":"                cls.share[\"id\"])[\u0027share_instances\u0027][0]"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":50,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":51,"context_line":"            cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":52,"context_line":"                cls.share[\"id\"], client\u003dcls.admin_client)"}],"source_content_type":"text/x-python","patch_set":29,"id":"20e1b7c6_19d27386","line":49,"range":{"start_line":49,"start_character":48,"end_line":49,"end_character":50},"in_reply_to":"490a326d_11929ef5","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            cls.admin_client.get_instances_of_share("},{"line_number":47,"context_line":"                cls.share[\"id\"])[\u0027share_instances\u0027][0]"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":50,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":51,"context_line":"            cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":52,"context_line":"                cls.share[\"id\"], client\u003dcls.admin_client)"}],"source_content_type":"text/x-python","patch_set":29,"id":"490a326d_11929ef5","line":49,"range":{"start_line":49,"start_character":48,"end_line":49,"end_character":50},"in_reply_to":"e8f3ed31_7bc0582b","updated":"2026-01-29 18:58:59.000000000","message":"actually we no longer need the second option because of the compatibility code added in plugin.py.","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"}],"manila_tempest_tests/tests/api/admin/test_migration_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":324,"context_line":"        property_to_evaluate \u003d {"},{"line_number":325,"context_line":"            \u0027extend_share\u0027: CONF.share.run_extend_tests,"},{"line_number":326,"context_line":"            \u0027shrink_share\u0027: CONF.share.run_shrink_tests,"},{"line_number":327,"context_line":"            \u0027create_snapshot\u0027: (CONF.share_feature_enabled.snapshot or"},{"line_number":328,"context_line":"                                CONF.share.run_snapshot_tests),"},{"line_number":329,"context_line":"        }"},{"line_number":330,"context_line":"        if not property_to_evaluate[method_name]:"},{"line_number":331,"context_line":"            raise self.skipException(method_name + \u0027tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"4a707165_6dcf4658","line":328,"range":{"start_line":327,"start_character":31,"end_line":328,"end_character":63},"updated":"2026-01-29 18:58:59.000000000","message":"this needs to only use `CONF.share_feature_enabled.snapshot`","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        property_to_evaluate \u003d {"},{"line_number":325,"context_line":"            \u0027extend_share\u0027: CONF.share.run_extend_tests,"},{"line_number":326,"context_line":"            \u0027shrink_share\u0027: CONF.share.run_shrink_tests,"},{"line_number":327,"context_line":"            \u0027create_snapshot\u0027: (CONF.share_feature_enabled.snapshot or"},{"line_number":328,"context_line":"                                CONF.share.run_snapshot_tests),"},{"line_number":329,"context_line":"        }"},{"line_number":330,"context_line":"        if not property_to_evaluate[method_name]:"},{"line_number":331,"context_line":"            raise self.skipException(method_name + \u0027tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"fb8128c1_9a6cf25b","line":328,"range":{"start_line":327,"start_character":31,"end_line":328,"end_character":63},"in_reply_to":"4a707165_6dcf4658","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/admin/test_share_snapshot_instances.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ffaf61edb887813e600f25d41877f777db606cb8","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(ShareSnapshotInstancesTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":35,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":36,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ce44891f_1a911e03","line":34,"range":{"start_line":34,"start_character":52,"end_line":34,"end_character":54},"updated":"2025-03-26 19:49:30.000000000","message":"same as the question in the other file :)","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"441237452f1ae54d3d7c525076b632ab24863698","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(ShareSnapshotInstancesTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":35,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":36,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"5bc80b9f_5d2588f1","line":34,"range":{"start_line":34,"start_character":52,"end_line":34,"end_character":54},"in_reply_to":"6e6df0b2_e167f28f","updated":"2025-03-27 11:58:44.000000000","message":"Acknowledged","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3632ee02537024448207c86edc5bfaf751ab3a50","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(ShareSnapshotInstancesTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":35,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":36,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"6e6df0b2_e167f28f","line":34,"range":{"start_line":34,"start_character":52,"end_line":34,"end_character":54},"in_reply_to":"ce44891f_1a911e03","updated":"2025-03-27 09:07:35.000000000","message":"same","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"}],"manila_tempest_tests/tests/api/admin/test_snapshot_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    def skip_checks(cls):"},{"line_number":34,"context_line":"        super(SnapshotExportLocationsTest, cls).skip_checks()"},{"line_number":35,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":36,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":37,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":38,"context_line":"        if not CONF.share.run_mount_snapshot_tests:"},{"line_number":39,"context_line":"            raise cls.skipException(\u0027Mountable snapshots tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"ef63f757_1e604d10","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":47},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def skip_checks(cls):"},{"line_number":34,"context_line":"        super(SnapshotExportLocationsTest, cls).skip_checks()"},{"line_number":35,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":36,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":37,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":38,"context_line":"        if not CONF.share.run_mount_snapshot_tests:"},{"line_number":39,"context_line":"            raise cls.skipException(\u0027Mountable snapshots tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"d154cf04_e61a800f","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":47},"in_reply_to":"ef63f757_1e604d10","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/admin/test_snapshot_export_locations_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(SnapshotExportLocationsNegativeTest, cls).skip_checks()"},{"line_number":32,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":33,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":34,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":35,"context_line":"        if not CONF.share.run_mount_snapshot_tests:"},{"line_number":36,"context_line":"            raise cls.skipException(\u0027Mountable snapshots tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"92ef8376_bc7aea5f","line":33,"range":{"start_line":33,"start_character":16,"end_line":33,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(SnapshotExportLocationsNegativeTest, cls).skip_checks()"},{"line_number":32,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":33,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":34,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":35,"context_line":"        if not CONF.share.run_mount_snapshot_tests:"},{"line_number":36,"context_line":"            raise cls.skipException(\u0027Mountable snapshots tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"5bd041bd_19bf967a","line":33,"range":{"start_line":33,"start_character":16,"end_line":33,"end_character":45},"in_reply_to":"92ef8376_bc7aea5f","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":132,"context_line":"    def skip_checks(cls):"},{"line_number":133,"context_line":"        super(SnapshotExportLocationsAPIOnlyNegativeTest, cls).skip_checks()"},{"line_number":134,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":135,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":136,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":137,"context_line":"        if not CONF.share.run_mount_snapshot_tests:"},{"line_number":138,"context_line":"            raise cls.skipException(\u0027Mountable snapshots tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"e1251ea3_4db59188","line":135,"range":{"start_line":135,"start_character":16,"end_line":135,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def skip_checks(cls):"},{"line_number":133,"context_line":"        super(SnapshotExportLocationsAPIOnlyNegativeTest, cls).skip_checks()"},{"line_number":134,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":135,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":136,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":137,"context_line":"        if not CONF.share.run_mount_snapshot_tests:"},{"line_number":138,"context_line":"            raise cls.skipException(\u0027Mountable snapshots tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"6f94b94f_9bf9de76","line":135,"range":{"start_line":135,"start_character":16,"end_line":135,"end_character":45},"in_reply_to":"e1251ea3_4db59188","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_replication_snapshots.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        if not CONF.share.run_replication_tests:"},{"line_number":36,"context_line":"            raise cls.skipException(\u0027Replication tests are disabled.\u0027)"},{"line_number":37,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":38,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":39,"context_line":"            raise cls.skipException(\u0027Snapshot tests disabled.\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        utils.check_skip_if_microversion_not_supported("}],"source_content_type":"text/x-python","patch_set":37,"id":"6940d4f6_4d3fe303","line":38,"range":{"start_line":38,"start_character":16,"end_line":38,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if not CONF.share.run_replication_tests:"},{"line_number":36,"context_line":"            raise cls.skipException(\u0027Replication tests are disabled.\u0027)"},{"line_number":37,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":38,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":39,"context_line":"            raise cls.skipException(\u0027Snapshot tests disabled.\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        utils.check_skip_if_microversion_not_supported("}],"source_content_type":"text/x-python","patch_set":37,"id":"fd8c8424_fe6b106a","line":38,"range":{"start_line":38,"start_character":16,"end_line":38,"end_character":45},"in_reply_to":"6940d4f6_4d3fe303","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_revert_to_snapshot.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":39,"context_line":"            msg \u003d \"Revert to snapshot tests are disabled.\""},{"line_number":40,"context_line":"            raise cls.skipException(msg)"},{"line_number":41,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":42,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":43,"context_line":"            msg \u003d \"Snapshot tests are disabled.\""},{"line_number":44,"context_line":"            raise cls.skipException(msg)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"bacc79b1_b228216d","line":42,"range":{"start_line":42,"start_character":16,"end_line":42,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            msg \u003d \"Revert to snapshot tests are disabled.\""},{"line_number":40,"context_line":"            raise cls.skipException(msg)"},{"line_number":41,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":42,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":43,"context_line":"            msg \u003d \"Snapshot tests are disabled.\""},{"line_number":44,"context_line":"            raise cls.skipException(msg)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"d1c7a9e6_328c245a","line":42,"range":{"start_line":42,"start_character":16,"end_line":42,"end_character":45},"in_reply_to":"bacc79b1_b228216d","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_revert_to_snapshot_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            msg \u003d \"Revert to snapshot tests are disabled.\""},{"line_number":39,"context_line":"            raise cls.skipException(msg)"},{"line_number":40,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":41,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":42,"context_line":"            msg \u003d \"Snapshot tests are disabled.\""},{"line_number":43,"context_line":"            raise cls.skipException(msg)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"bf8ed570_c2d6b896","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            msg \u003d \"Revert to snapshot tests are disabled.\""},{"line_number":39,"context_line":"            raise cls.skipException(msg)"},{"line_number":40,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":41,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":42,"context_line":"            msg \u003d \"Snapshot tests are disabled.\""},{"line_number":43,"context_line":"            raise cls.skipException(msg)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"2f1bfc7e_23dcc84b","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":45},"in_reply_to":"bf8ed570_c2d6b896","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_rules_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        # create share_type"},{"line_number":52,"context_line":"        extra_specs \u003d None"},{"line_number":53,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":54,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":55,"context_line":"            extra_specs \u003d {\u0027snapshot_support\u0027: True}"},{"line_number":56,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":57,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":37,"id":"5fb1160a_41c7d5ba","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        # create share_type"},{"line_number":52,"context_line":"        extra_specs \u003d None"},{"line_number":53,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":54,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":55,"context_line":"            extra_specs \u003d {\u0027snapshot_support\u0027: True}"},{"line_number":56,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":57,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":37,"id":"188e79bd_1b3eb016","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":45},"in_reply_to":"5fb1160a_41c7d5ba","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"},{"line_number":60,"context_line":"                                     share_type_id\u003dcls.share_type_id)"},{"line_number":61,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":62,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":63,"context_line":"            # create snapshot"},{"line_number":64,"context_line":"            cls.snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"3134f98e_533a8fbe","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"},{"line_number":60,"context_line":"                                     share_type_id\u003dcls.share_type_id)"},{"line_number":61,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":62,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":63,"context_line":"            # create snapshot"},{"line_number":64,"context_line":"            cls.snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"d7176765_9cca64da","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":45},"in_reply_to":"3134f98e_533a8fbe","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":285,"context_line":"        # create share type"},{"line_number":286,"context_line":"        extra_specs \u003d None"},{"line_number":287,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":288,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":289,"context_line":"            extra_specs \u003d {\u0027snapshot_support\u0027: True}"},{"line_number":290,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":291,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":37,"id":"2b06d2bb_1f4e2cf4","line":288,"range":{"start_line":288,"start_character":16,"end_line":288,"end_character":46},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        # create share type"},{"line_number":286,"context_line":"        extra_specs \u003d None"},{"line_number":287,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":288,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":289,"context_line":"            extra_specs \u003d {\u0027snapshot_support\u0027: True}"},{"line_number":290,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":291,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":37,"id":"d3d148ab_95ed1a6f","line":288,"range":{"start_line":288,"start_character":16,"end_line":288,"end_character":46},"in_reply_to":"2b06d2bb_1f4e2cf4","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"},{"line_number":294,"context_line":"                                     share_type_id\u003dcls.share_type_id)"},{"line_number":295,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":296,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":297,"context_line":"            # create snapshot"},{"line_number":298,"context_line":"            cls.snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"5e8b7f1b_9c6e77a3","line":296,"range":{"start_line":296,"start_character":16,"end_line":296,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"},{"line_number":294,"context_line":"                                     share_type_id\u003dcls.share_type_id)"},{"line_number":295,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":296,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":297,"context_line":"            # create snapshot"},{"line_number":298,"context_line":"            cls.snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"ae7ce5bc_60bb97a2","line":296,"range":{"start_line":296,"start_character":16,"end_line":296,"end_character":45},"in_reply_to":"5e8b7f1b_9c6e77a3","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":414,"context_line":"        # create share type"},{"line_number":415,"context_line":"        extra_specs \u003d None"},{"line_number":416,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":417,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":418,"context_line":"            extra_specs \u003d {\u0027snapshot_support\u0027: True}"},{"line_number":419,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":420,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":37,"id":"3818b841_aec08690","line":417,"range":{"start_line":417,"start_character":16,"end_line":417,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        # create share type"},{"line_number":415,"context_line":"        extra_specs \u003d None"},{"line_number":416,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":417,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":418,"context_line":"            extra_specs \u003d {\u0027snapshot_support\u0027: True}"},{"line_number":419,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":420,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":37,"id":"06c34dd6_a6c374c6","line":417,"range":{"start_line":417,"start_character":16,"end_line":417,"end_character":45},"in_reply_to":"3818b841_aec08690","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":422,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"},{"line_number":423,"context_line":"                                     share_type_id\u003dcls.share_type_id)"},{"line_number":424,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":425,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":426,"context_line":"            # create snapshot"},{"line_number":427,"context_line":"            cls.snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"0b02fb88_f68a74b7","line":425,"range":{"start_line":425,"start_character":17,"end_line":425,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"},{"line_number":423,"context_line":"                                     share_type_id\u003dcls.share_type_id)"},{"line_number":424,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":425,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":426,"context_line":"            # create snapshot"},{"line_number":427,"context_line":"            cls.snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"1ff40288_92e6939a","line":425,"range":{"start_line":425,"start_character":17,"end_line":425,"end_character":45},"in_reply_to":"0b02fb88_f68a74b7","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":613,"context_line":"        # create share type"},{"line_number":614,"context_line":"        extra_specs \u003d None"},{"line_number":615,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":616,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":617,"context_line":"            extra_specs \u003d {\u0027snapshot_support\u0027: True}"},{"line_number":618,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":619,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":37,"id":"2c57803e_5983a496","line":616,"range":{"start_line":616,"start_character":16,"end_line":616,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        # create share type"},{"line_number":614,"context_line":"        extra_specs \u003d None"},{"line_number":615,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":616,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":617,"context_line":"            extra_specs \u003d {\u0027snapshot_support\u0027: True}"},{"line_number":618,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":619,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":37,"id":"bf496534_5caeee3d","line":616,"range":{"start_line":616,"start_character":16,"end_line":616,"end_character":45},"in_reply_to":"2c57803e_5983a496","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":620,"context_line":"        # create share"},{"line_number":621,"context_line":"        cls.share \u003d cls.create_share(share_type_id\u003dcls.share_type_id)"},{"line_number":622,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":623,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":624,"context_line":"            # create snapshot"},{"line_number":625,"context_line":"            cls.snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":626,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"6234eb07_e9376ccd","line":623,"range":{"start_line":623,"start_character":16,"end_line":623,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        # create share"},{"line_number":621,"context_line":"        cls.share \u003d cls.create_share(share_type_id\u003dcls.share_type_id)"},{"line_number":622,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":623,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":624,"context_line":"            # create snapshot"},{"line_number":625,"context_line":"            cls.snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":626,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"f332d39f_22d2e91b","line":623,"range":{"start_line":623,"start_character":16,"end_line":623,"end_character":45},"in_reply_to":"6234eb07_e9376ccd","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_share_groups_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":74,"context_line":"            share_group_id\u003dcls.share_group[\u0027id\u0027],"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":77,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":78,"context_line":"            # Create a share group snapshot of the share group"},{"line_number":79,"context_line":"            cls.sg_snap_name \u003d data_utils.rand_name(\"tempest-sg-snap-name\")"},{"line_number":80,"context_line":"            cls.sg_snap_desc \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"5150e001_ccaada44","line":77,"range":{"start_line":77,"start_character":16,"end_line":77,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            share_group_id\u003dcls.share_group[\u0027id\u0027],"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":77,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":78,"context_line":"            # Create a share group snapshot of the share group"},{"line_number":79,"context_line":"            cls.sg_snap_name \u003d data_utils.rand_name(\"tempest-sg-snap-name\")"},{"line_number":80,"context_line":"            cls.sg_snap_desc \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"b7ce9d3f_dba0ab2e","line":77,"range":{"start_line":77,"start_character":16,"end_line":77,"end_character":45},"in_reply_to":"5150e001_ccaada44","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_shares_actions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        ))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":66,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":67,"context_line":"            # create snapshot"},{"line_number":68,"context_line":"            cls.snap_name \u003d data_utils.rand_name(\"tempest-snapshot-name\")"},{"line_number":69,"context_line":"            cls.snap_desc \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"e3d5dd77_b9c7957a","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        ))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":66,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":67,"context_line":"            # create snapshot"},{"line_number":68,"context_line":"            cls.snap_name \u003d data_utils.rand_name(\"tempest-snapshot-name\")"},{"line_number":69,"context_line":"            cls.snap_desc \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"49c4f337_e89e1842","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":45},"in_reply_to":"e3d5dd77_b9c7957a","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @decorators.idempotent_id(\u0027fd87884d-71a4-4ca8-8b2b-07b4df2de3bd\u0027)"},{"line_number":339,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":340,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":341,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":342,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027, \u0027share_from_snapshot\u0027)"},{"line_number":343,"context_line":"    def test_list_shares_with_detail_filter_by_snapshot_id(self):"},{"line_number":344,"context_line":"        filters \u003d {\u0027snapshot_id\u0027: self.snap[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":37,"id":"e66bac0c_ace61cc6","line":341,"range":{"start_line":340,"start_character":4,"end_line":341,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @decorators.idempotent_id(\u0027fd87884d-71a4-4ca8-8b2b-07b4df2de3bd\u0027)"},{"line_number":339,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":340,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":341,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":342,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027, \u0027share_from_snapshot\u0027)"},{"line_number":343,"context_line":"    def test_list_shares_with_detail_filter_by_snapshot_id(self):"},{"line_number":344,"context_line":"        filters \u003d {\u0027snapshot_id\u0027: self.snap[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":37,"id":"86e95106_9bb6fc32","line":341,"range":{"start_line":340,"start_character":4,"end_line":341,"end_character":57},"in_reply_to":"e66bac0c_ace61cc6","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    @decorators.idempotent_id(\u0027174829eb-fd3e-46ef-880b-f05c3d44d1fe\u0027)"},{"line_number":450,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":451,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":452,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":453,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":454,"context_line":"    @ddt.data(None, \u00272.16\u0027, LATEST_MICROVERSION)"},{"line_number":455,"context_line":"    def test_get_snapshot(self, version):"}],"source_content_type":"text/x-python","patch_set":37,"id":"32dfa19d_6c75d73e","line":452,"range":{"start_line":451,"start_character":4,"end_line":452,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    @decorators.idempotent_id(\u0027174829eb-fd3e-46ef-880b-f05c3d44d1fe\u0027)"},{"line_number":450,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":451,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":452,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":453,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":454,"context_line":"    @ddt.data(None, \u00272.16\u0027, LATEST_MICROVERSION)"},{"line_number":455,"context_line":"    def test_get_snapshot(self, version):"}],"source_content_type":"text/x-python","patch_set":37,"id":"1acde78f_6d5a6b3f","line":452,"range":{"start_line":451,"start_character":4,"end_line":452,"end_character":57},"in_reply_to":"32dfa19d_6c75d73e","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    @decorators.idempotent_id(\u00273d5d85ff-6158-4af2-a765-cfa07a46adde\u0027)"},{"line_number":511,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":512,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":513,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":514,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":515,"context_line":"    def test_list_snapshots(self):"},{"line_number":516,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"3b57a4a2_f344de51","line":513,"range":{"start_line":512,"start_character":4,"end_line":513,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    @decorators.idempotent_id(\u00273d5d85ff-6158-4af2-a765-cfa07a46adde\u0027)"},{"line_number":511,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":512,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":513,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":514,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":515,"context_line":"    def test_list_snapshots(self):"},{"line_number":516,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"1814b9ee_9b902504","line":513,"range":{"start_line":512,"start_character":4,"end_line":513,"end_character":57},"in_reply_to":"3b57a4a2_f344de51","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":528,"context_line":""},{"line_number":529,"context_line":"    @decorators.idempotent_id(\u00274d717665-e4ca-47df-b4b9-f6d096159779\u0027)"},{"line_number":530,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":531,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":532,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":533,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":534,"context_line":"    @ddt.data(None, \u00272.16\u0027, \u00272.36\u0027, LATEST_MICROVERSION)"},{"line_number":535,"context_line":"    def test_list_snapshots_with_detail(self, version):"}],"source_content_type":"text/x-python","patch_set":37,"id":"bb22782f_ef7e80b7","line":532,"range":{"start_line":531,"start_character":4,"end_line":532,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":528,"context_line":""},{"line_number":529,"context_line":"    @decorators.idempotent_id(\u00274d717665-e4ca-47df-b4b9-f6d096159779\u0027)"},{"line_number":530,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":531,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":532,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":533,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":534,"context_line":"    @ddt.data(None, \u00272.16\u0027, \u00272.36\u0027, LATEST_MICROVERSION)"},{"line_number":535,"context_line":"    def test_list_snapshots_with_detail(self, version):"}],"source_content_type":"text/x-python","patch_set":37,"id":"9aee330d_f6bc5afb","line":532,"range":{"start_line":531,"start_character":4,"end_line":532,"end_character":57},"in_reply_to":"bb22782f_ef7e80b7","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    @decorators.idempotent_id(\u002780497a21-7533-47b5-93aa-29e0f7924cb9\u0027)"},{"line_number":569,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":570,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":571,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":572,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":573,"context_line":"    def test_list_snapshots_with_detail_use_limit(self):"},{"line_number":574,"context_line":"        for limit, offset in [(\u00271\u0027, \u00271\u0027), (\u00270\u0027, \u00271\u0027)]:"}],"source_content_type":"text/x-python","patch_set":37,"id":"0150e72e_eef0f63a","line":571,"range":{"start_line":570,"start_character":4,"end_line":571,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    @decorators.idempotent_id(\u002780497a21-7533-47b5-93aa-29e0f7924cb9\u0027)"},{"line_number":569,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":570,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":571,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":572,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":573,"context_line":"    def test_list_snapshots_with_detail_use_limit(self):"},{"line_number":574,"context_line":"        for limit, offset in [(\u00271\u0027, \u00271\u0027), (\u00270\u0027, \u00271\u0027)]:"}],"source_content_type":"text/x-python","patch_set":37,"id":"d9551ff3_17782721","line":571,"range":{"start_line":570,"start_character":4,"end_line":571,"end_character":57},"in_reply_to":"0150e72e_eef0f63a","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    @decorators.idempotent_id(\u00270a94e996-c4db-4fef-b486-4004ea65c11a\u0027)"},{"line_number":597,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":598,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":599,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":600,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":601,"context_line":"    def test_list_snapshots_with_detail_filter_by_status_and_name(self):"},{"line_number":602,"context_line":"        filters \u003d {\u0027status\u0027: \u0027available\u0027, \u0027name\u0027: self.snap_name}"}],"source_content_type":"text/x-python","patch_set":37,"id":"356d5584_08e17046","line":599,"range":{"start_line":598,"start_character":4,"end_line":599,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    @decorators.idempotent_id(\u00270a94e996-c4db-4fef-b486-4004ea65c11a\u0027)"},{"line_number":597,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":598,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":599,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":600,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":601,"context_line":"    def test_list_snapshots_with_detail_filter_by_status_and_name(self):"},{"line_number":602,"context_line":"        filters \u003d {\u0027status\u0027: \u0027available\u0027, \u0027name\u0027: self.snap_name}"}],"source_content_type":"text/x-python","patch_set":37,"id":"d68015f4_b013cde3","line":599,"range":{"start_line":598,"start_character":4,"end_line":599,"end_character":57},"in_reply_to":"356d5584_08e17046","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    @decorators.idempotent_id(\u0027f969aba1-d293-48e3-a638-a89785bb41ef\u0027)"},{"line_number":615,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":616,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":617,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":618,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":619,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.35\")"},{"line_number":620,"context_line":"    def test_list_snapshots_with_detail_filter_by_description(self):"}],"source_content_type":"text/x-python","patch_set":37,"id":"b2796a2f_16510892","line":617,"range":{"start_line":616,"start_character":4,"end_line":617,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    @decorators.idempotent_id(\u0027f969aba1-d293-48e3-a638-a89785bb41ef\u0027)"},{"line_number":615,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":616,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":617,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":618,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":619,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.35\")"},{"line_number":620,"context_line":"    def test_list_snapshots_with_detail_filter_by_description(self):"}],"source_content_type":"text/x-python","patch_set":37,"id":"e27b5696_f6598d77","line":617,"range":{"start_line":616,"start_character":4,"end_line":617,"end_character":57},"in_reply_to":"b2796a2f_16510892","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    @decorators.idempotent_id(\u002759968026-12af-4029-a3d0-42c291b7db96\u0027)"},{"line_number":633,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":634,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":635,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":636,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":637,"context_line":"    def test_list_snapshots_with_detail_and_asc_sorting(self):"},{"line_number":638,"context_line":"        filters \u003d {\u0027sort_key\u0027: \u0027share_id\u0027, \u0027sort_dir\u0027: \u0027asc\u0027}"}],"source_content_type":"text/x-python","patch_set":37,"id":"84f5c316_950d2426","line":635,"range":{"start_line":634,"start_character":4,"end_line":635,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    @decorators.idempotent_id(\u002759968026-12af-4029-a3d0-42c291b7db96\u0027)"},{"line_number":633,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":634,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":635,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":636,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":637,"context_line":"    def test_list_snapshots_with_detail_and_asc_sorting(self):"},{"line_number":638,"context_line":"        filters \u003d {\u0027sort_key\u0027: \u0027share_id\u0027, \u0027sort_dir\u0027: \u0027asc\u0027}"}],"source_content_type":"text/x-python","patch_set":37,"id":"9d2716c0_7cc74962","line":635,"range":{"start_line":634,"start_character":4,"end_line":635,"end_character":57},"in_reply_to":"84f5c316_950d2426","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":768,"context_line":"            share_type_id\u003dcls.share_type_id)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":771,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":772,"context_line":"            # create snapshot"},{"line_number":773,"context_line":"            cls.snap_name \u003d data_utils.rand_name(\"tempest-snapshot-name\")"},{"line_number":774,"context_line":"            cls.snap_desc \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"841b2ae8_fb10f993","line":771,"range":{"start_line":771,"start_character":16,"end_line":771,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":768,"context_line":"            share_type_id\u003dcls.share_type_id)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":771,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":772,"context_line":"            # create snapshot"},{"line_number":773,"context_line":"            cls.snap_name \u003d data_utils.rand_name(\"tempest-snapshot-name\")"},{"line_number":774,"context_line":"            cls.snap_desc \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"f42f7c22_6981adb2","line":771,"range":{"start_line":771,"start_character":16,"end_line":771,"end_character":45},"in_reply_to":"841b2ae8_fb10f993","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    @decorators.idempotent_id(\u002720f299f6-2441-4629-b44e-d791d57f413c\u0027)"},{"line_number":804,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":805,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":806,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":807,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":808,"context_line":"    def test_rename_snapshot(self):"},{"line_number":809,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"b7abcbd8_5fedf003","line":806,"range":{"start_line":805,"start_character":4,"end_line":806,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    @decorators.idempotent_id(\u002720f299f6-2441-4629-b44e-d791d57f413c\u0027)"},{"line_number":804,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":805,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":806,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":807,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":808,"context_line":"    def test_rename_snapshot(self):"},{"line_number":809,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"414ba39f_614d633c","line":806,"range":{"start_line":805,"start_character":4,"end_line":806,"end_character":57},"in_reply_to":"b7abcbd8_5fedf003","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_shares_actions_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":49,"context_line":"            description\u003dcls.share_desc,"},{"line_number":50,"context_line":"            share_type_id\u003dcls.share_type_id)"},{"line_number":51,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":52,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":53,"context_line":"            # create snapshot"},{"line_number":54,"context_line":"            cls.snap_name \u003d data_utils.rand_name(\"tempest-snapshot-name\")"},{"line_number":55,"context_line":"            cls.snap_desc \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"b6135bd0_d3bb4d21","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            description\u003dcls.share_desc,"},{"line_number":50,"context_line":"            share_type_id\u003dcls.share_type_id)"},{"line_number":51,"context_line":"        if (CONF.share_feature_enabled.snapshot or"},{"line_number":52,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":53,"context_line":"            # create snapshot"},{"line_number":54,"context_line":"            cls.snap_name \u003d data_utils.rand_name(\"tempest-snapshot-name\")"},{"line_number":55,"context_line":"            cls.snap_desc \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":37,"id":"f99af81a_3098cc74","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":45},"in_reply_to":"b6135bd0_d3bb4d21","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_shares_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @decorators.idempotent_id(\u0027b9bb8dee-0c7c-4e51-909c-028335b1a6a0\u0027)"},{"line_number":44,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":45,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":46,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":47,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":48,"context_line":"    def test_try_delete_share_with_existing_snapshot(self):"},{"line_number":49,"context_line":"        # share can not be deleted while snapshot exists"}],"source_content_type":"text/x-python","patch_set":37,"id":"1acc093a_38cd2a9c","line":46,"range":{"start_line":45,"start_character":4,"end_line":46,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @decorators.idempotent_id(\u0027b9bb8dee-0c7c-4e51-909c-028335b1a6a0\u0027)"},{"line_number":44,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":45,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":46,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":47,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":48,"context_line":"    def test_try_delete_share_with_existing_snapshot(self):"},{"line_number":49,"context_line":"        # share can not be deleted while snapshot exists"}],"source_content_type":"text/x-python","patch_set":37,"id":"a1216b0b_77f031bd","line":46,"range":{"start_line":45,"start_character":4,"end_line":46,"end_character":57},"in_reply_to":"1acc093a_38cd2a9c","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @decorators.idempotent_id(\u00273df8e2d8-9b79-428d-9d8b-30bc66b5b40e\u0027)"},{"line_number":62,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":63,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":64,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":65,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027, \u0027share_from_snapshot\u0027)"},{"line_number":66,"context_line":"    def test_create_share_from_snap_with_less_size(self):"},{"line_number":67,"context_line":"        # requires minimum 5Gb available space"}],"source_content_type":"text/x-python","patch_set":37,"id":"3081dca7_7b012a71","line":64,"range":{"start_line":63,"start_character":4,"end_line":64,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @decorators.idempotent_id(\u00273df8e2d8-9b79-428d-9d8b-30bc66b5b40e\u0027)"},{"line_number":62,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":63,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":64,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":65,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027, \u0027share_from_snapshot\u0027)"},{"line_number":66,"context_line":"    def test_create_share_from_snap_with_less_size(self):"},{"line_number":67,"context_line":"        # requires minimum 5Gb available space"}],"source_content_type":"text/x-python","patch_set":37,"id":"abc0d1a5_1517b5dd","line":64,"range":{"start_line":63,"start_character":4,"end_line":64,"end_character":57},"in_reply_to":"3081dca7_7b012a71","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":103,"context_line":"    @testtools.skipIf(not CONF.share.multitenancy_enabled,"},{"line_number":104,"context_line":"                      \"Only for multitenancy.\")"},{"line_number":105,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":106,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":107,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027, \u0027share_from_snapshot\u0027)"},{"line_number":108,"context_line":"    def test_create_share_from_snap_with_different_share_network(self):"},{"line_number":109,"context_line":"        # We can\u0027t create a share from a snapshot whose base share does not"}],"source_content_type":"text/x-python","patch_set":37,"id":"f89db4af_721b7f8e","line":106,"range":{"start_line":105,"start_character":4,"end_line":106,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":103,"context_line":"    @testtools.skipIf(not CONF.share.multitenancy_enabled,"},{"line_number":104,"context_line":"                      \"Only for multitenancy.\")"},{"line_number":105,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":106,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":107,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027, \u0027share_from_snapshot\u0027)"},{"line_number":108,"context_line":"    def test_create_share_from_snap_with_different_share_network(self):"},{"line_number":109,"context_line":"        # We can\u0027t create a share from a snapshot whose base share does not"}],"source_content_type":"text/x-python","patch_set":37,"id":"b508da49_a0cc093a","line":106,"range":{"start_line":105,"start_character":4,"end_line":106,"end_character":57},"in_reply_to":"f89db4af_721b7f8e","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @decorators.idempotent_id(\u0027bf303b29-bbcb-4a96-96e9-270e12df58d1\u0027)"},{"line_number":221,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":222,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":223,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":224,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":225,"context_line":"    def test_delete_snapshot_with_wrong_id(self):"},{"line_number":226,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":37,"id":"9af09805_2e3ab5b6","line":223,"range":{"start_line":222,"start_character":4,"end_line":223,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @decorators.idempotent_id(\u0027bf303b29-bbcb-4a96-96e9-270e12df58d1\u0027)"},{"line_number":221,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":222,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":223,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":224,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":225,"context_line":"    def test_delete_snapshot_with_wrong_id(self):"},{"line_number":226,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":37,"id":"a73c8318_bb6e7790","line":223,"range":{"start_line":222,"start_character":4,"end_line":223,"end_character":57},"in_reply_to":"9af09805_2e3ab5b6","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @decorators.idempotent_id(\u002708e5a9c7-45cb-414c-b375-28c335f20ff1\u0027)"},{"line_number":231,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":232,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":233,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":234,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":235,"context_line":"    def test_create_snapshot_with_wrong_id(self):"},{"line_number":236,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":37,"id":"e4fdd2ce_76cca1e7","line":233,"range":{"start_line":232,"start_character":4,"end_line":233,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @decorators.idempotent_id(\u002708e5a9c7-45cb-414c-b375-28c335f20ff1\u0027)"},{"line_number":231,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":232,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":233,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":234,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":235,"context_line":"    def test_create_snapshot_with_wrong_id(self):"},{"line_number":236,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":37,"id":"f9d5c449_68971674","line":233,"range":{"start_line":232,"start_character":4,"end_line":233,"end_character":57},"in_reply_to":"e4fdd2ce_76cca1e7","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_snapshot_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        super(ShareSnapshotMetadataTest, cls).skip_checks()"},{"line_number":29,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.73\")"},{"line_number":30,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":31,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":32,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa922a89_a06074da","line":31,"range":{"start_line":31,"start_character":16,"end_line":31,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(ShareSnapshotMetadataTest, cls).skip_checks()"},{"line_number":29,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.73\")"},{"line_number":30,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":31,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":32,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":37,"id":"6f77f2f4_11644d18","line":31,"range":{"start_line":31,"start_character":16,"end_line":31,"end_character":45},"in_reply_to":"fa922a89_a06074da","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_snapshot_metadata_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        super(ShareSnapshotMetadataNegativeTest, cls).skip_checks()"},{"line_number":32,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.73\")"},{"line_number":33,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":34,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":35,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":37,"id":"3bde8a7e_3450ba13","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(ShareSnapshotMetadataNegativeTest, cls).skip_checks()"},{"line_number":32,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.73\")"},{"line_number":33,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":34,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":35,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":37,"id":"697848c8_dc873408","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":45},"in_reply_to":"3bde8a7e_3450ba13","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_snapshot_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    def skip_checks(cls):"},{"line_number":76,"context_line":"        super(ShareSnapshotIpRulesForNFSTest, cls).skip_checks()"},{"line_number":77,"context_line":"        if not (CONF.share_feature_enabled.snapshot"},{"line_number":78,"context_line":"                or CONF.share.run_snapshot_tests):"},{"line_number":79,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":80,"context_line":"        if not CONF.share.run_mount_snapshot_tests:"},{"line_number":81,"context_line":"            raise cls.skipException(\u0027Mountable snapshots tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"7dec258d_9eb9d9e8","line":78,"range":{"start_line":78,"start_character":16,"end_line":78,"end_character":48},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def skip_checks(cls):"},{"line_number":76,"context_line":"        super(ShareSnapshotIpRulesForNFSTest, cls).skip_checks()"},{"line_number":77,"context_line":"        if not (CONF.share_feature_enabled.snapshot"},{"line_number":78,"context_line":"                or CONF.share.run_snapshot_tests):"},{"line_number":79,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":80,"context_line":"        if not CONF.share.run_mount_snapshot_tests:"},{"line_number":81,"context_line":"            raise cls.skipException(\u0027Mountable snapshots tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"e2a72801_9abe7077","line":78,"range":{"start_line":78,"start_character":16,"end_line":78,"end_character":48},"in_reply_to":"7dec258d_9eb9d9e8","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/api/test_snapshot_rules_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    def skip_checks(cls):"},{"line_number":37,"context_line":"        super(SnapshotIpRulesForNFSNegativeTest, cls).skip_checks()"},{"line_number":38,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":39,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":40,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":41,"context_line":"        if not CONF.share.run_mount_snapshot_tests:"},{"line_number":42,"context_line":"            raise cls.skipException(\u0027Mountable snapshots tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"e891faa7_3440a6b6","line":39,"range":{"start_line":39,"start_character":16,"end_line":39,"end_character":45},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def skip_checks(cls):"},{"line_number":37,"context_line":"        super(SnapshotIpRulesForNFSNegativeTest, cls).skip_checks()"},{"line_number":38,"context_line":"        if not (CONF.share_feature_enabled.snapshot or"},{"line_number":39,"context_line":"                CONF.share.run_snapshot_tests):"},{"line_number":40,"context_line":"            raise cls.skipException(\u0027Snapshot tests are disabled.\u0027)"},{"line_number":41,"context_line":"        if not CONF.share.run_mount_snapshot_tests:"},{"line_number":42,"context_line":"            raise cls.skipException(\u0027Mountable snapshots tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"51c33db3_bc6de221","line":39,"range":{"start_line":39,"start_character":16,"end_line":39,"end_character":45},"in_reply_to":"e891faa7_3440a6b6","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/tests/scenario/test_share_basic_ops.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":true,"context_lines":[{"line_number":343,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.32\")"},{"line_number":344,"context_line":"    @testtools.skipUnless(CONF.share.run_mount_snapshot_tests,"},{"line_number":345,"context_line":"                          \u0027Mountable snapshots tests are disabled.\u0027)"},{"line_number":346,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":347,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":348,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":349,"context_line":"    def test_read_mountable_snapshot(self):"},{"line_number":350,"context_line":"        # 1 - Create UVM, ok, created"}],"source_content_type":"text/x-python","patch_set":37,"id":"7a03140d_291dcb9c","line":347,"range":{"start_line":346,"start_character":4,"end_line":347,"end_character":57},"updated":"2026-01-29 18:58:59.000000000","message":"can be dropped","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95c3c447cffd8206c79b178c4f90c33b8a5eb98c","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.32\")"},{"line_number":344,"context_line":"    @testtools.skipUnless(CONF.share.run_mount_snapshot_tests,"},{"line_number":345,"context_line":"                          \u0027Mountable snapshots tests are disabled.\u0027)"},{"line_number":346,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":347,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":348,"context_line":"    @utils.is_feature_enabled(\u0027snapshot\u0027)"},{"line_number":349,"context_line":"    def test_read_mountable_snapshot(self):"},{"line_number":350,"context_line":"        # 1 - Create UVM, ok, created"}],"source_content_type":"text/x-python","patch_set":37,"id":"552b57be_c4071688","line":347,"range":{"start_line":346,"start_character":4,"end_line":347,"end_character":57},"in_reply_to":"7a03140d_291dcb9c","updated":"2026-01-29 19:12:22.000000000","message":"Done","commit_id":"1c43cd9c6db931bea30e5397008c3974da16c9f0"}],"manila_tempest_tests/utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e03ac840f42026d224a6edffd2e9fa57703cf28e","unresolved":true,"context_lines":[{"line_number":313,"context_line":"    def decorator(f):"},{"line_number":314,"context_line":"        for feature in args:"},{"line_number":315,"context_line":"            if feature not in share_features:"},{"line_number":316,"context_line":"                raise share_exceptions.ShareFeatureEnabled("},{"line_number":317,"context_line":"                    \u0027%s is not supported\u0027 % feature)"},{"line_number":318,"context_line":"        decorators.attr(type\u003dlist(args))(f)"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"99e6242d_40b949c1","line":316,"range":{"start_line":316,"start_character":39,"end_line":316,"end_character":58},"updated":"2024-06-27 23:46:12.000000000","message":"\"ShareFeatureEnabledError\" perhaps? or \"InvalidShareFeature\"","commit_id":"1dfcc82e131e48328978c7ddab510591ddf60297"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7e07da17d76308db7106e999b29fffd3d2825a09","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    def decorator(f):"},{"line_number":314,"context_line":"        for feature in args:"},{"line_number":315,"context_line":"            if feature not in share_features:"},{"line_number":316,"context_line":"                raise share_exceptions.ShareFeatureEnabled("},{"line_number":317,"context_line":"                    \u0027%s is not supported\u0027 % feature)"},{"line_number":318,"context_line":"        decorators.attr(type\u003dlist(args))(f)"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"31e31876_15913a1d","line":316,"range":{"start_line":316,"start_character":39,"end_line":316,"end_character":58},"in_reply_to":"99e6242d_40b949c1","updated":"2024-11-07 09:27:44.000000000","message":"Done","commit_id":"1dfcc82e131e48328978c7ddab510591ddf60297"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ffaf61edb887813e600f25d41877f777db606cb8","unresolved":true,"context_lines":[{"line_number":294,"context_line":"    return headers, extra_headers"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"share_features \u003d [\u0027snapshot\u0027, \u0027share_from_snapshot\u0027, \u0027revert_to_snapshot\u0027,"},{"line_number":298,"context_line":"                  \u0027manage_share\u0027, \u0027manage_snapshot\u0027]"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"def features(*args):"}],"source_content_type":"text/x-python","patch_set":29,"id":"df8fafb3_b554377c","line":298,"range":{"start_line":297,"start_character":17,"end_line":298,"end_character":52},"updated":"2025-03-26 19:49:30.000000000","message":"should we also do something similar for other features such as migration, replication and so on?","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"347200959ea50c2d833b3e1295ab4fe9828b03ce","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    return headers, extra_headers"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"share_features \u003d [\u0027snapshot\u0027, \u0027share_from_snapshot\u0027, \u0027revert_to_snapshot\u0027,"},{"line_number":298,"context_line":"                  \u0027manage_share\u0027, \u0027manage_snapshot\u0027]"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"def features(*args):"}],"source_content_type":"text/x-python","patch_set":29,"id":"b79a5485_44ae63e1","line":298,"range":{"start_line":297,"start_character":17,"end_line":298,"end_character":52},"in_reply_to":"21768c6a_013d9e6a","updated":"2026-01-06 15:46:30.000000000","message":"Acknowledged","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3632ee02537024448207c86edc5bfaf751ab3a50","unresolved":true,"context_lines":[{"line_number":294,"context_line":"    return headers, extra_headers"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"share_features \u003d [\u0027snapshot\u0027, \u0027share_from_snapshot\u0027, \u0027revert_to_snapshot\u0027,"},{"line_number":298,"context_line":"                  \u0027manage_share\u0027, \u0027manage_snapshot\u0027]"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"def features(*args):"}],"source_content_type":"text/x-python","patch_set":29,"id":"21768c6a_013d9e6a","line":298,"range":{"start_line":297,"start_character":17,"end_line":298,"end_character":52},"in_reply_to":"df8fafb3_b554377c","updated":"2025-03-27 09:07:35.000000000","message":"right, but as I mentioned in the commit message, this is an initial patch.\nanother patch will follow to cover the remaining features.","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ffaf61edb887813e600f25d41877f777db606cb8","unresolved":true,"context_lines":[{"line_number":298,"context_line":"                  \u0027manage_share\u0027, \u0027manage_snapshot\u0027]"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"def features(*args):"},{"line_number":302,"context_line":"    \"\"\"A decorator used to set an attr for each share feature"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    This decorator applies a testtools attr for each share feature."}],"source_content_type":"text/x-python","patch_set":29,"id":"0213f8de_f9563c99","line":301,"range":{"start_line":301,"start_character":4,"end_line":301,"end_character":12},"updated":"2025-03-26 19:49:30.000000000","message":"Nit: this could also be named: is_feature_enabled or something as suggestive for this method. Don\u0027t think this is a big deal though","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3632ee02537024448207c86edc5bfaf751ab3a50","unresolved":true,"context_lines":[{"line_number":298,"context_line":"                  \u0027manage_share\u0027, \u0027manage_snapshot\u0027]"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"def features(*args):"},{"line_number":302,"context_line":"    \"\"\"A decorator used to set an attr for each share feature"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    This decorator applies a testtools attr for each share feature."}],"source_content_type":"text/x-python","patch_set":29,"id":"6493b66a_c7a941d1","line":301,"range":{"start_line":301,"start_character":4,"end_line":301,"end_character":12},"in_reply_to":"0213f8de_f9563c99","updated":"2025-03-27 09:07:35.000000000","message":"right, the name is more clear.","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024604b99cd57a00905a05995374e8252ff531d3","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                  \u0027manage_share\u0027, \u0027manage_snapshot\u0027]"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"def features(*args):"},{"line_number":302,"context_line":"    \"\"\"A decorator used to set an attr for each share feature"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    This decorator applies a testtools attr for each share feature."}],"source_content_type":"text/x-python","patch_set":29,"id":"3ca1b6f6_4f48b234","line":301,"range":{"start_line":301,"start_character":4,"end_line":301,"end_character":12},"in_reply_to":"6493b66a_c7a941d1","updated":"2026-01-29 18:58:59.000000000","message":"Done","commit_id":"4d18a1486809ed0696ac7f267981388f2f95ec56"}],"releasenotes/notes/share-feature-enabled-7683ffd756f15733.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"619ebd4e500384b8fdfa10ba3bde048bc4d28792","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new section option in tempest.conf for manila features called"},{"line_number":5,"context_line":"    \u0027share-feature-enabled\u0027. Under this cofiguration section will be indicated"},{"line_number":6,"context_line":"    the features that are supported by the environment."},{"line_number":7,"context_line":"    For example an environment that supports snapshot creation:"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"afe9bdea_6ecef835","line":5,"range":{"start_line":5,"start_character":40,"end_line":5,"end_character":52},"updated":"2026-01-07 20:23:51.000000000","message":"configuration","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b0c26f6f5ebc08e3289f5885452429888b1d843c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new section option in tempest.conf for manila features called"},{"line_number":5,"context_line":"    \u0027share-feature-enabled\u0027. Under this cofiguration section will be indicated"},{"line_number":6,"context_line":"    the features that are supported by the environment."},{"line_number":7,"context_line":"    For example an environment that supports snapshot creation:"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"3cc796d2_7ada73e3","line":5,"range":{"start_line":5,"start_character":40,"end_line":5,"end_character":52},"in_reply_to":"afe9bdea_6ecef835","updated":"2026-01-08 10:56:39.000000000","message":"Done","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"}],"zuul.d/manila-tempest-jobs.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"619ebd4e500384b8fdfa10ba3bde048bc4d28792","unresolved":true,"context_lines":[{"line_number":281,"context_line":"            share:"},{"line_number":282,"context_line":"              enable_ip_rules_for_protocols: \"\""},{"line_number":283,"context_line":"              run_share_group_tests: false"},{"line_number":284,"context_line":"              run_manage_unmanage_tests: true"},{"line_number":285,"context_line":"              run_shrink_tests: false"},{"line_number":286,"context_line":"              enable_user_rules_for_protocols: cifs"},{"line_number":287,"context_line":"              enable_protocols: cifs"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"d11256c9_d632bd61","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":45},"updated":"2026-01-07 20:23:51.000000000","message":"this option needs to be converted..","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b0c26f6f5ebc08e3289f5885452429888b1d843c","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            share:"},{"line_number":282,"context_line":"              enable_ip_rules_for_protocols: \"\""},{"line_number":283,"context_line":"              run_share_group_tests: false"},{"line_number":284,"context_line":"              run_manage_unmanage_tests: true"},{"line_number":285,"context_line":"              run_shrink_tests: false"},{"line_number":286,"context_line":"              enable_user_rules_for_protocols: cifs"},{"line_number":287,"context_line":"              enable_protocols: cifs"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"37304c0f_fc547783","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":45},"in_reply_to":"d11256c9_d632bd61","updated":"2026-01-08 10:56:39.000000000","message":"Done","commit_id":"2e65ad565cf080fe8b0963a95000ae907984614b"}]}