)]}'
{"manila_tempest_tests/services/share/json/shares_client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"903e5769be32484dc79940b13e9ececf40d889b4","unresolved":true,"context_lines":[{"line_number":106,"context_line":"        resp, body \u003d self.post("},{"line_number":107,"context_line":"            \"os-share-unmanage/%s/unmanage\" % share_id, None)"},{"line_number":108,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":109,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def list_shares(self, detailed\u003dFalse, params\u003dNone):"},{"line_number":112,"context_line":"        \"\"\"Get list of shares w/o filters.\"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"422517d8_054926bb","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":51},"updated":"2021-07-20 19:18:26.000000000","message":"even when we know the body to be empty, for consistency\u0027s sake, why don\u0027t we use:\n\n body \u003d json.loads(body)\n\nin all these methods?","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b307b0a9e30fc8d5c8d8a4bfd2192a609c98e67","unresolved":true,"context_lines":[{"line_number":106,"context_line":"        resp, body \u003d self.post("},{"line_number":107,"context_line":"            \"os-share-unmanage/%s/unmanage\" % share_id, None)"},{"line_number":108,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":109,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def list_shares(self, detailed\u003dFalse, params\u003dNone):"},{"line_number":112,"context_line":"        \"\"\"Get list of shares w/o filters.\"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"0b552170_949cec91","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":51},"in_reply_to":"024599ec_7f11b944","updated":"2021-07-21 17:14:57.000000000","message":"Thanks, in the prior _parse_resp() method we used to handle the body being JSON nil, or python None. Seems like overkill - thanks for checking it works.","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775cec8e4cd305d4ce19de066bb41adf043c0185","unresolved":true,"context_lines":[{"line_number":106,"context_line":"        resp, body \u003d self.post("},{"line_number":107,"context_line":"            \"os-share-unmanage/%s/unmanage\" % share_id, None)"},{"line_number":108,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":109,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def list_shares(self, detailed\u003dFalse, params\u003dNone):"},{"line_number":112,"context_line":"        \"\"\"Get list of shares w/o filters.\"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"024599ec_7f11b944","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":51},"in_reply_to":"422517d8_054926bb","updated":"2021-07-21 07:38:24.000000000","message":"Adding this line will raise JSON Decode Error since nothing retuned.","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"903e5769be32484dc79940b13e9ececf40d889b4","unresolved":true,"context_lines":[{"line_number":349,"context_line":"    def list_extensions(self):"},{"line_number":350,"context_line":"        resp, extensions \u003d self.get(\"extensions\")"},{"line_number":351,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":352,"context_line":"        return self._parse_resp(extensions)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def update_share(self, share_id, name\u003dNone, desc\u003dNone, is_public\u003dNone):"},{"line_number":355,"context_line":"        body \u003d {\"share\": {}}"}],"source_content_type":"text/x-python","patch_set":25,"id":"f8ae1e71_54641016","line":352,"range":{"start_line":352,"start_character":0,"end_line":352,"end_character":43},"updated":"2021-07-20 19:18:26.000000000","message":"shouldn\u0027t this be fixed as well?","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775cec8e4cd305d4ce19de066bb41adf043c0185","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    def list_extensions(self):"},{"line_number":350,"context_line":"        resp, extensions \u003d self.get(\"extensions\")"},{"line_number":351,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":352,"context_line":"        return self._parse_resp(extensions)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def update_share(self, share_id, name\u003dNone, desc\u003dNone, is_public\u003dNone):"},{"line_number":355,"context_line":"        body \u003d {\"share\": {}}"}],"source_content_type":"text/x-python","patch_set":25,"id":"a1b4ba80_35c9cdf0","line":352,"range":{"start_line":352,"start_character":0,"end_line":352,"end_character":43},"in_reply_to":"f8ae1e71_54641016","updated":"2021-07-21 07:38:24.000000000","message":"Done","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"903e5769be32484dc79940b13e9ececf40d889b4","unresolved":true,"context_lines":[{"line_number":423,"context_line":"        if method \u003d\u003d \"put\":"},{"line_number":424,"context_line":"            resp, metadata \u003d self.put(uri, body)"},{"line_number":425,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":426,"context_line":"        return self._parse_resp(metadata)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def set_metadata(self, share_id, metadata\u003dNone):"},{"line_number":429,"context_line":"        return self._update_metadata(share_id, metadata)"}],"source_content_type":"text/x-python","patch_set":25,"id":"99367ca6_07bf0614","line":426,"range":{"start_line":426,"start_character":0,"end_line":426,"end_character":41},"updated":"2021-07-20 19:18:26.000000000","message":"shouldn\u0027t this be fixed as well?","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775cec8e4cd305d4ce19de066bb41adf043c0185","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        if method \u003d\u003d \"put\":"},{"line_number":424,"context_line":"            resp, metadata \u003d self.put(uri, body)"},{"line_number":425,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":426,"context_line":"        return self._parse_resp(metadata)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def set_metadata(self, share_id, metadata\u003dNone):"},{"line_number":429,"context_line":"        return self._update_metadata(share_id, metadata)"}],"source_content_type":"text/x-python","patch_set":25,"id":"008430b4_aed5d647","line":426,"range":{"start_line":426,"start_character":0,"end_line":426,"end_character":41},"in_reply_to":"99367ca6_07bf0614","updated":"2021-07-21 07:38:24.000000000","message":"Done","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"903e5769be32484dc79940b13e9ececf40d889b4","unresolved":true,"context_lines":[{"line_number":434,"context_line":"    def delete_metadata(self, share_id, key):"},{"line_number":435,"context_line":"        resp, body \u003d self.delete(\"shares/%s/metadata/%s\" % (share_id, key))"},{"line_number":436,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":437,"context_line":"        return body"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def get_metadata(self, share_id):"},{"line_number":440,"context_line":"        resp, body \u003d self.get(\"shares/%s/metadata\" % share_id)"}],"source_content_type":"text/x-python","patch_set":25,"id":"b078f0fc_47697a53","line":437,"range":{"start_line":437,"start_character":0,"end_line":437,"end_character":19},"updated":"2021-07-20 19:18:26.000000000","message":"json.loads? and rest_client.ResponseBody","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775cec8e4cd305d4ce19de066bb41adf043c0185","unresolved":true,"context_lines":[{"line_number":434,"context_line":"    def delete_metadata(self, share_id, key):"},{"line_number":435,"context_line":"        resp, body \u003d self.delete(\"shares/%s/metadata/%s\" % (share_id, key))"},{"line_number":436,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":437,"context_line":"        return body"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def get_metadata(self, share_id):"},{"line_number":440,"context_line":"        resp, body \u003d self.get(\"shares/%s/metadata\" % share_id)"}],"source_content_type":"text/x-python","patch_set":25,"id":"7f58de5c_0349e9a5","line":437,"range":{"start_line":437,"start_character":0,"end_line":437,"end_character":19},"in_reply_to":"b078f0fc_47697a53","updated":"2021-07-21 07:38:24.000000000","message":"Only rest_client.ResponseBody according to the reason described above.","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"903e5769be32484dc79940b13e9ececf40d889b4","unresolved":true,"context_lines":[{"line_number":559,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    def add_sec_service_to_share_network(self, sn_id, ss_id):"},{"line_number":562,"context_line":"        body \u003d self._map_security_service_and_share_network(sn_id, ss_id)"},{"line_number":563,"context_line":"        return body"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def remove_sec_service_from_share_network(self, sn_id, ss_id):"},{"line_number":566,"context_line":"        body \u003d self._map_security_service_and_share_network("}],"source_content_type":"text/x-python","patch_set":25,"id":"2370156e_deb7cc34","line":563,"range":{"start_line":562,"start_character":8,"end_line":563,"end_character":19},"updated":"2021-07-20 19:18:26.000000000","message":"the semantics are slightly changed now, the response isn\u0027t really a json \u0027body\u0027, it\u0027s a custom \"ResponseBody\" object.. \n\nwhy don\u0027t we just:\n\n return self._map_security_service_and_share_network(sn_id, ss_id)\n\nand avoid the confusion?","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775cec8e4cd305d4ce19de066bb41adf043c0185","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    def add_sec_service_to_share_network(self, sn_id, ss_id):"},{"line_number":562,"context_line":"        body \u003d self._map_security_service_and_share_network(sn_id, ss_id)"},{"line_number":563,"context_line":"        return body"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def remove_sec_service_from_share_network(self, sn_id, ss_id):"},{"line_number":566,"context_line":"        body \u003d self._map_security_service_and_share_network("}],"source_content_type":"text/x-python","patch_set":25,"id":"cb32a13b_be05c82c","line":563,"range":{"start_line":562,"start_character":8,"end_line":563,"end_character":19},"in_reply_to":"2370156e_deb7cc34","updated":"2021-07-21 07:38:24.000000000","message":"Done","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"903e5769be32484dc79940b13e9ececf40d889b4","unresolved":true,"context_lines":[{"line_number":563,"context_line":"        return body"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def remove_sec_service_from_share_network(self, sn_id, ss_id):"},{"line_number":566,"context_line":"        body \u003d self._map_security_service_and_share_network("},{"line_number":567,"context_line":"            sn_id, ss_id, \"remove\")"},{"line_number":568,"context_line":"        return body"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def list_sec_services_for_share_network(self, sn_id):"},{"line_number":571,"context_line":"        resp, body \u003d self.get(\"security-services?share_network_id\u003d%s\" % sn_id)"}],"source_content_type":"text/x-python","patch_set":25,"id":"c9485a5f_ba30cfd3","line":568,"range":{"start_line":566,"start_character":8,"end_line":568,"end_character":19},"updated":"2021-07-20 19:18:26.000000000","message":"same","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775cec8e4cd305d4ce19de066bb41adf043c0185","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        return body"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def remove_sec_service_from_share_network(self, sn_id, ss_id):"},{"line_number":566,"context_line":"        body \u003d self._map_security_service_and_share_network("},{"line_number":567,"context_line":"            sn_id, ss_id, \"remove\")"},{"line_number":568,"context_line":"        return body"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def list_sec_services_for_share_network(self, sn_id):"},{"line_number":571,"context_line":"        resp, body \u003d self.get(\"security-services?share_network_id\u003d%s\" % sn_id)"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a4beb6e_4bdf5722","line":568,"range":{"start_line":566,"start_character":8,"end_line":568,"end_character":19},"in_reply_to":"c9485a5f_ba30cfd3","updated":"2021-07-21 07:38:24.000000000","message":"Done","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"903e5769be32484dc79940b13e9ececf40d889b4","unresolved":true,"context_lines":[{"line_number":734,"context_line":"            uri +\u003d \"?%s\" % urlparse.urlencode(search_opts)"},{"line_number":735,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":736,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":737,"context_line":"        return json.loads(body)"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"###############"},{"line_number":740,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"cef07353_32581da9","line":737,"range":{"start_line":737,"start_character":8,"end_line":737,"end_character":31},"updated":"2021-07-20 19:18:26.000000000","message":"+ rest_client.ResponseBody conversion","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775cec8e4cd305d4ce19de066bb41adf043c0185","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            uri +\u003d \"?%s\" % urlparse.urlencode(search_opts)"},{"line_number":735,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":736,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":737,"context_line":"        return json.loads(body)"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"###############"},{"line_number":740,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"0c668cca_a3c6e996","line":737,"range":{"start_line":737,"start_character":8,"end_line":737,"end_character":31},"in_reply_to":"cef07353_32581da9","updated":"2021-07-21 07:38:24.000000000","message":"Done","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"903e5769be32484dc79940b13e9ececf40d889b4","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        resp, body \u003d self.post(\"%s/%s/action\" % (s_type, s_id), body,"},{"line_number":138,"context_line":"                               headers\u003dheaders, extra_headers\u003dTrue,"},{"line_number":139,"context_line":"                               version\u003dversion)"},{"line_number":140,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":141,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def force_delete(self, s_id, s_type\u003d\"shares\", headers\u003dNone,"},{"line_number":144,"context_line":"                     version\u003dLATEST_MICROVERSION, action_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":25,"id":"f5b27716_a99afbb4","line":141,"range":{"start_line":140,"start_character":8,"end_line":141,"end_character":8},"updated":"2021-07-20 19:18:26.000000000","message":"same comment as in the v1_client file, for consistency\u0027s sake, always set\n\n body \u003d json.loads(body)\n\nThis also improves the validation that the API middleware is always giving you a JSON response","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775cec8e4cd305d4ce19de066bb41adf043c0185","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        resp, body \u003d self.post(\"%s/%s/action\" % (s_type, s_id), body,"},{"line_number":138,"context_line":"                               headers\u003dheaders, extra_headers\u003dTrue,"},{"line_number":139,"context_line":"                               version\u003dversion)"},{"line_number":140,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":141,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def force_delete(self, s_id, s_type\u003d\"shares\", headers\u003dNone,"},{"line_number":144,"context_line":"                     version\u003dLATEST_MICROVERSION, action_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":25,"id":"7611bd56_e84df5f4","line":141,"range":{"start_line":140,"start_character":8,"end_line":141,"end_character":8},"in_reply_to":"f5b27716_a99afbb4","updated":"2021-07-21 07:38:24.000000000","message":"Adding this line will raise JSON Decode Error since nothing retuned.","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"903e5769be32484dc79940b13e9ececf40d889b4","unresolved":true,"context_lines":[{"line_number":1444,"context_line":""},{"line_number":1445,"context_line":"###############"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"    def migrate_share(self, share_id, host,"},{"line_number":1448,"context_line":"                      force_host_assisted_migration\u003dFalse,"},{"line_number":1449,"context_line":"                      new_share_network_id\u003dNone, writable\u003dFalse,"},{"line_number":1450,"context_line":"                      preserve_metadata\u003dFalse, preserve_snapshots\u003dFalse,"},{"line_number":1451,"context_line":"                      nondisruptive\u003dFalse, new_share_type_id\u003dNone,"},{"line_number":1452,"context_line":"                      version\u003dLATEST_MICROVERSION):"},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"        body \u003d {"},{"line_number":1455,"context_line":"            \u0027migration_start\u0027: {"},{"line_number":1456,"context_line":"                \u0027host\u0027: host,"},{"line_number":1457,"context_line":"                \u0027force_host_assisted_migration\u0027: force_host_assisted_migration,"},{"line_number":1458,"context_line":"                \u0027new_share_network_id\u0027: new_share_network_id,"},{"line_number":1459,"context_line":"                \u0027new_share_type_id\u0027: new_share_type_id,"},{"line_number":1460,"context_line":"                \u0027writable\u0027: writable,"},{"line_number":1461,"context_line":"                \u0027preserve_metadata\u0027: preserve_metadata,"},{"line_number":1462,"context_line":"                \u0027preserve_snapshots\u0027: preserve_snapshots,"},{"line_number":1463,"context_line":"                \u0027nondisruptive\u0027: nondisruptive,"},{"line_number":1464,"context_line":"            }"},{"line_number":1465,"context_line":"        }"},{"line_number":1466,"context_line":""},{"line_number":1467,"context_line":"        body \u003d json.dumps(body)"},{"line_number":1468,"context_line":"        return self.post(\u0027shares/%s/action\u0027 % share_id, body,"},{"line_number":1469,"context_line":"                         headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1470,"context_line":"                         version\u003dversion)"},{"line_number":1471,"context_line":""},{"line_number":1472,"context_line":"    def migration_complete(self, share_id, version\u003dLATEST_MICROVERSION,"},{"line_number":1473,"context_line":"                           action_name\u003d\u0027migration_complete\u0027):"},{"line_number":1474,"context_line":"        post_body \u003d {"},{"line_number":1475,"context_line":"            action_name: None,"},{"line_number":1476,"context_line":"        }"},{"line_number":1477,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":1478,"context_line":"        return self.post(\u0027shares/%s/action\u0027 % share_id, body,"},{"line_number":1479,"context_line":"                         headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1480,"context_line":"                         version\u003dversion)"},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    def migration_cancel(self, share_id, version\u003dLATEST_MICROVERSION,"},{"line_number":1483,"context_line":"                         action_name\u003d\u0027migration_cancel\u0027):"},{"line_number":1484,"context_line":"        post_body \u003d {"},{"line_number":1485,"context_line":"            action_name: None,"},{"line_number":1486,"context_line":"        }"},{"line_number":1487,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":1488,"context_line":"        return self.post(\u0027shares/%s/action\u0027 % share_id, body,"},{"line_number":1489,"context_line":"                         headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1490,"context_line":"                         version\u003dversion)"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"    def migration_get_progress(self, share_id, version\u003dLATEST_MICROVERSION,"},{"line_number":1493,"context_line":"                               action_name\u003d\u0027migration_get_progress\u0027):"},{"line_number":1494,"context_line":"        post_body \u003d {"},{"line_number":1495,"context_line":"            action_name: None,"},{"line_number":1496,"context_line":"        }"},{"line_number":1497,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":1498,"context_line":"        result \u003d self.post(\u0027shares/%s/action\u0027 % share_id, body,"},{"line_number":1499,"context_line":"                           headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1500,"context_line":"                           version\u003dversion)"},{"line_number":1501,"context_line":"        return json.loads(result[1])"},{"line_number":1502,"context_line":""},{"line_number":1503,"context_line":"    def reset_task_state("},{"line_number":1504,"context_line":"            self, share_id, task_state, version\u003dLATEST_MICROVERSION,"},{"line_number":1505,"context_line":"            action_name\u003d\u0027reset_task_state\u0027):"},{"line_number":1506,"context_line":"        post_body \u003d {"},{"line_number":1507,"context_line":"            action_name: {"},{"line_number":1508,"context_line":"                \u0027task_state\u0027: task_state,"},{"line_number":1509,"context_line":"            }"},{"line_number":1510,"context_line":"        }"},{"line_number":1511,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":1512,"context_line":"        return self.post(\u0027shares/%s/action\u0027 % share_id, body,"},{"line_number":1513,"context_line":"                         headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1514,"context_line":"                         version\u003dversion)"},{"line_number":1515,"context_line":""},{"line_number":1516,"context_line":"################"},{"line_number":1517,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"bedcac8f_a7957414","line":1514,"range":{"start_line":1447,"start_character":0,"end_line":1514,"end_character":41},"updated":"2021-07-20 19:18:26.000000000","message":"fix these too?","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775cec8e4cd305d4ce19de066bb41adf043c0185","unresolved":false,"context_lines":[{"line_number":1444,"context_line":""},{"line_number":1445,"context_line":"###############"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"    def migrate_share(self, share_id, host,"},{"line_number":1448,"context_line":"                      force_host_assisted_migration\u003dFalse,"},{"line_number":1449,"context_line":"                      new_share_network_id\u003dNone, writable\u003dFalse,"},{"line_number":1450,"context_line":"                      preserve_metadata\u003dFalse, preserve_snapshots\u003dFalse,"},{"line_number":1451,"context_line":"                      nondisruptive\u003dFalse, new_share_type_id\u003dNone,"},{"line_number":1452,"context_line":"                      version\u003dLATEST_MICROVERSION):"},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"        body \u003d {"},{"line_number":1455,"context_line":"            \u0027migration_start\u0027: {"},{"line_number":1456,"context_line":"                \u0027host\u0027: host,"},{"line_number":1457,"context_line":"                \u0027force_host_assisted_migration\u0027: force_host_assisted_migration,"},{"line_number":1458,"context_line":"                \u0027new_share_network_id\u0027: new_share_network_id,"},{"line_number":1459,"context_line":"                \u0027new_share_type_id\u0027: new_share_type_id,"},{"line_number":1460,"context_line":"                \u0027writable\u0027: writable,"},{"line_number":1461,"context_line":"                \u0027preserve_metadata\u0027: preserve_metadata,"},{"line_number":1462,"context_line":"                \u0027preserve_snapshots\u0027: preserve_snapshots,"},{"line_number":1463,"context_line":"                \u0027nondisruptive\u0027: nondisruptive,"},{"line_number":1464,"context_line":"            }"},{"line_number":1465,"context_line":"        }"},{"line_number":1466,"context_line":""},{"line_number":1467,"context_line":"        body \u003d json.dumps(body)"},{"line_number":1468,"context_line":"        return self.post(\u0027shares/%s/action\u0027 % share_id, body,"},{"line_number":1469,"context_line":"                         headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1470,"context_line":"                         version\u003dversion)"},{"line_number":1471,"context_line":""},{"line_number":1472,"context_line":"    def migration_complete(self, share_id, version\u003dLATEST_MICROVERSION,"},{"line_number":1473,"context_line":"                           action_name\u003d\u0027migration_complete\u0027):"},{"line_number":1474,"context_line":"        post_body \u003d {"},{"line_number":1475,"context_line":"            action_name: None,"},{"line_number":1476,"context_line":"        }"},{"line_number":1477,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":1478,"context_line":"        return self.post(\u0027shares/%s/action\u0027 % share_id, body,"},{"line_number":1479,"context_line":"                         headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1480,"context_line":"                         version\u003dversion)"},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    def migration_cancel(self, share_id, version\u003dLATEST_MICROVERSION,"},{"line_number":1483,"context_line":"                         action_name\u003d\u0027migration_cancel\u0027):"},{"line_number":1484,"context_line":"        post_body \u003d {"},{"line_number":1485,"context_line":"            action_name: None,"},{"line_number":1486,"context_line":"        }"},{"line_number":1487,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":1488,"context_line":"        return self.post(\u0027shares/%s/action\u0027 % share_id, body,"},{"line_number":1489,"context_line":"                         headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1490,"context_line":"                         version\u003dversion)"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"    def migration_get_progress(self, share_id, version\u003dLATEST_MICROVERSION,"},{"line_number":1493,"context_line":"                               action_name\u003d\u0027migration_get_progress\u0027):"},{"line_number":1494,"context_line":"        post_body \u003d {"},{"line_number":1495,"context_line":"            action_name: None,"},{"line_number":1496,"context_line":"        }"},{"line_number":1497,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":1498,"context_line":"        result \u003d self.post(\u0027shares/%s/action\u0027 % share_id, body,"},{"line_number":1499,"context_line":"                           headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1500,"context_line":"                           version\u003dversion)"},{"line_number":1501,"context_line":"        return json.loads(result[1])"},{"line_number":1502,"context_line":""},{"line_number":1503,"context_line":"    def reset_task_state("},{"line_number":1504,"context_line":"            self, share_id, task_state, version\u003dLATEST_MICROVERSION,"},{"line_number":1505,"context_line":"            action_name\u003d\u0027reset_task_state\u0027):"},{"line_number":1506,"context_line":"        post_body \u003d {"},{"line_number":1507,"context_line":"            action_name: {"},{"line_number":1508,"context_line":"                \u0027task_state\u0027: task_state,"},{"line_number":1509,"context_line":"            }"},{"line_number":1510,"context_line":"        }"},{"line_number":1511,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":1512,"context_line":"        return self.post(\u0027shares/%s/action\u0027 % share_id, body,"},{"line_number":1513,"context_line":"                         headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1514,"context_line":"                         version\u003dversion)"},{"line_number":1515,"context_line":""},{"line_number":1516,"context_line":"################"},{"line_number":1517,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"6a062d73_1f6bdd65","line":1514,"range":{"start_line":1447,"start_character":0,"end_line":1514,"end_character":41},"in_reply_to":"bedcac8f_a7957414","updated":"2021-07-21 07:38:24.000000000","message":"Done","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"903e5769be32484dc79940b13e9ececf40d889b4","unresolved":true,"context_lines":[{"line_number":1754,"context_line":"                                 version\u003dLATEST_MICROVERSION):"},{"line_number":1755,"context_line":"        resp, body \u003d self.get(\"snapshots/%s/access-list\" % snapshot_id,"},{"line_number":1756,"context_line":"                              version\u003dversion)"},{"line_number":1757,"context_line":"        body \u003d self._parse_resp(body)"},{"line_number":1758,"context_line":"        found_rules \u003d [r for r in body if r[\u0027id\u0027] \u003d\u003d rule_id]"},{"line_number":1759,"context_line":""},{"line_number":1760,"context_line":"        return found_rules[0] if len(found_rules) \u003e 0 else None"}],"source_content_type":"text/x-python","patch_set":25,"id":"f1b757d4_40b9f55d","line":1757,"range":{"start_line":1757,"start_character":0,"end_line":1757,"end_character":37},"updated":"2021-07-20 19:18:26.000000000","message":"this one?","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775cec8e4cd305d4ce19de066bb41adf043c0185","unresolved":false,"context_lines":[{"line_number":1754,"context_line":"                                 version\u003dLATEST_MICROVERSION):"},{"line_number":1755,"context_line":"        resp, body \u003d self.get(\"snapshots/%s/access-list\" % snapshot_id,"},{"line_number":1756,"context_line":"                              version\u003dversion)"},{"line_number":1757,"context_line":"        body \u003d self._parse_resp(body)"},{"line_number":1758,"context_line":"        found_rules \u003d [r for r in body if r[\u0027id\u0027] \u003d\u003d rule_id]"},{"line_number":1759,"context_line":""},{"line_number":1760,"context_line":"        return found_rules[0] if len(found_rules) \u003e 0 else None"}],"source_content_type":"text/x-python","patch_set":25,"id":"f159ed71_312e92d9","line":1757,"range":{"start_line":1757,"start_character":0,"end_line":1757,"end_character":37},"in_reply_to":"f1b757d4_40b9f55d","updated":"2021-07-21 07:38:24.000000000","message":"Done","commit_id":"1abd40193c86e2c2e51e3798733224e8893da023"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b307b0a9e30fc8d5c8d8a4bfd2192a609c98e67","unresolved":true,"context_lines":[{"line_number":2002,"context_line":"        resp, body \u003d self.post(\u0027share-servers/%s/action\u0027 % share_server_id,"},{"line_number":2003,"context_line":"                               body, headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":2004,"context_line":"                               version\u003dversion)"},{"line_number":2005,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"        body \u003d json.loads(body)"},{"line_number":2008,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":29,"id":"76c2c5e9_27d75832","line":2005,"range":{"start_line":2005,"start_character":13,"end_line":2005,"end_character":29},"updated":"2021-07-21 17:14:57.000000000","message":"good catch!","commit_id":"86f2432476ba9128bb2c26a78ae3b3f53327d4bd"}]}