)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3877950d582f85c84b551bbaed4cd2fa2a796298","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7565a653_1a9ba256","updated":"2022-01-10 01:51:48.000000000","message":"recheck","commit_id":"ef85a7c61870791a782b850bec8f611010bd1acb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b70ff89ad54a07d9ff65036c8d4d53f8702f1c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b37b4aab_ddd105d5","updated":"2022-02-03 15:14:47.000000000","message":"recheck","commit_id":"ef85a7c61870791a782b850bec8f611010bd1acb"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"c8d06f4298d7331c0f049fa9ae80dccb4caf5e34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ad2036f2_2a6a74c9","updated":"2022-02-16 21:06:37.000000000","message":"Hi haixin, thank you for the tests. LGTM! I\u0027ll ensure to have a positive vote from NetApp CI on this. ","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a5012374be91c5f44eb8c00525189064cda3d9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2b39af65_32668fe8","updated":"2022-02-22 00:11:30.000000000","message":"LGTM, thank you - this one deserves a minor follow up patch: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/830295","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"693d220c6fecb9e4509f36cc56b3423705bc61fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"069026db_94b33d59","updated":"2022-02-08 08:59:36.000000000","message":"Thanks Haixin! LGTM!\nJust one minor comment.","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"2a889771611391666df94f6b04c389fcb9bbfaff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cd9bc862_77ba7f5f","updated":"2022-02-09 21:36:55.000000000","message":"Thanks haixin","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7822c2d1c26ab1a81bfca907029be50425893ccd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"489a6f2b_af015bba","updated":"2022-02-16 20:34:33.000000000","message":"run-NetApp CI","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"effce1841d3a4f60f46077cdb92ff34d693d23eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"54cbfc39_676c757e","updated":"2022-02-20 12:32:29.000000000","message":"run-NetApp CI","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"abf7d689a02297b7b30982cb4dc29893e5a560d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ca6533f0_50aff92c","updated":"2022-02-17 14:20:10.000000000","message":"run-NetApp CI","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4ad7ba3e1f3f6c06f6eea671f3b5b5c02d6c4921","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cc99dab1_c0aa2826","updated":"2022-02-16 20:42:45.000000000","message":"run-NetApp CI","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"eb785890e111e2a2d650dcb2462c35b1341edaa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fa0286cb_edeaa3cc","updated":"2022-02-18 13:21:00.000000000","message":"run-NetApp CI","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"}],"manila_tempest_tests/common/waiters.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a5012374be91c5f44eb8c00525189064cda3d9c","unresolved":true,"context_lines":[{"line_number":210,"context_line":"        if not share[\u0027is_soft_deleted\u0027]:"},{"line_number":211,"context_line":"            break"},{"line_number":212,"context_line":"        elif int(time.time()) - start \u003e\u003d client.build_timeout:"},{"line_number":213,"context_line":"            message \u003d (\u0027Share %(share_id)s failed to restore from \u0027"},{"line_number":214,"context_line":"                       \u0027recycle bin within the required time \u0027"},{"line_number":215,"context_line":"                       \u0027%(timeout)s.\u0027 % {"},{"line_number":216,"context_line":"                           \u0027share_id\u0027: share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"d9a8aa53_4f2b3df2","line":213,"range":{"start_line":213,"start_character":50,"end_line":213,"end_character":60},"updated":"2022-02-22 00:11:30.000000000","message":"to be restored","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1f1475a5f3de62e08301ef110a5034b8a9f510bc","unresolved":true,"context_lines":[{"line_number":31,"context_line":"                    \"This value is only used to validate the versions \""},{"line_number":32,"context_line":"                    \"response from Manila.\"),"},{"line_number":33,"context_line":"    cfg.StrOpt(\"max_api_microversion\","},{"line_number":34,"context_line":"               default\u003d\"2.64\","},{"line_number":35,"context_line":"               help\u003d\"The maximum api microversion is configured to be the \""},{"line_number":36,"context_line":"                    \"value of the latest microversion supported by Manila.\"),"},{"line_number":37,"context_line":"    cfg.StrOpt(\"region\","}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3fc913_d9f19172","line":34,"range":{"start_line":34,"start_character":26,"end_line":34,"end_character":28},"updated":"2021-09-03 07:39:58.000000000","message":"65","commit_id":"e0552c4c463d025268f21f249b06b774f0dea0e4"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7c71cb6dce66de3ada76c18faeedcb71dba287da","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    \"This value is only used to validate the versions \""},{"line_number":32,"context_line":"                    \"response from Manila.\"),"},{"line_number":33,"context_line":"    cfg.StrOpt(\"max_api_microversion\","},{"line_number":34,"context_line":"               default\u003d\"2.64\","},{"line_number":35,"context_line":"               help\u003d\"The maximum api microversion is configured to be the \""},{"line_number":36,"context_line":"                    \"value of the latest microversion supported by Manila.\"),"},{"line_number":37,"context_line":"    cfg.StrOpt(\"region\","}],"source_content_type":"text/x-python","patch_set":4,"id":"8bb6dcd2_96653217","line":34,"range":{"start_line":34,"start_character":26,"end_line":34,"end_character":28},"in_reply_to":"ba3fc913_d9f19172","updated":"2021-09-03 09:37:40.000000000","message":"Done","commit_id":"e0552c4c463d025268f21f249b06b774f0dea0e4"}],"manila_tempest_tests/tests/api/test_shares_actions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1f1475a5f3de62e08301ef110a5034b8a9f510bc","unresolved":true,"context_lines":[{"line_number":688,"context_line":"        )"},{"line_number":689,"context_line":"        self.assertEqual(new_size, share_get[\u0027size\u0027], msg)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.64\")"},{"line_number":692,"context_line":"    @decorators.idempotent_id(\u00277a19fb58-b645-44cc-a6d7-b3508ff8754d\u0027)"},{"line_number":693,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":694,"context_line":"    def test_soft_delete_and_restore_share(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"c9f1ff2f_1fa3bdfe","line":691,"range":{"start_line":691,"start_character":47,"end_line":691,"end_character":51},"updated":"2021-09-03 07:39:58.000000000","message":"2.65","commit_id":"e0552c4c463d025268f21f249b06b774f0dea0e4"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7c71cb6dce66de3ada76c18faeedcb71dba287da","unresolved":false,"context_lines":[{"line_number":688,"context_line":"        )"},{"line_number":689,"context_line":"        self.assertEqual(new_size, share_get[\u0027size\u0027], msg)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.64\")"},{"line_number":692,"context_line":"    @decorators.idempotent_id(\u00277a19fb58-b645-44cc-a6d7-b3508ff8754d\u0027)"},{"line_number":693,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":694,"context_line":"    def test_soft_delete_and_restore_share(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d97320b_4a54ae0d","line":691,"range":{"start_line":691,"start_character":47,"end_line":691,"end_character":51},"in_reply_to":"c9f1ff2f_1fa3bdfe","updated":"2021-09-03 09:37:40.000000000","message":"Done","commit_id":"e0552c4c463d025268f21f249b06b774f0dea0e4"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9afbbef82f7b79da2c38a7d6b9b5517cff0f615f","unresolved":true,"context_lines":[{"line_number":694,"context_line":"    def test_soft_delete_and_restore_share(self):"},{"line_number":695,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # wait for available status"},{"line_number":698,"context_line":"        waiters.wait_for_resource_status("},{"line_number":699,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        # list shares"},{"line_number":702,"context_line":"        shares \u003d self.shares_v2_client.list_shares()[\u0027shares\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5e2b673a_f6f26e7c","line":699,"range":{"start_line":697,"start_character":0,"end_line":699,"end_character":57},"updated":"2021-09-14 09:03:36.000000000","message":"It\u0027s unnecessary, it\u0027s already done by \"create_share\" wrapper.","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2eb3a3bed2eb3e1d1f82068a3b12363c5b14e7e1","unresolved":true,"context_lines":[{"line_number":694,"context_line":"    def test_soft_delete_and_restore_share(self):"},{"line_number":695,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # wait for available status"},{"line_number":698,"context_line":"        waiters.wait_for_resource_status("},{"line_number":699,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        # list shares"},{"line_number":702,"context_line":"        shares \u003d self.shares_v2_client.list_shares()[\u0027shares\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"bd35be67_b54eea9a","line":699,"range":{"start_line":697,"start_character":0,"end_line":699,"end_character":57},"in_reply_to":"5e2b673a_f6f26e7c","updated":"2021-09-15 03:21:49.000000000","message":"yes, i check again, this really not need.","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"15b20530f43b400f711dcaa46ab6da3f0d2ddf78","unresolved":false,"context_lines":[{"line_number":694,"context_line":"    def test_soft_delete_and_restore_share(self):"},{"line_number":695,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        # wait for available status"},{"line_number":698,"context_line":"        waiters.wait_for_resource_status("},{"line_number":699,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        # list shares"},{"line_number":702,"context_line":"        shares \u003d self.shares_v2_client.list_shares()[\u0027shares\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"0579e36d_f6ba925d","line":699,"range":{"start_line":697,"start_character":0,"end_line":699,"end_character":57},"in_reply_to":"bd35be67_b54eea9a","updated":"2022-02-08 06:19:04.000000000","message":"Done","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9afbbef82f7b79da2c38a7d6b9b5517cff0f615f","unresolved":true,"context_lines":[{"line_number":720,"context_line":"        self.assertNotIn(share[\u0027id\u0027], share_ids1)"},{"line_number":721,"context_line":"        self.assertIn(share[\u0027id\u0027], share_ids2)"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        # restore share from recycle bin"},{"line_number":724,"context_line":"        self.shares_v2_client.restore_share(share[\u0027id\u0027])"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        # list shares again"},{"line_number":727,"context_line":"        shares3 \u003d self.shares_v2_client.list_shares()[\u0027shares\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fddbb670_980b4acf","line":724,"range":{"start_line":723,"start_character":0,"end_line":724,"end_character":56},"updated":"2021-09-14 09:03:36.000000000","message":"Does the status of the share change during the restore operation.\nIf yes, it\u0027s better to add a waiter after this action.","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"15b20530f43b400f711dcaa46ab6da3f0d2ddf78","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        self.assertNotIn(share[\u0027id\u0027], share_ids1)"},{"line_number":721,"context_line":"        self.assertIn(share[\u0027id\u0027], share_ids2)"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        # restore share from recycle bin"},{"line_number":724,"context_line":"        self.shares_v2_client.restore_share(share[\u0027id\u0027])"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        # list shares again"},{"line_number":727,"context_line":"        shares3 \u003d self.shares_v2_client.list_shares()[\u0027shares\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"a84c3eb5_b738b491","line":724,"range":{"start_line":723,"start_character":0,"end_line":724,"end_character":56},"in_reply_to":"c774675d_b54a862b","updated":"2022-02-08 06:19:04.000000000","message":"Done","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2eb3a3bed2eb3e1d1f82068a3b12363c5b14e7e1","unresolved":true,"context_lines":[{"line_number":720,"context_line":"        self.assertNotIn(share[\u0027id\u0027], share_ids1)"},{"line_number":721,"context_line":"        self.assertIn(share[\u0027id\u0027], share_ids2)"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        # restore share from recycle bin"},{"line_number":724,"context_line":"        self.shares_v2_client.restore_share(share[\u0027id\u0027])"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        # list shares again"},{"line_number":727,"context_line":"        shares3 \u003d self.shares_v2_client.list_shares()[\u0027shares\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"c774675d_b54a862b","line":724,"range":{"start_line":723,"start_character":0,"end_line":724,"end_character":56},"in_reply_to":"fddbb670_980b4acf","updated":"2021-09-15 03:21:49.000000000","message":"the status of share does not change when share restore from recycle bin.\nit just change the marker of share\"is_soft_deleted\" from \"yes\" to \"no\".\nThe action return should be quick, just like rename share.\n\nbut to be on the safe side, i will add waiter action.","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"}],"manila_tempest_tests/tests/api/test_shares_actions_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1f1475a5f3de62e08301ef110a5034b8a9f510bc","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                          self.alt_shares_v2_client.get_share,"},{"line_number":283,"context_line":"                          self.share[\u0027id\u0027])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.64\")"},{"line_number":286,"context_line":"    @decorators.idempotent_id(\u002736cbe23b-08d2-49d9-bb42-f9eb2a804cb1\u0027)"},{"line_number":287,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":288,"context_line":"    def test_soft_delete_share_has_been_soft_deleted(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"242e6102_a097ad83","line":285,"range":{"start_line":285,"start_character":47,"end_line":285,"end_character":53},"updated":"2021-09-03 07:39:58.000000000","message":"microversion bump all over these tests","commit_id":"e0552c4c463d025268f21f249b06b774f0dea0e4"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7c71cb6dce66de3ada76c18faeedcb71dba287da","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                          self.alt_shares_v2_client.get_share,"},{"line_number":283,"context_line":"                          self.share[\u0027id\u0027])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.64\")"},{"line_number":286,"context_line":"    @decorators.idempotent_id(\u002736cbe23b-08d2-49d9-bb42-f9eb2a804cb1\u0027)"},{"line_number":287,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":288,"context_line":"    def test_soft_delete_share_has_been_soft_deleted(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ef00bab9_4d3a9731","line":285,"range":{"start_line":285,"start_character":47,"end_line":285,"end_character":53},"in_reply_to":"242e6102_a097ad83","updated":"2021-09-03 09:37:40.000000000","message":"Done","commit_id":"e0552c4c463d025268f21f249b06b774f0dea0e4"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9afbbef82f7b79da2c38a7d6b9b5517cff0f615f","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":290,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # wait for available status"},{"line_number":293,"context_line":"        waiters.wait_for_resource_status("},{"line_number":294,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # soft delete the share"},{"line_number":297,"context_line":"        self.shares_v2_client.soft_delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"b6165f1a_b27cfe95","line":294,"range":{"start_line":292,"start_character":0,"end_line":294,"end_character":57},"updated":"2021-09-14 09:03:36.000000000","message":"It\u0027s unnecessary, it\u0027s already done by \"create_share\" wrapper.","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2eb3a3bed2eb3e1d1f82068a3b12363c5b14e7e1","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":290,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        # wait for available status"},{"line_number":293,"context_line":"        waiters.wait_for_resource_status("},{"line_number":294,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # soft delete the share"},{"line_number":297,"context_line":"        self.shares_v2_client.soft_delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"abc560d2_df9d8040","line":294,"range":{"start_line":292,"start_character":0,"end_line":294,"end_character":57},"in_reply_to":"b6165f1a_b27cfe95","updated":"2021-09-15 03:21:49.000000000","message":"Done","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9afbbef82f7b79da2c38a7d6b9b5517cff0f615f","unresolved":true,"context_lines":[{"line_number":301,"context_line":"                          self.shares_v2_client.soft_delete_share,"},{"line_number":302,"context_line":"                          share[\u0027id\u0027])"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # restore the share for resource_cleanup"},{"line_number":305,"context_line":"        self.shares_v2_client.restore_share(share[\u0027id\u0027])"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.66\")"},{"line_number":308,"context_line":"    @decorators.idempotent_id(\u0027cf675ac9-0970-49fc-a051-8a94555c73b5\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"85dd4897_55f5c595","line":305,"range":{"start_line":304,"start_character":0,"end_line":305,"end_character":56},"updated":"2021-09-14 09:03:36.000000000","message":"I think we need to make sure the share was restored successfully.","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2eb3a3bed2eb3e1d1f82068a3b12363c5b14e7e1","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                          self.shares_v2_client.soft_delete_share,"},{"line_number":302,"context_line":"                          share[\u0027id\u0027])"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # restore the share for resource_cleanup"},{"line_number":305,"context_line":"        self.shares_v2_client.restore_share(share[\u0027id\u0027])"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.66\")"},{"line_number":308,"context_line":"    @decorators.idempotent_id(\u0027cf675ac9-0970-49fc-a051-8a94555c73b5\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fba51e72_0bfc6155","line":305,"range":{"start_line":304,"start_character":0,"end_line":305,"end_character":56},"in_reply_to":"85dd4897_55f5c595","updated":"2021-09-15 03:21:49.000000000","message":"Done","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9afbbef82f7b79da2c38a7d6b9b5517cff0f615f","unresolved":true,"context_lines":[{"line_number":311,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":312,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        # wait for available status"},{"line_number":315,"context_line":"        waiters.wait_for_resource_status("},{"line_number":316,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # set \"error_deleting\" state"},{"line_number":319,"context_line":"        self.admin_client.reset_state(share[\u0027id\u0027], status\u003d\"error_deleting\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"08720081_6d018773","line":316,"range":{"start_line":314,"start_character":0,"end_line":316,"end_character":57},"updated":"2021-09-14 09:03:36.000000000","message":"Same.","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2eb3a3bed2eb3e1d1f82068a3b12363c5b14e7e1","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":312,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        # wait for available status"},{"line_number":315,"context_line":"        waiters.wait_for_resource_status("},{"line_number":316,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # set \"error_deleting\" state"},{"line_number":319,"context_line":"        self.admin_client.reset_state(share[\u0027id\u0027], status\u003d\"error_deleting\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"62afa4ce_c65f147d","line":316,"range":{"start_line":314,"start_character":0,"end_line":316,"end_character":57},"in_reply_to":"08720081_6d018773","updated":"2021-09-15 03:21:49.000000000","message":"Done","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9afbbef82f7b79da2c38a7d6b9b5517cff0f615f","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                          self.shares_v2_client.soft_delete_share,"},{"line_number":324,"context_line":"                          share[\u0027id\u0027])"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        # rollback to available status"},{"line_number":327,"context_line":"        self.admin_client.reset_state(share[\u0027id\u0027], status\u003d\"available\")"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.66\")"},{"line_number":330,"context_line":"    @decorators.idempotent_id(\u0027f6106ee4-1a01-444f-b623-912a5e751d49\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"69d86398_ee389d9b","line":327,"range":{"start_line":326,"start_character":0,"end_line":327,"end_character":70},"updated":"2021-09-14 09:03:36.000000000","message":"We need to make sure the status of the share was updated:\n\nwaiters.wait_for_resource_status(\n        self.shares_v2_client, share[\u0027id\u0027], \"available\")","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"15b20530f43b400f711dcaa46ab6da3f0d2ddf78","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                          self.shares_v2_client.soft_delete_share,"},{"line_number":324,"context_line":"                          share[\u0027id\u0027])"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        # rollback to available status"},{"line_number":327,"context_line":"        self.admin_client.reset_state(share[\u0027id\u0027], status\u003d\"available\")"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.66\")"},{"line_number":330,"context_line":"    @decorators.idempotent_id(\u0027f6106ee4-1a01-444f-b623-912a5e751d49\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd8b3d86_143ef758","line":327,"range":{"start_line":326,"start_character":0,"end_line":327,"end_character":70},"in_reply_to":"0e8ba3f4_6ab676ed","updated":"2022-02-08 06:19:04.000000000","message":"Done","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2eb3a3bed2eb3e1d1f82068a3b12363c5b14e7e1","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                          self.shares_v2_client.soft_delete_share,"},{"line_number":324,"context_line":"                          share[\u0027id\u0027])"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        # rollback to available status"},{"line_number":327,"context_line":"        self.admin_client.reset_state(share[\u0027id\u0027], status\u003d\"available\")"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.66\")"},{"line_number":330,"context_line":"    @decorators.idempotent_id(\u0027f6106ee4-1a01-444f-b623-912a5e751d49\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0e8ba3f4_6ab676ed","line":327,"range":{"start_line":326,"start_character":0,"end_line":327,"end_character":70},"in_reply_to":"69d86398_ee389d9b","updated":"2021-09-15 03:21:49.000000000","message":"just like def test_share_extend_with_invalid_share_state() in line 111.\nreset_state aslo no need to wait resource status. i think\nthis is a quick action, just need to change db. so no need to wait.","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9afbbef82f7b79da2c38a7d6b9b5517cff0f615f","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":334,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        # wait for available status"},{"line_number":337,"context_line":"        waiters.wait_for_resource_status("},{"line_number":338,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # try soft delete the share"},{"line_number":341,"context_line":"        self.assertRaises(lib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":5,"id":"91423344_eaa05b2d","line":338,"range":{"start_line":336,"start_character":0,"end_line":338,"end_character":57},"updated":"2021-09-14 09:03:36.000000000","message":"Same.","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2eb3a3bed2eb3e1d1f82068a3b12363c5b14e7e1","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":334,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        # wait for available status"},{"line_number":337,"context_line":"        waiters.wait_for_resource_status("},{"line_number":338,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # try soft delete the share"},{"line_number":341,"context_line":"        self.assertRaises(lib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":5,"id":"77f18fff_284499b3","line":338,"range":{"start_line":336,"start_character":0,"end_line":338,"end_character":57},"in_reply_to":"91423344_eaa05b2d","updated":"2021-09-15 03:21:49.000000000","message":"Done","commit_id":"ac8d454c9cdcd1f03aa09553eb9438242b85ad8d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"693d220c6fecb9e4509f36cc56b3423705bc61fd","unresolved":true,"context_lines":[{"line_number":350,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":351,"context_line":"    def test_soft_delete_share_with_wrong_id(self):"},{"line_number":352,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":353,"context_line":"                          self.alt_shares_v2_client.soft_delete_share,"},{"line_number":354,"context_line":"                          \"wrong_share_id\")"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.69\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"b3f26d83_47b1ec5b","line":353,"range":{"start_line":353,"start_character":31,"end_line":353,"end_character":51},"updated":"2022-02-08 08:59:36.000000000","message":"There is no need to use alt user here.\nIt can be a bit confusing even though it does not really matter.","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a5012374be91c5f44eb8c00525189064cda3d9c","unresolved":true,"context_lines":[{"line_number":350,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":351,"context_line":"    def test_soft_delete_share_with_wrong_id(self):"},{"line_number":352,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":353,"context_line":"                          self.alt_shares_v2_client.soft_delete_share,"},{"line_number":354,"context_line":"                          \"wrong_share_id\")"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.69\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"43ad46f8_dfb9a7f5","line":353,"range":{"start_line":353,"start_character":31,"end_line":353,"end_character":51},"in_reply_to":"4eb10521_6fbe7f42","updated":"2022-02-22 00:11:30.000000000","message":"+1, haixin, liron, andre, I\u0027ve addressed this in https://review.opendev.org/c/openstack/manila-tempest-plugin/+/830295 - please check","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"c8d06f4298d7331c0f049fa9ae80dccb4caf5e34","unresolved":true,"context_lines":[{"line_number":350,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":351,"context_line":"    def test_soft_delete_share_with_wrong_id(self):"},{"line_number":352,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":353,"context_line":"                          self.alt_shares_v2_client.soft_delete_share,"},{"line_number":354,"context_line":"                          \"wrong_share_id\")"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.69\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"4eb10521_6fbe7f42","line":353,"range":{"start_line":353,"start_character":31,"end_line":353,"end_character":51},"in_reply_to":"b3f26d83_47b1ec5b","updated":"2022-02-16 21:06:37.000000000","message":"+1","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"693d220c6fecb9e4509f36cc56b3423705bc61fd","unresolved":true,"context_lines":[{"line_number":358,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":359,"context_line":"    def test_restore_share_with_wrong_id(self):"},{"line_number":360,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":361,"context_line":"                          self.alt_shares_v2_client.restore_share,"},{"line_number":362,"context_line":"                          \"wrong_share_id\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"d1d6fb10_fcef510a","line":361,"range":{"start_line":361,"start_character":31,"end_line":361,"end_character":51},"updated":"2022-02-08 08:59:36.000000000","message":"Same.","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a5012374be91c5f44eb8c00525189064cda3d9c","unresolved":true,"context_lines":[{"line_number":358,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":359,"context_line":"    def test_restore_share_with_wrong_id(self):"},{"line_number":360,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":361,"context_line":"                          self.alt_shares_v2_client.restore_share,"},{"line_number":362,"context_line":"                          \"wrong_share_id\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"ef391ad9_f9310661","line":361,"range":{"start_line":361,"start_character":31,"end_line":361,"end_character":51},"in_reply_to":"d1d6fb10_fcef510a","updated":"2022-02-22 00:11:30.000000000","message":"+1","commit_id":"1c5e68da5ebbd4e544d6a01b31c7dbe23fcecaec"}]}