)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba534e31396a9cd1f1285b96756dd0425eb7489f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a898593b_46be4fb4","updated":"2021-12-15 20:28:59.000000000","message":"Kiran, can you rebase this change?\n\nI\u0027d like to have these run against the NetApp CI so we can be sure the changes don\u0027t break anything","commit_id":"3ab022b7b40b2fe6c3136b525aa7c4eb2e64889c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"59c9463e0463408f13c7fe5597f44ef5049d4d79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b18f051e_51d05fa0","in_reply_to":"91a88362_0eba4818","updated":"2022-03-17 14:22:03.000000000","message":"sorry for being-late on this. Please check. Can you please check again with NetApp?","commit_id":"3ab022b7b40b2fe6c3136b525aa7c4eb2e64889c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3d149dff0dadff9af15e299f0dd78f2994c4a2b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c054cf82_08bea5f3","in_reply_to":"a898593b_46be4fb4","updated":"2021-12-16 09:43:31.000000000","message":"I think I will get only_host scheduler hints merged first, since it is then extended to share replica as well. And then move to this PR where share-network option is added.\nIs it ok ?","commit_id":"3ab022b7b40b2fe6c3136b525aa7c4eb2e64889c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ab5c70884aa99bd240dfa0befd2e7da70a0a4da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"91a88362_0eba4818","in_reply_to":"c054cf82_08bea5f3","updated":"2021-12-16 16:58:12.000000000","message":"Yep that\u0027s fine - we called this patch out at today\u0027s IRC meeting, and wanted to get the driver maintainers at NetApp looking at these changes; So please update this when possible..","commit_id":"3ab022b7b40b2fe6c3136b525aa7c4eb2e64889c"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bc1ad5a8a3e14dbdb43faf42c9d7e6307318dd9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f7e9d73d_686e14b5","updated":"2022-08-30 22:02:04.000000000","message":"recheck - logs are gone already","commit_id":"bc321d361d3dd2bbdbed1fe2a67bd3f9c10f741d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e8ca4399d8406078fbe6934f88ada3ed3fe24d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"009aa35c_48684c96","updated":"2022-09-22 22:50:06.000000000","message":"LGTM for the most part - see the comment inline. Thanks Kiran!","commit_id":"69591886b419fa8f3419e972cb099607426a863b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"6b5476e303f36054036a5d321c3441d2888de815","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"2307478c_f6ee48a8","updated":"2022-10-10 06:06:55.000000000","message":"LGTM","commit_id":"b8d8c60421295dc44d6d9351964b1a8b78e63a26"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"20868a09d6c3e1f4ffc022922b506c59d10f4029","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3e1860d2_8486715d","updated":"2023-01-17 18:16:27.000000000","message":"Thank you for working on this change, and sorry for the wait Kiran! Please take a look at the comments inline ","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"872297313e06005c44753e21828eb139394d5bf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"bcb3704f_bfbf4b20","updated":"2023-01-24 16:56:38.000000000","message":"LGTM, thanks Kiran!","commit_id":"6d3e918cc5d9152160a9dd271e34fe5c68cc9bf4"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"ca33074e774eb5a2e35dbee3c54649313e05993e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"4a316cdc_75da6f10","updated":"2023-01-26 15:21:50.000000000","message":"Looks good, thanks!","commit_id":"6d3e918cc5d9152160a9dd271e34fe5c68cc9bf4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b0a583a8b64cc16e420153e62e13cf5e0036241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"d25660b5_846fbdb5","updated":"2023-01-26 15:25:47.000000000","message":"Sorry, found a missing test skip which will make the newly added test fail on stable branches.. ","commit_id":"6d3e918cc5d9152160a9dd271e34fe5c68cc9bf4"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"103889c0bc97d5f0cc1441773115e44f4eced39b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"ebef120f_a3497601","updated":"2023-01-24 10:57:30.000000000","message":"Thanks Kiran,\nOnly a minor comment.","commit_id":"6d3e918cc5d9152160a9dd271e34fe5c68cc9bf4"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5c5ca19ac2e38a1756c5a76d82a574aa02feb994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"82d574cd_728e59f1","updated":"2023-01-30 06:38:51.000000000","message":"LGTM.let\u0027s merge it.","commit_id":"2521fbf86a2aa001e5c82dc9fd36d39646b37a3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"317cf325f301bc79e111616908db274304971926","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"7b8eba20_2f14d515","updated":"2023-01-27 16:15:14.000000000","message":"Thanks, LGTM","commit_id":"2521fbf86a2aa001e5c82dc9fd36d39646b37a3b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f234ad316fd007e45a6d99bf9fa2695e709abe22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"36f6ab11_1e81a02a","updated":"2023-01-27 15:58:20.000000000","message":"recheck","commit_id":"2521fbf86a2aa001e5c82dc9fd36d39646b37a3b"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"20868a09d6c3e1f4ffc022922b506c59d10f4029","unresolved":true,"context_lines":[{"line_number":1578,"context_line":"            post_body[\u0027share_network_id\u0027] \u003d share_network_id"},{"line_number":1579,"context_line":""},{"line_number":1580,"context_line":"        headers, extra_headers \u003d utils.get_extra_headers("},{"line_number":1581,"context_line":"            version, constants.SHARE_REPLICA_SHARE_NET_PARAM_VERSION)"},{"line_number":1582,"context_line":"        body \u003d json.dumps({\u0027share_replica\u0027: post_body})"},{"line_number":1583,"context_line":"        resp, body \u003d self.post(uri, body,"},{"line_number":1584,"context_line":"                               headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":19,"id":"45ea0286_5d627b66","line":1581,"range":{"start_line":1581,"start_character":21,"end_line":1581,"end_character":68},"updated":"2023-01-17 18:16:27.000000000","message":"I think this should not be modified. The version of the graduation of share replicas is what actually dictates whether we need to add the experimental headers to the request or not, so we should continue relying on the version of the graduation, as that has not changed. Otherwise, we will end up sending create requests with experimental headers in all requests done from API version 2.56 to 2.71. Share replica APIs are no longer experimental in that range of API versions.","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6eaaf313771509e1c016c6602f07af816ff70a7","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"            post_body[\u0027share_network_id\u0027] \u003d share_network_id"},{"line_number":1579,"context_line":""},{"line_number":1580,"context_line":"        headers, extra_headers \u003d utils.get_extra_headers("},{"line_number":1581,"context_line":"            version, constants.SHARE_REPLICA_SHARE_NET_PARAM_VERSION)"},{"line_number":1582,"context_line":"        body \u003d json.dumps({\u0027share_replica\u0027: post_body})"},{"line_number":1583,"context_line":"        resp, body \u003d self.post(uri, body,"},{"line_number":1584,"context_line":"                               headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":19,"id":"0df685fc_f5f08c0a","line":1581,"range":{"start_line":1581,"start_character":21,"end_line":1581,"end_character":68},"in_reply_to":"45ea0286_5d627b66","updated":"2023-01-24 08:10:12.000000000","message":"Done","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"}],"manila_tempest_tests/tests/api/admin/test_replication.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e8ca4399d8406078fbe6934f88ada3ed3fe24d8","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        *utils.deduplicate([constants.MIN_SHARE_REPLICATION_VERSION,"},{"line_number":104,"context_line":"                            constants.SHARE_REPLICA_GRADUATION_VERSION,"},{"line_number":105,"context_line":"                            LATEST_MICROVERSION]))"},{"line_number":106,"context_line":"    def test_promote_out_of_sync_share_replica(self, version):"},{"line_number":107,"context_line":"        \"\"\"Test promote \u0027out_of_sync\u0027 share replica to active state.\"\"\""},{"line_number":108,"context_line":"        utils.check_skip_if_microversion_not_supported(version)"},{"line_number":109,"context_line":"        if (self.replication_type"}],"source_content_type":"text/x-python","patch_set":17,"id":"4ecd7a6a_1e8b3dbd","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":46},"updated":"2022-09-22 22:50:06.000000000","message":"This test had the unstable test tag on line 85; please move the tag as well..","commit_id":"69591886b419fa8f3419e972cb099607426a863b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1a86ebead468ff84be28254e0b868e3c8821a2ec","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        *utils.deduplicate([constants.MIN_SHARE_REPLICATION_VERSION,"},{"line_number":104,"context_line":"                            constants.SHARE_REPLICA_GRADUATION_VERSION,"},{"line_number":105,"context_line":"                            LATEST_MICROVERSION]))"},{"line_number":106,"context_line":"    def test_promote_out_of_sync_share_replica(self, version):"},{"line_number":107,"context_line":"        \"\"\"Test promote \u0027out_of_sync\u0027 share replica to active state.\"\"\""},{"line_number":108,"context_line":"        utils.check_skip_if_microversion_not_supported(version)"},{"line_number":109,"context_line":"        if (self.replication_type"}],"source_content_type":"text/x-python","patch_set":17,"id":"96e893d7_40320293","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":46},"in_reply_to":"4ecd7a6a_1e8b3dbd","updated":"2022-09-23 07:36:10.000000000","message":"Done","commit_id":"69591886b419fa8f3419e972cb099607426a863b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e857014060ddaeb19f8d33cc7d02d7f85bb22b64","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        return [replica[\u0027id\u0027] for replica in replica_list"},{"line_number":83,"context_line":"                if replica[\u0027replica_state\u0027] \u003d\u003d r_state]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _create_share_replica(self, share_id, version, cleanup\u003dTrue,"},{"line_number":86,"context_line":"                              cleanup_in_class\u003dFalse):"},{"line_number":87,"context_line":"        if utils.is_microversion_lt(version, ("},{"line_number":88,"context_line":"                constants.SHARE_REPLICA_SHARE_NET_PARAM_VERSION)):"}],"source_content_type":"text/x-python","patch_set":19,"id":"bbab6d35_48109323","line":85,"range":{"start_line":85,"start_character":46,"end_line":85,"end_character":53},"updated":"2023-01-18 13:49:45.000000000","message":"Please don\u0027t set this as a mandatory parameter, define a default value.\nversion\u003dCONF.share.max_api_microversion","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6eaaf313771509e1c016c6602f07af816ff70a7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        return [replica[\u0027id\u0027] for replica in replica_list"},{"line_number":83,"context_line":"                if replica[\u0027replica_state\u0027] \u003d\u003d r_state]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _create_share_replica(self, share_id, version, cleanup\u003dTrue,"},{"line_number":86,"context_line":"                              cleanup_in_class\u003dFalse):"},{"line_number":87,"context_line":"        if utils.is_microversion_lt(version, ("},{"line_number":88,"context_line":"                constants.SHARE_REPLICA_SHARE_NET_PARAM_VERSION)):"}],"source_content_type":"text/x-python","patch_set":19,"id":"fad084ed_6d43f6a6","line":85,"range":{"start_line":85,"start_character":46,"end_line":85,"end_character":53},"in_reply_to":"bbab6d35_48109323","updated":"2023-01-24 08:10:12.000000000","message":"Done","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e857014060ddaeb19f8d33cc7d02d7f85bb22b64","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        return [replica[\u0027id\u0027] for replica in replica_list"},{"line_number":83,"context_line":"                if replica[\u0027replica_state\u0027] \u003d\u003d r_state]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _create_share_replica(self, share_id, version, cleanup\u003dTrue,"},{"line_number":86,"context_line":"                              cleanup_in_class\u003dFalse):"},{"line_number":87,"context_line":"        if utils.is_microversion_lt(version, ("},{"line_number":88,"context_line":"                constants.SHARE_REPLICA_SHARE_NET_PARAM_VERSION)):"},{"line_number":89,"context_line":"            share_net_id \u003d None"},{"line_number":90,"context_line":"        else:"},{"line_number":91,"context_line":"            share_net_id \u003d self.sn_id"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        replica \u003d self.create_share_replica("},{"line_number":94,"context_line":"            share_id, self.replica_zone, share_network_id\u003dshare_net_id,"},{"line_number":95,"context_line":"            cleanup_in_class\u003dcleanup_in_class, cleanup\u003dcleanup,"},{"line_number":96,"context_line":"            client\u003dself.admin_client, version\u003dversion)"},{"line_number":97,"context_line":"        return replica"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @decorators.unstable_test(bug\u003d\u00271631314\u0027)"},{"line_number":100,"context_line":"    @decorators.idempotent_id(\u00270213cdfd-6a0f-4f24-a154-69796888a64a\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1cb7c695_d3ff24ad","line":97,"range":{"start_line":85,"start_character":0,"end_line":97,"end_character":22},"updated":"2023-01-18 13:49:45.000000000","message":"Please modify the existing method https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/api/base.py#L678\nThere is no need to create a new one.","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6eaaf313771509e1c016c6602f07af816ff70a7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        return [replica[\u0027id\u0027] for replica in replica_list"},{"line_number":83,"context_line":"                if replica[\u0027replica_state\u0027] \u003d\u003d r_state]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _create_share_replica(self, share_id, version, cleanup\u003dTrue,"},{"line_number":86,"context_line":"                              cleanup_in_class\u003dFalse):"},{"line_number":87,"context_line":"        if utils.is_microversion_lt(version, ("},{"line_number":88,"context_line":"                constants.SHARE_REPLICA_SHARE_NET_PARAM_VERSION)):"},{"line_number":89,"context_line":"            share_net_id \u003d None"},{"line_number":90,"context_line":"        else:"},{"line_number":91,"context_line":"            share_net_id \u003d self.sn_id"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        replica \u003d self.create_share_replica("},{"line_number":94,"context_line":"            share_id, self.replica_zone, share_network_id\u003dshare_net_id,"},{"line_number":95,"context_line":"            cleanup_in_class\u003dcleanup_in_class, cleanup\u003dcleanup,"},{"line_number":96,"context_line":"            client\u003dself.admin_client, version\u003dversion)"},{"line_number":97,"context_line":"        return replica"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @decorators.unstable_test(bug\u003d\u00271631314\u0027)"},{"line_number":100,"context_line":"    @decorators.idempotent_id(\u00270213cdfd-6a0f-4f24-a154-69796888a64a\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"eb4a2886_612d4f9c","line":97,"range":{"start_line":85,"start_character":0,"end_line":97,"end_character":22},"in_reply_to":"1cb7c695_d3ff24ad","updated":"2023-01-24 08:10:12.000000000","message":"Done","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"}],"manila_tempest_tests/tests/api/admin/test_replication_actions.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"20868a09d6c3e1f4ffc022922b506c59d10f4029","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            0, {\u0027type\u0027: \u0027share\u0027, \u0027id\u0027: managed_share[\u0027id\u0027],"},{"line_number":141,"context_line":"                \u0027client\u0027: self.admin_client})"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        # Make sure a replica can be added to newly managed share"},{"line_number":144,"context_line":"        self.create_share_replica(managed_share[\u0027id\u0027], self.replica_zone,"},{"line_number":145,"context_line":"                                  share_network_id\u003dself.sn_id, cleanup\u003dTrue,"},{"line_number":146,"context_line":"                                  client\u003dself.admin_client)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @decorators.idempotent_id(\u0027cbbe2650-47bb-456b-8b41-74c66270ea97\u0027)"},{"line_number":149,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ca7e2e52_f47578d1","line":146,"range":{"start_line":143,"start_character":8,"end_line":146,"end_character":59},"updated":"2023-01-17 18:16:27.000000000","message":"please add microversion checks before sending the share network id to the create share replica command.","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6eaaf313771509e1c016c6602f07af816ff70a7","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            0, {\u0027type\u0027: \u0027share\u0027, \u0027id\u0027: managed_share[\u0027id\u0027],"},{"line_number":141,"context_line":"                \u0027client\u0027: self.admin_client})"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        # Make sure a replica can be added to newly managed share"},{"line_number":144,"context_line":"        self.create_share_replica(managed_share[\u0027id\u0027], self.replica_zone,"},{"line_number":145,"context_line":"                                  share_network_id\u003dself.sn_id, cleanup\u003dTrue,"},{"line_number":146,"context_line":"                                  client\u003dself.admin_client)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @decorators.idempotent_id(\u0027cbbe2650-47bb-456b-8b41-74c66270ea97\u0027)"},{"line_number":149,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":19,"id":"8cdb0d70_acbb43da","line":146,"range":{"start_line":143,"start_character":8,"end_line":146,"end_character":59},"in_reply_to":"ca7e2e52_f47578d1","updated":"2023-01-24 08:10:12.000000000","message":"Done","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"20868a09d6c3e1f4ffc022922b506c59d10f4029","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    def test_unmanage_replicated_share_with_replica(self):"},{"line_number":153,"context_line":"        \"\"\"Try to unmanage a share having replica.\"\"\""},{"line_number":154,"context_line":"        # Create a share replica before unmanaging the share"},{"line_number":155,"context_line":"        self.create_share_replica(self.share[\"id\"], self.replica_zone,"},{"line_number":156,"context_line":"                                  share_network_id\u003dself.sn_id, cleanup\u003dTrue,"},{"line_number":157,"context_line":"                                  client\u003dself.admin_client)"},{"line_number":158,"context_line":"        self.assertRaises("},{"line_number":159,"context_line":"            lib_exc.Conflict,"},{"line_number":160,"context_line":"            self.admin_client.unmanage_share,"}],"source_content_type":"text/x-python","patch_set":19,"id":"0db2f08d_1180281a","line":157,"range":{"start_line":155,"start_character":8,"end_line":157,"end_character":59},"updated":"2023-01-17 18:16:27.000000000","message":"same as above","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6eaaf313771509e1c016c6602f07af816ff70a7","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    def test_unmanage_replicated_share_with_replica(self):"},{"line_number":153,"context_line":"        \"\"\"Try to unmanage a share having replica.\"\"\""},{"line_number":154,"context_line":"        # Create a share replica before unmanaging the share"},{"line_number":155,"context_line":"        self.create_share_replica(self.share[\"id\"], self.replica_zone,"},{"line_number":156,"context_line":"                                  share_network_id\u003dself.sn_id, cleanup\u003dTrue,"},{"line_number":157,"context_line":"                                  client\u003dself.admin_client)"},{"line_number":158,"context_line":"        self.assertRaises("},{"line_number":159,"context_line":"            lib_exc.Conflict,"},{"line_number":160,"context_line":"            self.admin_client.unmanage_share,"}],"source_content_type":"text/x-python","patch_set":19,"id":"4d25bd7c_109fd2ba","line":157,"range":{"start_line":155,"start_character":8,"end_line":157,"end_character":59},"in_reply_to":"0db2f08d_1180281a","updated":"2023-01-24 08:10:12.000000000","message":"Done","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"20868a09d6c3e1f4ffc022922b506c59d10f4029","unresolved":true,"context_lines":[{"line_number":181,"context_line":"    def test_manage_replicated_share_snapshot(self):"},{"line_number":182,"context_line":"        \"\"\"Try to manage a snapshot of the replicated.\"\"\""},{"line_number":183,"context_line":"        # Create a share replica before managing the snapshot"},{"line_number":184,"context_line":"        self.create_share_replica(self.share[\"id\"], self.replica_zone,"},{"line_number":185,"context_line":"                                  share_network_id\u003dself.sn_id, cleanup\u003dTrue,"},{"line_number":186,"context_line":"                                  client\u003dself.admin_client)"},{"line_number":187,"context_line":"        self.assertRaises("},{"line_number":188,"context_line":"            lib_exc.Conflict,"},{"line_number":189,"context_line":"            self.admin_client.manage_snapshot,"}],"source_content_type":"text/x-python","patch_set":19,"id":"28e46cc2_8f344ba8","line":186,"range":{"start_line":184,"start_character":8,"end_line":186,"end_character":59},"updated":"2023-01-17 18:16:27.000000000","message":"same","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6eaaf313771509e1c016c6602f07af816ff70a7","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def test_manage_replicated_share_snapshot(self):"},{"line_number":182,"context_line":"        \"\"\"Try to manage a snapshot of the replicated.\"\"\""},{"line_number":183,"context_line":"        # Create a share replica before managing the snapshot"},{"line_number":184,"context_line":"        self.create_share_replica(self.share[\"id\"], self.replica_zone,"},{"line_number":185,"context_line":"                                  share_network_id\u003dself.sn_id, cleanup\u003dTrue,"},{"line_number":186,"context_line":"                                  client\u003dself.admin_client)"},{"line_number":187,"context_line":"        self.assertRaises("},{"line_number":188,"context_line":"            lib_exc.Conflict,"},{"line_number":189,"context_line":"            self.admin_client.manage_snapshot,"}],"source_content_type":"text/x-python","patch_set":19,"id":"8f080650_edef3a97","line":186,"range":{"start_line":184,"start_character":8,"end_line":186,"end_character":59},"in_reply_to":"28e46cc2_8f344ba8","updated":"2023-01-24 08:10:12.000000000","message":"Done","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"20868a09d6c3e1f4ffc022922b506c59d10f4029","unresolved":true,"context_lines":[{"line_number":198,"context_line":"    def test_unmanage_replicated_share_snapshot(self):"},{"line_number":199,"context_line":"        \"\"\"Try to unmanage a snapshot of the replicated share with replica.\"\"\""},{"line_number":200,"context_line":"        # Create a share replica before unmanaging the snapshot"},{"line_number":201,"context_line":"        self.create_share_replica(self.share[\"id\"], self.replica_zone,"},{"line_number":202,"context_line":"                                  share_network_id\u003dself.sn_id, cleanup\u003dTrue,"},{"line_number":203,"context_line":"                                  client\u003dself.admin_client)"},{"line_number":204,"context_line":"        snapshot \u003d self.create_snapshot_wait_for_active("},{"line_number":205,"context_line":"            self.share[\"id\"], client\u003dself.admin_client)"},{"line_number":206,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":19,"id":"84a2fd73_382bc7b2","line":203,"range":{"start_line":201,"start_character":8,"end_line":203,"end_character":59},"updated":"2023-01-17 18:16:27.000000000","message":"same","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6eaaf313771509e1c016c6602f07af816ff70a7","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    def test_unmanage_replicated_share_snapshot(self):"},{"line_number":199,"context_line":"        \"\"\"Try to unmanage a snapshot of the replicated share with replica.\"\"\""},{"line_number":200,"context_line":"        # Create a share replica before unmanaging the snapshot"},{"line_number":201,"context_line":"        self.create_share_replica(self.share[\"id\"], self.replica_zone,"},{"line_number":202,"context_line":"                                  share_network_id\u003dself.sn_id, cleanup\u003dTrue,"},{"line_number":203,"context_line":"                                  client\u003dself.admin_client)"},{"line_number":204,"context_line":"        snapshot \u003d self.create_snapshot_wait_for_active("},{"line_number":205,"context_line":"            self.share[\"id\"], client\u003dself.admin_client)"},{"line_number":206,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":19,"id":"bf7d0f88_cb05d364","line":203,"range":{"start_line":201,"start_character":8,"end_line":203,"end_character":59},"in_reply_to":"84a2fd73_382bc7b2","updated":"2023-01-24 08:10:12.000000000","message":"Done","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"}],"manila_tempest_tests/tests/api/test_replication.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"20868a09d6c3e1f4ffc022922b506c59d10f4029","unresolved":true,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _verify_create_replica(self):"},{"line_number":100,"context_line":"        # Create the replica"},{"line_number":101,"context_line":"        share_replica \u003d self.create_share_replica(self.shares[0][\"id\"],"},{"line_number":102,"context_line":"                                                  self.replica_zone,"},{"line_number":103,"context_line":"                                                  share_network_id\u003dself.sn_id,"},{"line_number":104,"context_line":"                                                  cleanup_in_class\u003dFalse)"},{"line_number":105,"context_line":"        share_replicas \u003d self.shares_v2_client.list_share_replicas("},{"line_number":106,"context_line":"            share_id\u003dself.shares[0][\"id\"])[\u0027share_replicas\u0027]"},{"line_number":107,"context_line":"        # Ensure replica is created successfully."}],"source_content_type":"text/x-python","patch_set":19,"id":"c6821cf1_05ec4961","line":104,"range":{"start_line":101,"start_character":8,"end_line":104,"end_character":73},"updated":"2023-01-17 18:16:27.000000000","message":"please add microversion checks here and below","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6eaaf313771509e1c016c6602f07af816ff70a7","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _verify_create_replica(self):"},{"line_number":100,"context_line":"        # Create the replica"},{"line_number":101,"context_line":"        share_replica \u003d self.create_share_replica(self.shares[0][\"id\"],"},{"line_number":102,"context_line":"                                                  self.replica_zone,"},{"line_number":103,"context_line":"                                                  share_network_id\u003dself.sn_id,"},{"line_number":104,"context_line":"                                                  cleanup_in_class\u003dFalse)"},{"line_number":105,"context_line":"        share_replicas \u003d self.shares_v2_client.list_share_replicas("},{"line_number":106,"context_line":"            share_id\u003dself.shares[0][\"id\"])[\u0027share_replicas\u0027]"},{"line_number":107,"context_line":"        # Ensure replica is created successfully."}],"source_content_type":"text/x-python","patch_set":19,"id":"45316df0_25d1e541","line":104,"range":{"start_line":101,"start_character":8,"end_line":104,"end_character":73},"in_reply_to":"c6821cf1_05ec4961","updated":"2023-01-24 08:10:12.000000000","message":"Done","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e857014060ddaeb19f8d33cc7d02d7f85bb22b64","unresolved":true,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @decorators.idempotent_id(\u0027c59e3198-062b-4284-8a3b-189a62213573\u0027)"},{"line_number":161,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":162,"context_line":"    @testtools.skipIf("},{"line_number":163,"context_line":"        not CONF.share.multitenancy_enabled, \"Only for multitenancy.\")"},{"line_number":164,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.72\")"},{"line_number":165,"context_line":"    def test_create_share_replica_with_provided_network(self):"},{"line_number":166,"context_line":"        # Create the replica"}],"source_content_type":"text/x-python","patch_set":19,"id":"fd76065d_849a8e03","line":163,"range":{"start_line":162,"start_character":0,"end_line":163,"end_character":70},"updated":"2023-01-18 13:49:45.000000000","message":"You can simply use skipUnless:\n@testtools.skipUnless(CONF.share.multitenancy_enabled, \"Only for multitenancy.\")","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6eaaf313771509e1c016c6602f07af816ff70a7","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @decorators.idempotent_id(\u0027c59e3198-062b-4284-8a3b-189a62213573\u0027)"},{"line_number":161,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":162,"context_line":"    @testtools.skipIf("},{"line_number":163,"context_line":"        not CONF.share.multitenancy_enabled, \"Only for multitenancy.\")"},{"line_number":164,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.72\")"},{"line_number":165,"context_line":"    def test_create_share_replica_with_provided_network(self):"},{"line_number":166,"context_line":"        # Create the replica"}],"source_content_type":"text/x-python","patch_set":19,"id":"b429bba3_840d120b","line":163,"range":{"start_line":162,"start_character":0,"end_line":163,"end_character":70},"in_reply_to":"fd76065d_849a8e03","updated":"2023-01-24 08:10:12.000000000","message":"Done","commit_id":"6c515ed9f3e841a00e4cdbac3aa03ed2957e8403"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4a03040953be7cec8525de8d838870833e23eee5","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            share_net_id \u003d self.sn_id"},{"line_number":108,"context_line":"        share_replica \u003d self.create_share_replica("},{"line_number":109,"context_line":"            self.shares[0][\"id\"], self.replica_zone,"},{"line_number":110,"context_line":"            share_network_id\u003dshare_net_id, cleanup_in_class\u003dFalse)"},{"line_number":111,"context_line":"        share_replicas \u003d self.shares_v2_client.list_share_replicas("},{"line_number":112,"context_line":"            share_id\u003dself.shares[0][\"id\"])[\u0027share_replicas\u0027]"},{"line_number":113,"context_line":"        # Ensure replica is created successfully."}],"source_content_type":"text/x-python","patch_set":22,"id":"2a2df2c1_83588716","line":110,"range":{"start_line":110,"start_character":43,"end_line":110,"end_character":65},"updated":"2023-01-24 09:48:35.000000000","message":"You can remove it.\nThis is already set as a default value.","commit_id":"b2803182e1d3e246096284cfc339facd4418e5d4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f234ad316fd007e45a6d99bf9fa2695e709abe22","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            share_net_id \u003d self.sn_id"},{"line_number":108,"context_line":"        share_replica \u003d self.create_share_replica("},{"line_number":109,"context_line":"            self.shares[0][\"id\"], self.replica_zone,"},{"line_number":110,"context_line":"            share_network_id\u003dshare_net_id, cleanup_in_class\u003dFalse)"},{"line_number":111,"context_line":"        share_replicas \u003d self.shares_v2_client.list_share_replicas("},{"line_number":112,"context_line":"            share_id\u003dself.shares[0][\"id\"])[\u0027share_replicas\u0027]"},{"line_number":113,"context_line":"        # Ensure replica is created successfully."}],"source_content_type":"text/x-python","patch_set":22,"id":"424eee0a_25c25fdb","line":110,"range":{"start_line":110,"start_character":43,"end_line":110,"end_character":65},"in_reply_to":"2a2df2c1_83588716","updated":"2023-01-27 15:58:20.000000000","message":"Done","commit_id":"b2803182e1d3e246096284cfc339facd4418e5d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b0a583a8b64cc16e420153e62e13cf5e0036241","unresolved":true,"context_lines":[{"line_number":162,"context_line":"            raise self.skipException("},{"line_number":163,"context_line":"                msg % \u0027,\u0027.join(constants.REPLICATION_PROMOTION_CHOICES))"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @decorators.idempotent_id(\u0027c59e3198-062b-4284-8a3b-189a62213573\u0027)"},{"line_number":166,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":167,"context_line":"    @testtools.skipUnless("},{"line_number":168,"context_line":"        CONF.share.multitenancy_enabled, \"Only for multitenancy.\")"},{"line_number":169,"context_line":"    @ddt.data("},{"line_number":170,"context_line":"        *utils.deduplicate([constants.MIN_SHARE_REPLICATION_VERSION,"},{"line_number":171,"context_line":"                            constants.SHARE_REPLICA_SHARE_NET_PARAM_VERSION,"},{"line_number":172,"context_line":"                            LATEST_MICROVERSION]))"},{"line_number":173,"context_line":"    def test_create_share_replica_with_provided_network(self, version):"},{"line_number":174,"context_line":"        share_replica \u003d self._verify_create_replica(version)"},{"line_number":175,"context_line":"        self.assertIsNotNone(share_replica)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @decorators.idempotent_id(\u00278858617f-292d-4e5c-9e15-794b7f1b2e3c\u0027)"},{"line_number":178,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"}],"source_content_type":"text/x-python","patch_set":23,"id":"be6650e4_c7a3bc10","line":175,"range":{"start_line":165,"start_character":0,"end_line":175,"end_character":43},"updated":"2023-01-26 15:25:47.000000000","message":"please skip if microversion not supported..","commit_id":"6d3e918cc5d9152160a9dd271e34fe5c68cc9bf4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f234ad316fd007e45a6d99bf9fa2695e709abe22","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            raise self.skipException("},{"line_number":163,"context_line":"                msg % \u0027,\u0027.join(constants.REPLICATION_PROMOTION_CHOICES))"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @decorators.idempotent_id(\u0027c59e3198-062b-4284-8a3b-189a62213573\u0027)"},{"line_number":166,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":167,"context_line":"    @testtools.skipUnless("},{"line_number":168,"context_line":"        CONF.share.multitenancy_enabled, \"Only for multitenancy.\")"},{"line_number":169,"context_line":"    @ddt.data("},{"line_number":170,"context_line":"        *utils.deduplicate([constants.MIN_SHARE_REPLICATION_VERSION,"},{"line_number":171,"context_line":"                            constants.SHARE_REPLICA_SHARE_NET_PARAM_VERSION,"},{"line_number":172,"context_line":"                            LATEST_MICROVERSION]))"},{"line_number":173,"context_line":"    def test_create_share_replica_with_provided_network(self, version):"},{"line_number":174,"context_line":"        share_replica \u003d self._verify_create_replica(version)"},{"line_number":175,"context_line":"        self.assertIsNotNone(share_replica)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @decorators.idempotent_id(\u00278858617f-292d-4e5c-9e15-794b7f1b2e3c\u0027)"},{"line_number":178,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"}],"source_content_type":"text/x-python","patch_set":23,"id":"97791aaa_c678d1de","line":175,"range":{"start_line":165,"start_character":0,"end_line":175,"end_character":43},"in_reply_to":"be6650e4_c7a3bc10","updated":"2023-01-27 15:58:20.000000000","message":"Done","commit_id":"6d3e918cc5d9152160a9dd271e34fe5c68cc9bf4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31a71ff181f56fefb302c30bca758019aa2f7903","unresolved":true,"context_lines":[{"line_number":162,"context_line":"            raise self.skipException("},{"line_number":163,"context_line":"                msg % \u0027,\u0027.join(constants.REPLICATION_PROMOTION_CHOICES))"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @decorators.idempotent_id(\u0027c59e3198-062b-4284-8a3b-189a62213573\u0027)"},{"line_number":166,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":167,"context_line":"    @testtools.skipUnless("},{"line_number":168,"context_line":"        CONF.share.multitenancy_enabled, \"Only for multitenancy.\")"},{"line_number":169,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.72\")"},{"line_number":170,"context_line":"    @ddt.data("},{"line_number":171,"context_line":"        *utils.deduplicate([constants.MIN_SHARE_REPLICATION_VERSION,"},{"line_number":172,"context_line":"                            constants.SHARE_REPLICA_SHARE_NET_PARAM_VERSION,"},{"line_number":173,"context_line":"                            LATEST_MICROVERSION]))"},{"line_number":174,"context_line":"    def test_create_share_replica_with_provided_network(self, version):"},{"line_number":175,"context_line":"        share_replica \u003d self._verify_create_replica(version)"},{"line_number":176,"context_line":"        self.assertIsNotNone(share_replica)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @decorators.idempotent_id(\u00278858617f-292d-4e5c-9e15-794b7f1b2e3c\u0027)"},{"line_number":179,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":180,"context_line":"    def test_add_delete_share_replica(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"9d425fbc_515cb2d3","line":177,"range":{"start_line":165,"start_character":0,"end_line":177,"end_character":0},"updated":"2023-01-26 16:17:00.000000000","message":"Some issues here:\n\nThis test is a duplicate of the other tests; the method \"_verify_create_replica\" in this file always sets the share network if the version is above the \"SHARE_REPLICA_SHARE_NET_PARAM_VERSION\"; so we\u0027d need to fix some things:\n\n1) The skipUnless decorator doesn\u0027t make sense compared to the ddt inputs - i mean, constants.MIN_SHARE_REPLICATION_VERSION is going to be less than \"2.72\" - so no point testing this version with this test, so i\u0027d suggest dropping that version.\n2) When using ddt to specify version, use an inline skip instead of a decorator - like this: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/871775","commit_id":"77ea838fcb1afcdd40a53c2bb008359195cba2eb"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ddfa681b200a4a57e57c3f958e99b66ccc33ee47","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            raise self.skipException("},{"line_number":163,"context_line":"                msg % \u0027,\u0027.join(constants.REPLICATION_PROMOTION_CHOICES))"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @decorators.idempotent_id(\u0027c59e3198-062b-4284-8a3b-189a62213573\u0027)"},{"line_number":166,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":167,"context_line":"    @testtools.skipUnless("},{"line_number":168,"context_line":"        CONF.share.multitenancy_enabled, \"Only for multitenancy.\")"},{"line_number":169,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.72\")"},{"line_number":170,"context_line":"    @ddt.data("},{"line_number":171,"context_line":"        *utils.deduplicate([constants.MIN_SHARE_REPLICATION_VERSION,"},{"line_number":172,"context_line":"                            constants.SHARE_REPLICA_SHARE_NET_PARAM_VERSION,"},{"line_number":173,"context_line":"                            LATEST_MICROVERSION]))"},{"line_number":174,"context_line":"    def test_create_share_replica_with_provided_network(self, version):"},{"line_number":175,"context_line":"        share_replica \u003d self._verify_create_replica(version)"},{"line_number":176,"context_line":"        self.assertIsNotNone(share_replica)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @decorators.idempotent_id(\u00278858617f-292d-4e5c-9e15-794b7f1b2e3c\u0027)"},{"line_number":179,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":180,"context_line":"    def test_add_delete_share_replica(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"ebf793bd_7dd12e1b","line":177,"range":{"start_line":165,"start_character":0,"end_line":177,"end_character":0},"in_reply_to":"9d425fbc_515cb2d3","updated":"2023-01-27 08:37:40.000000000","message":"Done","commit_id":"77ea838fcb1afcdd40a53c2bb008359195cba2eb"}]}