)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"157b5c946e579b5cea1c58dcbc8ffe1670c1313b","unresolved":true,"context_lines":[{"line_number":14,"context_line":"- share type"},{"line_number":15,"context_line":"- share network"},{"line_number":16,"context_line":"- scheduler stats"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I53bb9851445038f81032485817389ec31e2b7341"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":45,"id":"b1494789_e155e08d","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":0},"updated":"2022-02-10 14:44:47.000000000","message":"Lets clarify why we are:\n- testing with the dhss-false job\n- using the dummy driver job\n- running this test job against manila-tempest-plugin","commit_id":"d8b18fb31784bc6db2fdf9afcbeb55fad29e022e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"03cf14c152425391530a19c62a1b5e27a3507a78","unresolved":false,"context_lines":[{"line_number":14,"context_line":"- share type"},{"line_number":15,"context_line":"- share network"},{"line_number":16,"context_line":"- scheduler stats"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I53bb9851445038f81032485817389ec31e2b7341"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":45,"id":"2565fa13_96778c3c","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":0},"in_reply_to":"b1494789_e155e08d","updated":"2022-02-15 13:50:27.000000000","message":"Done","commit_id":"d8b18fb31784bc6db2fdf9afcbeb55fad29e022e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"2810700e47d3a3243b8a6d2c9e27ceed714dfb3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0c089994_31eee3ba","updated":"2021-10-26 17:58:59.000000000","message":"run-DellEMC Unity CI","commit_id":"1ff5209c266d3b94678f40b9b0646873242400d5"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2e5e5e8c6bb92556d7990f4ab9c26a3539f5571d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4e2159bc_bc79c61b","updated":"2021-10-27 12:18:12.000000000","message":"Added \"test_delete_share_type\" test.","commit_id":"c7f2f0097f4019c036f9116167c677da3b354581"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"c6cd4be49e6c4192f8fcc940b313abeecbea865d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4e985ee7_ee9a11f0","updated":"2021-11-01 19:29:09.000000000","message":"Thanks!","commit_id":"4d2cf38fcc9b7f346cac28113fef03d613cc3931"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e5b826c75770decda5fe8fc739e7e9cad7737823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7aa5040c_9049e5a7","updated":"2021-11-18 11:51:17.000000000","message":"recheck","commit_id":"10727230fd6f116f54cc914085d94296224e3e1e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0d47d17e00999f9c47e061ef06c0cb13038ef3ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b5fd4cca_3ec32958","updated":"2021-11-18 11:12:28.000000000","message":"recheck","commit_id":"10727230fd6f116f54cc914085d94296224e3e1e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5bf21294ff5e39d76a6301d24274f17a1eafc37a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"4553bd57_2d39eed9","updated":"2021-12-08 15:50:58.000000000","message":"recheck","commit_id":"ea0d3124c1832141e460e34e4553725aecbf53fd"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b2f9f0dce38430470c33877da3e6d97ed09aa5fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"f8e3bcc1_8215b442","updated":"2021-12-13 09:31:57.000000000","message":"recheck","commit_id":"ea0d3124c1832141e460e34e4553725aecbf53fd"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0bd62c293db5635e7ab3961a9c3ccf19460f88c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"f9cba6bb_6e7690c4","updated":"2021-12-12 17:15:31.000000000","message":"recheck","commit_id":"ea0d3124c1832141e460e34e4553725aecbf53fd"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"36f00606db37f060a3f6d2f5e8b7dd827fe7e2ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"fa9065f9_7a2597d4","updated":"2021-12-12 11:40:00.000000000","message":"recheck","commit_id":"ea0d3124c1832141e460e34e4553725aecbf53fd"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c830a9b0fc1f28080fbc3b97f5bb268224b3893e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"54cf68c4_630a7552","updated":"2021-12-14 09:56:32.000000000","message":"recheck","commit_id":"ec3897c9c964b69b8e79488605496915234d5ec9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bd2847c62114e08a69a9630544b73b7e14b2d8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"8d1c5f3c_58447e86","updated":"2021-12-14 19:45:57.000000000","message":"recheck","commit_id":"ec3897c9c964b69b8e79488605496915234d5ec9"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"42298cca5374bb366dae3cbb447b4f763b9dece4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"4e9f4a5c_dc4e7591","updated":"2021-12-22 16:14:18.000000000","message":"recheck","commit_id":"357f4adcbe06917f0fb8ed9a29c5cb82b913ff41"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cac6abe775d6a28d2d6d90de969397d0ae3efd6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"79216f90_b6a30300","updated":"2022-01-27 21:24:45.000000000","message":"Thanks for working on this change, Liron\nI have few questions and addressed comments with them. Please check them inline","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3e277d812ec85e741c6abaf9da1fe883dc459789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"c9f4baea_ae70f2b1","updated":"2022-01-30 13:07:54.000000000","message":"Thank you so much Carlos for reviewing the patch!","commit_id":"b77bded811dbc4e407f82ea6ca4d4037dc4ed450"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"444208fbe2fee6a28e3c38ffa92d6052a6e68d0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"0527e38c_7da7e8d3","updated":"2022-02-23 05:40:02.000000000","message":"recheck","commit_id":"167a8d72c26d69732a9af012ad12d32de1d3b5ca"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c75e9643b54146526e7ffdb5f172d2cfe9e1ecf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":53,"id":"1218314e_8b8690fb","updated":"2022-06-17 19:30:42.000000000","message":"Thank you for the changes, Liron! Found a couple more things that I thought were worth it to raise the question. Sorry for taking too long to revisit this :)\nIf you have any question or would like to discuss something with me, please ping :)","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fa7cf1dd328340efd58d87f2bd26ad17956da3a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":59,"id":"fc41c490_092b792e","updated":"2022-06-19 11:42:33.000000000","message":"Thanks for the comments Carlos!\nThe following gates seem to be broken, not related to this patch:\nmanila-tempest-plugin-lvm-yoga \nmanila-tempest-plugin-lvm-xena\nmanila-tempest-plugin-lvm-wallaby\n","commit_id":"6f0ed4b3be78bb54d90c302b2a26e6c2cb3a036a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4f7ab65dd2f2e73f94c2ad1d5efa85298625f903","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":59,"id":"d0ddafc1_068e3a55","updated":"2022-06-23 04:16:29.000000000","message":"recheck","commit_id":"6f0ed4b3be78bb54d90c302b2a26e6c2cb3a036a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"24a678ffcf268a158dc387bc4552e9f4c33618c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":59,"id":"8e8e976b_04a5f757","updated":"2022-06-22 15:17:13.000000000","message":"recheck\nStable jobs have been fixed","commit_id":"6f0ed4b3be78bb54d90c302b2a26e6c2cb3a036a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ef3da34db65bd2a6552c285057ab6fe660ea2002","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":61,"id":"2f8c8a8d_5fba969d","updated":"2022-07-07 14:22:44.000000000","message":"Did not encounter any other major issues.\nThank you for the change","commit_id":"de50b183f0ee11651164f148aedf317833b0985d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"14b3a133a89b54d6d9e2d5f1978f8534b5e330fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":62,"id":"244c183a_d2e95a2f","updated":"2022-09-13 13:10:59.000000000","message":"Recheck\nChange looks good - thank you, Liron\nComments could be addressed in a separate follow-up change. Doing a recheck and waiting for the results to add my +2.","commit_id":"28bf7d7505341b6d39dd3c81cc2c152e4f386f44"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"7e3e5d1710f31517f1b9effb7f3ca06dea9aaca4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":62,"id":"c20a30de_b1c3c088","updated":"2022-09-13 12:59:38.000000000","message":"Tests passed in local env as well, looks good. Thanks Liron.","commit_id":"28bf7d7505341b6d39dd3c81cc2c152e4f386f44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8b3ae94f4eeaad1225fb7e237f43f46673adc430","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"c86398d2_999a4ba9","updated":"2022-09-14 11:50:37.000000000","message":"LGTM, thank you Liron!","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"eda75dee1c317e8f12fba324740192531f7b6d59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"0411918d_d804f67c","updated":"2022-09-14 15:42:50.000000000","message":"Latest changes look good, thanks.","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"cf0f8cae_069e5b05","updated":"2022-09-14 22:53:04.000000000","message":"Thank you very much for working on this and for your patience with the reviews Liron; as we discussed on a recent call, the direction for Secure RBAC defaults shifted in Zed (https://review.opendev.org/c/openstack/manila/+/856394); the good thing is that most of your tests would work if we adjusted some of the expectations in them. I think this is great coverage for the CRUD operations with these resources! So thank you!","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"ecc29ccb73687da3736d54b8539e331cf16abad1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"1ee138c0_25ad94fe","updated":"2022-09-14 06:40:32.000000000","message":"recheck","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"98b89d38bbdb397cbb81ebd8e1853c7d05fa4bdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"faa05746_c75a2a80","updated":"2022-09-14 04:45:41.000000000","message":"recheck","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6738ce36561aea39b1617e7fa3cba5ebe17a5028","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"39a5d7a0_69ca7b48","updated":"2022-09-21 15:08:42.000000000","message":"Added a devstack plugin patch as dependency to get the test job unblocked... ","commit_id":"1b2e2aee83f9e9119475259af4f6d4777ac41832"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"32b9632dca3ca7181699f8322a603b15f41d2d4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"1cdfa749_e8b47a60","updated":"2022-09-21 19:32:24.000000000","message":"One issue with the tests.. ","commit_id":"1b2e2aee83f9e9119475259af4f6d4777ac41832"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9c2ebd701f7883090156b6e836e1fc3035be30a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"3cc0cac9_32397ba9","updated":"2022-09-21 19:48:54.000000000","message":"Rest of the changes look great. I\u0027ll +2 once you fix this up, thanks Liron!","commit_id":"1b2e2aee83f9e9119475259af4f6d4777ac41832"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1672d7336dae12d5cc9b0d28cc60375af0cea46c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"31aa4925_787c8253","updated":"2022-09-22 13:59:44.000000000","message":"Changes LGTM, CI is happy. Thanks!","commit_id":"2d497becce94bcf813b780cb271a843b47122d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77eb3cacf77f8a4a08d5bbccdfb3d52d8f84efac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"02998e0e_a3b51395","updated":"2022-09-22 15:21:38.000000000","message":"LGTM! Thanks for your hard work on this Liron!","commit_id":"2d497becce94bcf813b780cb271a843b47122d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a8b53c5185fea891e75925f000e83ecc4b8da07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"1f11f00b_8864abe9","updated":"2022-09-30 00:51:37.000000000","message":"Pulling back votes because this patch needs to change based on a recent bugfix: https://review.opendev.org/c/openstack/manila/+/857807... \n\nStrange how these tests ran fine after that patch had merged - perhaps a race in the CI","commit_id":"2d497becce94bcf813b780cb271a843b47122d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"259f65d785c5c9416ef0d37b159466c767a33aa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"00858820_f595860a","updated":"2022-09-29 16:59:02.000000000","message":"recheck\n\nnode issue","commit_id":"2d497becce94bcf813b780cb271a843b47122d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7ca38fe93c2563495d14c1549abc3ef3b71af33a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"fdf77599_1da3cf58","updated":"2022-09-29 22:02:24.000000000","message":"recheck\n\nthe scenario test \"test_create_extend_and_write\" has failed twice in a row now; i wonder if we need to workaround any disk limitations here.","commit_id":"2d497becce94bcf813b780cb271a843b47122d0b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6eee22673c94e70dc533efdff6d153ba52d952d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"5579b83a_250118d8","updated":"2022-09-23 14:59:29.000000000","message":"recheck\nSSH Timeout on the lvm job. Let\u0027s try again","commit_id":"2d497becce94bcf813b780cb271a843b47122d0b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b08984cc0545a4342565e7c910146bbce6aa2594","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":68,"id":"a67f0a0d_b144c431","updated":"2022-09-23 12:45:19.000000000","message":"recheck\nZuul apparently didn\u0027t run","commit_id":"2d497becce94bcf813b780cb271a843b47122d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9d3b58afed8a8c79127f9d44cd9779e8209a6af7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":70,"id":"24fb60e6_e7c013ff","updated":"2022-10-03 20:00:46.000000000","message":"LGTM, thank you Liron!","commit_id":"7b2566a61ef2dc2d4c84460b54ded70d11ed4a79"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b946df9db7e5e3a385883bfe990355a3a7f59ade","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":70,"id":"26445ef5_9f0d6920","updated":"2022-10-04 12:07:58.000000000","message":"LGTM, thank you for the hard work Liron!\nLet\u0027s finally get this in","commit_id":"7b2566a61ef2dc2d4c84460b54ded70d11ed4a79"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"73bc1efe6dd759a3e948a889420283660ea7fbd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":70,"id":"41808e45_d71fb30c","updated":"2022-10-03 05:53:42.000000000","message":"recheck","commit_id":"7b2566a61ef2dc2d4c84460b54ded70d11ed4a79"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f01b9014650f634aaed28e503aee9b51b4708dba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":70,"id":"85fba7f5_d713105e","updated":"2022-10-02 11:13:56.000000000","message":"recheck","commit_id":"7b2566a61ef2dc2d4c84460b54ded70d11ed4a79"}],"manila_tempest_tests/tests/rbac/base.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cac6abe775d6a28d2d6d90de969397d0ae3efd6f","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(ShareRbacBaseTests, cls).skip_checks()"},{"line_number":36,"context_line":"        if not CONF.enforce_scope.manila:"},{"line_number":37,"context_line":"            raise cls.skipException("},{"line_number":38,"context_line":"                \"Tempest is not configured to enforce_scope for manila, \""},{"line_number":39,"context_line":"                \"skipping RBAC tests. To enable these tests set \""}],"source_content_type":"text/x-python","patch_set":35,"id":"6829ffea_5b8ae903","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":41},"updated":"2022-01-27 21:24:45.000000000","message":"this ties if the tests should be run to a tempest variable. Should we also have another validation to check the manila version?","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c75e9643b54146526e7ffdb5f172d2cfe9e1ecf1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(ShareRbacBaseTests, cls).skip_checks()"},{"line_number":36,"context_line":"        if not CONF.enforce_scope.manila:"},{"line_number":37,"context_line":"            raise cls.skipException("},{"line_number":38,"context_line":"                \"Tempest is not configured to enforce_scope for manila, \""},{"line_number":39,"context_line":"                \"skipping RBAC tests. To enable these tests set \""}],"source_content_type":"text/x-python","patch_set":35,"id":"bf6deb47_89c90379","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":41},"in_reply_to":"2a055744_09549454","updated":"2022-06-17 19:30:42.000000000","message":"Ack","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3e277d812ec85e741c6abaf9da1fe883dc459789","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"},{"line_number":35,"context_line":"        super(ShareRbacBaseTests, cls).skip_checks()"},{"line_number":36,"context_line":"        if not CONF.enforce_scope.manila:"},{"line_number":37,"context_line":"            raise cls.skipException("},{"line_number":38,"context_line":"                \"Tempest is not configured to enforce_scope for manila, \""},{"line_number":39,"context_line":"                \"skipping RBAC tests. To enable these tests set \""}],"source_content_type":"text/x-python","patch_set":35,"id":"2a055744_09549454","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":41},"in_reply_to":"6829ffea_5b8ae903","updated":"2022-01-30 13:07:54.000000000","message":"I don\u0027t think there is a need.\nIf the environment support rbac then the tests can be run.\nAnd it\u0027s not really a manila feature but a keystone feature.","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":40,"context_line":"                \"`tempest.conf [enforce_scope] manila\u003dTrue`.\""},{"line_number":41,"context_line":"            )"},{"line_number":42,"context_line":"        if not CONF.share.default_share_type_name:"},{"line_number":43,"context_line":"            raise cls.skipException(\"Secure rbac tests requires a default \""},{"line_number":44,"context_line":"                                    \"share type\")"},{"line_number":45,"context_line":"        if not any(p in CONF.share.enable_protocols for p in cls.protocols):"},{"line_number":46,"context_line":"            message \u003d \"%s tests are disabled\" % cls.protocol"}],"source_content_type":"text/x-python","patch_set":63,"id":"0eadb817_b9a59330","line":43,"range":{"start_line":43,"start_character":55,"end_line":43,"end_character":63},"updated":"2022-09-14 22:53:04.000000000","message":"nit: require","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                \"`tempest.conf [enforce_scope] manila\u003dTrue`.\""},{"line_number":41,"context_line":"            )"},{"line_number":42,"context_line":"        if not CONF.share.default_share_type_name:"},{"line_number":43,"context_line":"            raise cls.skipException(\"Secure rbac tests requires a default \""},{"line_number":44,"context_line":"                                    \"share type\")"},{"line_number":45,"context_line":"        if not any(p in CONF.share.enable_protocols for p in cls.protocols):"},{"line_number":46,"context_line":"            message \u003d \"%s tests are disabled\" % cls.protocol"}],"source_content_type":"text/x-python","patch_set":63,"id":"4dc9d100_01075613","line":43,"range":{"start_line":43,"start_character":55,"end_line":43,"end_character":63},"in_reply_to":"0eadb817_b9a59330","updated":"2022-09-15 09:56:13.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @classmethod"},{"line_number":105,"context_line":"    def get_share_type(cls):"},{"line_number":106,"context_line":"        if CONF.share.default_share_type_name:"},{"line_number":107,"context_line":"            return cls.shares_v2_client.get_default_share_type()[\u0027share_type\u0027]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def do_request(self, method, expected_status\u003d200, client\u003dNone, **payload):"}],"source_content_type":"text/x-python","patch_set":63,"id":"189defd3_c8444973","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":46},"updated":"2022-09-14 22:53:04.000000000","message":"this condition is being checked in the skip_checks","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @classmethod"},{"line_number":105,"context_line":"    def get_share_type(cls):"},{"line_number":106,"context_line":"        if CONF.share.default_share_type_name:"},{"line_number":107,"context_line":"            return cls.shares_v2_client.get_default_share_type()[\u0027share_type\u0027]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def do_request(self, method, expected_status\u003d200, client\u003dNone, **payload):"}],"source_content_type":"text/x-python","patch_set":63,"id":"c83d83a6_d472e5c3","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":46},"in_reply_to":"189defd3_c8444973","updated":"2022-09-15 09:56:13.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            return response"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @classmethod"},{"line_number":122,"context_line":"    def setup_user_client(cls, client, project_id\u003dNone):"},{"line_number":123,"context_line":"        \"\"\"Set up project user with its own client."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        This is useful for testing protection of resources in separate"}],"source_content_type":"text/x-python","patch_set":63,"id":"e36c3932_9b3d85c0","line":122,"range":{"start_line":122,"start_character":0,"end_line":122,"end_character":56},"updated":"2022-09-14 22:53:04.000000000","message":"Should be mitigated with https://bugs.launchpad.net/tempest/+bug/1964509\n\nMaybe we should add a note here..","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            return response"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @classmethod"},{"line_number":122,"context_line":"    def setup_user_client(cls, client, project_id\u003dNone):"},{"line_number":123,"context_line":"        \"\"\"Set up project user with its own client."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        This is useful for testing protection of resources in separate"}],"source_content_type":"text/x-python","patch_set":63,"id":"39432fbb_a6a52aea","line":122,"range":{"start_line":122,"start_character":0,"end_line":122,"end_character":56},"in_reply_to":"e36c3932_9b3d85c0","updated":"2022-09-15 09:56:13.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"}],"manila_tempest_tests/tests/rbac/test_scheduler_stats.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c75e9643b54146526e7ffdb5f172d2cfe9e1ecf1","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    credentials \u003d [\u0027project_admin\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @decorators.idempotent_id(\u00271ec4d0f5-0d60-4bbc-88a4-57fa92f6f62f\u0027)"},{"line_number":48,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":49,"context_line":"    def test_list_storage_pools(self):"},{"line_number":50,"context_line":"        self.do_request("},{"line_number":51,"context_line":"            \u0027list_pools\u0027, expected_status\u003dlib_exc.Forbidden)"}],"source_content_type":"text/x-python","patch_set":53,"id":"2a21e99a_14e34ecf","line":48,"range":{"start_line":48,"start_character":13,"end_line":48,"end_character":30},"updated":"2022-06-17 19:30:42.000000000","message":"As this is TAG_POSITIVE, are we really expecting the status of this request to be lib_exc.Forbidden?\nEven if it is, for me sounds a bit tricky to tag it as positive and expect a request. I\u0027ll check on other occurrences and see how this is working :)","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fa7cf1dd328340efd58d87f2bd26ad17956da3a9","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    credentials \u003d [\u0027project_admin\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @decorators.idempotent_id(\u00271ec4d0f5-0d60-4bbc-88a4-57fa92f6f62f\u0027)"},{"line_number":48,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":49,"context_line":"    def test_list_storage_pools(self):"},{"line_number":50,"context_line":"        self.do_request("},{"line_number":51,"context_line":"            \u0027list_pools\u0027, expected_status\u003dlib_exc.Forbidden)"}],"source_content_type":"text/x-python","patch_set":53,"id":"2ec9f49d_97af3656","line":48,"range":{"start_line":48,"start_character":13,"end_line":48,"end_character":30},"in_reply_to":"2a21e99a_14e34ecf","updated":"2022-06-19 11:42:33.000000000","message":"It should be tagged as negative test.\nAs I understand it only admin user in the scope of system has the permissions\nfor this action.","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ef3da34db65bd2a6552c285057ab6fe660ea2002","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    credentials \u003d [\u0027project_admin\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @decorators.idempotent_id(\u00271ec4d0f5-0d60-4bbc-88a4-57fa92f6f62f\u0027)"},{"line_number":48,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":49,"context_line":"    def test_list_storage_pools(self):"},{"line_number":50,"context_line":"        self.do_request("},{"line_number":51,"context_line":"            \u0027list_pools\u0027, expected_status\u003dlib_exc.Forbidden)"}],"source_content_type":"text/x-python","patch_set":53,"id":"e24c53ad_d146025a","line":48,"range":{"start_line":48,"start_character":13,"end_line":48,"end_character":30},"in_reply_to":"2ec9f49d_97af3656","updated":"2022-07-07 14:22:44.000000000","message":"Ack","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c75e9643b54146526e7ffdb5f172d2cfe9e1ecf1","unresolved":true,"context_lines":[{"line_number":104,"context_line":"class TestProjectMemberTestsCIFS(ProjectMemberTests):"},{"line_number":105,"context_line":"    protocol \u003d \"cifs\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class TestProjectReaderTestsCIFS(ProjectReaderTests):"},{"line_number":109,"context_line":"    protocol \u003d \"cifs\""}],"source_content_type":"text/x-python","patch_set":53,"id":"7e3a0878_e1ccb8d4","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":21},"updated":"2022-06-17 19:30:42.000000000","message":"same comment about the protocols in the other file :)","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fa7cf1dd328340efd58d87f2bd26ad17956da3a9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"class TestProjectMemberTestsCIFS(ProjectMemberTests):"},{"line_number":105,"context_line":"    protocol \u003d \"cifs\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class TestProjectReaderTestsCIFS(ProjectReaderTests):"},{"line_number":109,"context_line":"    protocol \u003d \"cifs\""}],"source_content_type":"text/x-python","patch_set":53,"id":"6d5fcafd_918cac03","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":21},"in_reply_to":"7e3a0878_e1ccb8d4","updated":"2022-06-19 11:42:33.000000000","message":"Done","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    credentials \u003d [\u0027project_admin\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @decorators.idempotent_id(\u00271ec4d0f5-0d60-4bbc-88a4-57fa92f6f62f\u0027)"},{"line_number":48,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":49,"context_line":"    def test_list_storage_pools(self):"},{"line_number":50,"context_line":"        self.do_request("},{"line_number":51,"context_line":"            \u0027list_pools\u0027, expected_status\u003dlib_exc.Forbidden)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class ProjectMemberTests(ShareRbacSchedulerStatsTests, base.BaseSharesTest):"}],"source_content_type":"text/x-python","patch_set":63,"id":"9db0e0d1_3e7cbc4a","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":60},"updated":"2022-09-14 22:53:04.000000000","message":"In Zed, we\u0027re going to allow anyone with role:admin to perform this action: https://review.opendev.org/c/openstack/manila/+/856394","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    credentials \u003d [\u0027project_admin\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @decorators.idempotent_id(\u00271ec4d0f5-0d60-4bbc-88a4-57fa92f6f62f\u0027)"},{"line_number":48,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":49,"context_line":"    def test_list_storage_pools(self):"},{"line_number":50,"context_line":"        self.do_request("},{"line_number":51,"context_line":"            \u0027list_pools\u0027, expected_status\u003dlib_exc.Forbidden)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class ProjectMemberTests(ShareRbacSchedulerStatsTests, base.BaseSharesTest):"}],"source_content_type":"text/x-python","patch_set":63,"id":"7206ed11_9d8813ca","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":60},"in_reply_to":"46623bb2_969776f9","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    credentials \u003d [\u0027project_admin\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @decorators.idempotent_id(\u00271ec4d0f5-0d60-4bbc-88a4-57fa92f6f62f\u0027)"},{"line_number":48,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":49,"context_line":"    def test_list_storage_pools(self):"},{"line_number":50,"context_line":"        self.do_request("},{"line_number":51,"context_line":"            \u0027list_pools\u0027, expected_status\u003dlib_exc.Forbidden)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class ProjectMemberTests(ShareRbacSchedulerStatsTests, base.BaseSharesTest):"}],"source_content_type":"text/x-python","patch_set":63,"id":"46623bb2_969776f9","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":60},"in_reply_to":"9db0e0d1_3e7cbc4a","updated":"2022-09-15 09:56:13.000000000","message":"So I guess I need to set this patch as dependent on https://review.opendev.org/c/openstack/manila/+/856394\n\nOtherwise all tests will fail","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"}],"manila_tempest_tests/tests/rbac/test_share_network.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c75e9643b54146526e7ffdb5f172d2cfe9e1ecf1","unresolved":true,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    In order to test certain share operations we must create a share network"},{"line_number":230,"context_line":"    resource for this. Since reader user is limited in resources creation, we"},{"line_number":231,"context_line":"    are forced  to user admin credentials, so we can test other share"},{"line_number":232,"context_line":"    operations. In this class we use admin user to create a member user within"},{"line_number":233,"context_line":"    reader project. That way we can perform a reader actions on this resource."},{"line_number":234,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":53,"id":"52f62ae1_a413e9db","line":231,"range":{"start_line":231,"start_character":19,"end_line":231,"end_character":23},"updated":"2022-06-17 19:30:42.000000000","message":"nit: use","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fa7cf1dd328340efd58d87f2bd26ad17956da3a9","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    In order to test certain share operations we must create a share network"},{"line_number":230,"context_line":"    resource for this. Since reader user is limited in resources creation, we"},{"line_number":231,"context_line":"    are forced  to user admin credentials, so we can test other share"},{"line_number":232,"context_line":"    operations. In this class we use admin user to create a member user within"},{"line_number":233,"context_line":"    reader project. That way we can perform a reader actions on this resource."},{"line_number":234,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":53,"id":"d5a08c01_9a14db6d","line":231,"range":{"start_line":231,"start_character":19,"end_line":231,"end_character":23},"in_reply_to":"52f62ae1_a413e9db","updated":"2022-06-19 11:42:33.000000000","message":"Done","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c75e9643b54146526e7ffdb5f172d2cfe9e1ecf1","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            sn_id\u003dalt_share_network[\u0027id\u0027], name\u003dname)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"class TestProjectAdminTestsNFS(ProjectAdminTests):"},{"line_number":295,"context_line":"    protocol \u003d \"nfs\""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"class TestProjectMemberTestsNFS(ProjectMemberTests):"},{"line_number":299,"context_line":"    protocol \u003d \"nfs\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"class TestProjectReaderTestsNFS(ProjectReaderTests):"},{"line_number":303,"context_line":"    protocol \u003d \"nfs\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"class TestProjectAdminTestsCEPHFS(ProjectAdminTests):"},{"line_number":307,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"class TestProjectMemberTestsCEPHFS(ProjectMemberTests):"},{"line_number":311,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":312,"context_line":""},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"class TestProjectReaderTestsCEPHFS(ProjectReaderTests):"},{"line_number":315,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"class TestProjectAdminTestsCIFS(ProjectAdminTests):"},{"line_number":319,"context_line":"    protocol \u003d \"cifs\""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"class TestProjectMemberTestsCIFS(ProjectMemberTests):"},{"line_number":323,"context_line":"    protocol \u003d \"cifs\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"class TestProjectReaderTestsCIFS(ProjectReaderTests):"},{"line_number":327,"context_line":"    protocol \u003d \"cifs\""}],"source_content_type":"text/x-python","patch_set":53,"id":"c46f69a5_6158bf99","line":327,"range":{"start_line":294,"start_character":0,"end_line":327,"end_character":21},"updated":"2022-06-17 19:30:42.000000000","message":"This file may not need tests for different protocols, considering that the protocols won\u0027t be used, as we are not creating shares here...","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fa7cf1dd328340efd58d87f2bd26ad17956da3a9","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            sn_id\u003dalt_share_network[\u0027id\u0027], name\u003dname)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"class TestProjectAdminTestsNFS(ProjectAdminTests):"},{"line_number":295,"context_line":"    protocol \u003d \"nfs\""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"class TestProjectMemberTestsNFS(ProjectMemberTests):"},{"line_number":299,"context_line":"    protocol \u003d \"nfs\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"class TestProjectReaderTestsNFS(ProjectReaderTests):"},{"line_number":303,"context_line":"    protocol \u003d \"nfs\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"class TestProjectAdminTestsCEPHFS(ProjectAdminTests):"},{"line_number":307,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"class TestProjectMemberTestsCEPHFS(ProjectMemberTests):"},{"line_number":311,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":312,"context_line":""},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"class TestProjectReaderTestsCEPHFS(ProjectReaderTests):"},{"line_number":315,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"class TestProjectAdminTestsCIFS(ProjectAdminTests):"},{"line_number":319,"context_line":"    protocol \u003d \"cifs\""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"class TestProjectMemberTestsCIFS(ProjectMemberTests):"},{"line_number":323,"context_line":"    protocol \u003d \"cifs\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"class TestProjectReaderTestsCIFS(ProjectReaderTests):"},{"line_number":327,"context_line":"    protocol \u003d \"cifs\""}],"source_content_type":"text/x-python","patch_set":53,"id":"c5772c05_84d5495e","line":327,"range":{"start_line":294,"start_character":0,"end_line":327,"end_character":21},"in_reply_to":"c46f69a5_6158bf99","updated":"2022-06-19 11:42:33.000000000","message":"Done","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"}],"manila_tempest_tests/tests/rbac/test_share_types.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cac6abe775d6a28d2d6d90de969397d0ae3efd6f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3efeb1de_f102acfa","line":190,"updated":"2022-01-27 21:24:45.000000000","message":"should we also test CIFS protocol?","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3e277d812ec85e741c6abaf9da1fe883dc459789","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"9f1f8bcc_a1ae41de","line":190,"in_reply_to":"3efeb1de_f102acfa","updated":"2022-01-30 13:07:54.000000000","message":"Thanks! Done!","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fa7cf1dd328340efd58d87f2bd26ad17956da3a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"81d0415d_7ec5fe65","line":190,"in_reply_to":"57973b15_058f497e","updated":"2022-06-19 11:42:33.000000000","message":"Done","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c75e9643b54146526e7ffdb5f172d2cfe9e1ecf1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"57973b15_058f497e","line":190,"in_reply_to":"9f1f8bcc_a1ae41de","updated":"2022-06-17 19:30:42.000000000","message":"Thanks - But it got me thinking if we need different protocols for this file as well, as mentioned in the comment from the previous file :)","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ef3da34db65bd2a6552c285057ab6fe660ea2002","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @decorators.idempotent_id(\u0027b24bf137-352a-4ebd-b736-27518d32c1bd\u0027)"},{"line_number":81,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":82,"context_line":"    def test_create_share_type(self):"},{"line_number":83,"context_line":"        self.do_request("},{"line_number":84,"context_line":"            \u0027create_share_type\u0027, expected_status\u003dlib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":59,"id":"61a80d75_48b9ef31","line":81,"range":{"start_line":81,"start_character":18,"end_line":81,"end_character":30},"updated":"2022-07-07 14:22:44.000000000","message":"shouldn\u0027t this be negative, as it is raising an exception?","commit_id":"6f0ed4b3be78bb54d90c302b2a26e6c2cb3a036a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c5630c46a5dbd3453cdde9a8a671a1b1d475190f","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @decorators.idempotent_id(\u0027b24bf137-352a-4ebd-b736-27518d32c1bd\u0027)"},{"line_number":81,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":82,"context_line":"    def test_create_share_type(self):"},{"line_number":83,"context_line":"        self.do_request("},{"line_number":84,"context_line":"            \u0027create_share_type\u0027, expected_status\u003dlib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":59,"id":"d8cddea9_3c8a601c","line":81,"range":{"start_line":81,"start_character":18,"end_line":81,"end_character":30},"in_reply_to":"61a80d75_48b9ef31","updated":"2022-07-07 15:11:46.000000000","message":"Thanks\nDone","commit_id":"6f0ed4b3be78bb54d90c302b2a26e6c2cb3a036a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"14b3a133a89b54d6d9e2d5f1978f8534b5e330fb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @decorators.idempotent_id(\u0027b24bf137-352a-4ebd-b736-27518d32c1bd\u0027)"},{"line_number":81,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":82,"context_line":"    def test_create_share_type(self):"},{"line_number":83,"context_line":"        self.do_request("},{"line_number":84,"context_line":"            \u0027create_share_type\u0027, expected_status\u003dlib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":59,"id":"4bcf717f_348abf93","line":81,"range":{"start_line":81,"start_character":18,"end_line":81,"end_character":30},"in_reply_to":"d8cddea9_3c8a601c","updated":"2022-09-13 13:10:59.000000000","message":"Done","commit_id":"6f0ed4b3be78bb54d90c302b2a26e6c2cb3a036a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":80,"context_line":"    @decorators.idempotent_id(\u0027b24bf137-352a-4ebd-b736-27518d32c1bd\u0027)"},{"line_number":81,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":82,"context_line":"    def test_create_share_type(self):"},{"line_number":83,"context_line":"        self.do_request("},{"line_number":84,"context_line":"            \u0027create_share_type\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":85,"context_line":"            **self.share_type_properties())"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027741d69f3-b3fe-49cf-9e33-6b0696b353ec\u0027)"},{"line_number":88,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":63,"id":"fd0f1c3e_7a30fdee","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":43},"updated":"2022-09-14 22:53:04.000000000","message":"anyone with role:admin will be able to create share types in zed/beyond when enforce_scope and enable_new_defaults are set to True: https://review.opendev.org/c/openstack/manila/+/856394","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @decorators.idempotent_id(\u0027b24bf137-352a-4ebd-b736-27518d32c1bd\u0027)"},{"line_number":81,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":82,"context_line":"    def test_create_share_type(self):"},{"line_number":83,"context_line":"        self.do_request("},{"line_number":84,"context_line":"            \u0027create_share_type\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":85,"context_line":"            **self.share_type_properties())"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027741d69f3-b3fe-49cf-9e33-6b0696b353ec\u0027)"},{"line_number":88,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":63,"id":"89ab37f7_091b464e","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":43},"in_reply_to":"fd0f1c3e_7a30fdee","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class ProjectReaderTests(ShareRbacShareTypesTests, base.BaseSharesTest):"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_member\u0027, \u0027project_alt_member\u0027]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @decorators.idempotent_id(\u0027f4c352c4-c12b-4722-9fe7-9a2ec639ee63\u0027)"},{"line_number":155,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":63,"id":"8fca2c9d_6115ec31","line":152,"range":{"start_line":152,"start_character":55,"end_line":152,"end_character":75},"updated":"2022-09-14 22:53:04.000000000","message":"no tests are being added for this, so we can drop it?","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class ProjectReaderTests(ShareRbacShareTypesTests, base.BaseSharesTest):"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_member\u0027, \u0027project_alt_member\u0027]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @decorators.idempotent_id(\u0027f4c352c4-c12b-4722-9fe7-9a2ec639ee63\u0027)"},{"line_number":155,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":63,"id":"6ab95fc3_d54db5b1","line":152,"range":{"start_line":152,"start_character":55,"end_line":152,"end_character":75},"in_reply_to":"8fca2c9d_6115ec31","updated":"2022-09-15 09:56:13.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"}],"manila_tempest_tests/tests/rbac/test_shares.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fbf999893979e0e8bcab49adb68b00c4ef078080","unresolved":true,"context_lines":[{"line_number":445,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], new_size\u003d2)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        @decorators.idempotent_id(\u002720d6360d-5cea-4305-be36-7e1429007598\u0027)"},{"line_number":448,"context_line":"        @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":449,"context_line":"        def test_rename_share(self):"},{"line_number":450,"context_line":"            share \u003d self.create_share("},{"line_number":451,"context_line":"                self.share_member_client, self.share_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"16dac057_285d5602","line":448,"range":{"start_line":448,"start_character":22,"end_line":448,"end_character":34},"updated":"2021-11-01 14:39:03.000000000","message":"TAG_NEGATIVE. because it\u0027s a negative test.","commit_id":"083f36a8f0e64002a693f3f1e4fa94685cbc331a"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"c6cd4be49e6c4192f8fcc940b313abeecbea865d","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], new_size\u003d2)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        @decorators.idempotent_id(\u002720d6360d-5cea-4305-be36-7e1429007598\u0027)"},{"line_number":448,"context_line":"        @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":449,"context_line":"        def test_rename_share(self):"},{"line_number":450,"context_line":"            share \u003d self.create_share("},{"line_number":451,"context_line":"                self.share_member_client, self.share_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"abaa13ee_d7e136d7","line":448,"range":{"start_line":448,"start_character":22,"end_line":448,"end_character":34},"in_reply_to":"16dac057_285d5602","updated":"2021-11-01 19:29:09.000000000","message":"Done","commit_id":"083f36a8f0e64002a693f3f1e4fa94685cbc331a"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"7097a2ccf0bbe1c2bbc5e8fc9b046d0a83c418fa","unresolved":true,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u0027d6014579-d772-441a-a9b1-01b1e87caeaa\u0027)"},{"line_number":210,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":211,"context_line":"    def test_set_share_metadata(self):"},{"line_number":212,"context_line":"        share \u003d self.create_share("},{"line_number":213,"context_line":"            self.share_member_client, self.share_type[\u0027id\u0027])"},{"line_number":214,"context_line":"        self.do_request("}],"source_content_type":"text/x-python","patch_set":35,"id":"7015e6ed_49dcd12b","line":211,"updated":"2022-01-18 12:08:50.000000000","message":"Thanks for adding this test. Consider adding negative case for this test.","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"7e3e5d1710f31517f1b9effb7f3ca06dea9aaca4","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u0027d6014579-d772-441a-a9b1-01b1e87caeaa\u0027)"},{"line_number":210,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":211,"context_line":"    def test_set_share_metadata(self):"},{"line_number":212,"context_line":"        share \u003d self.create_share("},{"line_number":213,"context_line":"            self.share_member_client, self.share_type[\u0027id\u0027])"},{"line_number":214,"context_line":"        self.do_request("}],"source_content_type":"text/x-python","patch_set":35,"id":"6329dcbd_746b791d","line":211,"in_reply_to":"182e21aa_a068d3d6","updated":"2022-09-13 12:59:38.000000000","message":"Ack","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"aedede1c7ca768084e7ba04939a47f0b3df3d9c1","unresolved":true,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @decorators.idempotent_id(\u0027d6014579-d772-441a-a9b1-01b1e87caeaa\u0027)"},{"line_number":210,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":211,"context_line":"    def test_set_share_metadata(self):"},{"line_number":212,"context_line":"        share \u003d self.create_share("},{"line_number":213,"context_line":"            self.share_member_client, self.share_type[\u0027id\u0027])"},{"line_number":214,"context_line":"        self.do_request("}],"source_content_type":"text/x-python","patch_set":35,"id":"182e21aa_a068d3d6","line":211,"in_reply_to":"7015e6ed_49dcd12b","updated":"2022-01-18 12:21:07.000000000","message":"This test also includes a negative case.\nI think in this case it is unnecessary to separate the positive and the negative cases.\nPlease see L221","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"7097a2ccf0bbe1c2bbc5e8fc9b046d0a83c418fa","unresolved":true,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @decorators.idempotent_id(\u00274cd807d6-bac4-4d0f-a207-c84dfe77f032\u0027)"},{"line_number":242,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":243,"context_line":"    def test_delete_share_metadata(self):"},{"line_number":244,"context_line":"        share \u003d self.create_share("},{"line_number":245,"context_line":"            self.share_member_client, self.share_type[\u0027id\u0027],"},{"line_number":246,"context_line":"            metadata\u003d{\u0027key\u0027: \u0027value\u0027})"}],"source_content_type":"text/x-python","patch_set":35,"id":"9359a99e_bef985d6","line":243,"updated":"2022-01-18 12:08:50.000000000","message":"Ditto.","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"aedede1c7ca768084e7ba04939a47f0b3df3d9c1","unresolved":true,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @decorators.idempotent_id(\u00274cd807d6-bac4-4d0f-a207-c84dfe77f032\u0027)"},{"line_number":242,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":243,"context_line":"    def test_delete_share_metadata(self):"},{"line_number":244,"context_line":"        share \u003d self.create_share("},{"line_number":245,"context_line":"            self.share_member_client, self.share_type[\u0027id\u0027],"},{"line_number":246,"context_line":"            metadata\u003d{\u0027key\u0027: \u0027value\u0027})"}],"source_content_type":"text/x-python","patch_set":35,"id":"a8bbb2b4_f33f6fdf","line":243,"in_reply_to":"9359a99e_bef985d6","updated":"2022-01-18 12:21:07.000000000","message":"Same\nPlease see L255","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"7e3e5d1710f31517f1b9effb7f3ca06dea9aaca4","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @decorators.idempotent_id(\u00274cd807d6-bac4-4d0f-a207-c84dfe77f032\u0027)"},{"line_number":242,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":243,"context_line":"    def test_delete_share_metadata(self):"},{"line_number":244,"context_line":"        share \u003d self.create_share("},{"line_number":245,"context_line":"            self.share_member_client, self.share_type[\u0027id\u0027],"},{"line_number":246,"context_line":"            metadata\u003d{\u0027key\u0027: \u0027value\u0027})"}],"source_content_type":"text/x-python","patch_set":35,"id":"bcf3fd41_65c1f761","line":243,"in_reply_to":"a8bbb2b4_f33f6fdf","updated":"2022-09-13 12:59:38.000000000","message":"Done","commit_id":"164c46d5888e0770b53b614cfc144e6710140641"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c75e9643b54146526e7ffdb5f172d2cfe9e1ecf1","unresolved":true,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    In order to test certain share operations we must create a share resource"},{"line_number":499,"context_line":"    for this. Since reader user is limited in resources creation, we are forced"},{"line_number":500,"context_line":"    to user admin credentials, so we can test other share operations."},{"line_number":501,"context_line":"    In this class we use admin user to create a member user within reader"},{"line_number":502,"context_line":"    project. That way we can perform a reader actions on this resource."},{"line_number":503,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":53,"id":"a421dcaa_0bc3ca80","line":500,"range":{"start_line":500,"start_character":7,"end_line":500,"end_character":11},"updated":"2022-06-17 19:30:42.000000000","message":"nit: use :)","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fa7cf1dd328340efd58d87f2bd26ad17956da3a9","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    In order to test certain share operations we must create a share resource"},{"line_number":499,"context_line":"    for this. Since reader user is limited in resources creation, we are forced"},{"line_number":500,"context_line":"    to user admin credentials, so we can test other share operations."},{"line_number":501,"context_line":"    In this class we use admin user to create a member user within reader"},{"line_number":502,"context_line":"    project. That way we can perform a reader actions on this resource."},{"line_number":503,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":53,"id":"3b4868c6_bec2979a","line":500,"range":{"start_line":500,"start_character":7,"end_line":500,"end_character":11},"in_reply_to":"a421dcaa_0bc3ca80","updated":"2022-06-19 11:42:33.000000000","message":"Done","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c75e9643b54146526e7ffdb5f172d2cfe9e1ecf1","unresolved":true,"context_lines":[{"line_number":640,"context_line":"            \u0027delete_metadata\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":641,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], key\u003d\u0027key\u0027)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"class TestProjectAdminTestsNFS(ProjectAdminTests):"},{"line_number":645,"context_line":"    protocol \u003d \"nfs\""},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":53,"id":"b58fad69_462a87c9","line":643,"updated":"2022-06-17 19:30:42.000000000","message":"as we create shares on these tests, that question about different protocols does not apply here :)","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fa7cf1dd328340efd58d87f2bd26ad17956da3a9","unresolved":false,"context_lines":[{"line_number":640,"context_line":"            \u0027delete_metadata\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":641,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], key\u003d\u0027key\u0027)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"class TestProjectAdminTestsNFS(ProjectAdminTests):"},{"line_number":645,"context_line":"    protocol \u003d \"nfs\""},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":53,"id":"6a12b593_1446a61c","line":643,"in_reply_to":"b58fad69_462a87c9","updated":"2022-06-19 11:42:33.000000000","message":"Done","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":152,"context_line":"        ]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.assertIn(share[\u0027id\u0027], share_id_list)"},{"line_number":155,"context_line":"        self.assertNotIn(alt_share[\u0027id\u0027], share_id_list)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @decorators.idempotent_id(\u002734b84af3-a9ea-4c19-8414-e4e44648099c\u0027)"},{"line_number":158,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"764796d6_397cdbc3","line":155,"range":{"start_line":155,"start_character":8,"end_line":155,"end_character":56},"updated":"2022-09-14 22:53:04.000000000","message":"anyone with role:admin would have permission to use all_tenants, and hence will see this share in Zed: https://review.opendev.org/c/openstack/manila/+/856394","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        ]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.assertIn(share[\u0027id\u0027], share_id_list)"},{"line_number":155,"context_line":"        self.assertNotIn(alt_share[\u0027id\u0027], share_id_list)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @decorators.idempotent_id(\u002734b84af3-a9ea-4c19-8414-e4e44648099c\u0027)"},{"line_number":158,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"e3be55d9_b504cd86","line":155,"range":{"start_line":155,"start_character":8,"end_line":155,"end_character":56},"in_reply_to":"764796d6_397cdbc3","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        alt_share \u003d self.create_share("},{"line_number":178,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":179,"context_line":"        self.do_request("},{"line_number":180,"context_line":"            \u0027delete_share\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":181,"context_line":"            share_id\u003dalt_share[\u0027id\u0027])"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @decorators.idempotent_id(\u00272e915a27-488d-4e33-b2f8-37758ef11653\u0027)"},{"line_number":184,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"0f995ff4_321eb692","line":181,"range":{"start_line":179,"start_character":8,"end_line":181,"end_character":37},"updated":"2022-09-14 22:53:04.000000000","message":"this should be possible as well for anyone with role:admin in Zed","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        alt_share \u003d self.create_share("},{"line_number":178,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":179,"context_line":"        self.do_request("},{"line_number":180,"context_line":"            \u0027delete_share\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":181,"context_line":"            share_id\u003dalt_share[\u0027id\u0027])"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @decorators.idempotent_id(\u00272e915a27-488d-4e33-b2f8-37758ef11653\u0027)"},{"line_number":184,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"1f6bad1f_b8d50f01","line":181,"range":{"start_line":179,"start_character":8,"end_line":181,"end_character":37},"in_reply_to":"0f995ff4_321eb692","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        alt_share \u003d self.create_share("},{"line_number":193,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":194,"context_line":"        self.do_request("},{"line_number":195,"context_line":"            \u0027force_delete\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":196,"context_line":"            s_id\u003dalt_share[\u0027id\u0027])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @decorators.idempotent_id(\u00275c2bda4c-0179-4af9-b18c-430a7d31f962\u0027)"},{"line_number":199,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"b61396cb_9cf8216f","line":196,"range":{"start_line":194,"start_character":8,"end_line":196,"end_character":33},"updated":"2022-09-14 22:53:04.000000000","message":"this should be possible as well for anyone with role:admin","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        alt_share \u003d self.create_share("},{"line_number":193,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":194,"context_line":"        self.do_request("},{"line_number":195,"context_line":"            \u0027force_delete\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":196,"context_line":"            s_id\u003dalt_share[\u0027id\u0027])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @decorators.idempotent_id(\u00275c2bda4c-0179-4af9-b18c-430a7d31f962\u0027)"},{"line_number":199,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"7ef4ff1c_659e788f","line":196,"range":{"start_line":194,"start_character":8,"end_line":196,"end_character":33},"in_reply_to":"b61396cb_9cf8216f","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":208,"context_line":"        alt_share \u003d self.create_share("},{"line_number":209,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":210,"context_line":"        name \u003d data_utils.rand_name(\"updated_share\")"},{"line_number":211,"context_line":"        self.do_request("},{"line_number":212,"context_line":"            \u0027update_share\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":213,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], name\u003dname)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    @decorators.skip_because(bug\u003d\u00271955627\u0027)"},{"line_number":216,"context_line":"    @decorators.idempotent_id(\u002744fb7049-8fc0-4584-9ff1-7527395d2ec5\u0027)"}],"source_content_type":"text/x-python","patch_set":63,"id":"ec461594_61e1eb6b","line":213,"range":{"start_line":211,"start_character":0,"end_line":213,"end_character":48},"updated":"2022-09-14 22:53:04.000000000","message":"same","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        alt_share \u003d self.create_share("},{"line_number":209,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":210,"context_line":"        name \u003d data_utils.rand_name(\"updated_share\")"},{"line_number":211,"context_line":"        self.do_request("},{"line_number":212,"context_line":"            \u0027update_share\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":213,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], name\u003dname)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    @decorators.skip_because(bug\u003d\u00271955627\u0027)"},{"line_number":216,"context_line":"    @decorators.idempotent_id(\u002744fb7049-8fc0-4584-9ff1-7527395d2ec5\u0027)"}],"source_content_type":"text/x-python","patch_set":63,"id":"739531c3_369420a2","line":213,"range":{"start_line":211,"start_character":0,"end_line":213,"end_character":48},"in_reply_to":"ec461594_61e1eb6b","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        alt_share \u003d self.create_share("},{"line_number":226,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":227,"context_line":"        self.do_request("},{"line_number":228,"context_line":"            \u0027reset_state\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":229,"context_line":"            s_id\u003dalt_share[\u0027id\u0027], status\u003d\"error\")"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    @decorators.idempotent_id(\u0027cc49ae58-6696-4030-a029-a66bae2efa96\u0027)"},{"line_number":232,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"b8cc128d_06ae12c0","line":229,"range":{"start_line":227,"start_character":0,"end_line":229,"end_character":49},"updated":"2022-09-14 22:53:04.000000000","message":"same","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        alt_share \u003d self.create_share("},{"line_number":226,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":227,"context_line":"        self.do_request("},{"line_number":228,"context_line":"            \u0027reset_state\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":229,"context_line":"            s_id\u003dalt_share[\u0027id\u0027], status\u003d\"error\")"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    @decorators.idempotent_id(\u0027cc49ae58-6696-4030-a029-a66bae2efa96\u0027)"},{"line_number":232,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"33a1f628_5ca0f7ed","line":229,"range":{"start_line":227,"start_character":0,"end_line":229,"end_character":49},"in_reply_to":"b8cc128d_06ae12c0","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":232,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":233,"context_line":"    def test_shrink_share(self):"},{"line_number":234,"context_line":"        share \u003d self.create_share("},{"line_number":235,"context_line":"            self.share_member_client, self.share_type[\u0027id\u0027], size\u003d2)"},{"line_number":236,"context_line":"        self.do_request("},{"line_number":237,"context_line":"            \u0027shrink_share\u0027, expected_status\u003d202, share_id\u003dshare[\u0027id\u0027],"},{"line_number":238,"context_line":"            new_size\u003d1)"}],"source_content_type":"text/x-python","patch_set":63,"id":"000fca64_142167f3","line":235,"range":{"start_line":235,"start_character":66,"end_line":235,"end_character":67},"updated":"2022-09-14 22:53:04.000000000","message":"you should use conf.share.share_size +1 here since we have that config","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":233,"context_line":"    def test_shrink_share(self):"},{"line_number":234,"context_line":"        share \u003d self.create_share("},{"line_number":235,"context_line":"            self.share_member_client, self.share_type[\u0027id\u0027], size\u003d2)"},{"line_number":236,"context_line":"        self.do_request("},{"line_number":237,"context_line":"            \u0027shrink_share\u0027, expected_status\u003d202, share_id\u003dshare[\u0027id\u0027],"},{"line_number":238,"context_line":"            new_size\u003d1)"}],"source_content_type":"text/x-python","patch_set":63,"id":"bafdaf37_6b40ba4a","line":235,"range":{"start_line":235,"start_character":66,"end_line":235,"end_character":67},"in_reply_to":"000fca64_142167f3","updated":"2022-09-15 09:56:13.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":235,"context_line":"            self.share_member_client, self.share_type[\u0027id\u0027], size\u003d2)"},{"line_number":236,"context_line":"        self.do_request("},{"line_number":237,"context_line":"            \u0027shrink_share\u0027, expected_status\u003d202, share_id\u003dshare[\u0027id\u0027],"},{"line_number":238,"context_line":"            new_size\u003d1)"},{"line_number":239,"context_line":"        waiters.wait_for_resource_status(self.client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        alt_share \u003d self.create_share("}],"source_content_type":"text/x-python","patch_set":63,"id":"e6e78100_c12d9409","line":238,"range":{"start_line":238,"start_character":0,"end_line":238,"end_character":21},"updated":"2022-09-14 22:53:04.000000000","message":"conf.share.share_size","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            self.share_member_client, self.share_type[\u0027id\u0027], size\u003d2)"},{"line_number":236,"context_line":"        self.do_request("},{"line_number":237,"context_line":"            \u0027shrink_share\u0027, expected_status\u003d202, share_id\u003dshare[\u0027id\u0027],"},{"line_number":238,"context_line":"            new_size\u003d1)"},{"line_number":239,"context_line":"        waiters.wait_for_resource_status(self.client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        alt_share \u003d self.create_share("}],"source_content_type":"text/x-python","patch_set":63,"id":"e2386e7a_1d51faee","line":238,"range":{"start_line":238,"start_character":0,"end_line":238,"end_character":21},"in_reply_to":"e6e78100_c12d9409","updated":"2022-09-15 09:56:13.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        alt_share \u003d self.create_share("},{"line_number":242,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027], size\u003d2)"},{"line_number":243,"context_line":"        self.do_request("},{"line_number":244,"context_line":"            \u0027shrink_share\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":245,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], new_size\u003d1)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    @decorators.idempotent_id(\u00272cfa04e5-16cc-43e4-b892-c1a11b0a2f2d\u0027)"},{"line_number":248,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"65ebc09e_fb8e0f1f","line":245,"range":{"start_line":243,"start_character":0,"end_line":245,"end_character":49},"updated":"2022-09-14 22:53:04.000000000","message":"same","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        alt_share \u003d self.create_share("},{"line_number":242,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027], size\u003d2)"},{"line_number":243,"context_line":"        self.do_request("},{"line_number":244,"context_line":"            \u0027shrink_share\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":245,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], new_size\u003d1)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    @decorators.idempotent_id(\u00272cfa04e5-16cc-43e4-b892-c1a11b0a2f2d\u0027)"},{"line_number":248,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"74041614_5c378189","line":245,"range":{"start_line":243,"start_character":0,"end_line":245,"end_character":49},"in_reply_to":"65ebc09e_fb8e0f1f","updated":"2022-09-15 09:56:13.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        alt_share \u003d self.create_share("},{"line_number":258,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":259,"context_line":"        self.do_request("},{"line_number":260,"context_line":"            \u0027extend_share\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":261,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], new_size\u003d2)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @decorators.idempotent_id(\u0027d6014579-d772-441a-a9b1-01b1e87caeaa\u0027)"},{"line_number":264,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"ecc6e642_e42b84e4","line":261,"range":{"start_line":259,"start_character":0,"end_line":261,"end_character":49},"updated":"2022-09-14 22:53:04.000000000","message":"same","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        alt_share \u003d self.create_share("},{"line_number":258,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":259,"context_line":"        self.do_request("},{"line_number":260,"context_line":"            \u0027extend_share\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":261,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], new_size\u003d2)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @decorators.idempotent_id(\u0027d6014579-d772-441a-a9b1-01b1e87caeaa\u0027)"},{"line_number":264,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"d06ecd89_bac06be6","line":261,"range":{"start_line":259,"start_character":0,"end_line":261,"end_character":49},"in_reply_to":"ecc6e642_e42b84e4","updated":"2022-09-15 09:56:13.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        alt_share \u003d self.create_share("},{"line_number":273,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":274,"context_line":"        self.do_request("},{"line_number":275,"context_line":"            \u0027set_metadata\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":276,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], metadata\u003d{\u0027key\u0027: \u0027value\u0027})"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @decorators.idempotent_id(\u00272d91e97e-d0e5-4112-8b22-60cd4659586c\u0027)"},{"line_number":279,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"1527aba5_3516856f","line":276,"range":{"start_line":274,"start_character":0,"end_line":276,"end_character":64},"updated":"2022-09-14 22:53:04.000000000","message":"same","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        alt_share \u003d self.create_share("},{"line_number":273,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"},{"line_number":274,"context_line":"        self.do_request("},{"line_number":275,"context_line":"            \u0027set_metadata\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":276,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], metadata\u003d{\u0027key\u0027: \u0027value\u0027})"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @decorators.idempotent_id(\u00272d91e97e-d0e5-4112-8b22-60cd4659586c\u0027)"},{"line_number":279,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"c8169c7c_d7e52221","line":276,"range":{"start_line":274,"start_character":0,"end_line":276,"end_character":64},"in_reply_to":"1527aba5_3516856f","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":288,"context_line":"        alt_share \u003d self.create_share("},{"line_number":289,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027],"},{"line_number":290,"context_line":"            metadata\u003dmetadata)"},{"line_number":291,"context_line":"        self.do_request("},{"line_number":292,"context_line":"            \u0027get_metadata\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":293,"context_line":"            share_id\u003dalt_share[\u0027id\u0027])"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @decorators.idempotent_id(\u00274cd807d6-bac4-4d0f-a207-c84dfe77f032\u0027)"},{"line_number":296,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"45770423_2ed4cf55","line":293,"range":{"start_line":291,"start_character":0,"end_line":293,"end_character":37},"updated":"2022-09-14 22:53:04.000000000","message":"same","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        alt_share \u003d self.create_share("},{"line_number":289,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027],"},{"line_number":290,"context_line":"            metadata\u003dmetadata)"},{"line_number":291,"context_line":"        self.do_request("},{"line_number":292,"context_line":"            \u0027get_metadata\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":293,"context_line":"            share_id\u003dalt_share[\u0027id\u0027])"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @decorators.idempotent_id(\u00274cd807d6-bac4-4d0f-a207-c84dfe77f032\u0027)"},{"line_number":296,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"879afe48_89fdcc3e","line":293,"range":{"start_line":291,"start_character":0,"end_line":293,"end_character":37},"in_reply_to":"45770423_2ed4cf55","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        alt_share \u003d self.create_share("},{"line_number":306,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027],"},{"line_number":307,"context_line":"            metadata\u003d{\u0027key\u0027: \u0027value\u0027})"},{"line_number":308,"context_line":"        self.do_request("},{"line_number":309,"context_line":"            \u0027delete_metadata\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":310,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], key\u003d\u0027key\u0027)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"class TestProjectMemberTestsNFS(ShareRbacSharesTests, base.BaseSharesTest):"}],"source_content_type":"text/x-python","patch_set":63,"id":"15588117_72e13797","line":310,"range":{"start_line":308,"start_character":0,"end_line":310,"end_character":48},"updated":"2022-09-14 22:53:04.000000000","message":"same\n\nFor these tests, we could convert them to positive test cases and update the expected status to a success code..","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        alt_share \u003d self.create_share("},{"line_number":306,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027],"},{"line_number":307,"context_line":"            metadata\u003d{\u0027key\u0027: \u0027value\u0027})"},{"line_number":308,"context_line":"        self.do_request("},{"line_number":309,"context_line":"            \u0027delete_metadata\u0027, expected_status\u003dlib_exc.Forbidden,"},{"line_number":310,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], key\u003d\u0027key\u0027)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"class TestProjectMemberTestsNFS(ShareRbacSharesTests, base.BaseSharesTest):"}],"source_content_type":"text/x-python","patch_set":63,"id":"723bceb8_dbe1d171","line":310,"range":{"start_line":308,"start_character":0,"end_line":310,"end_character":48},"in_reply_to":"15588117_72e13797","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":347,"context_line":"        share_id_list \u003d ["},{"line_number":348,"context_line":"            s[\u0027id\u0027] for s in share_list"},{"line_number":349,"context_line":"        ]"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        self.assertIn(share[\u0027id\u0027], share_id_list)"},{"line_number":352,"context_line":"        self.assertNotIn(alt_share[\u0027id\u0027], share_id_list)"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"b53b39e9_e50ad02e","line":350,"updated":"2022-09-14 22:53:04.000000000","message":"since the all_tenants key is ignored by the API [1], we could try supplying it to simulate a malicious attempt to get all tenants\u0027 shares as a member of a project; if you add all_tenants to the search query, please also add a comment stating that we expect this key to be ignored since project_member isn\u0027t an admin\n\n[1] https://github.com/openstack/manila/blob/206885a3e9a06571ba582bedddb40a1c413ec7f9/manila/share/api.py#L2039-L2045","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":true,"context_lines":[{"line_number":347,"context_line":"        share_id_list \u003d ["},{"line_number":348,"context_line":"            s[\u0027id\u0027] for s in share_list"},{"line_number":349,"context_line":"        ]"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        self.assertIn(share[\u0027id\u0027], share_id_list)"},{"line_number":352,"context_line":"        self.assertNotIn(alt_share[\u0027id\u0027], share_id_list)"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"e04be165_adba2bfd","line":350,"in_reply_to":"b53b39e9_e50ad02e","updated":"2022-09-15 09:56:13.000000000","message":"Good idea, will do it in the next iteration.","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        share_id_list \u003d ["},{"line_number":348,"context_line":"            s[\u0027id\u0027] for s in share_list"},{"line_number":349,"context_line":"        ]"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        self.assertIn(share[\u0027id\u0027], share_id_list)"},{"line_number":352,"context_line":"        self.assertNotIn(alt_share[\u0027id\u0027], share_id_list)"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"9b1871fc_975a3ab2","line":350,"in_reply_to":"e04be165_adba2bfd","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"32b9632dca3ca7181699f8322a603b15f41d2d4d","unresolved":true,"context_lines":[{"line_number":265,"context_line":"            \u0027extend_share\u0027, expected_status\u003d202,"},{"line_number":266,"context_line":"            share_id\u003dalt_share[\u0027id\u0027], new_size\u003dCONF.share.share_size + 1)"},{"line_number":267,"context_line":"        waiters.wait_for_resource_status("},{"line_number":268,"context_line":"            self.alt_project_share_v2_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    @decorators.idempotent_id(\u0027d6014579-d772-441a-a9b1-01b1e87caeaa\u0027)"},{"line_number":271,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":66,"id":"98c2efe0_a30aac4f","line":268,"range":{"start_line":268,"start_character":46,"end_line":268,"end_character":51},"updated":"2022-09-21 19:32:24.000000000","message":"alt_share","commit_id":"1b2e2aee83f9e9119475259af4f6d4777ac41832"}],"manila_tempest_tests/tests/rbac/test_snapshots.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"14b3a133a89b54d6d9e2d5f1978f8534b5e330fb","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            snapshot_id\u003dalt_snapshot[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @decorators.idempotent_id(\u00273b209017-f5ad-4daa-8932-582a75975bbe\u0027)"},{"line_number":113,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":114,"context_line":"    def test_list_snapshot(self):"},{"line_number":115,"context_line":"        snap \u003d self.create_snapshot("},{"line_number":116,"context_line":"            self.share_member_client, self.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":62,"id":"7aecfaf3_6892b846","line":113,"range":{"start_line":113,"start_character":18,"end_line":113,"end_character":30},"updated":"2022-09-13 13:10:59.000000000","message":"negative should raise an exception, right? This case it\u0027s a positive as I understand, unless I\u0027m misreading it.","commit_id":"28bf7d7505341b6d39dd3c81cc2c152e4f386f44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8b3ae94f4eeaad1225fb7e237f43f46673adc430","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            snapshot_id\u003dalt_snapshot[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @decorators.idempotent_id(\u00273b209017-f5ad-4daa-8932-582a75975bbe\u0027)"},{"line_number":113,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":114,"context_line":"    def test_list_snapshot(self):"},{"line_number":115,"context_line":"        snap \u003d self.create_snapshot("},{"line_number":116,"context_line":"            self.share_member_client, self.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":62,"id":"c16bb0ab_52e4021a","line":113,"range":{"start_line":113,"start_character":18,"end_line":113,"end_character":30},"in_reply_to":"4b24029e_bf873ecd","updated":"2022-09-14 11:50:37.000000000","message":"Done","commit_id":"28bf7d7505341b6d39dd3c81cc2c152e4f386f44"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d7da247877fe72faa8ae918123fc48b03c3d96cf","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            snapshot_id\u003dalt_snapshot[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @decorators.idempotent_id(\u00273b209017-f5ad-4daa-8932-582a75975bbe\u0027)"},{"line_number":113,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":114,"context_line":"    def test_list_snapshot(self):"},{"line_number":115,"context_line":"        snap \u003d self.create_snapshot("},{"line_number":116,"context_line":"            self.share_member_client, self.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":62,"id":"4b24029e_bf873ecd","line":113,"range":{"start_line":113,"start_character":18,"end_line":113,"end_character":30},"in_reply_to":"7aecfaf3_6892b846","updated":"2022-09-13 14:05:35.000000000","message":"I think I marked it as negative because I used assertNotIn.\nBut positive is fine.","commit_id":"28bf7d7505341b6d39dd3c81cc2c152e4f386f44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"14b3a133a89b54d6d9e2d5f1978f8534b5e330fb","unresolved":true,"context_lines":[{"line_number":230,"context_line":"            snapshot_id\u003dalt_snapshot[\u0027id\u0027])"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @decorators.idempotent_id(\u00270dcc1f68-86e2-432e-ad50-51c3cb78b986\u0027)"},{"line_number":233,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":234,"context_line":"    def test_list_snapshot(self):"},{"line_number":235,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":236,"context_line":"        snap \u003d self.create_snapshot(share_client, self.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":62,"id":"93fd7849_14a1c0de","line":233,"range":{"start_line":233,"start_character":18,"end_line":233,"end_character":30},"updated":"2022-09-13 13:10:59.000000000","message":"same as above","commit_id":"28bf7d7505341b6d39dd3c81cc2c152e4f386f44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8b3ae94f4eeaad1225fb7e237f43f46673adc430","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            snapshot_id\u003dalt_snapshot[\u0027id\u0027])"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @decorators.idempotent_id(\u00270dcc1f68-86e2-432e-ad50-51c3cb78b986\u0027)"},{"line_number":233,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":234,"context_line":"    def test_list_snapshot(self):"},{"line_number":235,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":236,"context_line":"        snap \u003d self.create_snapshot(share_client, self.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":62,"id":"6b7f4a45_a46591b7","line":233,"range":{"start_line":233,"start_character":18,"end_line":233,"end_character":30},"in_reply_to":"28f6ced9_3f2db2bb","updated":"2022-09-14 11:50:37.000000000","message":"Done","commit_id":"28bf7d7505341b6d39dd3c81cc2c152e4f386f44"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d7da247877fe72faa8ae918123fc48b03c3d96cf","unresolved":true,"context_lines":[{"line_number":230,"context_line":"            snapshot_id\u003dalt_snapshot[\u0027id\u0027])"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @decorators.idempotent_id(\u00270dcc1f68-86e2-432e-ad50-51c3cb78b986\u0027)"},{"line_number":233,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":234,"context_line":"    def test_list_snapshot(self):"},{"line_number":235,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":236,"context_line":"        snap \u003d self.create_snapshot(share_client, self.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":62,"id":"28f6ced9_3f2db2bb","line":233,"range":{"start_line":233,"start_character":18,"end_line":233,"end_character":30},"in_reply_to":"93fd7849_14a1c0de","updated":"2022-09-13 14:05:35.000000000","message":"Done","commit_id":"28bf7d7505341b6d39dd3c81cc2c152e4f386f44"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        alt_snapshot \u003d self.create_snapshot("},{"line_number":107,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"},{"line_number":108,"context_line":"        self.do_request("},{"line_number":109,"context_line":"            \u0027get_snapshot\u0027, expected_status\u003dlib_exc.NotFound,"},{"line_number":110,"context_line":"            snapshot_id\u003dalt_snapshot[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @decorators.idempotent_id(\u00273b209017-f5ad-4daa-8932-582a75975bbe\u0027)"},{"line_number":113,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"8d3be964_61b7207c","line":110,"range":{"start_line":108,"start_character":0,"end_line":110,"end_character":43},"updated":"2022-09-14 22:53:04.000000000","message":"role:admin should be able to do this in Zed","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        alt_snapshot \u003d self.create_snapshot("},{"line_number":107,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"},{"line_number":108,"context_line":"        self.do_request("},{"line_number":109,"context_line":"            \u0027get_snapshot\u0027, expected_status\u003dlib_exc.NotFound,"},{"line_number":110,"context_line":"            snapshot_id\u003dalt_snapshot[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @decorators.idempotent_id(\u00273b209017-f5ad-4daa-8932-582a75975bbe\u0027)"},{"line_number":113,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"8d5fb2c0_3461d077","line":110,"range":{"start_line":108,"start_character":0,"end_line":110,"end_character":43},"in_reply_to":"8d3be964_61b7207c","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":125,"context_line":"        ]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.assertIn(snap[\u0027id\u0027], snapshot_id_list)"},{"line_number":128,"context_line":"        self.assertNotIn(alt_snap[\u0027id\u0027], snapshot_id_list)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u00272b90d3e9-ec71-468a-86e9-e8955139ad48\u0027)"},{"line_number":131,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"a1773410_e1bcb755","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":58},"updated":"2022-09-14 22:53:04.000000000","message":"role:admin should be able to list all projects\u0027 snapshots","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        ]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.assertIn(snap[\u0027id\u0027], snapshot_id_list)"},{"line_number":128,"context_line":"        self.assertNotIn(alt_snap[\u0027id\u0027], snapshot_id_list)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u00272b90d3e9-ec71-468a-86e9-e8955139ad48\u0027)"},{"line_number":131,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"2f98a74e_cf9bb9df","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":58},"in_reply_to":"a1773410_e1bcb755","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        alt_snap \u003d self.create_snapshot("},{"line_number":151,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"},{"line_number":152,"context_line":"        self.do_request("},{"line_number":153,"context_line":"            \u0027delete_snapshot\u0027, expected_status\u003dlib_exc.NotFound,"},{"line_number":154,"context_line":"            snap_id\u003dalt_snap[\u0027id\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @decorators.idempotent_id(\u00273ac10dfb-3445-4052-855a-a17056d16a9c\u0027)"},{"line_number":157,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"e59a8577_832d460e","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":35},"updated":"2022-09-14 22:53:04.000000000","message":"role:admin should be able to delete any snapshot in Zed","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        alt_snap \u003d self.create_snapshot("},{"line_number":151,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"},{"line_number":152,"context_line":"        self.do_request("},{"line_number":153,"context_line":"            \u0027delete_snapshot\u0027, expected_status\u003dlib_exc.NotFound,"},{"line_number":154,"context_line":"            snap_id\u003dalt_snap[\u0027id\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @decorators.idempotent_id(\u00273ac10dfb-3445-4052-855a-a17056d16a9c\u0027)"},{"line_number":157,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"bb152536_8f06facb","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":35},"in_reply_to":"e59a8577_832d460e","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        alt_snap \u003d self.create_snapshot("},{"line_number":167,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"},{"line_number":168,"context_line":"        self.do_request("},{"line_number":169,"context_line":"            \u0027force_delete\u0027, expected_status\u003dlib_exc.NotFound,"},{"line_number":170,"context_line":"            s_id\u003dalt_snap[\u0027id\u0027], s_type\u003d\u0027snapshots\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @decorators.idempotent_id(\u0027513c8fef-9597-4e6c-a811-fb89b456d457\u0027)"},{"line_number":173,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"de64f3e3_2b544330","line":170,"range":{"start_line":168,"start_character":0,"end_line":170,"end_character":52},"updated":"2022-09-14 22:53:04.000000000","message":"same","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        alt_snap \u003d self.create_snapshot("},{"line_number":167,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"},{"line_number":168,"context_line":"        self.do_request("},{"line_number":169,"context_line":"            \u0027force_delete\u0027, expected_status\u003dlib_exc.NotFound,"},{"line_number":170,"context_line":"            s_id\u003dalt_snap[\u0027id\u0027], s_type\u003d\u0027snapshots\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @decorators.idempotent_id(\u0027513c8fef-9597-4e6c-a811-fb89b456d457\u0027)"},{"line_number":173,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"4ad3da9d_e0866b45","line":170,"range":{"start_line":168,"start_character":0,"end_line":170,"end_character":52},"in_reply_to":"de64f3e3_2b544330","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        alt_snap \u003d self.create_snapshot("},{"line_number":183,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"},{"line_number":184,"context_line":"        self.do_request("},{"line_number":185,"context_line":"            \u0027rename_snapshot\u0027, expected_status\u003dlib_exc.NotFound,"},{"line_number":186,"context_line":"            snapshot_id\u003dalt_snap[\u0027id\u0027], name\u003dname)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @decorators.idempotent_id(\u0027a5e99bfb-8767-4680-9e39-bde767e4b8f8\u0027)"},{"line_number":189,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"661e6366_a4305361","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":50},"updated":"2022-09-14 22:53:04.000000000","message":"same","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        alt_snap \u003d self.create_snapshot("},{"line_number":183,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"},{"line_number":184,"context_line":"        self.do_request("},{"line_number":185,"context_line":"            \u0027rename_snapshot\u0027, expected_status\u003dlib_exc.NotFound,"},{"line_number":186,"context_line":"            snapshot_id\u003dalt_snap[\u0027id\u0027], name\u003dname)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @decorators.idempotent_id(\u0027a5e99bfb-8767-4680-9e39-bde767e4b8f8\u0027)"},{"line_number":189,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":63,"id":"6d3d4812_89f3d393","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":50},"in_reply_to":"661e6366_a4305361","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        alt_snap \u003d self.create_snapshot("},{"line_number":198,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"},{"line_number":199,"context_line":"        self.do_request("},{"line_number":200,"context_line":"            \u0027snapshot_reset_state\u0027, expected_status\u003dlib_exc.NotFound,"},{"line_number":201,"context_line":"            snapshot_id\u003dalt_snap[\u0027id\u0027], status\u003d\u0027error\u0027)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class TestProjectMemberTestsNFS(ShareRbacSnapshotsTests, base.BaseSharesTest):"}],"source_content_type":"text/x-python","patch_set":63,"id":"5ec16ab3_ca37ad28","line":201,"range":{"start_line":199,"start_character":0,"end_line":201,"end_character":55},"updated":"2022-09-14 22:53:04.000000000","message":"same","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        alt_snap \u003d self.create_snapshot("},{"line_number":198,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"},{"line_number":199,"context_line":"        self.do_request("},{"line_number":200,"context_line":"            \u0027snapshot_reset_state\u0027, expected_status\u003dlib_exc.NotFound,"},{"line_number":201,"context_line":"            snapshot_id\u003dalt_snap[\u0027id\u0027], status\u003d\u0027error\u0027)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class TestProjectMemberTestsNFS(ShareRbacSnapshotsTests, base.BaseSharesTest):"}],"source_content_type":"text/x-python","patch_set":63,"id":"152799ab_7fdb9e3b","line":201,"range":{"start_line":199,"start_character":0,"end_line":201,"end_character":55},"in_reply_to":"5ec16ab3_ca37ad28","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3bf72609e02169f1bde35a92a0c8ff99bd668e7f","unresolved":true,"context_lines":[{"line_number":243,"context_line":"        snapshot_id_list \u003d ["},{"line_number":244,"context_line":"            s[\u0027id\u0027] for s in snapshot_list"},{"line_number":245,"context_line":"        ]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        self.assertIn(snap[\u0027id\u0027], snapshot_id_list)"},{"line_number":248,"context_line":"        self.assertNotIn(alt_snap[\u0027id\u0027], snapshot_id_list)"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"b4ab964f_b5d4cd26","line":246,"updated":"2022-09-14 22:53:04.000000000","message":"same comment as in the shares tests, we should send \"all_tenants\" in the request (it will be ignored) and verify hat we still don\u0027t see other project\u0027s snapshots","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"58b40bc9dea95f2342dbcc7cd6f6a8e259b64584","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        snapshot_id_list \u003d ["},{"line_number":244,"context_line":"            s[\u0027id\u0027] for s in snapshot_list"},{"line_number":245,"context_line":"        ]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        self.assertIn(snap[\u0027id\u0027], snapshot_id_list)"},{"line_number":248,"context_line":"        self.assertNotIn(alt_snap[\u0027id\u0027], snapshot_id_list)"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"ccac1752_c14b26be","line":246,"in_reply_to":"1be20284_dbb9df24","updated":"2022-09-21 09:57:14.000000000","message":"Done","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87026c35ab90d65d1b2df867989ea8335f0eec5a","unresolved":true,"context_lines":[{"line_number":243,"context_line":"        snapshot_id_list \u003d ["},{"line_number":244,"context_line":"            s[\u0027id\u0027] for s in snapshot_list"},{"line_number":245,"context_line":"        ]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        self.assertIn(snap[\u0027id\u0027], snapshot_id_list)"},{"line_number":248,"context_line":"        self.assertNotIn(alt_snap[\u0027id\u0027], snapshot_id_list)"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"1be20284_dbb9df24","line":246,"in_reply_to":"b4ab964f_b5d4cd26","updated":"2022-09-15 09:56:13.000000000","message":"I\u0027ll do it in the next iteration.","commit_id":"6b05221577dc9540c3ab3cc160dd144913db59fe"}],"zuul.d/manila-tempest-jobs.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c75e9643b54146526e7ffdb5f172d2cfe9e1ecf1","unresolved":true,"context_lines":[{"line_number":585,"context_line":"        MANILA_ENFORCE_SCOPE: true"},{"line_number":586,"context_line":"      devstack_local_conf:"},{"line_number":587,"context_line":"        test-config:"},{"line_number":588,"context_line":"          \"$TEMPEST_CONFIG\":"},{"line_number":589,"context_line":"            share:"},{"line_number":590,"context_line":"              default_share_type_name: default"},{"line_number":591,"context_line":"              backend_names: ALPHA,BETA"},{"line_number":592,"context_line":"              backend_replication_type: readable"},{"line_number":593,"context_line":"              build_timeout: 180"},{"line_number":594,"context_line":"              capability_sg_consistent_snapshot_support: pool"},{"line_number":595,"context_line":"              create_networks_when_multitenancy_enabled: false"},{"line_number":596,"context_line":"              enable_ip_rules_for_protocols: nfs"},{"line_number":597,"context_line":"              enable_ro_access_level_for_protocols: nfs,cifs"},{"line_number":598,"context_line":"              enable_user_rules_for_protocols: cifs"},{"line_number":599,"context_line":"              multi_backend: true"},{"line_number":600,"context_line":"              multitenancy_enabled: false"}],"source_content_type":"text/x-yaml","patch_set":53,"id":"98e6febf_253e2caf","line":600,"range":{"start_line":588,"start_character":10,"end_line":600,"end_character":41},"updated":"2022-06-17 19:30:42.000000000","message":"all of this except from the default_share_type_name who is already defined in the parent job (L423 to 442) - It should be okay to drop these duplicated lines and have the job working fine in the same way","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fa7cf1dd328340efd58d87f2bd26ad17956da3a9","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        MANILA_ENFORCE_SCOPE: true"},{"line_number":586,"context_line":"      devstack_local_conf:"},{"line_number":587,"context_line":"        test-config:"},{"line_number":588,"context_line":"          \"$TEMPEST_CONFIG\":"},{"line_number":589,"context_line":"            share:"},{"line_number":590,"context_line":"              default_share_type_name: default"},{"line_number":591,"context_line":"              backend_names: ALPHA,BETA"},{"line_number":592,"context_line":"              backend_replication_type: readable"},{"line_number":593,"context_line":"              build_timeout: 180"},{"line_number":594,"context_line":"              capability_sg_consistent_snapshot_support: pool"},{"line_number":595,"context_line":"              create_networks_when_multitenancy_enabled: false"},{"line_number":596,"context_line":"              enable_ip_rules_for_protocols: nfs"},{"line_number":597,"context_line":"              enable_ro_access_level_for_protocols: nfs,cifs"},{"line_number":598,"context_line":"              enable_user_rules_for_protocols: cifs"},{"line_number":599,"context_line":"              multi_backend: true"},{"line_number":600,"context_line":"              multitenancy_enabled: false"}],"source_content_type":"text/x-yaml","patch_set":53,"id":"c63291a5_e391a221","line":600,"range":{"start_line":588,"start_character":10,"end_line":600,"end_character":41},"in_reply_to":"98e6febf_253e2caf","updated":"2022-06-19 11:42:33.000000000","message":"Done","commit_id":"4c5a15e43a4b4a9234774ac44d31b70e030032bf"}]}