)]}'
{"manila_tempest_tests/services/share/json/shares_client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"434b1c536c61f9c7a5666f7f34e3a78e3c3731ae","unresolved":true,"context_lines":[{"line_number":69,"context_line":"                \"size\": size,"},{"line_number":70,"context_line":"                \"metadata\": metadata,"},{"line_number":71,"context_line":"                \"is_public\": is_public,"},{"line_number":72,"context_line":"                \"scheduler_hints\": scheduler_hints,"},{"line_number":73,"context_line":"            }"},{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        if share_network_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d0db733_44febe8a","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":51},"updated":"2021-09-13 23:50:27.000000000","message":"The v1 API doesn\u0027t support this; no need to add it here.","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"923d161b6540d5fb9d52c1ed2153644dd04f4bc1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                \"size\": size,"},{"line_number":70,"context_line":"                \"metadata\": metadata,"},{"line_number":71,"context_line":"                \"is_public\": is_public,"},{"line_number":72,"context_line":"                \"scheduler_hints\": scheduler_hints,"},{"line_number":73,"context_line":"            }"},{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        if share_network_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"20875440_2c192076","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":51},"in_reply_to":"9d0db733_44febe8a","updated":"2021-09-14 11:31:14.000000000","message":"Done, removed from v1","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"434b1c536c61f9c7a5666f7f34e3a78e3c3731ae","unresolved":true,"context_lines":[{"line_number":267,"context_line":"                \"size\": size,"},{"line_number":268,"context_line":"                \"metadata\": metadata,"},{"line_number":269,"context_line":"                \"is_public\": is_public,"},{"line_number":270,"context_line":"                \"scheduler_hints\": scheduler_hints,"},{"line_number":271,"context_line":"            }"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        if availability_zone:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e188e4be_34bafe78","line":270,"range":{"start_line":270,"start_character":0,"end_line":270,"end_character":51},"updated":"2021-09-13 23:50:27.000000000","message":"nit: while manila API ignores this key for older microversions, for correctness, we should do this:\n\n if scheduler_hints:\n    post_body[\"share\"][\"scheduler_hints\"] \u003d scheduler_hints","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"923d161b6540d5fb9d52c1ed2153644dd04f4bc1","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                \"size\": size,"},{"line_number":268,"context_line":"                \"metadata\": metadata,"},{"line_number":269,"context_line":"                \"is_public\": is_public,"},{"line_number":270,"context_line":"                \"scheduler_hints\": scheduler_hints,"},{"line_number":271,"context_line":"            }"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        if availability_zone:"}],"source_content_type":"text/x-python","patch_set":1,"id":"395ca137_efbc3d84","line":270,"range":{"start_line":270,"start_character":0,"end_line":270,"end_character":51},"in_reply_to":"e188e4be_34bafe78","updated":"2021-09-14 11:31:14.000000000","message":"Done","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"}],"manila_tempest_tests/tests/api/test_scheduler_hints.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"434b1c536c61f9c7a5666f7f34e3a78e3c3731ae","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        # create share"},{"line_number":35,"context_line":"        cls.share_a \u003d cls.create_share(share_type_id\u003dcls.share_type_id)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if not CONF.share.multi_backend:"},{"line_number":38,"context_line":"            raise cls.skipException(\"Manila multi-backend is disabled.\")"},{"line_number":39,"context_line":"        elif len(CONF.share.backend_names) \u003c 2:"},{"line_number":40,"context_line":"            raise cls.skipException(\"For running multi-backend tests required\""},{"line_number":41,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":42,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":43,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":44,"context_line":"                                    \"Skipping.\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.idempotent_id(\u0027f96d5836-bfc9-4c22-888e-3f62d731573c\u0027)"},{"line_number":47,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ec0d885c_9e01c5a0","line":44,"range":{"start_line":37,"start_character":8,"end_line":44,"end_character":48},"updated":"2021-09-13 23:50:27.000000000","message":"there\u0027s a skip_checks method that gets evaluated before resource_setup - set these in the skip_checks: https://github.com/openstack/manila-tempest-plugin/blob/ed2b75e6ae6a1dd99dba2a20133845ba115fbc48/manila_tempest_tests/tests/api/admin/test_replication_actions.py#L32-L41\n\n\nAlso, these tests must be skipped with microversion \u003c 2.65, see an example for this in the link above","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"923d161b6540d5fb9d52c1ed2153644dd04f4bc1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # create share"},{"line_number":35,"context_line":"        cls.share_a \u003d cls.create_share(share_type_id\u003dcls.share_type_id)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if not CONF.share.multi_backend:"},{"line_number":38,"context_line":"            raise cls.skipException(\"Manila multi-backend is disabled.\")"},{"line_number":39,"context_line":"        elif len(CONF.share.backend_names) \u003c 2:"},{"line_number":40,"context_line":"            raise cls.skipException(\"For running multi-backend tests required\""},{"line_number":41,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":42,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":43,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":44,"context_line":"                                    \"Skipping.\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.idempotent_id(\u0027f96d5836-bfc9-4c22-888e-3f62d731573c\u0027)"},{"line_number":47,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b3d9e964_0fe5446e","line":44,"range":{"start_line":37,"start_character":8,"end_line":44,"end_character":48},"in_reply_to":"ec0d885c_9e01c5a0","updated":"2021-09-14 11:31:14.000000000","message":"Done","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"434b1c536c61f9c7a5666f7f34e3a78e3c3731ae","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        backend_b \u003d instance_b.get(\u0027host\u0027).split(\u0027#\u0027)[0]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # verify same backends"},{"line_number":63,"context_line":"        self.assertEqual(backend_a, backend_b)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u00276569e0c3-43c9-4ee2-84ff-ea7fa8da8110\u0027)"},{"line_number":66,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":1,"id":"36375322_27a0f2de","line":63,"range":{"start_line":63,"start_character":45,"end_line":63,"end_character":46},"updated":"2021-09-13 23:50:27.000000000","message":"Can you test the metadata on share_a and share_b here as well?","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"923d161b6540d5fb9d52c1ed2153644dd04f4bc1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        backend_b \u003d instance_b.get(\u0027host\u0027).split(\u0027#\u0027)[0]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # verify same backends"},{"line_number":63,"context_line":"        self.assertEqual(backend_a, backend_b)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u00276569e0c3-43c9-4ee2-84ff-ea7fa8da8110\u0027)"},{"line_number":66,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb96e878_1447f37e","line":63,"range":{"start_line":63,"start_character":45,"end_line":63,"end_character":46},"in_reply_to":"36375322_27a0f2de","updated":"2021-09-14 11:31:14.000000000","message":"Done","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"434b1c536c61f9c7a5666f7f34e3a78e3c3731ae","unresolved":true,"context_lines":[{"line_number":73,"context_line":"                                    cleanup_in_class\u003dFalse)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # get backend of shares"},{"line_number":76,"context_line":"        instance_a \u003d self._get_instance(self.share_a)"},{"line_number":77,"context_line":"        backend_a \u003d instance_a.get(\u0027host\u0027).split(\u0027#\u0027)[0]"},{"line_number":78,"context_line":"        instance_c \u003d self._get_instance(share_c)"},{"line_number":79,"context_line":"        backend_c \u003d instance_c.get(\u0027host\u0027).split(\u0027#\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"4876c5e5_3d157301","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":53},"updated":"2021-09-13 23:50:27.000000000","message":"it isn\u0027t necessary, \n\nthe \"host\" attribute is available to admins on the share itself.. \n\nso:\n\n share_a \u003d self.admin_shares_v2_client.get_share(share_a[\u0027id\u0027])\n share_c \u003d self.admin_shares_v2_client.get_share(share_c[\u0027id\u0027])","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"923d161b6540d5fb9d52c1ed2153644dd04f4bc1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                                    cleanup_in_class\u003dFalse)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # get backend of shares"},{"line_number":76,"context_line":"        instance_a \u003d self._get_instance(self.share_a)"},{"line_number":77,"context_line":"        backend_a \u003d instance_a.get(\u0027host\u0027).split(\u0027#\u0027)[0]"},{"line_number":78,"context_line":"        instance_c \u003d self._get_instance(share_c)"},{"line_number":79,"context_line":"        backend_c \u003d instance_c.get(\u0027host\u0027).split(\u0027#\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"31e21f96_56c4ae3a","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":53},"in_reply_to":"4876c5e5_3d157301","updated":"2021-09-14 11:31:14.000000000","message":"Done","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"434b1c536c61f9c7a5666f7f34e3a78e3c3731ae","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # get backend of shares"},{"line_number":76,"context_line":"        instance_a \u003d self._get_instance(self.share_a)"},{"line_number":77,"context_line":"        backend_a \u003d instance_a.get(\u0027host\u0027).split(\u0027#\u0027)[0]"},{"line_number":78,"context_line":"        instance_c \u003d self._get_instance(share_c)"},{"line_number":79,"context_line":"        backend_c \u003d instance_c.get(\u0027host\u0027).split(\u0027#\u0027)[0]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e2b275df_72c699bf","line":77,"range":{"start_line":77,"start_character":42,"end_line":77,"end_character":56},"updated":"2021-09-13 23:50:27.000000000","message":"The scheduler filters aren\u0027t going to ignore the pool, so you shouldn\u0027t need to split it out here as well.","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"923d161b6540d5fb9d52c1ed2153644dd04f4bc1","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # get backend of shares"},{"line_number":76,"context_line":"        instance_a \u003d self._get_instance(self.share_a)"},{"line_number":77,"context_line":"        backend_a \u003d instance_a.get(\u0027host\u0027).split(\u0027#\u0027)[0]"},{"line_number":78,"context_line":"        instance_c \u003d self._get_instance(share_c)"},{"line_number":79,"context_line":"        backend_c \u003d instance_c.get(\u0027host\u0027).split(\u0027#\u0027)[0]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c9b48dc5_0a28bec4","line":77,"range":{"start_line":77,"start_character":42,"end_line":77,"end_character":56},"in_reply_to":"e2b275df_72c699bf","updated":"2021-09-14 11:31:14.000000000","message":"Done","commit_id":"9eebe1dcfa1bf6fe1d622aa968335af05ed4c8b7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e595bb766297e8e655a591b3627adf5aee818070","unresolved":true,"context_lines":[{"line_number":34,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":35,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":36,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":37,"context_line":"                                    \"Skipping.\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"f6073194_aa3737e0","line":37,"range":{"start_line":37,"start_character":47,"end_line":37,"end_character":48},"updated":"2021-09-14 19:40:44.000000000","message":"These tests must also be skipped with microversion \u003c 2.65, you can invoke this method:\n\nhttps://github.com/openstack/manila-tempest-plugin/blob/ed2b75e6ae6a1dd99dba2a20133845ba115fbc48/manila_tempest_tests/utils.py#L98-L102","commit_id":"2c2781260669d17405353234bbdd7fc0b93175f6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"417cdce2daaaa3df98236c87d814776fc39499f1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":35,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":36,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":37,"context_line":"                                    \"Skipping.\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2f12f201_dcdfa36d","line":37,"range":{"start_line":37,"start_character":47,"end_line":37,"end_character":48},"in_reply_to":"60472de7_adb76982","updated":"2021-09-15 07:07:11.000000000","message":"Done","commit_id":"2c2781260669d17405353234bbdd7fc0b93175f6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4da455af5a1bf5c49e472e7c6dd49560b91a9ce3","unresolved":true,"context_lines":[{"line_number":34,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":35,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":36,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":37,"context_line":"                                    \"Skipping.\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"60472de7_adb76982","line":37,"range":{"start_line":37,"start_character":47,"end_line":37,"end_character":48},"in_reply_to":"f6073194_aa3737e0","updated":"2021-09-15 01:13:04.000000000","message":"we need to add \nfrom manila_tempest_tests import utils\nutils.check_skip_if_microversion_not_supported(\"2.65\")","commit_id":"2c2781260669d17405353234bbdd7fc0b93175f6"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"13e162b9a5b04776c8beac1abc8f8b563f1b44d3","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":37,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":38,"context_line":"                                    \"Skipping.\")"},{"line_number":39,"context_line":"        utils.check_skip_if_microversion_not_supported(\u00272.65\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"62d4b13b_ee8f9769","line":39,"range":{"start_line":39,"start_character":14,"end_line":39,"end_character":54},"updated":"2021-09-17 17:19:03.000000000","message":"nit, could be the first check","commit_id":"98b3e8782d20d193974173c5763236bb0478a289"}]}