)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7ef29d840152b08e5be7a64834339dfde77f43c6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     lkk \u003clikangkang01@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-09-16 11:35:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pre-existing metadata items, set new share metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib463a38cb731f1a61c5eee185343304ee991956e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"272f8766_68f35b57","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":51},"updated":"2021-12-30 14:02:21.000000000","message":"Please add some details in the body.","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7ef29d840152b08e5be7a64834339dfde77f43c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fceaa36_75271d8e","updated":"2021-12-30 14:02:21.000000000","message":"Thanks!","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e1ed9ecd4a56fea2aff92a5e78848d7db034bd97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"616bdfe8_d56b6110","updated":"2022-01-02 08:45:51.000000000","message":"LGTM!","commit_id":"032a8fbeed4684b03de98fcc3c40c8376dc57188"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"23ff0ec7ffeedf8e12217ae504e30a5874ffaa5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6e05384c_be09678f","updated":"2022-01-05 22:58:54.000000000","message":"LGTM, thanks!","commit_id":"032a8fbeed4684b03de98fcc3c40c8376dc57188"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"d684100e8572bb720273d007c72cd7a421b7bd36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1227c7cf_f80d9daf","updated":"2022-01-14 08:59:03.000000000","message":"run-DellEMC VNX CI","commit_id":"032a8fbeed4684b03de98fcc3c40c8376dc57188"}],"manila_tempest_tests/tests/api/test_metadata.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7ef29d840152b08e5be7a64834339dfde77f43c6","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        # create share with metadata"},{"line_number":41,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":42,"context_line":"                                  metadata\u003dmd,"},{"line_number":43,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # get metadata of share"},{"line_number":46,"context_line":"        metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # verify metadata"},{"line_number":49,"context_line":"        self.assertEqual(md, metadata)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u00272725ab8e-cc04-4032-9393-74726ba43eb7\u0027)"},{"line_number":52,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"00dabc19_2472190b","line":49,"range":{"start_line":40,"start_character":0,"end_line":49,"end_character":38},"updated":"2021-12-30 14:02:21.000000000","message":"You can use the local method \"_verify_share_metadata\".\nRelated to the comment after.","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"fb8d0f0784240bf19d2443370840625773a22dd7","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        # create share with metadata"},{"line_number":41,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":42,"context_line":"                                  metadata\u003dmd,"},{"line_number":43,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # get metadata of share"},{"line_number":46,"context_line":"        metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # verify metadata"},{"line_number":49,"context_line":"        self.assertEqual(md, metadata)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u00272725ab8e-cc04-4032-9393-74726ba43eb7\u0027)"},{"line_number":52,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0302e004_d3cce2d9","line":49,"range":{"start_line":40,"start_character":0,"end_line":49,"end_character":38},"in_reply_to":"00dabc19_2472190b","updated":"2021-12-31 08:58:53.000000000","message":"Done","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7ef29d840152b08e5be7a64834339dfde77f43c6","unresolved":true,"context_lines":[{"line_number":59,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # set metadata"},{"line_number":62,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # read metadata"},{"line_number":65,"context_line":"        get_md \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # verify metadata"},{"line_number":68,"context_line":"        self.assertEqual(md, get_md)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # verify metadata items"},{"line_number":71,"context_line":"        for key in md:"},{"line_number":72,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":73,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # delete metadata"},{"line_number":76,"context_line":"        for key in md.keys():"},{"line_number":77,"context_line":"            self.shares_client.delete_metadata(share[\"id\"], key)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # verify deletion of metadata"},{"line_number":80,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"65c126e7_0fb5344a","line":77,"range":{"start_line":62,"start_character":0,"end_line":77,"end_character":64},"updated":"2021-12-30 14:02:21.000000000","message":"Same.","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"fb8d0f0784240bf19d2443370840625773a22dd7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # set metadata"},{"line_number":62,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # read metadata"},{"line_number":65,"context_line":"        get_md \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # verify metadata"},{"line_number":68,"context_line":"        self.assertEqual(md, get_md)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # verify metadata items"},{"line_number":71,"context_line":"        for key in md:"},{"line_number":72,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":73,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # delete metadata"},{"line_number":76,"context_line":"        for key in md.keys():"},{"line_number":77,"context_line":"            self.shares_client.delete_metadata(share[\"id\"], key)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # verify deletion of metadata"},{"line_number":80,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"2e5036b0_f994ddd0","line":77,"range":{"start_line":62,"start_character":0,"end_line":77,"end_character":64},"in_reply_to":"65c126e7_0fb5344a","updated":"2021-12-31 08:58:53.000000000","message":"Done","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7ef29d840152b08e5be7a64834339dfde77f43c6","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # verify deletion of metadata"},{"line_number":80,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":81,"context_line":"        self.assertEqual({}, get_metadata)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @decorators.idempotent_id(\u00274e5f8159-62b6-4d5c-f729-d8b1f029d7de\u0027)"},{"line_number":84,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0b2c0f7f_19b38ff2","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":42},"updated":"2021-12-30 14:02:21.000000000","message":"self.assertEmpty(get_metadata)","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"fb8d0f0784240bf19d2443370840625773a22dd7","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # verify deletion of metadata"},{"line_number":80,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":81,"context_line":"        self.assertEqual({}, get_metadata)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @decorators.idempotent_id(\u00274e5f8159-62b6-4d5c-f729-d8b1f029d7de\u0027)"},{"line_number":84,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fc9770d_24617d5e","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":42},"in_reply_to":"0b2c0f7f_19b38ff2","updated":"2021-12-31 08:58:53.000000000","message":"Done","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7ef29d840152b08e5be7a64834339dfde77f43c6","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":91,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # set metadata"},{"line_number":94,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md1)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # read metadata"},{"line_number":97,"context_line":"        get_md1 \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # verify metadata"},{"line_number":100,"context_line":"        self.assertEqual(md1, get_md1)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # verify metadata items"},{"line_number":103,"context_line":"        for key in md1:"},{"line_number":104,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":105,"context_line":"            self.assertEqual(md1[key], get_value[key])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # set metadata again"},{"line_number":108,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2e65c5a2_72242b2e","line":105,"range":{"start_line":93,"start_character":0,"end_line":105,"end_character":54},"updated":"2021-12-30 14:02:21.000000000","message":"This code snippet is repeated several times.\nI suggest to create a local method called \"_verify_share_metadata\"\nfor reusable by the test methods.","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"fb8d0f0784240bf19d2443370840625773a22dd7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":91,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # set metadata"},{"line_number":94,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md1)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # read metadata"},{"line_number":97,"context_line":"        get_md1 \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # verify metadata"},{"line_number":100,"context_line":"        self.assertEqual(md1, get_md1)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # verify metadata items"},{"line_number":103,"context_line":"        for key in md1:"},{"line_number":104,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":105,"context_line":"            self.assertEqual(md1[key], get_value[key])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # set metadata again"},{"line_number":108,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bb094f3c_343dd764","line":105,"range":{"start_line":93,"start_character":0,"end_line":105,"end_character":54},"in_reply_to":"2e65c5a2_72242b2e","updated":"2021-12-31 08:58:53.000000000","message":"Done","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7ef29d840152b08e5be7a64834339dfde77f43c6","unresolved":true,"context_lines":[{"line_number":105,"context_line":"            self.assertEqual(md1[key], get_value[key])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # set metadata again"},{"line_number":108,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md2)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # read metadata"},{"line_number":111,"context_line":"        get_md2 \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # verify metadata"},{"line_number":114,"context_line":"        md1.update(md2)"},{"line_number":115,"context_line":"        md \u003d md1"},{"line_number":116,"context_line":"        self.assertEqual(md, get_md2)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # verify metadata items"},{"line_number":119,"context_line":"        for key in md:"},{"line_number":120,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":121,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # delete metadata"},{"line_number":124,"context_line":"        for key in md.keys():"},{"line_number":125,"context_line":"            self.shares_client.delete_metadata(share[\"id\"], key)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # verify deletion of metadata"},{"line_number":128,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"92ab3b62_5c1bb68c","line":125,"range":{"start_line":108,"start_character":1,"end_line":125,"end_character":64},"updated":"2021-12-30 14:02:21.000000000","message":"Duplicated code.","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"fb8d0f0784240bf19d2443370840625773a22dd7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self.assertEqual(md1[key], get_value[key])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # set metadata again"},{"line_number":108,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md2)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # read metadata"},{"line_number":111,"context_line":"        get_md2 \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # verify metadata"},{"line_number":114,"context_line":"        md1.update(md2)"},{"line_number":115,"context_line":"        md \u003d md1"},{"line_number":116,"context_line":"        self.assertEqual(md, get_md2)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # verify metadata items"},{"line_number":119,"context_line":"        for key in md:"},{"line_number":120,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":121,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # delete metadata"},{"line_number":124,"context_line":"        for key in md.keys():"},{"line_number":125,"context_line":"            self.shares_client.delete_metadata(share[\"id\"], key)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # verify deletion of metadata"},{"line_number":128,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9df93b04_31d838c3","line":125,"range":{"start_line":108,"start_character":1,"end_line":125,"end_character":64},"in_reply_to":"92ab3b62_5c1bb68c","updated":"2021-12-31 08:58:53.000000000","message":"Done","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7ef29d840152b08e5be7a64834339dfde77f43c6","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # verify deletion of metadata"},{"line_number":128,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":129,"context_line":"        self.assertEqual({}, get_metadata)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @decorators.idempotent_id(\u00272ec70ba5-050b-3b17-c862-c149e53543c0\u0027)"},{"line_number":132,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b1e56d95_76e5edb5","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":42},"updated":"2021-12-30 14:02:21.000000000","message":"self.assertEmpty(get_metadata)","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"fb8d0f0784240bf19d2443370840625773a22dd7","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # verify deletion of metadata"},{"line_number":128,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":129,"context_line":"        self.assertEqual({}, get_metadata)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @decorators.idempotent_id(\u00272ec70ba5-050b-3b17-c862-c149e53543c0\u0027)"},{"line_number":132,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"53240abc_67086617","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":42},"in_reply_to":"b1e56d95_76e5edb5","updated":"2021-12-31 08:58:53.000000000","message":"Done","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7ef29d840152b08e5be7a64834339dfde77f43c6","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":139,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # set metadata"},{"line_number":142,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md1)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # read metadata"},{"line_number":145,"context_line":"        get_md1 \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        # verify metadata"},{"line_number":148,"context_line":"        self.assertEqual(md1, get_md1)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # verify metadata items"},{"line_number":151,"context_line":"        for key in md1:"},{"line_number":152,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":153,"context_line":"            self.assertEqual(md1[key], get_value[key])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # set metadata again"},{"line_number":156,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md2)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # read metadata"},{"line_number":159,"context_line":"        get_md2 \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        # verify metadata"},{"line_number":162,"context_line":"        md \u003d {u\"key9\": u\"value13\", u\"key10\": u\"value10\","},{"line_number":163,"context_line":"              u\"key11\": u\"value11\"}"},{"line_number":164,"context_line":"        self.assertEqual(md, get_md2)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        # verify metadata items"},{"line_number":167,"context_line":"        for key in md:"},{"line_number":168,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":169,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # delete metadata"},{"line_number":172,"context_line":"        for key in md.keys():"},{"line_number":173,"context_line":"            self.shares_client.delete_metadata(share[\"id\"], key)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # verify deletion of metadata"},{"line_number":176,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":177,"context_line":"        self.assertEqual({}, get_metadata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4470fbb4_75324227","line":174,"range":{"start_line":141,"start_character":0,"end_line":174,"end_character":0},"updated":"2021-12-30 14:02:21.000000000","message":"Duplicated code.","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"fb8d0f0784240bf19d2443370840625773a22dd7","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":139,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # set metadata"},{"line_number":142,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md1)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # read metadata"},{"line_number":145,"context_line":"        get_md1 \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        # verify metadata"},{"line_number":148,"context_line":"        self.assertEqual(md1, get_md1)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # verify metadata items"},{"line_number":151,"context_line":"        for key in md1:"},{"line_number":152,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":153,"context_line":"            self.assertEqual(md1[key], get_value[key])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # set metadata again"},{"line_number":156,"context_line":"        self.shares_client.set_metadata(share[\"id\"], md2)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # read metadata"},{"line_number":159,"context_line":"        get_md2 \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        # verify metadata"},{"line_number":162,"context_line":"        md \u003d {u\"key9\": u\"value13\", u\"key10\": u\"value10\","},{"line_number":163,"context_line":"              u\"key11\": u\"value11\"}"},{"line_number":164,"context_line":"        self.assertEqual(md, get_md2)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        # verify metadata items"},{"line_number":167,"context_line":"        for key in md:"},{"line_number":168,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":169,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # delete metadata"},{"line_number":172,"context_line":"        for key in md.keys():"},{"line_number":173,"context_line":"            self.shares_client.delete_metadata(share[\"id\"], key)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # verify deletion of metadata"},{"line_number":176,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":177,"context_line":"        self.assertEqual({}, get_metadata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8e64684c_6b9ecb07","line":174,"range":{"start_line":141,"start_character":0,"end_line":174,"end_character":0},"in_reply_to":"4470fbb4_75324227","updated":"2021-12-31 08:58:53.000000000","message":"Done","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7ef29d840152b08e5be7a64834339dfde77f43c6","unresolved":true,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # verify deletion of metadata"},{"line_number":176,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":177,"context_line":"        self.assertEqual({}, get_metadata)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @decorators.idempotent_id(\u0027c94851f4-2559-4712-9297-9912db1da7ff\u0027)"},{"line_number":180,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7252f9f3_cdee7c8c","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":42},"updated":"2021-12-30 14:02:21.000000000","message":"self.assertEmpty(get_metadata)","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"fb8d0f0784240bf19d2443370840625773a22dd7","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # verify deletion of metadata"},{"line_number":176,"context_line":"        get_metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":177,"context_line":"        self.assertEqual({}, get_metadata)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @decorators.idempotent_id(\u0027c94851f4-2559-4712-9297-9912db1da7ff\u0027)"},{"line_number":180,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"211449ed_dfd21044","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":42},"in_reply_to":"7252f9f3_cdee7c8c","updated":"2021-12-31 08:58:53.000000000","message":"Done","commit_id":"f823aa18abd4efad2ad2155c856ddb151c3ed116"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"23ff0ec7ffeedf8e12217ae504e30a5874ffaa5c","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        metadata \u003d self.shares_client.get_metadata(share[\"id\"])[\u0027metadata\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        # verify metadata"},{"line_number":40,"context_line":"        self.assertEqual(md, metadata)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        # verify metadata items"},{"line_number":43,"context_line":"        for key in md:"}],"source_content_type":"text/x-python","patch_set":3,"id":"69894a85_6d36ae91","line":40,"range":{"start_line":40,"start_character":13,"end_line":40,"end_character":24},"updated":"2022-01-05 22:58:54.000000000","message":"self.assertDictEqual would be more appropriate","commit_id":"032a8fbeed4684b03de98fcc3c40c8376dc57188"}]}