)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7dac279bfdb2dac9f428a9d7a20a02c3781a5dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9fa7cab_29c6e1dc","updated":"2022-02-04 18:17:08.000000000","message":"recheck","commit_id":"48cd24fd188d07ac673c5023eb9088cccfa04783"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a9e17bfa1bf149125f2783a0c1368d73490d0f20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a2584c61_3e621df1","updated":"2022-02-10 23:07:43.000000000","message":"recheck","commit_id":"0ecf39cf0c1f8cadfad350a59a40e91f46f6a9c5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a7c0aac5dc6defbdddb9bf285cee0032490eb6e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bd729d0d_183cf895","updated":"2022-02-22 21:21:29.000000000","message":"Thanks Carlos.","commit_id":"854f6dd395c9cdd970893233aea6a6c6fdb15b8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5096126981bd65a01b3e93e7ad52e6581a9529a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bfb5bb48_bb7ca116","updated":"2022-02-22 21:26:32.000000000","message":"good improvement for sure, question inline about the timeout. ","commit_id":"854f6dd395c9cdd970893233aea6a6c6fdb15b8c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bc1b85292dfa87386a6bb7de5f509ae249c8be97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f822dec7_7382dbac","updated":"2022-02-22 20:24:23.000000000","message":"thanks for reviewing, Douglas\nPlease check the modifications inline","commit_id":"854f6dd395c9cdd970893233aea6a6c6fdb15b8c"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"54d26b9865bd0d7b658cbab26f92d626b8975f56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"16b32dc8_91559745","updated":"2022-02-25 17:26:51.000000000","message":"LGTM carloss","commit_id":"a894bae49a7d911d448e30a3ef8c9fd9d748e0f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2196dffd15cb5837fbb3250d05efde42473a5fbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"58567fb5_a10f5c55","updated":"2022-02-23 15:05:01.000000000","message":"Thank you for the reviews, Douglas and Goutham\nPlease check the changes inline","commit_id":"a894bae49a7d911d448e30a3ef8c9fd9d748e0f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b2199334617648a578f72cfaa87f650f84c56db9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a8eb9b1_4f933cd4","updated":"2022-03-02 18:59:23.000000000","message":"Thanks Carlos","commit_id":"a894bae49a7d911d448e30a3ef8c9fd9d748e0f7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0009f5effd6841d9dc9e51f5041c7718cce1eb5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b57e3634_c27304d7","updated":"2022-02-23 19:07:39.000000000","message":"Thanks, LGTM","commit_id":"a894bae49a7d911d448e30a3ef8c9fd9d748e0f7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c741a5f40923de950a39bc62853ec4415c189abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bddc40ed_2a9595ad","updated":"2022-03-16 19:25:45.000000000","message":"This broke stable/train testing; fixing here: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/834064","commit_id":"a894bae49a7d911d448e30a3ef8c9fd9d748e0f7"}],"manila_tempest_tests/common/remote_client.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3abea3f186db4d2035e06c1f8a0c8328556158ae","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        self.server \u003d server"},{"line_number":72,"context_line":"        self.servers_client \u003d servers_client"},{"line_number":73,"context_line":"        self.log_console \u003d CONF.compute_feature_enabled.console_output"},{"line_number":74,"context_line":"        ssh_key_type \u003d CONF.validation.ssh_key_type or \u0027rsa\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.ssh_client \u003d ssh.Client("},{"line_number":77,"context_line":"            ip_address, username, password, timeout\u003d500, pkey\u003dpkey,"},{"line_number":78,"context_line":"            ssh_key_type\u003dssh_key_type)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @debug_ssh"},{"line_number":81,"context_line":"    def exec_command(self, cmd):"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ceaae3e_78058b1c","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":38},"updated":"2022-02-22 13:22:46.000000000","message":"why don\u0027t you pass \u0027ssh_key_type\u0027 as kwargs if \u0027CONF.validation.ssh_key_type\u0027 is defined only, instead of hardcoding \u0027rsa\u0027? it will continue to use ssh.Client defaults","commit_id":"19f9d82e2f56f7b929e4030905abd2599c7e010d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bc1b85292dfa87386a6bb7de5f509ae249c8be97","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        self.server \u003d server"},{"line_number":72,"context_line":"        self.servers_client \u003d servers_client"},{"line_number":73,"context_line":"        self.log_console \u003d CONF.compute_feature_enabled.console_output"},{"line_number":74,"context_line":"        ssh_key_type \u003d CONF.validation.ssh_key_type or \u0027rsa\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.ssh_client \u003d ssh.Client("},{"line_number":77,"context_line":"            ip_address, username, password, timeout\u003d500, pkey\u003dpkey,"},{"line_number":78,"context_line":"            ssh_key_type\u003dssh_key_type)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @debug_ssh"},{"line_number":81,"context_line":"    def exec_command(self, cmd):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bd61d8b7_0ee0b418","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":38},"in_reply_to":"0ceaae3e_78058b1c","updated":"2022-02-22 20:24:23.000000000","message":"makes sense, thanks","commit_id":"19f9d82e2f56f7b929e4030905abd2599c7e010d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b2199334617648a578f72cfaa87f650f84c56db9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.server \u003d server"},{"line_number":72,"context_line":"        self.servers_client \u003d servers_client"},{"line_number":73,"context_line":"        self.log_console \u003d CONF.compute_feature_enabled.console_output"},{"line_number":74,"context_line":"        ssh_key_type \u003d CONF.validation.ssh_key_type or \u0027rsa\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.ssh_client \u003d ssh.Client("},{"line_number":77,"context_line":"            ip_address, username, password, timeout\u003d500, pkey\u003dpkey,"},{"line_number":78,"context_line":"            ssh_key_type\u003dssh_key_type)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @debug_ssh"},{"line_number":81,"context_line":"    def exec_command(self, cmd):"}],"source_content_type":"text/x-python","patch_set":4,"id":"704b777e_ae01bb61","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":38},"in_reply_to":"bd61d8b7_0ee0b418","updated":"2022-03-02 18:59:23.000000000","message":"Done","commit_id":"19f9d82e2f56f7b929e4030905abd2599c7e010d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a7c0aac5dc6defbdddb9bf285cee0032490eb6e2","unresolved":true,"context_lines":[{"line_number":76,"context_line":"            kwargs[\u0027ssh_key_type\u0027] \u003d CONF.validation.ssh_key_type"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        self.ssh_client \u003d ssh.Client("},{"line_number":79,"context_line":"            ip_address, username, password, timeout\u003d500, pkey\u003dpkey,"},{"line_number":80,"context_line":"            **kwargs)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @debug_ssh"}],"source_content_type":"text/x-python","patch_set":5,"id":"cf90aaf1_87bdafdf","line":79,"range":{"start_line":79,"start_character":44,"end_line":79,"end_character":55},"updated":"2022-02-22 21:21:29.000000000","message":"no comments about that, but you are probably increasing it, right?\nwe should add an new option in future if we need to change it again.","commit_id":"854f6dd395c9cdd970893233aea6a6c6fdb15b8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5096126981bd65a01b3e93e7ad52e6581a9529a","unresolved":true,"context_lines":[{"line_number":76,"context_line":"            kwargs[\u0027ssh_key_type\u0027] \u003d CONF.validation.ssh_key_type"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        self.ssh_client \u003d ssh.Client("},{"line_number":79,"context_line":"            ip_address, username, password, timeout\u003d500, pkey\u003dpkey,"},{"line_number":80,"context_line":"            **kwargs)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @debug_ssh"}],"source_content_type":"text/x-python","patch_set":5,"id":"eb038eb1_198db9b6","line":79,"range":{"start_line":79,"start_character":44,"end_line":79,"end_character":55},"in_reply_to":"cf90aaf1_87bdafdf","updated":"2022-02-22 21:26:32.000000000","message":"yeah, why are we increasing the timeout here.. this won\u0027t be consistent with the test\u0027s own build timeouts... maybe you want to allow using the other timeout config options instead? \n\nhttps://github.com/openstack/tempest/blob/ca03d2b504eabb19aff56ea6673eeb9a7d7b22fe/tempest/config.py#L927-L936","commit_id":"854f6dd395c9cdd970893233aea6a6c6fdb15b8c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2196dffd15cb5837fbb3250d05efde42473a5fbf","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            kwargs[\u0027ssh_key_type\u0027] \u003d CONF.validation.ssh_key_type"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        self.ssh_client \u003d ssh.Client("},{"line_number":79,"context_line":"            ip_address, username, password, timeout\u003d500, pkey\u003dpkey,"},{"line_number":80,"context_line":"            **kwargs)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @debug_ssh"}],"source_content_type":"text/x-python","patch_set":5,"id":"0a404a54_901bbddf","line":79,"range":{"start_line":79,"start_character":44,"end_line":79,"end_character":55},"in_reply_to":"eb038eb1_198db9b6","updated":"2022-02-23 15:05:01.000000000","message":"Not a specific reason - I added this while debugging because I wanted to check if this could help with the timeout issues we had with the ssh connections. I can remove it though, I think it is not going to impact anything","commit_id":"854f6dd395c9cdd970893233aea6a6c6fdb15b8c"}]}