)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff9daf605f5732b76121b656da907d05a38b7e62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"166efcca_382d0bd8","updated":"2022-01-09 18:29:02.000000000","message":"Good work, nothing to add! LGTM.","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"024d831aca89ab43466df55a7293af1feeaa9264","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd72aacf_54227888","updated":"2021-11-02 01:35:58.000000000","message":"LGTM，thanks Kiran Pawar!","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"905f358f7bfaf5e151e114e9749ccc0e387e0e76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e57a06e1_68753ee6","updated":"2022-01-14 02:51:23.000000000","message":"Oh wait; i went ahead of myself --- the microversion needs to be adjusted to 2.67 now. ","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6329c179f1353c8cc28f116d38510661592f7bb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3784eaa_a2f153ea","updated":"2022-01-14 02:50:45.000000000","message":"This LGTM, lets get this in.. ","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cbadd31ad75dffcffda90eddc3606c0795b03ff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f98f04a1_3ecbf6b7","updated":"2021-12-09 01:00:31.000000000","message":"We don\u0027t have a stable/xena job.. where this test will likely fail..I\u0027ll add more comments in the manila patch.. ","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66c52c0450f6c3e9e8d451472ab3d0f52aae40c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"314c05b6_a2fe8b19","updated":"2021-12-15 19:17:52.000000000","message":"recheck\n\n\njobs are now adjusted; this should in theory fail against the stable/xena branch.. ","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c440a4ae4fd0dcacad597b859d0a6364a854f96d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c504eb0_5bffcb0d","in_reply_to":"314c05b6_a2fe8b19","updated":"2021-12-24 16:49:08.000000000","message":"yes they should fail on stable/xena but pass on master as I added Depends on in description.","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55e8ffa167637ab84b64d8eadbea2011352a2b63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5cf332b6_4861a236","in_reply_to":"38b7cf92_0b196ebe","updated":"2022-01-18 23:51:34.000000000","message":"A change in config was needed to ensure the tests are run..","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"089ccd7e5bb83ae689b0d5bbecef5b0a31adae42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38b7cf92_0b196ebe","in_reply_to":"e57a06e1_68753ee6","updated":"2022-01-14 16:43:46.000000000","message":"changed version 2.65 in test as well as commit description. Please check","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"d3dc18f966e94120c59dcc1c21f85ed034416123","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa9466dd_7cc70573","updated":"2022-01-19 01:27:55.000000000","message":"LGTM","commit_id":"40e112ad5bb101c585537af025a88899f4833f37"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55e8ffa167637ab84b64d8eadbea2011352a2b63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7fc06b82_a8a3bf54","updated":"2022-01-18 23:51:34.000000000","message":"Thanks for the change, LGTM","commit_id":"40e112ad5bb101c585537af025a88899f4833f37"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f447c657f32650ee81fbb9ae09148fd98c30657f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"68b2bd13_955b191d","updated":"2022-02-05 06:42:26.000000000","message":"I tried to fix all possible suggestions. Please check","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b1cc8f52097f4194ed5437c897a2cb5a3d59b34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff8aa6cf_3f75f905","updated":"2022-02-04 23:16:49.000000000","message":"Thanks, please take a look at the comments inline","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ab78d5e422c2c645307fe85dcb6e96f6fafb2985","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7e2ffdf6_2f99e223","updated":"2022-02-04 17:40:56.000000000","message":"run-NetApp CI","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a2b45a5cf98c1e9e6d410e22bd07fc02aa1bdc32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9ad68477_2108fe0a","updated":"2022-02-03 13:18:45.000000000","message":"run-NetApp CI","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"9cc0d0cb2fa44b6365e60d236466b3d615cbe23d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"94fa38ef_74546ff2","updated":"2022-02-07 15:10:54.000000000","message":"run-NetApp CI","commit_id":"2b92e09e3725065a102a7b68604134d9c1b69733"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"7de4fb2362ee677ac8c4675ba96dfdd65b526394","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ac0786fe_6ea1a2b7","updated":"2022-02-07 20:22:37.000000000","message":"run-NetApp CI","commit_id":"2b92e09e3725065a102a7b68604134d9c1b69733"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4482bbfb17121527aa6c5b8b093fcae75e2204bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6ceb60de_f7293fcd","updated":"2022-02-08 00:15:01.000000000","message":"thanks for the changes, please see comments inline","commit_id":"2b92e09e3725065a102a7b68604134d9c1b69733"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46e9bafdf9b40c0b02cdebb8409caa45be102ab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7599ecd3_3281b214","updated":"2022-02-14 23:46:38.000000000","message":"This looks good, couple of minor comments inline to address if you make another patch.. \n\nI was hoping to see results of this from a \"real\" backend -- it looks like we\u0027re just running \"BACKEND\" tests with the zfsonlinux driver; and the NetApp CI seems to be misconfigured a bit.. \n\nThere are multiple backends enabled:\nhttps://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/68/816168/10/upstream-check/manila-cDOT-manila-tempest-plugin-no-ss/5085096/5085096/logs/etc/manila/manila.conf.txt\n\nhowever, tempest configuration seems incorrect, logs are missing tempest.conf and tempest.log, but, you can see the console log from the run show you the value of tempest\u0027s [share]/enabled_backends configuration parameter - it\u0027s incorrect. \n\nFelipe/Andre - can either of you sign off on these tests?","commit_id":"03167dc5f41d94fe50a02c1c856af64d32aca057"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"875536b16618c46dd9ebcbb1073c49a68d8f7eea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"47d1e496_9ed7aef0","updated":"2022-02-15 00:02:09.000000000","message":"Vote","commit_id":"03167dc5f41d94fe50a02c1c856af64d32aca057"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"164193d7e6d791dfbe392316b0d61a1b5df5f0fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d9be66e2_f72af736","updated":"2022-02-22 21:21:42.000000000","message":"Kiran, can you please resolve the merge conflict and respond to Liron\u0027s comments?\n\nWe merged tests for a later microversion recently, so, no need to set anything in the config file, your tests for 2.67 will run with the latest state of this repository","commit_id":"ad4cfca444452fe370eddcd88d795c1baceaffa8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b22e6273a2430e7006c7ee51fbab94ab4e1948fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"65f15635_706fe576","updated":"2022-02-15 03:52:51.000000000","message":"LGTM, thank you for the correction","commit_id":"ad4cfca444452fe370eddcd88d795c1baceaffa8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cd6e53f230e5597906ec031c121f61a2480c8c91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bc1afc8b_75a1cd54","updated":"2022-02-16 09:27:32.000000000","message":"Thanks Kiran, LGTM.\nTiny minor details, sorry about that, it should take 2 sec to fix :)","commit_id":"ad4cfca444452fe370eddcd88d795c1baceaffa8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c2f1e28d30f02f5caf189d71f53eb6e93e6891bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ffff579b_6eb5968b","in_reply_to":"d9be66e2_f72af736","updated":"2022-02-24 11:38:30.000000000","message":"Done.","commit_id":"ad4cfca444452fe370eddcd88d795c1baceaffa8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e7c1ceea32355bc321fe7e484676c440e850418f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"589a933d_1a72cb03","updated":"2022-02-24 16:52:05.000000000","message":"LGTM, thank you for the changes!","commit_id":"59745065f9aa13dbfc2ed7de2dc480e74fac81fc"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0bb07ecedf76484ff11ff5f253e9e45b9028aa1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"677324e6_8b507358","updated":"2022-02-27 11:03:16.000000000","message":"Thanks Kiran!","commit_id":"59745065f9aa13dbfc2ed7de2dc480e74fac81fc"}],"manila_tempest_tests/tests/api/admin/test_scheduler_hints.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cbadd31ad75dffcffda90eddc3606c0795b03ff8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3d16f879_d54f00bc","line":72,"range":{"start_line":69,"start_character":0,"end_line":72,"end_character":0},"updated":"2021-12-09 01:00:31.000000000","message":"I am confused how this test will pass in stable/xena where the only_host filter doesn\u0027t exist...","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4482bbfb17121527aa6c5b8b093fcae75e2204bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"372c8165_52a61b99","line":72,"range":{"start_line":69,"start_character":0,"end_line":72,"end_character":0},"in_reply_to":"3d16f879_d54f00bc","updated":"2022-02-08 00:15:01.000000000","message":"Resolved with introducing a new API microversion","commit_id":"0140c07b51ad5a3404c5ba6fa0be4a5f7d922038"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b1cc8f52097f4194ed5437c897a2cb5a3d59b34","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(SharesSchedulerHintsAdminTest, cls).skip_checks()"},{"line_number":32,"context_line":"        if not CONF.share.multi_backend:"},{"line_number":33,"context_line":"            raise cls.skipException(\"Manila multi-backend is disabled.\")"},{"line_number":34,"context_line":"        elif len(CONF.share.backend_names) \u003c 2:"},{"line_number":35,"context_line":"            raise cls.skipException(\"For running multi-backend tests required\""},{"line_number":36,"context_line":"                                    \" two names in config. Skipping.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"022ba864_385a966e","line":33,"range":{"start_line":33,"start_character":58,"end_line":33,"end_character":69},"updated":"2022-02-04 23:16:49.000000000","message":"tests are disabled","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f447c657f32650ee81fbb9ae09148fd98c30657f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(SharesSchedulerHintsAdminTest, cls).skip_checks()"},{"line_number":32,"context_line":"        if not CONF.share.multi_backend:"},{"line_number":33,"context_line":"            raise cls.skipException(\"Manila multi-backend is disabled.\")"},{"line_number":34,"context_line":"        elif len(CONF.share.backend_names) \u003c 2:"},{"line_number":35,"context_line":"            raise cls.skipException(\"For running multi-backend tests required\""},{"line_number":36,"context_line":"                                    \" two names in config. Skipping.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1e01651c_ebaea7ab","line":33,"range":{"start_line":33,"start_character":58,"end_line":33,"end_character":69},"in_reply_to":"022ba864_385a966e","updated":"2022-02-05 06:42:26.000000000","message":"Done","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b1cc8f52097f4194ed5437c897a2cb5a3d59b34","unresolved":true,"context_lines":[{"line_number":33,"context_line":"            raise cls.skipException(\"Manila multi-backend is disabled.\")"},{"line_number":34,"context_line":"        elif len(CONF.share.backend_names) \u003c 2:"},{"line_number":35,"context_line":"            raise cls.skipException(\"For running multi-backend tests required\""},{"line_number":36,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":37,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":38,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":39,"context_line":"                                    \"Skipping.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"eadd3b85_801dc729","line":36,"range":{"start_line":36,"start_character":59,"end_line":36,"end_character":67},"updated":"2022-02-04 23:16:49.000000000","message":"\"Skipping\" isn\u0027t necessary... when a skip exception is raised here, the word \"SKIPPED\" is added to the logs","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b1cc8f52097f4194ed5437c897a2cb5a3d59b34","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        if not CONF.share.multi_backend:"},{"line_number":33,"context_line":"            raise cls.skipException(\"Manila multi-backend is disabled.\")"},{"line_number":34,"context_line":"        elif len(CONF.share.backend_names) \u003c 2:"},{"line_number":35,"context_line":"            raise cls.skipException(\"For running multi-backend tests required\""},{"line_number":36,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":37,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":38,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":39,"context_line":"                                    \"Skipping.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"379af063_5f365594","line":36,"range":{"start_line":35,"start_character":37,"end_line":36,"end_character":57},"updated":"2022-02-04 23:16:49.000000000","message":"For running multi-backend tests, two or more backend names must be configured","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f447c657f32650ee81fbb9ae09148fd98c30657f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        if not CONF.share.multi_backend:"},{"line_number":33,"context_line":"            raise cls.skipException(\"Manila multi-backend is disabled.\")"},{"line_number":34,"context_line":"        elif len(CONF.share.backend_names) \u003c 2:"},{"line_number":35,"context_line":"            raise cls.skipException(\"For running multi-backend tests required\""},{"line_number":36,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":37,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":38,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":39,"context_line":"                                    \"Skipping.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"94275b76_13fc3758","line":36,"range":{"start_line":35,"start_character":37,"end_line":36,"end_character":57},"in_reply_to":"379af063_5f365594","updated":"2022-02-05 06:42:26.000000000","message":"Done","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f447c657f32650ee81fbb9ae09148fd98c30657f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            raise cls.skipException(\"Manila multi-backend is disabled.\")"},{"line_number":34,"context_line":"        elif len(CONF.share.backend_names) \u003c 2:"},{"line_number":35,"context_line":"            raise cls.skipException(\"For running multi-backend tests required\""},{"line_number":36,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":37,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":38,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":39,"context_line":"                                    \"Skipping.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"140eb2cb_ee1eb622","line":36,"range":{"start_line":36,"start_character":59,"end_line":36,"end_character":67},"in_reply_to":"eadd3b85_801dc729","updated":"2022-02-05 06:42:26.000000000","message":"Done","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b1cc8f52097f4194ed5437c897a2cb5a3d59b34","unresolved":true,"context_lines":[{"line_number":36,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":37,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":38,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":39,"context_line":"                                    \"Skipping.\")"},{"line_number":40,"context_line":"        utils.check_skip_if_microversion_not_supported(\u00272.67\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"092c418e_31ead62b","line":39,"range":{"start_line":39,"start_character":37,"end_line":39,"end_character":45},"updated":"2022-02-04 23:16:49.000000000","message":"same comment as above","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f447c657f32650ee81fbb9ae09148fd98c30657f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                    \" two names in config. Skipping.\")"},{"line_number":37,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":38,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":39,"context_line":"                                    \"Skipping.\")"},{"line_number":40,"context_line":"        utils.check_skip_if_microversion_not_supported(\u00272.67\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"7accc369_6f8b7df0","line":39,"range":{"start_line":39,"start_character":37,"end_line":39,"end_character":45},"in_reply_to":"092c418e_31ead62b","updated":"2022-02-05 06:42:26.000000000","message":"Done","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b1cc8f52097f4194ed5437c897a2cb5a3d59b34","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":38,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":39,"context_line":"                                    \"Skipping.\")"},{"line_number":40,"context_line":"        utils.check_skip_if_microversion_not_supported(\u00272.67\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"0be6f6d5_07e0d363","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":62},"updated":"2022-02-04 23:16:49.000000000","message":"in addition, you need to set the max_api_microversion in the config to \u00272.67\u0027 as well, or these tests won\u0027t be run: https://github.com/openstack/manila-tempest-plugin/blob/73e0b6fdc450b7539bf6a97349f5774177ffb24a/manila_tempest_tests/config.py#L42-L45\n\n\nTake a look at one of the test jobs - the tests below don\u0027t show up there: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_ea1/816168/5/check/manila-tempest-plugin-dummy-no-dhss/ea111f4/testr_results.html","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f447c657f32650ee81fbb9ae09148fd98c30657f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        elif any(not name for name in CONF.share.backend_names):"},{"line_number":38,"context_line":"            raise cls.skipException(\"Share backend names can not be empty. \""},{"line_number":39,"context_line":"                                    \"Skipping.\")"},{"line_number":40,"context_line":"        utils.check_skip_if_microversion_not_supported(\u00272.67\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"865dc77b_cd3d0467","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":62},"in_reply_to":"0be6f6d5_07e0d363","updated":"2022-02-05 06:42:26.000000000","message":"Done","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b1cc8f52097f4194ed5437c897a2cb5a3d59b34","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @decorators.idempotent_id(\u00271dec3306-61f4-41b9-ba4a-572a9e6f5f57\u0027)"},{"line_number":75,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":76,"context_line":"    def test_only_host_scheduler_hint_in_share_replica_creation(self):"},{"line_number":77,"context_line":"        share_a \u003d self.admin_shares_v2_client.get_share("},{"line_number":78,"context_line":"            self.share_a[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":79,"context_line":"        backend_a \u003d share_a[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"b6c4fbbb_26212e31","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":63},"updated":"2022-02-04 23:16:49.000000000","message":"Testing of replication is disabled by default configuration here since it is an optional feature for share backends to support.\n\nSo, you\u0027ll need to skip this test unless replication is enabled; example: https://github.com/openstack/manila-tempest-plugin/blob/86f2432476ba9128bb2c26a78ae3b3f53327d4bd/manila_tempest_tests/tests/api/test_revert_to_snapshot.py#L151-L152","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f447c657f32650ee81fbb9ae09148fd98c30657f","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @decorators.idempotent_id(\u00271dec3306-61f4-41b9-ba4a-572a9e6f5f57\u0027)"},{"line_number":75,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":76,"context_line":"    def test_only_host_scheduler_hint_in_share_replica_creation(self):"},{"line_number":77,"context_line":"        share_a \u003d self.admin_shares_v2_client.get_share("},{"line_number":78,"context_line":"            self.share_a[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":79,"context_line":"        backend_a \u003d share_a[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"f7d94c79_0bc89e02","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":63},"in_reply_to":"b6c4fbbb_26212e31","updated":"2022-02-05 06:42:26.000000000","message":"Done","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b1cc8f52097f4194ed5437c897a2cb5a3d59b34","unresolved":true,"context_lines":[{"line_number":78,"context_line":"            self.share_a[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":79,"context_line":"        backend_a \u003d share_a[\u0027host\u0027]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        scheduler_hint \u003d {\"only_host\": \"%s\" % backend_a}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # create share replica with hint"},{"line_number":84,"context_line":"        replica \u003d self.create_share_replica(self.share_a[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"f985da2e_4acb8077","line":81,"range":{"start_line":81,"start_character":25,"end_line":81,"end_character":56},"updated":"2022-02-04 23:16:49.000000000","message":"don\u0027t you want to make sure your replica goes to the other available backend and not the one in which the source/\"active\" replica is?\n\nManila won\u0027t let you create a replica in the same host.. (you *might* be able to create a replica in a different pool in the same host, but, that\u0027s up to the scheduler\u0027s decision).. \n\n\nHere\u0027s an example of a test that gets the available hosts (pools) filtered by the share\u0027s host\u0027s replication domain: https://github.com/openstack/manila-tempest-plugin/blob/86f2432476ba9128bb2c26a78ae3b3f53327d4bd/manila_tempest_tests/tests/api/test_replication.py#L239 - maybe you could use that to find a pool to set as \"only_host\"","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f447c657f32650ee81fbb9ae09148fd98c30657f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            self.share_a[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":79,"context_line":"        backend_a \u003d share_a[\u0027host\u0027]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        scheduler_hint \u003d {\"only_host\": \"%s\" % backend_a}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # create share replica with hint"},{"line_number":84,"context_line":"        replica \u003d self.create_share_replica(self.share_a[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9406e2a9_8411e77f","line":81,"range":{"start_line":81,"start_character":25,"end_line":81,"end_character":56},"in_reply_to":"f985da2e_4acb8077","updated":"2022-02-05 06:42:26.000000000","message":"Done","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b1cc8f52097f4194ed5437c897a2cb5a3d59b34","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        scheduler_hint \u003d {\"only_host\": \"%s\" % backend_a}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # create share replica with hint"},{"line_number":84,"context_line":"        replica \u003d self.create_share_replica(self.share_a[\u0027id\u0027],"},{"line_number":85,"context_line":"                                            None,"},{"line_number":86,"context_line":"                                            cleanup_in_class\u003dFalse,"},{"line_number":87,"context_line":"                                            client\u003dself.admin_client,"},{"line_number":88,"context_line":"                                            version\u003dLATEST_MICROVERSION,"},{"line_number":89,"context_line":"                                            scheduler_hints\u003dscheduler_hint)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # get backend of share replica"},{"line_number":92,"context_line":"        replica \u003d self.admin_shares_v2_client.list_share_replicas("}],"source_content_type":"text/x-python","patch_set":5,"id":"c465cf12_8448beed","line":89,"range":{"start_line":84,"start_character":0,"end_line":89,"end_character":75},"updated":"2022-02-04 23:16:49.000000000","message":"To create a replica of a share, the share\u0027s type must have a \"replication_type\" extra-spec set. The share type associated with this class isn\u0027t requesting it; so this will fail. \n\nPlease see https://github.com/openstack/manila-tempest-plugin/blob/86f2432476ba9128bb2c26a78ae3b3f53327d4bd/manila_tempest_tests/tests/api/test_revert_to_snapshot.py#L159-L170 for an example of how to create:\n\n1) a share type that supports replication, based off of the \"backend_replication_type\" config parameter\n2) a share with that share type\n3) a share replica","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f447c657f32650ee81fbb9ae09148fd98c30657f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        scheduler_hint \u003d {\"only_host\": \"%s\" % backend_a}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # create share replica with hint"},{"line_number":84,"context_line":"        replica \u003d self.create_share_replica(self.share_a[\u0027id\u0027],"},{"line_number":85,"context_line":"                                            None,"},{"line_number":86,"context_line":"                                            cleanup_in_class\u003dFalse,"},{"line_number":87,"context_line":"                                            client\u003dself.admin_client,"},{"line_number":88,"context_line":"                                            version\u003dLATEST_MICROVERSION,"},{"line_number":89,"context_line":"                                            scheduler_hints\u003dscheduler_hint)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # get backend of share replica"},{"line_number":92,"context_line":"        replica \u003d self.admin_shares_v2_client.list_share_replicas("}],"source_content_type":"text/x-python","patch_set":5,"id":"5d53d6ef_e8bfb0a6","line":89,"range":{"start_line":84,"start_character":0,"end_line":89,"end_character":75},"in_reply_to":"c465cf12_8448beed","updated":"2022-02-05 06:42:26.000000000","message":"Done","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b1cc8f52097f4194ed5437c897a2cb5a3d59b34","unresolved":true,"context_lines":[{"line_number":89,"context_line":"                                            scheduler_hints\u003dscheduler_hint)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # get backend of share replica"},{"line_number":92,"context_line":"        replica \u003d self.admin_shares_v2_client.list_share_replicas("},{"line_number":93,"context_line":"            share_id\u003dshare_a[\u0027id\u0027])[\u0027share_replicas\u0027][-1]"},{"line_number":94,"context_line":"        backend_replica \u003d replica[\u0027host\u0027]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # verify same backends"}],"source_content_type":"text/x-python","patch_set":5,"id":"a18ff232_329074f1","line":93,"range":{"start_line":92,"start_character":18,"end_line":93,"end_character":57},"updated":"2022-02-04 23:16:49.000000000","message":"the call you need here is to the client\u0027s get_share_replica method: https://github.com/openstack/manila-tempest-plugin/blob/98b3e8782d20d193974173c5763236bb0478a289/manila_tempest_tests/services/share/v2/json/shares_client.py#L1547-L1557\n\nListing share replicas would include \"active\" and other replica (\"in-sync\" or \"out-of-sync\") copies -- so this wouldn\u0027t be a deterministic way to get information about the replica you just created","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f447c657f32650ee81fbb9ae09148fd98c30657f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                                            scheduler_hints\u003dscheduler_hint)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # get backend of share replica"},{"line_number":92,"context_line":"        replica \u003d self.admin_shares_v2_client.list_share_replicas("},{"line_number":93,"context_line":"            share_id\u003dshare_a[\u0027id\u0027])[\u0027share_replicas\u0027][-1]"},{"line_number":94,"context_line":"        backend_replica \u003d replica[\u0027host\u0027]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # verify same backends"}],"source_content_type":"text/x-python","patch_set":5,"id":"f6523e84_591200fe","line":93,"range":{"start_line":92,"start_character":18,"end_line":93,"end_character":57},"in_reply_to":"a18ff232_329074f1","updated":"2022-02-05 06:42:26.000000000","message":"Done","commit_id":"f6537f742e0aeb7f7efe16c5d16460307e7e789d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4482bbfb17121527aa6c5b8b093fcae75e2204bf","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                cls.share_network \u003d cls.shares_v2_client.get_share_network("},{"line_number":85,"context_line":"                    cls.shares_v2_client.share_network_id)[\u0027share_network\u0027]"},{"line_number":86,"context_line":"                cls.sn_id \u003d cls.share_network[\u0027id\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @decorators.idempotent_id(\u002754f4dea7-890e-443b-aea5-f6108da893f0\u0027)"},{"line_number":89,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":90,"context_line":"    def test_only_host_scheduler_hint_in_share_creation(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"6b2df1c2_00052ba2","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":0},"updated":"2022-02-08 00:15:01.000000000","message":"This got quite complicated... setting up resources in the class\u0027s resource_setup isn\u0027t always necessary - it makes things easier if you have multiple tests that can share some resources.. that isn\u0027t the case here - the share you\u0027re creating in the setup method is only being used by one of the tests.. it feels like you can make things more readable/simple if you created shares in the test - i.e., when you need them.. \n\nsuggestions in follow up comments below..","commit_id":"2b92e09e3725065a102a7b68604134d9c1b69733"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"50db0424cacd563166b045af588cd2651980904c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                cls.share_network \u003d cls.shares_v2_client.get_share_network("},{"line_number":85,"context_line":"                    cls.shares_v2_client.share_network_id)[\u0027share_network\u0027]"},{"line_number":86,"context_line":"                cls.sn_id \u003d cls.share_network[\u0027id\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @decorators.idempotent_id(\u002754f4dea7-890e-443b-aea5-f6108da893f0\u0027)"},{"line_number":89,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":90,"context_line":"    def test_only_host_scheduler_hint_in_share_creation(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"37636300_f732887d","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":0},"in_reply_to":"6b2df1c2_00052ba2","updated":"2022-02-12 04:59:55.000000000","message":"Ack","commit_id":"2b92e09e3725065a102a7b68604134d9c1b69733"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4482bbfb17121527aa6c5b8b093fcae75e2204bf","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    @decorators.idempotent_id(\u002754f4dea7-890e-443b-aea5-f6108da893f0\u0027)"},{"line_number":89,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":90,"context_line":"    def test_only_host_scheduler_hint_in_share_creation(self):"},{"line_number":91,"context_line":"        share_a \u003d self.admin_client.get_share(self.shares[0][\u0027id\u0027])[\u0027share\u0027]"},{"line_number":92,"context_line":"        backend_a \u003d share_a[\u0027host\u0027]"},{"line_number":93,"context_line":"        scheduler_hint \u003d {\"only_host\": \"%s\" % backend_a}"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"e1025fb3_2c6398c5","line":91,"range":{"start_line":91,"start_character":18,"end_line":91,"end_character":76},"updated":"2022-02-08 00:15:01.000000000","message":"share_a \u003d self.create_share(share_type_id\u003dself.share_type[\u0027id\u0027])\nshare_a \u003d self.admin_client.get_share(share_a[\u0027id\u0027])[\u0027share\u0027]","commit_id":"2b92e09e3725065a102a7b68604134d9c1b69733"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"50db0424cacd563166b045af588cd2651980904c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    @decorators.idempotent_id(\u002754f4dea7-890e-443b-aea5-f6108da893f0\u0027)"},{"line_number":89,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":90,"context_line":"    def test_only_host_scheduler_hint_in_share_creation(self):"},{"line_number":91,"context_line":"        share_a \u003d self.admin_client.get_share(self.shares[0][\u0027id\u0027])[\u0027share\u0027]"},{"line_number":92,"context_line":"        backend_a \u003d share_a[\u0027host\u0027]"},{"line_number":93,"context_line":"        scheduler_hint \u003d {\"only_host\": \"%s\" % backend_a}"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"d5e00327_0d537ae0","line":91,"range":{"start_line":91,"start_character":18,"end_line":91,"end_character":76},"in_reply_to":"e1025fb3_2c6398c5","updated":"2022-02-12 04:59:55.000000000","message":"Done","commit_id":"2b92e09e3725065a102a7b68604134d9c1b69733"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4482bbfb17121527aa6c5b8b093fcae75e2204bf","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    @tc.skipUnless(CONF.share.run_replication_tests,"},{"line_number":108,"context_line":"                   \u0027Replication tests are disabled.\u0027)"},{"line_number":109,"context_line":"    def test_only_host_scheduler_hint_in_share_replica_creation(self):"},{"line_number":110,"context_line":"        share \u003d self.create_share("},{"line_number":111,"context_line":"            share_type_id\u003dself.replicated_share_type[\u0027id\u0027],"},{"line_number":112,"context_line":"            availability_zone\u003dself.share_zone,"},{"line_number":113,"context_line":"            share_network_id\u003dself.sn_id"},{"line_number":114,"context_line":"        )"},{"line_number":115,"context_line":"        share \u003d self.admin_client.get_share(share[\u0027id\u0027])[\u0027share\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ca95c26_8e6033d8","line":112,"range":{"start_line":110,"start_character":8,"end_line":112,"end_character":46},"updated":"2022-02-08 00:15:01.000000000","message":"create the share type right here; and since this test is only executed if replication is enabled, you don\u0027t need any conditionals; also we don\u0027t need any other capabilities that we\u0027re not testing here.. \n\n\n        def test_only_host_scheduler_hint_in_share_replica_creation(self):\n            replication_type \u003d CONF.share.backend_replication_type\n            if replication_type not in constants.REPLICATION_TYPE_CHOICES:\n                raise share_exceptions.ShareReplicationTypeException(\n                    replication_type\u003dcls.replication_type\n                )\n            extra_specs \u003d cls.add_extra_specs_to_dict({\n                \"replication_type\": replication_type\n            })\n            replicated_share_type \u003d self.create_share_type(\n                data_utils.rand_name(\"replicated-shares\"),\n                extra_specs\u003dextra_specs)\n            share \u003d self.create_share(\n                 share_type_id\u003dself.replicated_share_type[\u0027id\u0027],\n                 cleanup_in_class\u003dFalse)\n            share \u003d self.admin_client.get_share(share[\u0027id\u0027])[\u0027share\u0027]\n            share_host \u003d share[\u0027host\u0027]\n\n            rep_domain, pools \u003d self.get_pools_for_replication_domain()\n            if len(pools) \u003c 2:\n               msg \u003d (\"Cannot test scheduler hints with replication due to insuffcient pools.\")\n            raise self.skipException(msg)\n    \n            for p in pools:\n               if p[\u0027name\u0027] !\u003d share_host:\n                expected_replica_host \u003d p[\u0027name\u0027]\n                scheduler_hint \u003d {\"only_host\": \"%s\" % backend_to_verify}\n                break\n\n           replica \u003d self.create_share_replica(share[\u0027id\u0027],\n                                            cleanup_in_class\u003dFalse,\n                                            version\u003dLATEST_MICROVERSION,\n                                            scheduler_hints\u003dscheduler_hint)\n           replica \u003d self.admin_client.get_share_replica(\n            replica[\u0027id\u0027])[\u0027share_replica\u0027]\n       \n           replica_host \u003d replica[\u0027host\u0027]\n\n            # verify same backends\n            self.assertEqual(expected_replica_host, actual_replica_host)","commit_id":"2b92e09e3725065a102a7b68604134d9c1b69733"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"50db0424cacd563166b045af588cd2651980904c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    @tc.skipUnless(CONF.share.run_replication_tests,"},{"line_number":108,"context_line":"                   \u0027Replication tests are disabled.\u0027)"},{"line_number":109,"context_line":"    def test_only_host_scheduler_hint_in_share_replica_creation(self):"},{"line_number":110,"context_line":"        share \u003d self.create_share("},{"line_number":111,"context_line":"            share_type_id\u003dself.replicated_share_type[\u0027id\u0027],"},{"line_number":112,"context_line":"            availability_zone\u003dself.share_zone,"},{"line_number":113,"context_line":"            share_network_id\u003dself.sn_id"},{"line_number":114,"context_line":"        )"},{"line_number":115,"context_line":"        share \u003d self.admin_client.get_share(share[\u0027id\u0027])[\u0027share\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"aee151ee_a7266371","line":112,"range":{"start_line":110,"start_character":8,"end_line":112,"end_character":46},"in_reply_to":"9ca95c26_8e6033d8","updated":"2022-02-12 04:59:55.000000000","message":"Done","commit_id":"2b92e09e3725065a102a7b68604134d9c1b69733"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46e9bafdf9b40c0b02cdebb8409caa45be102ab0","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    def resource_setup(cls):"},{"line_number":46,"context_line":"        super(SharesSchedulerHintsAdminTest, cls).resource_setup()"},{"line_number":47,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":48,"context_line":"        cls.replication_multitenancy \u003d ("},{"line_number":49,"context_line":"            utils.replication_with_multitenancy_support())"},{"line_number":50,"context_line":"        # create share type"},{"line_number":51,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":52,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"162fa966_70c773dd","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":58},"updated":"2022-02-14 23:46:38.000000000","message":"This isn\u0027t being used","commit_id":"03167dc5f41d94fe50a02c1c856af64d32aca057"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c2f1e28d30f02f5caf189d71f53eb6e93e6891bc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def resource_setup(cls):"},{"line_number":46,"context_line":"        super(SharesSchedulerHintsAdminTest, cls).resource_setup()"},{"line_number":47,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":48,"context_line":"        cls.replication_multitenancy \u003d ("},{"line_number":49,"context_line":"            utils.replication_with_multitenancy_support())"},{"line_number":50,"context_line":"        # create share type"},{"line_number":51,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":52,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"906da122_4e77582d","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":58},"in_reply_to":"162fa966_70c773dd","updated":"2022-02-24 11:38:30.000000000","message":"Done","commit_id":"03167dc5f41d94fe50a02c1c856af64d32aca057"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46e9bafdf9b40c0b02cdebb8409caa45be102ab0","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        share_host \u003d share[\u0027host\u0027]"},{"line_number":93,"context_line":"        rep_domain, pools \u003d self.get_pools_for_replication_domain(share\u003dshare)"},{"line_number":94,"context_line":"        if len(pools) \u003c 2:"},{"line_number":95,"context_line":"            msg \u003d (\"Can not create valid hint due to insuffcient pools.\")"},{"line_number":96,"context_line":"            raise self.skipException(msg)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        for p in pools:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fd45694e_31fff9fa","line":95,"range":{"start_line":95,"start_character":53,"end_line":95,"end_character":64},"updated":"2022-02-14 23:46:38.000000000","message":"insufficient","commit_id":"03167dc5f41d94fe50a02c1c856af64d32aca057"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c2f1e28d30f02f5caf189d71f53eb6e93e6891bc","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        share_host \u003d share[\u0027host\u0027]"},{"line_number":93,"context_line":"        rep_domain, pools \u003d self.get_pools_for_replication_domain(share\u003dshare)"},{"line_number":94,"context_line":"        if len(pools) \u003c 2:"},{"line_number":95,"context_line":"            msg \u003d (\"Can not create valid hint due to insuffcient pools.\")"},{"line_number":96,"context_line":"            raise self.skipException(msg)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        for p in pools:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5fd6f99d_2b502e92","line":95,"range":{"start_line":95,"start_character":53,"end_line":95,"end_character":64},"in_reply_to":"fd45694e_31fff9fa","updated":"2022-02-24 11:38:30.000000000","message":"Done","commit_id":"03167dc5f41d94fe50a02c1c856af64d32aca057"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cd6e53f230e5597906ec031c121f61a2480c8c91","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(cls):"},{"line_number":46,"context_line":"        super(SharesSchedulerHintsAdminTest, cls).resource_setup()"},{"line_number":47,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":48,"context_line":"        # create share type"},{"line_number":49,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":50,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"5c7d5179_88712512","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":53},"updated":"2022-02-16 09:27:32.000000000","message":"I know it appears in a lot of places in this project, but I don\u0027t understand why,\nwe can just call directly to cls.admin_shares_v2_client","commit_id":"ad4cfca444452fe370eddcd88d795c1baceaffa8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c2f1e28d30f02f5caf189d71f53eb6e93e6891bc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(cls):"},{"line_number":46,"context_line":"        super(SharesSchedulerHintsAdminTest, cls).resource_setup()"},{"line_number":47,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":48,"context_line":"        # create share type"},{"line_number":49,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":50,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"032ebf89_9f5b0583","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":53},"in_reply_to":"5c7d5179_88712512","updated":"2022-02-24 11:38:30.000000000","message":"Done","commit_id":"ad4cfca444452fe370eddcd88d795c1baceaffa8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cd6e53f230e5597906ec031c121f61a2480c8c91","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        super(SharesSchedulerHintsAdminTest, cls).resource_setup()"},{"line_number":47,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":48,"context_line":"        # create share type"},{"line_number":49,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":50,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002754f4dea7-890e-443b-aea5-f6108da893f0\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3550b24d_fcef4466","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":22},"updated":"2022-02-16 09:27:32.000000000","message":"You don\u0027t need a class variable here. A local variable would work.","commit_id":"ad4cfca444452fe370eddcd88d795c1baceaffa8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c2f1e28d30f02f5caf189d71f53eb6e93e6891bc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        super(SharesSchedulerHintsAdminTest, cls).resource_setup()"},{"line_number":47,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":48,"context_line":"        # create share type"},{"line_number":49,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":50,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002754f4dea7-890e-443b-aea5-f6108da893f0\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"b57aafa2_49823b0b","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":22},"in_reply_to":"3550b24d_fcef4466","updated":"2022-02-24 11:38:30.000000000","message":"Done","commit_id":"ad4cfca444452fe370eddcd88d795c1baceaffa8"}]}