)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"923f50f33a29fdcf443aec6b6522b98ba6f522de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4504d58f_3641ba04","updated":"2022-01-18 22:19:04.000000000","message":"LGTM; no loss of test coverage with this refactor. Thanks!","commit_id":"f88c2ab0490eb7103a5be9cd9e0fa5c40e4f8283"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"02daa70ba98a0218c66e7e358da78e9d1d6fb363","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7c2b310_dfd0998b","updated":"2022-01-19 09:26:53.000000000","message":"Thanks lkk for working on it!\nSorry, I don\u0027t agree with this approach.\nThese tests should remain separate.\nWe want to test two different actions: \"snapshot-reset-state\" and \"snapshot-force-delete\".\nIt\u0027s true that for proper testing \"snapshot-force-delete\" action we should change the state\nof the snapshot, but still we need to \"snapshot-reset-state\" separately.\nIn case of failure we want to get a specific indication for the failed action.\n\nI noticed that a negative test for snapshot deletion is missing.\nDeleting a snapshot when its stats is different from \u0027available\u0027 and \u0027error\u0027.\nIt would be great if you could add this test in this patch or in another patch.\n ","commit_id":"f88c2ab0490eb7103a5be9cd9e0fa5c40e4f8283"}],"manila_tempest_tests/tests/api/admin/test_admin_actions.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"02daa70ba98a0218c66e7e358da78e9d1d6fb363","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":128,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":129,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":130,"context_line":"    @ddt.data(\"error\", \"available\", \"error_deleting\", \"deleting\", \"creating\","},{"line_number":131,"context_line":"              \"migrating\", \"migrating_to\", \"server_migrating\")"},{"line_number":132,"context_line":"    def test_reset_and_force_delete_snapshot(self, status):"},{"line_number":133,"context_line":"        sn \u003d self.create_snapshot_wait_for_active(self.share[\"id\"])"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a56f1952_af5c72ce","line":131,"range":{"start_line":130,"start_character":0,"end_line":131,"end_character":62},"updated":"2022-01-19 09:26:53.000000000","message":"I do not know how necessary it is but I\u0027m fine with it.","commit_id":"f88c2ab0490eb7103a5be9cd9e0fa5c40e4f8283"}]}