)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1346b86f48777b0b9197193d85f9581a3d784aa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"58021ab5_26beaaf5","updated":"2022-01-11 20:36:39.000000000","message":"Thanks, this test looks sane; please take a look at the tag in the test though","commit_id":"528336bf19a000f9cd12a80b57d2ad25923d8f4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4da56b22f80213dcf1224a185d8372da8a6d6863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2868f66f_ba9b4efe","updated":"2022-01-12 20:43:56.000000000","message":"Thanks, the test case must be in a different class... ","commit_id":"a39a91cf0589bdacd7e21cc8c83a515c8cea0a8d"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"553fdbbae16d0089d4264a30bca53be33fc95a5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8864cf8b_a5cd4d00","updated":"2022-02-04 18:02:36.000000000","message":"LGTM.","commit_id":"69fcf8fea13a2b5609348fe5e530f7b01d28dd0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"54e5f3808f0727f8fe3d5e9c4beae59158efe584","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"88218fff_2df1130b","updated":"2022-01-13 07:13:17.000000000","message":"Thanks, LGTM!","commit_id":"69fcf8fea13a2b5609348fe5e530f7b01d28dd0b"}],"manila_tempest_tests/tests/api/test_shares_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1346b86f48777b0b9197193d85f9581a3d784aa0","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                          \"wrong_share_id\")"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @decorators.idempotent_id(\u00277642bdb1-1356-0a18-bf36-d3536be6a02e\u0027)"},{"line_number":244,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":245,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":246,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":247,"context_line":"    def test_create_snapshot_for_invalid_share(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ed2aeb0e_1fd8ad90","line":244,"range":{"start_line":244,"start_character":37,"end_line":244,"end_character":44},"updated":"2022-01-11 20:36:39.000000000","message":"TAG_API_WITH_BACKEND\n\n\nsince you\u0027re creating a share..","commit_id":"528336bf19a000f9cd12a80b57d2ad25923d8f4d"},{"author":{"_account_id":31280,"name":"lkk","email":"likangkang01@inspur.com","username":"likangkang"},"change_message_id":"6b0b7c8bfc58e8132917fbc62d0c8513a73a13c9","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                          \"wrong_share_id\")"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @decorators.idempotent_id(\u00277642bdb1-1356-0a18-bf36-d3536be6a02e\u0027)"},{"line_number":244,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":245,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":246,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":247,"context_line":"    def test_create_snapshot_for_invalid_share(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3db6891a_55d40167","line":244,"range":{"start_line":244,"start_character":37,"end_line":244,"end_character":44},"in_reply_to":"ed2aeb0e_1fd8ad90","updated":"2022-01-12 05:44:56.000000000","message":"Done","commit_id":"528336bf19a000f9cd12a80b57d2ad25923d8f4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4da56b22f80213dcf1224a185d8372da8a6d6863","unresolved":true,"context_lines":[{"line_number":145,"context_line":"        )"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class SharesAPIOnlyNegativeTest(base.BaseSharesMixedTest):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @classmethod"},{"line_number":151,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"b0e21767_877df3ef","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":58},"updated":"2022-01-12 20:43:56.000000000","message":"Hi, i missed this in my earlier review. This test class is named to only accommodate tests that don\u0027t need a backend... so ideally your test should be in the class above..","commit_id":"a39a91cf0589bdacd7e21cc8c83a515c8cea0a8d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"faa672ec2b76e4723ca61b27c57b7314011d352a","unresolved":true,"context_lines":[{"line_number":145,"context_line":"        )"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class SharesAPIOnlyNegativeTest(base.BaseSharesMixedTest):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @classmethod"},{"line_number":151,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3d9fd05c_60163205","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":58},"in_reply_to":"b0e21767_877df3ef","updated":"2022-02-06 08:00:31.000000000","message":"The test create a share resource, so the current location is fine.","commit_id":"a39a91cf0589bdacd7e21cc8c83a515c8cea0a8d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"faa672ec2b76e4723ca61b27c57b7314011d352a","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"},{"line_number":34,"context_line":"        super(SharesNegativeTest, cls).resource_setup()"},{"line_number":35,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":36,"context_line":"        # create share_type"},{"line_number":37,"context_line":"        extra_specs \u003d {}"},{"line_number":38,"context_line":"        if CONF.share.capability_snapshot_support:"}],"source_content_type":"text/x-python","patch_set":9,"id":"74ded157_97038774","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":53},"updated":"2022-02-06 08:00:31.000000000","message":"Please remove it, there is no need for that.","commit_id":"69fcf8fea13a2b5609348fe5e530f7b01d28dd0b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"faa672ec2b76e4723ca61b27c57b7314011d352a","unresolved":true,"context_lines":[{"line_number":153,"context_line":"        share \u003d self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":154,"context_line":"                                  cleanup_in_class\u003dFalse)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self.admin_client.reset_state(share[\"id\"],"},{"line_number":157,"context_line":"                                      status\u003dconstants.STATUS_ERROR,"},{"line_number":158,"context_line":"                                      s_type\u003d\"shares\")"},{"line_number":159,"context_line":"        self.addCleanup(self.admin_client.reset_state,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fd1ccd75_c4b049a4","line":156,"range":{"start_line":156,"start_character":13,"end_line":156,"end_character":25},"updated":"2022-02-06 08:00:31.000000000","message":"admin_shares_v2_client","commit_id":"69fcf8fea13a2b5609348fe5e530f7b01d28dd0b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"faa672ec2b76e4723ca61b27c57b7314011d352a","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        self.admin_client.reset_state(share[\"id\"],"},{"line_number":157,"context_line":"                                      status\u003dconstants.STATUS_ERROR,"},{"line_number":158,"context_line":"                                      s_type\u003d\"shares\")"},{"line_number":159,"context_line":"        self.addCleanup(self.admin_client.reset_state,"},{"line_number":160,"context_line":"                        share[\u0027id\u0027],"},{"line_number":161,"context_line":"                        status\u003dconstants.STATUS_AVAILABLE,"},{"line_number":162,"context_line":"                        s_type\u003d\u0027shares\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"44537752_8a1a2450","line":159,"range":{"start_line":159,"start_character":29,"end_line":159,"end_character":41},"updated":"2022-02-06 08:00:31.000000000","message":"admin_shares_v2_client","commit_id":"69fcf8fea13a2b5609348fe5e530f7b01d28dd0b"}]}
