)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functional tests for add multiple subnets feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds functional tests positives and negatives"},{"line_number":10,"context_line":"for the new feature add multiple subnets per az. Older"},{"line_number":11,"context_line":"functional tests impacted by the feature are fixed. Finally,"},{"line_number":12,"context_line":"the new flags `run_share_server_multiple_subnets_tests` and"},{"line_number":13,"context_line":"`run_network_allocation_update_tests` are added and configured"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"61139ed2_29df656e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"updated":"2022-03-02 21:54:22.000000000","message":"nit:\nThis change adds negative and positive functional tests...","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"eca05d5e4584c080fb899d6f2da07883a264e308","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functional tests for add multiple subnets feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds functional tests positives and negatives"},{"line_number":10,"context_line":"for the new feature add multiple subnets per az. Older"},{"line_number":11,"context_line":"functional tests impacted by the feature are fixed. Finally,"},{"line_number":12,"context_line":"the new flags `run_share_server_multiple_subnets_tests` and"},{"line_number":13,"context_line":"`run_network_allocation_update_tests` are added and configured"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"14288346_b7ea1502","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"61139ed2_29df656e","updated":"2022-03-03 14:27:41.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"af875745ed718e661a5643dd36e753b284bb4436","unresolved":true,"context_lines":[{"line_number":14,"context_line":"in the community jobs for Dummy DHSS\u003dTrue and Container Driver."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-Implements: blueprint multiple-share-network-subnets"},{"line_number":17,"context_line":"Depends-On: I7702f458f6bca5e3947479a13a843f30873597a7"},{"line_number":18,"context_line":"Depends-On: If5db09627a2a9a98951a972e15b8af0857598d1e"},{"line_number":19,"context_line":"Change-Id: I99547e1873646fb1494a454f67b14c7293342beb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"411c4ab0_ae6fd370","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":53},"updated":"2022-03-03 19:11:58.000000000","message":"you dont need python-manilaclient, right?","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"689f5691cddd0db5bd19f6f5b53c55fc8466e958","unresolved":false,"context_lines":[{"line_number":14,"context_line":"in the community jobs for Dummy DHSS\u003dTrue and Container Driver."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-Implements: blueprint multiple-share-network-subnets"},{"line_number":17,"context_line":"Depends-On: I7702f458f6bca5e3947479a13a843f30873597a7"},{"line_number":18,"context_line":"Depends-On: If5db09627a2a9a98951a972e15b8af0857598d1e"},{"line_number":19,"context_line":"Change-Id: I99547e1873646fb1494a454f67b14c7293342beb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"02f67914_47a5883a","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":53},"in_reply_to":"411c4ab0_ae6fd370","updated":"2022-03-03 21:27:03.000000000","message":"Right, thanks Douglas.","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"af875745ed718e661a5643dd36e753b284bb4436","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-Implements: blueprint multiple-share-network-subnets"},{"line_number":17,"context_line":"Depends-On: I7702f458f6bca5e3947479a13a843f30873597a7"},{"line_number":18,"context_line":"Depends-On: If5db09627a2a9a98951a972e15b8af0857598d1e"},{"line_number":19,"context_line":"Change-Id: I99547e1873646fb1494a454f67b14c7293342beb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"8e89d5c6_12fb19c8","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":53},"updated":"2022-03-03 19:11:58.000000000","message":"please, add container back:\nI81a616b57c95508f30d872383f5c2d68718950d7","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"689f5691cddd0db5bd19f6f5b53c55fc8466e958","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-Implements: blueprint multiple-share-network-subnets"},{"line_number":17,"context_line":"Depends-On: I7702f458f6bca5e3947479a13a843f30873597a7"},{"line_number":18,"context_line":"Depends-On: If5db09627a2a9a98951a972e15b8af0857598d1e"},{"line_number":19,"context_line":"Change-Id: I99547e1873646fb1494a454f67b14c7293342beb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"f80f1994_7086e93e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":53},"in_reply_to":"8e89d5c6_12fb19c8","updated":"2022-03-03 21:27:03.000000000","message":"Done","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"540b1daa0507a79b85f82d006e3669797431d276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"561524bd_cd5016d9","updated":"2022-02-04 16:22:23.000000000","message":"recheck","commit_id":"5475242906263a326d89bb5034a83797086f087f"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"a53b56322600775ea2f80cfcb9a8d2f36d29efe0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"59977197_38f6adcc","updated":"2022-02-04 17:13:28.000000000","message":"recheck","commit_id":"5475242906263a326d89bb5034a83797086f087f"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"bd678b4e231a0fc0fc6c8f50d90963dd3cc6b1d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d87603e5_eb73c60e","updated":"2022-02-04 16:36:17.000000000","message":"recheck","commit_id":"5475242906263a326d89bb5034a83797086f087f"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"925ff29b8192b34168510c3e3885b9853e1eff55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0290b628_bbebbdc6","updated":"2022-02-10 13:47:40.000000000","message":"recheck","commit_id":"20c990d80d6531cf2e3937d9526dc27aee314543"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"3841aa5133af96db7fc37102cff63c2416e258ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"78aa99e3_8398011a","updated":"2022-02-11 13:41:17.000000000","message":"run-NetApp CI","commit_id":"20c990d80d6531cf2e3937d9526dc27aee314543"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"9464b838e6657771d34fe66b3b4b9c59bda017a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9626abbb_0d91d3cf","updated":"2022-02-13 22:36:50.000000000","message":"run-NetApp CI","commit_id":"b7fafd46539401142e42adbd35b59e286b2a74db"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"74104e7a448e306eb65f664cca8249e3a2314011","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9a28d5e6_1c71510f","updated":"2022-02-11 13:43:42.000000000","message":"run-NetApp CI","commit_id":"b7fafd46539401142e42adbd35b59e286b2a74db"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"0d4333427cf57c528d1e2fa7adecec22e0f580ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b38a99aa_55e70c2e","updated":"2022-02-11 19:35:19.000000000","message":"run-NetApp CI","commit_id":"b7fafd46539401142e42adbd35b59e286b2a74db"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"b5fd0df0bf53d43bb68252fe3bb65b18d8133d7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3b144665_e05e005c","updated":"2022-02-15 12:44:55.000000000","message":"run-NetApp CI","commit_id":"79602b06ce25815692bb42a4e2cbbcc74669f9c9"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"0af45bcf7866472b47064c17585ddb0ebd0e6b73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ac1f5039_af9aee81","updated":"2022-02-15 12:46:54.000000000","message":"run-NetApp CI","commit_id":"79602b06ce25815692bb42a4e2cbbcc74669f9c9"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"c58becd940f360d815042ccc684ef5de3cd3606c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b085c62d_33835e0e","updated":"2022-02-14 14:02:13.000000000","message":"run-NetApp CI","commit_id":"79602b06ce25815692bb42a4e2cbbcc74669f9c9"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"36b51423b119839244dfb044ca183befe0887a0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dc174b82_d2c06094","updated":"2022-02-15 12:53:09.000000000","message":"run-NetApp CI","commit_id":"79602b06ce25815692bb42a4e2cbbcc74669f9c9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9462b385_62e954d0","updated":"2022-02-23 20:56:21.000000000","message":"Thanks, few commens inline. \n/me still need to check drivers that are running those tests and see outputs. ","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"b9ca59487767abfdbd738dbb0d08032ff3677983","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0d02aaa3_675e45df","updated":"2022-02-16 13:48:26.000000000","message":"recheck","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"99709d10e538c69fe7e5730b916076293cb856da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"825b0e55_4677d8f2","updated":"2022-02-16 13:51:52.000000000","message":"run-NetApp CI","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"61259b193ed503842ed4543609e672f4318f76c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d0fe912b_ed55b784","in_reply_to":"9462b385_62e954d0","updated":"2022-02-28 22:48:17.000000000","message":"Hi Douglas, the tempest tests are passing in the drivers, including the NetApp driver. New share group tests and replica tests are tested only by dummy driver and NetApp driver, since the container driver doesn`t support those features.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7ea1b09f_abd0bb8e","updated":"2022-02-24 21:37:33.000000000","message":"Hi Douglas, thank you for the comments, most of them are addressed in the PS 10. Let\u0027s get more opinion about the two different capabilities in the tempest conf, and decided if we stay in that way or we should remove. Also, some new tempest tests are added in this PS to cover the new operation `share_network_subnet_create_check`.","commit_id":"603ee6f621fb2b3be1be426e339488ce258f83cb"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"45b892947c5fe80f3d675d1a4f8cbbb721e11d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"582bb384_0dee1fe0","updated":"2022-02-25 14:46:41.000000000","message":"Removing Container and NetApp drivers depends-on to test the new tempests with CORE patch (dummy driver). After solving the conflicts and comments in the drivers patches I will include back to test them with the new tempest.","commit_id":"a7061d9c24a807595437d8add791f16139439ba8"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"78ad7337190e640ba48d7ecfd1e7390731018dab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"96b72b83_a919378b","updated":"2022-02-25 17:11:21.000000000","message":"recheck","commit_id":"3e71ae075c65bf89cb4383f5783127b160b3d07d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"591141e648b6d2668b121d2d53962668ec46b621","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1ebefbd7_1335a208","updated":"2022-03-02 21:02:47.000000000","message":"Please see comments inline. Thanks for updating.","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9e568621_c73c268e","updated":"2022-03-02 21:54:22.000000000","message":"Thanks for working on this change, André\nFew comments inline, please check them","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"dde74d3c01efb055e0715ad22372302fdfef3dd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e1cc0d6e_157b2cae","updated":"2022-02-26 15:25:20.000000000","message":"recheck","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"2ea1c5a0c98db7a27f13bcdedc104fb5f07e6b06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"372de2ca_c90c14ab","updated":"2022-02-26 12:18:05.000000000","message":"run-NetApp CI","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"8fb7ae9f6f64bc5be6e1a492b0ce8694e9e07587","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b82eb40b_2c8a63ae","updated":"2022-03-02 10:51:53.000000000","message":"run-NetApp CI","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5354a81ade0967b7c3e04eaaffbe6d6c0d3bf223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ec76dab3_971c88e1","updated":"2022-02-28 17:45:07.000000000","message":"run-NetApp CI","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7e22ba6e_00e375fa","updated":"2022-03-02 23:47:22.000000000","message":"Hi Douglas and Carlos thank you for the comments.","commit_id":"fd8181aa2d4ea4588321b7fa1c27eb1bbbd09d75"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"fc0cb40a28f2a2ef9b5a2557ca91ea3ede3575fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"67e209d7_fbc42979","updated":"2022-03-03 03:06:46.000000000","message":"run-NetApp CI","commit_id":"fd8181aa2d4ea4588321b7fa1c27eb1bbbd09d75"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"baefb28c716a2f2131e96fc3456ce57243b13135","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c5436f34_2d8311a1","updated":"2022-03-03 11:53:59.000000000","message":"run-NetApp CI","commit_id":"3ef6227f69e043a03d8d4c2e0cf9c0c6d4da81e5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"48e4b72cf5b96a1870352ddff799da7cf35cd7cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d3ae44fc_4fc1664a","updated":"2022-03-03 18:55:02.000000000","message":"Thanks Andre, just a small issue from my point of view. Otherwise, lgtm.","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"15c7da1a5812da679d7aed22950f52ed1d144ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"588c124b_f554ad01","updated":"2022-03-03 19:02:19.000000000","message":"recheck","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"beb66126a3b8fbd643a635680b4500ea968e7f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"08445780_9846ca05","updated":"2022-03-03 15:35:51.000000000","message":"run-NetApp CI","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"a5d94c40f2d06de642083c51543bcaa6067813ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5d583ba7_331f511f","updated":"2022-03-03 15:01:01.000000000","message":"run-NetApp CI","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"157d75fd2c59050a3616a97d7928b4fd41272d9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"849e445f_26be9db7","updated":"2022-03-03 14:29:51.000000000","message":"run-NetApp CI","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"4b00e7e49cd7b0ee88fc096f8d641eaa64e9a57b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a8c5ecde_e5d54698","updated":"2022-03-03 16:17:36.000000000","message":"run-NetApp CI","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"adac7dfc1c4e0ed7979819fc9cfb6b3bc710a7f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e8193e59_5d3eba12","updated":"2022-03-03 21:34:14.000000000","message":"This LGTM, waiting more CI results, thanks","commit_id":"073417b4ebe3e1cb0ba6c2c0eca4e364341fd4ac"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4bf2fbfbff45449d88b16bf23d78846d4ae00f6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e84a7a3d_6196799e","updated":"2022-03-04 21:09:47.000000000","message":"Two comments, but nothing major\nThanks, André","commit_id":"073417b4ebe3e1cb0ba6c2c0eca4e364341fd4ac"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"0f8175b89a9d793fda7e557c9b3cfbef8b63f16b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c61e465e_2c78b813","updated":"2022-03-04 00:33:45.000000000","message":"recheck","commit_id":"073417b4ebe3e1cb0ba6c2c0eca4e364341fd4ac"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"08ea4fb0a40539abda2089f47367d8044ca9ea59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f710eb67_a00ec408","updated":"2022-03-04 04:42:45.000000000","message":"recheck","commit_id":"073417b4ebe3e1cb0ba6c2c0eca4e364341fd4ac"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5db7ca720e8503684f949c43abdad1b978c68754","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"dbfbcce0_7b142e7d","updated":"2022-03-03 21:29:18.000000000","message":"run-NetApp CI","commit_id":"073417b4ebe3e1cb0ba6c2c0eca4e364341fd4ac"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f5de56744b4f86f71730dba550c4b79cd4993b88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"49ab97df_68741d82","updated":"2022-03-15 20:46:52.000000000","message":"LGTM, thanks!","commit_id":"c1a3c0e54e675380ec85f8092527981efa8ce078"}],"manila_tempest_tests/common/waiters.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"591141e648b6d2668b121d2d53962668ec46b621","unresolved":true,"context_lines":[{"line_number":236,"context_line":"            availability_zone\u003davailability_zone)"},{"line_number":237,"context_line":"        if result[\u0027compatible\u0027]:"},{"line_number":238,"context_line":"            break"},{"line_number":239,"context_line":"        elif int(time.time()) - start \u003e\u003d client.build_timeout or not ("},{"line_number":240,"context_line":"                result[\u0027compatible\u0027]):"},{"line_number":241,"context_line":"            message \u003d (\u0027Subnet create check failed within the \u0027"},{"line_number":242,"context_line":"                       \u0027required time %(timeout)s for share network \u0027"},{"line_number":243,"context_line":"                       \u0027%(share_network)s.\u0027 % {"}],"source_content_type":"text/x-python","patch_set":13,"id":"67380689_2d4578bc","line":240,"range":{"start_line":239,"start_character":64,"end_line":240,"end_character":36},"updated":"2022-03-02 21:02:47.000000000","message":"or result[\u0027compatible\u0027] \u003d\u003d False\n\nsince:\n\u003e\u003e\u003e not None\nTrue\n\nisn\u0027t None the results while hosts are still processing the request?","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":236,"context_line":"            availability_zone\u003davailability_zone)"},{"line_number":237,"context_line":"        if result[\u0027compatible\u0027]:"},{"line_number":238,"context_line":"            break"},{"line_number":239,"context_line":"        elif int(time.time()) - start \u003e\u003d client.build_timeout or not ("},{"line_number":240,"context_line":"                result[\u0027compatible\u0027]):"},{"line_number":241,"context_line":"            message \u003d (\u0027Subnet create check failed within the \u0027"},{"line_number":242,"context_line":"                       \u0027required time %(timeout)s for share network \u0027"},{"line_number":243,"context_line":"                       \u0027%(share_network)s.\u0027 % {"}],"source_content_type":"text/x-python","patch_set":13,"id":"da8215b0_7611fe8e","line":240,"range":{"start_line":239,"start_character":64,"end_line":240,"end_character":36},"in_reply_to":"67380689_2d4578bc","updated":"2022-03-02 21:54:22.000000000","message":"+1\nalso, shouldn\u0027t it be an `and not (result[\u0027compatible\u0027])`?","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            availability_zone\u003davailability_zone)"},{"line_number":237,"context_line":"        if result[\u0027compatible\u0027]:"},{"line_number":238,"context_line":"            break"},{"line_number":239,"context_line":"        elif int(time.time()) - start \u003e\u003d client.build_timeout or not ("},{"line_number":240,"context_line":"                result[\u0027compatible\u0027]):"},{"line_number":241,"context_line":"            message \u003d (\u0027Subnet create check failed within the \u0027"},{"line_number":242,"context_line":"                       \u0027required time %(timeout)s for share network \u0027"},{"line_number":243,"context_line":"                       \u0027%(share_network)s.\u0027 % {"}],"source_content_type":"text/x-python","patch_set":13,"id":"02e818e3_679ab104","line":240,"range":{"start_line":239,"start_character":64,"end_line":240,"end_character":36},"in_reply_to":"da8215b0_7611fe8e","updated":"2022-03-02 23:47:22.000000000","message":"Agree, I added the Douglas suggestion since the timeout can occur without failing the result[\u0027compatible\u0027], in worst scenarios.","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":239,"context_line":"        elif int(time.time()) - start \u003e\u003d client.build_timeout or not ("},{"line_number":240,"context_line":"                result[\u0027compatible\u0027]):"},{"line_number":241,"context_line":"            message \u003d (\u0027Subnet create check failed within the \u0027"},{"line_number":242,"context_line":"                       \u0027required time %(timeout)s for share network \u0027"},{"line_number":243,"context_line":"                       \u0027%(share_network)s.\u0027 % {"},{"line_number":244,"context_line":"                           \u0027timeout\u0027: client.build_timeout,"},{"line_number":245,"context_line":"                           \u0027share_network\u0027: share_network_id,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1288db_074bdfa7","line":242,"range":{"start_line":242,"start_character":38,"end_line":242,"end_character":49},"updated":"2022-03-02 21:54:22.000000000","message":"please add if its seconds, minutes or what measurement unit you\u0027re using here","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        elif int(time.time()) - start \u003e\u003d client.build_timeout or not ("},{"line_number":240,"context_line":"                result[\u0027compatible\u0027]):"},{"line_number":241,"context_line":"            message \u003d (\u0027Subnet create check failed within the \u0027"},{"line_number":242,"context_line":"                       \u0027required time %(timeout)s for share network \u0027"},{"line_number":243,"context_line":"                       \u0027%(share_network)s.\u0027 % {"},{"line_number":244,"context_line":"                           \u0027timeout\u0027: client.build_timeout,"},{"line_number":245,"context_line":"                           \u0027share_network\u0027: share_network_id,"}],"source_content_type":"text/x-python","patch_set":13,"id":"be09a325_b3913098","line":242,"range":{"start_line":242,"start_character":38,"end_line":242,"end_character":49},"in_reply_to":"fa1288db_074bdfa7","updated":"2022-03-02 23:47:22.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":214,"context_line":"                      \"ss_type:\u003cldap, kerberos or active_directory\u003e, \""},{"line_number":215,"context_line":"                      \"ss_dns_ip:value, ss_user:value, ss_password\u003dvalue, \""},{"line_number":216,"context_line":"                      \"ss_domain:value, ss_server:value\"),"},{"line_number":217,"context_line":"    cfg.BoolOpt(\"capability_share_server_multiple_subnet_support\","},{"line_number":218,"context_line":"                default\u003dFalse,"},{"line_number":219,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":220,"context_line":"                     \"capability called \u0027share_server_multiple_subnet_support\u0027\""},{"line_number":221,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":222,"context_line":"                     \"Defaults to value of other config option \""},{"line_number":223,"context_line":"                     \"\u0027run_share_server_multiple_subnets_tests\u0027.\"),"},{"line_number":224,"context_line":"    cfg.BoolOpt(\"capability_network_allocation_update_support\","},{"line_number":225,"context_line":"                default\u003dFalse,"},{"line_number":226,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":227,"context_line":"                     \"capability called \u0027network_allocation_update_support\u0027\""},{"line_number":228,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":229,"context_line":"                     \"Defaults to value of other config option \""},{"line_number":230,"context_line":"                     \"\u0027run_network_allocation_update_tests\u0027.\"),"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    # Switching ON/OFF test suites filtered by features"},{"line_number":233,"context_line":"    cfg.BoolOpt(\"run_quota_tests\","},{"line_number":234,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bca22e08_c98d584d","line":231,"range":{"start_line":217,"start_character":0,"end_line":231,"end_character":0},"updated":"2022-02-23 20:56:21.000000000","message":"After looking at all tests, I don\u0027t see why you need to create these options. There are test that must enable these capabilities in order to work, while negative tests may need to create share types with capabilities disabled to find the proper az. Please check if they are really needed. Thanks","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":214,"context_line":"                      \"ss_type:\u003cldap, kerberos or active_directory\u003e, \""},{"line_number":215,"context_line":"                      \"ss_dns_ip:value, ss_user:value, ss_password\u003dvalue, \""},{"line_number":216,"context_line":"                      \"ss_domain:value, ss_server:value\"),"},{"line_number":217,"context_line":"    cfg.BoolOpt(\"capability_share_server_multiple_subnet_support\","},{"line_number":218,"context_line":"                default\u003dFalse,"},{"line_number":219,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":220,"context_line":"                     \"capability called \u0027share_server_multiple_subnet_support\u0027\""},{"line_number":221,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":222,"context_line":"                     \"Defaults to value of other config option \""},{"line_number":223,"context_line":"                     \"\u0027run_share_server_multiple_subnets_tests\u0027.\"),"},{"line_number":224,"context_line":"    cfg.BoolOpt(\"capability_network_allocation_update_support\","},{"line_number":225,"context_line":"                default\u003dFalse,"},{"line_number":226,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":227,"context_line":"                     \"capability called \u0027network_allocation_update_support\u0027\""},{"line_number":228,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":229,"context_line":"                     \"Defaults to value of other config option \""},{"line_number":230,"context_line":"                     \"\u0027run_network_allocation_update_tests\u0027.\"),"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    # Switching ON/OFF test suites filtered by features"},{"line_number":233,"context_line":"    cfg.BoolOpt(\"run_quota_tests\","},{"line_number":234,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ae771e3e_ecc3c9f0","line":231,"range":{"start_line":217,"start_character":0,"end_line":231,"end_character":0},"in_reply_to":"816905fc_28d9a694","updated":"2022-03-02 21:54:22.000000000","message":"\u003e Don\u0027t you have \u0027run_share_server_multiple_subnets_tests\u0027 and \u0027run_network_allocation_update_tests\u0027 that already cover that scenario?\n\n++","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                      \"ss_type:\u003cldap, kerberos or active_directory\u003e, \""},{"line_number":215,"context_line":"                      \"ss_dns_ip:value, ss_user:value, ss_password\u003dvalue, \""},{"line_number":216,"context_line":"                      \"ss_domain:value, ss_server:value\"),"},{"line_number":217,"context_line":"    cfg.BoolOpt(\"capability_share_server_multiple_subnet_support\","},{"line_number":218,"context_line":"                default\u003dFalse,"},{"line_number":219,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":220,"context_line":"                     \"capability called \u0027share_server_multiple_subnet_support\u0027\""},{"line_number":221,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":222,"context_line":"                     \"Defaults to value of other config option \""},{"line_number":223,"context_line":"                     \"\u0027run_share_server_multiple_subnets_tests\u0027.\"),"},{"line_number":224,"context_line":"    cfg.BoolOpt(\"capability_network_allocation_update_support\","},{"line_number":225,"context_line":"                default\u003dFalse,"},{"line_number":226,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":227,"context_line":"                     \"capability called \u0027network_allocation_update_support\u0027\""},{"line_number":228,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":229,"context_line":"                     \"Defaults to value of other config option \""},{"line_number":230,"context_line":"                     \"\u0027run_network_allocation_update_tests\u0027.\"),"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    # Switching ON/OFF test suites filtered by features"},{"line_number":233,"context_line":"    cfg.BoolOpt(\"run_quota_tests\","},{"line_number":234,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1dff46d3_9e144f00","line":231,"range":{"start_line":217,"start_character":0,"end_line":231,"end_character":0},"in_reply_to":"ae771e3e_ecc3c9f0","updated":"2022-03-02 23:47:22.000000000","message":"You are right, I saw that some capabilities are being replaced by the run_bla_tests option. Thanks.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":true,"context_lines":[{"line_number":214,"context_line":"                      \"ss_type:\u003cldap, kerberos or active_directory\u003e, \""},{"line_number":215,"context_line":"                      \"ss_dns_ip:value, ss_user:value, ss_password\u003dvalue, \""},{"line_number":216,"context_line":"                      \"ss_domain:value, ss_server:value\"),"},{"line_number":217,"context_line":"    cfg.BoolOpt(\"capability_share_server_multiple_subnet_support\","},{"line_number":218,"context_line":"                default\u003dFalse,"},{"line_number":219,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":220,"context_line":"                     \"capability called \u0027share_server_multiple_subnet_support\u0027\""},{"line_number":221,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":222,"context_line":"                     \"Defaults to value of other config option \""},{"line_number":223,"context_line":"                     \"\u0027run_share_server_multiple_subnets_tests\u0027.\"),"},{"line_number":224,"context_line":"    cfg.BoolOpt(\"capability_network_allocation_update_support\","},{"line_number":225,"context_line":"                default\u003dFalse,"},{"line_number":226,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":227,"context_line":"                     \"capability called \u0027network_allocation_update_support\u0027\""},{"line_number":228,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":229,"context_line":"                     \"Defaults to value of other config option \""},{"line_number":230,"context_line":"                     \"\u0027run_network_allocation_update_tests\u0027.\"),"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    # Switching ON/OFF test suites filtered by features"},{"line_number":233,"context_line":"    cfg.BoolOpt(\"run_quota_tests\","},{"line_number":234,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"efbd43d8_5c59d77c","line":231,"range":{"start_line":217,"start_character":0,"end_line":231,"end_character":0},"in_reply_to":"bca22e08_c98d584d","updated":"2022-02-24 21:37:33.000000000","message":"I think you are right considering the tests and driver implementations proposed right now. However, we have two different features (multiple subnets support and network allocation update support), which means that maybe one day another vendor can implement only one of them, if so, to don\u0027t impact the tempest tests created now I created those two capabilities, then the CIs maintainers can have more flexibility. Today all the drivers (dummy, container and NetApp) implement both features. But, I can remove those capabilities if you or the community saw that is too much.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"591141e648b6d2668b121d2d53962668ec46b621","unresolved":true,"context_lines":[{"line_number":214,"context_line":"                      \"ss_type:\u003cldap, kerberos or active_directory\u003e, \""},{"line_number":215,"context_line":"                      \"ss_dns_ip:value, ss_user:value, ss_password\u003dvalue, \""},{"line_number":216,"context_line":"                      \"ss_domain:value, ss_server:value\"),"},{"line_number":217,"context_line":"    cfg.BoolOpt(\"capability_share_server_multiple_subnet_support\","},{"line_number":218,"context_line":"                default\u003dFalse,"},{"line_number":219,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":220,"context_line":"                     \"capability called \u0027share_server_multiple_subnet_support\u0027\""},{"line_number":221,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":222,"context_line":"                     \"Defaults to value of other config option \""},{"line_number":223,"context_line":"                     \"\u0027run_share_server_multiple_subnets_tests\u0027.\"),"},{"line_number":224,"context_line":"    cfg.BoolOpt(\"capability_network_allocation_update_support\","},{"line_number":225,"context_line":"                default\u003dFalse,"},{"line_number":226,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":227,"context_line":"                     \"capability called \u0027network_allocation_update_support\u0027\""},{"line_number":228,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":229,"context_line":"                     \"Defaults to value of other config option \""},{"line_number":230,"context_line":"                     \"\u0027run_network_allocation_update_tests\u0027.\"),"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    # Switching ON/OFF test suites filtered by features"},{"line_number":233,"context_line":"    cfg.BoolOpt(\"run_quota_tests\","},{"line_number":234,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"816905fc_28d9a694","line":231,"range":{"start_line":217,"start_character":0,"end_line":231,"end_character":0},"in_reply_to":"efbd43d8_5c59d77c","updated":"2022-03-02 21:02:47.000000000","message":"Don\u0027t you have \u0027run_share_server_multiple_subnets_tests\u0027 and \u0027run_network_allocation_update_tests\u0027 that already cover that scenario?","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":1968,"context_line":""},{"line_number":1969,"context_line":"        body \u003d json.dumps(body)"},{"line_number":1970,"context_line":"        resp, body \u003d self.post("},{"line_number":1971,"context_line":"            \u0027share-networks/%s/action\u0027 % share_network_id,"},{"line_number":1972,"context_line":"            body, headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1973,"context_line":"            version\u003dversion)"},{"line_number":1974,"context_line":"        self.expected_success(202, resp.status)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ce10c694_12a6b206","line":1971,"range":{"start_line":1971,"start_character":12,"end_line":1971,"end_character":57},"updated":"2022-03-02 21:54:22.000000000","message":"f\u0027share-networks/{share_network_id}/action\u0027\nF strings are more encouraged now and they make the code readability a bit better :)","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":1968,"context_line":""},{"line_number":1969,"context_line":"        body \u003d json.dumps(body)"},{"line_number":1970,"context_line":"        resp, body \u003d self.post("},{"line_number":1971,"context_line":"            \u0027share-networks/%s/action\u0027 % share_network_id,"},{"line_number":1972,"context_line":"            body, headers\u003dEXPERIMENTAL, extra_headers\u003dTrue,"},{"line_number":1973,"context_line":"            version\u003dversion)"},{"line_number":1974,"context_line":"        self.expected_success(202, resp.status)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba6d8fa5_b9d4ebe1","line":1971,"range":{"start_line":1971,"start_character":12,"end_line":1971,"end_character":57},"in_reply_to":"ce10c694_12a6b206","updated":"2022-03-02 23:47:22.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"}],"manila_tempest_tests/tests/api/admin/test_share_servers.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":196,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.49\"):"},{"line_number":197,"context_line":"            keys.append(\"is_auto_deletable\")"},{"line_number":198,"context_line":"            keys.append(\"identifier\")"},{"line_number":199,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.51\"):"},{"line_number":200,"context_line":"            keys.append(\"share_network_subnet_id\")"},{"line_number":201,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.70\"):"},{"line_number":202,"context_line":"            keys.remove(\"share_network_subnet_id\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"9d3d2f01_9c97b8b1","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":77},"updated":"2022-03-02 21:54:22.000000000","message":"I think you could add a comparison here as well ans check both if api version is bigger than 2.51 and smaller than 2.70. In that way you\u0027d avoid removing the key right after in the statement below.","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.49\"):"},{"line_number":197,"context_line":"            keys.append(\"is_auto_deletable\")"},{"line_number":198,"context_line":"            keys.append(\"identifier\")"},{"line_number":199,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.51\"):"},{"line_number":200,"context_line":"            keys.append(\"share_network_subnet_id\")"},{"line_number":201,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \"2.70\"):"},{"line_number":202,"context_line":"            keys.remove(\"share_network_subnet_id\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"374470ca_5700a45b","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":77},"in_reply_to":"9d3d2f01_9c97b8b1","updated":"2022-03-02 23:47:22.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"}],"manila_tempest_tests/tests/api/admin/test_share_servers_manage.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            msg \u003d (\"Manage share server with share network subnet is \""},{"line_number":67,"context_line":"                   \"supported starting from microversion \u00272.51\u0027.\")"},{"line_number":68,"context_line":"            raise self.skipException(msg)"},{"line_number":69,"context_line":"        check_multiple_subnet \u003d utils.is_microversion_ge("},{"line_number":70,"context_line":"            CONF.share.max_api_microversion, \u00272.70\u0027)"},{"line_number":71,"context_line":"        if check_multiple_subnet:"},{"line_number":72,"context_line":"            network_subnet \u003d \u0027share_network_subnet_ids\u0027"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            network_subnet \u003d \u0027share_network_subnet_id\u0027"},{"line_number":75,"context_line":"        # create a new share network to make sure that a new share server"},{"line_number":76,"context_line":"        # will be created"},{"line_number":77,"context_line":"        original_share_network \u003d self.shares_v2_client.get_share_network("}],"source_content_type":"text/x-python","patch_set":13,"id":"525bad0d_59f80bfc","line":74,"range":{"start_line":69,"start_character":8,"end_line":74,"end_character":54},"updated":"2022-03-02 21:54:22.000000000","message":"nit: this could be turned into a ddt...\n@ddt.data(\n    (True,\u00272.51\u0027, \u0027share_network_subnet_id\u0027),\n    (True,\u00272.70\u0027, \u0027share_network_subnet_ids\u0027),\n)\n@ddt.unpack\ndef test_manage_share_server(self, add_subnet_field, microversion, subnet_field_name):\n...\n\nThis way you\u0027d avoid this if/else attributions","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            msg \u003d (\"Manage share server with share network subnet is \""},{"line_number":67,"context_line":"                   \"supported starting from microversion \u00272.51\u0027.\")"},{"line_number":68,"context_line":"            raise self.skipException(msg)"},{"line_number":69,"context_line":"        check_multiple_subnet \u003d utils.is_microversion_ge("},{"line_number":70,"context_line":"            CONF.share.max_api_microversion, \u00272.70\u0027)"},{"line_number":71,"context_line":"        if check_multiple_subnet:"},{"line_number":72,"context_line":"            network_subnet \u003d \u0027share_network_subnet_ids\u0027"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            network_subnet \u003d \u0027share_network_subnet_id\u0027"},{"line_number":75,"context_line":"        # create a new share network to make sure that a new share server"},{"line_number":76,"context_line":"        # will be created"},{"line_number":77,"context_line":"        original_share_network \u003d self.shares_v2_client.get_share_network("}],"source_content_type":"text/x-python","patch_set":13,"id":"c79b9daa_c3b80705","line":74,"range":{"start_line":69,"start_character":8,"end_line":74,"end_character":54},"in_reply_to":"525bad0d_59f80bfc","updated":"2022-03-02 23:47:22.000000000","message":"I agree, however we will need to include the add_subnet_field False also to don\u0027t change the old behavior. Will be necessary create (False, \u00272.51\u0027, \u0027share_network_subnet_id\u0027) (False, \u00272.70\u0027, \u0027share_network_subnet_ids\u0027) or (False, None, None) since the subnet field will not be checked if the first value was False. In my opinion, this option will increase the complexity of the test, WDYT?","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"10c8d1fe309027008a5d380402f7e816c4e7ad82","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            msg \u003d (\"Manage share server with share network subnet is \""},{"line_number":67,"context_line":"                   \"supported starting from microversion \u00272.51\u0027.\")"},{"line_number":68,"context_line":"            raise self.skipException(msg)"},{"line_number":69,"context_line":"        check_multiple_subnet \u003d utils.is_microversion_ge("},{"line_number":70,"context_line":"            CONF.share.max_api_microversion, \u00272.70\u0027)"},{"line_number":71,"context_line":"        if check_multiple_subnet:"},{"line_number":72,"context_line":"            network_subnet \u003d \u0027share_network_subnet_ids\u0027"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            network_subnet \u003d \u0027share_network_subnet_id\u0027"},{"line_number":75,"context_line":"        # create a new share network to make sure that a new share server"},{"line_number":76,"context_line":"        # will be created"},{"line_number":77,"context_line":"        original_share_network \u003d self.shares_v2_client.get_share_network("}],"source_content_type":"text/x-python","patch_set":13,"id":"127ee393_5c69cb8b","line":74,"range":{"start_line":69,"start_character":8,"end_line":74,"end_character":54},"in_reply_to":"c79b9daa_c3b80705","updated":"2022-03-11 22:35:39.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        self.assertIs(True, share_server[\"is_auto_deletable\"])"},{"line_number":135,"context_line":"        self.assertIsNotNone(share_server[\"identifier\"])"},{"line_number":136,"context_line":"        if add_subnet_field:"},{"line_number":137,"context_line":"            self.assertIn(az_subnet[\"id\"],"},{"line_number":138,"context_line":"                          share_server[network_subnet])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self._unmanage_share_and_wait(share)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1251ea2d_52d3fea7","line":137,"range":{"start_line":137,"start_character":17,"end_line":137,"end_character":25},"updated":"2022-03-02 21:54:22.000000000","message":"assertIn or assertEqual are going to depend on the version, right?","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        self.assertIs(True, share_server[\"is_auto_deletable\"])"},{"line_number":135,"context_line":"        self.assertIsNotNone(share_server[\"identifier\"])"},{"line_number":136,"context_line":"        if add_subnet_field:"},{"line_number":137,"context_line":"            self.assertIn(az_subnet[\"id\"],"},{"line_number":138,"context_line":"                          share_server[network_subnet])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self._unmanage_share_and_wait(share)"}],"source_content_type":"text/x-python","patch_set":13,"id":"937c8747_f175720a","line":137,"range":{"start_line":137,"start_character":17,"end_line":137,"end_character":25},"in_reply_to":"1251ea2d_52d3fea7","updated":"2022-03-02 23:47:22.000000000","message":"Right...","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"}],"manila_tempest_tests/tests/api/test_replication.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        extra_specs \u003d {"},{"line_number":203,"context_line":"            \"replication_type\": self.replication_type,"},{"line_number":204,"context_line":"            \"driver_handles_share_servers\": CONF.share.multitenancy_enabled,"},{"line_number":205,"context_line":"            \"share_server_multiple_subnet_support\":"},{"line_number":206,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support"},{"line_number":207,"context_line":"        }"},{"line_number":208,"context_line":"        share_type \u003d self.create_share_type("}],"source_content_type":"text/x-python","patch_set":9,"id":"120df16b_23114d80","line":205,"range":{"start_line":205,"start_character":13,"end_line":205,"end_character":50},"updated":"2022-02-23 20:56:21.000000000","message":"shouldn\u0027t be always True for this test? why do you need a config?","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        extra_specs \u003d {"},{"line_number":203,"context_line":"            \"replication_type\": self.replication_type,"},{"line_number":204,"context_line":"            \"driver_handles_share_servers\": CONF.share.multitenancy_enabled,"},{"line_number":205,"context_line":"            \"share_server_multiple_subnet_support\":"},{"line_number":206,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support"},{"line_number":207,"context_line":"        }"},{"line_number":208,"context_line":"        share_type \u003d self.create_share_type("}],"source_content_type":"text/x-python","patch_set":9,"id":"c8e43560_634da4ff","line":205,"range":{"start_line":205,"start_character":13,"end_line":205,"end_character":50},"in_reply_to":"120df16b_23114d80","updated":"2022-02-24 21:37:33.000000000","message":"Yes. But if we decided to stay with the capabilities options this can be got from capabilities. Otherwise, we can add a fixed True.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        extra_specs \u003d {"},{"line_number":203,"context_line":"            \"replication_type\": self.replication_type,"},{"line_number":204,"context_line":"            \"driver_handles_share_servers\": CONF.share.multitenancy_enabled,"},{"line_number":205,"context_line":"            \"share_server_multiple_subnet_support\":"},{"line_number":206,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support"},{"line_number":207,"context_line":"        }"},{"line_number":208,"context_line":"        share_type \u003d self.create_share_type("}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac9a8de_04db6028","line":205,"range":{"start_line":205,"start_character":13,"end_line":205,"end_character":50},"in_reply_to":"609f8dd0_662046fa","updated":"2022-03-02 23:47:22.000000000","message":"Done","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"591141e648b6d2668b121d2d53962668ec46b621","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        extra_specs \u003d {"},{"line_number":203,"context_line":"            \"replication_type\": self.replication_type,"},{"line_number":204,"context_line":"            \"driver_handles_share_servers\": CONF.share.multitenancy_enabled,"},{"line_number":205,"context_line":"            \"share_server_multiple_subnet_support\":"},{"line_number":206,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support"},{"line_number":207,"context_line":"        }"},{"line_number":208,"context_line":"        share_type \u003d self.create_share_type("}],"source_content_type":"text/x-python","patch_set":9,"id":"609f8dd0_662046fa","line":205,"range":{"start_line":205,"start_character":13,"end_line":205,"end_character":50},"in_reply_to":"c8e43560_634da4ff","updated":"2022-03-02 21:02:47.000000000","message":"IMHO, make no sense read it from capabilities, if this is not set to True, the test will fail. What is the purpose of this capability then?","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":266,"context_line":"            \"replication_type\": self.replication_type,"},{"line_number":267,"context_line":"            \"driver_handles_share_servers\": CONF.share.multitenancy_enabled,"},{"line_number":268,"context_line":"            \"network_allocation_update_support\":"},{"line_number":269,"context_line":"                CONF.share.capability_network_allocation_update_support,"},{"line_number":270,"context_line":"        }"},{"line_number":271,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"16231f78_80145d8c","line":269,"range":{"start_line":269,"start_character":27,"end_line":269,"end_character":71},"updated":"2022-02-23 20:56:21.000000000","message":"same question as before.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"c54e60ad51d47621b3f6924def14517d33c362e0","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            \"replication_type\": self.replication_type,"},{"line_number":267,"context_line":"            \"driver_handles_share_servers\": CONF.share.multitenancy_enabled,"},{"line_number":268,"context_line":"            \"network_allocation_update_support\":"},{"line_number":269,"context_line":"                CONF.share.capability_network_allocation_update_support,"},{"line_number":270,"context_line":"        }"},{"line_number":271,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"e93e4194_c0a3c670","line":269,"range":{"start_line":269,"start_character":27,"end_line":269,"end_character":71},"in_reply_to":"0f8ee523_3f1af437","updated":"2022-03-03 18:13:15.000000000","message":"Done","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":true,"context_lines":[{"line_number":266,"context_line":"            \"replication_type\": self.replication_type,"},{"line_number":267,"context_line":"            \"driver_handles_share_servers\": CONF.share.multitenancy_enabled,"},{"line_number":268,"context_line":"            \"network_allocation_update_support\":"},{"line_number":269,"context_line":"                CONF.share.capability_network_allocation_update_support,"},{"line_number":270,"context_line":"        }"},{"line_number":271,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"0f8ee523_3f1af437","line":269,"range":{"start_line":269,"start_character":27,"end_line":269,"end_character":71},"in_reply_to":"16231f78_80145d8c","updated":"2022-02-24 21:37:33.000000000","message":"Same as above.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        \"Share server multiple subnet tests are disabled.\")"},{"line_number":196,"context_line":"    @testtools.skipIf(CONF.share.share_network_id !\u003d \"\","},{"line_number":197,"context_line":"                      \"This test is not suitable for pre-existing \""},{"line_number":198,"context_line":"                      \"share_network.\")"},{"line_number":199,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.70\")"},{"line_number":200,"context_line":"    @decorators.idempotent_id(\u00274235e789-dbd6-47a8-8f2e-d70edf78e532\u0027)"},{"line_number":201,"context_line":"    def test_add_delete_share_replica_multiple_subnets(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"cebb4c33_d69c6d17","line":198,"range":{"start_line":198,"start_character":23,"end_line":198,"end_character":36},"updated":"2022-03-02 21:54:22.000000000","message":"share networks.","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        \"Share server multiple subnet tests are disabled.\")"},{"line_number":196,"context_line":"    @testtools.skipIf(CONF.share.share_network_id !\u003d \"\","},{"line_number":197,"context_line":"                      \"This test is not suitable for pre-existing \""},{"line_number":198,"context_line":"                      \"share_network.\")"},{"line_number":199,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.70\")"},{"line_number":200,"context_line":"    @decorators.idempotent_id(\u00274235e789-dbd6-47a8-8f2e-d70edf78e532\u0027)"},{"line_number":201,"context_line":"    def test_add_delete_share_replica_multiple_subnets(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"16b10342_0a592e42","line":198,"range":{"start_line":198,"start_character":23,"end_line":198,"end_character":36},"in_reply_to":"cebb4c33_d69c6d17","updated":"2022-03-02 23:47:22.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":294,"context_line":"        replica \u003d self.admin_client.get_share_replica("},{"line_number":295,"context_line":"            replica[\u0027id\u0027])[\u0027share_replica\u0027]"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        # A new waiter was added in 2.70 to wait the share network subnet"},{"line_number":298,"context_line":"        # create check result"},{"line_number":299,"context_line":"        waiters.wait_for_subnet_create_check("},{"line_number":300,"context_line":"            self.shares_v2_client, new_share_network_id,"},{"line_number":301,"context_line":"            neutron_net_id\u003dsubnet_data[\u0027neutron_net_id\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"628cdc83_81114d16","line":298,"range":{"start_line":297,"start_character":10,"end_line":298,"end_character":29},"updated":"2022-03-02 21:54:22.000000000","message":"waits until the check is completed and positive","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        replica \u003d self.admin_client.get_share_replica("},{"line_number":295,"context_line":"            replica[\u0027id\u0027])[\u0027share_replica\u0027]"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        # A new waiter was added in 2.70 to wait the share network subnet"},{"line_number":298,"context_line":"        # create check result"},{"line_number":299,"context_line":"        waiters.wait_for_subnet_create_check("},{"line_number":300,"context_line":"            self.shares_v2_client, new_share_network_id,"},{"line_number":301,"context_line":"            neutron_net_id\u003dsubnet_data[\u0027neutron_net_id\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"ca939421_cdb62e16","line":298,"range":{"start_line":297,"start_character":10,"end_line":298,"end_character":29},"in_reply_to":"628cdc83_81114d16","updated":"2022-03-02 23:47:22.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4bf2fbfbff45449d88b16bf23d78846d4ae00f6d","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        replica \u003d self.admin_client.get_share_replica("},{"line_number":295,"context_line":"            replica[\u0027id\u0027])[\u0027share_replica\u0027]"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        # A new waiter was added in 2.70 to wait the share network subnet"},{"line_number":298,"context_line":"        # create check result"},{"line_number":299,"context_line":"        waiters.wait_for_subnet_create_check("},{"line_number":300,"context_line":"            self.shares_v2_client, new_share_network_id,"},{"line_number":301,"context_line":"            neutron_net_id\u003dsubnet_data[\u0027neutron_net_id\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"dd1e4090_c0cd9625","line":298,"range":{"start_line":297,"start_character":10,"end_line":298,"end_character":29},"in_reply_to":"ca939421_cdb62e16","updated":"2022-03-04 21:09:47.000000000","message":"I think the idea here was to replace the entire sentence by the suggested :)\nBut that\u0027s fine","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"}],"manila_tempest_tests/tests/api/test_share_groups.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":285,"context_line":"                \u0027Network allocation update tests are disabled.\u0027)"},{"line_number":286,"context_line":"        extra_specs \u003d {"},{"line_number":287,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":288,"context_line":"            \u0027share_server_multiple_subnet_support\u0027:"},{"line_number":289,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support,"},{"line_number":290,"context_line":"            \u0027network_allocation_update_support\u0027:"},{"line_number":291,"context_line":"                CONF.share.capability_network_allocation_update_support,"},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":294,"context_line":"        sg_type_name \u003d data_utils.rand_name(\"tempest-manila\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"9e3f6be0_df058023","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":72},"updated":"2022-02-23 20:56:21.000000000","message":"always need to be True since you need to filter azs that match share type, right?","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"591141e648b6d2668b121d2d53962668ec46b621","unresolved":true,"context_lines":[{"line_number":285,"context_line":"                \u0027Network allocation update tests are disabled.\u0027)"},{"line_number":286,"context_line":"        extra_specs \u003d {"},{"line_number":287,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":288,"context_line":"            \u0027share_server_multiple_subnet_support\u0027:"},{"line_number":289,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support,"},{"line_number":290,"context_line":"            \u0027network_allocation_update_support\u0027:"},{"line_number":291,"context_line":"                CONF.share.capability_network_allocation_update_support,"},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":294,"context_line":"        sg_type_name \u003d data_utils.rand_name(\"tempest-manila\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"6bfc6d6b_3321d2e9","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":72},"in_reply_to":"5e6cfc33_a3c0c186","updated":"2022-03-02 21:02:47.000000000","message":"My bad, share_server_multiple_subnet_support is always True, but network_allocation_update_support should be equal to \u0027network_allocation_update\u0027\n--\nYou already skip those tests when \u0027CONF.share.run_network_allocation_update_tests\u0027 is set or not (line 282). So again, you don\u0027t need a capability option, you are making it more complicated than needed.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                \u0027Network allocation update tests are disabled.\u0027)"},{"line_number":286,"context_line":"        extra_specs \u003d {"},{"line_number":287,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":288,"context_line":"            \u0027share_server_multiple_subnet_support\u0027:"},{"line_number":289,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support,"},{"line_number":290,"context_line":"            \u0027network_allocation_update_support\u0027:"},{"line_number":291,"context_line":"                CONF.share.capability_network_allocation_update_support,"},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":294,"context_line":"        sg_type_name \u003d data_utils.rand_name(\"tempest-manila\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f6da345_1b8b5fee","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":72},"in_reply_to":"6bfc6d6b_3321d2e9","updated":"2022-03-02 23:47:22.000000000","message":"Done","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":true,"context_lines":[{"line_number":285,"context_line":"                \u0027Network allocation update tests are disabled.\u0027)"},{"line_number":286,"context_line":"        extra_specs \u003d {"},{"line_number":287,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":288,"context_line":"            \u0027share_server_multiple_subnet_support\u0027:"},{"line_number":289,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support,"},{"line_number":290,"context_line":"            \u0027network_allocation_update_support\u0027:"},{"line_number":291,"context_line":"                CONF.share.capability_network_allocation_update_support,"},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":294,"context_line":"        sg_type_name \u003d data_utils.rand_name(\"tempest-manila\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"5e6cfc33_a3c0c186","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":72},"in_reply_to":"9e3f6be0_df058023","updated":"2022-02-24 21:37:33.000000000","message":"Right now yes, but as I commented above, suppose that a vendor implements only one of them (share server multiple subnets), they can enable the share_server_multiple_subnet capability and the run_share_server_multiple_subnets_tests, and easily disable the two tempest confs about the network allocation update support.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8113c164_f710ba2f","line":390,"updated":"2022-02-23 20:56:21.000000000","message":"/me hope that cleanup method deletes the remaining resources","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"61259b193ed503842ed4543609e672f4318f76c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1b8cd957_7f04de80","line":390,"in_reply_to":"8113c164_f710ba2f","updated":"2022-02-28 22:48:17.000000000","message":"I suppose it\u0027s working in the CIs, I also tested using my dev environment.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":300,"context_line":"        azs \u003d self.get_availability_zones_matching_share_type(share_type)"},{"line_number":301,"context_line":"        if len(azs) \u003d\u003d 0:"},{"line_number":302,"context_line":"            raise self.skipException("},{"line_number":303,"context_line":"                \"Could not find the necessary az. At least one az is needed \""},{"line_number":304,"context_line":"                \"to run this test.\")"},{"line_number":305,"context_line":"        share_network \u003d self.shares_v2_client.get_share_network("},{"line_number":306,"context_line":"            self.shares_v2_client.share_network_id)[\u0027share_network\u0027]"},{"line_number":307,"context_line":"        new_share_network_id \u003d self.create_share_network("}],"source_content_type":"text/x-python","patch_set":13,"id":"ecd42d18_dde0aa8c","line":304,"range":{"start_line":303,"start_character":17,"end_line":304,"end_character":35},"updated":"2022-03-02 21:54:22.000000000","message":"No AZs were found. Make sure there is at least one configured.","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        azs \u003d self.get_availability_zones_matching_share_type(share_type)"},{"line_number":301,"context_line":"        if len(azs) \u003d\u003d 0:"},{"line_number":302,"context_line":"            raise self.skipException("},{"line_number":303,"context_line":"                \"Could not find the necessary az. At least one az is needed \""},{"line_number":304,"context_line":"                \"to run this test.\")"},{"line_number":305,"context_line":"        share_network \u003d self.shares_v2_client.get_share_network("},{"line_number":306,"context_line":"            self.shares_v2_client.share_network_id)[\u0027share_network\u0027]"},{"line_number":307,"context_line":"        new_share_network_id \u003d self.create_share_network("}],"source_content_type":"text/x-python","patch_set":13,"id":"1fd3a1aa_93d13ee0","line":304,"range":{"start_line":303,"start_character":17,"end_line":304,"end_character":35},"in_reply_to":"ecd42d18_dde0aa8c","updated":"2022-03-02 23:47:22.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"48e4b72cf5b96a1870352ddff799da7cf35cd7cf","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        extra_specs \u003d {"},{"line_number":287,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":288,"context_line":"            \u0027share_server_multiple_subnet_support\u0027: True,"},{"line_number":289,"context_line":"            \u0027network_allocation_update_support\u0027: True,"},{"line_number":290,"context_line":"        }"},{"line_number":291,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":292,"context_line":"        sg_type_name \u003d data_utils.rand_name(\"tempest-manila\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"266672ee_242645b0","line":289,"range":{"start_line":289,"start_character":12,"end_line":289,"end_character":54},"updated":"2022-03-03 18:55:02.000000000","message":"when \u0027network_allocation_update\u0027 is False, this will break the test for backends that only supports \u0027share_server_multiple_subnet_support\u0027. You should add this extra_spec as True only when \u0027network_allocation_update\u0027 is also True, otherwise, omit this extra_spec since you may filter compatible backends.","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"689f5691cddd0db5bd19f6f5b53c55fc8466e958","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        extra_specs \u003d {"},{"line_number":287,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":288,"context_line":"            \u0027share_server_multiple_subnet_support\u0027: True,"},{"line_number":289,"context_line":"            \u0027network_allocation_update_support\u0027: True,"},{"line_number":290,"context_line":"        }"},{"line_number":291,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":292,"context_line":"        sg_type_name \u003d data_utils.rand_name(\"tempest-manila\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"ad7fb808_5acdd08e","line":289,"range":{"start_line":289,"start_character":12,"end_line":289,"end_character":54},"in_reply_to":"266672ee_242645b0","updated":"2022-03-03 21:27:03.000000000","message":"Agree, good catch, thanks Douglas.","commit_id":"5a1b07a99c61da71da1adefbe0e97c0a21c4c603"}],"manila_tempest_tests/tests/api/test_share_network_subnets.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        self.assertIsNone(default_subnet[\u0027availability_zone\u0027])"},{"line_number":263,"context_line":"        # Match share server subnet"},{"line_number":264,"context_line":"        if not check_multiple_subnet:"},{"line_number":265,"context_line":"            self.assertIn("},{"line_number":266,"context_line":"                expected_subnet_id, share_server[\u0027share_network_subnet_id\u0027])"},{"line_number":267,"context_line":"        else:"},{"line_number":268,"context_line":"            self.assertIn("}],"source_content_type":"text/x-python","patch_set":9,"id":"c151bd66_e4ecf02b","line":265,"range":{"start_line":265,"start_character":17,"end_line":265,"end_character":25},"updated":"2022-02-23 20:56:21.000000000","message":"assertEqual?","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        self.assertIsNone(default_subnet[\u0027availability_zone\u0027])"},{"line_number":263,"context_line":"        # Match share server subnet"},{"line_number":264,"context_line":"        if not check_multiple_subnet:"},{"line_number":265,"context_line":"            self.assertIn("},{"line_number":266,"context_line":"                expected_subnet_id, share_server[\u0027share_network_subnet_id\u0027])"},{"line_number":267,"context_line":"        else:"},{"line_number":268,"context_line":"            self.assertIn("}],"source_content_type":"text/x-python","patch_set":9,"id":"57de868a_dd02868b","line":265,"range":{"start_line":265,"start_character":17,"end_line":265,"end_character":25},"in_reply_to":"c151bd66_e4ecf02b","updated":"2022-02-24 21:37:33.000000000","message":"Done","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"}],"manila_tempest_tests/tests/api/test_share_network_subnets_negative.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":276,"context_line":"            self.assertIn(subnet[\u0027id\u0027],"},{"line_number":277,"context_line":"                          share_server[\u0027share_network_subnet_ids\u0027])"},{"line_number":278,"context_line":"        else:"},{"line_number":279,"context_line":"            self.assertIn(subnet[\u0027id\u0027],"},{"line_number":280,"context_line":"                          share_server[\u0027share_network_subnet_id\u0027])"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # Assert that the user cannot delete a subnet that contain shares"}],"source_content_type":"text/x-python","patch_set":9,"id":"43094d02_9604c8cf","line":279,"range":{"start_line":279,"start_character":17,"end_line":279,"end_character":25},"updated":"2022-02-23 20:56:21.000000000","message":"assertEqual?","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            self.assertIn(subnet[\u0027id\u0027],"},{"line_number":277,"context_line":"                          share_server[\u0027share_network_subnet_ids\u0027])"},{"line_number":278,"context_line":"        else:"},{"line_number":279,"context_line":"            self.assertIn(subnet[\u0027id\u0027],"},{"line_number":280,"context_line":"                          share_server[\u0027share_network_subnet_id\u0027])"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # Assert that the user cannot delete a subnet that contain shares"}],"source_content_type":"text/x-python","patch_set":9,"id":"21979ed4_80fd4b61","line":279,"range":{"start_line":279,"start_character":17,"end_line":279,"end_character":25},"in_reply_to":"43094d02_9604c8cf","updated":"2022-02-24 21:37:33.000000000","message":"Done","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"}],"manila_tempest_tests/tests/api/test_share_servers_multiple_subnet.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        super(ShareServerMultipleSubnetTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not CONF.share.multitenancy_enabled:"},{"line_number":35,"context_line":"            raise cls.skipException(\u0027Multitenancy tests are disabled.\u0027)"},{"line_number":36,"context_line":"        if not CONF.share.run_share_server_multiple_subnet_tests \\"},{"line_number":37,"context_line":"                and not CONF.share.run_network_allocation_update_tests:"},{"line_number":38,"context_line":"            raise cls.skipException("},{"line_number":39,"context_line":"                \u0027Share network multiple subnets tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"deb44d1b_44356ad6","line":36,"range":{"start_line":36,"start_character":65,"end_line":36,"end_character":66},"updated":"2022-02-23 20:56:21.000000000","message":"busted","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(ShareServerMultipleSubnetTest, cls).skip_checks()"},{"line_number":34,"context_line":"        if not CONF.share.multitenancy_enabled:"},{"line_number":35,"context_line":"            raise cls.skipException(\u0027Multitenancy tests are disabled.\u0027)"},{"line_number":36,"context_line":"        if not CONF.share.run_share_server_multiple_subnet_tests \\"},{"line_number":37,"context_line":"                and not CONF.share.run_network_allocation_update_tests:"},{"line_number":38,"context_line":"            raise cls.skipException("},{"line_number":39,"context_line":"                \u0027Share network multiple subnets tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"0bf5c410_501e999f","line":36,"range":{"start_line":36,"start_character":65,"end_line":36,"end_character":66},"in_reply_to":"deb44d1b_44356ad6","updated":"2022-02-24 21:37:33.000000000","message":"Done","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        if not CONF.share.run_share_server_multiple_subnet_tests \\"},{"line_number":37,"context_line":"                and not CONF.share.run_network_allocation_update_tests:"},{"line_number":38,"context_line":"            raise cls.skipException("},{"line_number":39,"context_line":"                \u0027Share network multiple subnets tests are disabled.\u0027)"},{"line_number":40,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.69\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"6f393e9f_bbbdb844","line":39,"range":{"start_line":39,"start_character":47,"end_line":39,"end_character":48},"updated":"2022-02-23 20:56:21.000000000","message":"and network allocation update","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        if not CONF.share.run_share_server_multiple_subnet_tests \\"},{"line_number":37,"context_line":"                and not CONF.share.run_network_allocation_update_tests:"},{"line_number":38,"context_line":"            raise cls.skipException("},{"line_number":39,"context_line":"                \u0027Share network multiple subnets tests are disabled.\u0027)"},{"line_number":40,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.69\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a468b60_030bb7b4","line":39,"range":{"start_line":39,"start_character":47,"end_line":39,"end_character":48},"in_reply_to":"6f393e9f_bbbdb844","updated":"2022-02-24 21:37:33.000000000","message":"Done","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        cls.extra_specs \u003d {"},{"line_number":46,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled"},{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dcls.extra_specs)"},{"line_number":49,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":50,"context_line":"        cls.share_network \u003d cls.alt_shares_v2_client.get_share_network("},{"line_number":51,"context_line":"            cls.alt_shares_v2_client.share_network_id)[\u0027share_network\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"abf8317d_8b056695","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":12},"updated":"2022-02-23 20:56:21.000000000","message":"nit: not using anywhere else, ca be share_type","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        cls.extra_specs \u003d {"},{"line_number":46,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled"},{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dcls.extra_specs)"},{"line_number":49,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":50,"context_line":"        cls.share_network \u003d cls.alt_shares_v2_client.get_share_network("},{"line_number":51,"context_line":"            cls.alt_shares_v2_client.share_network_id)[\u0027share_network\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"49fe6514_c8e8b24b","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":12},"in_reply_to":"abf8317d_8b056695","updated":"2022-02-24 21:37:33.000000000","message":"Done","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    @testtools.skipIf("},{"line_number":55,"context_line":"        not CONF.share.run_share_server_multiple_subnet_tests,"},{"line_number":56,"context_line":"        \"Share network multiple subnets tests are disabled.\")"},{"line_number":57,"context_line":"    @testtools.skipIf(CONF.share.share_network_id !\u003d \"\","},{"line_number":58,"context_line":"                      \"This test is not suitable for pre-existing \""},{"line_number":59,"context_line":"                      \"share_network.\")"},{"line_number":60,"context_line":"    @decorators.idempotent_id(\u00275600bd52-ecb4-47d3-a4e8-3e6565cb0b80\u0027)"},{"line_number":61,"context_line":"    def test_create_share_on_multiple_subnets_same_az(self):"},{"line_number":62,"context_line":"        extra_specs \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"a079a7ce_c4b20eb3","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":39},"updated":"2022-02-23 20:56:21.000000000","message":"this is true for all tests, you can skip in class skip_checks, right?","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    @testtools.skipIf("},{"line_number":55,"context_line":"        not CONF.share.run_share_server_multiple_subnet_tests,"},{"line_number":56,"context_line":"        \"Share network multiple subnets tests are disabled.\")"},{"line_number":57,"context_line":"    @testtools.skipIf(CONF.share.share_network_id !\u003d \"\","},{"line_number":58,"context_line":"                      \"This test is not suitable for pre-existing \""},{"line_number":59,"context_line":"                      \"share_network.\")"},{"line_number":60,"context_line":"    @decorators.idempotent_id(\u00275600bd52-ecb4-47d3-a4e8-3e6565cb0b80\u0027)"},{"line_number":61,"context_line":"    def test_create_share_on_multiple_subnets_same_az(self):"},{"line_number":62,"context_line":"        extra_specs \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf2c7cfd_3204b405","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":39},"in_reply_to":"a079a7ce_c4b20eb3","updated":"2022-02-24 21:37:33.000000000","message":"You are right.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3c5446eb_ff1df20c","updated":"2022-03-02 21:54:22.000000000","message":"I don\u0027t know the opinion of other reviewers but IMHO the tests on this file (at least the test_share_network_subnet_create_check) could possibly fit into the share_network_subnets file...\nI\u0027m okay if others also think it\u0027s okay though :)","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b4a191bc_1de6466b","in_reply_to":"3c5446eb_ff1df20c","updated":"2022-03-02 23:47:22.000000000","message":"I choose this way for the readability since we are adding new config options to enable/disable those new tests. I don\u0027t have strong opinion on that also. What do you thing Douglas?","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"10c8d1fe309027008a5d380402f7e816c4e7ad82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"30131aa5_71df2879","in_reply_to":"b4a191bc_1de6466b","updated":"2022-03-11 22:35:39.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"}],"manila_tempest_tests/tests/api/test_share_servers_multiple_subnet_negative.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c371d33412ca8c664f2bb2288397fbec329136e0","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        extra_specs \u003d {"},{"line_number":51,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":52,"context_line":"            \u0027share_server_multiple_subnet_support\u0027:"},{"line_number":53,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":56,"context_line":"        pools \u003d self.get_pools_matching_share_type("}],"source_content_type":"text/x-python","patch_set":9,"id":"97e429c0_b7ea08c4","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":74},"updated":"2022-02-23 20:56:21.000000000","message":"what do you expect here? it think that must be \u0027False\u0027, so you can search for pools/zones that are not compatible, and fail creating the share.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6616ce518d5ffd034a99fa31d797de72fbf188ea","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        extra_specs \u003d {"},{"line_number":51,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":52,"context_line":"            \u0027share_server_multiple_subnet_support\u0027:"},{"line_number":53,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":56,"context_line":"        pools \u003d self.get_pools_matching_share_type("}],"source_content_type":"text/x-python","patch_set":9,"id":"efe0eb03_a542b390","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":74},"in_reply_to":"97e429c0_b7ea08c4","updated":"2022-02-24 21:37:33.000000000","message":"Agree, I think the idea is to always run this test considering the capability share_server_multiple_subnet_support False. Also, removing the skipIf about the tempest conf run_share_server_multiple_subnet_tests, since this test will run if has backends without support of multiple subnets and mc \u003e 2.70. Thanks.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"591141e648b6d2668b121d2d53962668ec46b621","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        extra_specs \u003d {"},{"line_number":51,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":52,"context_line":"            \u0027share_server_multiple_subnet_support\u0027:"},{"line_number":53,"context_line":"                CONF.share.capability_share_server_multiple_subnet_support"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":56,"context_line":"        pools \u003d self.get_pools_matching_share_type("}],"source_content_type":"text/x-python","patch_set":9,"id":"9d267693_b97081f7","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":74},"in_reply_to":"efe0eb03_a542b390","updated":"2022-03-02 21:02:47.000000000","message":"Ack, good one on removing the skipif, since some CIs can have both backends to test.","commit_id":"5a711a8f650abb2b46f290bd442e52215eaa0a83"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b6abf3f8_04061ff4","updated":"2022-03-02 21:54:22.000000000","message":"Same comment as the other file... The test below could possibly fit into other file - But isn\u0027t a strong opinion on this as I mentioned","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d5e1a64b_93611e71","in_reply_to":"b6abf3f8_04061ff4","updated":"2022-03-02 23:47:22.000000000","message":"Same as the other file.","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"10c8d1fe309027008a5d380402f7e816c4e7ad82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"45dd0d62_f168777e","in_reply_to":"d5e1a64b_93611e71","updated":"2022-03-11 22:35:39.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        zones \u003d self.get_availability_zones_matching_share_type("},{"line_number":54,"context_line":"            share_type)"},{"line_number":55,"context_line":"        if not pools or not zones:"},{"line_number":56,"context_line":"            raise self.skipException(\"At least one backend without \""},{"line_number":57,"context_line":"                                     \"support to share network multiple \""},{"line_number":58,"context_line":"                                     \"subnets feature is needed\")"},{"line_number":59,"context_line":"        extra_specs \u003d {\u0027pool_name\u0027: pools[0][\u0027pool\u0027],"},{"line_number":60,"context_line":"                       \u0027availability_zone\u0027: zones[0]}"},{"line_number":61,"context_line":"        self.admin_shares_v2_client.update_share_type_extra_specs("}],"source_content_type":"text/x-python","patch_set":13,"id":"4cad31c3_e413c8e6","line":58,"range":{"start_line":56,"start_character":38,"end_line":58,"end_character":63},"updated":"2022-03-02 21:54:22.000000000","message":"At least one backend that supports adding multiple subnets into a share network is needed for this test.","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        zones \u003d self.get_availability_zones_matching_share_type("},{"line_number":54,"context_line":"            share_type)"},{"line_number":55,"context_line":"        if not pools or not zones:"},{"line_number":56,"context_line":"            raise self.skipException(\"At least one backend without \""},{"line_number":57,"context_line":"                                     \"support to share network multiple \""},{"line_number":58,"context_line":"                                     \"subnets feature is needed\")"},{"line_number":59,"context_line":"        extra_specs \u003d {\u0027pool_name\u0027: pools[0][\u0027pool\u0027],"},{"line_number":60,"context_line":"                       \u0027availability_zone\u0027: zones[0]}"},{"line_number":61,"context_line":"        self.admin_shares_v2_client.update_share_type_extra_specs("}],"source_content_type":"text/x-python","patch_set":13,"id":"efdaf1d1_48b9c522","line":58,"range":{"start_line":56,"start_character":38,"end_line":58,"end_character":63},"in_reply_to":"4cad31c3_e413c8e6","updated":"2022-03-02 23:47:22.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"}],"manila_tempest_tests/utils.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7c6e8aa652b5cefdb6918d10e97b78c91fafacc","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def skip_if_is_microversion_ge(left, right):"},{"line_number":98,"context_line":"    \"\"\"Decorator for tests that are microversion-specific.\"\"\""},{"line_number":99,"context_line":"    if is_microversion_ge(left, right):"},{"line_number":100,"context_line":"        reason \u003d (\"Skipped. Test requires microversion \""},{"line_number":101,"context_line":"                  \"\u003c than \u0027%s\u0027.\" % right)"}],"source_content_type":"text/x-python","patch_set":13,"id":"17dd85e9_3a5439fb","line":98,"range":{"start_line":98,"start_character":4,"end_line":98,"end_character":61},"updated":"2022-03-02 21:54:22.000000000","message":"docstring seems like copy/paste","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"201fd09fd191ac176168f151d9670e16f9315792","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def skip_if_is_microversion_ge(left, right):"},{"line_number":98,"context_line":"    \"\"\"Decorator for tests that are microversion-specific.\"\"\""},{"line_number":99,"context_line":"    if is_microversion_ge(left, right):"},{"line_number":100,"context_line":"        reason \u003d (\"Skipped. Test requires microversion \""},{"line_number":101,"context_line":"                  \"\u003c than \u0027%s\u0027.\" % right)"}],"source_content_type":"text/x-python","patch_set":13,"id":"064e42f7_a8d4c48e","line":98,"range":{"start_line":98,"start_character":4,"end_line":98,"end_character":61},"in_reply_to":"17dd85e9_3a5439fb","updated":"2022-03-02 23:47:22.000000000","message":"Done","commit_id":"d27a6399a26508c007310e8d24f4bb6265997964"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4bf2fbfbff45449d88b16bf23d78846d4ae00f6d","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def skip_if_is_microversion_ge(left, right):"},{"line_number":98,"context_line":"    \"\"\"Skip if mc for left is greater than or equal to the right one.\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    if is_microversion_ge(left, right):"},{"line_number":101,"context_line":"        reason \u003d (\"Skipped. Test requires microversion \""}],"source_content_type":"text/x-python","patch_set":17,"id":"d314ca64_b3879d0b","line":98,"range":{"start_line":98,"start_character":15,"end_line":98,"end_character":17},"updated":"2022-03-04 21:09:47.000000000","message":"version","commit_id":"073417b4ebe3e1cb0ba6c2c0eca4e364341fd4ac"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"10c8d1fe309027008a5d380402f7e816c4e7ad82","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def skip_if_is_microversion_ge(left, right):"},{"line_number":98,"context_line":"    \"\"\"Skip if mc for left is greater than or equal to the right one.\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    if is_microversion_ge(left, right):"},{"line_number":101,"context_line":"        reason \u003d (\"Skipped. Test requires microversion \""}],"source_content_type":"text/x-python","patch_set":17,"id":"4d50daaa_1e7e70a0","line":98,"range":{"start_line":98,"start_character":15,"end_line":98,"end_character":17},"in_reply_to":"d314ca64_b3879d0b","updated":"2022-03-11 22:35:39.000000000","message":"Done","commit_id":"073417b4ebe3e1cb0ba6c2c0eca4e364341fd4ac"}]}