)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"a6cfb93fff0c1551367400db58cc7048c96028a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e107d960_77c2fdf2","updated":"2022-03-03 11:30:48.000000000","message":"recheck","commit_id":"cee978a7c4c5a6c1678d62c365a8e4c0b766f2a0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ebea0cf84d114f85387d21b362d70dc582bb656a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e5e2ef28_7c4d0444","updated":"2022-03-07 13:22:21.000000000","message":"recheck\n\nThank you, mostly LGTM - The generic driver job usually passes, but has failed several scenario tests; checking if this is related. ","commit_id":"cee978a7c4c5a6c1678d62c365a8e4c0b766f2a0"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"075d73cf8cca09a9748b41a0759df234ec9fd075","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cd5b50b5_4e4fcfd8","updated":"2022-03-28 20:38:29.000000000","message":"\nHi Roman, Can you please attempt to test with concurrency set to 1, and see if it helps the generic driver stability issue.\nSharing the related link, https://github.com/openstack/manila-tempest-plugin/blob/5203643c2423c89afc90b1c0045de422c643f85a/zuul.d/manila-tempest-jobs.yaml#L262 \n","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b62d498035506cc00b043f9d464619193c0f15f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c65a53fe_1ce6f626","updated":"2022-03-29 16:29:00.000000000","message":"Lets see whether the generic driver job fares better when test concurrency is reduced: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/835664\n\nThanks Roman!","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3e78da417bcfbf9832d2b0a7bb4c443346d9a269","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4e947aaa_179ade03","updated":"2022-04-20 18:27:52.000000000","message":"Looks good. Thank you Roman","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"5179942f51b742768738765a01b7b629304b16b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d76e510b_7220bddd","updated":"2022-03-21 12:36:40.000000000","message":"Looks good. The cephfs-nfs (non-voting) job failure exceptions.SSHTimeout is curious","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a7a44a11c79d8e8ddc255a394bbb12149de338fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5b785386_bdb966c2","updated":"2022-03-29 18:43:33.000000000","message":"nice, looks good, thanks Roman!","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"38adb30418275536bc11434e7cb6b68b93b9846f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c198b90c_69617c23","updated":"2022-03-09 12:31:31.000000000","message":"recheck","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7230382be5f5eac64e294bfff1fa988fa0d5c34b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"eb0bd58c_82923fca","updated":"2022-03-21 17:56:21.000000000","message":"recheck\n\n\nFor sanity; q-svc HTTP 500 in the Generic driver causing failures was indeed puzzling - no evidence of that in the latest run, but a test failed - lets see if it passes ","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6f9c1008cd36da7a1fa976c3c34dfb210d8f5952","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e7da204e_2a4ba40c","updated":"2022-03-23 18:49:03.000000000","message":"recheck\n\nThe generic driver job failures are still concerning; the old failures are back","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bab2b7c6aeb9275dfc954731c329d01b1db2f33e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7d2f3f18_941364b3","updated":"2022-03-16 18:57:25.000000000","message":"recheck\n\nunsure why we\u0027re seeing HTTP500s in the generic driver job\u0027s scenario tests:\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_110/831168/10/check/manila-tempest-plugin-generic/110722a/testr_results.html\nhttps://zuul.opendev.org/t/openstack/build/110722a74c7345268058451d2f68bdd5/log/controller/logs/screen-q-svc.txt#60011-60098","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7eec05af656639e3123d70326e506c210b2d4e7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7cec5ebb_11deda33","updated":"2022-03-15 21:01:45.000000000","message":"thanks now this lgtm","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b62d498035506cc00b043f9d464619193c0f15f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"add21fcc_c5aa3e9e","in_reply_to":"4dbf0b8d_689fc4f4","updated":"2022-03-29 16:29:00.000000000","message":"We had a high failure rate because of https://launchpad.net/bugs/1903922 \n\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/829758\n\nI haven\u0027t tracked this since - but i guess we\u0027re running into an issue with lack of resources with this job as Vida suggests..","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"f7f3bbdfee894fbcbe6025dd5c2a1f9e146ea834","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4dbf0b8d_689fc4f4","in_reply_to":"e7da204e_2a4ba40c","updated":"2022-03-24 12:42:48.000000000","message":"I checked job\u0027s history and it seems like it\u0027s been failing a lot in past few months too. (f.e. build history from january and february: https://zuul.opendev.org/t/openstack/builds?job_name\u003dmanila-tempest-plugin-generic\u0026project\u003dopenstack%2Fmanila-tempest-plugin\u0026skip\u003d100)","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"}],"manila_tempest_tests/tests/scenario/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ebea0cf84d114f85387d21b362d70dc582bb656a","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"},{"line_number":86,"context_line":"                      validatable\u003dFalse, wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":87,"context_line":"                      clients\u003dNone, **kwargs):"},{"line_number":88,"context_line":"        if CONF.network.port_vnic_type:"},{"line_number":89,"context_line":"            kwargs[\u0027create_port_body\u0027][\u0027namestart\u0027] \u003d \u0027port-smoke\u0027"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return super().create_server(name\u003dname,"},{"line_number":92,"context_line":"                                     image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"8771b3d6_8d77a8f4","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":66},"updated":"2022-03-07 13:22:21.000000000","message":"shouldn\u0027t this happen in the super class\u0027s create_server method as well? https://github.com/openstack/tempest/blob/914b096dfd6b829ea963d537aaa1db6c12bd28f2/tempest/scenario/manager.py#L252","commit_id":"cee978a7c4c5a6c1678d62c365a8e4c0b766f2a0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bab709bcd80faac6ee29c39a9b177a223439dd9a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"},{"line_number":86,"context_line":"                      validatable\u003dFalse, wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":87,"context_line":"                      clients\u003dNone, **kwargs):"},{"line_number":88,"context_line":"        if CONF.network.port_vnic_type:"},{"line_number":89,"context_line":"            kwargs[\u0027create_port_body\u0027][\u0027namestart\u0027] \u003d \u0027port-smoke\u0027"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return super().create_server(name\u003dname,"},{"line_number":92,"context_line":"                                     image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3a906a9_af56c79e","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":66},"in_reply_to":"135f5877_8377abe0","updated":"2022-03-15 21:02:10.000000000","message":"+1, same I commented in other patches also like https://review.opendev.org/c/openstack/barbican-tempest-plugin/+/830121/13/barbican_tempest_plugin/tests/scenario/manager.py#89","commit_id":"cee978a7c4c5a6c1678d62c365a8e4c0b766f2a0"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"3959d7c6fadda06232202538569bd5130045aa92","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"},{"line_number":86,"context_line":"                      validatable\u003dFalse, wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":87,"context_line":"                      clients\u003dNone, **kwargs):"},{"line_number":88,"context_line":"        if CONF.network.port_vnic_type:"},{"line_number":89,"context_line":"            kwargs[\u0027create_port_body\u0027][\u0027namestart\u0027] \u003d \u0027port-smoke\u0027"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return super().create_server(name\u003dname,"},{"line_number":92,"context_line":"                                     image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f9885bbe_0d01be21","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":66},"in_reply_to":"4fcc0209_0b84694f","updated":"2022-03-09 07:53:02.000000000","message":"Agreed, deleting it. :)","commit_id":"cee978a7c4c5a6c1678d62c365a8e4c0b766f2a0"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"f53cfa52b475785e99972987af02fa0684932d21","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"},{"line_number":86,"context_line":"                      validatable\u003dFalse, wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":87,"context_line":"                      clients\u003dNone, **kwargs):"},{"line_number":88,"context_line":"        if CONF.network.port_vnic_type:"},{"line_number":89,"context_line":"            kwargs[\u0027create_port_body\u0027][\u0027namestart\u0027] \u003d \u0027port-smoke\u0027"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return super().create_server(name\u003dname,"},{"line_number":92,"context_line":"                                     image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c2a927fd_b861316c","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":66},"in_reply_to":"8771b3d6_8d77a8f4","updated":"2022-03-08 10:55:02.000000000","message":"I don\u0027t know about that. The logic behind this condition is as follows: \n\nManila explicitly assigned \u0027namestart\u0027 to \u0027create_port_body\u0027, tempest doesn\u0027t do such thing. The condition was created to achieve logical equivalence of manila\u0027s and tempest\u0027s create_server method. \n\ncreate_port_body dict must be used only when CONF.network.port_vnic_type is present, otherwise the dictionary wouldn\u0027t be popped from kwargs (https://github.com/openstack/tempest/blob/914b096dfd6b829ea963d537aaa1db6c12bd28f2/tempest/scenario/manager.py#L249) and will cause failure later - https://github.com/openstack/tempest/blob/914b096dfd6b829ea963d537aaa1db6c12bd28f2/tempest/scenario/manager.py#L309, because compute.create_test_server doesn\u0027t accept such kwarg.","commit_id":"cee978a7c4c5a6c1678d62c365a8e4c0b766f2a0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4febdbe2d4122b55374aa4100a5301c794d7e1ec","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"},{"line_number":86,"context_line":"                      validatable\u003dFalse, wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":87,"context_line":"                      clients\u003dNone, **kwargs):"},{"line_number":88,"context_line":"        if CONF.network.port_vnic_type:"},{"line_number":89,"context_line":"            kwargs[\u0027create_port_body\u0027][\u0027namestart\u0027] \u003d \u0027port-smoke\u0027"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return super().create_server(name\u003dname,"},{"line_number":92,"context_line":"                                     image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4fcc0209_0b84694f","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":66},"in_reply_to":"c2a927fd_b861316c","updated":"2022-03-08 18:49:04.000000000","message":"its not just the manila tests -- the code existed in tempest at some point and got ported over to the plugins: https://codesearch.opendev.org/?q\u003d%27namestart%27%3A%20%27port-smoke%27\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\nThis commit in tempest removed it: https://review.opendev.org/c/openstack/tempest/+/512234/3/tempest/scenario/manager.py\n\n\nSo, i don\u0027t mind us dropping it here too, so the next person doesn\u0027t wonder why we\u0027re customizing the port namestart... what do you think?","commit_id":"cee978a7c4c5a6c1678d62c365a8e4c0b766f2a0"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"bf9e881e49ebf798e6c0971504925b773da14279","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"},{"line_number":86,"context_line":"                      validatable\u003dFalse, wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":87,"context_line":"                      clients\u003dNone, **kwargs):"},{"line_number":88,"context_line":"        if CONF.network.port_vnic_type:"},{"line_number":89,"context_line":"            kwargs[\u0027create_port_body\u0027][\u0027namestart\u0027] \u003d \u0027port-smoke\u0027"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return super().create_server(name\u003dname,"},{"line_number":92,"context_line":"                                     image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"135f5877_8377abe0","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":66},"in_reply_to":"f9885bbe_0d01be21","updated":"2022-03-09 12:32:09.000000000","message":"Done","commit_id":"cee978a7c4c5a6c1678d62c365a8e4c0b766f2a0"}]}