)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ce172dd1270e1cbdc359467c8eae61d5845ac074","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove ping_ip_address \u0026 _log_console_output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Replaced methods:"},{"line_number":12,"context_line":"\t* ping_ip_address"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d8867708_875898d0","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":75},"updated":"2022-04-13 08:00:47.000000000","message":"line too long, this should have started on a new line","commit_id":"164898cd76d84a776198952e18255d010f256285"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ce172dd1270e1cbdc359467c8eae61d5845ac074","unresolved":true,"context_lines":[{"line_number":9,"context_line":"As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Replaced methods:"},{"line_number":12,"context_line":"\t* ping_ip_address"},{"line_number":13,"context_line":"\t* _log_console_output"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Etherpad concerning this effort:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a738e772_a6223809","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":18},"updated":"2022-04-13 08:00:47.000000000","message":"this is removed because it\u0027s not even used by the plugin","commit_id":"164898cd76d84a776198952e18255d010f256285"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ce172dd1270e1cbdc359467c8eae61d5845ac074","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Replaced methods:"},{"line_number":12,"context_line":"\t* ping_ip_address"},{"line_number":13,"context_line":"\t* _log_console_output"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Etherpad concerning this effort:"},{"line_number":16,"context_line":"https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5b901095_b6791419","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":1},"updated":"2022-04-13 08:00:47.000000000","message":"a small detail, but please avoid tabs","commit_id":"164898cd76d84a776198952e18255d010f256285"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ce172dd1270e1cbdc359467c8eae61d5845ac074","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Replaced methods:"},{"line_number":12,"context_line":"\t* ping_ip_address"},{"line_number":13,"context_line":"\t* _log_console_output"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Etherpad concerning this effort:"},{"line_number":16,"context_line":"https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7bb6a50a_037700b0","line":13,"range":{"start_line":13,"start_character":3,"end_line":13,"end_character":22},"updated":"2022-04-13 08:00:47.000000000","message":"technically only this is replaced","commit_id":"164898cd76d84a776198952e18255d010f256285"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"38f4844a8d9fc5998360c15820fa71424dd5e537","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4c4b1db_9b749322","updated":"2022-05-04 10:26:11.000000000","message":"LGTM.","commit_id":"164898cd76d84a776198952e18255d010f256285"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0f40de19a704cc09441854cad765862293a7578b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"470c6ada_3a344a3b","updated":"2022-04-13 19:01:40.000000000","message":"LGTM; the generic driver job is failing - but the failure seems unrelated (time out)","commit_id":"164898cd76d84a776198952e18255d010f256285"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ce172dd1270e1cbdc359467c8eae61d5845ac074","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70dfef69_e7c3c06f","updated":"2022-04-13 08:00:47.000000000","message":"lgtm, looks very clean, great work! ","commit_id":"164898cd76d84a776198952e18255d010f256285"}],"manila_tempest_tests/tests/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ce172dd1270e1cbdc359467c8eae61d5845ac074","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        if not isinstance(exc, lib_exc.SSHTimeout):"},{"line_number":245,"context_line":"            LOG.debug(\u0027Network information on a devstack host\u0027)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def ping_ip_address(self, ip_address, should_succeed\u003dTrue,"},{"line_number":248,"context_line":"                        ping_timeout\u003dNone, mtu\u003dNone):"},{"line_number":249,"context_line":"        timeout \u003d ping_timeout or CONF.validation.ping_timeout"},{"line_number":250,"context_line":"        cmd \u003d [\u0027ping\u0027, \u0027-c1\u0027, \u0027-w1\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"14f6ce9c_45626102","side":"PARENT","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":23},"updated":"2022-04-13 08:00:47.000000000","message":"seems this isn\u0027t even used","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0f40de19a704cc09441854cad765862293a7578b","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        if not isinstance(exc, lib_exc.SSHTimeout):"},{"line_number":245,"context_line":"            LOG.debug(\u0027Network information on a devstack host\u0027)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def ping_ip_address(self, ip_address, should_succeed\u003dTrue,"},{"line_number":248,"context_line":"                        ping_timeout\u003dNone, mtu\u003dNone):"},{"line_number":249,"context_line":"        timeout \u003d ping_timeout or CONF.validation.ping_timeout"},{"line_number":250,"context_line":"        cmd \u003d [\u0027ping\u0027, \u0027-c1\u0027, \u0027-w1\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f751f38_a87a7425","side":"PARENT","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":23},"in_reply_to":"14f6ce9c_45626102","updated":"2022-04-13 19:01:40.000000000","message":"It\u0027s used here: https://opendev.org/openstack/manila-tempest-plugin/src/commit/ee15891b5d5e02ff355f50ad7647ead9d8ec6841/manila_tempest_tests/tests/scenario/manager.py#L447-L450","commit_id":"a02c455af93838e4247be7348630bc83b138cf6c"}]}