)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0bbd15fd17d7724630932ea597010f88cff25d49","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove get_remote_client \u0026 check_vm_connectivity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Replaced methods:"},{"line_number":12,"context_line":"\t* get_remote_client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"985e7a0f_02fc78d3","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":79},"updated":"2022-03-29 19:43:26.000000000","message":"too long line, this should have been already on the next line","commit_id":"b67d7ce410987d49087b49ca5be819a32c317fb1"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"aafe5a3b1beb7c9598940bdfc3b4140d53417b4c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove get_remote_client \u0026 check_vm_connectivity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Replaced methods:"},{"line_number":12,"context_line":"\t* get_remote_client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fcb40874_3d50c930","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":79},"in_reply_to":"985e7a0f_02fc78d3","updated":"2022-04-01 08:18:05.000000000","message":"Ack","commit_id":"b67d7ce410987d49087b49ca5be819a32c317fb1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0bbd15fd17d7724630932ea597010f88cff25d49","unresolved":true,"context_lines":[{"line_number":9,"context_line":"As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Replaced methods:"},{"line_number":12,"context_line":"\t* get_remote_client"},{"line_number":13,"context_line":"\t* check_vm_connectivity"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Etherpad concerning this effort:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"aa16bb01_19aca450","line":12,"updated":"2022-03-29 19:43:26.000000000","message":"the tabs should be replaced by spaces","commit_id":"b67d7ce410987d49087b49ca5be819a32c317fb1"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"aafe5a3b1beb7c9598940bdfc3b4140d53417b4c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Replaced methods:"},{"line_number":12,"context_line":"\t* get_remote_client"},{"line_number":13,"context_line":"\t* check_vm_connectivity"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Etherpad concerning this effort:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ea02e62_37eeb61c","line":12,"in_reply_to":"aa16bb01_19aca450","updated":"2022-04-01 08:18:05.000000000","message":"Ack","commit_id":"b67d7ce410987d49087b49ca5be819a32c317fb1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"9b48e903250354d51c0dd08424b3bff0fcf47bb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e7c096af_d28b80a7","updated":"2022-03-22 10:32:31.000000000","message":"run-DellEMC Unity CI","commit_id":"8cda00b6a1e29dcf34594b9e87d608ec3b57cf0d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0bbd15fd17d7724630932ea597010f88cff25d49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0fecb281_1e7c312e","updated":"2022-03-29 19:43:26.000000000","message":"overall it looks fine, i have a few points for the further discussion though ","commit_id":"b67d7ce410987d49087b49ca5be819a32c317fb1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"95c989537d21a2cae3fb18def9a004332e8ddaf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"08ac08bb_e9cb8dcf","updated":"2022-04-13 08:14:50.000000000","message":"lgtm, thanks","commit_id":"fd4e2f325cf3eedfc929bca9c0398e2640e91650"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"adc94008c3d2e76c8bedf8de53d1803ffc451688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0bcf2ffd_f2657681","updated":"2022-05-09 16:21:17.000000000","message":"recheck\n\nknown sporadic failure in the dummy driver job","commit_id":"fd4e2f325cf3eedfc929bca9c0398e2640e91650"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91d1740f8e3540a329f556f22c56831822821eb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7a87534e_4b889f33","updated":"2022-05-07 07:43:10.000000000","message":"recheck\n\nlogs are gone","commit_id":"fd4e2f325cf3eedfc929bca9c0398e2640e91650"}],"manila_tempest_tests/tests/scenario/manager.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0bbd15fd17d7724630932ea597010f88cff25d49","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            message \u003d (\u0027Initializing SSH connection to %(ip)s failed. \u0027"},{"line_number":164,"context_line":"                       \u0027Error: %(error)s\u0027 % {\u0027ip\u0027: ip_address,"},{"line_number":165,"context_line":"                                             \u0027error\u0027: e})"},{"line_number":166,"context_line":"            caller \u003d test_utils.find_test_caller()"},{"line_number":167,"context_line":"            if caller:"},{"line_number":168,"context_line":"                message \u003d \u0027(%s) %s\u0027 % (caller, message)"},{"line_number":169,"context_line":"            LOG.exception(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1bdb5323_65affaa1","side":"PARENT","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":50},"updated":"2022-03-29 19:43:26.000000000","message":"this is missing in the tempest\u0027s implementation of get_remote_client/check_vm_connectivity .. not sure needed it is, maybe we could add it to the tempest\u0027s implementation of check_vm_connectivity","commit_id":"f01c60eac31465af0b9425e7ede4ba540b8192f8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91d1740f8e3540a329f556f22c56831822821eb9","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            message \u003d (\u0027Initializing SSH connection to %(ip)s failed. \u0027"},{"line_number":164,"context_line":"                       \u0027Error: %(error)s\u0027 % {\u0027ip\u0027: ip_address,"},{"line_number":165,"context_line":"                                             \u0027error\u0027: e})"},{"line_number":166,"context_line":"            caller \u003d test_utils.find_test_caller()"},{"line_number":167,"context_line":"            if caller:"},{"line_number":168,"context_line":"                message \u003d \u0027(%s) %s\u0027 % (caller, message)"},{"line_number":169,"context_line":"            LOG.exception(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"48199b19_ad87966d","side":"PARENT","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":50},"in_reply_to":"1bdb5323_65affaa1","updated":"2022-05-07 07:43:10.000000000","message":"+1","commit_id":"f01c60eac31465af0b9425e7ede4ba540b8192f8"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"429dd91aad67b4e38ce2e5a5e465e4e28ae8ccc0","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            message \u003d (\u0027Initializing SSH connection to %(ip)s failed. \u0027"},{"line_number":164,"context_line":"                       \u0027Error: %(error)s\u0027 % {\u0027ip\u0027: ip_address,"},{"line_number":165,"context_line":"                                             \u0027error\u0027: e})"},{"line_number":166,"context_line":"            caller \u003d test_utils.find_test_caller()"},{"line_number":167,"context_line":"            if caller:"},{"line_number":168,"context_line":"                message \u003d \u0027(%s) %s\u0027 % (caller, message)"},{"line_number":169,"context_line":"            LOG.exception(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"6e1bc877_06dbb55f","side":"PARENT","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":50},"in_reply_to":"1bdb5323_65affaa1","updated":"2022-04-01 08:00:36.000000000","message":"This logic was moved to remote_client in tempest. So there probably shouldn\u0027t be need to add this, or the log_console_output method to current tempest implementations. Patch regarding this issue: https://opendev.org/openstack/tempest/commit/f52c759e5cc6da962ad63831c55dc140d05a2373","commit_id":"f01c60eac31465af0b9425e7ede4ba540b8192f8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"95c989537d21a2cae3fb18def9a004332e8ddaf9","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            message \u003d (\u0027Initializing SSH connection to %(ip)s failed. \u0027"},{"line_number":164,"context_line":"                       \u0027Error: %(error)s\u0027 % {\u0027ip\u0027: ip_address,"},{"line_number":165,"context_line":"                                             \u0027error\u0027: e})"},{"line_number":166,"context_line":"            caller \u003d test_utils.find_test_caller()"},{"line_number":167,"context_line":"            if caller:"},{"line_number":168,"context_line":"                message \u003d \u0027(%s) %s\u0027 % (caller, message)"},{"line_number":169,"context_line":"            LOG.exception(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"cb6a056d_c0de9d86","side":"PARENT","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":50},"in_reply_to":"6e1bc877_06dbb55f","updated":"2022-04-13 08:14:50.000000000","message":"oh, i see, you\u0027re right","commit_id":"f01c60eac31465af0b9425e7ede4ba540b8192f8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0bbd15fd17d7724630932ea597010f88cff25d49","unresolved":true,"context_lines":[{"line_number":167,"context_line":"            if caller:"},{"line_number":168,"context_line":"                message \u003d \u0027(%s) %s\u0027 % (caller, message)"},{"line_number":169,"context_line":"            LOG.exception(message)"},{"line_number":170,"context_line":"            self.log_console_output()"},{"line_number":171,"context_line":"            raise"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        return linux_client"}],"source_content_type":"text/x-python","patch_set":3,"id":"48d0ecbf_2f59d333","side":"PARENT","line":170,"range":{"start_line":170,"start_character":11,"end_line":170,"end_character":37},"updated":"2022-03-29 19:43:26.000000000","message":"this is missing in the tempest\u0027s implementation of get_remote_client/check_vm_connectivity too, although i think it\u0027s not needed here as it\u0027s called on line 592 of this file.","commit_id":"f01c60eac31465af0b9425e7ede4ba540b8192f8"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"aafe5a3b1beb7c9598940bdfc3b4140d53417b4c","unresolved":true,"context_lines":[{"line_number":167,"context_line":"            if caller:"},{"line_number":168,"context_line":"                message \u003d \u0027(%s) %s\u0027 % (caller, message)"},{"line_number":169,"context_line":"            LOG.exception(message)"},{"line_number":170,"context_line":"            self.log_console_output()"},{"line_number":171,"context_line":"            raise"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        return linux_client"}],"source_content_type":"text/x-python","patch_set":3,"id":"7846f96a_e5391559","side":"PARENT","line":170,"range":{"start_line":170,"start_character":11,"end_line":170,"end_character":37},"in_reply_to":"48d0ecbf_2f59d333","updated":"2022-04-01 08:18:05.000000000","message":"Answer is in previous comment. Patch regarding this issue: https://opendev.org/openstack/tempest/commit/f52c759e5cc6da962ad63831c55dc140d05a2373","commit_id":"f01c60eac31465af0b9425e7ede4ba540b8192f8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"95c989537d21a2cae3fb18def9a004332e8ddaf9","unresolved":true,"context_lines":[{"line_number":167,"context_line":"            if caller:"},{"line_number":168,"context_line":"                message \u003d \u0027(%s) %s\u0027 % (caller, message)"},{"line_number":169,"context_line":"            LOG.exception(message)"},{"line_number":170,"context_line":"            self.log_console_output()"},{"line_number":171,"context_line":"            raise"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        return linux_client"}],"source_content_type":"text/x-python","patch_set":3,"id":"77cb09c7_f47fb32f","side":"PARENT","line":170,"range":{"start_line":170,"start_character":11,"end_line":170,"end_character":37},"in_reply_to":"7846f96a_e5391559","updated":"2022-04-13 08:14:50.000000000","message":"makes sense, thanks","commit_id":"f01c60eac31465af0b9425e7ede4ba540b8192f8"}]}