)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f11ac75a90973eebd07a1a73775f996644d8ab10","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2022-05-05 16:33:12 -0300"},{"line_number":4,"context_line":"Commit:     silvacarloss \u003cces.eduardo98@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-05-06 14:55:15 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Perform list all sec services using admin client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We currently try to list all security services using the"},{"line_number":10,"context_line":"shares_client. This change switches that search and makes it start"},{"line_number":11,"context_line":"using the admins client instead, considering that this is supposed"},{"line_number":12,"context_line":"to be an administrator action."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1916102"},{"line_number":15,"context_line":"Change-Id: Idd49e22c8dc534a1fe1e4814f233b079cf14bb72"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e40f6bd8_8b6e5a37","line":12,"range":{"start_line":6,"start_character":0,"end_line":12,"end_character":30},"updated":"2022-05-06 19:53:49.000000000","message":"This commit message needs to be updated to what the change really does..","commit_id":"315b266a13ea5d24ec4f04e3985e6f923297df73"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"423053bf38e247ed022ddf0f30a27829ed808f9e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2022-05-05 16:33:12 -0300"},{"line_number":4,"context_line":"Commit:     silvacarloss \u003cces.eduardo98@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-05-06 14:55:15 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Perform list all sec services using admin client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We currently try to list all security services using the"},{"line_number":10,"context_line":"shares_client. This change switches that search and makes it start"},{"line_number":11,"context_line":"using the admins client instead, considering that this is supposed"},{"line_number":12,"context_line":"to be an administrator action."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1916102"},{"line_number":15,"context_line":"Change-Id: Idd49e22c8dc534a1fe1e4814f233b079cf14bb72"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e9da2bba_f9860d2d","line":12,"range":{"start_line":6,"start_character":0,"end_line":12,"end_character":30},"in_reply_to":"8c6b512e_5c5050a5","updated":"2022-05-06 20:20:18.000000000","message":"Done","commit_id":"315b266a13ea5d24ec4f04e3985e6f923297df73"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c49f665274a22455bdd4464f549d2a811d4d5ab4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2022-05-05 16:33:12 -0300"},{"line_number":4,"context_line":"Commit:     silvacarloss \u003cces.eduardo98@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-05-06 14:55:15 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Perform list all sec services using admin client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We currently try to list all security services using the"},{"line_number":10,"context_line":"shares_client. This change switches that search and makes it start"},{"line_number":11,"context_line":"using the admins client instead, considering that this is supposed"},{"line_number":12,"context_line":"to be an administrator action."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1916102"},{"line_number":15,"context_line":"Change-Id: Idd49e22c8dc534a1fe1e4814f233b079cf14bb72"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8c6b512e_5c5050a5","line":12,"range":{"start_line":6,"start_character":0,"end_line":12,"end_character":30},"in_reply_to":"e40f6bd8_8b6e5a37","updated":"2022-05-06 20:20:05.000000000","message":"This is true! sorry I didn\u0027t pay attention to it before :p\nI just amended the changes really quick and didn\u0027t double check the commit message again :)","commit_id":"315b266a13ea5d24ec4f04e3985e6f923297df73"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f11ac75a90973eebd07a1a73775f996644d8ab10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2aa5063e_6a52a0ee","updated":"2022-05-06 19:53:49.000000000","message":"Sorry; didn\u0027t pay attention to the commit message in my earlier review..  ","commit_id":"315b266a13ea5d24ec4f04e3985e6f923297df73"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d618073e990869fcfca2404d5bbce58bd97e6eab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d478b4ab_8bd303d0","updated":"2022-05-06 19:51:35.000000000","message":"Thanks, LGTM!","commit_id":"315b266a13ea5d24ec4f04e3985e6f923297df73"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bca2be0e03bf59c9b826e4eda18764055c59a122","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d9802bd_9bfcbd87","updated":"2022-05-07 07:29:01.000000000","message":"LGTM, thank you Carlos","commit_id":"71caf46c021ed64ddf3a85a3b41c478ec2845795"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7bb5ad2831c74d8e994b5f087c2f19a623ad132c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"71cf01e7_56d9bc92","updated":"2022-07-15 12:05:25.000000000","message":"LGTM, thanks Carlos","commit_id":"71caf46c021ed64ddf3a85a3b41c478ec2845795"}],"manila_tempest_tests/tests/api/test_security_services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"85e5f1ff1f0311d87d4bb0211f6db4feb26f99a3","unresolved":true,"context_lines":[{"line_number":273,"context_line":"    @decorators.idempotent_id(\u0027d501710e-4710-4c13-a373-75ed6ababb13\u0027)"},{"line_number":274,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":275,"context_line":"    def test_try_list_security_services_all_tenants(self):"},{"line_number":276,"context_line":"        listed \u003d self.admin_shares_v2_client.list_security_services("},{"line_number":277,"context_line":"            params\u003d{\u0027all_tenants\u0027: 1})[\u0027security_services\u0027]"},{"line_number":278,"context_line":"        self.assertTrue(any(self.ss_ldap[\u0027id\u0027] \u003d\u003d ss[\u0027id\u0027] for ss in listed))"},{"line_number":279,"context_line":"        self.assertTrue(any(self.ss_kerberos[\u0027id\u0027] \u003d\u003d ss[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"53c65d01_a7c6e2fa","line":276,"range":{"start_line":276,"start_character":0,"end_line":276,"end_character":68},"updated":"2022-05-06 13:57:35.000000000","message":"if https://review.opendev.org/c/openstack/manila/+/832734 is changed to ignore the \"all_tenants\" key, this test case need not be modified.. but we can perhaps add a new security service right here created in a different project (\"alt_shares_v2_client\") and prove that \"all_tenants\" is being ignored..","commit_id":"03a1ffb51f2e277cc4d4b26f5004fcb84a943bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0f7181fd5cb222f8415a3809fe6e43db0847ad87","unresolved":true,"context_lines":[{"line_number":273,"context_line":"    @decorators.idempotent_id(\u0027d501710e-4710-4c13-a373-75ed6ababb13\u0027)"},{"line_number":274,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":275,"context_line":"    def test_try_list_security_services_all_tenants(self):"},{"line_number":276,"context_line":"        listed \u003d self.admin_shares_v2_client.list_security_services("},{"line_number":277,"context_line":"            params\u003d{\u0027all_tenants\u0027: 1})[\u0027security_services\u0027]"},{"line_number":278,"context_line":"        self.assertTrue(any(self.ss_ldap[\u0027id\u0027] \u003d\u003d ss[\u0027id\u0027] for ss in listed))"},{"line_number":279,"context_line":"        self.assertTrue(any(self.ss_kerberos[\u0027id\u0027] \u003d\u003d ss[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ccab7ed0_5f7beb69","line":276,"range":{"start_line":276,"start_character":0,"end_line":276,"end_character":68},"in_reply_to":"53c65d01_a7c6e2fa","updated":"2022-05-06 13:59:11.000000000","message":"the admin test already exists to test the \"all_tenants\" logic: https://github.com/openstack/manila-tempest-plugin/blob/86f2432476ba9128bb2c26a78ae3b3f53327d4bd/manila_tempest_tests/tests/api/admin/test_security_services.py#L50-L60","commit_id":"03a1ffb51f2e277cc4d4b26f5004fcb84a943bdf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f01c0d8301d744b4b651caa18ba1bc974526a7ef","unresolved":true,"context_lines":[{"line_number":273,"context_line":"    @decorators.idempotent_id(\u0027d501710e-4710-4c13-a373-75ed6ababb13\u0027)"},{"line_number":274,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":275,"context_line":"    def test_try_list_security_services_all_tenants(self):"},{"line_number":276,"context_line":"        listed \u003d self.admin_shares_v2_client.list_security_services("},{"line_number":277,"context_line":"            params\u003d{\u0027all_tenants\u0027: 1})[\u0027security_services\u0027]"},{"line_number":278,"context_line":"        self.assertTrue(any(self.ss_ldap[\u0027id\u0027] \u003d\u003d ss[\u0027id\u0027] for ss in listed))"},{"line_number":279,"context_line":"        self.assertTrue(any(self.ss_kerberos[\u0027id\u0027] \u003d\u003d ss[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"6c1f53d9_dbdcdc30","line":276,"range":{"start_line":276,"start_character":0,"end_line":276,"end_character":68},"in_reply_to":"ccab7ed0_5f7beb69","updated":"2022-05-06 14:04:10.000000000","message":"Okay, so I think it is worth it to modify this test only to prove that we can only see the security services we are supposed to","commit_id":"03a1ffb51f2e277cc4d4b26f5004fcb84a943bdf"}]}