)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9c47d6e2c26061a32f83b09d70cf3426346634b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b9bf4213_115d970d","updated":"2023-06-15 17:19:09.000000000","message":"Also, I think it would be nice to have a scenario test, as we do for share migration, where we would have instances, the share backup happening and we would be able to restore from the backup. Could you please take a look at it?","commit_id":"9e8eabeb70f26c3070fda65dd9af6be428434d58"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"54296b9df63434380836f700412f020b73d9c5de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d682606_a4e6981e","updated":"2023-06-15 17:17:19.000000000","message":"Hi, Kiran! Could you please rebase this change? And also get a more recent run for the tests?","commit_id":"9e8eabeb70f26c3070fda65dd9af6be428434d58"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"366753ae467a708b1fd943237067086d2d6d1b55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad2cbd25_ad544aec","updated":"2023-06-19 15:01:08.000000000","message":"recheck","commit_id":"0a6c1194543bebe47a685c2eb221815ee3c1e25e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f4fac54dd897c3833b255c5c3c0adc4bbaf53ef7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ea8c101e_1fc994d6","updated":"2023-07-06 12:29:15.000000000","message":"Added negative tests","commit_id":"e2fbc82ccf79c02b5ce61670c7a099014f8db1d1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1c5aa41102042a93075a5ac6d16e1d1e0c384f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"94b20133_aa148691","updated":"2023-07-07 11:54:01.000000000","message":"Thanks for the negative tests, please take a look at the comments.","commit_id":"e2fbc82ccf79c02b5ce61670c7a099014f8db1d1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1bd9725c3dd4bec43e91d113e080fa20242fa929","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7dbb4b1c_87f1576d","updated":"2023-07-17 17:37:35.000000000","message":"Hi Kiran, thank you for working on the tests... However, as indicated in the comments, the tests are not being run. Please enable the run share backups tests flag so the tests will be run.","commit_id":"33f8323c9e9e845ff7dd1babbded8b6fbcd7cc92"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"86a05651c0e360c9274c084be67504083528e310","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d56da20d_0cc52f1b","updated":"2023-08-09 11:57:56.000000000","message":"Added changes suggested in https://review.opendev.org/c/openstack/manila-tempest-plugin/+/890192.","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e779c68be40182190f75e027041e94bff3b4baa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9fcfa27a_52315669","updated":"2023-08-01 10:59:07.000000000","message":"Hi, Kiran! I was looking into the tests again","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775ba96de3b5e1a54896a34850fda1f462447b02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"11fa7d42_b02aac90","updated":"2023-08-01 11:29:16.000000000","message":"Thanks Kiran!","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0e1371131a0338ee5571ded72474887b8e3f03e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d5b8ea84_425b7cea","updated":"2023-07-19 11:41:06.000000000","message":"recheck\njob timed out even before tests ran.","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1881fdfe1ec578a5630043581b3f12b6ea6ac74a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bb39c860_3f2624db","updated":"2023-07-19 14:35:23.000000000","message":"share backup by default select manila-data (NFS driver) and it will not work until nfs backup location is provided in config file. It seems like during tempest tests run, instead of dummy driver(i,e. manila-share), backup create calls are going to manila-data.","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c135cb12017d010c06284b13d5fe17b58c974285","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fb43cdbd_f68820f7","in_reply_to":"876cec6d_eb20e3f0","updated":"2023-08-01 19:03:41.000000000","message":"It worked. The call went to the share/manager, and the dummy driver handled it. Please take a look at the comments I left and check the change I have proposed... You\u0027ll need to specity a driver_options or backup_options as we suggested in a call today. There are other issues going on, but they are related to the way tests were written... One of the issues will likely be sorted by fixing one of the Liron\u0027s suggestions: reusing the waiter.","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"769f4b3669b27eb721a6a2a80a5b4624bf7a03e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"876cec6d_eb20e3f0","in_reply_to":"9fcfa27a_52315669","updated":"2023-08-01 10:59:33.000000000","message":"... and attempted something PTAL","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e779c68be40182190f75e027041e94bff3b4baa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"65374993_3bcbb54e","in_reply_to":"bb39c860_3f2624db","updated":"2023-08-01 10:59:07.000000000","message":"Hi, I think if we want to test with dummy, we should forget the NFS driver for now. It can be useful in the LVM driver job or the ZFS. Instead, we need to make sure that the call is going to the driver. Looking at your change, I have realized that it will go to the share topic only when in the backup creation we specify a \u0027driver_option\u0027 in the request [1], so I proposed [2] to see if it will go through the dummy driver or not.\n\n[1] https://review.opendev.org/c/openstack/manila/+/343980/57/manila/share/api.py#3838\n[2] https://review.opendev.org/c/openstack/manila-tempest-plugin/+/890192","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e7a2bd7c369be180dfdfec5472e810e72ac64c59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c7d86bf7_c3e65b45","in_reply_to":"fb43cdbd_f68820f7","updated":"2023-08-01 19:04:17.000000000","message":"You can ensure the dummy driver received the call here: https://zuul.opendev.org/t/openstack/build/835bb61c4d404c16ad50310ef199fee6/log/controller/logs/screen-m-shr.txt?severity\u003d1#1360","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"88737161ce3532c1a2af9c05d80959952d5c4cd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ecc9d40b_7800b006","updated":"2023-08-10 13:01:45.000000000","message":"Thanks Kiran!\nPlease look at the manila-tempest-plugin-dummy-no-dhss gate failures.","commit_id":"fd8c9d978bb022d83ce80e6ff3f38605e92a7341"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"074f48d4d6cb6b06441fac78f2f62fbcc6b68ede","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9e7c6fd2_fff1aab0","updated":"2023-08-10 12:43:29.000000000","message":"https://zuul.opendev.org/t/openstack/build/a640171510c24ad28adbbea93f0fafc3/log/controller/logs/screen-m-shr.txt seems like backup was created fine and most likely update_interval needs to set to 1, similar to migration.","commit_id":"fd8c9d978bb022d83ce80e6ff3f38605e92a7341"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ac13ee3c_52ca585d","updated":"2023-08-18 22:56:23.000000000","message":"Thanks for working on this; as we\u0027ve discussed in the past, we merged the API changes to get you unblocked - we typically avoid merging API code changes without a good amount of API/functional testing with tempest.. as you can see, there are some bugs that your test code is uncovering. Since you have a pending patch to fix things up, it gives us a good opportunity to get most of the issues resolved, even if that means a bunch of back and forth. \n\nAre you able to test this change with a devstack environment?","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a436e7a65eb776e6c4765d3df30760c98dc6d902","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2e5fd195_da2fd306","updated":"2023-08-18 16:07:02.000000000","message":"first test test_create_share_backup is failing itself. From m-shr.log, seems like dummy driver not invoked to create backup.","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"74cae950_c057599a","in_reply_to":"2e5fd195_da2fd306","updated":"2023-08-18 22:56:23.000000000","message":"I\u0027d suggest debugging this in a local devstack. \nEvery request made in the tempest tests is logged in tempest.log: \n\nEach request has a request_id that you can grep for in the manila logs. For example, the \"create_backup\" call you\u0027re referencing is:\n\n\ntestr_results: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1ce/841015/12/check/manila-tempest-plugin-dummy-no-dhss/1ce3703/testr_results.html\n\ntempest.log: https://zuul.opendev.org/t/openstack/build/1ce37036a7ff4e21a563c7b6621c3b0b/log/controller/logs/tempest_log.txt#19523-19527\n\nmanila-api.log: https://zuul.opendev.org/t/openstack/build/1ce37036a7ff4e21a563c7b6621c3b0b/log/controller/logs/screen-m-api.txt#10319-10391\n\n\nAs you can see; the backup failed in the API; you have a bug in the server.","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e328f9b7_da265599","in_reply_to":"ac13ee3c_52ca585d","updated":"2023-08-25 14:28:00.000000000","message":"yes, devstack testing works fine tested with data service.","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"8d65e5aaf29e823c5345b09ff9f8fde0c4b9b999","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9609599b_aa0f4c9b","updated":"2023-08-22 13:42:10.000000000","message":"Thanks for this patch, Kiran. Few comments inline, let me know WDYT.","commit_id":"4f753ab31086f3bd4e2ebb410ec260bd6776755b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2d8885aca1ea77a975d424572a5f3fb752d505d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"af7295a3_040b5183","updated":"2023-08-25 20:36:33.000000000","message":"Thanks for working on this change. Please take a look in the comments inline :)","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"516966f3_8e49c437","updated":"2023-08-25 14:28:00.000000000","message":"recheck","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fc0192c7b9d6eb644efb08630b996cc42d7fb1f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"1aff4e22_4aa59dc8","updated":"2024-02-16 18:02:13.000000000","message":"LGTM, thank you for working on the tests","commit_id":"dc75f2728a3c6c8d959b1c89d65f7a38d6348479"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7abfb36ce621683f18545610da96c890aceb8e43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"a1f63da5_800cd9d4","updated":"2024-03-06 07:24:10.000000000","message":"LGTM!","commit_id":"edd82c73856bbce856e2d69be840062ae352c23b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55a11649aee77b1f858f41c0dd365b4ddfa658ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"b4af6ae0_9da3d342","updated":"2024-02-28 21:31:35.000000000","message":"LGTM, ty Kiran","commit_id":"edd82c73856bbce856e2d69be840062ae352c23b"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"6076d32d829755e045c4f4d03a0c2dd827b32e51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"92d1eb6f_bb5f1ba3","updated":"2024-03-01 11:35:34.000000000","message":"Looks good, verified. Thanks.","commit_id":"edd82c73856bbce856e2d69be840062ae352c23b"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775ba96de3b5e1a54896a34850fda1f462447b02","unresolved":true,"context_lines":[{"line_number":1864,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":1865,"context_line":"        return body"},{"line_number":1866,"context_line":""},{"line_number":1867,"context_line":"    def wait_for_share_backup_status(self, backup_id, status,"},{"line_number":1868,"context_line":"                                     version\u003dLATEST_MICROVERSION):"},{"line_number":1869,"context_line":"        \"\"\"Waits for a share to reach a given status\"\"\""},{"line_number":1870,"context_line":"        backup \u003d self.get_backup(backup_id, version\u003dversion)"},{"line_number":1871,"context_line":"        share_backup_timeout \u003d CONF.share.share_backup_timeout"},{"line_number":1872,"context_line":"        start \u003d int(time.time())"},{"line_number":1873,"context_line":"        while backup[\u0027status\u0027] !\u003d status:"},{"line_number":1874,"context_line":"            time.sleep(self.build_interval)"},{"line_number":1875,"context_line":"            backup \u003d self.get_backup(backup_id, version\u003dversion)"},{"line_number":1876,"context_line":"            backup_status \u003d backup[\u0027status\u0027]"},{"line_number":1877,"context_line":"            if backup_status \u003d\u003d status:"},{"line_number":1878,"context_line":"                return backup"},{"line_number":1879,"context_line":"            elif backup_status \u003d\u003d \u0027error\u0027:"},{"line_number":1880,"context_line":"                raise share_exceptions.ShareBackupException("},{"line_number":1881,"context_line":"                    backup_id\u003dbackup[\u0027id\u0027])"},{"line_number":1882,"context_line":"            elif int(time.time()) - start \u003e\u003d share_backup_timeout:"},{"line_number":1883,"context_line":"                message \u003d (\u0027Share backup %s failed to reach %s status \u0027"},{"line_number":1884,"context_line":"                           \u0027(current %s) within the required time (%s s).\u0027 %"},{"line_number":1885,"context_line":"                           (backup_id, status, backup_status,"},{"line_number":1886,"context_line":"                            self.build_timeout))"},{"line_number":1887,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":1888,"context_line":""},{"line_number":1889,"context_line":"################"},{"line_number":1890,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"74085057_4bc92d78","line":1887,"range":{"start_line":1867,"start_character":0,"end_line":1887,"end_character":58},"updated":"2023-08-01 11:29:16.000000000","message":"There is a common function for that purpose:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/common/waiters.py#L44","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"86a05651c0e360c9274c084be67504083528e310","unresolved":false,"context_lines":[{"line_number":1864,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":1865,"context_line":"        return body"},{"line_number":1866,"context_line":""},{"line_number":1867,"context_line":"    def wait_for_share_backup_status(self, backup_id, status,"},{"line_number":1868,"context_line":"                                     version\u003dLATEST_MICROVERSION):"},{"line_number":1869,"context_line":"        \"\"\"Waits for a share to reach a given status\"\"\""},{"line_number":1870,"context_line":"        backup \u003d self.get_backup(backup_id, version\u003dversion)"},{"line_number":1871,"context_line":"        share_backup_timeout \u003d CONF.share.share_backup_timeout"},{"line_number":1872,"context_line":"        start \u003d int(time.time())"},{"line_number":1873,"context_line":"        while backup[\u0027status\u0027] !\u003d status:"},{"line_number":1874,"context_line":"            time.sleep(self.build_interval)"},{"line_number":1875,"context_line":"            backup \u003d self.get_backup(backup_id, version\u003dversion)"},{"line_number":1876,"context_line":"            backup_status \u003d backup[\u0027status\u0027]"},{"line_number":1877,"context_line":"            if backup_status \u003d\u003d status:"},{"line_number":1878,"context_line":"                return backup"},{"line_number":1879,"context_line":"            elif backup_status \u003d\u003d \u0027error\u0027:"},{"line_number":1880,"context_line":"                raise share_exceptions.ShareBackupException("},{"line_number":1881,"context_line":"                    backup_id\u003dbackup[\u0027id\u0027])"},{"line_number":1882,"context_line":"            elif int(time.time()) - start \u003e\u003d share_backup_timeout:"},{"line_number":1883,"context_line":"                message \u003d (\u0027Share backup %s failed to reach %s status \u0027"},{"line_number":1884,"context_line":"                           \u0027(current %s) within the required time (%s s).\u0027 %"},{"line_number":1885,"context_line":"                           (backup_id, status, backup_status,"},{"line_number":1886,"context_line":"                            self.build_timeout))"},{"line_number":1887,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":1888,"context_line":""},{"line_number":1889,"context_line":"################"},{"line_number":1890,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ad5cdc54_30a189a0","line":1887,"range":{"start_line":1867,"start_character":0,"end_line":1887,"end_character":58},"in_reply_to":"74085057_4bc92d78","updated":"2023-08-09 11:57:56.000000000","message":"Done","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":1863,"context_line":"                              headers\u003dEXPERIMENTAL,"},{"line_number":1864,"context_line":"                              extra_headers\u003dTrue,"},{"line_number":1865,"context_line":"                              version\u003dversion)"},{"line_number":1866,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":1867,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"################"}],"source_content_type":"text/x-python","patch_set":12,"id":"6e737dce_f8e27c7c","line":1866,"range":{"start_line":1866,"start_character":8,"end_line":1866,"end_character":47},"updated":"2023-08-18 22:56:23.000000000","message":"this is an incorrect response code for an \"update\" operation. The update is done synchronously - we should be responding with HTTP200. \n\nso this: https://github.com/openstack/manila/blob/a93a844398a11a8a85f204782fb9456f7caccdbe/manila/api/v2/share_backups.py#L193 is a bug. Please fix it to HTTP 200.","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":1863,"context_line":"                              headers\u003dEXPERIMENTAL,"},{"line_number":1864,"context_line":"                              extra_headers\u003dTrue,"},{"line_number":1865,"context_line":"                              version\u003dversion)"},{"line_number":1866,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":1867,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"################"}],"source_content_type":"text/x-python","patch_set":12,"id":"67340330_f9461e8c","line":1866,"range":{"start_line":1866,"start_character":8,"end_line":1866,"end_character":47},"in_reply_to":"6e737dce_f8e27c7c","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"8d65e5aaf29e823c5345b09ff9f8fde0c4b9b999","unresolved":true,"context_lines":[{"line_number":1803,"context_line":"        body \u003d json.loads(body)"},{"line_number":1804,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"    def create_share_backup(self, share_id, name\u003dNone, description\u003dNone,"},{"line_number":1807,"context_line":"                            backup_options\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":1808,"context_line":"        if name is None:"},{"line_number":1809,"context_line":"            name \u003d data_utils.rand_name(\"tempest-created-share-backup\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"d5319b14_bd67053e","line":1806,"updated":"2023-08-22 13:42:10.000000000","message":"Please, add the method doc as done in the others.","commit_id":"4f753ab31086f3bd4e2ebb410ec260bd6776755b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":1803,"context_line":"        body \u003d json.loads(body)"},{"line_number":1804,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"    def create_share_backup(self, share_id, name\u003dNone, description\u003dNone,"},{"line_number":1807,"context_line":"                            backup_options\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":1808,"context_line":"        if name is None:"},{"line_number":1809,"context_line":"            name \u003d data_utils.rand_name(\"tempest-created-share-backup\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"607d9a57_4d30c14d","line":1806,"in_reply_to":"d5319b14_bd67053e","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"4f753ab31086f3bd4e2ebb410ec260bd6776755b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2d8885aca1ea77a975d424572a5f3fb752d505d","unresolved":true,"context_lines":[{"line_number":1796,"context_line":"    def list_share_backups(self, share_id\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":1797,"context_line":"        \"\"\"Get list of backups.\"\"\""},{"line_number":1798,"context_line":"        uri \u003d \"share-backups/detail\""},{"line_number":1799,"context_line":"        uri +\u003d (\"?share_id\u003d%s\" % share_id) if share_id is not None else \u0027\u0027"},{"line_number":1800,"context_line":"        resp, body \u003d self.get(uri, headers\u003dEXPERIMENTAL,"},{"line_number":1801,"context_line":"                              extra_headers\u003dTrue, version\u003dversion)"},{"line_number":1802,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":14,"id":"86cc2ddc_a7b53b0a","line":1799,"range":{"start_line":1799,"start_character":55,"end_line":1799,"end_character":66},"updated":"2023-08-25 20:36:33.000000000","message":"this is a bit redundant, it can be dropped","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9e596051270ca93da7dbe49aed6187e90c5886d2","unresolved":false,"context_lines":[{"line_number":1796,"context_line":"    def list_share_backups(self, share_id\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":1797,"context_line":"        \"\"\"Get list of backups.\"\"\""},{"line_number":1798,"context_line":"        uri \u003d \"share-backups/detail\""},{"line_number":1799,"context_line":"        uri +\u003d (\"?share_id\u003d%s\" % share_id) if share_id is not None else \u0027\u0027"},{"line_number":1800,"context_line":"        resp, body \u003d self.get(uri, headers\u003dEXPERIMENTAL,"},{"line_number":1801,"context_line":"                              extra_headers\u003dTrue, version\u003dversion)"},{"line_number":1802,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bf999cf9_8e36d737","line":1799,"range":{"start_line":1799,"start_character":55,"end_line":1799,"end_character":66},"in_reply_to":"86cc2ddc_a7b53b0a","updated":"2023-08-26 14:07:36.000000000","message":"Done","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2d8885aca1ea77a975d424572a5f3fb752d505d","unresolved":true,"context_lines":[{"line_number":1806,"context_line":"    def create_share_backup(self, share_id, name\u003dNone, description\u003dNone,"},{"line_number":1807,"context_line":"                            backup_options\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":1808,"context_line":"        \"\"\"Create a share backup.\"\"\""},{"line_number":1809,"context_line":"        if name is None:"},{"line_number":1810,"context_line":"            name \u003d data_utils.rand_name(\"tempest-created-share-backup\")"},{"line_number":1811,"context_line":"        if description is None:"},{"line_number":1812,"context_line":"            description \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":14,"id":"c17c6534_0b3978ff","line":1809,"range":{"start_line":1809,"start_character":11,"end_line":1809,"end_character":23},"updated":"2023-08-25 20:36:33.000000000","message":"if not name?\n\nif \u0027\u0027 is passed as name arg, it would fail this validation","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"afcfb345c55042d1b8ed58a559c43e162ad7935a","unresolved":false,"context_lines":[{"line_number":1806,"context_line":"    def create_share_backup(self, share_id, name\u003dNone, description\u003dNone,"},{"line_number":1807,"context_line":"                            backup_options\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":1808,"context_line":"        \"\"\"Create a share backup.\"\"\""},{"line_number":1809,"context_line":"        if name is None:"},{"line_number":1810,"context_line":"            name \u003d data_utils.rand_name(\"tempest-created-share-backup\")"},{"line_number":1811,"context_line":"        if description is None:"},{"line_number":1812,"context_line":"            description \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":14,"id":"db4b1dc9_59f86ed4","line":1809,"range":{"start_line":1809,"start_character":11,"end_line":1809,"end_character":23},"in_reply_to":"2ad8a1bb_cb05b5cd","updated":"2023-09-19 12:20:24.000000000","message":"Done","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9e596051270ca93da7dbe49aed6187e90c5886d2","unresolved":true,"context_lines":[{"line_number":1806,"context_line":"    def create_share_backup(self, share_id, name\u003dNone, description\u003dNone,"},{"line_number":1807,"context_line":"                            backup_options\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":1808,"context_line":"        \"\"\"Create a share backup.\"\"\""},{"line_number":1809,"context_line":"        if name is None:"},{"line_number":1810,"context_line":"            name \u003d data_utils.rand_name(\"tempest-created-share-backup\")"},{"line_number":1811,"context_line":"        if description is None:"},{"line_number":1812,"context_line":"            description \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":14,"id":"2ad8a1bb_cb05b5cd","line":1809,"range":{"start_line":1809,"start_character":11,"end_line":1809,"end_character":23},"in_reply_to":"c17c6534_0b3978ff","updated":"2023-08-26 14:07:36.000000000","message":"this is inherited from other implementation e.g. create_share, create_snapshot. As a tempest user, we hardcode names else auto generate. Why \u0027*\u0027 validation matters here ?","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2d8885aca1ea77a975d424572a5f3fb752d505d","unresolved":true,"context_lines":[{"line_number":1808,"context_line":"        \"\"\"Create a share backup.\"\"\""},{"line_number":1809,"context_line":"        if name is None:"},{"line_number":1810,"context_line":"            name \u003d data_utils.rand_name(\"tempest-created-share-backup\")"},{"line_number":1811,"context_line":"        if description is None:"},{"line_number":1812,"context_line":"            description \u003d data_utils.rand_name("},{"line_number":1813,"context_line":"                \"tempest-created-share-backup-desc\")"},{"line_number":1814,"context_line":"        post_body \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"c4e0fc1e_daf41eb5","line":1811,"range":{"start_line":1811,"start_character":8,"end_line":1811,"end_character":31},"updated":"2023-08-25 20:36:33.000000000","message":"same","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9e596051270ca93da7dbe49aed6187e90c5886d2","unresolved":false,"context_lines":[{"line_number":1808,"context_line":"        \"\"\"Create a share backup.\"\"\""},{"line_number":1809,"context_line":"        if name is None:"},{"line_number":1810,"context_line":"            name \u003d data_utils.rand_name(\"tempest-created-share-backup\")"},{"line_number":1811,"context_line":"        if description is None:"},{"line_number":1812,"context_line":"            description \u003d data_utils.rand_name("},{"line_number":1813,"context_line":"                \"tempest-created-share-backup-desc\")"},{"line_number":1814,"context_line":"        post_body \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"244cb951_16072101","line":1811,"range":{"start_line":1811,"start_character":8,"end_line":1811,"end_character":31},"in_reply_to":"c4e0fc1e_daf41eb5","updated":"2023-08-26 14:07:36.000000000","message":"Done","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fc0192c7b9d6eb644efb08630b996cc42d7fb1f8","unresolved":true,"context_lines":[{"line_number":1852,"context_line":"        \"\"\"Get list of backups.\"\"\""},{"line_number":1853,"context_line":"        uri \u003d \"share-backups/detail\""},{"line_number":1854,"context_line":"        if share_id:"},{"line_number":1855,"context_line":"            uri +\u003d (\"?share_id\u003d%s\" % share_id)"},{"line_number":1856,"context_line":"        resp, body \u003d self.get(uri, headers\u003dEXPERIMENTAL,"},{"line_number":1857,"context_line":"                              extra_headers\u003dTrue, version\u003dversion)"},{"line_number":1858,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":27,"id":"a6f04152_f74c08b4","line":1855,"range":{"start_line":1855,"start_character":19,"end_line":1855,"end_character":46},"updated":"2024-02-16 18:02:13.000000000","message":"nit: f strings would make it more readable:\nf\u0027?share_id\u003d{share_id}\u0027","commit_id":"dc75f2728a3c6c8d959b1c89d65f7a38d6348479"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f776610435c8e038899deed99e811ac48cd4ed90","unresolved":false,"context_lines":[{"line_number":1852,"context_line":"        \"\"\"Get list of backups.\"\"\""},{"line_number":1853,"context_line":"        uri \u003d \"share-backups/detail\""},{"line_number":1854,"context_line":"        if share_id:"},{"line_number":1855,"context_line":"            uri +\u003d (\"?share_id\u003d%s\" % share_id)"},{"line_number":1856,"context_line":"        resp, body \u003d self.get(uri, headers\u003dEXPERIMENTAL,"},{"line_number":1857,"context_line":"                              extra_headers\u003dTrue, version\u003dversion)"},{"line_number":1858,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":27,"id":"a9367a24_5fc1a7de","line":1855,"range":{"start_line":1855,"start_character":19,"end_line":1855,"end_character":46},"in_reply_to":"a6f04152_f74c08b4","updated":"2024-02-22 09:02:39.000000000","message":"Done","commit_id":"dc75f2728a3c6c8d959b1c89d65f7a38d6348479"}],"manila_tempest_tests/share_exceptions.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"8d65e5aaf29e823c5345b09ff9f8fde0c4b9b999","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               \"status\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class ShareBackupException(exceptions.TempestException):"},{"line_number":92,"context_line":"    message \u003d (\"Share backup %(backup_id)s failed and is in ERROR status\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"98a89a08_3c245e73","line":91,"updated":"2023-08-22 13:42:10.000000000","message":"nit: Sorry, but I didn\u0027t find where this exception is used. Can you point to me? Also, for what operation is this? Is for any Share backup operation (e.g., create, delete, restore...)? I think it would be good indicate what share backup operation failed to make debug easier.","commit_id":"4f753ab31086f3bd4e2ebb410ec260bd6776755b"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"88737161ce3532c1a2af9c05d80959952d5c4cd0","unresolved":true,"context_lines":[{"line_number":711,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":712,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":713,"context_line":"        backup_options \u003d {\u0027dummy\u0027: True}"},{"line_number":714,"context_line":"        backup \u003d client.create_share_backup(share_id, name\u003dbackup_name,"},{"line_number":715,"context_line":"                                            backup_options\u003dbackup_options)"},{"line_number":716,"context_line":"        resource \u003d {"},{"line_number":717,"context_line":"            \"type\": \"backup\","},{"line_number":718,"context_line":"            \"id\": backup[\"id\"],"}],"source_content_type":"text/x-python","patch_set":10,"id":"39d93700_468bf019","line":715,"range":{"start_line":714,"start_character":17,"end_line":715,"end_character":74},"updated":"2023-08-10 13:01:45.000000000","message":"I guess \"share_backup\" key is missing:\nclient.create_share_backup(share_id, name\u003dbackup_name,                                            backup_options\u003dbackup_options)[\u0027share_backup\u0027]","commit_id":"fd8c9d978bb022d83ce80e6ff3f38605e92a7341"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3b25b7b3edffa69df4f91dda2e303e0ab7b5425c","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":712,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":713,"context_line":"        backup_options \u003d {\u0027dummy\u0027: True}"},{"line_number":714,"context_line":"        backup \u003d client.create_share_backup(share_id, name\u003dbackup_name,"},{"line_number":715,"context_line":"                                            backup_options\u003dbackup_options)"},{"line_number":716,"context_line":"        resource \u003d {"},{"line_number":717,"context_line":"            \"type\": \"backup\","},{"line_number":718,"context_line":"            \"id\": backup[\"id\"],"}],"source_content_type":"text/x-python","patch_set":10,"id":"72cd8109_a32ed625","line":715,"range":{"start_line":714,"start_character":17,"end_line":715,"end_character":74},"in_reply_to":"39d93700_468bf019","updated":"2023-08-18 14:03:42.000000000","message":"Done","commit_id":"fd8c9d978bb022d83ce80e6ff3f38605e92a7341"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":710,"context_line":"                                      version\u003dCONF.share.max_api_microversion):"},{"line_number":711,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":712,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":713,"context_line":"        backup_options \u003d {\u0027dummy\u0027: True}"},{"line_number":714,"context_line":"        backup \u003d client.create_share_backup("},{"line_number":715,"context_line":"            share_id,"},{"line_number":716,"context_line":"            name\u003dbackup_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"86ff091b_80145dcb","line":713,"range":{"start_line":713,"start_character":8,"end_line":713,"end_character":40},"updated":"2023-08-18 22:56:23.000000000","message":"This needs to come from configuration; not hard coded like this. You\u0027ll want to test two backup scenarios with tempest tests:\n\n1) Generic backup assisted by the data service\n2) \"Advantaged\" backup facilitated by the share backend driver. \n\nMigration is a similar feature that we test via tempest tests. Migration supports two separate test modes: \"host-assisted\" migration (similar to backup option 1) and \"driver-assisted\" migration (similar to backup option 2). In order to test these two modes, we have two separate config options:\n\nhttps://github.com/openstack/manila-tempest-plugin/blob/8d4a2decf09b91787515515294063d703e5c2a2a/manila_tempest_tests/config.py#L256-L263\n\n\nSo i would suggest implementing two separate tests, triggered via separate config opts. \n\nso instead of \"run_backup_tests\", you can have:\n\n\n\"run_host_assisted_backup_tests\" - when enabled, no driver_options are passed\n\"run_driver_assisted_backup_tests\" - when enabled, driver_options can be provided optionally:\n\n\"driver_assisted_backup_test_driver_options\" - this can default to {\u0027dummy\u0027: True}\n\neventually, if you were to support backup options in one of the drivers other than the dummy driver, the respective CI job can set this option appropriately.","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"afcfb345c55042d1b8ed58a559c43e162ad7935a","unresolved":false,"context_lines":[{"line_number":710,"context_line":"                                      version\u003dCONF.share.max_api_microversion):"},{"line_number":711,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":712,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":713,"context_line":"        backup_options \u003d {\u0027dummy\u0027: True}"},{"line_number":714,"context_line":"        backup \u003d client.create_share_backup("},{"line_number":715,"context_line":"            share_id,"},{"line_number":716,"context_line":"            name\u003dbackup_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"cf82e09a_d7b95e68","line":713,"range":{"start_line":713,"start_character":8,"end_line":713,"end_character":40},"in_reply_to":"5914af7a_45c33a40","updated":"2023-09-19 12:20:24.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":true,"context_lines":[{"line_number":710,"context_line":"                                      version\u003dCONF.share.max_api_microversion):"},{"line_number":711,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":712,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":713,"context_line":"        backup_options \u003d {\u0027dummy\u0027: True}"},{"line_number":714,"context_line":"        backup \u003d client.create_share_backup("},{"line_number":715,"context_line":"            share_id,"},{"line_number":716,"context_line":"            name\u003dbackup_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5914af7a_45c33a40","line":713,"range":{"start_line":713,"start_character":8,"end_line":713,"end_character":40},"in_reply_to":"86ff091b_80145dcb","updated":"2023-08-25 14:28:00.000000000","message":"to test host assisted backup, we need to have some backup location. I am not sure, how to provision it as part of CI config. For now, I have renamed run_backup_tests to run_driver_assisted_backup_tests","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2d8885aca1ea77a975d424572a5f3fb752d505d","unresolved":true,"context_lines":[{"line_number":725,"context_line":"        else:"},{"line_number":726,"context_line":"            cls.method_resources.insert(0, resource)"},{"line_number":727,"context_line":"        waiters.wait_for_resource_status(client, backup[\"id\"], \"available\","},{"line_number":728,"context_line":"                                         resource_name\u003d\u0027backup\u0027)"},{"line_number":729,"context_line":"        return backup"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"f22bae8e_b5582239","line":728,"range":{"start_line":728,"start_character":41,"end_line":728,"end_character":63},"updated":"2023-08-25 20:36:33.000000000","message":"as per the test failures [1], backup resource type should be implemented in the wait_for_resource_status method\n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_721/841015/14/check/manila-tempest-plugin-dummy-no-dhss/72108ca/testr_results.html","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9e596051270ca93da7dbe49aed6187e90c5886d2","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        else:"},{"line_number":726,"context_line":"            cls.method_resources.insert(0, resource)"},{"line_number":727,"context_line":"        waiters.wait_for_resource_status(client, backup[\"id\"], \"available\","},{"line_number":728,"context_line":"                                         resource_name\u003d\u0027backup\u0027)"},{"line_number":729,"context_line":"        return backup"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"5ba93fb6_d9e6dc2c","line":728,"range":{"start_line":728,"start_character":41,"end_line":728,"end_character":63},"in_reply_to":"f22bae8e_b5582239","updated":"2023-08-26 14:07:36.000000000","message":"fixed.","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"}],"manila_tempest_tests/tests/api/test_backup.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1c5aa41102042a93075a5ac6d16e1d1e0c384f00","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        share \u003d cls.create_share(cls.protocol)"},{"line_number":44,"context_line":"        cls.share \u003d cls.shares_client.get_share(share[\u0027id\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.idempotent_id(\u002758c36c97-faf4-4fec-9a9b-7cff0d2035cd\u0027)"},{"line_number":47,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":48,"context_line":"    def test_create_delete_share_backup(self):"},{"line_number":49,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":50,"context_line":"        backup \u003d self.shares_v2_client.create_share_backup("},{"line_number":51,"context_line":"            self.share[\u0027id\u0027], name\u003dbackup_name)"},{"line_number":52,"context_line":"        self.shares_v2_client.wait_for_share_backup_status("},{"line_number":53,"context_line":"            backup[\u0027id\u0027], \u0027available\u0027)"},{"line_number":54,"context_line":"        self.assertEqual(backup_name, backup[\u0027display_name\u0027])"},{"line_number":55,"context_line":"        # Verify backup create API response"},{"line_number":56,"context_line":"        expected_keys \u003d [\"id\", \"share_id\", \"availability_zone\", \"created_at\","},{"line_number":57,"context_line":"                         \"host\", \"topic\", \"status\", \"updated_at\", \"user_id\","},{"line_number":58,"context_line":"                         \"project_id\", \"size\", \"store\","},{"line_number":59,"context_line":"                         \"display_name\", \"display_description\"]"},{"line_number":60,"context_line":"        actual_keys \u003d backup.keys()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Strict key check"},{"line_number":63,"context_line":"        self.assertEqual(set(expected_keys), set(actual_keys))"},{"line_number":64,"context_line":"        actual_backup \u003d self.shares_v2_client.get_backup(backup[\u0027id\u0027])"},{"line_number":65,"context_line":"        self.assertEqual(backup[\u0027id\u0027], actual_backup[\u0027id\u0027])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Restore share backup"},{"line_number":68,"context_line":"        restore \u003d self.shares_v2_client.restore_share_backup(backup[\u0027id\u0027])"},{"line_number":69,"context_line":"        self.shares_v2_client.wait_for_share_backup_status("},{"line_number":70,"context_line":"            backup[\u0027id\u0027], \u0027available\u0027)"},{"line_number":71,"context_line":"        self.assertEqual(restore[\u0027share_id\u0027], self.share[\u0027id\u0027])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Delete share backup"},{"line_number":74,"context_line":"        self.shares_v2_client.delete_share_backup(backup[\u0027id\u0027])"},{"line_number":75,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":76,"context_line":"                          self.shares_v2_client.get_backup,"},{"line_number":77,"context_line":"                          backup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ecd2850e_161c0995","line":77,"range":{"start_line":46,"start_character":4,"end_line":77,"end_character":39},"updated":"2023-07-07 11:54:01.000000000","message":"I think this test should be splitted... It\u0027s looking like a scenario test. We should be testing the APIs individually. Scenario tests are the ones where we complete the entire scenario of a feature, while in the API, we test the behavior of the APIs individually. That makes it easier to isolate possible issues.\n\nSo:\ncreate_share_backups could be combined with get_backup\nget_all_backups should be another separate test\ndelete_backup should be another separate test\nrestore backup should be anothher separate test\nupdate should be another test","commit_id":"e2fbc82ccf79c02b5ce61670c7a099014f8db1d1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"dc3a649fb56cfc883b8f8f06be2d6c4e8747b48f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        share \u003d cls.create_share(cls.protocol)"},{"line_number":44,"context_line":"        cls.share \u003d cls.shares_client.get_share(share[\u0027id\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.idempotent_id(\u002758c36c97-faf4-4fec-9a9b-7cff0d2035cd\u0027)"},{"line_number":47,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":48,"context_line":"    def test_create_delete_share_backup(self):"},{"line_number":49,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":50,"context_line":"        backup \u003d self.shares_v2_client.create_share_backup("},{"line_number":51,"context_line":"            self.share[\u0027id\u0027], name\u003dbackup_name)"},{"line_number":52,"context_line":"        self.shares_v2_client.wait_for_share_backup_status("},{"line_number":53,"context_line":"            backup[\u0027id\u0027], \u0027available\u0027)"},{"line_number":54,"context_line":"        self.assertEqual(backup_name, backup[\u0027display_name\u0027])"},{"line_number":55,"context_line":"        # Verify backup create API response"},{"line_number":56,"context_line":"        expected_keys \u003d [\"id\", \"share_id\", \"availability_zone\", \"created_at\","},{"line_number":57,"context_line":"                         \"host\", \"topic\", \"status\", \"updated_at\", \"user_id\","},{"line_number":58,"context_line":"                         \"project_id\", \"size\", \"store\","},{"line_number":59,"context_line":"                         \"display_name\", \"display_description\"]"},{"line_number":60,"context_line":"        actual_keys \u003d backup.keys()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Strict key check"},{"line_number":63,"context_line":"        self.assertEqual(set(expected_keys), set(actual_keys))"},{"line_number":64,"context_line":"        actual_backup \u003d self.shares_v2_client.get_backup(backup[\u0027id\u0027])"},{"line_number":65,"context_line":"        self.assertEqual(backup[\u0027id\u0027], actual_backup[\u0027id\u0027])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Restore share backup"},{"line_number":68,"context_line":"        restore \u003d self.shares_v2_client.restore_share_backup(backup[\u0027id\u0027])"},{"line_number":69,"context_line":"        self.shares_v2_client.wait_for_share_backup_status("},{"line_number":70,"context_line":"            backup[\u0027id\u0027], \u0027available\u0027)"},{"line_number":71,"context_line":"        self.assertEqual(restore[\u0027share_id\u0027], self.share[\u0027id\u0027])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Delete share backup"},{"line_number":74,"context_line":"        self.shares_v2_client.delete_share_backup(backup[\u0027id\u0027])"},{"line_number":75,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":76,"context_line":"                          self.shares_v2_client.get_backup,"},{"line_number":77,"context_line":"                          backup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"73f80ec6_4b898502","line":77,"range":{"start_line":46,"start_character":4,"end_line":77,"end_character":39},"in_reply_to":"ecd2850e_161c0995","updated":"2023-07-19 14:36:09.000000000","message":"Done","commit_id":"e2fbc82ccf79c02b5ce61670c7a099014f8db1d1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1bd9725c3dd4bec43e91d113e080fa20242fa929","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def skip_checks(cls):"},{"line_number":34,"context_line":"        super(ShareBackupTest, cls).skip_checks()"},{"line_number":35,"context_line":"        if not CONF.share.run_share_backup_tests:"},{"line_number":36,"context_line":"            raise cls.skipException(\"Share backup tests are disabled.\")"},{"line_number":37,"context_line":"        utils.check_skip_if_microversion_not_supported("},{"line_number":38,"context_line":"            _MIN_SUPPORTED_MICROVERSION)"}],"source_content_type":"text/x-python","patch_set":5,"id":"4e36291e_eab0793d","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":49},"updated":"2023-07-17 17:37:35.000000000","message":"The tests are never being run [1], you need to set this flag to true. You can do so here [2]. You will need to set: run_share_backup_tests: true\n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a30/841015/5/check/manila-tempest-plugin-dummy-dhss/a306f29/testr_results.html\n[2] https://github.com/openstack/manila-tempest-plugin/blob/master/zuul.d/manila-tempest-jobs.yaml#L540","commit_id":"33f8323c9e9e845ff7dd1babbded8b6fbcd7cc92"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"dc3a649fb56cfc883b8f8f06be2d6c4e8747b48f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def skip_checks(cls):"},{"line_number":34,"context_line":"        super(ShareBackupTest, cls).skip_checks()"},{"line_number":35,"context_line":"        if not CONF.share.run_share_backup_tests:"},{"line_number":36,"context_line":"            raise cls.skipException(\"Share backup tests are disabled.\")"},{"line_number":37,"context_line":"        utils.check_skip_if_microversion_not_supported("},{"line_number":38,"context_line":"            _MIN_SUPPORTED_MICROVERSION)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1b7d46f4_d952cf3c","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":49},"in_reply_to":"4e36291e_eab0793d","updated":"2023-07-19 14:36:09.000000000","message":"Done","commit_id":"33f8323c9e9e845ff7dd1babbded8b6fbcd7cc92"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775ba96de3b5e1a54896a34850fda1f462447b02","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ShareBackupTest(base.BaseSharesMixedTest):"},{"line_number":31,"context_line":"    protocol \u003d \"nfs\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"f8657372_849e803c","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":20},"updated":"2023-08-01 11:29:16.000000000","message":"Is it only supported in this protocol ?","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"bc01d5c4b85948952d29958d7b704a830f2f341b","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ShareBackupTest(base.BaseSharesMixedTest):"},{"line_number":31,"context_line":"    protocol \u003d \"nfs\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3e47ba4c_36a3df72","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":20},"in_reply_to":"ea1a6c39_b95b5ea1","updated":"2023-08-10 12:55:49.000000000","message":"If it\u0027s supported by another protocols, you need to create additional classes for each protocol.\nplease see example here:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/api/admin/test_share_manage.py#L175","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"86a05651c0e360c9274c084be67504083528e310","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ShareBackupTest(base.BaseSharesMixedTest):"},{"line_number":31,"context_line":"    protocol \u003d \"nfs\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ea1a6c39_b95b5ea1","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":20},"in_reply_to":"f8657372_849e803c","updated":"2023-08-09 11:57:56.000000000","message":"this is used to create share. Since its the way used in other files, I replicated the same.","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775ba96de3b5e1a54896a34850fda1f462447b02","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareBackupTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"}],"source_content_type":"text/x-python","patch_set":8,"id":"6d0cdeec_b69d4c29","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":12},"updated":"2023-08-01 11:29:16.000000000","message":"It shouldn\u0027t be an instance variable.","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"86a05651c0e360c9274c084be67504083528e310","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareBackupTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"}],"source_content_type":"text/x-python","patch_set":8,"id":"42f5ad19_ea71f111","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":12},"in_reply_to":"6d0cdeec_b69d4c29","updated":"2023-08-09 11:57:56.000000000","message":"Done","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775ba96de3b5e1a54896a34850fda1f462447b02","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareBackupTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"},{"line_number":48,"context_line":"                                     share_type_id\u003dcls.share_type_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5d8e7671_22c064c9","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":11},"updated":"2023-08-01 11:29:16.000000000","message":"same","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"86a05651c0e360c9274c084be67504083528e310","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareBackupTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"},{"line_number":48,"context_line":"                                     share_type_id\u003dcls.share_type_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b47dc16d_b4eb1f6d","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":11},"in_reply_to":"5d8e7671_22c064c9","updated":"2023-08-09 11:57:56.000000000","message":"Done","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775ba96de3b5e1a54896a34850fda1f462447b02","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"},{"line_number":48,"context_line":"                                     share_type_id\u003dcls.share_type_id)"},{"line_number":49,"context_line":"        cls.share_id \u003d cls.share[\"id\"]"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3d9d663d_a31534fc","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":11},"updated":"2023-08-01 11:29:16.000000000","message":"same","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"86a05651c0e360c9274c084be67504083528e310","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        cls.share \u003d cls.create_share(cls.protocol,"},{"line_number":48,"context_line":"                                     share_type_id\u003dcls.share_type_id)"},{"line_number":49,"context_line":"        cls.share_id \u003d cls.share[\"id\"]"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"c9957f8b_0dcea37c","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":11},"in_reply_to":"3d9d663d_a31534fc","updated":"2023-08-09 11:57:56.000000000","message":"Done","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775ba96de3b5e1a54896a34850fda1f462447b02","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":53,"context_line":"    def test_create_share_backup(self):"},{"line_number":54,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":55,"context_line":"        backup \u003d self.shares_v2_client.create_share_backup("},{"line_number":56,"context_line":"            self.share_id, name\u003dbackup_name)"},{"line_number":57,"context_line":"        self.shares_v2_client.wait_for_share_backup_status("},{"line_number":58,"context_line":"            backup[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"89c49820_34860a9f","line":55,"range":{"start_line":55,"start_character":22,"end_line":55,"end_character":58},"updated":"2023-08-01 11:29:16.000000000","message":"Please add a new helper method for backup creation under base module.","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"86a05651c0e360c9274c084be67504083528e310","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":53,"context_line":"    def test_create_share_backup(self):"},{"line_number":54,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":55,"context_line":"        backup \u003d self.shares_v2_client.create_share_backup("},{"line_number":56,"context_line":"            self.share_id, name\u003dbackup_name)"},{"line_number":57,"context_line":"        self.shares_v2_client.wait_for_share_backup_status("},{"line_number":58,"context_line":"            backup[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b597d44d_586f73ad","line":55,"range":{"start_line":55,"start_character":22,"end_line":55,"end_character":58},"in_reply_to":"89c49820_34860a9f","updated":"2023-08-09 11:57:56.000000000","message":"Done","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareBackupTest(base.BaseSharesMixedTest):"},{"line_number":32,"context_line":"    protocol \u003d \"nfs\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"d81c6453_b3826fd2","line":32,"range":{"start_line":32,"start_character":3,"end_line":32,"end_character":20},"updated":"2023-08-18 22:56:23.000000000","message":"Does it matter what protocol you use? Backup must be agnostic, correct? I understand host assisted backup is limited to NFS right now.. but, driver assisted backup can be any share of any protocol, correct?\n\nSo instead of overriding the protocol like this, just remove this and use self.shares_v2_client.share_protocol (this will be the first defined protocol in the config listopt \"enable_protocols\") [1]\n\n[1] https://github.com/openstack/manila-tempest-plugin/blob/d62b5dcf51e8b9824ddc279a73ee4d03ee23d0b2/manila_tempest_tests/services/share/json/shares_client.py#L40-L41","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareBackupTest(base.BaseSharesMixedTest):"},{"line_number":32,"context_line":"    protocol \u003d \"nfs\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"e0bbde25_914865f0","line":32,"range":{"start_line":32,"start_character":3,"end_line":32,"end_character":20},"in_reply_to":"d81c6453_b3826fd2","updated":"2023-08-25 14:28:00.000000000","message":"yes, protocol does not matter since its applicable for share. The implementation is  mostly carried from other source files. Updated","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        share_type \u003d cls.create_share_type()"},{"line_number":46,"context_line":"        share_type_id \u003d share_type[\u0027id\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        share \u003d cls.create_share(cls.protocol, share_type_id\u003dshare_type_id)"},{"line_number":49,"context_line":"        cls.share_id \u003d share[\"id\"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u002712c36c97-faf4-4fec-9a9b-7cff0d2035cd\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"2d99cc5f_01720948","line":48,"range":{"start_line":48,"start_character":33,"end_line":48,"end_character":45},"updated":"2023-08-18 22:56:23.000000000","message":"see comment above","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        share_type \u003d cls.create_share_type()"},{"line_number":46,"context_line":"        share_type_id \u003d share_type[\u0027id\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        share \u003d cls.create_share(cls.protocol, share_type_id\u003dshare_type_id)"},{"line_number":49,"context_line":"        cls.share_id \u003d share[\"id\"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u002712c36c97-faf4-4fec-9a9b-7cff0d2035cd\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"b5613973_58f368db","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":75},"updated":"2023-08-18 22:56:23.000000000","message":"you\u0027re creating a share that\u0027s available through the lifetime of the class. This will trip the tests up - i.e, one test\u0027s failure will bleed into the next. \n\nI suggest using isolated shares for each test. You can use a \"setUp\" method to create this share. Unline \"resource_setup\" (which is a \u0027classmethod\u0027), setUp() is a regular instance method, executed once before each test and doesn\u0027t allow sharing resources across the class.\n\n\"resource_setup\" should be used to create class level resources when you\u0027re not manipulating the resource adversely in your tests. I imagine backup tests to potentially be disruptive to the source share.","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        share_type \u003d cls.create_share_type()"},{"line_number":46,"context_line":"        share_type_id \u003d share_type[\u0027id\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        share \u003d cls.create_share(cls.protocol, share_type_id\u003dshare_type_id)"},{"line_number":49,"context_line":"        cls.share_id \u003d share[\"id\"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u002712c36c97-faf4-4fec-9a9b-7cff0d2035cd\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"e2bae6a8_474568c4","line":48,"range":{"start_line":48,"start_character":33,"end_line":48,"end_character":45},"in_reply_to":"2d99cc5f_01720948","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        share_type \u003d cls.create_share_type()"},{"line_number":46,"context_line":"        share_type_id \u003d share_type[\u0027id\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        share \u003d cls.create_share(cls.protocol, share_type_id\u003dshare_type_id)"},{"line_number":49,"context_line":"        cls.share_id \u003d share[\"id\"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u002712c36c97-faf4-4fec-9a9b-7cff0d2035cd\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"4b1be316_02949ef6","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":75},"in_reply_to":"b5613973_58f368db","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Strict key check"},{"line_number":64,"context_line":"        self.assertEqual(set(expected_keys), set(actual_keys))"},{"line_number":65,"context_line":"        actual_backup \u003d self.shares_v2_client.get_backup(backup[\u0027id\u0027])"},{"line_number":66,"context_line":"        self.assertEqual(backup[\u0027id\u0027], actual_backup[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.idempotent_id(\u002734c36c97-faf4-4fec-9a9b-7cff0d2035cd\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"fb638618_bfe6861a","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":21},"updated":"2023-08-18 22:56:23.000000000","message":"can you also assert that this has the expected keys?","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Strict key check"},{"line_number":64,"context_line":"        self.assertEqual(set(expected_keys), set(actual_keys))"},{"line_number":65,"context_line":"        actual_backup \u003d self.shares_v2_client.get_backup(backup[\u0027id\u0027])"},{"line_number":66,"context_line":"        self.assertEqual(backup[\u0027id\u0027], actual_backup[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.idempotent_id(\u002734c36c97-faf4-4fec-9a9b-7cff0d2035cd\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"0c1a93c2_2c214243","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":21},"in_reply_to":"fb638618_bfe6861a","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        backup \u003d self.create_backup_wait_for_active(self.share_id)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Delete share backup"},{"line_number":74,"context_line":"        self.shares_v2_client.delete_share_backup(backup[\u0027id\u0027])"},{"line_number":75,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":76,"context_line":"                          self.shares_v2_client.get_backup,"},{"line_number":77,"context_line":"                          backup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"f5f9a161_88684f69","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":63},"updated":"2023-08-18 22:56:23.000000000","message":"deletion of a backup is an asynchronous operation; you should wait before you expect a \"NotFound\" error","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        backup \u003d self.create_backup_wait_for_active(self.share_id)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Delete share backup"},{"line_number":74,"context_line":"        self.shares_v2_client.delete_share_backup(backup[\u0027id\u0027])"},{"line_number":75,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":76,"context_line":"                          self.shares_v2_client.get_backup,"},{"line_number":77,"context_line":"                          backup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"736bd2cd_84f57f86","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":63},"in_reply_to":"f5f9a161_88684f69","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        backup \u003d self.create_backup_wait_for_active(self.share_id)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Delete share backup"},{"line_number":74,"context_line":"        self.shares_v2_client.delete_share_backup(backup[\u0027id\u0027])"},{"line_number":75,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":76,"context_line":"                          self.shares_v2_client.get_backup,"},{"line_number":77,"context_line":"                          backup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"be2be6c4_3fe5e256","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":63},"in_reply_to":"f5f9a161_88684f69","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"8d65e5aaf29e823c5345b09ff9f8fde0c4b9b999","unresolved":true,"context_lines":[{"line_number":28,"context_line":"_MIN_SUPPORTED_MICROVERSION \u003d \u00272.80\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareBackupTest(base.BaseSharesMixedTest):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":13,"id":"2214be2b_fcd95d3e","line":31,"updated":"2023-08-22 13:42:10.000000000","message":"From what I saw, you did not test the shares_v2_client.list_share_backups method. Would be good test it.","commit_id":"4f753ab31086f3bd4e2ebb410ec260bd6776755b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"_MIN_SUPPORTED_MICROVERSION \u003d \u00272.80\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareBackupTest(base.BaseSharesMixedTest):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":13,"id":"7ec23c8b_be3303cb","line":31,"in_reply_to":"2214be2b_fcd95d3e","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"4f753ab31086f3bd4e2ebb410ec260bd6776755b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fc0192c7b9d6eb644efb08630b996cc42d7fb1f8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2023 Cloudification GmbH"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":27,"id":"155e9094_3b4ee871","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2024-02-16 18:02:13.000000000","message":"nit: 2024","commit_id":"dc75f2728a3c6c8d959b1c89d65f7a38d6348479"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f776610435c8e038899deed99e811ac48cd4ed90","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2023 Cloudification GmbH"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":27,"id":"20ae6488_8faa420b","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"in_reply_to":"155e9094_3b4ee871","updated":"2024-02-22 09:02:39.000000000","message":"Done","commit_id":"dc75f2728a3c6c8d959b1c89d65f7a38d6348479"}],"manila_tempest_tests/tests/api/test_backup_negative.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1c5aa41102042a93075a5ac6d16e1d1e0c384f00","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        self.assertRaises(lib_exec.HTTPBadRequest,"},{"line_number":86,"context_line":"                          self.shares_v2_client.create_share_backup,"},{"line_number":87,"context_line":"                          self.share[\u0027id\u0027],"},{"line_number":88,"context_line":"                          name\u003dbackup_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b0b2c8b1_28d1ca6f","line":88,"updated":"2023-07-07 11:54:01.000000000","message":"please also add negative tests for delete and restore","commit_id":"e2fbc82ccf79c02b5ce61670c7a099014f8db1d1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1881fdfe1ec578a5630043581b3f12b6ea6ac74a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.assertRaises(lib_exec.HTTPBadRequest,"},{"line_number":86,"context_line":"                          self.shares_v2_client.create_share_backup,"},{"line_number":87,"context_line":"                          self.share[\u0027id\u0027],"},{"line_number":88,"context_line":"                          name\u003dbackup_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"191ebab0_7a60926c","line":88,"in_reply_to":"b0b2c8b1_28d1ca6f","updated":"2023-07-19 14:35:23.000000000","message":"Done","commit_id":"e2fbc82ccf79c02b5ce61670c7a099014f8db1d1"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775ba96de3b5e1a54896a34850fda1f462447b02","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareBackupNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        share \u003d cls.create_share(cls.protocol,"}],"source_content_type":"text/x-python","patch_set":8,"id":"f893bcf9_341125d2","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":11},"updated":"2023-08-01 11:29:16.000000000","message":"same","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"86a05651c0e360c9274c084be67504083528e310","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareBackupNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        share \u003d cls.create_share(cls.protocol,"}],"source_content_type":"text/x-python","patch_set":8,"id":"dd442021_a202bbb7","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":11},"in_reply_to":"f893bcf9_341125d2","updated":"2023-08-09 11:57:56.000000000","message":"Done","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775ba96de3b5e1a54896a34850fda1f462447b02","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareBackupNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        share \u003d cls.create_share(cls.protocol,"},{"line_number":48,"context_line":"                                 share_type_id\u003dcls.share_type_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"d1e3039b_0267e74b","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":11},"updated":"2023-08-01 11:29:16.000000000","message":"same","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"86a05651c0e360c9274c084be67504083528e310","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareBackupNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        share \u003d cls.create_share(cls.protocol,"},{"line_number":48,"context_line":"                                 share_type_id\u003dcls.share_type_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"cd38179d_0b2a149f","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":11},"in_reply_to":"d1e3039b_0267e74b","updated":"2023-08-09 11:57:56.000000000","message":"Done","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"775ba96de3b5e1a54896a34850fda1f462447b02","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        share \u003d cls.create_share(cls.protocol,"},{"line_number":48,"context_line":"                                 share_type_id\u003dcls.share_type_id)"},{"line_number":49,"context_line":"        cls.share \u003d cls.shares_client.get_share(share[\u0027id\u0027])"},{"line_number":50,"context_line":"        cls.share_id \u003d cls.share[\"id\"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002758c36c97-faf4-4fec-9a9b-7cff0d2035ab\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"94f1e12a_9bc43cc3","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":11},"updated":"2023-08-01 11:29:16.000000000","message":"same","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"86a05651c0e360c9274c084be67504083528e310","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        share \u003d cls.create_share(cls.protocol,"},{"line_number":48,"context_line":"                                 share_type_id\u003dcls.share_type_id)"},{"line_number":49,"context_line":"        cls.share \u003d cls.shares_client.get_share(share[\u0027id\u0027])"},{"line_number":50,"context_line":"        cls.share_id \u003d cls.share[\"id\"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002758c36c97-faf4-4fec-9a9b-7cff0d2035ab\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"6259cf79_32f80415","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":11},"in_reply_to":"94f1e12a_9bc43cc3","updated":"2023-08-09 11:57:56.000000000","message":"Done","commit_id":"fc24f2379c32347e41f70db1162db8d88b47af63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareBackupNegativeTest(base.BaseSharesMixedTest):"},{"line_number":32,"context_line":"    protocol \u003d \"nfs\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"fb44315e_86f727fd","line":32,"range":{"start_line":32,"start_character":3,"end_line":32,"end_character":20},"updated":"2023-08-18 22:56:23.000000000","message":"remove and use `shares_v2_client.share_protocol` instead\n\nhttps://github.com/openstack/manila-tempest-plugin/blob/d62b5dcf51e8b9824ddc279a73ee4d03ee23d0b2/manila_tempest_tests/services/share/json/shares_client.py#L40-L41","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareBackupNegativeTest(base.BaseSharesMixedTest):"},{"line_number":32,"context_line":"    protocol \u003d \"nfs\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"762a9e15_b02a5d32","line":32,"range":{"start_line":32,"start_character":3,"end_line":32,"end_character":20},"in_reply_to":"fb44315e_86f727fd","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002758c36c97-faf4-4fec-9a9b-7cff0d2035ab\u0027)"},{"line_number":53,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_BACKEND)"},{"line_number":54,"context_line":"    def test_create_backup_when_share_task_state_is_busy(self):"},{"line_number":55,"context_line":"        backup_name1 \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":56,"context_line":"        backup1 \u003d self.shares_v2_client.create_share_backup("},{"line_number":57,"context_line":"            self.share_id, name\u003dbackup_name1)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # try create backup when share state is busy"},{"line_number":60,"context_line":"        backup_name2 \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":61,"context_line":"        self.assertRaises(lib_exec.HTTPBadRequest,"},{"line_number":62,"context_line":"                          self.shares_v2_client.create_share_backup,"}],"source_content_type":"text/x-python","patch_set":12,"id":"36350569_6ca53adb","line":59,"range":{"start_line":55,"start_character":8,"end_line":59,"end_character":52},"updated":"2023-08-18 22:56:23.000000000","message":"this is fragile. What if the backup completes by the time you attempt to create the second backup?\n\nThe next test case verifies the same behavior, correct? why don\u0027t we rely on that instead?","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002758c36c97-faf4-4fec-9a9b-7cff0d2035ab\u0027)"},{"line_number":53,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_BACKEND)"},{"line_number":54,"context_line":"    def test_create_backup_when_share_task_state_is_busy(self):"},{"line_number":55,"context_line":"        backup_name1 \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":56,"context_line":"        backup1 \u003d self.shares_v2_client.create_share_backup("},{"line_number":57,"context_line":"            self.share_id, name\u003dbackup_name1)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # try create backup when share state is busy"},{"line_number":60,"context_line":"        backup_name2 \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":61,"context_line":"        self.assertRaises(lib_exec.HTTPBadRequest,"},{"line_number":62,"context_line":"                          self.shares_v2_client.create_share_backup,"}],"source_content_type":"text/x-python","patch_set":12,"id":"68b6ceec_46c5cfca","line":59,"range":{"start_line":55,"start_character":8,"end_line":59,"end_character":52},"in_reply_to":"36350569_6ca53adb","updated":"2023-08-25 14:28:00.000000000","message":"first one check share state is not amongst busy while next one check share status is available.","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"afcfb345c55042d1b8ed58a559c43e162ad7935a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002758c36c97-faf4-4fec-9a9b-7cff0d2035ab\u0027)"},{"line_number":53,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_BACKEND)"},{"line_number":54,"context_line":"    def test_create_backup_when_share_task_state_is_busy(self):"},{"line_number":55,"context_line":"        backup_name1 \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":56,"context_line":"        backup1 \u003d self.shares_v2_client.create_share_backup("},{"line_number":57,"context_line":"            self.share_id, name\u003dbackup_name1)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # try create backup when share state is busy"},{"line_number":60,"context_line":"        backup_name2 \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":61,"context_line":"        self.assertRaises(lib_exec.HTTPBadRequest,"},{"line_number":62,"context_line":"                          self.shares_v2_client.create_share_backup,"}],"source_content_type":"text/x-python","patch_set":12,"id":"2ab708dd_7a99342e","line":59,"range":{"start_line":55,"start_character":8,"end_line":59,"end_character":52},"in_reply_to":"68b6ceec_46c5cfca","updated":"2023-09-19 12:20:24.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_BACKEND)"},{"line_number":98,"context_line":"    def test_delete_backup_when_share_is_not_available(self):"},{"line_number":99,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":100,"context_line":"        backup \u003d self.shares_v2_client.create_share_backup("},{"line_number":101,"context_line":"            self.share_id, name\u003dbackup_name)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        waiters.wait_for_resource_status("},{"line_number":104,"context_line":"            self.shares_v2_client, backup[\u0027id\u0027], \u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"b0f66f9b_e2ff582a","line":101,"range":{"start_line":100,"start_character":8,"end_line":101,"end_character":44},"updated":"2023-08-18 22:56:23.000000000","message":"please add a cleanup step to delete this backup; or use the method added to the base module to create this backup since that already adds the necessary cleanup step","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_BACKEND)"},{"line_number":98,"context_line":"    def test_delete_backup_when_share_is_not_available(self):"},{"line_number":99,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":100,"context_line":"        backup \u003d self.shares_v2_client.create_share_backup("},{"line_number":101,"context_line":"            self.share_id, name\u003dbackup_name)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        waiters.wait_for_resource_status("},{"line_number":104,"context_line":"            self.shares_v2_client, backup[\u0027id\u0027], \u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"41686289_82ade0ea","line":101,"range":{"start_line":100,"start_character":8,"end_line":101,"end_character":44},"in_reply_to":"b0f66f9b_e2ff582a","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55764eb8eb5d0e77752998c1612cc19a731e2782","unresolved":true,"context_lines":[{"line_number":118,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_BACKEND)"},{"line_number":119,"context_line":"    def test_restore_backup_when_share_is_not_available(self):"},{"line_number":120,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":121,"context_line":"        backup \u003d self.shares_v2_client.create_share_backup("},{"line_number":122,"context_line":"            self.share_id, name\u003dbackup_name)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        waiters.wait_for_resource_status("},{"line_number":125,"context_line":"            self.shares_v2_client, backup[\u0027id\u0027], \u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"d635f517_848436ca","line":122,"range":{"start_line":121,"start_character":7,"end_line":122,"end_character":44},"updated":"2023-08-18 22:56:23.000000000","message":"same comment as above; this needs to be cleaned up","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_BACKEND)"},{"line_number":119,"context_line":"    def test_restore_backup_when_share_is_not_available(self):"},{"line_number":120,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":121,"context_line":"        backup \u003d self.shares_v2_client.create_share_backup("},{"line_number":122,"context_line":"            self.share_id, name\u003dbackup_name)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        waiters.wait_for_resource_status("},{"line_number":125,"context_line":"            self.shares_v2_client, backup[\u0027id\u0027], \u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"331a514e_5bdfd32b","line":122,"range":{"start_line":121,"start_character":7,"end_line":122,"end_character":44},"in_reply_to":"d635f517_848436ca","updated":"2023-08-25 14:28:00.000000000","message":"Done","commit_id":"2679fdedb04f351cac817ffc85984bb64c195ab1"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"8d65e5aaf29e823c5345b09ff9f8fde0c4b9b999","unresolved":true,"context_lines":[{"line_number":28,"context_line":"_MIN_SUPPORTED_MICROVERSION \u003d \u00272.80\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareBackupNegativeTest(base.BaseSharesMixedTest):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":13,"id":"ec9cddd1_93075c79","line":31,"updated":"2023-08-22 13:42:10.000000000","message":"From what I saw, you did not test a negative scenario for update a share backup. Would be good test it.","commit_id":"4f753ab31086f3bd4e2ebb410ec260bd6776755b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a492d3b4f2e92e11262b60c0038716c9c67d252b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"_MIN_SUPPORTED_MICROVERSION \u003d \u00272.80\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareBackupNegativeTest(base.BaseSharesMixedTest):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":13,"id":"482eaf63_6a964b38","line":31,"in_reply_to":"ec9cddd1_93075c79","updated":"2023-08-25 14:28:00.000000000","message":"For backup update, like other objects only name and description. So negative test would be to pass invalid backup id. I checked other implementation e.g. snapshot and replica and did not find similar tests.","commit_id":"4f753ab31086f3bd4e2ebb410ec260bd6776755b"}],"zuul.d/manila-tempest-jobs.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2d8885aca1ea77a975d424572a5f3fb752d505d","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS: \u0027snapshot_support\u003dTrue create_share_from_snapshot_support\u003dTrue\u0027"},{"line_number":46,"context_line":"        MANILA_CONFIGURE_DEFAULT_TYPES: true"},{"line_number":47,"context_line":"        MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL: 1"},{"line_number":48,"context_line":"        MANILA_CREATE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":49,"context_line":"        MANILA_RESTORE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":50,"context_line":"        MANILA_SERVER_MIGRATION_PERIOD_TASK_INTERVAL: 10"},{"line_number":51,"context_line":"        MANILA_REPLICA_STATE_UPDATE_INTERVAL: 10"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e24077ae_34264cde","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":55},"updated":"2023-08-25 20:36:33.000000000","message":"no need to set this in the base job, otherwise this periodic task will have this interval set in every single job","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9e596051270ca93da7dbe49aed6187e90c5886d2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS: \u0027snapshot_support\u003dTrue create_share_from_snapshot_support\u003dTrue\u0027"},{"line_number":46,"context_line":"        MANILA_CONFIGURE_DEFAULT_TYPES: true"},{"line_number":47,"context_line":"        MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL: 1"},{"line_number":48,"context_line":"        MANILA_CREATE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":49,"context_line":"        MANILA_RESTORE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":50,"context_line":"        MANILA_SERVER_MIGRATION_PERIOD_TASK_INTERVAL: 10"},{"line_number":51,"context_line":"        MANILA_REPLICA_STATE_UPDATE_INTERVAL: 10"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0eacc722_d5d3affc","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":55},"in_reply_to":"e24077ae_34264cde","updated":"2023-08-26 14:07:36.000000000","message":"Done","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2d8885aca1ea77a975d424572a5f3fb752d505d","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        MANILA_INSTALL_TEMPEST_PLUGIN_SYSTEMWIDE: false"},{"line_number":108,"context_line":"        MANILA_SERVICE_IMAGE_ENABLED: false"},{"line_number":109,"context_line":"        MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL: 1"},{"line_number":110,"context_line":"        MANILA_CREATE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":111,"context_line":"        MANILA_RESTORE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":112,"context_line":"        MANILA_SERVER_MIGRATION_PERIOD_TASK_INTERVAL: 10"},{"line_number":113,"context_line":"        MANILA_REPLICA_STATE_UPDATE_INTERVAL: 10"},{"line_number":114,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1c5a68d7_ade45971","line":111,"range":{"start_line":110,"start_character":0,"end_line":111,"end_character":55},"updated":"2023-08-25 20:36:33.000000000","message":"same","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9e596051270ca93da7dbe49aed6187e90c5886d2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        MANILA_INSTALL_TEMPEST_PLUGIN_SYSTEMWIDE: false"},{"line_number":108,"context_line":"        MANILA_SERVICE_IMAGE_ENABLED: false"},{"line_number":109,"context_line":"        MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL: 1"},{"line_number":110,"context_line":"        MANILA_CREATE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":111,"context_line":"        MANILA_RESTORE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":112,"context_line":"        MANILA_SERVER_MIGRATION_PERIOD_TASK_INTERVAL: 10"},{"line_number":113,"context_line":"        MANILA_REPLICA_STATE_UPDATE_INTERVAL: 10"},{"line_number":114,"context_line":"      devstack_services:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ed19f002_691a1041","line":111,"range":{"start_line":110,"start_character":0,"end_line":111,"end_character":55},"in_reply_to":"1c5a68d7_ade45971","updated":"2023-08-26 14:07:36.000000000","message":"Done","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2d8885aca1ea77a975d424572a5f3fb752d505d","unresolved":true,"context_lines":[{"line_number":133,"context_line":"        MANILA_OPTGROUP_london_driver_handles_share_servers: false"},{"line_number":134,"context_line":"        MANILA_OPTGROUP_paris_driver_handles_share_servers: false"},{"line_number":135,"context_line":"        MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL: 1"},{"line_number":136,"context_line":"        MANILA_CREATE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":137,"context_line":"        MANILA_RESTORE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":138,"context_line":"        MANILA_REPLICA_STATE_UPDATE_INTERVAL: 60"},{"line_number":139,"context_line":"        MANILA_ZFSONLINUX_SERVICE_IP: 127.0.0.1"},{"line_number":140,"context_line":"        MANILA_ZFSONLINUX_USE_SSH: true"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"4f4c9419_41a0c81d","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":55},"updated":"2023-08-25 20:36:33.000000000","message":"zfsonlinux driver is not testing share backups","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9e596051270ca93da7dbe49aed6187e90c5886d2","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        MANILA_OPTGROUP_london_driver_handles_share_servers: false"},{"line_number":134,"context_line":"        MANILA_OPTGROUP_paris_driver_handles_share_servers: false"},{"line_number":135,"context_line":"        MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL: 1"},{"line_number":136,"context_line":"        MANILA_CREATE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":137,"context_line":"        MANILA_RESTORE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":138,"context_line":"        MANILA_REPLICA_STATE_UPDATE_INTERVAL: 60"},{"line_number":139,"context_line":"        MANILA_ZFSONLINUX_SERVICE_IP: 127.0.0.1"},{"line_number":140,"context_line":"        MANILA_ZFSONLINUX_USE_SSH: true"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3bab90b2_35285a22","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":55},"in_reply_to":"4f4c9419_41a0c81d","updated":"2023-08-26 14:07:36.000000000","message":"Done","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2d8885aca1ea77a975d424572a5f3fb752d505d","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        MANILA_OPTGROUP_paris_driver_handles_share_servers: false"},{"line_number":214,"context_line":"        SHARE_BACKING_FILE_SIZE: 32000M"},{"line_number":215,"context_line":"        MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL: 1"},{"line_number":216,"context_line":"        MANILA_CREATE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":217,"context_line":"        MANILA_RESTORE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":218,"context_line":"        MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS: \u0027snapshot_support\u003dTrue create_share_from_snapshot_support\u003dTrue revert_to_snapshot_support\u003dTrue mount_snapshot_support\u003dTrue\u0027"},{"line_number":219,"context_line":"        MANILA_SETUP_IPV6: true"},{"line_number":220,"context_line":"        NEUTRON_CREATE_INITIAL_NETWORKS: false"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9d336c83_28330826","line":217,"range":{"start_line":216,"start_character":0,"end_line":217,"end_character":55},"updated":"2023-08-25 20:36:33.000000000","message":"same, LVM is not testing share backups, no need to run this task so often","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9e596051270ca93da7dbe49aed6187e90c5886d2","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        MANILA_OPTGROUP_paris_driver_handles_share_servers: false"},{"line_number":214,"context_line":"        SHARE_BACKING_FILE_SIZE: 32000M"},{"line_number":215,"context_line":"        MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL: 1"},{"line_number":216,"context_line":"        MANILA_CREATE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":217,"context_line":"        MANILA_RESTORE_BACKUP_CONTINUE_TASK_INTERVAL: 1"},{"line_number":218,"context_line":"        MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS: \u0027snapshot_support\u003dTrue create_share_from_snapshot_support\u003dTrue revert_to_snapshot_support\u003dTrue mount_snapshot_support\u003dTrue\u0027"},{"line_number":219,"context_line":"        MANILA_SETUP_IPV6: true"},{"line_number":220,"context_line":"        NEUTRON_CREATE_INITIAL_NETWORKS: false"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ea06ed45_2882a7bc","line":217,"range":{"start_line":216,"start_character":0,"end_line":217,"end_character":55},"in_reply_to":"9d336c83_28330826","updated":"2023-08-26 14:07:36.000000000","message":"Done","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b2d8885aca1ea77a975d424572a5f3fb752d505d","unresolved":true,"context_lines":[{"line_number":531,"context_line":"        MANILA_OPTGROUP_membernet_standalone_network_plugin_gateway: 10.0.0.1"},{"line_number":532,"context_line":"        MANILA_OPTGROUP_membernet_standalone_network_plugin_mask: 24"},{"line_number":533,"context_line":"        MANILA_OPTGROUP_membernet_standalone_network_plugin_network_type: vlan"},{"line_number":534,"context_line":"        MANILA_OPTGROUP_membernet_standalone_network_plugin_segmentation_id: 1010"},{"line_number":535,"context_line":"      devstack_local_conf:"},{"line_number":536,"context_line":"        test-config:"},{"line_number":537,"context_line":"          \"$TEMPEST_CONFIG\":"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"30b81503_c9c4a82b","line":534,"updated":"2023-08-25 20:36:33.000000000","message":"this is the driver where you should set an interval, but 1 might be too low. This task would be run each second. 30 would be okay I think (30 seconds). The default is 60 seconds.","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9e596051270ca93da7dbe49aed6187e90c5886d2","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        MANILA_OPTGROUP_membernet_standalone_network_plugin_gateway: 10.0.0.1"},{"line_number":532,"context_line":"        MANILA_OPTGROUP_membernet_standalone_network_plugin_mask: 24"},{"line_number":533,"context_line":"        MANILA_OPTGROUP_membernet_standalone_network_plugin_network_type: vlan"},{"line_number":534,"context_line":"        MANILA_OPTGROUP_membernet_standalone_network_plugin_segmentation_id: 1010"},{"line_number":535,"context_line":"      devstack_local_conf:"},{"line_number":536,"context_line":"        test-config:"},{"line_number":537,"context_line":"          \"$TEMPEST_CONFIG\":"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2370e54d_d5b4d4de","line":534,"in_reply_to":"30b81503_c9c4a82b","updated":"2023-08-26 14:07:36.000000000","message":"Done","commit_id":"a3c04fa7c767c9fc359d348d9eee150cb2e2ecc7"}]}