)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e180c4e0829e6a74860f09a7976e5136c8ff85ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5848e3e6_f0301f88","updated":"2022-06-30 10:24:23.000000000","message":"recheck\nFailed due to known reason","commit_id":"f7d40e916e565c50541a81afc657053d1229be58"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e4dd8de82e9ebd6c1836f6a3df75c85a25768eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3796131f_aa04204b","updated":"2022-07-01 11:58:42.000000000","message":"Some comments inline, -1: for the branching question only,the rest is your call.","commit_id":"23cc738e60d372ad58c8f79750f38c954d9c3664"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"70c7e86511d544ad18a5c89b8c70e49fa5596259","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9fd222d9_59d4b685","updated":"2022-07-05 10:12:46.000000000","message":"LGTM, thanks Carlos!","commit_id":"e21dbfd23d7e9342446d95ba868a27fb8118efc4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4bd2f11f7f6e15221bda5408eb3a94119a2af708","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7dcdb6b7_d204aec3","updated":"2022-07-05 23:44:19.000000000","message":"LGTM, thanks Carlos, Ashley and Vida.\n\nWe have both fips and fips-stable jobs passing in the following patches:\n\nhttps://review.opendev.org/c/openstack/manila/+/810953/73#message-0a8e53835beac8f53b8d0b6d8c0814184a29360d\nhttps://review.opendev.org/c/openstack/manila/+/848182/4#message-49fa6676f1b73a51b597aabb62ba35e73b6c1001","commit_id":"e21dbfd23d7e9342446d95ba868a27fb8118efc4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"02b6bc2627c1b0f6a1190d0b830ce060a6a703db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"130186f4_0152bbe4","updated":"2022-07-01 16:54:12.000000000","message":"Thank you for the review, Douglas. Please take a look at the most recent PS","commit_id":"e21dbfd23d7e9342446d95ba868a27fb8118efc4"}],"zuul.d/manila-tempest-jobs.yaml":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e4dd8de82e9ebd6c1836f6a3df75c85a25768eff","unresolved":true,"context_lines":[{"line_number":629,"context_line":"    pre-run:"},{"line_number":630,"context_line":"      - playbooks/enable-fips.yaml"},{"line_number":631,"context_line":"    vars:"},{"line_number":632,"context_line":"      nslookup_target: \u0027opendev.org\u0027"},{"line_number":633,"context_line":"      devstack_localrc:"},{"line_number":634,"context_line":"        MANILA_SETUP_IPV6: false"},{"line_number":635,"context_line":"        NEUTRON_CREATE_INITIAL_NETWORKS: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2def1806_4f2bfbd4","line":632,"range":{"start_line":632,"start_character":6,"end_line":632,"end_character":36},"updated":"2022-07-01 11:58:42.000000000","message":"this is very \u0027enable-fips\u0027 specific var. One idea: you could add this as default on your pre playbook, when you call enable-fips role, pass this as var.\nI don\u0027t thing that this value will need to change for any other job, and you don\u0027t need to add it in all other fips jobs.\nUp to you","commit_id":"23cc738e60d372ad58c8f79750f38c954d9c3664"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"02b6bc2627c1b0f6a1190d0b830ce060a6a703db","unresolved":false,"context_lines":[{"line_number":629,"context_line":"    pre-run:"},{"line_number":630,"context_line":"      - playbooks/enable-fips.yaml"},{"line_number":631,"context_line":"    vars:"},{"line_number":632,"context_line":"      nslookup_target: \u0027opendev.org\u0027"},{"line_number":633,"context_line":"      devstack_localrc:"},{"line_number":634,"context_line":"        MANILA_SETUP_IPV6: false"},{"line_number":635,"context_line":"        NEUTRON_CREATE_INITIAL_NETWORKS: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2bd3077f_e990df93","line":632,"range":{"start_line":632,"start_character":6,"end_line":632,"end_character":36},"in_reply_to":"2def1806_4f2bfbd4","updated":"2022-07-01 16:54:12.000000000","message":"Yeah, that would work too... I kept this as is, because it\u0027s being the pattern, but we can move it to the other file in the future as well","commit_id":"23cc738e60d372ad58c8f79750f38c954d9c3664"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e4dd8de82e9ebd6c1836f6a3df75c85a25768eff","unresolved":true,"context_lines":[{"line_number":646,"context_line":"- job:"},{"line_number":647,"context_line":"    name: manila-tempest-plugin-lvm-fips"},{"line_number":648,"context_line":"    parent: manila-tempest-plugin-lvm-fips-base"},{"line_number":649,"context_line":"    branches: ^(?!stable/(victoria|ussuri)).*$"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"- project-template:"},{"line_number":652,"context_line":"    name: manila-tempest-plugin-jobs-using-service-image"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"08afe3a9_79d7620b","line":649,"range":{"start_line":649,"start_character":0,"end_line":649,"end_character":46},"updated":"2022-07-01 11:58:42.000000000","message":"This should be zed and onwards, right? the stable one has:\nbranches: ^(stable/(yoga|xena|wallaby)).*$","commit_id":"23cc738e60d372ad58c8f79750f38c954d9c3664"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"02b6bc2627c1b0f6a1190d0b830ce060a6a703db","unresolved":false,"context_lines":[{"line_number":646,"context_line":"- job:"},{"line_number":647,"context_line":"    name: manila-tempest-plugin-lvm-fips"},{"line_number":648,"context_line":"    parent: manila-tempest-plugin-lvm-fips-base"},{"line_number":649,"context_line":"    branches: ^(?!stable/(victoria|ussuri)).*$"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"- project-template:"},{"line_number":652,"context_line":"    name: manila-tempest-plugin-jobs-using-service-image"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bed7f037_0a8fdc06","line":649,"range":{"start_line":649,"start_character":0,"end_line":649,"end_character":46},"in_reply_to":"08afe3a9_79d7620b","updated":"2022-07-01 16:54:12.000000000","message":"yes, missing xena and wallaby here, but if we are not adding this to project-templates there\u0027s no reason to define the branches this I think","commit_id":"23cc738e60d372ad58c8f79750f38c954d9c3664"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e4dd8de82e9ebd6c1836f6a3df75c85a25768eff","unresolved":true,"context_lines":[{"line_number":666,"context_line":"            voting: false"},{"line_number":667,"context_line":"        - manila-tempest-plugin-zfsonlinux:"},{"line_number":668,"context_line":"            voting: false"},{"line_number":669,"context_line":"        - manila-tempest-plugin-lvm-fips:"},{"line_number":670,"context_line":"            voting: false"},{"line_number":671,"context_line":"    gate:"},{"line_number":672,"context_line":"      jobs:"},{"line_number":673,"context_line":"        - manila-tempest-plugin-lvm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c05335de_7336b8a9","line":670,"range":{"start_line":669,"start_character":0,"end_line":670,"end_character":25},"updated":"2022-07-01 11:58:42.000000000","message":"I think that this would work better in another template, one for fips only, WDYT?\nOr, since it is a single job, just add it directly in project\u0027s configuration","commit_id":"23cc738e60d372ad58c8f79750f38c954d9c3664"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"02b6bc2627c1b0f6a1190d0b830ce060a6a703db","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            voting: false"},{"line_number":667,"context_line":"        - manila-tempest-plugin-zfsonlinux:"},{"line_number":668,"context_line":"            voting: false"},{"line_number":669,"context_line":"        - manila-tempest-plugin-lvm-fips:"},{"line_number":670,"context_line":"            voting: false"},{"line_number":671,"context_line":"    gate:"},{"line_number":672,"context_line":"      jobs:"},{"line_number":673,"context_line":"        - manila-tempest-plugin-lvm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"cd4dc0e6_1db0afd0","line":670,"range":{"start_line":669,"start_character":0,"end_line":670,"end_character":25},"in_reply_to":"c05335de_7336b8a9","updated":"2022-07-01 16:54:12.000000000","message":"I think I prefer if we add it directly in the project\u0027s configuration...","commit_id":"23cc738e60d372ad58c8f79750f38c954d9c3664"}],"zuul.d/manila-tempest-stable-jobs.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"70c7e86511d544ad18a5c89b8c70e49fa5596259","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- job:"},{"line_number":66,"context_line":"    name: manila-tempest-plugin-lvm-fips-stable"},{"line_number":67,"context_line":"    parent: manila-tempest-plugin-lvm-fips-base"},{"line_number":68,"context_line":"    branches: ^(stable/(yoga|xena|wallaby)).*$"},{"line_number":69,"context_line":"    vars: *manila_tempest_image_pinned_vars"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7ff47a36_77bced09","line":68,"range":{"start_line":67,"start_character":4,"end_line":68,"end_character":4},"updated":"2022-07-05 10:12:46.000000000","message":"Carlos and I discussed issues using devstack with centos-9 on xena/wallaby; but that\u0027s getting worked on at the moment: https://review.opendev.org/q/5ea4c3c18c558ec1fa37e0dd9b28ce66c3da1130","commit_id":"e21dbfd23d7e9342446d95ba868a27fb8118efc4"}]}