)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a6e4669583f0491bfb9cf79365c121c99f62da2b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaix09@chinatelecom.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-15 14:59:40 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update micversion to 2.77,support share transfer between project."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I8facf9112a6b09e6b7aed9956c0a87fb5f1fc31f"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/manila/+/874229"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"4fae76ea_8459d6a5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"updated":"2023-09-16 17:24:52.000000000","message":"No longer true; so perhaps just:\n\n\"Add share transfer tests\"","commit_id":"f5b7417570011168981f744beee0904700fc5ef0"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1e5663327ceeb6fa9a33bb627b6922ad1f4d7296","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaix09@chinatelecom.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-15 14:59:40 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update micversion to 2.77,support share transfer between project."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I8facf9112a6b09e6b7aed9956c0a87fb5f1fc31f"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/manila/+/874229"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"2f961b35_d197f815","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"in_reply_to":"4fae76ea_8459d6a5","updated":"2023-09-18 01:03:04.000000000","message":"Done","commit_id":"f5b7417570011168981f744beee0904700fc5ef0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a6e4669583f0491bfb9cf79365c121c99f62da2b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-09-15 14:59:40 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update micversion to 2.77,support share transfer between project."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I8facf9112a6b09e6b7aed9956c0a87fb5f1fc31f"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/manila/+/874229"},{"line_number":11,"context_line":"Partially-Implements: blueprint transfer-share-between-project"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I74f0a079edb59e376d045fe9e9fd781acd70249d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"eeeb5bb2_246df63a","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":66},"updated":"2023-09-16 17:24:52.000000000","message":"these have merged now; so please drop if you make another patch","commit_id":"f5b7417570011168981f744beee0904700fc5ef0"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1e5663327ceeb6fa9a33bb627b6922ad1f4d7296","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-09-15 14:59:40 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update micversion to 2.77,support share transfer between project."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I8facf9112a6b09e6b7aed9956c0a87fb5f1fc31f"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/manila/+/874229"},{"line_number":11,"context_line":"Partially-Implements: blueprint transfer-share-between-project"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I74f0a079edb59e376d045fe9e9fd781acd70249d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"a9ccc852_a73b9a85","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":66},"in_reply_to":"eeeb5bb2_246df63a","updated":"2023-09-18 01:03:04.000000000","message":"Done","commit_id":"f5b7417570011168981f744beee0904700fc5ef0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4b67516355ad80911c211e24454505a45945f14d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c7c6cb67_0b77a79b","updated":"2022-09-20 14:52:29.000000000","message":"recheck","commit_id":"fb96794b23d17a47d214acde6b8843a853671f3d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"88668e50c83d72f31470c281687645af36b4bffb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bec8b9c7_fca0bce8","updated":"2023-02-02 00:29:22.000000000","message":"Thanks Haixin. LGTM! NetApp CI failed, but it seems not related to the change. I\u0027m retriggering just to be safe. As soon as it passes, my vote goes to +1.","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"12edca836c60c8bc0063d8defe99cd5a4583fad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"56736dd5_55a92b6d","updated":"2023-02-04 02:26:12.000000000","message":"This looks good; some minor suggestions inline.. ","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"bd94a0862f823dfba4442832010af1cd0a03bc6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"531ecac6_e87386c4","updated":"2023-02-02 00:29:11.000000000","message":"run-NetApp CI","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7a5fe7addb77a3e18439863d21489bc492274ad0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9afc29cb_2959a71a","updated":"2023-02-06 08:08:42.000000000","message":"Thank you very much for your review， Goutham Pacha Ravi.","commit_id":"09080e56124948ed17f341ff2c9369d69fe3107a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f295b7463227f85ced6e1ba45b766f6cd4bfca7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1c339050_31a7984f","updated":"2023-02-06 10:02:15.000000000","message":"recheck","commit_id":"09080e56124948ed17f341ff2c9369d69fe3107a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"36fb66fe505a9770d487edea2d95688dae04229c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c17dc4bf_69f7f37e","updated":"2023-02-06 09:40:54.000000000","message":"recheck","commit_id":"09080e56124948ed17f341ff2c9369d69fe3107a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f18f1c5dd1336b3804f242fcc762fd625f248382","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fc24f884_0bfc946e","updated":"2023-02-07 00:47:29.000000000","message":"recheck","commit_id":"09080e56124948ed17f341ff2c9369d69fe3107a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"64a3304a24e18f2225291357d47475de05de09fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"817030f7_4ecc3a0e","updated":"2023-02-16 14:26:59.000000000","message":"recheck","commit_id":"991feb1a4c0eca1166fdfedababada75cbe9ba79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1cb36ec1a705bbfc4db5b19478acd6dea5af0ce3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"226fa851_015edcd5","updated":"2023-02-17 08:11:45.000000000","message":"recheck","commit_id":"d998c5218ca2d4e7e86f7ed0ff6c5f1cb48872c0"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ca48705f49fb908ef2db8eaf868cca8a93c73790","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"9296cd99_866096f4","updated":"2023-02-17 05:54:37.000000000","message":"recheck","commit_id":"d998c5218ca2d4e7e86f7ed0ff6c5f1cb48872c0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"de8c227b378a2cf78b7cb40490e9e59e9b42cde5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3481f86d_4174b540","updated":"2023-02-17 14:15:09.000000000","message":"LGTM, thanks for the hard work, Haixin!","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"2df80e2f_812b3f08","updated":"2023-02-21 05:18:14.000000000","message":"Thanks for submitting this; could you please address the comments inline","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f4fefc6b94fd54eb6bf198b071f8ed0f8ca7a80f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"8d573a6d_95892f50","in_reply_to":"3481f86d_4174b540","updated":"2023-02-17 14:15:37.000000000","message":"Wrong change 😄","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"41f928e0_0da33afc","updated":"2023-02-21 09:06:02.000000000","message":"thanks for your review. Goutham Pacha Ravi.","commit_id":"021ab310e4104d4d1f457d440b17ad1f14203f66"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"024c01be7b0f056dda832602faa2b8077d54929d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c502a9be_7ddfbe16","updated":"2023-02-22 06:34:17.000000000","message":"thanks for your review. Liron Kuchlani.","commit_id":"01decc0593a1e08d244585e26e7eb56b9fdcf439"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0a5390f29d5a307301f2a204ba5c0f1bc975a0b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"f948572b_f291692b","updated":"2023-09-14 00:42:23.000000000","message":"Hi Haixin;\n\ncould you please rebase/refresh this change. it\u0027s quite valuable to backfill these tests! :)","commit_id":"dff7c2e2dd6a26d89a48ad27f237298a766c2f74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a6e4669583f0491bfb9cf79365c121c99f62da2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"e93ea46b_f5d33691","updated":"2023-09-16 17:24:52.000000000","message":"thank you Haixin, LGTM!","commit_id":"f5b7417570011168981f744beee0904700fc5ef0"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1e5663327ceeb6fa9a33bb627b6922ad1f4d7296","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"19f50340_e5b5550f","updated":"2023-09-18 01:03:04.000000000","message":"thanks, Goutham.","commit_id":"7e1ca61974c1903573d4bbf959c48fc9d29513c1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"627493a493c478fafdd9816d278a76ec1027ffd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"f66fd8bc_c786121d","updated":"2023-09-19 05:58:15.000000000","message":"The error appear.","commit_id":"e1db08f7b990f6c2443d2ac7849d0b1f4c8bd734"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"65001085fa305619e2a4d2eca786708e9f29423a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"e93a5ee0_4b2aad66","updated":"2023-09-20 03:02:41.000000000","message":"the zuul tell us, also has same error.","commit_id":"109695cd929a6a028be5354448f6735e63c1d2a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e2f9829a54725ac0777c2489dde8b1e79d0a387b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"eb9f796b_3f983e67","in_reply_to":"16b040ae_0b6f6c80","updated":"2023-09-20 20:26:07.000000000","message":"I got lost troubleshooting this with the logs from the job that ran on PS 29\n\nthe share type deletion failure occurred because there was a share:\n\n -- share type that failed to be deleted --\ntempest-typeshare-type-645402017 eb9d0965-38a0-48a8-ac42-ebbe6c338153\n\nhttps://zuul.opendev.org/t/openstack/build/3190b6020171465fb2544a1690433f71/log/controller/logs/tempest_log.txt#58742-58771\n (reattempt: https://zuul.opendev.org/t/openstack/build/3190b6020171465fb2544a1690433f71/log/controller/logs/tempest_log.txt#59591-59620)\n \n--- failure in the API logs ---\n\n\nhttps://zuul.opendev.org/t/openstack/build/3190b6020171465fb2544a1690433f71/log/controller/logs/screen-m-api.txt#39483\n\n\"Deletion of share type eb9d0965-38a0-48a8-ac42-ebbe6c338153 failed; it in use by 1 shares and 0 share group types\"\n\n--- Shares associated with the share type, and their deletions ---- \n \n \n\nShareTransferTest:test_create_and_delete_share_transfer\n7b65935f-bc1b-477b-86a6-77c4c58c4253 -- share 1 (deleted fine)\nhttps://zuul.opendev.org/t/openstack/build/3190b6020171465fb2544a1690433f71/log/controller/logs/tempest_log.txt#58693\n\n\nShareTransferTest:test_create_and_accept_share_transfer\n48c68391-bf9c-4848-ad61-079f03843605 -- share 2 (not deleted)\n\nhttps://zuul.opendev.org/t/openstack/build/3190b6020171465fb2544a1690433f71/log/controller/logs/tempest_log.txt#58029\n\n\n^ So i think this is because you\u0027re expecting cleanup with the primary project (\"shares_v2_client\") when you\u0027ve transferred the share over to alt_primary (\"alt_shares_v2_client\"). \n\nAnywho: lets debug this separately: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/895977","commit_id":"109695cd929a6a028be5354448f6735e63c1d2a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1e66224cfe730e8aba59b89fc0f96b64b46bb6d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"16b040ae_0b6f6c80","in_reply_to":"e93a5ee0_4b2aad66","updated":"2023-09-20 08:24:49.000000000","message":"So there is probably no problem in the deletion mechanisms, but there is a hidden problem here.\nI don\u0027t want to delay this patch. So delete the share in the test itself as it worked for you and we\u0027ll have to investigate further.","commit_id":"109695cd929a6a028be5354448f6735e63c1d2a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7afcb1126ab91b76d50b8b247191a35f437b469c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"e404b5ba_dae3d33e","in_reply_to":"eb9f796b_3f983e67","updated":"2023-09-21 00:06:51.000000000","message":"Looks like it works: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/895977\n\nany reason not to just adopt that change and fix this right away?","commit_id":"109695cd929a6a028be5354448f6735e63c1d2a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e2f9829a54725ac0777c2489dde8b1e79d0a387b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"ec3c4ded_40aad5d0","updated":"2023-09-20 20:26:07.000000000","message":"Good we were able to address the cleanup issue in the negative tests; but its still a bit puzzling why the share type cleanup fails in the positive test cases; so lets debug elsewhere: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/895977","commit_id":"dec59c1c1d80877fe6c67e463ee1ac0264e7cf60"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"660abb0ce44dca223d7e1347f2ad0f195bc44e32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"33753be1_c9596b42","updated":"2023-09-21 02:13:22.000000000","message":"Good stuff; thank you - i\u0027ll abandon https://review.opendev.org/c/openstack/manila-tempest-plugin/+/895977/","commit_id":"1227546e7ca39759fb2240c0e8412e1a7a43cd0b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d21b23e9ccde1b7d425a51928fc2bc6a6097efff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"ab600a47_4c5bf755","updated":"2023-09-22 12:48:34.000000000","message":"LGTM, thanks Haixin!","commit_id":"1227546e7ca39759fb2240c0e8412e1a7a43cd0b"}],"manila_tempest_tests/tests/api/test_share_transfers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"12edca836c60c8bc0063d8defe99cd5a4583fad3","unresolved":true,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # check transfer not in transfer list"},{"line_number":74,"context_line":"        transfers \u003d self.shares_v2_client.list_share_transfers()[\u0027transfers\u0027]"},{"line_number":75,"context_line":"        transfer_ids \u003d [tf[\u0027id\u0027] for tf in transfers] if transfers else []"},{"line_number":76,"context_line":"        self.assertNotIn(transfer[\u0027id\u0027], transfer_ids)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"}],"source_content_type":"text/x-python","patch_set":11,"id":"fd4310f4_48edcbef","line":75,"range":{"start_line":75,"start_character":54,"end_line":75,"end_character":74},"updated":"2023-02-04 02:26:12.000000000","message":"not needed","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7a5fe7addb77a3e18439863d21489bc492274ad0","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # check transfer not in transfer list"},{"line_number":74,"context_line":"        transfers \u003d self.shares_v2_client.list_share_transfers()[\u0027transfers\u0027]"},{"line_number":75,"context_line":"        transfer_ids \u003d [tf[\u0027id\u0027] for tf in transfers] if transfers else []"},{"line_number":76,"context_line":"        self.assertNotIn(transfer[\u0027id\u0027], transfer_ids)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"}],"source_content_type":"text/x-python","patch_set":11,"id":"297dbd7d_ade80d2a","line":75,"range":{"start_line":75,"start_character":54,"end_line":75,"end_character":74},"in_reply_to":"fd4310f4_48edcbef","updated":"2023-02-06 08:08:42.000000000","message":"Done","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75961739df43ba52aaa20688ba8c3fcdf4231b61","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":11,"id":"b859e6d5_af93695d","line":80,"updated":"2023-09-18 09:33:46.000000000","message":"hi, Liron Kuchlani.\nhere is the error i got.","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"12edca836c60c8bc0063d8defe99cd5a4583fad3","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        transfer_ids \u003d [tf[\u0027id\u0027] for tf in transfers] if transfers else []"},{"line_number":76,"context_line":"        self.assertNotIn(transfer[\u0027id\u0027], transfer_ids)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":11,"id":"53523724_69b5e1a0","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":78},"updated":"2023-02-04 02:26:12.000000000","message":"this can be done automatically - set \"cleanup_in_class\u003dFalse\" on line 52-53","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"845eb882906072d703ad61c7aadee39d2bb72637","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        transfer_ids \u003d [tf[\u0027id\u0027] for tf in transfers] if transfers else []"},{"line_number":76,"context_line":"        self.assertNotIn(transfer[\u0027id\u0027], transfer_ids)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":11,"id":"d0f56238_e0ec1729","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":78},"in_reply_to":"52cec66e_b5a73f19","updated":"2023-02-08 00:52:07.000000000","message":"but, i got below error:\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_22d/858351/13/check/manila-tempest-plugin-dummy-no-dhss/22d2ed4/testr_results.html\n\nft1.1: tearDownClass (manila_tempest_tests.tests.api.test_share_transfers.ShareTransferTest)testtools.testresult.real._StringException: Traceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/test.py\", line 267, in tearDownClass\n    raise value.with_traceback(trace)\n  File \"/opt/stack/tempest/tempest/test.py\", line 231, in tearDownClass\n    teardown()\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/manila_tempest_tests/tests/api/base.py\", line 1201, in resource_cleanup\n    super(BaseSharesMixedTest, cls).resource_cleanup()\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/manila_tempest_tests/tests/api/base.py\", line 183, in resource_cleanup\n    cls.clear_resources(cls.class_resources)\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/manila_tempest_tests/tests/api/base.py\", line 881, in clear_resources\n    client.delete_share_type(res_id)\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/manila_tempest_tests/services/share/v2/json/shares_client.py\", line 993, in delete_share_type\n    resp, body \u003d self.delete(\"types/%s\" % share_type_id, version\u003dversion)\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/manila_tempest_tests/services/share/v2/json/shares_client.py\", line 85, in delete\n    resp, body \u003d super(SharesV2Client, self).delete(url, headers\u003dheaders,\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 330, in delete\n    return self.request(\u0027DELETE\u0027, url, extra_headers, headers, body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 720, in request\n    self._error_checker(resp, resp_body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 831, in _error_checker\n    raise exceptions.BadRequest(resp_body, resp\u003dresp)\ntempest.lib.exceptions.BadRequest: Bad request\nDetails: {\u0027code\u0027: 400, \u0027message\u0027: \u0027Target share type is still in use.\u0027}","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7a5fe7addb77a3e18439863d21489bc492274ad0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        transfer_ids \u003d [tf[\u0027id\u0027] for tf in transfers] if transfers else []"},{"line_number":76,"context_line":"        self.assertNotIn(transfer[\u0027id\u0027], transfer_ids)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":11,"id":"52cec66e_b5a73f19","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":78},"in_reply_to":"53523724_69b5e1a0","updated":"2023-02-06 08:08:42.000000000","message":"Done","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3240ab263926907ba1070074f97116943ce923f6","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":11,"id":"cd453416_5724c846","line":80,"in_reply_to":"5a10fa36_c056f4c9","updated":"2023-09-19 10:34:07.000000000","message":"Thanks Haixin!\n\nThis is very suspicious.\nPlease do the bellow workaround in L53, it should work and we\u0027ll push this patch.\nThis will confirm that there\u0027s a problem with the deletion mechanisms.\n\n\nfrom tempest.lib.common.utils import test_utils\n\nshare \u003d self.create_share(name\u003dshare_name,\n                          share_type_id\u003dself.share_type_id)\nself.addCleanup(test_utils.call_and_ignore_notfound_exc,\n                self.shares_v2_client.wait_for_resource_deletion, \n                share_id\u003dshare[\u0027id\u0027])\nself.addCleanup(test_utils.call_and_ignore_notfound_exc,\n                self.shares_v2_client.delete_share, share[\u0027id\u0027])","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5790c33a13b7b2295b1a3fa9284e55d936ed0cc9","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":11,"id":"baf4a66a_ea7e3bbe","line":80,"in_reply_to":"b859e6d5_af93695d","updated":"2023-09-18 11:06:48.000000000","message":"I think it didn\u0027t wait for the share deletion to complete.\nCan you please do what Goutham suggested.\nRemove these lines and add cleanup_in_class\u003dFalse in create_share method(L53), like:\nshare \u003d self.create_share(name\u003dshare_name,                                  \n                          share_type_id\u003dself.share_type_id,\n                          cleanup_in_class\u003dFalse)\n\nSorry to ask you to do this, but if there is indeed a failure it means there is a problem with the deletion mechanisms.","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d2e427d53621b3b34cc80cbc59b0a3e1de550226","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fe3195c7_ab6fbf03","line":80,"in_reply_to":"baf4a66a_ea7e3bbe","updated":"2023-09-18 21:36:57.000000000","message":"Haixin, would you like to address this? \n\nI\u0027m hoping to get this into the upcoming release: https://review.opendev.org/c/openstack/releases/+/895561","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"db67fe4135d019a7dc90e9ac16a67d9f48747230","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1e2d4e39_25ef5ffd","line":80,"in_reply_to":"cd453416_5724c846","updated":"2023-09-20 01:41:41.000000000","message":"Done, try again.","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"0852a97b820cd5750331e67fdb9608ff4bf3451c","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        transfer_ids \u003d [tf[\u0027id\u0027] for tf in transfers] if transfers else []"},{"line_number":76,"context_line":"        self.assertNotIn(transfer[\u0027id\u0027], transfer_ids)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":11,"id":"140f9835_55f9430b","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":78},"in_reply_to":"d0f56238_e0ec1729","updated":"2023-09-18 09:34:43.000000000","message":"hi, Liron Kuchlani.\nhere is the error i got.","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"9fd78cd16eadf9f16b833be7f43bc169fd2b41d2","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a10fa36_c056f4c9","line":80,"in_reply_to":"fe3195c7_ab6fbf03","updated":"2023-09-19 01:13:37.000000000","message":"ok, let\u0027s try it.","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    def resource_setup(cls):"},{"line_number":41,"context_line":"        super(ShareTransferTest, cls).resource_setup()"},{"line_number":42,"context_line":"        # create share_type with dhss\u003dFalse"},{"line_number":43,"context_line":"        extra_specs \u003d {\"driver_handles_share_servers\": \"False\"}"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"449136fe_082232cd","line":43,"range":{"start_line":43,"start_character":22,"end_line":43,"end_character":63},"updated":"2023-02-21 05:18:14.000000000","message":"self.add_extra_specs_to_dict() adds necessary specs based on config","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def resource_setup(cls):"},{"line_number":41,"context_line":"        super(ShareTransferTest, cls).resource_setup()"},{"line_number":42,"context_line":"        # create share_type with dhss\u003dFalse"},{"line_number":43,"context_line":"        extra_specs \u003d {\"driver_handles_share_servers\": \"False\"}"},{"line_number":44,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7ae6b90a_4e36fe4c","line":43,"range":{"start_line":43,"start_character":22,"end_line":43,"end_character":63},"in_reply_to":"449136fe_082232cd","updated":"2023-02-21 09:06:02.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @decorators.idempotent_id(\u0027716e71a0-8265-4410-9170-08714095d9e8\u0027)"},{"line_number":48,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":49,"context_line":"    def test_create_and_delete_share_transfer(self):"},{"line_number":50,"context_line":"        # create share"},{"line_number":51,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"2c5134cf_ed7b8ed1","line":48,"range":{"start_line":48,"start_character":37,"end_line":48,"end_character":44},"updated":"2023-02-21 05:18:14.000000000","message":"TAG_API_WITH_BACKEND\n\nTAG_API is for tests where only the API service is required..","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @decorators.idempotent_id(\u0027716e71a0-8265-4410-9170-08714095d9e8\u0027)"},{"line_number":48,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":49,"context_line":"    def test_create_and_delete_share_transfer(self):"},{"line_number":50,"context_line":"        # create share"},{"line_number":51,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"18f73045_647106b8","line":48,"range":{"start_line":48,"start_character":37,"end_line":48,"end_character":44},"in_reply_to":"2c5134cf_ed7b8ed1","updated":"2023-02-21 09:06:02.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c19fa9bc95b3f5cf7404bfbe435ebaedd1ea1995","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":52,"context_line":"        share \u003d self.create_share(name\u003dshare_name,"},{"line_number":53,"context_line":"                                  share_type_id\u003dself.share_type_id)"},{"line_number":54,"context_line":"        waiters.wait_for_resource_status("},{"line_number":55,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # create share transfer"},{"line_number":58,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"5bccb9cc_ee4d7f79","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":57},"updated":"2023-02-21 09:19:07.000000000","message":"You can remove it, it\u0027s already done in the \u0027create_shares\u0027 method.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"024c01be7b0f056dda832602faa2b8077d54929d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":52,"context_line":"        share \u003d self.create_share(name\u003dshare_name,"},{"line_number":53,"context_line":"                                  share_type_id\u003dself.share_type_id)"},{"line_number":54,"context_line":"        waiters.wait_for_resource_status("},{"line_number":55,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # create share transfer"},{"line_number":58,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"073d8648_dd31d03b","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":57},"in_reply_to":"5bccb9cc_ee4d7f79","updated":"2023-02-22 06:34:17.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        transfer_ids \u003d [tf[\u0027id\u0027] for tf in transfers]"},{"line_number":76,"context_line":"        self.assertNotIn(transfer[\u0027id\u0027], transfer_ids)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":18,"id":"185dd91f_bff8654a","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":78},"updated":"2023-02-21 05:18:14.000000000","message":"since the transfer won\u0027t happen in this test; set \"cleanup_in_class\u003dFalse\" on line 53 when creating the share, the share will be deleted after this test case is finished","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        transfer_ids \u003d [tf[\u0027id\u0027] for tf in transfers]"},{"line_number":76,"context_line":"        self.assertNotIn(transfer[\u0027id\u0027], transfer_ids)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":18,"id":"f5b8c0a3_e99d4796","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":78},"in_reply_to":"185dd91f_bff8654a","updated":"2023-02-21 09:06:02.000000000","message":"i have tried to add in patch 13. but i got error:\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/858351/11..18/manila_tempest_tests/tests/api/test_share_transfers.py#b80\n\nthen i remove it again, finally test pass.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"82bb8bb9e59864e78e53ca7b5fef048aa0d59b19","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        transfer_ids \u003d [tf[\u0027id\u0027] for tf in transfers]"},{"line_number":76,"context_line":"        self.assertNotIn(transfer[\u0027id\u0027], transfer_ids)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # delete the share"},{"line_number":79,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":80,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.idempotent_id(\u00273c2622ab-3368-4693-afb6-e60bd27e61ef\u0027)"},{"line_number":83,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3659f786_b08f3ede","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":78},"in_reply_to":"f5b8c0a3_e99d4796","updated":"2023-09-18 07:27:04.000000000","message":"Weird, this shouldn\u0027t happen.\nWhat error did you get ?","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c19fa9bc95b3f5cf7404bfbe435ebaedd1ea1995","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":87,"context_line":"        share \u003d self.create_share(name\u003dshare_name,"},{"line_number":88,"context_line":"                                  share_type_id\u003dself.share_type_id)"},{"line_number":89,"context_line":"        waiters.wait_for_resource_status("},{"line_number":90,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # create share transfer"},{"line_number":93,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"efae7aef_3f392ebe","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":57},"updated":"2023-02-21 09:19:07.000000000","message":"You can remove it.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"024c01be7b0f056dda832602faa2b8077d54929d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":87,"context_line":"        share \u003d self.create_share(name\u003dshare_name,"},{"line_number":88,"context_line":"                                  share_type_id\u003dself.share_type_id)"},{"line_number":89,"context_line":"        waiters.wait_for_resource_status("},{"line_number":90,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # create share transfer"},{"line_number":93,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"fc763ba0_6fc2a52f","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":57},"in_reply_to":"efae7aef_3f392ebe","updated":"2023-02-22 06:34:17.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"82bb8bb9e59864e78e53ca7b5fef048aa0d59b19","unresolved":true,"context_lines":[{"line_number":23,"context_line":"from manila_tempest_tests import utils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":"SHARE_TRANSFER_VERSION \u003d \"2.77\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ShareTransferTest(base.BaseSharesMixedTest):"}],"source_content_type":"text/x-python","patch_set":25,"id":"a5cb5ffd_6022c9cd","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":22},"updated":"2023-09-18 07:27:04.000000000","message":"Can you please add this new constant in this file:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/common/constants.py","commit_id":"7e1ca61974c1903573d4bbf959c48fc9d29513c1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75961739df43ba52aaa20688ba8c3fcdf4231b61","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from manila_tempest_tests import utils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":"SHARE_TRANSFER_VERSION \u003d \"2.77\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ShareTransferTest(base.BaseSharesMixedTest):"}],"source_content_type":"text/x-python","patch_set":25,"id":"0bfcf1ff_f02d5499","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":22},"in_reply_to":"a5cb5ffd_6022c9cd","updated":"2023-09-18 09:33:46.000000000","message":"Done","commit_id":"7e1ca61974c1903573d4bbf959c48fc9d29513c1"}],"manila_tempest_tests/tests/api/test_share_transfers_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"12edca836c60c8bc0063d8defe99cd5a4583fad3","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        waiters.wait_for_resource_status("},{"line_number":135,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027awaiting-transfer\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":138,"context_line":"                          self.alt_shares_v2_client.accept_share_transfer,"},{"line_number":139,"context_line":"                          transfer[\u0027id\u0027], \"\")"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # clear transfer and share"},{"line_number":142,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"fdbb52da_1fe981aa","line":139,"range":{"start_line":137,"start_character":0,"end_line":139,"end_character":45},"updated":"2023-02-04 02:26:12.000000000","message":"suggest adding another assert below for an incorrect auth key similarly","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7a5fe7addb77a3e18439863d21489bc492274ad0","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        waiters.wait_for_resource_status("},{"line_number":135,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027awaiting-transfer\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":138,"context_line":"                          self.alt_shares_v2_client.accept_share_transfer,"},{"line_number":139,"context_line":"                          transfer[\u0027id\u0027], \"\")"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # clear transfer and share"},{"line_number":142,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"7362d6bd_aba31c64","line":139,"range":{"start_line":137,"start_character":0,"end_line":139,"end_character":45},"in_reply_to":"fdbb52da_1fe981aa","updated":"2023-02-06 08:08:42.000000000","message":"i will add the test.","commit_id":"33efe39724c92afa92865d3df043583a1e5a5139"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareTransferNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        # create share_type with dhss\u003dFalse"},{"line_number":45,"context_line":"        extra_specs \u003d {\"driver_handles_share_servers\": \"False\"}"},{"line_number":46,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":47,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"430d350f_18e4970b","line":45,"range":{"start_line":45,"start_character":22,"end_line":45,"end_character":63},"updated":"2023-02-21 05:18:14.000000000","message":"self.add_extra_specs_to_dict()","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareTransferNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        # create share_type with dhss\u003dFalse"},{"line_number":45,"context_line":"        extra_specs \u003d {\"driver_handles_share_servers\": \"False\"}"},{"line_number":46,"context_line":"        cls.share_type \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":47,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"582797d1_ad6557bf","line":45,"range":{"start_line":45,"start_character":22,"end_line":45,"end_character":63},"in_reply_to":"430d350f_18e4970b","updated":"2023-02-21 09:06:02.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @decorators.idempotent_id(\u0027baf66f62-253e-40dd-a6a9-109bc7613e52\u0027)"},{"line_number":50,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":51,"context_line":"    def test_show_transfer_of_other_tenants(self):"},{"line_number":52,"context_line":"        # create share"},{"line_number":53,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"881ba464_753991e9","line":50,"range":{"start_line":50,"start_character":37,"end_line":50,"end_character":44},"updated":"2023-02-21 05:18:14.000000000","message":"TAG_API_WITH_BACKEND\n\n\nany test that creates a share also needs the manila-share manager service with a backend.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @decorators.idempotent_id(\u0027baf66f62-253e-40dd-a6a9-109bc7613e52\u0027)"},{"line_number":50,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":51,"context_line":"    def test_show_transfer_of_other_tenants(self):"},{"line_number":52,"context_line":"        # create share"},{"line_number":53,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"2aa0786f_bdbfb187","line":50,"range":{"start_line":50,"start_character":37,"end_line":50,"end_character":44},"in_reply_to":"881ba464_753991e9","updated":"2023-02-21 09:06:02.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c19fa9bc95b3f5cf7404bfbe435ebaedd1ea1995","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        share \u003d self.create_share("},{"line_number":55,"context_line":"            name\u003dshare_name,"},{"line_number":56,"context_line":"            share_type_id\u003dself.share_type_id)"},{"line_number":57,"context_line":"        waiters.wait_for_resource_status("},{"line_number":58,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # create share transfer"},{"line_number":61,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"b1d473f9_73833e9b","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":57},"updated":"2023-02-21 09:19:07.000000000","message":"You can remove it.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"024c01be7b0f056dda832602faa2b8077d54929d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        share \u003d self.create_share("},{"line_number":55,"context_line":"            name\u003dshare_name,"},{"line_number":56,"context_line":"            share_type_id\u003dself.share_type_id)"},{"line_number":57,"context_line":"        waiters.wait_for_resource_status("},{"line_number":58,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # create share transfer"},{"line_number":61,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"f27f8612_2ec32e31","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":57},"in_reply_to":"b1d473f9_73833e9b","updated":"2023-02-22 06:34:17.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":71,"context_line":"        waiters.wait_for_resource_status("},{"line_number":72,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":75,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u00274b9e75b1-4ac6-4111-b09e-e6dacd0ac2c3\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":18,"id":"28b7096b_8050d35d","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":78},"updated":"2023-02-21 05:18:14.000000000","message":"add cleanup_in_class\u003dFalse on line 56 instead","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":71,"context_line":"        waiters.wait_for_resource_status("},{"line_number":72,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":75,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u00274b9e75b1-4ac6-4111-b09e-e6dacd0ac2c3\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":18,"id":"cc4397b3_69b127dd","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":78},"in_reply_to":"28b7096b_8050d35d","updated":"2023-02-21 09:06:02.000000000","message":"i have tried to add in patch 13. but i got error:\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/858351/11..18/manila_tempest_tests/tests/api/test_share_transfers.py#b80\n\nthen i remove it again, finally test pass. this will make sure share has been deleted before delete share type.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u00274b9e75b1-4ac6-4111-b09e-e6dacd0ac2c3\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":79,"context_line":"    def test_show_nonexistent_transfer(self):"},{"line_number":80,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":81,"context_line":"                          self.shares_v2_client.get_share_transfer,"}],"source_content_type":"text/x-python","patch_set":18,"id":"d8ba7ac1_c0d4e6d0","line":78,"range":{"start_line":78,"start_character":37,"end_line":78,"end_character":44},"updated":"2023-02-21 05:18:14.000000000","message":"this is the correct use of TAG_API","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u00274b9e75b1-4ac6-4111-b09e-e6dacd0ac2c3\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":79,"context_line":"    def test_show_nonexistent_transfer(self):"},{"line_number":80,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":81,"context_line":"                          self.shares_v2_client.get_share_transfer,"}],"source_content_type":"text/x-python","patch_set":18,"id":"a807b3ba_0daf3183","line":78,"range":{"start_line":78,"start_character":37,"end_line":78,"end_character":44},"in_reply_to":"d8ba7ac1_c0d4e6d0","updated":"2023-02-21 09:06:02.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":82,"context_line":"                          str(uuidutils.generate_uuid()))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @decorators.idempotent_id(\u0027b3e26356-5eb0-4f73-b5a7-d3594cc2f30e\u0027)"},{"line_number":85,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":86,"context_line":"    def test_delete_transfer_of_other_tenants(self):"},{"line_number":87,"context_line":"        # create share"},{"line_number":88,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"1b688f4c_0fc837f6","line":85,"range":{"start_line":85,"start_character":37,"end_line":85,"end_character":44},"updated":"2023-02-21 05:18:14.000000000","message":"TAG_API_WITH_BACKEND","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                          str(uuidutils.generate_uuid()))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @decorators.idempotent_id(\u0027b3e26356-5eb0-4f73-b5a7-d3594cc2f30e\u0027)"},{"line_number":85,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":86,"context_line":"    def test_delete_transfer_of_other_tenants(self):"},{"line_number":87,"context_line":"        # create share"},{"line_number":88,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"35d5366f_fb4acd3e","line":85,"range":{"start_line":85,"start_character":37,"end_line":85,"end_character":44},"in_reply_to":"1b688f4c_0fc837f6","updated":"2023-02-21 09:06:02.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c19fa9bc95b3f5cf7404bfbe435ebaedd1ea1995","unresolved":true,"context_lines":[{"line_number":89,"context_line":"        share \u003d self.create_share("},{"line_number":90,"context_line":"            name\u003dshare_name,"},{"line_number":91,"context_line":"            share_type_id\u003dself.share_type_id)"},{"line_number":92,"context_line":"        waiters.wait_for_resource_status("},{"line_number":93,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # create share transfer"},{"line_number":96,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"532065ce_182d5daf","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":57},"updated":"2023-02-21 09:19:07.000000000","message":"You can remove it.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"024c01be7b0f056dda832602faa2b8077d54929d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        share \u003d self.create_share("},{"line_number":90,"context_line":"            name\u003dshare_name,"},{"line_number":91,"context_line":"            share_type_id\u003dself.share_type_id)"},{"line_number":92,"context_line":"        waiters.wait_for_resource_status("},{"line_number":93,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # create share transfer"},{"line_number":96,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"d84057bd_628324f3","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":57},"in_reply_to":"532065ce_182d5daf","updated":"2023-02-22 06:34:17.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c19fa9bc95b3f5cf7404bfbe435ebaedd1ea1995","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        waiters.wait_for_resource_status("},{"line_number":93,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # create share transfer"},{"line_number":96,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("},{"line_number":97,"context_line":"            share[\u0027id\u0027])[\u0027transfer\u0027]"},{"line_number":98,"context_line":"        waiters.wait_for_resource_status("},{"line_number":99,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027awaiting_transfer\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":102,"context_line":"                          self.alt_shares_v2_client.delete_share_transfer,"},{"line_number":103,"context_line":"                          transfer[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # clear transfer and share"},{"line_number":106,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":107,"context_line":"        waiters.wait_for_resource_status("},{"line_number":108,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"}],"source_content_type":"text/x-python","patch_set":18,"id":"0a2d75bf_4cb10489","line":108,"range":{"start_line":95,"start_character":0,"end_line":108,"end_character":57},"updated":"2023-02-21 09:19:07.000000000","message":"Since this code is repeated in many tests.\nI would suggest to create an inner helper method:\ndef _transfer_share(self, share):\n        transfer \u003d self.shares_v2_client.create_share_transfer(\n            share[\u0027id\u0027], name\u003d\u0027tempest_share_transfer\u0027)[\u0027transfer\u0027]\n        waiters.wait_for_resource_status(\n            self.shares_client, share[\u0027id\u0027], \u0027awaiting_transfer\u0027)\n        self.addCleanup(waiters.wait_for_resource_status, self.shares_client, share[\u0027id\u0027], \u0027available\u0027)\n        self.addCleanup(self.shares_v2_client.delete_share_transfer, transfer[\u0027id\u0027])","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"024c01be7b0f056dda832602faa2b8077d54929d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        waiters.wait_for_resource_status("},{"line_number":93,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # create share transfer"},{"line_number":96,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("},{"line_number":97,"context_line":"            share[\u0027id\u0027])[\u0027transfer\u0027]"},{"line_number":98,"context_line":"        waiters.wait_for_resource_status("},{"line_number":99,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027awaiting_transfer\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":102,"context_line":"                          self.alt_shares_v2_client.delete_share_transfer,"},{"line_number":103,"context_line":"                          transfer[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # clear transfer and share"},{"line_number":106,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":107,"context_line":"        waiters.wait_for_resource_status("},{"line_number":108,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"}],"source_content_type":"text/x-python","patch_set":18,"id":"1d09dd6c_ba16c0c2","line":108,"range":{"start_line":95,"start_character":0,"end_line":108,"end_character":57},"in_reply_to":"0a2d75bf_4cb10489","updated":"2023-02-22 06:34:17.000000000","message":"i have create two innner method:\n1:  def _create_share_transfer(self, share):\n2:  def _clear_transfer_and_share(self, transfer, share):","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0a7629dbefa9ff19090e911a76971127fb436bdc","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        waiters.wait_for_resource_status("},{"line_number":93,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # create share transfer"},{"line_number":96,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("},{"line_number":97,"context_line":"            share[\u0027id\u0027])[\u0027transfer\u0027]"},{"line_number":98,"context_line":"        waiters.wait_for_resource_status("},{"line_number":99,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027awaiting_transfer\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":102,"context_line":"                          self.alt_shares_v2_client.delete_share_transfer,"},{"line_number":103,"context_line":"                          transfer[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # clear transfer and share"},{"line_number":106,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":107,"context_line":"        waiters.wait_for_resource_status("},{"line_number":108,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"}],"source_content_type":"text/x-python","patch_set":18,"id":"54040b8b_349ad231","line":108,"range":{"start_line":95,"start_character":0,"end_line":108,"end_character":57},"in_reply_to":"1d09dd6c_ba16c0c2","updated":"2023-02-22 06:57:12.000000000","message":"Thanks haixin!\nWhy not create a one method that clear the transfer at the tear down of the test, like it\u0027s done in other helper methods ?","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"24d7f4ad3adb7f1c78d851e02ecb92ebc4c57c98","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        waiters.wait_for_resource_status("},{"line_number":93,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # create share transfer"},{"line_number":96,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("},{"line_number":97,"context_line":"            share[\u0027id\u0027])[\u0027transfer\u0027]"},{"line_number":98,"context_line":"        waiters.wait_for_resource_status("},{"line_number":99,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027awaiting_transfer\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":102,"context_line":"                          self.alt_shares_v2_client.delete_share_transfer,"},{"line_number":103,"context_line":"                          transfer[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # clear transfer and share"},{"line_number":106,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":107,"context_line":"        waiters.wait_for_resource_status("},{"line_number":108,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"}],"source_content_type":"text/x-python","patch_set":18,"id":"71d05c11_0efc3cad","line":108,"range":{"start_line":95,"start_character":0,"end_line":108,"end_character":57},"in_reply_to":"54040b8b_349ad231","updated":"2023-02-22 07:09:01.000000000","message":"you mean put \nself.addCleanup(self.shares_v2_client.delete_share_transfer, transfer[\u0027id\u0027])\nself.addCleanup(waiters.wait_for_resource_status, self.shares_client, share[\u0027id\u0027], \u0027available\u0027)\ninto method of _create_share_transfer(self, share)?","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a8093425b1704e25f7415efc86fb7aa95ba0024d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        waiters.wait_for_resource_status("},{"line_number":93,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # create share transfer"},{"line_number":96,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("},{"line_number":97,"context_line":"            share[\u0027id\u0027])[\u0027transfer\u0027]"},{"line_number":98,"context_line":"        waiters.wait_for_resource_status("},{"line_number":99,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027awaiting_transfer\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":102,"context_line":"                          self.alt_shares_v2_client.delete_share_transfer,"},{"line_number":103,"context_line":"                          transfer[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # clear transfer and share"},{"line_number":106,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":107,"context_line":"        waiters.wait_for_resource_status("},{"line_number":108,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"}],"source_content_type":"text/x-python","patch_set":18,"id":"748abe3b_e43862cb","line":108,"range":{"start_line":95,"start_character":0,"end_line":108,"end_character":57},"in_reply_to":"71d05c11_0efc3cad","updated":"2023-02-22 07:43:46.000000000","message":"exactly","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3587520b045f7c5ca86b2c653c7b02e507740b6b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        waiters.wait_for_resource_status("},{"line_number":93,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # create share transfer"},{"line_number":96,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("},{"line_number":97,"context_line":"            share[\u0027id\u0027])[\u0027transfer\u0027]"},{"line_number":98,"context_line":"        waiters.wait_for_resource_status("},{"line_number":99,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027awaiting_transfer\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":102,"context_line":"                          self.alt_shares_v2_client.delete_share_transfer,"},{"line_number":103,"context_line":"                          transfer[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # clear transfer and share"},{"line_number":106,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":107,"context_line":"        waiters.wait_for_resource_status("},{"line_number":108,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"}],"source_content_type":"text/x-python","patch_set":18,"id":"76acc515_52b0e65e","line":108,"range":{"start_line":95,"start_character":0,"end_line":108,"end_character":57},"in_reply_to":"748abe3b_e43862cb","updated":"2023-02-22 09:18:53.000000000","message":"ok， let me try.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        waiters.wait_for_resource_status("},{"line_number":108,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u0027085d5971-fe6e-4497-93cb-f1eb176a10da\u0027)"},{"line_number":114,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":18,"id":"11611380_beebc5a2","line":111,"range":{"start_line":110,"start_character":0,"end_line":111,"end_character":78},"updated":"2023-02-21 05:18:14.000000000","message":"add cleanup_in_class\u003dFalse on line 91","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        waiters.wait_for_resource_status("},{"line_number":108,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":111,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u0027085d5971-fe6e-4497-93cb-f1eb176a10da\u0027)"},{"line_number":114,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":18,"id":"4c94d0cc_f17ab99a","line":111,"range":{"start_line":110,"start_character":0,"end_line":111,"end_character":78},"in_reply_to":"11611380_beebc5a2","updated":"2023-02-21 09:06:02.000000000","message":"i have tried to add in patch 13. but i got error:\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/858351/11..18/manila_tempest_tests/tests/api/test_share_transfers.py#b80\n\nthen i remove it again, finally test pass.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":118,"context_line":"                          str(uuidutils.generate_uuid()))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @decorators.idempotent_id(\u0027cc7af032-0504-417e-8ab9-73b37bed7f85\u0027)"},{"line_number":121,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":122,"context_line":"    def test_accept_transfer_without_auth_key(self):"},{"line_number":123,"context_line":"        # create share"},{"line_number":124,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"10014b8c_c32ddb95","line":121,"range":{"start_line":121,"start_character":37,"end_line":121,"end_character":44},"updated":"2023-02-21 05:18:14.000000000","message":"TAG_API_WITH_BACKEND","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                          str(uuidutils.generate_uuid()))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @decorators.idempotent_id(\u0027cc7af032-0504-417e-8ab9-73b37bed7f85\u0027)"},{"line_number":121,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":122,"context_line":"    def test_accept_transfer_without_auth_key(self):"},{"line_number":123,"context_line":"        # create share"},{"line_number":124,"context_line":"        share_name \u003d data_utils.rand_name(\"tempest-share-name\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"315f3a4b_bc76eb8c","line":121,"range":{"start_line":121,"start_character":37,"end_line":121,"end_character":44},"in_reply_to":"10014b8c_c32ddb95","updated":"2023-02-21 09:06:02.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c19fa9bc95b3f5cf7404bfbe435ebaedd1ea1995","unresolved":true,"context_lines":[{"line_number":125,"context_line":"        share \u003d self.create_share("},{"line_number":126,"context_line":"            name\u003dshare_name,"},{"line_number":127,"context_line":"            share_type_id\u003dself.share_type_id)"},{"line_number":128,"context_line":"        waiters.wait_for_resource_status("},{"line_number":129,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # create share transfer"},{"line_number":132,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"7331d775_fde54a21","line":129,"range":{"start_line":128,"start_character":0,"end_line":129,"end_character":57},"updated":"2023-02-21 09:19:07.000000000","message":"You can remove it.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"024c01be7b0f056dda832602faa2b8077d54929d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        share \u003d self.create_share("},{"line_number":126,"context_line":"            name\u003dshare_name,"},{"line_number":127,"context_line":"            share_type_id\u003dself.share_type_id)"},{"line_number":128,"context_line":"        waiters.wait_for_resource_status("},{"line_number":129,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # create share transfer"},{"line_number":132,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"6b7ce583_c0a3fae1","line":129,"range":{"start_line":128,"start_character":0,"end_line":129,"end_character":57},"in_reply_to":"7331d775_fde54a21","updated":"2023-02-22 06:34:17.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":143,"context_line":"        waiters.wait_for_resource_status("},{"line_number":144,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":147,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @decorators.idempotent_id(\u002705a6a345-7609-421f-be21-d79041970674\u0027)"},{"line_number":150,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":18,"id":"cafd6d6d_c572150b","line":147,"range":{"start_line":145,"start_character":0,"end_line":147,"end_character":78},"updated":"2023-02-21 05:18:14.000000000","message":"add cleanup_in_class\u003dFalse on line 127 instead","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":143,"context_line":"        waiters.wait_for_resource_status("},{"line_number":144,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":147,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @decorators.idempotent_id(\u002705a6a345-7609-421f-be21-d79041970674\u0027)"},{"line_number":150,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":18,"id":"4996375d_5127bd94","line":147,"range":{"start_line":145,"start_character":0,"end_line":147,"end_character":78},"in_reply_to":"cafd6d6d_c572150b","updated":"2023-02-21 09:06:02.000000000","message":"i have tried to add in patch 13. but i got error:\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/858351/11..18/manila_tempest_tests/tests/api/test_share_transfers.py#b80\n\nthen i remove it again, finally test pass.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c19fa9bc95b3f5cf7404bfbe435ebaedd1ea1995","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        share \u003d self.create_share("},{"line_number":155,"context_line":"            name\u003dshare_name,"},{"line_number":156,"context_line":"            share_type_id\u003dself.share_type_id)"},{"line_number":157,"context_line":"        waiters.wait_for_resource_status("},{"line_number":158,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # create share transfer"},{"line_number":161,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"e9b303b9_11240ed5","line":158,"range":{"start_line":157,"start_character":0,"end_line":158,"end_character":57},"updated":"2023-02-21 09:19:07.000000000","message":"You can remove it.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"024c01be7b0f056dda832602faa2b8077d54929d","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        share \u003d self.create_share("},{"line_number":155,"context_line":"            name\u003dshare_name,"},{"line_number":156,"context_line":"            share_type_id\u003dself.share_type_id)"},{"line_number":157,"context_line":"        waiters.wait_for_resource_status("},{"line_number":158,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # create share transfer"},{"line_number":161,"context_line":"        transfer \u003d self.shares_v2_client.create_share_transfer("}],"source_content_type":"text/x-python","patch_set":18,"id":"b38305e7_a2e9fc82","line":158,"range":{"start_line":157,"start_character":0,"end_line":158,"end_character":57},"in_reply_to":"e9b303b9_11240ed5","updated":"2023-02-22 06:34:17.000000000","message":"Done","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"329944cdf48f9209ec9e23c365cb5c298e368c8b","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":172,"context_line":"        waiters.wait_for_resource_status("},{"line_number":173,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":176,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"}],"source_content_type":"text/x-python","patch_set":18,"id":"de2730b1_08ccf96a","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":78},"updated":"2023-02-21 05:18:14.000000000","message":"add cleanup_in_class on line 158 instead","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c1b219b8a56a355b16d55df555f6bf8632147f2c","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        self.shares_v2_client.delete_share_transfer(transfer[\u0027id\u0027])"},{"line_number":172,"context_line":"        waiters.wait_for_resource_status("},{"line_number":173,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":176,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\"id\"])"}],"source_content_type":"text/x-python","patch_set":18,"id":"7478dddc_41f94163","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":78},"in_reply_to":"de2730b1_08ccf96a","updated":"2023-02-21 09:06:02.000000000","message":"i have tried to add in patch 13. but i got error:\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/858351/11..18/manila_tempest_tests/tests/api/test_share_transfers.py#b80\n\nthen i remove it again, finally test pass.","commit_id":"c3f38525519c3645475373191cd14b995c167d13"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0cc5bb3ab55c723e08d756aebda0197a8c0de921","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        waiters.wait_for_resource_status("},{"line_number":53,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027awaiting_transfer\u0027)"},{"line_number":54,"context_line":"        # clean transfer"},{"line_number":55,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share_transfer,"},{"line_number":56,"context_line":"                        transfer[\u0027id\u0027])"},{"line_number":57,"context_line":"        self.addCleanup(waiters.wait_for_resource_status, self.shares_client,"},{"line_number":58,"context_line":"                        share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":59,"context_line":"        # clean share"},{"line_number":60,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share,"},{"line_number":61,"context_line":"                        share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"1998f0d0_e4c9cdac","line":58,"range":{"start_line":55,"start_character":0,"end_line":58,"end_character":49},"updated":"2023-02-22 09:37:31.000000000","message":"It\u0027s going to fail because of a timeout, because you wait before you delete.\n\nYou can try this:\n\ndef _create_share_transfer(self, share):\n        transfer \u003d self.shares_v2_client.create_share_transfer(\n            share[\u0027id\u0027], name\u003d\u0027tempest_share_transfer\u0027)[\u0027transfer\u0027]\n        waiters.wait_for_resource_status(\n            self.shares_client, share[\u0027id\u0027], \u0027awaiting_transfer\u0027)\n        self.addCleanup(waiters.wait_for_resource_status, self.shares_client, \n                        share[\u0027id\u0027], \u0027available\u0027)\n        self.addCleanup(self.shares_v2_client.delete_share_transfer, transfer[\u0027id\u0027])","commit_id":"9131cee00f64be8ef7cc42006a1bf726bec03504"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"34cab6076c61a064dd737c60431b036807bea388","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        waiters.wait_for_resource_status("},{"line_number":53,"context_line":"            self.shares_client, share[\u0027id\u0027], \u0027awaiting_transfer\u0027)"},{"line_number":54,"context_line":"        # clean transfer"},{"line_number":55,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share_transfer,"},{"line_number":56,"context_line":"                        transfer[\u0027id\u0027])"},{"line_number":57,"context_line":"        self.addCleanup(waiters.wait_for_resource_status, self.shares_client,"},{"line_number":58,"context_line":"                        share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":59,"context_line":"        # clean share"},{"line_number":60,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share,"},{"line_number":61,"context_line":"                        share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"f59ffb39_03e85141","line":58,"range":{"start_line":55,"start_character":0,"end_line":58,"end_character":49},"in_reply_to":"1998f0d0_e4c9cdac","updated":"2023-02-22 09:52:39.000000000","message":"Done","commit_id":"9131cee00f64be8ef7cc42006a1bf726bec03504"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0cc5bb3ab55c723e08d756aebda0197a8c0de921","unresolved":true,"context_lines":[{"line_number":56,"context_line":"                        transfer[\u0027id\u0027])"},{"line_number":57,"context_line":"        self.addCleanup(waiters.wait_for_resource_status, self.shares_client,"},{"line_number":58,"context_line":"                        share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":59,"context_line":"        # clean share"},{"line_number":60,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share,"},{"line_number":61,"context_line":"                        share[\u0027id\u0027])"},{"line_number":62,"context_line":"        self.addCleanup(self.shares_v2_client.wait_for_resource_deletion,"},{"line_number":63,"context_line":"                        share_id\u003dshare[\u0027id\u0027])"},{"line_number":64,"context_line":"        return transfer"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027baf66f62-253e-40dd-a6a9-109bc7613e52\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"23e36210_94d20400","line":63,"range":{"start_line":59,"start_character":0,"end_line":63,"end_character":45},"updated":"2023-02-22 09:37:31.000000000","message":"You should remove it, it\u0027s already done in create_share method","commit_id":"9131cee00f64be8ef7cc42006a1bf726bec03504"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"34cab6076c61a064dd737c60431b036807bea388","unresolved":true,"context_lines":[{"line_number":56,"context_line":"                        transfer[\u0027id\u0027])"},{"line_number":57,"context_line":"        self.addCleanup(waiters.wait_for_resource_status, self.shares_client,"},{"line_number":58,"context_line":"                        share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":59,"context_line":"        # clean share"},{"line_number":60,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share,"},{"line_number":61,"context_line":"                        share[\u0027id\u0027])"},{"line_number":62,"context_line":"        self.addCleanup(self.shares_v2_client.wait_for_resource_deletion,"},{"line_number":63,"context_line":"                        share_id\u003dshare[\u0027id\u0027])"},{"line_number":64,"context_line":"        return transfer"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027baf66f62-253e-40dd-a6a9-109bc7613e52\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"a4e064a1_a6ebc5e3","line":63,"range":{"start_line":59,"start_character":0,"end_line":63,"end_character":45},"in_reply_to":"23e36210_94d20400","updated":"2023-02-22 09:52:39.000000000","message":"really? I haven\u0027t been able to find where this step is executed, so just try to\nremote it.","commit_id":"9131cee00f64be8ef7cc42006a1bf726bec03504"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"82bb8bb9e59864e78e53ca7b5fef048aa0d59b19","unresolved":true,"context_lines":[{"line_number":25,"context_line":"from manila_tempest_tests import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":"SHARE_TRANSFER_VERSION \u003d \"2.77\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareTransferNegativeTest(base.BaseSharesMixedTest):"}],"source_content_type":"text/x-python","patch_set":25,"id":"baa355f8_bdbdf746","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":22},"updated":"2023-09-18 07:27:04.000000000","message":"Same","commit_id":"7e1ca61974c1903573d4bbf959c48fc9d29513c1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75961739df43ba52aaa20688ba8c3fcdf4231b61","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from manila_tempest_tests import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":"SHARE_TRANSFER_VERSION \u003d \"2.77\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareTransferNegativeTest(base.BaseSharesMixedTest):"}],"source_content_type":"text/x-python","patch_set":25,"id":"b844093a_fbc6b333","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":22},"in_reply_to":"baa355f8_bdbdf746","updated":"2023-09-18 09:33:46.000000000","message":"Done","commit_id":"7e1ca61974c1903573d4bbf959c48fc9d29513c1"}]}