)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"40c5d1a99c7b65f8ecfc6b764c5fb718668b76fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e188eaf2_ff145fe6","updated":"2022-09-19 20:59:33.000000000","message":"run-DellEMC Unity CI","commit_id":"5c01fe6ab59f1d5c5f48b0b9504f267f97dd5fa4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a5d27ec516dd3f7822e2237b259baa85dbd7c068","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"773de0f6_f7e2b3be","updated":"2022-09-22 22:52:30.000000000","message":"Hi Nahim, thanks for working on this! a question inline.","commit_id":"d8995a489f8e1ac9a7d637fc78567aba44e1f6d6"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"69f3d1e92859a54f020cf56365653e46dce4c453","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"09b7800f_4b29defa","updated":"2022-09-23 13:37:45.000000000","message":"Thanks, Goutham. I replied your question inline.","commit_id":"d8995a489f8e1ac9a7d637fc78567aba44e1f6d6"},{"author":{"_account_id":35049,"name":"Helena","email":"helenamylena@gmail.com","username":"helenadantas"},"change_message_id":"4c997083e40a65e69382299851351c693c702c79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"576d0db8_a18f0ed5","updated":"2022-09-20 15:34:01.000000000","message":"run-DellEMC Unity CI","commit_id":"d8995a489f8e1ac9a7d637fc78567aba44e1f6d6"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"de75fa1d303a56a3169dc4ce6834acc91e025fc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f0914068_f96711e4","updated":"2022-10-27 12:50:48.000000000","message":"\u003e Patch Set 3:\n\u003e \n\u003e Build failed.\n\u003e \n\u003e - manila-tempest-plugin-ontap-dhss https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/48/858448/3/upstream-check/manila-tempest-plugin-ontap-dhss/8ce7f5b/ : FAILURE in 2h 09m 36s\n\u003e - manila-tempest-plugin-ontap-no-dhss https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/48/858448/3/upstream-check/manila-tempest-plugin-ontap-no-dhss/4378f28/ : SUCCESS in 1h 57m 25s\n\u003e \n\u003e Comment \"run-NetApp CI\" to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_CI\n\nrun-NetApp CI","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"de8edc88633f710ce13a45e5c2d53169c424487b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"484b985e_357eeaf2","updated":"2023-03-02 12:54:20.000000000","message":"LGTM, just need to fix the goutham points","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0e271a48c4c7896779472c71d4924927e168c515","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"40bbdffa_7c00514d","updated":"2023-01-25 13:31:32.000000000","message":"LGTM, thanks Nahim! Will try to get some NetApp CI logs on this","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"11599549eac1d4ea156f2318654d241dcb39fedb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cf7e4600_9fe433e1","updated":"2023-04-05 10:31:18.000000000","message":"Looks good barring previous comments. Thanks!","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0168cbf5804ac2113bdbd3854975976608fc3964","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c3397c24_9015d8a9","updated":"2023-01-28 03:03:57.000000000","message":"The code looks better now thanks Nahim, except there are a couple of redundant definitions that we could drop.. ","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"6f3ffb37d3266854b5590da287c604d6ab50124b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"59d8f6fb_430d4d6b","updated":"2022-10-27 14:14:05.000000000","message":"run-NetApp CI","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4fc3659e1f3de5b2343070cc6226edbcb4f889d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f73fdbb8_afd20ad7","updated":"2023-01-25 13:31:41.000000000","message":"run-NetApp CI","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"998b01236bfc26d6cd74dbc823c0ac6126481fb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa07180b_b14ec0a1","updated":"2023-08-02 21:39:26.000000000","message":"LGTM, thanks Nahim and Helena","commit_id":"ab1c39cc29a0f00c3be79c1ff677cc1a4c30ee42"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f235ebe2140d78f65c3d4a8aefeb7bcea8b1261b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"27895aa6_94d01160","updated":"2023-07-31 14:42:59.000000000","message":"Thank you Nahim!","commit_id":"ab1c39cc29a0f00c3be79c1ff677cc1a4c30ee42"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"db4fc842cfa1afee004cfc4e73ff32c08ffa2b6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"99573443_db91fe3a","updated":"2023-07-31 12:40:41.000000000","message":"Thanks for the reviews, I uploaded a new patch set with the fixes.","commit_id":"ab1c39cc29a0f00c3be79c1ff677cc1a4c30ee42"},{"author":{"_account_id":36135,"name":"zhenghuijuan","display_name":"zhenghuijuan","email":"Zheng.Huijuan@dellteam.com","username":"zhenghuijuan"},"change_message_id":"1bd61975622c7f1ec0938c312e5a5c2ae2321759","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"56642820_8e9074fa","updated":"2023-09-13 07:12:02.000000000","message":"run DellEMC Unity CI","commit_id":"ab1c39cc29a0f00c3be79c1ff677cc1a4c30ee42"},{"author":{"_account_id":36135,"name":"zhenghuijuan","display_name":"zhenghuijuan","email":"Zheng.Huijuan@dellteam.com","username":"zhenghuijuan"},"change_message_id":"db80bfc82e641514100ae51a5dbe02a50641d031","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"268459ba_0eaef183","updated":"2023-09-14 02:02:53.000000000","message":"run-DellEMC Unity CI","commit_id":"ab1c39cc29a0f00c3be79c1ff677cc1a4c30ee42"},{"author":{"_account_id":36135,"name":"zhenghuijuan","display_name":"zhenghuijuan","email":"Zheng.Huijuan@dellteam.com","username":"zhenghuijuan"},"change_message_id":"1155f5554a480414d963d298e0302e72160747d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"49b90888_4037488f","updated":"2023-09-13 07:07:09.000000000","message":"run-DellEMC Unity CI","commit_id":"ab1c39cc29a0f00c3be79c1ff677cc1a4c30ee42"},{"author":{"_account_id":36135,"name":"zhenghuijuan","display_name":"zhenghuijuan","email":"Zheng.Huijuan@dellteam.com","username":"zhenghuijuan"},"change_message_id":"be9814ee6793f67c7ec4a8994db4a60ce629b6a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"65af0dbe_046c0164","updated":"2023-09-13 07:19:32.000000000","message":"run-DellEMC Unity CI","commit_id":"ab1c39cc29a0f00c3be79c1ff677cc1a4c30ee42"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0168cbf5804ac2113bdbd3854975976608fc3964","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        super(BaseSharesTest, cls).setup_clients()"},{"line_number":151,"context_line":"        os \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":152,"context_line":"        # Initialise share clients for test credentials"},{"line_number":153,"context_line":"        cls.shares_client \u003d os.share_v1.SharesClient()"},{"line_number":154,"context_line":"        cls.shares_v2_client \u003d os.share_v2.SharesV2Client()"},{"line_number":155,"context_line":"        # Initialise network clients for test credentials"},{"line_number":156,"context_line":"        cls.networks_client \u003d None"},{"line_number":157,"context_line":"        cls.subnets_client \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"81a35cc7_ec710ae5","line":154,"range":{"start_line":153,"start_character":0,"end_line":154,"end_character":59},"updated":"2023-01-28 03:03:57.000000000","message":"These are already defined here","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"db4fc842cfa1afee004cfc4e73ff32c08ffa2b6e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        super(BaseSharesTest, cls).setup_clients()"},{"line_number":151,"context_line":"        os \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":152,"context_line":"        # Initialise share clients for test credentials"},{"line_number":153,"context_line":"        cls.shares_client \u003d os.share_v1.SharesClient()"},{"line_number":154,"context_line":"        cls.shares_v2_client \u003d os.share_v2.SharesV2Client()"},{"line_number":155,"context_line":"        # Initialise network clients for test credentials"},{"line_number":156,"context_line":"        cls.networks_client \u003d None"},{"line_number":157,"context_line":"        cls.subnets_client \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"e61908cb_415515b0","line":154,"range":{"start_line":153,"start_character":0,"end_line":154,"end_character":59},"in_reply_to":"81a35cc7_ec710ae5","updated":"2023-07-31 12:40:41.000000000","message":"Ack","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0168cbf5804ac2113bdbd3854975976608fc3964","unresolved":true,"context_lines":[{"line_number":169,"context_line":"                    \"CONF.share.create_networks_when_multitenancy_enabled \""},{"line_number":170,"context_line":"                    \"is set to True\")"},{"line_number":171,"context_line":"            share_network_id \u003d cls.provide_share_network("},{"line_number":172,"context_line":"                cls.shares_client, cls.networks_client)"},{"line_number":173,"context_line":"            cls.shares_client.share_network_id \u003d share_network_id"},{"line_number":174,"context_line":"            cls.shares_v2_client.share_network_id \u003d share_network_id"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def setUp(self):"},{"line_number":177,"context_line":"        super(BaseSharesTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"637bb9fa_45a8b613","line":174,"range":{"start_line":172,"start_character":55,"end_line":174,"end_character":68},"updated":"2023-01-28 03:03:57.000000000","message":"These are already defined here","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"db4fc842cfa1afee004cfc4e73ff32c08ffa2b6e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                    \"CONF.share.create_networks_when_multitenancy_enabled \""},{"line_number":170,"context_line":"                    \"is set to True\")"},{"line_number":171,"context_line":"            share_network_id \u003d cls.provide_share_network("},{"line_number":172,"context_line":"                cls.shares_client, cls.networks_client)"},{"line_number":173,"context_line":"            cls.shares_client.share_network_id \u003d share_network_id"},{"line_number":174,"context_line":"            cls.shares_v2_client.share_network_id \u003d share_network_id"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def setUp(self):"},{"line_number":177,"context_line":"        super(BaseSharesTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"8428a6af_c0707130","line":174,"range":{"start_line":172,"start_character":55,"end_line":174,"end_character":68},"in_reply_to":"637bb9fa_45a8b613","updated":"2023-07-31 12:40:41.000000000","message":"Ack","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0168cbf5804ac2113bdbd3854975976608fc3964","unresolved":true,"context_lines":[{"line_number":1270,"context_line":"        super(BaseSharesMixedTest, cls).setup_clients()"},{"line_number":1271,"context_line":"        cls.alt_shares_client \u003d cls.os_alt.share_v1.SharesClient()"},{"line_number":1272,"context_line":"        cls.alt_shares_v2_client \u003d cls.os_alt.share_v2.SharesV2Client()"},{"line_number":1273,"context_line":"        cls.shares_client \u003d cls.os.share_v1.SharesClient()"},{"line_number":1274,"context_line":"        cls.shares_v2_client \u003d cls.os.share_v2.SharesV2Client()"},{"line_number":1275,"context_line":"        # Initialise network clients"},{"line_number":1276,"context_line":"        cls.os_admin.networks_client \u003d cls.os_admin.network.NetworksClient()"},{"line_number":1277,"context_line":"        cls.os_alt.networks_client \u003d cls.os_alt.network.NetworksClient()"}],"source_content_type":"text/x-python","patch_set":3,"id":"d80378e1_d51bbbc0","line":1274,"range":{"start_line":1273,"start_character":0,"end_line":1274,"end_character":63},"updated":"2023-01-28 03:03:57.000000000","message":"not needed, see above","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"db4fc842cfa1afee004cfc4e73ff32c08ffa2b6e","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"        super(BaseSharesMixedTest, cls).setup_clients()"},{"line_number":1271,"context_line":"        cls.alt_shares_client \u003d cls.os_alt.share_v1.SharesClient()"},{"line_number":1272,"context_line":"        cls.alt_shares_v2_client \u003d cls.os_alt.share_v2.SharesV2Client()"},{"line_number":1273,"context_line":"        cls.shares_client \u003d cls.os.share_v1.SharesClient()"},{"line_number":1274,"context_line":"        cls.shares_v2_client \u003d cls.os.share_v2.SharesV2Client()"},{"line_number":1275,"context_line":"        # Initialise network clients"},{"line_number":1276,"context_line":"        cls.os_admin.networks_client \u003d cls.os_admin.network.NetworksClient()"},{"line_number":1277,"context_line":"        cls.os_alt.networks_client \u003d cls.os_alt.network.NetworksClient()"}],"source_content_type":"text/x-python","patch_set":3,"id":"8bffed0f_6336f803","line":1274,"range":{"start_line":1273,"start_character":0,"end_line":1274,"end_character":63},"in_reply_to":"d80378e1_d51bbbc0","updated":"2023-07-31 12:40:41.000000000","message":"Done","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0168cbf5804ac2113bdbd3854975976608fc3964","unresolved":true,"context_lines":[{"line_number":1296,"context_line":"            cls.admin_shares_v2_client.share_network_id \u003d ("},{"line_number":1297,"context_line":"                admin_share_network_id)"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"            share_network_id \u003d cls.provide_share_network("},{"line_number":1300,"context_line":"                cls.shares_client, cls.networks_client)"},{"line_number":1301,"context_line":"            cls.shares_client.share_network_id \u003d share_network_id"},{"line_number":1302,"context_line":"            cls.shares_v2_client.share_network_id \u003d share_network_id"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"            alt_share_network_id \u003d cls.provide_share_network("},{"line_number":1305,"context_line":"                cls.alt_shares_v2_client, cls.os_alt.networks_client)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2f664b34_916a27ec","line":1302,"range":{"start_line":1299,"start_character":0,"end_line":1302,"end_character":68},"updated":"2023-01-28 03:03:57.000000000","message":"not needed, see above","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"db4fc842cfa1afee004cfc4e73ff32c08ffa2b6e","unresolved":false,"context_lines":[{"line_number":1296,"context_line":"            cls.admin_shares_v2_client.share_network_id \u003d ("},{"line_number":1297,"context_line":"                admin_share_network_id)"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"            share_network_id \u003d cls.provide_share_network("},{"line_number":1300,"context_line":"                cls.shares_client, cls.networks_client)"},{"line_number":1301,"context_line":"            cls.shares_client.share_network_id \u003d share_network_id"},{"line_number":1302,"context_line":"            cls.shares_v2_client.share_network_id \u003d share_network_id"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"            alt_share_network_id \u003d cls.provide_share_network("},{"line_number":1305,"context_line":"                cls.alt_shares_v2_client, cls.os_alt.networks_client)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a1ec326d_c94f94ad","line":1302,"range":{"start_line":1299,"start_character":0,"end_line":1302,"end_character":68},"in_reply_to":"2f664b34_916a27ec","updated":"2023-07-31 12:40:41.000000000","message":"Done","commit_id":"296e93b77d97381680260525d7a97d5758a246b8"}],"manila_tempest_tests/tests/api/test_share_servers_multiple_subnet_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a5d27ec516dd3f7822e2237b259baa85dbd7c068","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareServerMultipleSubNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_network \u003d cls.admin_shares_v2_client.get_share_network("},{"line_number":45,"context_line":"            cls.admin_shares_v2_client.share_network_id)[\u0027share_network\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c9ae6c0c_3298a690","line":44,"range":{"start_line":44,"start_character":32,"end_line":44,"end_character":54},"updated":"2022-09-22 22:52:30.000000000","message":"why not use shares_v2_client?","commit_id":"d8995a489f8e1ac9a7d637fc78567aba44e1f6d6"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"941a9b62a1abf8ad7b0981013af24d7ed7e7e4af","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareServerMultipleSubNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_network \u003d cls.admin_shares_v2_client.get_share_network("},{"line_number":45,"context_line":"            cls.admin_shares_v2_client.share_network_id)[\u0027share_network\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f37401a_19c7572f","line":44,"range":{"start_line":44,"start_character":32,"end_line":44,"end_character":54},"in_reply_to":"54ba25ad_af5e1c10","updated":"2022-09-29 12:18:30.000000000","message":"Thanks for the detailed explanation, Goutham. \nWe\u0027re going to work on this change and provide a new patch set.","commit_id":"d8995a489f8e1ac9a7d637fc78567aba44e1f6d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e18d20c59c92ca0975589734f4a8876f3275b897","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareServerMultipleSubNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_network \u003d cls.admin_shares_v2_client.get_share_network("},{"line_number":45,"context_line":"            cls.admin_shares_v2_client.share_network_id)[\u0027share_network\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"54ba25ad_af5e1c10","line":44,"range":{"start_line":44,"start_character":32,"end_line":44,"end_character":54},"in_reply_to":"7dae5eaf_c7aaaa66","updated":"2022-09-27 18:27:38.000000000","message":"\u003e But, I chose to use admin basically because it was already being used in the test (lines 56 and 65).\n\n\nyes - these are specifically \"admin-only\" actions - i.e., listing pools and updating share type extra specs requires admin privileges.. \n\n\u003e so I wondered if the developer mixed the names of the clients during the implementation.\n\nI think so too; the way these credentials work is explained here: https://docs.openstack.org/tempest/latest/write_tests.html#allocating-credentials\nIn our tests, we request tempest to set aside three users from three separate projects: (\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027) in the \"BaseSharesMixedTest\" class [1]. \n\n- The \"primary\" project will have a regular user called \"primary\", assigned a \"member\" role. \n- The \"alt\" project will have a regular user called \"alt\", with a \"member\" role assigned to the user. \n- The \"admin\" project will have an user called \"admin\", with the \"admin\" role. So \n\nas you can imagine, the \"admin\" user has access to project resources within \"primary\", \"alt\" and \"admin\" projects because of their role. The \"primary\" user and \"alt\" user can only operate within their assigned projects. \n\nWhen doing tests like this, we should test with the \"primary\" user so that we can test the RBAC alongside the API schema and behavior. The \"alt\" user can be used when we want to test isolation between projects - i.e., the \"alt\" user cannot access \"primary\u0027s\" resources. \n\nYou\u0027re right in fixing this up to not use the alt user - we don\u0027t need it here. We\u0027re not testing isolation; but, please use the \"primary\" user (cls.shares_v2_client) instead of the \"admin_shares_v2_client\" because the operation you\u0027re performing - getting a share network doesn\u0027t need admin privileges. \n\n\n[1] https://github.com/openstack/manila-tempest-plugin/blob/5e559df86912a5dcc8a071a64cac65e55189695a/manila_tempest_tests/tests/api/base.py#L1251","commit_id":"d8995a489f8e1ac9a7d637fc78567aba44e1f6d6"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"db4fc842cfa1afee004cfc4e73ff32c08ffa2b6e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareServerMultipleSubNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_network \u003d cls.admin_shares_v2_client.get_share_network("},{"line_number":45,"context_line":"            cls.admin_shares_v2_client.share_network_id)[\u0027share_network\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f29687b_589060b3","line":44,"range":{"start_line":44,"start_character":32,"end_line":44,"end_character":54},"in_reply_to":"9f37401a_19c7572f","updated":"2023-07-31 12:40:41.000000000","message":"Done","commit_id":"d8995a489f8e1ac9a7d637fc78567aba44e1f6d6"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"69f3d1e92859a54f020cf56365653e46dce4c453","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def resource_setup(cls):"},{"line_number":43,"context_line":"        super(ShareServerMultipleSubNegativeTest, cls).resource_setup()"},{"line_number":44,"context_line":"        cls.share_network \u003d cls.admin_shares_v2_client.get_share_network("},{"line_number":45,"context_line":"            cls.admin_shares_v2_client.share_network_id)[\u0027share_network\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7dae5eaf_c7aaaa66","line":44,"range":{"start_line":44,"start_character":32,"end_line":44,"end_character":54},"in_reply_to":"c9ae6c0c_3298a690","updated":"2022-09-23 13:37:45.000000000","message":"I don\u0027t know much about these users and roles, so I might be wrong. \n\nBut, I chose to use admin basically because it was already being used in the test (lines 56 and 65).\n\nAlso, alt_shares_v2_client and admin_shares_v2_client share networks seems to be configured in the same place [1] when multitenancy is enabled, so I wondered if the developer mixed the names of the clients during the implementation.\n\nI didn\u0027t try to use shares_v2_client. Do you think we should try that?\n\n[1] https://github.com/openstack/manila-tempest-plugin/blob/5e559df86912a5dcc8a071a64cac65e55189695a/manila_tempest_tests/tests/api/base.py#L1290","commit_id":"d8995a489f8e1ac9a7d637fc78567aba44e1f6d6"}]}