)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b0964ebd826297eb876c8581550c3e0984db6832","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"324dbda3_0958288c","updated":"2022-12-13 18:18:20.000000000","message":"Thanks for working on these tests Liron!\nThey are looking good overall, just found some things that could make the tests simpler. Thanks!","commit_id":"79880ce5b862c85fef59d95381d6720c91e145c6"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1abf52120f2cd79546ac8a23bb8af4748196214e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d54b3f99_11f77bb3","updated":"2023-03-30 09:56:23.000000000","message":"recheck","commit_id":"ea7855281dd7bd3274d9e8f6eacb99f7a8f9c3ff"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dcd8636649e11e1117897eb6e37f66ad232adc94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"6bd0eed1_8109b7b5","updated":"2023-07-21 12:43:36.000000000","message":"LGTM, thank you Liron!!","commit_id":"5bd5f54073329423bb87f0345012f40c93251c2e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e37296257c452ac0a3221e69f2018b53cca23908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e5450a17_fbdeb544","updated":"2023-07-21 00:30:18.000000000","message":"recheck\n\nunrelated test failure\n\nLGTM; please remove unicode markers if you make another patch..","commit_id":"5bd5f54073329423bb87f0345012f40c93251c2e"}],"manila_tempest_tests/tests/rbac/test_snapshots.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b0964ebd826297eb876c8581550c3e0984db6832","unresolved":true,"context_lines":[{"line_number":234,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":235,"context_line":"    def test_get_snapshot_metadata(self):"},{"line_number":236,"context_line":"        metadata \u003d {u\u0027key\u0027: u\u0027value\u0027}"},{"line_number":237,"context_line":"        snap \u003d self.create_snapshot("},{"line_number":238,"context_line":"            self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":239,"context_line":"        self.share_member_client.set_metadata("},{"line_number":240,"context_line":"            snap[\u0027id\u0027], metadata, resource\u003d\u0027snapshot\u0027)"},{"line_number":241,"context_line":"        self.do_request("},{"line_number":242,"context_line":"            \u0027get_metadata\u0027, expected_status\u003d200,"},{"line_number":243,"context_line":"            resource_id\u003dsnap[\u0027id\u0027], resource\u003d\u0027snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b12a10ce_6f9bad5a","line":240,"range":{"start_line":237,"start_character":8,"end_line":240,"end_character":54},"updated":"2022-12-13 18:18:20.000000000","message":"what if we already created the snapshot with the metadata in it?\nthat way we\u0027d avoid one more call to the API and would simplify the test, as it is supposed to test the get_metadata operation\n\nthis is valid for later in this test and in the next one as well :)","commit_id":"79880ce5b862c85fef59d95381d6720c91e145c6"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d53ad112629748b9d6482b0d21697b918664f31a","unresolved":true,"context_lines":[{"line_number":234,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":235,"context_line":"    def test_get_snapshot_metadata(self):"},{"line_number":236,"context_line":"        metadata \u003d {u\u0027key\u0027: u\u0027value\u0027}"},{"line_number":237,"context_line":"        snap \u003d self.create_snapshot("},{"line_number":238,"context_line":"            self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":239,"context_line":"        self.share_member_client.set_metadata("},{"line_number":240,"context_line":"            snap[\u0027id\u0027], metadata, resource\u003d\u0027snapshot\u0027)"},{"line_number":241,"context_line":"        self.do_request("},{"line_number":242,"context_line":"            \u0027get_metadata\u0027, expected_status\u003d200,"},{"line_number":243,"context_line":"            resource_id\u003dsnap[\u0027id\u0027], resource\u003d\u0027snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7e29c407_6d22c726","line":240,"range":{"start_line":237,"start_character":8,"end_line":240,"end_character":54},"in_reply_to":"b12a10ce_6f9bad5a","updated":"2022-12-14 09:43:10.000000000","message":"Yes, of course.\nThanks for noticing it.\nFor some reason I forgot we support snapshot creation with metadata.\nSame as done here:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_shares.py#L287","commit_id":"79880ce5b862c85fef59d95381d6720c91e145c6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b0964ebd826297eb876c8581550c3e0984db6832","unresolved":true,"context_lines":[{"line_number":408,"context_line":"    def test_get_snapshot_metadata(self):"},{"line_number":409,"context_line":"        metadata \u003d {u\u0027key\u0027: u\u0027value\u0027}"},{"line_number":410,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":411,"context_line":"        snap \u003d self.create_snapshot("},{"line_number":412,"context_line":"            share_client, self.share[\u0027id\u0027])"},{"line_number":413,"context_line":"        share_client.set_metadata(snap[\u0027id\u0027], metadata, resource\u003d\u0027snapshot\u0027)"},{"line_number":414,"context_line":"        self.do_request("},{"line_number":415,"context_line":"            \u0027get_metadata\u0027, expected_status\u003d200,"},{"line_number":416,"context_line":"            resource_id\u003dsnap[\u0027id\u0027], resource\u003d\u0027snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"e77431ea_939cdaa5","line":413,"range":{"start_line":411,"start_character":8,"end_line":413,"end_character":76},"updated":"2022-12-13 18:18:20.000000000","message":"same as above and also applies to the next test :)","commit_id":"79880ce5b862c85fef59d95381d6720c91e145c6"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d53ad112629748b9d6482b0d21697b918664f31a","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    def test_get_snapshot_metadata(self):"},{"line_number":409,"context_line":"        metadata \u003d {u\u0027key\u0027: u\u0027value\u0027}"},{"line_number":410,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":411,"context_line":"        snap \u003d self.create_snapshot("},{"line_number":412,"context_line":"            share_client, self.share[\u0027id\u0027])"},{"line_number":413,"context_line":"        share_client.set_metadata(snap[\u0027id\u0027], metadata, resource\u003d\u0027snapshot\u0027)"},{"line_number":414,"context_line":"        self.do_request("},{"line_number":415,"context_line":"            \u0027get_metadata\u0027, expected_status\u003d200,"},{"line_number":416,"context_line":"            resource_id\u003dsnap[\u0027id\u0027], resource\u003d\u0027snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"82e8f1e4_11edbd25","line":413,"range":{"start_line":411,"start_character":8,"end_line":413,"end_character":76},"in_reply_to":"e77431ea_939cdaa5","updated":"2022-12-14 09:43:10.000000000","message":"Done","commit_id":"79880ce5b862c85fef59d95381d6720c91e145c6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1f68bb3fac20cfea57e3439ec9fdb340b669714a","unresolved":true,"context_lines":[{"line_number":220,"context_line":"        snap \u003d self.create_snapshot("},{"line_number":221,"context_line":"            self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":222,"context_line":"        metadata \u003d {u\u0027key\u0027: u\u0027value\u0027}"},{"line_number":223,"context_line":"        self.do_request("},{"line_number":224,"context_line":"            \u0027set_metadata\u0027, expected_status\u003d200,"},{"line_number":225,"context_line":"            resource_id\u003dsnap[\u0027id\u0027], resource\u003d\u0027snapshot\u0027, metadata\u003dmetadata)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        alt_snap \u003d self.create_snapshot("},{"line_number":228,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"dd9916a3_ec5817ab","line":225,"range":{"start_line":223,"start_character":8,"end_line":225,"end_character":75},"updated":"2023-05-10 15:33:29.000000000","message":"This won\u0027t work with older microversions..\n\nutils.check_skip_if_microversion_not_supported(\"2.73\")","commit_id":"2d8f6b10480b34fcac3c6240fd35f3d501ad1acb"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"6de33b1dbc8e29f35352525244f5754ed60876b2","unresolved":true,"context_lines":[{"line_number":220,"context_line":"        snap \u003d self.create_snapshot("},{"line_number":221,"context_line":"            self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":222,"context_line":"        metadata \u003d {u\u0027key\u0027: u\u0027value\u0027}"},{"line_number":223,"context_line":"        self.do_request("},{"line_number":224,"context_line":"            \u0027set_metadata\u0027, expected_status\u003d200,"},{"line_number":225,"context_line":"            resource_id\u003dsnap[\u0027id\u0027], resource\u003d\u0027snapshot\u0027, metadata\u003dmetadata)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        alt_snap \u003d self.create_snapshot("},{"line_number":228,"context_line":"            self.alt_project_share_v2_client, self.alt_share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"43c30f44_c8380fa5","line":225,"range":{"start_line":223,"start_character":8,"end_line":225,"end_character":75},"in_reply_to":"dd9916a3_ec5817ab","updated":"2023-05-11 07:14:26.000000000","message":"Thanks Goutham!\nDone!","commit_id":"2d8f6b10480b34fcac3c6240fd35f3d501ad1acb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e37296257c452ac0a3221e69f2018b53cca23908","unresolved":true,"context_lines":[{"line_number":221,"context_line":"    def test_set_snapshot_metadata(self):"},{"line_number":222,"context_line":"        snap \u003d self.create_snapshot("},{"line_number":223,"context_line":"            self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":224,"context_line":"        metadata \u003d {u\u0027key\u0027: u\u0027value\u0027}"},{"line_number":225,"context_line":"        self.do_request("},{"line_number":226,"context_line":"            \u0027set_metadata\u0027, expected_status\u003d200,"},{"line_number":227,"context_line":"            resource_id\u003dsnap[\u0027id\u0027], resource\u003d\u0027snapshot\u0027, metadata\u003dmetadata)"}],"source_content_type":"text/x-python","patch_set":19,"id":"43f8b5fa_d0274d98","line":224,"range":{"start_line":224,"start_character":20,"end_line":224,"end_character":22},"updated":"2023-07-21 00:30:18.000000000","message":"these unicode markers aren\u0027t necessary..","commit_id":"5bd5f54073329423bb87f0345012f40c93251c2e"}]}