)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"12bd3701a6042adbe1b0e0205f26a336afed7d74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"174f2ab7_a8e6de61","updated":"2022-12-13 18:50:38.000000000","message":"Thanks for the work on this tests Liron!\nAdded a few comments with recommendations and questions inline, please take a look :)","commit_id":"7ca3d7b20c764b5bc653eeb63526bc1370802a18"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"4cd3f0b7a5fb75069ab425b6cbdd069e45c1b4bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"adfc0305_64d81066","updated":"2023-02-06 23:42:18.000000000","message":"Passed all checks. Thanks!","commit_id":"c99a66ea5a536041100e334ad0c025f56f4aec07"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"30d0be99557cab6b66fe5fa49dbaa1c0aa7f15b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"eaa89926_287590ff","updated":"2022-12-15 20:27:19.000000000","message":"Thank you for the changes, Liron! LGTM","commit_id":"c99a66ea5a536041100e334ad0c025f56f4aec07"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"127ff099607fd0389336a4b35b53795efd03a433","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"26e4f054_d95dc453","updated":"2023-02-08 06:43:57.000000000","message":"recheck","commit_id":"c99a66ea5a536041100e334ad0c025f56f4aec07"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"956e9982133a795f0e99cc53783dade7f0e58613","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6e3d5cf1_21f52ff2","updated":"2023-02-07 14:33:16.000000000","message":"recheck","commit_id":"c99a66ea5a536041100e334ad0c025f56f4aec07"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3447a836ef8465c6dd988c07a59d8ea0dfa42b6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8206e8ca_e92a3e63","updated":"2023-02-12 13:14:49.000000000","message":"recheck","commit_id":"c99a66ea5a536041100e334ad0c025f56f4aec07"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e18fd6762a8569cb787e28972280d1817c49f480","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b547558f_f71886d6","updated":"2023-02-12 12:47:04.000000000","message":"recheck","commit_id":"c99a66ea5a536041100e334ad0c025f56f4aec07"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cc1bd3d6b42e4c5240a4b5be5c3a4963e3411240","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f88cd86e_fb784ea5","updated":"2023-02-12 11:19:52.000000000","message":"recheck","commit_id":"c99a66ea5a536041100e334ad0c025f56f4aec07"}],"manila_tempest_tests/tests/rbac/test_rules.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"12bd3701a6042adbe1b0e0205f26a336afed7d74","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        a_type, a_to \u003d utils.get_access_rule_data_from_config(self.protocol)"},{"line_number":57,"context_line":"        access \u003d {}"},{"line_number":58,"context_line":"        access[\u0027share_id\u0027] \u003d share_id"},{"line_number":59,"context_line":"        access[\u0027access_type\u0027] \u003d a_type"},{"line_number":60,"context_line":"        access[\u0027access_to\u0027] \u003d a_to"},{"line_number":61,"context_line":"        access[\u0027access_level\u0027] \u003d access_level"},{"line_number":62,"context_line":"        return access"}],"source_content_type":"text/x-python","patch_set":8,"id":"b6561da6_9787052b","line":59,"range":{"start_line":59,"start_character":32,"end_line":59,"end_character":38},"updated":"2022-12-13 18:50:38.000000000","message":"would self.access_type work here?","commit_id":"7ca3d7b20c764b5bc653eeb63526bc1370802a18"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"30d0be99557cab6b66fe5fa49dbaa1c0aa7f15b1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        a_type, a_to \u003d utils.get_access_rule_data_from_config(self.protocol)"},{"line_number":57,"context_line":"        access \u003d {}"},{"line_number":58,"context_line":"        access[\u0027share_id\u0027] \u003d share_id"},{"line_number":59,"context_line":"        access[\u0027access_type\u0027] \u003d a_type"},{"line_number":60,"context_line":"        access[\u0027access_to\u0027] \u003d a_to"},{"line_number":61,"context_line":"        access[\u0027access_level\u0027] \u003d access_level"},{"line_number":62,"context_line":"        return access"}],"source_content_type":"text/x-python","patch_set":8,"id":"4d98dd11_37eafa7f","line":59,"range":{"start_line":59,"start_character":32,"end_line":59,"end_character":38},"in_reply_to":"83d08609_6fbd8d5a","updated":"2022-12-15 20:27:19.000000000","message":"++, thanks for the changes :)","commit_id":"7ca3d7b20c764b5bc653eeb63526bc1370802a18"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cc9c3d284a5e3cd0b86b2a3cfda333f6c7860f12","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        a_type, a_to \u003d utils.get_access_rule_data_from_config(self.protocol)"},{"line_number":57,"context_line":"        access \u003d {}"},{"line_number":58,"context_line":"        access[\u0027share_id\u0027] \u003d share_id"},{"line_number":59,"context_line":"        access[\u0027access_type\u0027] \u003d a_type"},{"line_number":60,"context_line":"        access[\u0027access_to\u0027] \u003d a_to"},{"line_number":61,"context_line":"        access[\u0027access_level\u0027] \u003d access_level"},{"line_number":62,"context_line":"        return access"}],"source_content_type":"text/x-python","patch_set":8,"id":"83d08609_6fbd8d5a","line":59,"range":{"start_line":59,"start_character":32,"end_line":59,"end_character":38},"in_reply_to":"b6561da6_9787052b","updated":"2022-12-14 11:33:32.000000000","message":"Good catch man!\nSo we can remove L56","commit_id":"7ca3d7b20c764b5bc653eeb63526bc1370802a18"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"12bd3701a6042adbe1b0e0205f26a336afed7d74","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        access \u003d {}"},{"line_number":58,"context_line":"        access[\u0027share_id\u0027] \u003d share_id"},{"line_number":59,"context_line":"        access[\u0027access_type\u0027] \u003d a_type"},{"line_number":60,"context_line":"        access[\u0027access_to\u0027] \u003d a_to"},{"line_number":61,"context_line":"        access[\u0027access_level\u0027] \u003d access_level"},{"line_number":62,"context_line":"        return access"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"a9230905_535d9d1e","line":60,"range":{"start_line":60,"start_character":30,"end_line":60,"end_character":34},"updated":"2022-12-13 18:50:38.000000000","message":"same for self.access_To","commit_id":"7ca3d7b20c764b5bc653eeb63526bc1370802a18"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cc9c3d284a5e3cd0b86b2a3cfda333f6c7860f12","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        access \u003d {}"},{"line_number":58,"context_line":"        access[\u0027share_id\u0027] \u003d share_id"},{"line_number":59,"context_line":"        access[\u0027access_type\u0027] \u003d a_type"},{"line_number":60,"context_line":"        access[\u0027access_to\u0027] \u003d a_to"},{"line_number":61,"context_line":"        access[\u0027access_level\u0027] \u003d access_level"},{"line_number":62,"context_line":"        return access"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"d2321a04_8aa8ec7b","line":60,"range":{"start_line":60,"start_character":30,"end_line":60,"end_character":34},"in_reply_to":"a9230905_535d9d1e","updated":"2022-12-14 11:33:32.000000000","message":"Done","commit_id":"7ca3d7b20c764b5bc653eeb63526bc1370802a18"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"12bd3701a6042adbe1b0e0205f26a336afed7d74","unresolved":true,"context_lines":[{"line_number":255,"context_line":"            cls.alt_project_share_v2_client, share_type[\u0027id\u0027])"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @decorators.idempotent_id(\u0027de643909-88a2-470b-8a14-0417696ec451\u0027)"},{"line_number":258,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":259,"context_line":"    def test_get_access(self):"},{"line_number":260,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":261,"context_line":"        access \u003d self.allow_access("}],"source_content_type":"text/x-python","patch_set":8,"id":"660f360a_d3d212e4","line":258,"range":{"start_line":258,"start_character":18,"end_line":258,"end_character":30},"updated":"2022-12-13 18:50:38.000000000","message":"I\u0027m a bit confused, this could be positive, right? Asking just because I saw it being handled differently in another test:\n\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/862800/6/manila_tempest_tests/tests/rbac/test_quotas.py#199\n\nIn the test, we have kind of the same scenario, it is a member test, the in-project operation succeeds but the cross-project operation fails. That is kinda confusing to me, but I\u0027m up to whatever we\u0027d like to go, just would like to have the consistency between them, otherwise this can get confusing for other people implementing the tests :)\n\nI see the same happening below, so I\u0027d say either keep like this and change in the other tests implementation, or change it here :)","commit_id":"7ca3d7b20c764b5bc653eeb63526bc1370802a18"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cc9c3d284a5e3cd0b86b2a3cfda333f6c7860f12","unresolved":true,"context_lines":[{"line_number":255,"context_line":"            cls.alt_project_share_v2_client, share_type[\u0027id\u0027])"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @decorators.idempotent_id(\u0027de643909-88a2-470b-8a14-0417696ec451\u0027)"},{"line_number":258,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":259,"context_line":"    def test_get_access(self):"},{"line_number":260,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":261,"context_line":"        access \u003d self.allow_access("}],"source_content_type":"text/x-python","patch_set":8,"id":"67675c90_cbd365a8","line":258,"range":{"start_line":258,"start_character":18,"end_line":258,"end_character":30},"in_reply_to":"660f360a_d3d212e4","updated":"2022-12-14 11:33:32.000000000","message":"I\u0027m also confused how to tag the tests :)\nLet\u0027s do it simple. If the test expects to get an error response it means that it\u0027s a negative test.\nI think I went with this direction for most of the cases.","commit_id":"7ca3d7b20c764b5bc653eeb63526bc1370802a18"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"30d0be99557cab6b66fe5fa49dbaa1c0aa7f15b1","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            cls.alt_project_share_v2_client, share_type[\u0027id\u0027])"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @decorators.idempotent_id(\u0027de643909-88a2-470b-8a14-0417696ec451\u0027)"},{"line_number":258,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":259,"context_line":"    def test_get_access(self):"},{"line_number":260,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":261,"context_line":"        access \u003d self.allow_access("}],"source_content_type":"text/x-python","patch_set":8,"id":"1c32a587_d289f68b","line":258,"range":{"start_line":258,"start_character":18,"end_line":258,"end_character":30},"in_reply_to":"67675c90_cbd365a8","updated":"2022-12-15 20:27:19.000000000","message":"Awesome, tag_negative it is!\nThanks, Liron! :)","commit_id":"7ca3d7b20c764b5bc653eeb63526bc1370802a18"}]}