)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b6cbe0a3faaaa24a348aa7293b01c8716e889514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90ed45f1_b005d787","updated":"2022-12-13 19:42:54.000000000","message":"Hello, Liron, thanks for the work on this change! Please check comments inline :)","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7048882420670cd7e5a6f2cda8143c308ae9ea9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2560f3a1_964a9299","updated":"2022-12-01 08:05:46.000000000","message":"recheck","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"433004e123a52983d4fae2bd33a92ef59924bd07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9844cb96_5daa09a4","updated":"2022-11-30 16:01:21.000000000","message":"recheck","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"eb05c5c00a4b3f8bcc28000ddaf1ea8bc636b346","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa6f62ad_5110c599","updated":"2023-02-06 19:18:17.000000000","message":"Looks good, local tests had passed. Thanks!","commit_id":"162216cb7743273cd10cfd2f8aae2a6958c0be84"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"20933ca9f0579ebae44216bb1e287f05b043606d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f3fd2ea_730bdcff","updated":"2022-12-15 20:31:32.000000000","message":"Thanks Liron, LGTM :)","commit_id":"162216cb7743273cd10cfd2f8aae2a6958c0be84"}],"manila_tempest_tests/tests/rbac/test_share_manage.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b6cbe0a3faaaa24a348aa7293b01c8716e889514","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        super(ShareRbacManageShareTests, cls).resource_setup()"},{"line_number":54,"context_line":"        cls.share_type \u003d cls.get_share_type()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def share_manage_preparations(self, share_id, unmange\u003dTrue):"},{"line_number":57,"context_line":"        share_info \u003d self.admin_shares_v2_client.get_share(share_id)[\u0027share\u0027]"},{"line_number":58,"context_line":"        export_path \u003d self.admin_shares_v2_client.list_share_export_locations("},{"line_number":59,"context_line":"            share_id)[\u0027export_locations\u0027][0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"e98ec9c6_844a3c80","line":56,"range":{"start_line":56,"start_character":50,"end_line":56,"end_character":57},"updated":"2022-12-13 19:42:54.000000000","message":"nit: unmanage","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"833d807b79250d794258b621e1804fb19667f72f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        super(ShareRbacManageShareTests, cls).resource_setup()"},{"line_number":54,"context_line":"        cls.share_type \u003d cls.get_share_type()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def share_manage_preparations(self, share_id, unmange\u003dTrue):"},{"line_number":57,"context_line":"        share_info \u003d self.admin_shares_v2_client.get_share(share_id)[\u0027share\u0027]"},{"line_number":58,"context_line":"        export_path \u003d self.admin_shares_v2_client.list_share_export_locations("},{"line_number":59,"context_line":"            share_id)[\u0027export_locations\u0027][0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"4de84a15_ff0529d2","line":56,"range":{"start_line":56,"start_character":50,"end_line":56,"end_character":57},"in_reply_to":"b550d5ba_af0e6bb5","updated":"2022-12-15 09:20:20.000000000","message":"Done","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b1962cb26e99ca8431814cce5a2da59839386df8","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        super(ShareRbacManageShareTests, cls).resource_setup()"},{"line_number":54,"context_line":"        cls.share_type \u003d cls.get_share_type()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def share_manage_preparations(self, share_id, unmange\u003dTrue):"},{"line_number":57,"context_line":"        share_info \u003d self.admin_shares_v2_client.get_share(share_id)[\u0027share\u0027]"},{"line_number":58,"context_line":"        export_path \u003d self.admin_shares_v2_client.list_share_export_locations("},{"line_number":59,"context_line":"            share_id)[\u0027export_locations\u0027][0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"b550d5ba_af0e6bb5","line":56,"range":{"start_line":56,"start_character":50,"end_line":56,"end_character":57},"in_reply_to":"e98ec9c6_844a3c80","updated":"2022-12-14 09:03:49.000000000","message":"Thanks, will do!","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b6cbe0a3faaaa24a348aa7293b01c8716e889514","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            \u0027unmanage_share\u0027, expected_status\u003d202, share_id\u003dshare[\u0027id\u0027])"},{"line_number":119,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        managed_share \u003d self.client.manage_share("},{"line_number":122,"context_line":"            share_type_id\u003dself.share_type[\u0027id\u0027], **share_data)[\u0027share\u0027]"},{"line_number":123,"context_line":"        waiters.wait_for_resource_status("},{"line_number":124,"context_line":"            self.client, managed_share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        alt_share \u003d self.create_share("},{"line_number":127,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"94f74736_7877a3a4","line":124,"range":{"start_line":121,"start_character":8,"end_line":124,"end_character":73},"updated":"2022-12-13 19:42:54.000000000","message":"are these shares being used for other reason after they are managed again?\nIf I understand correctly, you\u0027re managing again so the teardown of the class does not fail, right?\nI\u0027d say this is \"testing two features\", so maybe we can have a way to disable the automatic cleanup for tests like this?\nLike add a parameter in the create_share, called auto_cleanup_on_class\u003dTrue, and in this case we\u0027d set it to false and only clean up in case it is true. This would avoid the extra calls to share manage.","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"833d807b79250d794258b621e1804fb19667f72f","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            \u0027unmanage_share\u0027, expected_status\u003d202, share_id\u003dshare[\u0027id\u0027])"},{"line_number":119,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        managed_share \u003d self.client.manage_share("},{"line_number":122,"context_line":"            share_type_id\u003dself.share_type[\u0027id\u0027], **share_data)[\u0027share\u0027]"},{"line_number":123,"context_line":"        waiters.wait_for_resource_status("},{"line_number":124,"context_line":"            self.client, managed_share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        alt_share \u003d self.create_share("},{"line_number":127,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9496d8c8_23bdc6d2","line":124,"range":{"start_line":121,"start_character":8,"end_line":124,"end_character":73},"in_reply_to":"1fe25a7d_806e46e5","updated":"2022-12-15 09:20:20.000000000","message":"I added a comment to explain why we need to manage the share again.","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4d932f4d95d3a94d15543aa17842aeb917051c0b","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            \u0027unmanage_share\u0027, expected_status\u003d202, share_id\u003dshare[\u0027id\u0027])"},{"line_number":119,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        managed_share \u003d self.client.manage_share("},{"line_number":122,"context_line":"            share_type_id\u003dself.share_type[\u0027id\u0027], **share_data)[\u0027share\u0027]"},{"line_number":123,"context_line":"        waiters.wait_for_resource_status("},{"line_number":124,"context_line":"            self.client, managed_share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        alt_share \u003d self.create_share("},{"line_number":127,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fe25a7d_806e46e5","line":124,"range":{"start_line":121,"start_character":8,"end_line":124,"end_character":73},"in_reply_to":"39bde94b_63e56fc2","updated":"2022-12-14 18:43:47.000000000","message":"Got it - As I see, for the dummy driver it is not a problem, but if we run with an actual backend, it would leave some space allocated. Thanks!","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"20933ca9f0579ebae44216bb1e287f05b043606d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            \u0027unmanage_share\u0027, expected_status\u003d202, share_id\u003dshare[\u0027id\u0027])"},{"line_number":119,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        managed_share \u003d self.client.manage_share("},{"line_number":122,"context_line":"            share_type_id\u003dself.share_type[\u0027id\u0027], **share_data)[\u0027share\u0027]"},{"line_number":123,"context_line":"        waiters.wait_for_resource_status("},{"line_number":124,"context_line":"            self.client, managed_share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        alt_share \u003d self.create_share("},{"line_number":127,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"be796244_d83cd448","line":124,"range":{"start_line":121,"start_character":8,"end_line":124,"end_character":73},"in_reply_to":"9496d8c8_23bdc6d2","updated":"2022-12-15 20:31:32.000000000","message":"Ack, good approach. Thanks!","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b1962cb26e99ca8431814cce5a2da59839386df8","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            \u0027unmanage_share\u0027, expected_status\u003d202, share_id\u003dshare[\u0027id\u0027])"},{"line_number":119,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        managed_share \u003d self.client.manage_share("},{"line_number":122,"context_line":"            share_type_id\u003dself.share_type[\u0027id\u0027], **share_data)[\u0027share\u0027]"},{"line_number":123,"context_line":"        waiters.wait_for_resource_status("},{"line_number":124,"context_line":"            self.client, managed_share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        alt_share \u003d self.create_share("},{"line_number":127,"context_line":"            self.alt_project_share_v2_client, self.share_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"39bde94b_63e56fc2","line":124,"range":{"start_line":121,"start_character":8,"end_line":124,"end_character":73},"in_reply_to":"94f74736_7877a3a4","updated":"2022-12-14 09:03:49.000000000","message":"The test passes even without having to manage the share again thank to these lines:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/base.py#L60\n\nThis gives us the ability to handle resource deletion at the method level.\nThe reason I manage the share again is because after unmanaging operation, the share is removed from the management of the shared file systems service without deleting the share. So in order to be able to delete the share we need to manage it again.","commit_id":"68e50d783eb584338fcbdd20e92a5da7757183ec"}]}