)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92f88f79dfb869c49405f5a38b378f549ba2a030","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ed6ee27_1713f0dc","updated":"2022-12-20 14:21:13.000000000","message":"Thank you for the review Liron! PLease see the changes inline :)","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a6395db02b76239a09a1b47b041c83e385a8969","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b742aec4_d3dc7c31","updated":"2022-12-18 10:37:56.000000000","message":"Thanks Carlos for working on it!","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"42cea8ed337ee4086cdc7f475a4acf73a96c696c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d5336ed7_f8d3a02f","updated":"2023-01-19 08:19:03.000000000","message":"recheck","commit_id":"76e2b786d39b4c7da0846ac39bd176d32992cec7"}],"manila_tempest_tests/tests/rbac/test_share_network_security_services.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a6395db02b76239a09a1b47b041c83e385a8969","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def test_check_share_network_security_service_add(self):"},{"line_number":65,"context_line":"        pass"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def skip_if_add_update_microversion_not_supported(self):"},{"line_number":68,"context_line":"        if not utils.is_microversion_supported("},{"line_number":69,"context_line":"                ADD_UPDATE_SEC_SERVICE_MICROVERSION):"},{"line_number":70,"context_line":"            message \u003d ("},{"line_number":71,"context_line":"                \"Adding or updating security services on in-use share \""},{"line_number":72,"context_line":"                \"networks is not allowed in this microversion.\")"},{"line_number":73,"context_line":"            raise self.skipException(message)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class ProjectAdminTests(ShareRbacShareNetworkSecServiceTests,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7cc3eebe_4e96fc45","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":45},"updated":"2022-12-18 10:37:56.000000000","message":"Instead of creating a method, you can wrap the test in skip decorator, as below:\n@testtools.skipUnless(utils.is_microversion_supported(\nADD_UPDATE_SEC_SERVICE_MICROVERSION), \"msg\")\ndef test_add_security_service_to_share_network(self):","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92f88f79dfb869c49405f5a38b378f549ba2a030","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def test_check_share_network_security_service_add(self):"},{"line_number":65,"context_line":"        pass"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def skip_if_add_update_microversion_not_supported(self):"},{"line_number":68,"context_line":"        if not utils.is_microversion_supported("},{"line_number":69,"context_line":"                ADD_UPDATE_SEC_SERVICE_MICROVERSION):"},{"line_number":70,"context_line":"            message \u003d ("},{"line_number":71,"context_line":"                \"Adding or updating security services on in-use share \""},{"line_number":72,"context_line":"                \"networks is not allowed in this microversion.\")"},{"line_number":73,"context_line":"            raise self.skipException(message)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class ProjectAdminTests(ShareRbacShareNetworkSecServiceTests,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8b64002b_c9a4e532","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":45},"in_reply_to":"7cc3eebe_4e96fc45","updated":"2022-12-20 14:21:13.000000000","message":"Done","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a6395db02b76239a09a1b47b041c83e385a8969","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    @decorators.idempotent_id(\u0027db0c2d58-8c22-47f5-a2a4-ce0c806353d7\u0027)"},{"line_number":105,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":106,"context_line":"    def test_add_security_service_to_share_network(self):"},{"line_number":107,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":108,"context_line":"        share_network, security_service \u003d ("},{"line_number":109,"context_line":"            self.setup_security_service_add_tests())"},{"line_number":110,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ad4b9ce_086365e4","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":60},"updated":"2022-12-18 10:37:56.000000000","message":"It\u0027s better to skip the test outside the test, as I mentioned above.","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92f88f79dfb869c49405f5a38b378f549ba2a030","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    @decorators.idempotent_id(\u0027db0c2d58-8c22-47f5-a2a4-ce0c806353d7\u0027)"},{"line_number":105,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":106,"context_line":"    def test_add_security_service_to_share_network(self):"},{"line_number":107,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":108,"context_line":"        share_network, security_service \u003d ("},{"line_number":109,"context_line":"            self.setup_security_service_add_tests())"},{"line_number":110,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"b0a75f74_d7403d1e","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":60},"in_reply_to":"7ad4b9ce_086365e4","updated":"2022-12-20 14:21:13.000000000","message":"Done","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a6395db02b76239a09a1b47b041c83e385a8969","unresolved":true,"context_lines":[{"line_number":138,"context_line":"    @decorators.idempotent_id(\u0027581e2039-0cc4-4988-88fa-f0b0d58c9002\u0027)"},{"line_number":139,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":140,"context_line":"    def test_update_share_network_security_service(self):"},{"line_number":141,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":142,"context_line":"        share_network, security_service, new_security_service \u003d ("},{"line_number":143,"context_line":"            self.setup_security_service_update_in_use_tests())"},{"line_number":144,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"5c99c8d8_b3416ff8","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":60},"updated":"2022-12-18 10:37:56.000000000","message":"Same","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92f88f79dfb869c49405f5a38b378f549ba2a030","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    @decorators.idempotent_id(\u0027581e2039-0cc4-4988-88fa-f0b0d58c9002\u0027)"},{"line_number":139,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":140,"context_line":"    def test_update_share_network_security_service(self):"},{"line_number":141,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":142,"context_line":"        share_network, security_service, new_security_service \u003d ("},{"line_number":143,"context_line":"            self.setup_security_service_update_in_use_tests())"},{"line_number":144,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"06cb06bb_09d2643a","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":60},"in_reply_to":"5c99c8d8_b3416ff8","updated":"2022-12-20 14:21:13.000000000","message":"Done","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a6395db02b76239a09a1b47b041c83e385a8969","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    @decorators.idempotent_id(\u002797dd02a4-7f68-4bab-aee6-ffaed803b6f2\u0027)"},{"line_number":156,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":157,"context_line":"    def test_check_share_network_security_service_update(self):"},{"line_number":158,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":159,"context_line":"        share_network, security_service, new_security_service \u003d ("},{"line_number":160,"context_line":"            self.setup_security_service_update_in_use_tests())"},{"line_number":161,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f2f7c1c_e1ee0d75","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":60},"updated":"2022-12-18 10:37:56.000000000","message":"Same","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92f88f79dfb869c49405f5a38b378f549ba2a030","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    @decorators.idempotent_id(\u002797dd02a4-7f68-4bab-aee6-ffaed803b6f2\u0027)"},{"line_number":156,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":157,"context_line":"    def test_check_share_network_security_service_update(self):"},{"line_number":158,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":159,"context_line":"        share_network, security_service, new_security_service \u003d ("},{"line_number":160,"context_line":"            self.setup_security_service_update_in_use_tests())"},{"line_number":161,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"2804357b_80142894","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":60},"in_reply_to":"7f2f7c1c_e1ee0d75","updated":"2022-12-20 14:21:13.000000000","message":"Done","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a6395db02b76239a09a1b47b041c83e385a8969","unresolved":true,"context_lines":[{"line_number":175,"context_line":"    @decorators.idempotent_id(\u002762d81b9e-7dc5-45d2-a4be-e1b6edaa0e58\u0027)"},{"line_number":176,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":177,"context_line":"    def test_check_share_network_security_service_add(self):"},{"line_number":178,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":179,"context_line":"        share_network, security_service \u003d ("},{"line_number":180,"context_line":"            self.setup_security_service_add_tests())"},{"line_number":181,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"72f518e3_e283ee79","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":60},"updated":"2022-12-18 10:37:56.000000000","message":"Same","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92f88f79dfb869c49405f5a38b378f549ba2a030","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    @decorators.idempotent_id(\u002762d81b9e-7dc5-45d2-a4be-e1b6edaa0e58\u0027)"},{"line_number":176,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":177,"context_line":"    def test_check_share_network_security_service_add(self):"},{"line_number":178,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":179,"context_line":"        share_network, security_service \u003d ("},{"line_number":180,"context_line":"            self.setup_security_service_add_tests())"},{"line_number":181,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"53c3037c_ac3defa1","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":60},"in_reply_to":"72f518e3_e283ee79","updated":"2022-12-20 14:21:13.000000000","message":"Done","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a6395db02b76239a09a1b47b041c83e385a8969","unresolved":true,"context_lines":[{"line_number":188,"context_line":"                        expected_status\u003d202, **params)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"class ProjectMemberTests(ShareRbacShareNetworkSecServiceTests,"},{"line_number":192,"context_line":"                         base.BaseSharesTest):"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_alt_member\u0027]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @decorators.idempotent_id(\u0027f459e15e-23c9-4943-a909-ce97ac0711b9\u0027)"},{"line_number":197,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":198,"context_line":"    def test_add_security_service_to_share_network(self):"},{"line_number":199,"context_line":"        super("},{"line_number":200,"context_line":"            ProjectMemberTests,"},{"line_number":201,"context_line":"            self).test_add_security_service_to_share_network()"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @decorators.idempotent_id(\u002752b8eca3-1686-47e5-8369-509f2509df1a\u0027)"},{"line_number":204,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":205,"context_line":"    def test_remove_security_service_from_share_network(self):"},{"line_number":206,"context_line":"        super("},{"line_number":207,"context_line":"            ProjectMemberTests,"},{"line_number":208,"context_line":"            self).test_remove_security_service_from_share_network()"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @decorators.idempotent_id(\u002736e4892c-9f31-4b61-85b4-3df6765ab721\u0027)"},{"line_number":211,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":212,"context_line":"    def test_update_share_network_security_service(self):"},{"line_number":213,"context_line":"        super("},{"line_number":214,"context_line":"            ProjectMemberTests,"},{"line_number":215,"context_line":"            self).test_update_share_network_security_service()"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @decorators.idempotent_id(\u002779d08d0b-9007-4378-bd02-7007c3c91a5d\u0027)"},{"line_number":218,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":219,"context_line":"    def test_check_share_network_security_service_update(self):"},{"line_number":220,"context_line":"        super("},{"line_number":221,"context_line":"            ProjectMemberTests,"},{"line_number":222,"context_line":"            self).test_check_share_network_security_service_update()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @decorators.idempotent_id(\u002729c85f17-d5e4-47c7-9787-1236a0021c86\u0027)"},{"line_number":225,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":226,"context_line":"    def test_check_share_network_security_service_add(self):"},{"line_number":227,"context_line":"        super("},{"line_number":228,"context_line":"            ProjectMemberTests,"},{"line_number":229,"context_line":"            self).test_check_share_network_security_service_add()"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class ProjectReaderTests(ProjectMemberTests):"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"91732713_47f4be18","line":230,"range":{"start_line":191,"start_character":0,"end_line":230,"end_character":0},"updated":"2022-12-18 10:37:56.000000000","message":"The methods override the abstract methods without doing anything.","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"253d0e3ba9688e23917ff9fcc96847b24f5d5162","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                        expected_status\u003d202, **params)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"class ProjectMemberTests(ShareRbacShareNetworkSecServiceTests,"},{"line_number":192,"context_line":"                         base.BaseSharesTest):"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_alt_member\u0027]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @decorators.idempotent_id(\u0027f459e15e-23c9-4943-a909-ce97ac0711b9\u0027)"},{"line_number":197,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":198,"context_line":"    def test_add_security_service_to_share_network(self):"},{"line_number":199,"context_line":"        super("},{"line_number":200,"context_line":"            ProjectMemberTests,"},{"line_number":201,"context_line":"            self).test_add_security_service_to_share_network()"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @decorators.idempotent_id(\u002752b8eca3-1686-47e5-8369-509f2509df1a\u0027)"},{"line_number":204,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":205,"context_line":"    def test_remove_security_service_from_share_network(self):"},{"line_number":206,"context_line":"        super("},{"line_number":207,"context_line":"            ProjectMemberTests,"},{"line_number":208,"context_line":"            self).test_remove_security_service_from_share_network()"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @decorators.idempotent_id(\u002736e4892c-9f31-4b61-85b4-3df6765ab721\u0027)"},{"line_number":211,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":212,"context_line":"    def test_update_share_network_security_service(self):"},{"line_number":213,"context_line":"        super("},{"line_number":214,"context_line":"            ProjectMemberTests,"},{"line_number":215,"context_line":"            self).test_update_share_network_security_service()"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @decorators.idempotent_id(\u002779d08d0b-9007-4378-bd02-7007c3c91a5d\u0027)"},{"line_number":218,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":219,"context_line":"    def test_check_share_network_security_service_update(self):"},{"line_number":220,"context_line":"        super("},{"line_number":221,"context_line":"            ProjectMemberTests,"},{"line_number":222,"context_line":"            self).test_check_share_network_security_service_update()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @decorators.idempotent_id(\u002729c85f17-d5e4-47c7-9787-1236a0021c86\u0027)"},{"line_number":225,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":226,"context_line":"    def test_check_share_network_security_service_add(self):"},{"line_number":227,"context_line":"        super("},{"line_number":228,"context_line":"            ProjectMemberTests,"},{"line_number":229,"context_line":"            self).test_check_share_network_security_service_add()"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class ProjectReaderTests(ProjectMemberTests):"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"23766cca_264cb22c","line":230,"range":{"start_line":191,"start_character":0,"end_line":230,"end_character":0},"in_reply_to":"65d6270a_fc2731f0","updated":"2022-12-20 14:49:05.000000000","message":"This logic is implemented in reader class not in member class,\nand that\u0027s okay because the reader class inherits from member which implements the tests.\nHere you\u0027re inheriting from ShareRbacShareNetworkSecServiceTests which only declares the methods without doing anything.","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92f88f79dfb869c49405f5a38b378f549ba2a030","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                        expected_status\u003d202, **params)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"class ProjectMemberTests(ShareRbacShareNetworkSecServiceTests,"},{"line_number":192,"context_line":"                         base.BaseSharesTest):"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_alt_member\u0027]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @decorators.idempotent_id(\u0027f459e15e-23c9-4943-a909-ce97ac0711b9\u0027)"},{"line_number":197,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":198,"context_line":"    def test_add_security_service_to_share_network(self):"},{"line_number":199,"context_line":"        super("},{"line_number":200,"context_line":"            ProjectMemberTests,"},{"line_number":201,"context_line":"            self).test_add_security_service_to_share_network()"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @decorators.idempotent_id(\u002752b8eca3-1686-47e5-8369-509f2509df1a\u0027)"},{"line_number":204,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":205,"context_line":"    def test_remove_security_service_from_share_network(self):"},{"line_number":206,"context_line":"        super("},{"line_number":207,"context_line":"            ProjectMemberTests,"},{"line_number":208,"context_line":"            self).test_remove_security_service_from_share_network()"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @decorators.idempotent_id(\u002736e4892c-9f31-4b61-85b4-3df6765ab721\u0027)"},{"line_number":211,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":212,"context_line":"    def test_update_share_network_security_service(self):"},{"line_number":213,"context_line":"        super("},{"line_number":214,"context_line":"            ProjectMemberTests,"},{"line_number":215,"context_line":"            self).test_update_share_network_security_service()"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @decorators.idempotent_id(\u002779d08d0b-9007-4378-bd02-7007c3c91a5d\u0027)"},{"line_number":218,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":219,"context_line":"    def test_check_share_network_security_service_update(self):"},{"line_number":220,"context_line":"        super("},{"line_number":221,"context_line":"            ProjectMemberTests,"},{"line_number":222,"context_line":"            self).test_check_share_network_security_service_update()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @decorators.idempotent_id(\u002729c85f17-d5e4-47c7-9787-1236a0021c86\u0027)"},{"line_number":225,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":226,"context_line":"    def test_check_share_network_security_service_add(self):"},{"line_number":227,"context_line":"        super("},{"line_number":228,"context_line":"            ProjectMemberTests,"},{"line_number":229,"context_line":"            self).test_check_share_network_security_service_add()"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class ProjectReaderTests(ProjectMemberTests):"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"65d6270a_fc2731f0","line":230,"range":{"start_line":191,"start_character":0,"end_line":230,"end_character":0},"in_reply_to":"91732713_47f4be18","updated":"2022-12-20 14:21:13.000000000","message":"I followed the logic of this: https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_share_network.py#L248-L251\n\nBut it does not make much sense to just redeclare everything maybe","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a6395db02b76239a09a1b47b041c83e385a8969","unresolved":true,"context_lines":[{"line_number":296,"context_line":"    @decorators.idempotent_id(\u0027e2d2b8b3-3066-400e-b20e-380ef5d9a587\u0027)"},{"line_number":297,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":298,"context_line":"    def test_update_share_network_security_service(self):"},{"line_number":299,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":300,"context_line":"        share_network, security_service, new_security_service \u003d ("},{"line_number":301,"context_line":"            self.setup_security_service_update_in_use_tests())"},{"line_number":302,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"785d46ed_b4e29de8","line":299,"range":{"start_line":299,"start_character":8,"end_line":299,"end_character":60},"updated":"2022-12-18 10:37:56.000000000","message":"Same","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92f88f79dfb869c49405f5a38b378f549ba2a030","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    @decorators.idempotent_id(\u0027e2d2b8b3-3066-400e-b20e-380ef5d9a587\u0027)"},{"line_number":297,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":298,"context_line":"    def test_update_share_network_security_service(self):"},{"line_number":299,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":300,"context_line":"        share_network, security_service, new_security_service \u003d ("},{"line_number":301,"context_line":"            self.setup_security_service_update_in_use_tests())"},{"line_number":302,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"8996281e_1f02cc52","line":299,"range":{"start_line":299,"start_character":8,"end_line":299,"end_character":60},"in_reply_to":"785d46ed_b4e29de8","updated":"2022-12-20 14:21:13.000000000","message":"Done","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a6395db02b76239a09a1b47b041c83e385a8969","unresolved":true,"context_lines":[{"line_number":315,"context_line":"    @decorators.idempotent_id(\u0027b9dc4ce9-7d81-4d36-9818-0861ed04496f\u0027)"},{"line_number":316,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":317,"context_line":"    def test_check_share_network_security_service_update(self):"},{"line_number":318,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":319,"context_line":"        share_network, security_service, new_security_service \u003d ("},{"line_number":320,"context_line":"            self.setup_security_service_update_in_use_tests())"},{"line_number":321,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"e7357b21_06ac4ef2","line":318,"range":{"start_line":318,"start_character":8,"end_line":318,"end_character":60},"updated":"2022-12-18 10:37:56.000000000","message":"Same","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92f88f79dfb869c49405f5a38b378f549ba2a030","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    @decorators.idempotent_id(\u0027b9dc4ce9-7d81-4d36-9818-0861ed04496f\u0027)"},{"line_number":316,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":317,"context_line":"    def test_check_share_network_security_service_update(self):"},{"line_number":318,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":319,"context_line":"        share_network, security_service, new_security_service \u003d ("},{"line_number":320,"context_line":"            self.setup_security_service_update_in_use_tests())"},{"line_number":321,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"2d48134d_98590510","line":318,"range":{"start_line":318,"start_character":8,"end_line":318,"end_character":60},"in_reply_to":"e7357b21_06ac4ef2","updated":"2022-12-20 14:21:13.000000000","message":"Done","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a6395db02b76239a09a1b47b041c83e385a8969","unresolved":true,"context_lines":[{"line_number":335,"context_line":"    @decorators.idempotent_id(\u0027ea8f00fb-4daf-454d-a917-98ccab67eca8\u0027)"},{"line_number":336,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":337,"context_line":"    def test_check_share_network_security_service_add(self):"},{"line_number":338,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":339,"context_line":"        share_network, security_service \u003d ("},{"line_number":340,"context_line":"            self.setup_security_service_add_tests())"},{"line_number":341,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"b4a7dde1_25b63e65","line":338,"range":{"start_line":338,"start_character":8,"end_line":338,"end_character":60},"updated":"2022-12-18 10:37:56.000000000","message":"Same","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92f88f79dfb869c49405f5a38b378f549ba2a030","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    @decorators.idempotent_id(\u0027ea8f00fb-4daf-454d-a917-98ccab67eca8\u0027)"},{"line_number":336,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":337,"context_line":"    def test_check_share_network_security_service_add(self):"},{"line_number":338,"context_line":"        self.skip_if_add_update_microversion_not_supported()"},{"line_number":339,"context_line":"        share_network, security_service \u003d ("},{"line_number":340,"context_line":"            self.setup_security_service_add_tests())"},{"line_number":341,"context_line":"        params \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"f5e12e5d_4f664881","line":338,"range":{"start_line":338,"start_character":8,"end_line":338,"end_character":60},"in_reply_to":"b4a7dde1_25b63e65","updated":"2022-12-20 14:21:13.000000000","message":"Done","commit_id":"2187c9eee61b201ecb408f47eb73b242abf03950"}]}