)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f50615df66fcdded3f6f63ad2e8a45096399ffdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2e534599_f3f5ddcd","updated":"2023-05-04 13:28:37.000000000","message":"Hi, Nahim! Could you please take a look at Liron\u0027s comments?","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"421347ec054e9552437dda1628a35ae5dbb50a25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b1eec403_fac43062","updated":"2022-12-13 21:32:21.000000000","message":"LGTM, Thanks Nahim and Renan!","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b5a46f2c_a3649629","updated":"2022-12-14 12:51:10.000000000","message":"Thank you very much for your help Nahim! ","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"335cd02d_b45aebca","in_reply_to":"2e534599_f3f5ddcd","updated":"2023-05-08 16:12:24.000000000","message":"Hi Carlos\u0027, Nahim asked me to follow up this patch. I proposed some fixes, please take a look","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bcf881f2_2adb77ff","updated":"2023-05-09 06:47:06.000000000","message":"Thanks Renan for working on it.\n\nPlease see bellow the comments.\nI made some changes here https://paste.opendev.org/show/819936/\nexcept adding the tests of another project in member and reader class so you can user it as reference.","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6e011df2_f5fa906b","updated":"2023-05-08 16:12:24.000000000","message":"Thanks for the reviews","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"7613fd7f93b0f695aa863a293557e0ffbeae0635","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0be8b479_a977ddbe","updated":"2023-05-08 20:16:29.000000000","message":"recheck Seems to be a CI issue","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"ceb6e752ebed968f86984f2ac47e3dae640d9299","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d85ba348_0288ba40","in_reply_to":"0be8b479_a977ddbe","updated":"2023-05-08 20:17:45.000000000","message":"\u003e recheck Seems to be a CI issue\n\nOops, my mistake","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7c326d9b_d8ccbfae","updated":"2023-05-09 20:40:09.000000000","message":"Thanks Liron, I haven\u0027t seen your suggestions on paste and tried to resolved the comments in patchset 6, but in the end I noticed your changes and improved the code on patchset 7, thanks for you help","commit_id":"81f941e3ced4ed697c32389c22ed71255b6df8e9"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"5754d72607ebb15a37695213b790d410ccbc8a21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"88a76323_e2465aa5","updated":"2023-05-10 12:51:50.000000000","message":"Thanks Liron!","commit_id":"181d8d659e446216f63594c16df54aca24e9e85a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"08bb8edf28d93fa846ab3acc939cd502b738fa60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1d82acb8_f59a0bb4","updated":"2023-05-11 08:34:51.000000000","message":"Thanks guys!\nOnly a small comment.","commit_id":"181d8d659e446216f63594c16df54aca24e9e85a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c72a83fb87853a7a61dcb1d7a7bc8b676f9f56d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bba45b8a_f35725e1","updated":"2023-05-11 06:07:51.000000000","message":"recheck","commit_id":"181d8d659e446216f63594c16df54aca24e9e85a"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"354c5c9f7296b680d4992caaf17d796fdb2e501d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cccb1b73_fdd4538b","updated":"2023-05-16 12:12:45.000000000","message":"Looks good, thanks for adding these tests.","commit_id":"4246d0b9fe084bace3858912f20bea65b7421979"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"1ba0b1daaf072dab26ffe8e6360ae9bc944203f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2aaa31d9_ef00e4c9","updated":"2023-05-11 13:02:39.000000000","message":"Thanks Liron!","commit_id":"4246d0b9fe084bace3858912f20bea65b7421979"}],"manila_tempest_tests/tests/rbac/test_share_instance_export_locations.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"421347ec054e9552437dda1628a35ae5dbb50a25","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"0121b34d_fc546a5e","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":29},"updated":"2022-12-13 21:32:21.000000000","message":"2022 NetApp, Inc? :p","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"1a497a7af0d2297e70073a754b4679e5565b6182","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"91c4d7b4_d8096ceb","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":29},"in_reply_to":"0121b34d_fc546a5e","updated":"2023-05-08 16:23:21.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        super(TestProjectAdminTestsNFS, cls).resource_setup()"},{"line_number":63,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        cls.share \u003d cls.create_share(cls.client, share_type[\u0027id\u0027])"},{"line_number":66,"context_line":"        cls.share \u003d cls.client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":67,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":68,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"4c59f8d1_d358a71c","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":11},"updated":"2022-12-14 12:51:10.000000000","message":"Can be removed.","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        super(TestProjectAdminTestsNFS, cls).resource_setup()"},{"line_number":63,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        cls.share \u003d cls.create_share(cls.client, share_type[\u0027id\u0027])"},{"line_number":66,"context_line":"        cls.share \u003d cls.client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":67,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":68,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9b29707a_2ff4879e","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":11},"in_reply_to":"4c59f8d1_d358a71c","updated":"2023-05-08 16:12:24.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        cls.share \u003d cls.create_share(cls.client, share_type[\u0027id\u0027])"},{"line_number":66,"context_line":"        cls.share \u003d cls.client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":67,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":68,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9482fc47_9d7bafaf","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":11},"updated":"2022-12-14 12:51:10.000000000","message":"Same","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        cls.share \u003d cls.create_share(cls.client, share_type[\u0027id\u0027])"},{"line_number":66,"context_line":"        cls.share \u003d cls.client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":67,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":68,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e4948181_49bc4948","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":11},"in_reply_to":"9482fc47_9d7bafaf","updated":"2023-05-08 16:12:24.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":68,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027f3218212-d70b-4a3d-bc05-8905a4f14279\u0027)"},{"line_number":71,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":72,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":73,"context_line":"        self.do_request("},{"line_number":74,"context_line":"            \u0027list_share_instance_export_locations\u0027, expected_status\u003d200,"},{"line_number":75,"context_line":"            instance_id\u003dself.share_instances[0][\u0027id\u0027])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u0027c58c74cf-4fcd-4404-a2f9-1a9e6b4443c4\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":4,"id":"cd8b1510_4a6fc4d7","line":75,"range":{"start_line":70,"start_character":0,"end_line":75,"end_character":54},"updated":"2022-12-14 12:51:10.000000000","message":"It\u0027s true that the operation permission is checked but it\u0027s not enough.\nWe need to make sure the locations are viewable, as it\u0027s done here:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_shares.py#L145L153\n\nI guess you use this as a reference, but this also needs to be fixed:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_export_locations.py#L79\n\nIn addition, please also add a test when the resource is created in another project.\nIt\u0027s just like you did but in alt project, you can see example here:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_shares.py#L142L143\n\nYou need to initialize the alt client, see here:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_shares.py#L46L47","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":68,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027f3218212-d70b-4a3d-bc05-8905a4f14279\u0027)"},{"line_number":71,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":72,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":73,"context_line":"        self.do_request("},{"line_number":74,"context_line":"            \u0027list_share_instance_export_locations\u0027, expected_status\u003d200,"},{"line_number":75,"context_line":"            instance_id\u003dself.share_instances[0][\u0027id\u0027])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u0027c58c74cf-4fcd-4404-a2f9-1a9e6b4443c4\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":4,"id":"25169de0_78990bc5","line":75,"range":{"start_line":70,"start_character":0,"end_line":75,"end_character":54},"in_reply_to":"13290d94_5a820bc5","updated":"2023-05-08 16:12:24.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9b0a170b2b51e6dfecd298e51bc2a41f6813fa6e","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":68,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027f3218212-d70b-4a3d-bc05-8905a4f14279\u0027)"},{"line_number":71,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":72,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":73,"context_line":"        self.do_request("},{"line_number":74,"context_line":"            \u0027list_share_instance_export_locations\u0027, expected_status\u003d200,"},{"line_number":75,"context_line":"            instance_id\u003dself.share_instances[0][\u0027id\u0027])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u0027c58c74cf-4fcd-4404-a2f9-1a9e6b4443c4\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":4,"id":"13290d94_5a820bc5","line":75,"range":{"start_line":70,"start_character":0,"end_line":75,"end_character":54},"in_reply_to":"cd8b1510_4a6fc4d7","updated":"2022-12-18 08:38:48.000000000","message":"\u003e It\u0027s true that the operation permission is checked but it\u0027s not enough.\n\u003e We need to make sure the locations are viewable, as it\u0027s done here:\n\u003e https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_shares.py#L145L153\n\nPlease ignore the above example.\nYou can simply add assertNotEmpty exception to cover it, just as is done here:\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/868041\n\n\n\u003e \n\u003e I guess you use this as a reference, but this also needs to be fixed:\n\u003e https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_export_locations.py#L79\n\u003e \n\u003e In addition, please also add a test when the resource is created in another project.\n\u003e It\u0027s just like you did but in alt project, you can see example here:\n\u003e https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_shares.py#L142L143\n\u003e \n\u003e You need to initialize the alt client, see here:\n\u003e https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_shares.py#L46L47","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    @decorators.idempotent_id(\u0027c58c74cf-4fcd-4404-a2f9-1a9e6b4443c4\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":79,"context_line":"    def test_share_instance_show_export_location(self):"},{"line_number":80,"context_line":"        export_location \u003d ("},{"line_number":81,"context_line":"            self.client.list_share_instance_export_locations("},{"line_number":82,"context_line":"                self.share_instances[0][\u0027id\u0027])[\u0027export_locations\u0027])"},{"line_number":83,"context_line":"        self.do_request("},{"line_number":84,"context_line":"            \u0027get_share_instance_export_location\u0027, expected_status\u003d200,"},{"line_number":85,"context_line":"            instance_id\u003dself.share_instances[0][\u0027id\u0027],"},{"line_number":86,"context_line":"            export_location_uuid\u003dexport_location[0][\u0027id\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class TestProjectMemberTestsNFS(ShareRbacInstanceExportLocationsTests,"}],"source_content_type":"text/x-python","patch_set":4,"id":"cd079ab3_8317b280","line":86,"range":{"start_line":80,"start_character":0,"end_line":86,"end_character":58},"updated":"2022-12-14 12:51:10.000000000","message":"Please also add a test when the resource is created in another project.","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    @decorators.idempotent_id(\u0027c58c74cf-4fcd-4404-a2f9-1a9e6b4443c4\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":79,"context_line":"    def test_share_instance_show_export_location(self):"},{"line_number":80,"context_line":"        export_location \u003d ("},{"line_number":81,"context_line":"            self.client.list_share_instance_export_locations("},{"line_number":82,"context_line":"                self.share_instances[0][\u0027id\u0027])[\u0027export_locations\u0027])"},{"line_number":83,"context_line":"        self.do_request("},{"line_number":84,"context_line":"            \u0027get_share_instance_export_location\u0027, expected_status\u003d200,"},{"line_number":85,"context_line":"            instance_id\u003dself.share_instances[0][\u0027id\u0027],"},{"line_number":86,"context_line":"            export_location_uuid\u003dexport_location[0][\u0027id\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class TestProjectMemberTestsNFS(ShareRbacInstanceExportLocationsTests,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f156185_1b357599","line":86,"range":{"start_line":80,"start_character":0,"end_line":86,"end_character":58},"in_reply_to":"cd079ab3_8317b280","updated":"2023-05-08 16:12:24.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027]"},{"line_number":100,"context_line":"    protocol \u003d \u0027nfs\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def setup_clients(cls):"},{"line_number":104,"context_line":"        super(TestProjectMemberTestsNFS, cls).setup_clients()"},{"line_number":105,"context_line":"        cls.admin_client \u003d cls.os_project_admin.share_v2.SharesV2Client()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @classmethod"},{"line_number":108,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"36eb7753_90844315","line":105,"range":{"start_line":102,"start_character":0,"end_line":105,"end_character":73},"updated":"2022-12-14 12:51:10.000000000","message":"You don\u0027t think you need admin credentials.","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027]"},{"line_number":100,"context_line":"    protocol \u003d \u0027nfs\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def setup_clients(cls):"},{"line_number":104,"context_line":"        super(TestProjectMemberTestsNFS, cls).setup_clients()"},{"line_number":105,"context_line":"        cls.admin_client \u003d cls.os_project_admin.share_v2.SharesV2Client()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @classmethod"},{"line_number":108,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"393d4f16_4de3992b","line":105,"range":{"start_line":102,"start_character":0,"end_line":105,"end_character":73},"in_reply_to":"36eb7753_90844315","updated":"2023-05-08 16:12:24.000000000","message":"Hi Liron, thanks, I\u0027m not sure about that. I found some tests only performing these operations as admin [1], what do you think?\n\n[1] https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/api/admin/test_admin_actions_negative.py#L147L152","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027]"},{"line_number":100,"context_line":"    protocol \u003d \u0027nfs\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def setup_clients(cls):"},{"line_number":104,"context_line":"        super(TestProjectMemberTestsNFS, cls).setup_clients()"},{"line_number":105,"context_line":"        cls.admin_client \u003d cls.os_project_admin.share_v2.SharesV2Client()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @classmethod"},{"line_number":108,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"37ddeee5_0024fe86","line":105,"range":{"start_line":102,"start_character":0,"end_line":105,"end_character":73},"in_reply_to":"393d4f16_4de3992b","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    def resource_setup(cls):"},{"line_number":109,"context_line":"        super(TestProjectMemberTestsNFS, cls).resource_setup()"},{"line_number":110,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":111,"context_line":"        cls.share \u003d cls.create_share(cls.admin_client, share_type[\u0027id\u0027])"},{"line_number":112,"context_line":"        cls.share \u003d cls.admin_client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":113,"context_line":"        cls.share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":114,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"e12fa9d4_5af56b62","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":11},"updated":"2022-12-14 12:51:10.000000000","message":"Can be removed.","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    def resource_setup(cls):"},{"line_number":109,"context_line":"        super(TestProjectMemberTestsNFS, cls).resource_setup()"},{"line_number":110,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":111,"context_line":"        cls.share \u003d cls.create_share(cls.admin_client, share_type[\u0027id\u0027])"},{"line_number":112,"context_line":"        cls.share \u003d cls.admin_client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":113,"context_line":"        cls.share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":114,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"caa9d68b_31db1ab6","line":111,"range":{"start_line":111,"start_character":37,"end_line":111,"end_character":53},"updated":"2022-12-14 12:51:10.000000000","message":"Member can create a share, so you can use the persona credentials that in this case it\u0027s \u0027project_member\u0027.","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def resource_setup(cls):"},{"line_number":109,"context_line":"        super(TestProjectMemberTestsNFS, cls).resource_setup()"},{"line_number":110,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":111,"context_line":"        cls.share \u003d cls.create_share(cls.admin_client, share_type[\u0027id\u0027])"},{"line_number":112,"context_line":"        cls.share \u003d cls.admin_client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":113,"context_line":"        cls.share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":114,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"aa961084_2d6d1ce3","line":111,"range":{"start_line":111,"start_character":37,"end_line":111,"end_character":53},"in_reply_to":"caa9d68b_31db1ab6","updated":"2023-05-08 16:12:24.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def resource_setup(cls):"},{"line_number":109,"context_line":"        super(TestProjectMemberTestsNFS, cls).resource_setup()"},{"line_number":110,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":111,"context_line":"        cls.share \u003d cls.create_share(cls.admin_client, share_type[\u0027id\u0027])"},{"line_number":112,"context_line":"        cls.share \u003d cls.admin_client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":113,"context_line":"        cls.share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":114,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ce520ca_512410ff","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":11},"in_reply_to":"e12fa9d4_5af56b62","updated":"2023-05-08 16:12:24.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        super(TestProjectMemberTestsNFS, cls).resource_setup()"},{"line_number":110,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":111,"context_line":"        cls.share \u003d cls.create_share(cls.admin_client, share_type[\u0027id\u0027])"},{"line_number":112,"context_line":"        cls.share \u003d cls.admin_client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":113,"context_line":"        cls.share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":114,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d6a0fb56_8403f6a5","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":11},"updated":"2022-12-14 12:51:10.000000000","message":"Same","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        super(TestProjectMemberTestsNFS, cls).resource_setup()"},{"line_number":110,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":111,"context_line":"        cls.share \u003d cls.create_share(cls.admin_client, share_type[\u0027id\u0027])"},{"line_number":112,"context_line":"        cls.share \u003d cls.admin_client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":113,"context_line":"        cls.share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":114,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"a474fa0b_dc8d32d9","line":112,"range":{"start_line":112,"start_character":20,"end_line":112,"end_character":36},"updated":"2022-12-14 12:51:10.000000000","message":"You can use the persona client \u003d\u003e cls.client","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        super(TestProjectMemberTestsNFS, cls).resource_setup()"},{"line_number":110,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":111,"context_line":"        cls.share \u003d cls.create_share(cls.admin_client, share_type[\u0027id\u0027])"},{"line_number":112,"context_line":"        cls.share \u003d cls.admin_client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":113,"context_line":"        cls.share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":114,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ca5a68fd_fe44e12c","line":112,"range":{"start_line":112,"start_character":20,"end_line":112,"end_character":36},"in_reply_to":"a474fa0b_dc8d32d9","updated":"2023-05-08 16:12:24.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        super(TestProjectMemberTestsNFS, cls).resource_setup()"},{"line_number":110,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":111,"context_line":"        cls.share \u003d cls.create_share(cls.admin_client, share_type[\u0027id\u0027])"},{"line_number":112,"context_line":"        cls.share \u003d cls.admin_client.get_share(cls.share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":113,"context_line":"        cls.share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":114,"context_line":"            cls.share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fbae8afa_5de517c8","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":11},"in_reply_to":"d6a0fb56_8403f6a5","updated":"2023-05-08 16:12:24.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":118,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":119,"context_line":"        self.do_request("},{"line_number":120,"context_line":"            \u0027list_share_instance_export_locations\u0027,"},{"line_number":121,"context_line":"            expected_status\u003dlib_exc.Forbidden,"},{"line_number":122,"context_line":"            instance_id\u003dself.share_instances[0][\u0027id\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @decorators.idempotent_id(\u00278de74960-b9cf-4ee6-81dc-fbb5dbb291dd\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"be02f6f4_fd275f3e","line":121,"range":{"start_line":121,"start_character":28,"end_line":121,"end_character":45},"updated":"2022-12-14 12:51:10.000000000","message":"I think that member and reader can preform this action.\nThe reason we get 403 code is because the resource was created in admin project.","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":119,"context_line":"        self.do_request("},{"line_number":120,"context_line":"            \u0027list_share_instance_export_locations\u0027,"},{"line_number":121,"context_line":"            expected_status\u003dlib_exc.Forbidden,"},{"line_number":122,"context_line":"            instance_id\u003dself.share_instances[0][\u0027id\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @decorators.idempotent_id(\u00278de74960-b9cf-4ee6-81dc-fbb5dbb291dd\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4cde6442_2d44824d","line":121,"range":{"start_line":121,"start_character":28,"end_line":121,"end_character":45},"in_reply_to":"122ef351_63f89698","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":true,"context_lines":[{"line_number":118,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":119,"context_line":"        self.do_request("},{"line_number":120,"context_line":"            \u0027list_share_instance_export_locations\u0027,"},{"line_number":121,"context_line":"            expected_status\u003dlib_exc.Forbidden,"},{"line_number":122,"context_line":"            instance_id\u003dself.share_instances[0][\u0027id\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @decorators.idempotent_id(\u00278de74960-b9cf-4ee6-81dc-fbb5dbb291dd\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"d386eedc_7e92a5dd","line":121,"range":{"start_line":121,"start_character":28,"end_line":121,"end_character":45},"in_reply_to":"be02f6f4_fd275f3e","updated":"2023-05-08 16:12:24.000000000","message":"Same as Here [1]. I\u0027m not sure about if this is really an only admin operation but same as above I fount tests asserting that members are not allowed to perform this.\n\n[1] https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/api/admin/test_export_locations_negative.py#L76L81","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":118,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":119,"context_line":"        self.do_request("},{"line_number":120,"context_line":"            \u0027list_share_instance_export_locations\u0027,"},{"line_number":121,"context_line":"            expected_status\u003dlib_exc.Forbidden,"},{"line_number":122,"context_line":"            instance_id\u003dself.share_instances[0][\u0027id\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @decorators.idempotent_id(\u00278de74960-b9cf-4ee6-81dc-fbb5dbb291dd\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"122ef351_63f89698","line":121,"range":{"start_line":121,"start_character":28,"end_line":121,"end_character":45},"in_reply_to":"d386eedc_7e92a5dd","updated":"2023-05-09 06:47:06.000000000","message":"Sorry you\u0027r right!","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"455fde37f13a148272d591ac57b2c06b949e59ca","unresolved":true,"context_lines":[{"line_number":134,"context_line":"            export_location_uuid\u003dexport_location[0][\u0027id\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class TestProjectReaderTestsNFS(TestProjectMemberTestsNFS):"},{"line_number":138,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @decorators.idempotent_id(\u00279db505c1-45d3-4d82-8879-38c4861e4fb3\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"cdf1f4a1_224df20e","line":137,"range":{"start_line":137,"start_character":32,"end_line":137,"end_character":57},"updated":"2022-12-14 12:51:10.000000000","message":"Since you inherit from \"TestProjectMemberTestsNFS\" since the persona is reader and reader can\u0027t create a resource, you need to create a member user within the persona project in order to create a share resource, you can see example here:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_shares.py#L519L524\n\nAnd you also need to add the following line within TestProjectMemberTestsNFS class:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_shares.py#L340","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"d45bd64bd6db419f72bb652ac5008ff3e0c9b0f2","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            export_location_uuid\u003dexport_location[0][\u0027id\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class TestProjectReaderTestsNFS(TestProjectMemberTestsNFS):"},{"line_number":138,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @decorators.idempotent_id(\u00279db505c1-45d3-4d82-8879-38c4861e4fb3\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"aebb1e69_6a92d060","line":137,"range":{"start_line":137,"start_character":32,"end_line":137,"end_character":57},"in_reply_to":"cdf1f4a1_224df20e","updated":"2023-05-08 16:12:24.000000000","message":"Done","commit_id":"c12ffcbfdffcffa05fedb482d3d9243afa9327cf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        share \u003d cls.create_share(cls.client, share_type[\u0027id\u0027])"},{"line_number":75,"context_line":"        share \u003d cls.client.get_share(share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        alt_share \u003d cls.create_share("},{"line_number":78,"context_line":"            cls.alt_project_share_v2_client, share_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"64c58ff3_30e11dee","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":58},"updated":"2023-05-09 06:47:06.000000000","message":"You don\u0027t need it.\nYou can use the response body that is returned from the share creation one line up L74 and extract the share id.","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        share \u003d cls.create_share(cls.client, share_type[\u0027id\u0027])"},{"line_number":75,"context_line":"        share \u003d cls.client.get_share(share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        alt_share \u003d cls.create_share("},{"line_number":78,"context_line":"            cls.alt_project_share_v2_client, share_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bbf34676_7bc386f9","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":58},"in_reply_to":"64c58ff3_30e11dee","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        alt_share \u003d cls.create_share("},{"line_number":78,"context_line":"            cls.alt_project_share_v2_client, share_type[\u0027id\u0027])"},{"line_number":79,"context_line":"        alt_share \u003d cls.alt_project_share_v2_client.get_share("},{"line_number":80,"context_line":"            alt_share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":83,"context_line":"            share[\u0027id\u0027])[\u0027share_instances\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"703c3d08_75dc956d","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":37},"updated":"2023-05-09 06:47:06.000000000","message":"Same","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        alt_share \u003d cls.create_share("},{"line_number":78,"context_line":"            cls.alt_project_share_v2_client, share_type[\u0027id\u0027])"},{"line_number":79,"context_line":"        alt_share \u003d cls.alt_project_share_v2_client.get_share("},{"line_number":80,"context_line":"            alt_share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":83,"context_line":"            share[\u0027id\u0027])[\u0027share_instances\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"846aaae7_9c91dd4e","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":37},"in_reply_to":"703c3d08_75dc956d","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            cls.persona, project_id\u003dcls.persona.credentials.project_id)"},{"line_number":67,"context_line":"        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @classmethod"},{"line_number":70,"context_line":"    def resource_setup(cls):"},{"line_number":71,"context_line":"        super(TestProjectAdminTestsNFS, cls).resource_setup()"},{"line_number":72,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        share \u003d cls.create_share(cls.client, share_type[\u0027id\u0027])"},{"line_number":75,"context_line":"        share \u003d cls.client.get_share(share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        alt_share \u003d cls.create_share("},{"line_number":78,"context_line":"            cls.alt_project_share_v2_client, share_type[\u0027id\u0027])"},{"line_number":79,"context_line":"        alt_share \u003d cls.alt_project_share_v2_client.get_share("},{"line_number":80,"context_line":"            alt_share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":83,"context_line":"            share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":84,"context_line":"        cls.alt_share_instances \u003d cls.client.get_instances_of_share("},{"line_number":85,"context_line":"            alt_share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027f3218212-d70b-4a3d-bc05-8905a4f14279\u0027)"},{"line_number":88,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ec825a42_7fd235e8","line":85,"range":{"start_line":69,"start_character":0,"end_line":85,"end_character":47},"updated":"2023-05-09 06:47:06.000000000","message":"Since, we use admin credentials for export locations operation, I suggest to move the resource_setup class under ShareRbacInstanceExportLocationsTests that all child classes will use it.","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            cls.persona, project_id\u003dcls.persona.credentials.project_id)"},{"line_number":67,"context_line":"        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @classmethod"},{"line_number":70,"context_line":"    def resource_setup(cls):"},{"line_number":71,"context_line":"        super(TestProjectAdminTestsNFS, cls).resource_setup()"},{"line_number":72,"context_line":"        share_type \u003d cls.get_share_type()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        share \u003d cls.create_share(cls.client, share_type[\u0027id\u0027])"},{"line_number":75,"context_line":"        share \u003d cls.client.get_share(share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        alt_share \u003d cls.create_share("},{"line_number":78,"context_line":"            cls.alt_project_share_v2_client, share_type[\u0027id\u0027])"},{"line_number":79,"context_line":"        alt_share \u003d cls.alt_project_share_v2_client.get_share("},{"line_number":80,"context_line":"            alt_share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        cls.share_instances \u003d cls.client.get_instances_of_share("},{"line_number":83,"context_line":"            share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":84,"context_line":"        cls.alt_share_instances \u003d cls.client.get_instances_of_share("},{"line_number":85,"context_line":"            alt_share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027f3218212-d70b-4a3d-bc05-8905a4f14279\u0027)"},{"line_number":88,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0d9667f4_8a448b91","line":85,"range":{"start_line":69,"start_character":0,"end_line":85,"end_character":47},"in_reply_to":"ec825a42_7fd235e8","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"class TestProjectMemberTestsNFS(ShareRbacInstanceExportLocationsTests,"},{"line_number":121,"context_line":"                                base.BaseSharesTest):"},{"line_number":122,"context_line":"    \"\"\"Test suite for share instance export location operations by member"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    In order to test certain share operations we must create a share"},{"line_number":125,"context_line":"    resource for this. Since member user is limited in resources creation, we"},{"line_number":126,"context_line":"    are forced to use admin credentials, so we can test other share"},{"line_number":127,"context_line":"    operations."},{"line_number":128,"context_line":"    \"\"\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027, \u0027project_alt_member\u0027]"},{"line_number":131,"context_line":"    protocol \u003d \u0027nfs\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ee2ee8cf_6533a9f9","line":128,"range":{"start_line":122,"start_character":0,"end_line":128,"end_character":7},"updated":"2023-05-09 06:47:06.000000000","message":"This isn\u0027t correct, Member user can create a share resource.\nIn L143 you creates s share resource by Member user.","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"class TestProjectMemberTestsNFS(ShareRbacInstanceExportLocationsTests,"},{"line_number":121,"context_line":"                                base.BaseSharesTest):"},{"line_number":122,"context_line":"    \"\"\"Test suite for share instance export location operations by member"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    In order to test certain share operations we must create a share"},{"line_number":125,"context_line":"    resource for this. Since member user is limited in resources creation, we"},{"line_number":126,"context_line":"    are forced to use admin credentials, so we can test other share"},{"line_number":127,"context_line":"    operations."},{"line_number":128,"context_line":"    \"\"\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027, \u0027project_alt_member\u0027]"},{"line_number":131,"context_line":"    protocol \u003d \u0027nfs\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"b9b30487_131636bc","line":128,"range":{"start_line":122,"start_character":0,"end_line":128,"end_character":7},"in_reply_to":"ee2ee8cf_6533a9f9","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        share_client \u003d getattr(cls, \u0027share_member_client\u0027, cls.client)"},{"line_number":143,"context_line":"        share \u003d cls.create_share(share_client, share_type[\u0027id\u0027])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        share \u003d cls.client.get_share(share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":146,"context_line":"        cls.share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":147,"context_line":"            share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c4c469c0_8e8958cb","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":58},"updated":"2023-05-09 06:47:06.000000000","message":"Same as comment in L75","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        share_client \u003d getattr(cls, \u0027share_member_client\u0027, cls.client)"},{"line_number":143,"context_line":"        share \u003d cls.create_share(share_client, share_type[\u0027id\u0027])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        share \u003d cls.client.get_share(share[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":146,"context_line":"        cls.share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":147,"context_line":"            share[\u0027id\u0027])[\u0027share_instances\u0027]"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9b74802b_58556682","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":58},"in_reply_to":"c4c469c0_8e8958cb","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @decorators.idempotent_id(\u002727d495dd-b52d-417d-bfbf-9bb700e85f4d\u0027)"},{"line_number":150,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":151,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":152,"context_line":"        self.do_request("},{"line_number":153,"context_line":"            \u0027list_share_instance_export_locations\u0027,"},{"line_number":154,"context_line":"            expected_status\u003dlib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":5,"id":"6d2ae2a7_7ecd1baf","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":49},"updated":"2023-05-09 06:47:06.000000000","message":"You didn\u0027t add test for another project.","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @decorators.idempotent_id(\u002727d495dd-b52d-417d-bfbf-9bb700e85f4d\u0027)"},{"line_number":150,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":151,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":152,"context_line":"        self.do_request("},{"line_number":153,"context_line":"            \u0027list_share_instance_export_locations\u0027,"},{"line_number":154,"context_line":"            expected_status\u003dlib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":5,"id":"55fa2f2e_f63dd165","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":49},"in_reply_to":"6d2ae2a7_7ecd1baf","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @decorators.idempotent_id(\u00278de74960-b9cf-4ee6-81dc-fbb5dbb291dd\u0027)"},{"line_number":158,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":159,"context_line":"    def test_share_instance_show_export_location(self):"},{"line_number":160,"context_line":"        export_location \u003d ("},{"line_number":161,"context_line":"            self.admin_client.list_share_instance_export_locations("},{"line_number":162,"context_line":"                self.share_instances[0][\u0027id\u0027])[\u0027export_locations\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"be421d84_21855524","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":48},"updated":"2023-05-09 06:47:06.000000000","message":"same","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @decorators.idempotent_id(\u00278de74960-b9cf-4ee6-81dc-fbb5dbb291dd\u0027)"},{"line_number":158,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":159,"context_line":"    def test_share_instance_show_export_location(self):"},{"line_number":160,"context_line":"        export_location \u003d ("},{"line_number":161,"context_line":"            self.admin_client.list_share_instance_export_locations("},{"line_number":162,"context_line":"                self.share_instances[0][\u0027id\u0027])[\u0027export_locations\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"705f29d9_41b13ff7","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":48},"in_reply_to":"be421d84_21855524","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":182,"context_line":"    @classmethod"},{"line_number":183,"context_line":"    def setup_clients(cls):"},{"line_number":184,"context_line":"        super(TestProjectReaderTestsNFS, cls).setup_clients()"},{"line_number":185,"context_line":"        project_member \u003d cls.setup_user_client("},{"line_number":186,"context_line":"            cls.os_project_admin,"},{"line_number":187,"context_line":"            project_id\u003dcls.persona.credentials.project_id)"},{"line_number":188,"context_line":"        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"},{"line_number":191,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"f49b72f6_5c099072","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":74},"updated":"2023-05-09 06:47:06.000000000","message":"There\u0027s a fix [1] in the tempest project that is merged.\nAfter this fix reader, member and admin in the same project.\nSo we don\u0027t need to create a member. We can use the \"project_member\" credentials for this.\n\n[1] https://review.opendev.org/c/openstack/tempest/+/871018","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f58a63cbd3693cf40ce3bc1a746cf2fc33c4cadc","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    @classmethod"},{"line_number":183,"context_line":"    def setup_clients(cls):"},{"line_number":184,"context_line":"        super(TestProjectReaderTestsNFS, cls).setup_clients()"},{"line_number":185,"context_line":"        project_member \u003d cls.setup_user_client("},{"line_number":186,"context_line":"            cls.os_project_admin,"},{"line_number":187,"context_line":"            project_id\u003dcls.persona.credentials.project_id)"},{"line_number":188,"context_line":"        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"},{"line_number":191,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"6ee21b16_6d9aa947","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":74},"in_reply_to":"6b5d2ee8_e63484a5","updated":"2023-05-10 01:00:10.000000000","message":"Liron, wouldn\u0027t that mean that we\u0027d need to bump the version of tempest required by manila-tempest-plugin to at least 34.0.0?\n\nhttps://github.com/openstack/tempest/commits/34.0.0\n\nthat\u0027ll cause issues to get this patch into older distro releases (like RDO\u0027s stable/wallaby [1]).. I\u0027m okay with the bump; but i feel like we can create a tag of manila-tempest-plugin before that bump and allow that tag to be used by older distro releases\n\n[1] https://github.com/redhat-openstack/rdoinfo/blob/55fc43cd1ad975d12f007e20d0319cbc891893f1/tags/wallaby.yml#L314-L317","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"88a46661d83dd63afde8cbd3ac24876108182de8","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    @classmethod"},{"line_number":183,"context_line":"    def setup_clients(cls):"},{"line_number":184,"context_line":"        super(TestProjectReaderTestsNFS, cls).setup_clients()"},{"line_number":185,"context_line":"        project_member \u003d cls.setup_user_client("},{"line_number":186,"context_line":"            cls.os_project_admin,"},{"line_number":187,"context_line":"            project_id\u003dcls.persona.credentials.project_id)"},{"line_number":188,"context_line":"        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"},{"line_number":191,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fd0dc2b0_64c5bcd3","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":74},"in_reply_to":"6ee21b16_6d9aa947","updated":"2023-05-10 01:04:45.000000000","message":"continuing above comment, tempest is pinned at 33.0.0 in RDO\u0027s stable/wallaby [2]\nand in the upstream gate, we\u0027ve pinned it to 29.0.0.\n\nhttps://github.com/openstack/devstack/blob/17192ab3ff901e8bad83e1687fe4b57371e76a89/stackrc#L300\n\n[2] https://github.com/redhat-openstack/rdoinfo/blob/55fc43cd1ad975d12f007e20d0319cbc891893f1/tags/wallaby.yml#L1139-L1142","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    @classmethod"},{"line_number":183,"context_line":"    def setup_clients(cls):"},{"line_number":184,"context_line":"        super(TestProjectReaderTestsNFS, cls).setup_clients()"},{"line_number":185,"context_line":"        project_member \u003d cls.setup_user_client("},{"line_number":186,"context_line":"            cls.os_project_admin,"},{"line_number":187,"context_line":"            project_id\u003dcls.persona.credentials.project_id)"},{"line_number":188,"context_line":"        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"},{"line_number":191,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"6b5d2ee8_e63484a5","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":74},"in_reply_to":"f49b72f6_5c099072","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"6adc95e492b4c2b859a76a0cedb21e57a5c775e8","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    @classmethod"},{"line_number":183,"context_line":"    def setup_clients(cls):"},{"line_number":184,"context_line":"        super(TestProjectReaderTestsNFS, cls).setup_clients()"},{"line_number":185,"context_line":"        project_member \u003d cls.setup_user_client("},{"line_number":186,"context_line":"            cls.os_project_admin,"},{"line_number":187,"context_line":"            project_id\u003dcls.persona.credentials.project_id)"},{"line_number":188,"context_line":"        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @classmethod"},{"line_number":191,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ee25145a_e28e2e1e","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":74},"in_reply_to":"fd0dc2b0_64c5bcd3","updated":"2023-05-10 05:42:28.000000000","message":"Sorry I really didn\u0027t take that into consideration.\nSo let\u0027s wait until all rbac patches are merged, create a tag for older releases and then we can update all the tests for the new change.","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @decorators.idempotent_id(\u00279db505c1-45d3-4d82-8879-38c4861e4fb3\u0027)"},{"line_number":199,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":200,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":201,"context_line":"        (super(TestProjectReaderTestsNFS, self)"},{"line_number":202,"context_line":"            .test_share_instance_list_export_locations())"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d6d0a92b_c322c07b","line":200,"range":{"start_line":200,"start_character":8,"end_line":200,"end_character":49},"updated":"2023-05-09 06:47:06.000000000","message":"You didn\u0027t add test for another project.","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    @decorators.idempotent_id(\u00279db505c1-45d3-4d82-8879-38c4861e4fb3\u0027)"},{"line_number":199,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":200,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":201,"context_line":"        (super(TestProjectReaderTestsNFS, self)"},{"line_number":202,"context_line":"            .test_share_instance_list_export_locations())"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ec2ad26_a8e6a428","line":200,"range":{"start_line":200,"start_character":8,"end_line":200,"end_character":49},"in_reply_to":"d6d0a92b_c322c07b","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5816c9dd946ff0ab250d31e7e1124155a9ea629b","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u002709009203-ff20-4914-8764-7865839e29b2\u0027)"},{"line_number":205,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":206,"context_line":"    def test_share_instance_show_export_location(self):"},{"line_number":207,"context_line":"        (super(TestProjectReaderTestsNFS, self)"},{"line_number":208,"context_line":"            .test_share_instance_show_export_location())"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"80834d2e_f587655b","line":206,"range":{"start_line":206,"start_character":8,"end_line":206,"end_character":48},"updated":"2023-05-09 06:47:06.000000000","message":"same","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48c3d85fbd20aea2bf7d5be4171a5aa6a3673c75","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u002709009203-ff20-4914-8764-7865839e29b2\u0027)"},{"line_number":205,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":206,"context_line":"    def test_share_instance_show_export_location(self):"},{"line_number":207,"context_line":"        (super(TestProjectReaderTestsNFS, self)"},{"line_number":208,"context_line":"            .test_share_instance_show_export_location())"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"489c613c_955b436f","line":206,"range":{"start_line":206,"start_character":8,"end_line":206,"end_character":48},"in_reply_to":"80834d2e_f587655b","updated":"2023-05-09 20:40:09.000000000","message":"Done","commit_id":"a052374d50f33b0723f80d594d5e11d4141a58a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"375fceb4c2930e3b933ead1786c98fb4f50dc2a9","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        super(TestProjectReaderTestsNFS, cls).setup_clients()"},{"line_number":179,"context_line":"        # Initialize a member user in the same project of reader user"},{"line_number":180,"context_line":"        # for creating a share resource."},{"line_number":181,"context_line":"        cls.share_member_client \u003d ("},{"line_number":182,"context_line":"            cls.os_project_member.share_v2.SharesV2Client())"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    @decorators.idempotent_id(\u00279db505c1-45d3-4d82-8879-38c4861e4fb3\u0027)"},{"line_number":185,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"d329c548_05317074","line":182,"range":{"start_line":181,"start_character":0,"end_line":182,"end_character":60},"updated":"2023-05-10 05:46:23.000000000","message":"Sorry Renan for the confusion!\nThis is a small change, just replace it with this:\n\n        project_member \u003d cls.setup_user_client(\n            cls.os_project_admin,\n            project_id\u003dcls.persona.credentials.project_id)\n        cls.share_member_client \u003d project_member.share_v2.SharesV2Client()","commit_id":"81f941e3ced4ed697c32389c22ed71255b6df8e9"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"5754d72607ebb15a37695213b790d410ccbc8a21","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        super(TestProjectReaderTestsNFS, cls).setup_clients()"},{"line_number":179,"context_line":"        # Initialize a member user in the same project of reader user"},{"line_number":180,"context_line":"        # for creating a share resource."},{"line_number":181,"context_line":"        cls.share_member_client \u003d ("},{"line_number":182,"context_line":"            cls.os_project_member.share_v2.SharesV2Client())"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    @decorators.idempotent_id(\u00279db505c1-45d3-4d82-8879-38c4861e4fb3\u0027)"},{"line_number":185,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"e1e2eff0_08da3ded","line":182,"range":{"start_line":181,"start_character":0,"end_line":182,"end_character":60},"in_reply_to":"d329c548_05317074","updated":"2023-05-10 12:51:50.000000000","message":"No problem! Done","commit_id":"81f941e3ced4ed697c32389c22ed71255b6df8e9"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"08bb8edf28d93fa846ab3acc939cd502b738fa60","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    protocol \u003d \u0027nfs\u0027"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @decorators.idempotent_id(\u002727d495dd-b52d-417d-bfbf-9bb700e85f4d\u0027)"},{"line_number":128,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":129,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":130,"context_line":"        self.do_request("},{"line_number":131,"context_line":"            \u0027list_share_instance_export_locations\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"d94af6a2_20f92ab0","line":128,"range":{"start_line":128,"start_character":22,"end_line":128,"end_character":30},"updated":"2023-05-11 08:34:51.000000000","message":"NEGATIVE","commit_id":"181d8d659e446216f63594c16df54aca24e9e85a"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"1ba0b1daaf072dab26ffe8e6360ae9bc944203f8","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    protocol \u003d \u0027nfs\u0027"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @decorators.idempotent_id(\u002727d495dd-b52d-417d-bfbf-9bb700e85f4d\u0027)"},{"line_number":128,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":129,"context_line":"    def test_share_instance_list_export_locations(self):"},{"line_number":130,"context_line":"        self.do_request("},{"line_number":131,"context_line":"            \u0027list_share_instance_export_locations\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"6a4b7813_e27d04eb","line":128,"range":{"start_line":128,"start_character":22,"end_line":128,"end_character":30},"in_reply_to":"d94af6a2_20f92ab0","updated":"2023-05-11 13:02:39.000000000","message":"Done","commit_id":"181d8d659e446216f63594c16df54aca24e9e85a"}]}