)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"1b4aa4b061f5ef0fed3b36860c9278702c1cb6da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6698010c_5c9cf978","updated":"2023-03-22 16:46:19.000000000","message":"recheck - Seems to have a back-end error","commit_id":"13f4fd3fd5fafab64bc845a5dc07ef95a659da5f"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"5aa8bdad3a5a1a15349e754694d9ac7cbd7f7153","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d6fb9d1_957f3cb8","updated":"2023-04-03 15:08:31.000000000","message":"Hi Renan, thanks for the work. Only 2 little things to fix, I guess. The rest LGTM.","commit_id":"8affb691815f4785e3c40d5b5c8a7d02a7f13384"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48d88ee4bd0d4eba8e5d390670bdb4ab5c46d141","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1477809b_26d33513","in_reply_to":"2d6fb9d1_957f3cb8","updated":"2023-04-03 17:09:48.000000000","message":"Thanks Thiago, fixed on Patchset 4","commit_id":"8affb691815f4785e3c40d5b5c8a7d02a7f13384"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"fcd413222c987de2dd575e549dafae6d7f9efde5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5e920ea4_11c4330f","updated":"2023-04-04 15:22:40.000000000","message":"Thanks Renan, LGTM.","commit_id":"0ec0b781c00bb8739c95395ec2963f189a038819"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"40347024aa0c2a0adee83cd051e816572cd573f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"611bc497_a3a7f5ae","updated":"2025-04-08 16:28:49.000000000","message":"Changes looks good for me, there few place you can optimise the code, for that I have provide few minor comments","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2848344087d70e3c925d629ed99093d63afb7e94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bdb156ef_cf66fcc9","updated":"2025-04-07 03:57:28.000000000","message":"recheck","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f426440bbd4ec210c998be460f5f59763bd89df0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"231e8a9a_4670a2c9","updated":"2025-04-07 08:31:21.000000000","message":"the failure is unrelated .. \n\ndd: closing output file \u0027/mnt/t1\u0027: Cannot allocate memory","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6deda820f8ff14acd61ea5f697afb1f7ff5488a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4cdca93d_96541493","updated":"2025-06-17 00:07:24.000000000","message":"Thanks for updating this change, @kinpaa@gmail.com. A minor-ish comment inline","commit_id":"318ed6165babad9795ef5ea44c1cf73a0ba6da67"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03aa1f0f708d27093aee189f0392cfc551a42d30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d462eec9_c31fe17b","updated":"2025-06-24 19:29:30.000000000","message":"Thanks for working on this change. Have a single comment inline, please take a look","commit_id":"0fec91ac5eb9fcd04acb8d3e2758956b2d5d2069"}],"manila_tempest_tests/tests/api/test_share_network_subnet_metadata.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"40347024aa0c2a0adee83cd051e816572cd573f1","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    def test_set_get_delete_metadata(self):"},{"line_number":94,"context_line":"        md \u003d {u\"key3\": u\"value3\", u\"key4\": u\"value4\", u\"key.5.1\": u\"value.5\"}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # create subnet"},{"line_number":97,"context_line":"        subnet \u003d self.create_share_network_subnet(**self.data)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # set metadata"},{"line_number":100,"context_line":"        self.shares_v2_client.set_metadata("},{"line_number":101,"context_line":"            subnet[\u0027id\u0027], md, resource\u003d\"subnet\","},{"line_number":102,"context_line":"            parent_resource\u003d\"share-networks\","},{"line_number":103,"context_line":"            parent_id\u003dself.share_network[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # verify metadata"},{"line_number":106,"context_line":"        self._verify_subnet_metadata(subnet, md)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # delete metadata"},{"line_number":109,"context_line":"        for key in md.keys():"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aade12e_70570fd6","line":106,"range":{"start_line":96,"start_character":8,"end_line":106,"end_character":48},"updated":"2025-04-08 16:28:49.000000000","message":"Can you create one private method and put these code in that and call this method from all the test methods which have these common code","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ec91db562484710d49b153a967b632bbe21dd7d6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def test_set_get_delete_metadata(self):"},{"line_number":94,"context_line":"        md \u003d {u\"key3\": u\"value3\", u\"key4\": u\"value4\", u\"key.5.1\": u\"value.5\"}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # create subnet"},{"line_number":97,"context_line":"        subnet \u003d self.create_share_network_subnet(**self.data)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # set metadata"},{"line_number":100,"context_line":"        self.shares_v2_client.set_metadata("},{"line_number":101,"context_line":"            subnet[\u0027id\u0027], md, resource\u003d\"subnet\","},{"line_number":102,"context_line":"            parent_resource\u003d\"share-networks\","},{"line_number":103,"context_line":"            parent_id\u003dself.share_network[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # verify metadata"},{"line_number":106,"context_line":"        self._verify_subnet_metadata(subnet, md)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # delete metadata"},{"line_number":109,"context_line":"        for key in md.keys():"}],"source_content_type":"text/x-python","patch_set":10,"id":"d50f8382_0b63b56e","line":106,"range":{"start_line":96,"start_character":8,"end_line":106,"end_character":48},"in_reply_to":"5574540b_321c9ede","updated":"2025-06-26 10:29:40.000000000","message":"Acknowledged","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"51ffb6aef0d0107a555b958ca18ca55130aa9e39","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    def test_set_get_delete_metadata(self):"},{"line_number":94,"context_line":"        md \u003d {u\"key3\": u\"value3\", u\"key4\": u\"value4\", u\"key.5.1\": u\"value.5\"}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # create subnet"},{"line_number":97,"context_line":"        subnet \u003d self.create_share_network_subnet(**self.data)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # set metadata"},{"line_number":100,"context_line":"        self.shares_v2_client.set_metadata("},{"line_number":101,"context_line":"            subnet[\u0027id\u0027], md, resource\u003d\"subnet\","},{"line_number":102,"context_line":"            parent_resource\u003d\"share-networks\","},{"line_number":103,"context_line":"            parent_id\u003dself.share_network[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # verify metadata"},{"line_number":106,"context_line":"        self._verify_subnet_metadata(subnet, md)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # delete metadata"},{"line_number":109,"context_line":"        for key in md.keys():"}],"source_content_type":"text/x-python","patch_set":10,"id":"5574540b_321c9ede","line":106,"range":{"start_line":96,"start_character":8,"end_line":106,"end_character":48},"in_reply_to":"5668aca1_cdf9d6ec","updated":"2025-04-24 11:36:13.000000000","message":"I just wanted to reduce the total number of lines of code that why I suggested to move the duplicate code to separate method. But if you are fine with this approach also then I am fine with this.","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"dc3f8bdf5d26505eeb2a69b656835ab0ee430a8d","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    def test_set_get_delete_metadata(self):"},{"line_number":94,"context_line":"        md \u003d {u\"key3\": u\"value3\", u\"key4\": u\"value4\", u\"key.5.1\": u\"value.5\"}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # create subnet"},{"line_number":97,"context_line":"        subnet \u003d self.create_share_network_subnet(**self.data)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # set metadata"},{"line_number":100,"context_line":"        self.shares_v2_client.set_metadata("},{"line_number":101,"context_line":"            subnet[\u0027id\u0027], md, resource\u003d\"subnet\","},{"line_number":102,"context_line":"            parent_resource\u003d\"share-networks\","},{"line_number":103,"context_line":"            parent_id\u003dself.share_network[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # verify metadata"},{"line_number":106,"context_line":"        self._verify_subnet_metadata(subnet, md)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # delete metadata"},{"line_number":109,"context_line":"        for key in md.keys():"}],"source_content_type":"text/x-python","patch_set":10,"id":"5668aca1_cdf9d6ec","line":106,"range":{"start_line":96,"start_character":8,"end_line":106,"end_character":48},"in_reply_to":"7aade12e_70570fd6","updated":"2025-04-09 15:03:20.000000000","message":"I thought of optimizing after checking your comments, but it seems correct implementation is more appropriate as it gives step by step emulation of what test is doing.","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"40347024aa0c2a0adee83cd051e816572cd573f1","unresolved":true,"context_lines":[{"line_number":250,"context_line":"    def test_set_metadata_min_size_key(self):"},{"line_number":251,"context_line":"        data \u003d {\"k\": \"value\"}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        self.shares_v2_client.set_metadata(self.subnet[\u0027id\u0027],"},{"line_number":254,"context_line":"                                           data, resource\u003d\"subnet\","},{"line_number":255,"context_line":"                                           parent_resource\u003d\"share-networks\","},{"line_number":256,"context_line":"                                           parent_id\u003dself.share_network[\u0027id\u0027])"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        body_get \u003d self.shares_v2_client.get_metadata("},{"line_number":259,"context_line":"            self.subnet[\u0027id\u0027], resource\u003d\"subnet\","},{"line_number":260,"context_line":"            parent_resource\u003d\"share-networks\","},{"line_number":261,"context_line":"            parent_id\u003dself.share_network[\u0027id\u0027])[\u0027metadata\u0027]"},{"line_number":262,"context_line":"        self.assertEqual(data[\u0027k\u0027], body_get.get(\u0027k\u0027))"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @decorators.idempotent_id(\u0027b7933b35-04e7-4487-8e6a-730f7261a736\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"57ed48d0_30d1d9ab","line":261,"range":{"start_line":253,"start_character":8,"end_line":261,"end_character":59},"updated":"2025-04-08 16:28:49.000000000","message":"Can you create one private method and put these code in that and call this method from all the test methods.","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"dc3f8bdf5d26505eeb2a69b656835ab0ee430a8d","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    def test_set_metadata_min_size_key(self):"},{"line_number":251,"context_line":"        data \u003d {\"k\": \"value\"}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        self.shares_v2_client.set_metadata(self.subnet[\u0027id\u0027],"},{"line_number":254,"context_line":"                                           data, resource\u003d\"subnet\","},{"line_number":255,"context_line":"                                           parent_resource\u003d\"share-networks\","},{"line_number":256,"context_line":"                                           parent_id\u003dself.share_network[\u0027id\u0027])"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        body_get \u003d self.shares_v2_client.get_metadata("},{"line_number":259,"context_line":"            self.subnet[\u0027id\u0027], resource\u003d\"subnet\","},{"line_number":260,"context_line":"            parent_resource\u003d\"share-networks\","},{"line_number":261,"context_line":"            parent_id\u003dself.share_network[\u0027id\u0027])[\u0027metadata\u0027]"},{"line_number":262,"context_line":"        self.assertEqual(data[\u0027k\u0027], body_get.get(\u0027k\u0027))"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @decorators.idempotent_id(\u0027b7933b35-04e7-4487-8e6a-730f7261a736\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"c23bbb8b_c8c97cf7","line":261,"range":{"start_line":253,"start_character":8,"end_line":261,"end_character":59},"in_reply_to":"57ed48d0_30d1d9ab","updated":"2025-04-09 15:03:20.000000000","message":"Acknowledged","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"40347024aa0c2a0adee83cd051e816572cd573f1","unresolved":true,"context_lines":[{"line_number":320,"context_line":"    def test_upd_metadata_min_size_key(self):"},{"line_number":321,"context_line":"        data \u003d {\"k\": \"value\"}"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        self.shares_v2_client.update_all_metadata("},{"line_number":324,"context_line":"            self.subnet[\u0027id\u0027], data, resource\u003d\"subnet\","},{"line_number":325,"context_line":"            parent_resource\u003d\"share-networks\","},{"line_number":326,"context_line":"            parent_id\u003dself.share_network[\u0027id\u0027])"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        body_get \u003d self.shares_v2_client.get_metadata("},{"line_number":329,"context_line":"            self.subnet[\u0027id\u0027], resource\u003d\"subnet\","},{"line_number":330,"context_line":"            parent_resource\u003d\"share-networks\","},{"line_number":331,"context_line":"            parent_id\u003dself.share_network[\u0027id\u0027])[\u0027metadata\u0027]"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.assertEqual(data, body_get)"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"986413f5_4ae06518","line":331,"range":{"start_line":323,"start_character":8,"end_line":331,"end_character":59},"updated":"2025-04-08 16:28:49.000000000","message":"Can you create one private method and put these code in that and call this method from all the test methods.","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"dc3f8bdf5d26505eeb2a69b656835ab0ee430a8d","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    def test_upd_metadata_min_size_key(self):"},{"line_number":321,"context_line":"        data \u003d {\"k\": \"value\"}"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        self.shares_v2_client.update_all_metadata("},{"line_number":324,"context_line":"            self.subnet[\u0027id\u0027], data, resource\u003d\"subnet\","},{"line_number":325,"context_line":"            parent_resource\u003d\"share-networks\","},{"line_number":326,"context_line":"            parent_id\u003dself.share_network[\u0027id\u0027])"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        body_get \u003d self.shares_v2_client.get_metadata("},{"line_number":329,"context_line":"            self.subnet[\u0027id\u0027], resource\u003d\"subnet\","},{"line_number":330,"context_line":"            parent_resource\u003d\"share-networks\","},{"line_number":331,"context_line":"            parent_id\u003dself.share_network[\u0027id\u0027])[\u0027metadata\u0027]"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.assertEqual(data, body_get)"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"0ac93b87_80b0b7e8","line":331,"range":{"start_line":323,"start_character":8,"end_line":331,"end_character":59},"in_reply_to":"986413f5_4ae06518","updated":"2025-04-09 15:03:20.000000000","message":"Acknowledged","commit_id":"878c5aac090595a0e0bb336702acbfc994e72264"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6deda820f8ff14acd61ea5f697afb1f7ff5488a","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        super(ShareNetworkSubnetMetadataTest, cls).resource_setup()"},{"line_number":34,"context_line":"        # create share_network and subnet"},{"line_number":35,"context_line":"        cls.share_network \u003d cls.create_share_network(cleanup_in_class\u003dTrue)"},{"line_number":36,"context_line":"        az \u003d cls.shares_v2_client.list_availability_zones("},{"line_number":37,"context_line":"            )[\u0027availability_zones\u0027][0]"},{"line_number":38,"context_line":"        cls.az_name \u003d az[\u0027name\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        cls.data \u003d utils.generate_subnet_data()"},{"line_number":41,"context_line":"        cls.data[\u0027share_network_id\u0027] \u003d cls.share_network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"beecb1e2_f5729704","line":38,"range":{"start_line":36,"start_character":8,"end_line":38,"end_character":32},"updated":"2025-06-17 00:07:24.000000000","message":"note to reviewers: \n\nthis is fine when you\u0027re not creating a share.. but when you are, you must use \"get_availability_zones_matching_share_type\"","commit_id":"318ed6165babad9795ef5ea44c1cf73a0ba6da67"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d2ba3bc82c3941c555e0c33f1da4e96a204e7139","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(ShareNetworkSubnetMetadataTest, cls).resource_setup()"},{"line_number":34,"context_line":"        # create share_network and subnet"},{"line_number":35,"context_line":"        cls.share_network \u003d cls.create_share_network(cleanup_in_class\u003dTrue)"},{"line_number":36,"context_line":"        az \u003d cls.shares_v2_client.list_availability_zones("},{"line_number":37,"context_line":"            )[\u0027availability_zones\u0027][0]"},{"line_number":38,"context_line":"        cls.az_name \u003d az[\u0027name\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        cls.data \u003d utils.generate_subnet_data()"},{"line_number":41,"context_line":"        cls.data[\u0027share_network_id\u0027] \u003d cls.share_network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"18e20038_fa3b9876","line":38,"range":{"start_line":36,"start_character":8,"end_line":38,"end_character":32},"in_reply_to":"beecb1e2_f5729704","updated":"2025-06-17 07:48:59.000000000","message":"Acknowledged","commit_id":"318ed6165babad9795ef5ea44c1cf73a0ba6da67"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6deda820f8ff14acd61ea5f697afb1f7ff5488a","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u0027260744c2-c062-4ce3-a57e-cce475650e7b\u0027)"},{"line_number":66,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":67,"context_line":"    def test_set_metadata_in_subnet_creation(self):"},{"line_number":68,"context_line":"        share_network \u003d self.create_share_network()"},{"line_number":69,"context_line":"        az \u003d self.shares_v2_client.list_availability_zones("}],"source_content_type":"text/x-python","patch_set":11,"id":"da4b2532_ba3e6df4","line":66,"range":{"start_line":66,"start_character":37,"end_line":66,"end_character":57},"updated":"2025-06-17 00:07:24.000000000","message":"TAG_API\n\nnone of these tests need the manila-share service..","commit_id":"318ed6165babad9795ef5ea44c1cf73a0ba6da67"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d2ba3bc82c3941c555e0c33f1da4e96a204e7139","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u0027260744c2-c062-4ce3-a57e-cce475650e7b\u0027)"},{"line_number":66,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":67,"context_line":"    def test_set_metadata_in_subnet_creation(self):"},{"line_number":68,"context_line":"        share_network \u003d self.create_share_network()"},{"line_number":69,"context_line":"        az \u003d self.shares_v2_client.list_availability_zones("}],"source_content_type":"text/x-python","patch_set":11,"id":"61d59e0a_a400e060","line":66,"range":{"start_line":66,"start_character":37,"end_line":66,"end_character":57},"in_reply_to":"da4b2532_ba3e6df4","updated":"2025-06-17 07:48:59.000000000","message":"Done","commit_id":"318ed6165babad9795ef5ea44c1cf73a0ba6da67"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03aa1f0f708d27093aee189f0392cfc551a42d30","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        # verify metadata"},{"line_number":55,"context_line":"        self.assertEqual(md, metadata)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # verify metadata items"},{"line_number":58,"context_line":"        for key in md:"},{"line_number":59,"context_line":"            get_value \u003d self.shares_v2_client.get_metadata_item("},{"line_number":60,"context_line":"                subnet[\u0027id\u0027], key, resource\u003d\"subnet\","},{"line_number":61,"context_line":"                parent_resource\u003d\"share-networks\","},{"line_number":62,"context_line":"                parent_id\u003dsubnet[\u0027share_network_id\u0027])[\u0027meta\u0027]"},{"line_number":63,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u0027260744c2-c062-4ce3-a57e-cce475650e7b\u0027)"},{"line_number":66,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":67,"context_line":"    def test_set_metadata_in_subnet_creation(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"eb5209fe_8d89b608","line":64,"range":{"start_line":57,"start_character":8,"end_line":64,"end_character":0},"updated":"2025-06-24 19:29:30.000000000","message":"this is also testing get_item at the end,isn\u0027t it? wouldn\u0027t the whole metadata be returned as part of `metadata` on line 49 and already be validated on line 55? if we assert that one object is equal to the other, we already know that all of the key\u003dval are equal. Am I missing something? If that is it, then maybe we can drop this individual validation and leave it only for the scenarios that test get_item","commit_id":"0fec91ac5eb9fcd04acb8d3e2758956b2d5d2069"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ec91db562484710d49b153a967b632bbe21dd7d6","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        # verify metadata"},{"line_number":55,"context_line":"        self.assertEqual(md, metadata)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # verify metadata items"},{"line_number":58,"context_line":"        for key in md:"},{"line_number":59,"context_line":"            get_value \u003d self.shares_v2_client.get_metadata_item("},{"line_number":60,"context_line":"                subnet[\u0027id\u0027], key, resource\u003d\"subnet\","},{"line_number":61,"context_line":"                parent_resource\u003d\"share-networks\","},{"line_number":62,"context_line":"                parent_id\u003dsubnet[\u0027share_network_id\u0027])[\u0027meta\u0027]"},{"line_number":63,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u0027260744c2-c062-4ce3-a57e-cce475650e7b\u0027)"},{"line_number":66,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":67,"context_line":"    def test_set_metadata_in_subnet_creation(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"d4b95dd3_f65c629d","line":64,"range":{"start_line":57,"start_character":8,"end_line":64,"end_character":0},"in_reply_to":"eb5209fe_8d89b608","updated":"2025-06-26 10:29:40.000000000","message":"I think original PR creator have assumed that to verify both metadata and metadaitems to validate APIs are working fine. I dont see issue with keep as it is. But if you want, I will remove individual items validation. let me know.","commit_id":"0fec91ac5eb9fcd04acb8d3e2758956b2d5d2069"}],"manila_tempest_tests/tests/api/test_share_network_subnet_metadata_negative.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"5aa8bdad3a5a1a15349e754694d9ac7cbd7f7153","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @decorators.idempotent_id(\u0027852d080f-16f3-48c4-af26-d8440be9801b\u0027)"},{"line_number":48,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":49,"context_line":"    def test_try_set_metadata_to_unexisting_snapshot(self):"},{"line_number":50,"context_line":"        share_network \u003d self.create_share_network()"},{"line_number":51,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":52,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c760dd5f_03a3275b","line":49,"updated":"2023-04-03 15:08:31.000000000","message":"Change resource name to subnet.","commit_id":"8affb691815f4785e3c40d5b5c8a7d02a7f13384"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48d88ee4bd0d4eba8e5d390670bdb4ab5c46d141","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @decorators.idempotent_id(\u0027852d080f-16f3-48c4-af26-d8440be9801b\u0027)"},{"line_number":48,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":49,"context_line":"    def test_try_set_metadata_to_unexisting_snapshot(self):"},{"line_number":50,"context_line":"        share_network \u003d self.create_share_network()"},{"line_number":51,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":52,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a34b683_72c6437d","line":49,"in_reply_to":"c760dd5f_03a3275b","updated":"2023-04-03 17:09:48.000000000","message":"Done","commit_id":"8affb691815f4785e3c40d5b5c8a7d02a7f13384"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"5aa8bdad3a5a1a15349e754694d9ac7cbd7f7153","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.idempotent_id(\u0027dfe93a02-43cc-458c-92e5-ede6c2c2e597\u0027)"},{"line_number":59,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":60,"context_line":"    def test_try_update_all_metadata_to_unexisting_snapshot(self):"},{"line_number":61,"context_line":"        share_network \u003d self.create_share_network()"},{"line_number":62,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":63,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f11aeab4_3f807aa3","line":60,"updated":"2023-04-03 15:08:31.000000000","message":"Change resource name to subnet.","commit_id":"8affb691815f4785e3c40d5b5c8a7d02a7f13384"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"48d88ee4bd0d4eba8e5d390670bdb4ab5c46d141","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.idempotent_id(\u0027dfe93a02-43cc-458c-92e5-ede6c2c2e597\u0027)"},{"line_number":59,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":60,"context_line":"    def test_try_update_all_metadata_to_unexisting_snapshot(self):"},{"line_number":61,"context_line":"        share_network \u003d self.create_share_network()"},{"line_number":62,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":63,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e2c1def6_42a8c4f7","line":60,"in_reply_to":"f11aeab4_3f807aa3","updated":"2023-04-03 17:09:48.000000000","message":"Done","commit_id":"8affb691815f4785e3c40d5b5c8a7d02a7f13384"}]}