)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe4c69275eef7e48e4e952cc9b3834f7e6111984","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f23e8c6_f38ce262","updated":"2023-08-21 20:39:39.000000000","message":"Thanks Carlos; the test cases are good; a few comments inline. If you\u0027re open to it, i\u0027d like to suggest a test that prevents duplicate visibility locks..","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"056b5f2e6b4b3696db535b17828c09fb345b45f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"07a386ae_dfc445a8","updated":"2023-08-23 18:16:14.000000000","message":"Thanks for the review, Goutham! Please take another look :)","commit_id":"783f67b475e04fac0b1bdd6f42809f6eac9752aa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d0487d2121af3fa8925c9f7d072e710c8557bf97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"00f0efae_123d4ab6","updated":"2023-08-24 21:29:52.000000000","message":"Thanks for the review, please take a look in the newest PS :)","commit_id":"b05115c73d8c7c85a90dea47b393a53e70c87d45"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b694af5ef898a26904828f5a01b5656a6c39d208","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d209592e_88eea4c5","updated":"2023-08-30 12:12:52.000000000","message":"Overall it looks good. Nice coverage and asserts. However, from my understanding the \"service\" role is very important here. Are you testing \"services\" trying to access restricted rules and so on ? I identified for \"admin\" only (I might miss something, though_.","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c10b48adac66a13c6e113bc5ef49c13ebf6c3260","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f964ad7b_1114d086","updated":"2023-09-12 22:08:35.000000000","message":"Thanks Carlos; mostly LGTM.. a couple of minor suggestions inline","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c5b9d400ed19e738fbf12407d436e366ad29d781","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"400b2237_80f6f7ea","updated":"2023-09-29 15:03:03.000000000","message":"Thanks for the reviews, please take a look at the most recent PS","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"38a57eaeaee3491adf34ac8220f50f11d380c9af","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"85e89411_71df16fd","in_reply_to":"d209592e_88eea4c5","updated":"2023-08-30 19:48:03.000000000","message":"Hi, Felipe! Yes, the service role is very important. It is a bit tricky to test using the service role and we\u0027ll likely need to adapt a couple of things in manila-tempest-plugin. We are expecting that the Nova team will help with those integration tests.","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"61013cdfd8da99358156434340aa33befea5ddf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cacf7def_746f90cc","updated":"2024-01-27 00:53:32.000000000","message":"Hey Carlos; thanks for the changes.. i\u0027ve a few more comments..","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8cec91877c240c81ee05bef1daa63a951ebe059","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ccff4a55_9c326eec","updated":"2024-01-29 22:44:20.000000000","message":"Thank you for the review! PTAL at the latest PS","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"197eb90c017d0f975d804cbe27d21a44cf7d3d5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8e7f028a_e9da91b8","updated":"2024-01-22 12:30:33.000000000","message":"recheck\nLogs are gone","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1682c1befa4e8764aad879ff53b4a2820722b302","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"40fd2ac2_7ce7602e","updated":"2024-03-07 06:33:41.000000000","message":"Thanks Carlos!\nIt\u0027s been a very long time since my last review.\nSo I hope I\u0027m not writing nonsense:).","commit_id":"579e609064398ba6a4a5ce72df69aa4ad98dab85"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bd020a170646d3c51e63e4b7b864b21b41c4ea52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6e0dde44_67b9a926","updated":"2024-03-12 17:09:21.000000000","message":"Thank you very much for the reviews, Liron and Goutham!\nPlease take a look at the most recent PS :)","commit_id":"e713b5e368b6f29871fa94f745f0caf7c6c94761"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"74d26f215fc70ce008e863049992f2ee8f30dbd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"67f1b605_4c16a37b","updated":"2024-03-13 15:15:50.000000000","message":"LGTM, thanks Carlos.","commit_id":"d10819b89b81a34a7343a3250fed3ea8cd29b838"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91e601f65b4922d51f44e9d79e3c01229d2ec478","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c7e425c7_336e4851","updated":"2024-03-12 21:40:50.000000000","message":"Thanks Carlos","commit_id":"d10819b89b81a34a7343a3250fed3ea8cd29b838"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe4c69275eef7e48e4e952cc9b3834f7e6111984","unresolved":true,"context_lines":[{"line_number":1032,"context_line":"            \u0027access_level\u0027: access_level"},{"line_number":1033,"context_line":"        }"},{"line_number":1034,"context_line":"        delete_kwargs \u003d ("},{"line_number":1035,"context_line":"            {\u0027unrestrict\u0027: True} if lock_deletion else {})"},{"line_number":1036,"context_line":"        if client is self.shares_v2_client:"},{"line_number":1037,"context_line":"            kwargs.update({\u0027metadata\u0027: metadata, \u0027version\u0027: version})"},{"line_number":1038,"context_line":"        if lock_visibitily:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ed5996ff_bfa50237","line":1035,"range":{"start_line":1035,"start_character":57,"end_line":1035,"end_character":58},"updated":"2023-08-21 20:39:39.000000000","message":"nit: push closing parenthesis to next line","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"056b5f2e6b4b3696db535b17828c09fb345b45f7","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"            \u0027access_level\u0027: access_level"},{"line_number":1033,"context_line":"        }"},{"line_number":1034,"context_line":"        delete_kwargs \u003d ("},{"line_number":1035,"context_line":"            {\u0027unrestrict\u0027: True} if lock_deletion else {})"},{"line_number":1036,"context_line":"        if client is self.shares_v2_client:"},{"line_number":1037,"context_line":"            kwargs.update({\u0027metadata\u0027: metadata, \u0027version\u0027: version})"},{"line_number":1038,"context_line":"        if lock_visibitily:"}],"source_content_type":"text/x-python","patch_set":5,"id":"74b9ba4f_720daf0c","line":1035,"range":{"start_line":1035,"start_character":57,"end_line":1035,"end_character":58},"in_reply_to":"ed5996ff_bfa50237","updated":"2023-08-23 18:16:14.000000000","message":"Done","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33717bb98fd5dc4839215bcaf553bced2e4f18c2","unresolved":true,"context_lines":[{"line_number":1017,"context_line":"    def allow_access(self, share_id, client\u003dNone, access_type\u003dNone,"},{"line_number":1018,"context_line":"                     access_level\u003d\u0027rw\u0027, access_to\u003dNone, metadata\u003dNone,"},{"line_number":1019,"context_line":"                     version\u003dLATEST_MICROVERSION, status\u003d\u0027active\u0027,"},{"line_number":1020,"context_line":"                     raise_rule_in_error_state\u003dTrue, lock_visibitily\u003dFalse,"},{"line_number":1021,"context_line":"                     lock_deletion\u003dFalse, cleanup\u003dTrue):"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        client \u003d client or self.shares_v2_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"c058e22f_678c1e38","line":1020,"range":{"start_line":1020,"start_character":53,"end_line":1020,"end_character":68},"updated":"2023-08-23 23:23:47.000000000","message":"spelling","commit_id":"783f67b475e04fac0b1bdd6f42809f6eac9752aa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c9d4c8c85f359362d8e91ad47c394bb9fef4634","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"    def allow_access(self, share_id, client\u003dNone, access_type\u003dNone,"},{"line_number":1018,"context_line":"                     access_level\u003d\u0027rw\u0027, access_to\u003dNone, metadata\u003dNone,"},{"line_number":1019,"context_line":"                     version\u003dLATEST_MICROVERSION, status\u003d\u0027active\u0027,"},{"line_number":1020,"context_line":"                     raise_rule_in_error_state\u003dTrue, lock_visibitily\u003dFalse,"},{"line_number":1021,"context_line":"                     lock_deletion\u003dFalse, cleanup\u003dTrue):"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        client \u003d client or self.shares_v2_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"5dca4032_77a7330d","line":1020,"range":{"start_line":1020,"start_character":53,"end_line":1020,"end_character":68},"in_reply_to":"c058e22f_678c1e38","updated":"2023-08-24 21:29:32.000000000","message":"Done","commit_id":"783f67b475e04fac0b1bdd6f42809f6eac9752aa"}],"manila_tempest_tests/tests/api/test_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe4c69275eef7e48e4e952cc9b3834f7e6111984","unresolved":true,"context_lines":[{"line_number":537,"context_line":"            access_type\u003dself.access_type, access_to\u003dself.access_to,"},{"line_number":538,"context_line":"            lock_visibitily\u003dlock_visibility, lock_deletion\u003dTrue)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        rules \u003d self.new_user.shares_v2_client.list_access_rules("},{"line_number":541,"context_line":"            self.share[\u0027id\u0027])[\u0027access_list\u0027]"},{"line_number":542,"context_line":"        access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":543,"context_line":"        access_key \u003d \u0027******\u0027 if lock_visibility else None"}],"source_content_type":"text/x-python","patch_set":5,"id":"ad5eea68_ec7ceddb","line":540,"range":{"start_line":540,"start_character":47,"end_line":540,"end_character":64},"updated":"2023-08-21 20:39:39.000000000","message":"could you add two calls here?\n\none with max configred microversion (happens by default when you don\u0027t specify a microversion)\n\nanother with a version less than that.. \n\nthe goal is to test that the access restrictions apply no matter the microversion of the request","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"056b5f2e6b4b3696db535b17828c09fb345b45f7","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            access_type\u003dself.access_type, access_to\u003dself.access_to,"},{"line_number":538,"context_line":"            lock_visibitily\u003dlock_visibility, lock_deletion\u003dTrue)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        rules \u003d self.new_user.shares_v2_client.list_access_rules("},{"line_number":541,"context_line":"            self.share[\u0027id\u0027])[\u0027access_list\u0027]"},{"line_number":542,"context_line":"        access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":543,"context_line":"        access_key \u003d \u0027******\u0027 if lock_visibility else None"}],"source_content_type":"text/x-python","patch_set":5,"id":"152b2103_4f0b320f","line":540,"range":{"start_line":540,"start_character":47,"end_line":540,"end_character":64},"in_reply_to":"ad5eea68_ec7ceddb","updated":"2023-08-23 18:16:14.000000000","message":"Done","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe4c69275eef7e48e4e952cc9b3834f7e6111984","unresolved":true,"context_lines":[{"line_number":543,"context_line":"        access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        # verify values"},{"line_number":546,"context_line":"        self.assertEqual(access_to, rules[0][\"access_to\"])"},{"line_number":547,"context_line":"        if self.access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":548,"context_line":"            self.assertEqual(access_key, rules[0][\u0027access_key\u0027])"},{"line_number":549,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa71a33_b6ecfa1d","line":546,"range":{"start_line":546,"start_character":8,"end_line":546,"end_character":58},"updated":"2023-08-21 20:39:39.000000000","message":"if a different test in this class fails, we\u0027d probably fail this test too depending on whether the first rule in the list is the rule that was added with restrictions.\n\ninstead of looking at the first element, maybe get the rule ID from line 535 and filter the access list for the rule ID..","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"056b5f2e6b4b3696db535b17828c09fb345b45f7","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        # verify values"},{"line_number":546,"context_line":"        self.assertEqual(access_to, rules[0][\"access_to\"])"},{"line_number":547,"context_line":"        if self.access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":548,"context_line":"            self.assertEqual(access_key, rules[0][\u0027access_key\u0027])"},{"line_number":549,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ecfb7f48_647c21c2","line":546,"range":{"start_line":546,"start_character":8,"end_line":546,"end_character":58},"in_reply_to":"1fa71a33_b6ecfa1d","updated":"2023-08-23 18:16:14.000000000","message":"Done","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe4c69275eef7e48e4e952cc9b3834f7e6111984","unresolved":true,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        # verify values"},{"line_number":546,"context_line":"        self.assertEqual(access_to, rules[0][\"access_to\"])"},{"line_number":547,"context_line":"        if self.access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":548,"context_line":"            self.assertEqual(access_key, rules[0][\u0027access_key\u0027])"},{"line_number":549,"context_line":"        else:"},{"line_number":550,"context_line":"            self.assertEqual(access_key, rules[0][\u0027access_key\u0027])"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    @decorators.idempotent_id(\u00274829265a-eb32-400d-91a0-be06ce31a2ef\u0027)"},{"line_number":553,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":5,"id":"514c2387_33d398e3","line":550,"range":{"start_line":547,"start_character":8,"end_line":550,"end_character":64},"updated":"2023-08-21 20:39:39.000000000","message":"the asserts are the same, so the condition isn\u0027t necessary","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"056b5f2e6b4b3696db535b17828c09fb345b45f7","unresolved":false,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        # verify values"},{"line_number":546,"context_line":"        self.assertEqual(access_to, rules[0][\"access_to\"])"},{"line_number":547,"context_line":"        if self.access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":548,"context_line":"            self.assertEqual(access_key, rules[0][\u0027access_key\u0027])"},{"line_number":549,"context_line":"        else:"},{"line_number":550,"context_line":"            self.assertEqual(access_key, rules[0][\u0027access_key\u0027])"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    @decorators.idempotent_id(\u00274829265a-eb32-400d-91a0-be06ce31a2ef\u0027)"},{"line_number":553,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":5,"id":"160f5ed6_3547e87e","line":550,"range":{"start_line":547,"start_character":8,"end_line":550,"end_character":64},"in_reply_to":"514c2387_33d398e3","updated":"2023-08-23 18:16:14.000000000","message":"Done","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe4c69275eef7e48e4e952cc9b3834f7e6111984","unresolved":true,"context_lines":[{"line_number":584,"context_line":"            lock_visibitily\u003dTrue, lock_deletion\u003dTrue)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"        self.admin_shares_v2_client.delete_access_rule("},{"line_number":587,"context_line":"            self.share[\u0027id\u0027], rule[\u0027id\u0027], unrestrict\u003dTrue)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    @decorators.idempotent_id(\u0027c107b0b7-7a3e-4114-af64-ca8fe6e836c9\u0027)"},{"line_number":590,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":5,"id":"66918661_15cefae0","line":587,"range":{"start_line":587,"start_character":57,"end_line":587,"end_character":58},"updated":"2023-08-21 20:39:39.000000000","message":"set \"cleanup\u003dFalse\" in the allow_access call above and wait for deletion after this step instead.. it\u0027ll ensure correct behavior","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"056b5f2e6b4b3696db535b17828c09fb345b45f7","unresolved":false,"context_lines":[{"line_number":584,"context_line":"            lock_visibitily\u003dTrue, lock_deletion\u003dTrue)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"        self.admin_shares_v2_client.delete_access_rule("},{"line_number":587,"context_line":"            self.share[\u0027id\u0027], rule[\u0027id\u0027], unrestrict\u003dTrue)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    @decorators.idempotent_id(\u0027c107b0b7-7a3e-4114-af64-ca8fe6e836c9\u0027)"},{"line_number":590,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":5,"id":"005c4652_76440e6d","line":587,"range":{"start_line":587,"start_character":57,"end_line":587,"end_character":58},"in_reply_to":"66918661_15cefae0","updated":"2023-08-23 18:16:14.000000000","message":"Done","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe4c69275eef7e48e4e952cc9b3834f7e6111984","unresolved":true,"context_lines":[{"line_number":587,"context_line":"            self.share[\u0027id\u0027], rule[\u0027id\u0027], unrestrict\u003dTrue)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    @decorators.idempotent_id(\u0027c107b0b7-7a3e-4114-af64-ca8fe6e836c9\u0027)"},{"line_number":590,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":591,"context_line":"    @ddt.data(True, False)"},{"line_number":592,"context_line":"    def test_allow_access_lock_deletion(self, same_user):"},{"line_number":593,"context_line":"        utils.check_skip_if_microversion_not_supported("}],"source_content_type":"text/x-python","patch_set":5,"id":"59f1159c_83ae50e4","line":590,"range":{"start_line":590,"start_character":18,"end_line":590,"end_character":30},"updated":"2023-08-21 20:39:39.000000000","message":"NEGATIVE; a test that ends with assertRaises is really a negative test.. \n\nand should be moved to the \"test_rules_negative\" module","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"056b5f2e6b4b3696db535b17828c09fb345b45f7","unresolved":false,"context_lines":[{"line_number":587,"context_line":"            self.share[\u0027id\u0027], rule[\u0027id\u0027], unrestrict\u003dTrue)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    @decorators.idempotent_id(\u0027c107b0b7-7a3e-4114-af64-ca8fe6e836c9\u0027)"},{"line_number":590,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":591,"context_line":"    @ddt.data(True, False)"},{"line_number":592,"context_line":"    def test_allow_access_lock_deletion(self, same_user):"},{"line_number":593,"context_line":"        utils.check_skip_if_microversion_not_supported("}],"source_content_type":"text/x-python","patch_set":5,"id":"c22a935e_f1ff63a8","line":590,"range":{"start_line":590,"start_character":18,"end_line":590,"end_character":30},"in_reply_to":"59f1159c_83ae50e4","updated":"2023-08-23 18:16:14.000000000","message":"Done","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe4c69275eef7e48e4e952cc9b3834f7e6111984","unresolved":true,"context_lines":[{"line_number":589,"context_line":"    @decorators.idempotent_id(\u0027c107b0b7-7a3e-4114-af64-ca8fe6e836c9\u0027)"},{"line_number":590,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":591,"context_line":"    @ddt.data(True, False)"},{"line_number":592,"context_line":"    def test_allow_access_lock_deletion(self, same_user):"},{"line_number":593,"context_line":"        utils.check_skip_if_microversion_not_supported("},{"line_number":594,"context_line":"            RESTRICTED_RULES_VERSION)"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9dd22bcc_be094403","line":592,"range":{"start_line":592,"start_character":8,"end_line":592,"end_character":39},"updated":"2023-08-21 20:39:39.000000000","message":"```test_deny_access_without_unrestrict```\n\nperhaps?","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"056b5f2e6b4b3696db535b17828c09fb345b45f7","unresolved":false,"context_lines":[{"line_number":589,"context_line":"    @decorators.idempotent_id(\u0027c107b0b7-7a3e-4114-af64-ca8fe6e836c9\u0027)"},{"line_number":590,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":591,"context_line":"    @ddt.data(True, False)"},{"line_number":592,"context_line":"    def test_allow_access_lock_deletion(self, same_user):"},{"line_number":593,"context_line":"        utils.check_skip_if_microversion_not_supported("},{"line_number":594,"context_line":"            RESTRICTED_RULES_VERSION)"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"927acdb5_9ba0f29b","line":592,"range":{"start_line":592,"start_character":8,"end_line":592,"end_character":39},"in_reply_to":"9dd22bcc_be094403","updated":"2023-08-23 18:16:14.000000000","message":"Done","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe4c69275eef7e48e4e952cc9b3834f7e6111984","unresolved":true,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        client \u003d ("},{"line_number":603,"context_line":"            self.shares_v2_client"},{"line_number":604,"context_line":"            if same_user else self.new_user.shares_v2_client)"},{"line_number":605,"context_line":"        self.assertRaises("},{"line_number":606,"context_line":"            lib_exc.Forbidden,"},{"line_number":607,"context_line":"            client.delete_access_rule,"}],"source_content_type":"text/x-python","patch_set":5,"id":"cefed7a0_7795e181","line":604,"range":{"start_line":604,"start_character":60,"end_line":604,"end_character":61},"updated":"2023-08-21 20:39:39.000000000","message":"move closing parenthesis to next line","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"056b5f2e6b4b3696db535b17828c09fb345b45f7","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        client \u003d ("},{"line_number":603,"context_line":"            self.shares_v2_client"},{"line_number":604,"context_line":"            if same_user else self.new_user.shares_v2_client)"},{"line_number":605,"context_line":"        self.assertRaises("},{"line_number":606,"context_line":"            lib_exc.Forbidden,"},{"line_number":607,"context_line":"            client.delete_access_rule,"}],"source_content_type":"text/x-python","patch_set":5,"id":"d3bc1f8a_c7ccf734","line":604,"range":{"start_line":604,"start_character":60,"end_line":604,"end_character":61},"in_reply_to":"cefed7a0_7795e181","updated":"2023-08-23 18:16:14.000000000","message":"Done","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe4c69275eef7e48e4e952cc9b3834f7e6111984","unresolved":true,"context_lines":[{"line_number":604,"context_line":"            if same_user else self.new_user.shares_v2_client)"},{"line_number":605,"context_line":"        self.assertRaises("},{"line_number":606,"context_line":"            lib_exc.Forbidden,"},{"line_number":607,"context_line":"            client.delete_access_rule,"},{"line_number":608,"context_line":"            self.share[\u0027id\u0027],"},{"line_number":609,"context_line":"            rule[\u0027id\u0027])"},{"line_number":610,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"909e120b_9f54c6b8","line":607,"range":{"start_line":607,"start_character":18,"end_line":607,"end_character":38},"updated":"2023-08-21 20:39:39.000000000","message":"could you try this again with a lower microversion?","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"056b5f2e6b4b3696db535b17828c09fb345b45f7","unresolved":false,"context_lines":[{"line_number":604,"context_line":"            if same_user else self.new_user.shares_v2_client)"},{"line_number":605,"context_line":"        self.assertRaises("},{"line_number":606,"context_line":"            lib_exc.Forbidden,"},{"line_number":607,"context_line":"            client.delete_access_rule,"},{"line_number":608,"context_line":"            self.share[\u0027id\u0027],"},{"line_number":609,"context_line":"            rule[\u0027id\u0027])"},{"line_number":610,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fac11afd_6b32cdd6","line":607,"range":{"start_line":607,"start_character":18,"end_line":607,"end_character":38},"in_reply_to":"909e120b_9f54c6b8","updated":"2023-08-23 18:16:14.000000000","message":"Done","commit_id":"73555b8c8539948c85fc746c900c94420364805c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c10b48adac66a13c6e113bc5ef49c13ebf6c3260","unresolved":true,"context_lines":[{"line_number":577,"context_line":"        # ensure admin can see rules even if locked"},{"line_number":578,"context_line":"        self.assertEqual(self.access_to, rules[0][\"access_to\"])"},{"line_number":579,"context_line":"        if self.access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":580,"context_line":"            self.assertIsNotNone(rules[0][\u0027access_key\u0027])"},{"line_number":581,"context_line":"        else:"},{"line_number":582,"context_line":"            self.assertIsNone(rules[0][\u0027access_key\u0027])"},{"line_number":583,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"0c34e500_3014ab79","line":580,"range":{"start_line":580,"start_character":12,"end_line":580,"end_character":56},"updated":"2023-09-12 22:08:35.000000000","message":"could add another assert after this one:\n\n```\n self.assertFalse(rules[0][\u0027access_key\u0027] \u003d\u003d \u0027******\u0027)\n```","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"61013cdfd8da99358156434340aa33befea5ddf9","unresolved":true,"context_lines":[{"line_number":577,"context_line":"        # ensure admin can see rules even if locked"},{"line_number":578,"context_line":"        self.assertEqual(self.access_to, rules[0][\"access_to\"])"},{"line_number":579,"context_line":"        if self.access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":580,"context_line":"            self.assertIsNotNone(rules[0][\u0027access_key\u0027])"},{"line_number":581,"context_line":"        else:"},{"line_number":582,"context_line":"            self.assertIsNone(rules[0][\u0027access_key\u0027])"},{"line_number":583,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"08b4329d_cf179250","line":580,"range":{"start_line":580,"start_character":12,"end_line":580,"end_character":56},"in_reply_to":"006b59f3_269ba6de","updated":"2024-01-27 00:53:32.000000000","message":"yes, that\u0027s why \"assertFalse\".. but, \n\nI see that you inverted the condition below.. \n\nThis should be either:\n\n```\nself.assertFalse(rules[0][\u0027access_key\u0027] \u003d\u003d \u0027******\u0027)\n\n```\n\nor\n\n```\nself.assertTrue(rules[0][\u0027access_key\u0027] !\u003d \u0027******\u0027)\n\n```\n\nSo i\u0027m confused how this test is passing.","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8cec91877c240c81ee05bef1daa63a951ebe059","unresolved":true,"context_lines":[{"line_number":577,"context_line":"        # ensure admin can see rules even if locked"},{"line_number":578,"context_line":"        self.assertEqual(self.access_to, rules[0][\"access_to\"])"},{"line_number":579,"context_line":"        if self.access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":580,"context_line":"            self.assertIsNotNone(rules[0][\u0027access_key\u0027])"},{"line_number":581,"context_line":"        else:"},{"line_number":582,"context_line":"            self.assertIsNone(rules[0][\u0027access_key\u0027])"},{"line_number":583,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ec80abe_3d23667d","line":580,"range":{"start_line":580,"start_character":12,"end_line":580,"end_character":56},"in_reply_to":"08b4329d_cf179250","updated":"2024-01-29 22:44:20.000000000","message":"You\u0027re correct. Changed it, let\u0027s see how the test behaves","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c5b9d400ed19e738fbf12407d436e366ad29d781","unresolved":true,"context_lines":[{"line_number":577,"context_line":"        # ensure admin can see rules even if locked"},{"line_number":578,"context_line":"        self.assertEqual(self.access_to, rules[0][\"access_to\"])"},{"line_number":579,"context_line":"        if self.access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":580,"context_line":"            self.assertIsNotNone(rules[0][\u0027access_key\u0027])"},{"line_number":581,"context_line":"        else:"},{"line_number":582,"context_line":"            self.assertIsNone(rules[0][\u0027access_key\u0027])"},{"line_number":583,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"006b59f3_269ba6de","line":580,"range":{"start_line":580,"start_character":12,"end_line":580,"end_character":56},"in_reply_to":"0c34e500_3014ab79","updated":"2023-09-29 15:03:03.000000000","message":"admin should have the permission to view the fields, right? so we should assert that this field is different from ******","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bd020a170646d3c51e63e4b7b864b21b41c4ea52","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # ensure admin can see rules even if locked"},{"line_number":578,"context_line":"        self.assertEqual(self.access_to, rules[0][\"access_to\"])"},{"line_number":579,"context_line":"        if self.access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":580,"context_line":"            self.assertIsNotNone(rules[0][\u0027access_key\u0027])"},{"line_number":581,"context_line":"        else:"},{"line_number":582,"context_line":"            self.assertIsNone(rules[0][\u0027access_key\u0027])"},{"line_number":583,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"4bf30485_23e79f5a","line":580,"range":{"start_line":580,"start_character":12,"end_line":580,"end_character":56},"in_reply_to":"9ec80abe_3d23667d","updated":"2024-03-12 17:09:21.000000000","message":"Done","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"61013cdfd8da99358156434340aa33befea5ddf9","unresolved":true,"context_lines":[{"line_number":542,"context_line":"        rules_get_lower_version \u003d ("},{"line_number":543,"context_line":"            self.new_user.shares_v2_client.list_access_rules("},{"line_number":544,"context_line":"                self.share[\u0027id\u0027], version\u003d\u00272.81\u0027)[\u0027access_list\u0027])"},{"line_number":545,"context_line":"        access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":546,"context_line":"        access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        # verify values"}],"source_content_type":"text/x-python","patch_set":10,"id":"4837eee3_d3633b66","line":545,"range":{"start_line":545,"start_character":8,"end_line":545,"end_character":17},"updated":"2024-01-27 00:53:32.000000000","message":"minor nit:\n\ncan you call this: `expected_access_to`\n\nit\u0027ll enhance readability","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8cec91877c240c81ee05bef1daa63a951ebe059","unresolved":false,"context_lines":[{"line_number":542,"context_line":"        rules_get_lower_version \u003d ("},{"line_number":543,"context_line":"            self.new_user.shares_v2_client.list_access_rules("},{"line_number":544,"context_line":"                self.share[\u0027id\u0027], version\u003d\u00272.81\u0027)[\u0027access_list\u0027])"},{"line_number":545,"context_line":"        access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":546,"context_line":"        access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        # verify values"}],"source_content_type":"text/x-python","patch_set":10,"id":"1323f5da_96b5e768","line":545,"range":{"start_line":545,"start_character":8,"end_line":545,"end_character":17},"in_reply_to":"4837eee3_d3633b66","updated":"2024-01-29 22:44:20.000000000","message":"Done","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"61013cdfd8da99358156434340aa33befea5ddf9","unresolved":true,"context_lines":[{"line_number":543,"context_line":"            self.new_user.shares_v2_client.list_access_rules("},{"line_number":544,"context_line":"                self.share[\u0027id\u0027], version\u003d\u00272.81\u0027)[\u0027access_list\u0027])"},{"line_number":545,"context_line":"        access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":546,"context_line":"        access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        # verify values"},{"line_number":549,"context_line":"        for rule_list in [rules, rules_get_lower_version]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"47c94547_915a958f","line":546,"updated":"2024-01-27 00:53:32.000000000","message":"same","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8cec91877c240c81ee05bef1daa63a951ebe059","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            self.new_user.shares_v2_client.list_access_rules("},{"line_number":544,"context_line":"                self.share[\u0027id\u0027], version\u003d\u00272.81\u0027)[\u0027access_list\u0027])"},{"line_number":545,"context_line":"        access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":546,"context_line":"        access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        # verify values"},{"line_number":549,"context_line":"        for rule_list in [rules, rules_get_lower_version]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"c4cb97f6_090d7976","line":546,"in_reply_to":"47c94547_915a958f","updated":"2024-01-29 22:44:20.000000000","message":"Done","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"61013cdfd8da99358156434340aa33befea5ddf9","unresolved":true,"context_lines":[{"line_number":546,"context_line":"        access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        # verify values"},{"line_number":549,"context_line":"        for rule_list in [rules, rules_get_lower_version]:"},{"line_number":550,"context_line":"            for access_rule in rule_list:"},{"line_number":551,"context_line":"                if rule[\u0027id\u0027] \u003d\u003d access_rule[\u0027id\u0027]:"},{"line_number":552,"context_line":"                    self.assertEqual(access_to, rules[0][\"access_to\"])"},{"line_number":553,"context_line":"                    self.assertEqual("}],"source_content_type":"text/x-python","patch_set":10,"id":"15826673_370f788c","line":550,"range":{"start_line":549,"start_character":8,"end_line":550,"end_character":41},"updated":"2024-01-27 00:53:32.000000000","message":"instead of looping, extract the rule you want:\n\n```\n   rule_latest_rules_api \u003d [r for r in rules if r[\u0027id\u0027] \u003d\u003d rule[\u0027id\u0027]][0]\n   rule_lower_version_rules_api \u003d [r for r in rules_get_lower_version\n                                  if r[\u0027id\u0027] \u003d\u003d rule[\u0027id\u0027]][0]\n\n```\n\nit\u0027s still O(n) and we wouldn\u0027t need the \u0027break\u0027","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8cec91877c240c81ee05bef1daa63a951ebe059","unresolved":false,"context_lines":[{"line_number":546,"context_line":"        access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        # verify values"},{"line_number":549,"context_line":"        for rule_list in [rules, rules_get_lower_version]:"},{"line_number":550,"context_line":"            for access_rule in rule_list:"},{"line_number":551,"context_line":"                if rule[\u0027id\u0027] \u003d\u003d access_rule[\u0027id\u0027]:"},{"line_number":552,"context_line":"                    self.assertEqual(access_to, rules[0][\"access_to\"])"},{"line_number":553,"context_line":"                    self.assertEqual("}],"source_content_type":"text/x-python","patch_set":10,"id":"b28d3064_4eb61e46","line":550,"range":{"start_line":549,"start_character":8,"end_line":550,"end_character":41},"in_reply_to":"15826673_370f788c","updated":"2024-01-29 22:44:20.000000000","message":"Ah, great! looks cleaner now. Thank you","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1682c1befa4e8764aad879ff53b4a2820722b302","unresolved":true,"context_lines":[{"line_number":528,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":529,"context_line":"    @ddt.data(True, False)"},{"line_number":530,"context_line":"    def test_list_restricted_rules_from_other_user(self, lock_visibility):"},{"line_number":531,"context_line":"        utils.check_skip_if_microversion_not_supported("},{"line_number":532,"context_line":"            RESTRICTED_RULES_VERSION)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        # create rule"},{"line_number":535,"context_line":"        rule \u003d self.allow_access("}],"source_content_type":"text/x-python","patch_set":11,"id":"cabb7c6f_6fe8d1df","line":532,"range":{"start_line":531,"start_character":0,"end_line":532,"end_character":37},"updated":"2024-03-07 06:33:41.000000000","message":"Can we use the decorator instead of skipping the test within the test ?\n@utils.skip_if_microversion_not_supported(RESTRICTED_RULES_VERSION)","commit_id":"579e609064398ba6a4a5ce72df69aa4ad98dab85"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bd020a170646d3c51e63e4b7b864b21b41c4ea52","unresolved":false,"context_lines":[{"line_number":528,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":529,"context_line":"    @ddt.data(True, False)"},{"line_number":530,"context_line":"    def test_list_restricted_rules_from_other_user(self, lock_visibility):"},{"line_number":531,"context_line":"        utils.check_skip_if_microversion_not_supported("},{"line_number":532,"context_line":"            RESTRICTED_RULES_VERSION)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        # create rule"},{"line_number":535,"context_line":"        rule \u003d self.allow_access("}],"source_content_type":"text/x-python","patch_set":11,"id":"6ab55c5b_8323e15e","line":532,"range":{"start_line":531,"start_character":0,"end_line":532,"end_character":37},"in_reply_to":"cabb7c6f_6fe8d1df","updated":"2024-03-12 17:09:21.000000000","message":"Done","commit_id":"579e609064398ba6a4a5ce72df69aa4ad98dab85"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1682c1befa4e8764aad879ff53b4a2820722b302","unresolved":true,"context_lines":[{"line_number":537,"context_line":"            access_type\u003dself.access_type, access_to\u003dself.access_to,"},{"line_number":538,"context_line":"            lock_visibility\u003dlock_visibility, lock_deletion\u003dTrue)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        rules \u003d self.new_user.shares_v2_client.list_access_rules("},{"line_number":541,"context_line":"            self.share[\u0027id\u0027])[\u0027access_list\u0027]"},{"line_number":542,"context_line":"        rules_get_lower_version \u003d ("},{"line_number":543,"context_line":"            self.new_user.shares_v2_client.list_access_rules("},{"line_number":544,"context_line":"                self.share[\u0027id\u0027], version\u003d\u00272.81\u0027)[\u0027access_list\u0027])"},{"line_number":545,"context_line":"        expected_access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":546,"context_line":"        expected_access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bb1b7b46_7d2e6684","line":544,"range":{"start_line":540,"start_character":0,"end_line":544,"end_character":65},"updated":"2024-03-07 06:33:41.000000000","message":"What do you think about adding version argument to ddt ?\n\n    @ddt.data(\n        *itertools.product(utils.deduplicate(\n            [\"2.81\", CONF.share.max_api_microversion]), (True, False))\n    )\n    @ddt.unpack","commit_id":"579e609064398ba6a4a5ce72df69aa4ad98dab85"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bd020a170646d3c51e63e4b7b864b21b41c4ea52","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            access_type\u003dself.access_type, access_to\u003dself.access_to,"},{"line_number":538,"context_line":"            lock_visibility\u003dlock_visibility, lock_deletion\u003dTrue)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        rules \u003d self.new_user.shares_v2_client.list_access_rules("},{"line_number":541,"context_line":"            self.share[\u0027id\u0027])[\u0027access_list\u0027]"},{"line_number":542,"context_line":"        rules_get_lower_version \u003d ("},{"line_number":543,"context_line":"            self.new_user.shares_v2_client.list_access_rules("},{"line_number":544,"context_line":"                self.share[\u0027id\u0027], version\u003d\u00272.81\u0027)[\u0027access_list\u0027])"},{"line_number":545,"context_line":"        expected_access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":546,"context_line":"        expected_access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"b1ac4b8b_213418a0","line":544,"range":{"start_line":540,"start_character":0,"end_line":544,"end_character":65},"in_reply_to":"bb1b7b46_7d2e6684","updated":"2024-03-12 17:09:21.000000000","message":"Done","commit_id":"579e609064398ba6a4a5ce72df69aa4ad98dab85"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"596ec07648c88e8939451cceb5f71508fbd11a21","unresolved":true,"context_lines":[{"line_number":543,"context_line":"            self.new_user.shares_v2_client.list_access_rules("},{"line_number":544,"context_line":"                self.share[\u0027id\u0027], version\u003d\u00272.81\u0027)[\u0027access_list\u0027])"},{"line_number":545,"context_line":"        expected_access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":546,"context_line":"        expected_access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        # verify values"},{"line_number":549,"context_line":"        rule_latest_rules_api \u003d [r for r in rules if r[\u0027id\u0027] \u003d\u003d rule[\u0027id\u0027]][0]"}],"source_content_type":"text/x-python","patch_set":11,"id":"c078ad8a_b24609b8","line":546,"range":{"start_line":546,"start_character":63,"end_line":546,"end_character":67},"updated":"2024-01-30 19:49:36.000000000","message":"do a get rule and get rule[\u0027access_key\u0027]","commit_id":"579e609064398ba6a4a5ce72df69aa4ad98dab85"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c14b7c6b90f29e827cacdd7fd6e4c69d6155dd0f","unresolved":true,"context_lines":[{"line_number":543,"context_line":"            self.new_user.shares_v2_client.list_access_rules("},{"line_number":544,"context_line":"                self.share[\u0027id\u0027], version\u003d\u00272.81\u0027)[\u0027access_list\u0027])"},{"line_number":545,"context_line":"        expected_access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":546,"context_line":"        expected_access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        # verify values"},{"line_number":549,"context_line":"        rule_latest_rules_api \u003d [r for r in rules if r[\u0027id\u0027] \u003d\u003d rule[\u0027id\u0027]][0]"}],"source_content_type":"text/x-python","patch_set":11,"id":"2578683c_f1589d13","line":546,"range":{"start_line":546,"start_character":30,"end_line":546,"end_character":67},"updated":"2024-01-30 19:49:48.000000000","message":"get rule after line 535 and set this to:\n\n\nrule[\u0027access_key\u0027]","commit_id":"579e609064398ba6a4a5ce72df69aa4ad98dab85"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bd020a170646d3c51e63e4b7b864b21b41c4ea52","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            self.new_user.shares_v2_client.list_access_rules("},{"line_number":544,"context_line":"                self.share[\u0027id\u0027], version\u003d\u00272.81\u0027)[\u0027access_list\u0027])"},{"line_number":545,"context_line":"        expected_access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":546,"context_line":"        expected_access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        # verify values"},{"line_number":549,"context_line":"        rule_latest_rules_api \u003d [r for r in rules if r[\u0027id\u0027] \u003d\u003d rule[\u0027id\u0027]][0]"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f767ef6_708dc7fd","line":546,"range":{"start_line":546,"start_character":30,"end_line":546,"end_character":67},"in_reply_to":"2578683c_f1589d13","updated":"2024-03-12 17:09:21.000000000","message":"Done","commit_id":"579e609064398ba6a4a5ce72df69aa4ad98dab85"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bd020a170646d3c51e63e4b7b864b21b41c4ea52","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            self.new_user.shares_v2_client.list_access_rules("},{"line_number":544,"context_line":"                self.share[\u0027id\u0027], version\u003d\u00272.81\u0027)[\u0027access_list\u0027])"},{"line_number":545,"context_line":"        expected_access_to \u003d \u0027******\u0027 if lock_visibility else self.access_to"},{"line_number":546,"context_line":"        expected_access_key \u003d \u0027******\u0027 if lock_visibility else None"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        # verify values"},{"line_number":549,"context_line":"        rule_latest_rules_api \u003d [r for r in rules if r[\u0027id\u0027] \u003d\u003d rule[\u0027id\u0027]][0]"}],"source_content_type":"text/x-python","patch_set":11,"id":"18ebf441_c33c6be9","line":546,"range":{"start_line":546,"start_character":63,"end_line":546,"end_character":67},"in_reply_to":"c078ad8a_b24609b8","updated":"2024-03-12 17:09:21.000000000","message":"Done","commit_id":"579e609064398ba6a4a5ce72df69aa4ad98dab85"}],"manila_tempest_tests/tests/api/test_rules_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33717bb98fd5dc4839215bcaf553bced2e4f18c2","unresolved":true,"context_lines":[{"line_number":227,"context_line":"            self.share[\u0027id\u0027],"},{"line_number":228,"context_line":"            rule[\u0027id\u0027],"},{"line_number":229,"context_line":"            version\u003d\u00272.81\u0027"},{"line_number":230,"context_line":"        )"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":6,"id":"673bbc97_e325bc74","line":230,"range":{"start_line":230,"start_character":7,"end_line":230,"end_character":9},"updated":"2023-08-23 23:23:47.000000000","message":"test suggestion:\n\na test that tries adding two visibility locks:\n\n1) user A creates a visibility lock\n2) same user tries to create a new visibility lock on the same rule (fails)\n3) new user tries to create a new visibility lock on the rule (fails)","commit_id":"783f67b475e04fac0b1bdd6f42809f6eac9752aa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c9d4c8c85f359362d8e91ad47c394bb9fef4634","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            self.share[\u0027id\u0027],"},{"line_number":228,"context_line":"            rule[\u0027id\u0027],"},{"line_number":229,"context_line":"            version\u003d\u00272.81\u0027"},{"line_number":230,"context_line":"        )"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":6,"id":"ed701b59_9dc0d483","line":230,"range":{"start_line":230,"start_character":7,"end_line":230,"end_character":9},"in_reply_to":"673bbc97_e325bc74","updated":"2023-08-24 21:29:32.000000000","message":"Done","commit_id":"783f67b475e04fac0b1bdd6f42809f6eac9752aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c10b48adac66a13c6e113bc5ef49c13ebf6c3260","unresolved":true,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    @decorators.idempotent_id(\u0027f5b9e7c9-7e6b-4918-a1c4-e03c8d82c46a\u0027)"},{"line_number":235,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":236,"context_line":"    def test_allow_access_multiple_visibility_locks(self):"},{"line_number":237,"context_line":"        utils.check_skip_if_microversion_not_supported("},{"line_number":238,"context_line":"            RESTRICTED_RULES_VERSION)"},{"line_number":239,"context_line":"        access_type, access_to \u003d utils.get_access_rule_data_from_config("}],"source_content_type":"text/x-python","patch_set":8,"id":"09767ad1_7c6428c8","line":236,"range":{"start_line":236,"start_character":8,"end_line":236,"end_character":51},"updated":"2023-09-12 22:08:35.000000000","message":"`test_allow_access_multiple_visibility_locks_not_allowed`\n\nperhaps?","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c5b9d400ed19e738fbf12407d436e366ad29d781","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    @decorators.idempotent_id(\u0027f5b9e7c9-7e6b-4918-a1c4-e03c8d82c46a\u0027)"},{"line_number":235,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":236,"context_line":"    def test_allow_access_multiple_visibility_locks(self):"},{"line_number":237,"context_line":"        utils.check_skip_if_microversion_not_supported("},{"line_number":238,"context_line":"            RESTRICTED_RULES_VERSION)"},{"line_number":239,"context_line":"        access_type, access_to \u003d utils.get_access_rule_data_from_config("}],"source_content_type":"text/x-python","patch_set":8,"id":"3320b978_7f213145","line":236,"range":{"start_line":236,"start_character":8,"end_line":236,"end_character":51},"in_reply_to":"09767ad1_7c6428c8","updated":"2023-09-29 15:03:03.000000000","message":"Done","commit_id":"b0c5d0b9f66149f4a7d34abd477d23a5b43f716e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"61013cdfd8da99358156434340aa33befea5ddf9","unresolved":true,"context_lines":[{"line_number":202,"context_line":"    @decorators.idempotent_id(\u0027c107b0b7-7a3e-4114-af64-ca8fe6e836c9\u0027)"},{"line_number":203,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":204,"context_line":"    @ddt.data(True, False)"},{"line_number":205,"context_line":"    def test_deny_access_without_unrestrict(self, same_user):"},{"line_number":206,"context_line":"        utils.check_skip_if_microversion_not_supported("},{"line_number":207,"context_line":"            RESTRICTED_RULES_VERSION)"},{"line_number":208,"context_line":"        access_type, access_to \u003d utils.get_access_rule_data_from_config("}],"source_content_type":"text/x-python","patch_set":10,"id":"62a8bb76_b6d6e33b","line":205,"updated":"2024-01-27 00:53:32.000000000","message":"the name here can include the parameter so its easier to catch the test case in the o/p:\n\n```\n test_deny_access_without_unrestrict_as_owner_user(self, same_user):\n```","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8cec91877c240c81ee05bef1daa63a951ebe059","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    @decorators.idempotent_id(\u0027c107b0b7-7a3e-4114-af64-ca8fe6e836c9\u0027)"},{"line_number":203,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":204,"context_line":"    @ddt.data(True, False)"},{"line_number":205,"context_line":"    def test_deny_access_without_unrestrict(self, same_user):"},{"line_number":206,"context_line":"        utils.check_skip_if_microversion_not_supported("},{"line_number":207,"context_line":"            RESTRICTED_RULES_VERSION)"},{"line_number":208,"context_line":"        access_type, access_to \u003d utils.get_access_rule_data_from_config("}],"source_content_type":"text/x-python","patch_set":10,"id":"c2653796_6c6a9c14","line":205,"in_reply_to":"62a8bb76_b6d6e33b","updated":"2024-01-29 22:44:20.000000000","message":"Done","commit_id":"129fd1cc40a1b5ee671b86d66945acbbc35c8dfe"}]}