)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"536e4c20cdc548e58b937826b467fa3b8f166304","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     agireesh \u003cgawasthi2010@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-17 14:57:32 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed Share server migration test related to CIFS."},{"line_number":8,"context_line":"Modify \"wait_for_resource_status\" method so that we can pass the timeout"},{"line_number":9,"context_line":"parameter from test cases and modify the test cases as per lib changes."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id67589bf2d2094355003a16e3379867ba81bfb6b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8e27ed69_ce8cb02c","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":71},"updated":"2023-10-17 22:25:18.000000000","message":"please see: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\non how to format your commit message","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"c11eaebfafd36e4932c156befc0c4793c993d931","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     agireesh \u003cgawasthi2010@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-17 14:57:32 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed Share server migration test related to CIFS."},{"line_number":8,"context_line":"Modify \"wait_for_resource_status\" method so that we can pass the timeout"},{"line_number":9,"context_line":"parameter from test cases and modify the test cases as per lib changes."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id67589bf2d2094355003a16e3379867ba81bfb6b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dd2cfe77_22fc7b5a","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":71},"in_reply_to":"8e27ed69_ce8cb02c","updated":"2023-10-18 08:17:22.000000000","message":"Thanks for sharing the wiki page, I made the changes as suggested in wiki.","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ffef3866675341e05dfe09e51222b4d364354c3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66c471cc_cace9f6e","updated":"2023-10-17 09:41:46.000000000","message":"Below is the test result for share server migration, test are passing when downstream patch trigger the run \nhttps://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/72/1772/2/downstream-share-server-migration/manila-tempest-plugin-ontap-dhss-migration/d8de65f/testr_results.html","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"536e4c20cdc548e58b937826b467fa3b8f166304","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"46e2287b_8270c3ef","updated":"2023-10-17 22:25:18.000000000","message":"Thanks Gireesh, some comments inline","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"f97500df180a39a78c4aa4dbd8ba585ecacaab23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3deee63e_c475302e","updated":"2023-10-17 13:03:37.000000000","message":"recheck","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48b050b3e359134911bd5eb41ebd3654e025aab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dcdc3402_f0d57e01","updated":"2023-10-19 04:17:55.000000000","message":"We\u0027ve a pending change that should be merged soon that fixes the failing RBAC tests.. https://review.opendev.org/c/openstack/manila-tempest-plugin/+/872260\n\nso zuul will -1 this until that patch merges","commit_id":"c699fca328537fb0f0371fea92afeaa514d5e2f1"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"62b9d714cbc1c4dfebe7be303ba8eaf6dc240cae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c3447ef9_c8632868","in_reply_to":"dcdc3402_f0d57e01","updated":"2023-10-19 16:06:28.000000000","message":"Thanks for this info","commit_id":"c699fca328537fb0f0371fea92afeaa514d5e2f1"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"4b58d85d61bedff1629703445919af5d1c0d1cb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bdf5e5cb_377c16c4","updated":"2023-10-26 05:41:19.000000000","message":"recheck","commit_id":"d1f98e05798ef80018dc3d24d00c610187fd38c5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"832fef5048cd23d63623207001884be1f76722fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19b4ff3a_267f67f3","updated":"2023-12-13 18:40:13.000000000","message":"LGTM, thanks for the fix!","commit_id":"541c6cd91deb1b10b203ebb0f2fe50686edcd131"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7d0463439f353e5b122b259986968707109af3fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"849709c6_50a752e6","updated":"2023-11-06 20:11:29.000000000","message":"Thanks Gireesh!","commit_id":"541c6cd91deb1b10b203ebb0f2fe50686edcd131"}],"manila_tempest_tests/common/waiters.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"536e4c20cdc548e58b937826b467fa3b8f166304","unresolved":true,"context_lines":[{"line_number":46,"context_line":"                             status_attr\u003d\u0027status\u0027,"},{"line_number":47,"context_line":"                             raise_rule_in_error_state\u003dTrue,"},{"line_number":48,"context_line":"                             version\u003dLATEST_MICROVERSION,"},{"line_number":49,"context_line":"                             time_out\u003dNone):"},{"line_number":50,"context_line":"    \"\"\"Waits for a resource to reach a given status.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    get_resource_action \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fcfa830c_463c17b6","line":49,"range":{"start_line":49,"start_character":29,"end_line":49,"end_character":42},"updated":"2023-10-17 22:25:18.000000000","message":"initialize with this default:\n\n`time_out\u003dclient.build_timeout`","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"62b9d714cbc1c4dfebe7be303ba8eaf6dc240cae","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                             status_attr\u003d\u0027status\u0027,"},{"line_number":47,"context_line":"                             raise_rule_in_error_state\u003dTrue,"},{"line_number":48,"context_line":"                             version\u003dLATEST_MICROVERSION,"},{"line_number":49,"context_line":"                             time_out\u003dNone):"},{"line_number":50,"context_line":"    \"\"\"Waits for a resource to reach a given status.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    get_resource_action \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"21e7ca70_5d6b00c6","line":49,"range":{"start_line":49,"start_character":29,"end_line":49,"end_character":42},"in_reply_to":"2aa268ea_4b6d6c21","updated":"2023-10-19 16:06:28.000000000","message":"done","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48b050b3e359134911bd5eb41ebd3654e025aab0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                             status_attr\u003d\u0027status\u0027,"},{"line_number":47,"context_line":"                             raise_rule_in_error_state\u003dTrue,"},{"line_number":48,"context_line":"                             version\u003dLATEST_MICROVERSION,"},{"line_number":49,"context_line":"                             time_out\u003dNone):"},{"line_number":50,"context_line":"    \"\"\"Waits for a resource to reach a given status.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    get_resource_action \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"2aa268ea_4b6d6c21","line":49,"range":{"start_line":49,"start_character":29,"end_line":49,"end_character":42},"in_reply_to":"e692fd21_172bb4e9","updated":"2023-10-19 04:17:55.000000000","message":"oh right; \n\nyou could leave timeout\u003dNone and this instead inside the method:\n\n```\n   timeout \u003d timeout or client.build_timeout\n```\n\n(please use \"timeout\" instead of \"time_out\" for consistency with the config opt names we have)","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3fba7651ffc529a3a60e3dacb087e633158e0aaa","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                             status_attr\u003d\u0027status\u0027,"},{"line_number":47,"context_line":"                             raise_rule_in_error_state\u003dTrue,"},{"line_number":48,"context_line":"                             version\u003dLATEST_MICROVERSION,"},{"line_number":49,"context_line":"                             time_out\u003dNone):"},{"line_number":50,"context_line":"    \"\"\"Waits for a resource to reach a given status.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    get_resource_action \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"e692fd21_172bb4e9","line":49,"range":{"start_line":49,"start_character":29,"end_line":49,"end_character":42},"in_reply_to":"fcfa830c_463c17b6","updated":"2023-10-18 08:14:06.000000000","message":"client is the first parameter we are passing in this function so if I am adding time_out\u003dclient.build_timeout, it is giving compilation error ( unresolved reference client )","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"536e4c20cdc548e58b937826b467fa3b8f166304","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    start \u003d int(time.time())"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    exp_status \u003d status if isinstance(status, list) else [status]"},{"line_number":90,"context_line":"    resource_status_check_time_out \u003d client.build_timeout"},{"line_number":91,"context_line":"    if time_out is not None:"},{"line_number":92,"context_line":"        resource_status_check_time_out \u003d time_out"},{"line_number":93,"context_line":"    while resource_status not in exp_status:"},{"line_number":94,"context_line":"        time.sleep(client.build_interval)"},{"line_number":95,"context_line":"        body \u003d resource_action(*method_args, **method_kwargs)[rn]"}],"source_content_type":"text/x-python","patch_set":1,"id":"e7282f7b_b4cc3434","line":92,"range":{"start_line":90,"start_character":0,"end_line":92,"end_character":49},"updated":"2023-10-17 22:25:18.000000000","message":"so that this isn\u0027t necessary","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3fba7651ffc529a3a60e3dacb087e633158e0aaa","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    start \u003d int(time.time())"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    exp_status \u003d status if isinstance(status, list) else [status]"},{"line_number":90,"context_line":"    resource_status_check_time_out \u003d client.build_timeout"},{"line_number":91,"context_line":"    if time_out is not None:"},{"line_number":92,"context_line":"        resource_status_check_time_out \u003d time_out"},{"line_number":93,"context_line":"    while resource_status not in exp_status:"},{"line_number":94,"context_line":"        time.sleep(client.build_interval)"},{"line_number":95,"context_line":"        body \u003d resource_action(*method_args, **method_kwargs)[rn]"}],"source_content_type":"text/x-python","patch_set":1,"id":"118092b9_aa209029","line":92,"range":{"start_line":90,"start_character":0,"end_line":92,"end_character":49},"in_reply_to":"e7282f7b_b4cc3434","updated":"2023-10-18 08:14:06.000000000","message":"it is require as we can not set time_out value as client.build_timeout as mention in previous comment.","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"536e4c20cdc548e58b937826b467fa3b8f166304","unresolved":true,"context_lines":[{"line_number":106,"context_line":"            raise_method \u003d _get_name_of_raise_method(resource_name)"},{"line_number":107,"context_line":"            resource_exception \u003d getattr(share_exceptions, raise_method)"},{"line_number":108,"context_line":"            raise resource_exception(resource_id\u003dresource_id)"},{"line_number":109,"context_line":"        if int(time.time()) - start \u003e\u003d resource_status_check_time_out:"},{"line_number":110,"context_line":"            message \u003d (\u0027%s %s failed to reach %s status (current %s) \u0027"},{"line_number":111,"context_line":"                       \u0027within the required time (%s s).\u0027 %"},{"line_number":112,"context_line":"                       (resource_name.replace(\u0027_\u0027, \u0027 \u0027), resource_id, status,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4600b45a_6ffdacc3","line":109,"range":{"start_line":109,"start_character":39,"end_line":109,"end_character":69},"updated":"2023-10-17 22:25:18.000000000","message":"when you make the above change, rename this to `timeout`, here and below","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3fba7651ffc529a3a60e3dacb087e633158e0aaa","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            raise_method \u003d _get_name_of_raise_method(resource_name)"},{"line_number":107,"context_line":"            resource_exception \u003d getattr(share_exceptions, raise_method)"},{"line_number":108,"context_line":"            raise resource_exception(resource_id\u003dresource_id)"},{"line_number":109,"context_line":"        if int(time.time()) - start \u003e\u003d resource_status_check_time_out:"},{"line_number":110,"context_line":"            message \u003d (\u0027%s %s failed to reach %s status (current %s) \u0027"},{"line_number":111,"context_line":"                       \u0027within the required time (%s s).\u0027 %"},{"line_number":112,"context_line":"                       (resource_name.replace(\u0027_\u0027, \u0027 \u0027), resource_id, status,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d5f73dd_18689ec7","line":109,"range":{"start_line":109,"start_character":39,"end_line":109,"end_character":69},"in_reply_to":"4600b45a_6ffdacc3","updated":"2023-10-18 08:14:06.000000000","message":"As mention in previous reply we can not set time_out as client.build_timeout, so this also not require to change.","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"}],"manila_tempest_tests/tests/api/admin/test_share_servers_migration.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48b050b3e359134911bd5eb41ebd3654e025aab0","unresolved":true,"context_lines":[{"line_number":282,"context_line":"            src_server_id, dest_host, preserve_snapshots\u003dpreserve_snapshots)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        expected_state \u003d constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE"},{"line_number":285,"context_line":"        time_out \u003d CONF.share.share_server_migration_timeout"},{"line_number":286,"context_line":"        waiters.wait_for_resource_status("},{"line_number":287,"context_line":"            self.shares_v2_client, src_server_id,"},{"line_number":288,"context_line":"            expected_state, resource_name\u003d\u0027share_server\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"25caff96_3585619d","line":285,"range":{"start_line":285,"start_character":8,"end_line":285,"end_character":16},"updated":"2023-10-19 04:17:55.000000000","message":"\"timeout\" for consistency","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"62b9d714cbc1c4dfebe7be303ba8eaf6dc240cae","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            src_server_id, dest_host, preserve_snapshots\u003dpreserve_snapshots)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        expected_state \u003d constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE"},{"line_number":285,"context_line":"        time_out \u003d CONF.share.share_server_migration_timeout"},{"line_number":286,"context_line":"        waiters.wait_for_resource_status("},{"line_number":287,"context_line":"            self.shares_v2_client, src_server_id,"},{"line_number":288,"context_line":"            expected_state, resource_name\u003d\u0027share_server\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"30e6e14b_568b0c6d","line":285,"range":{"start_line":285,"start_character":8,"end_line":285,"end_character":16},"in_reply_to":"25caff96_3585619d","updated":"2023-10-19 16:06:28.000000000","message":"Done","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"62b9d714cbc1c4dfebe7be303ba8eaf6dc240cae","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            src_server_id, dest_host, preserve_snapshots\u003dpreserve_snapshots)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        expected_state \u003d constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE"},{"line_number":285,"context_line":"        time_out \u003d CONF.share.share_server_migration_timeout"},{"line_number":286,"context_line":"        waiters.wait_for_resource_status("},{"line_number":287,"context_line":"            self.shares_v2_client, src_server_id,"},{"line_number":288,"context_line":"            expected_state, resource_name\u003d\u0027share_server\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"17c3b47a_007a8e58","line":285,"range":{"start_line":285,"start_character":8,"end_line":285,"end_character":16},"in_reply_to":"25caff96_3585619d","updated":"2023-10-19 16:06:28.000000000","message":"done","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"536e4c20cdc548e58b937826b467fa3b8f166304","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        ss_configs \u003d CONF.share.security_service"},{"line_number":206,"context_line":"        if not ss_configs:"},{"line_number":207,"context_line":"            return"},{"line_number":208,"context_line":"        # if security service already associated with share network"},{"line_number":209,"context_line":"        # then don\u0027t create the new security service"},{"line_number":210,"context_line":"        ss_list \u003d shares_client.list_sec_services_for_share_network("},{"line_number":211,"context_line":"            share_network_id)[\u0027security_services\u0027]"},{"line_number":212,"context_line":"        if len(ss_list) !\u003d 0:"},{"line_number":213,"context_line":"            return"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        for ss_config in ss_configs:"},{"line_number":216,"context_line":"            ss_name \u003d \"ss_autogenerated_by_tempest_%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"ce086938_ff7aa0e1","line":213,"range":{"start_line":208,"start_character":8,"end_line":213,"end_character":18},"updated":"2023-10-17 22:25:18.000000000","message":"is this part of the same bugfix? or a different bug?","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"5de288795d3a41113f927a004122a066d3883291","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        ss_configs \u003d CONF.share.security_service"},{"line_number":206,"context_line":"        if not ss_configs:"},{"line_number":207,"context_line":"            return"},{"line_number":208,"context_line":"        # if security service already associated with share network"},{"line_number":209,"context_line":"        # then don\u0027t create the new security service"},{"line_number":210,"context_line":"        ss_list \u003d shares_client.list_sec_services_for_share_network("},{"line_number":211,"context_line":"            share_network_id)[\u0027security_services\u0027]"},{"line_number":212,"context_line":"        if len(ss_list) !\u003d 0:"},{"line_number":213,"context_line":"            return"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        for ss_config in ss_configs:"},{"line_number":216,"context_line":"            ss_name \u003d \"ss_autogenerated_by_tempest_%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"aa198cf5_fdfabfa7","line":213,"range":{"start_line":208,"start_character":8,"end_line":213,"end_character":18},"in_reply_to":"0c0b42ef_c9dc326c","updated":"2023-11-06 16:30:32.000000000","message":"As discussed over the chat that this code is not require as of now, so I reverted the changes","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"63a3433dc3b41be0b241a93229298b7279759514","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        ss_configs \u003d CONF.share.security_service"},{"line_number":206,"context_line":"        if not ss_configs:"},{"line_number":207,"context_line":"            return"},{"line_number":208,"context_line":"        # if security service already associated with share network"},{"line_number":209,"context_line":"        # then don\u0027t create the new security service"},{"line_number":210,"context_line":"        ss_list \u003d shares_client.list_sec_services_for_share_network("},{"line_number":211,"context_line":"            share_network_id)[\u0027security_services\u0027]"},{"line_number":212,"context_line":"        if len(ss_list) !\u003d 0:"},{"line_number":213,"context_line":"            return"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        for ss_config in ss_configs:"},{"line_number":216,"context_line":"            ss_name \u003d \"ss_autogenerated_by_tempest_%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"58326e30_0207d8b0","line":213,"range":{"start_line":208,"start_character":8,"end_line":213,"end_character":18},"in_reply_to":"1d2ba8c2_4e3dd858","updated":"2023-10-27 23:13:23.000000000","message":"Thanks for adding this; can you show me / link me to the line where this is being invoked from, and failing?","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"224a87de1f101d07738be8e03d9e733420321215","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        ss_configs \u003d CONF.share.security_service"},{"line_number":206,"context_line":"        if not ss_configs:"},{"line_number":207,"context_line":"            return"},{"line_number":208,"context_line":"        # if security service already associated with share network"},{"line_number":209,"context_line":"        # then don\u0027t create the new security service"},{"line_number":210,"context_line":"        ss_list \u003d shares_client.list_sec_services_for_share_network("},{"line_number":211,"context_line":"            share_network_id)[\u0027security_services\u0027]"},{"line_number":212,"context_line":"        if len(ss_list) !\u003d 0:"},{"line_number":213,"context_line":"            return"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        for ss_config in ss_configs:"},{"line_number":216,"context_line":"            ss_name \u003d \"ss_autogenerated_by_tempest_%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"0c0b42ef_c9dc326c","line":213,"range":{"start_line":208,"start_character":8,"end_line":213,"end_character":18},"in_reply_to":"276e6e25_1b6d3d7e","updated":"2023-11-03 06:32:43.000000000","message":"Yes \"provide_and_associate_security_services\" will be invoked based on value of add_security_services and default value of this variable is \"True\". Even from setup and test case we are not overbidding this value, so most of the time this optional code will be executed.","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ddbb24650d5d436d1a78ab81badc95e956456127","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        ss_configs \u003d CONF.share.security_service"},{"line_number":206,"context_line":"        if not ss_configs:"},{"line_number":207,"context_line":"            return"},{"line_number":208,"context_line":"        # if security service already associated with share network"},{"line_number":209,"context_line":"        # then don\u0027t create the new security service"},{"line_number":210,"context_line":"        ss_list \u003d shares_client.list_sec_services_for_share_network("},{"line_number":211,"context_line":"            share_network_id)[\u0027security_services\u0027]"},{"line_number":212,"context_line":"        if len(ss_list) !\u003d 0:"},{"line_number":213,"context_line":"            return"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        for ss_config in ss_configs:"},{"line_number":216,"context_line":"            ss_name \u003d \"ss_autogenerated_by_tempest_%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"8e0cdfb4_b826d527","line":213,"range":{"start_line":208,"start_character":8,"end_line":213,"end_character":18},"in_reply_to":"58326e30_0207d8b0","updated":"2023-10-30 09:59:14.000000000","message":"Hi Goutham, just wanted to correct myself here. Even we remove this check non of the test will failed. Initially, CIFS related tests were failing in our environment due to security service was not associated with share network. I have added \"security_service\" parameter in out tempest file and added the code in my test to associate the security service to share network, but it failed with error \"security services already associated with share network\", then I have added this code in lib. Later (after playing with code) I realize that we are creating the share network and adding the security service to share network as part of test setup. I remove the code from my test but I keep the code in lib which return if security service is already associated with share network.\n\nIf you want I can remove this code but I feel adding this validation is good as we can add only one security service to share network (plz correct me if I am wrong here) and if it is already exist then return once condition meet. As of now non of the test case might hit this but in future we can hit this kind of issue.","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"76e9bbc0115a48b253799f3bca9f396014f1eaf5","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        ss_configs \u003d CONF.share.security_service"},{"line_number":206,"context_line":"        if not ss_configs:"},{"line_number":207,"context_line":"            return"},{"line_number":208,"context_line":"        # if security service already associated with share network"},{"line_number":209,"context_line":"        # then don\u0027t create the new security service"},{"line_number":210,"context_line":"        ss_list \u003d shares_client.list_sec_services_for_share_network("},{"line_number":211,"context_line":"            share_network_id)[\u0027security_services\u0027]"},{"line_number":212,"context_line":"        if len(ss_list) !\u003d 0:"},{"line_number":213,"context_line":"            return"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        for ss_config in ss_configs:"},{"line_number":216,"context_line":"            ss_name \u003d \"ss_autogenerated_by_tempest_%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"276e6e25_1b6d3d7e","line":213,"range":{"start_line":208,"start_character":8,"end_line":213,"end_character":18},"in_reply_to":"8e0cdfb4_b826d527","updated":"2023-10-31 22:25:52.000000000","message":"Hi Gireesh, \n\n\n\u0027provide_and_associate_security_services\u0027 is meant to be invoked optionally: \nhttps://opendev.org/openstack/manila-tempest-plugin/src/commit/4a2f09514f39927a4deb1b3060dd9312037d09e1/manila_tempest_tests/tests/api/base.py#L747\n\nso, if you have a use case where there\u0027s no need to add security services, you just wouldn\u0027t call it.","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3fba7651ffc529a3a60e3dacb087e633158e0aaa","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        ss_configs \u003d CONF.share.security_service"},{"line_number":206,"context_line":"        if not ss_configs:"},{"line_number":207,"context_line":"            return"},{"line_number":208,"context_line":"        # if security service already associated with share network"},{"line_number":209,"context_line":"        # then don\u0027t create the new security service"},{"line_number":210,"context_line":"        ss_list \u003d shares_client.list_sec_services_for_share_network("},{"line_number":211,"context_line":"            share_network_id)[\u0027security_services\u0027]"},{"line_number":212,"context_line":"        if len(ss_list) !\u003d 0:"},{"line_number":213,"context_line":"            return"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        for ss_config in ss_configs:"},{"line_number":216,"context_line":"            ss_name \u003d \"ss_autogenerated_by_tempest_%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1d2ba8c2_4e3dd858","line":213,"range":{"start_line":208,"start_character":8,"end_line":213,"end_character":18},"in_reply_to":"ce086938_ff7aa0e1","updated":"2023-10-18 08:14:06.000000000","message":"Yes this is part of same bug. For cifs test we create the share network, security services and then associate the security services to share network.Adding this to make sure if share network already associated with security service and if we are calling \"provide_and_associate_security_services\" method out test should not failed.","commit_id":"ba3acbfc1109eb3b957437d6c8c943c2675072e2"}]}