)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0b803dd143ab1fa56cd2ce4d94e1e1ac6819a05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e285a6b_7e47043d","updated":"2024-04-12 00:14:01.000000000","message":"Thanks Gireesh; see my comments inline","commit_id":"2fb8965ab1e5eca2b3c2f9373c110f5d29e6290b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"687395bb36cf7ea049a052060a80aac66b020128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d99d2592_47780b78","updated":"2024-04-05 08:45:35.000000000","message":"recheck","commit_id":"2fb8965ab1e5eca2b3c2f9373c110f5d29e6290b"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"2b810836a9f997da7ed8f6241ffc4d1b8585176f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"837ebe34_257afccd","updated":"2024-04-10 06:18:04.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fb8965ab1e5eca2b3c2f9373c110f5d29e6290b"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0b803dd143ab1fa56cd2ce4d94e1e1ac6819a05","unresolved":true,"context_lines":[{"line_number":150,"context_line":"                     \"capability filter will request this capability in all \""},{"line_number":151,"context_line":"                     \"share types and the the capacity filter will allow \""},{"line_number":152,"context_line":"                     \"oversubscription.\"),"},{"line_number":153,"context_line":"    cfg.BoolOpt(\"capability_mount_snapshot_support\","},{"line_number":154,"context_line":"                default\u003dFalse,"},{"line_number":155,"context_line":"                help\u003d\"Backend capability to directly mounting a manila\""},{"line_number":156,"context_line":"                     \" snapshot in read-only mode. For some vendor, driver\""},{"line_number":157,"context_line":"                     \" support creating share from snapshot and mount it.\"),"},{"line_number":158,"context_line":"    cfg.StrOpt(\"share_network_id\","},{"line_number":159,"context_line":"               default\u003d\"\","},{"line_number":160,"context_line":"               help\u003d\"Some backend drivers requires share network \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3099660f_e2948ae3","line":157,"range":{"start_line":153,"start_character":0,"end_line":157,"end_character":76},"updated":"2024-04-12 00:14:01.000000000","message":"this isn\u0027t necessary; we are using \"run_mount_snapshot_tests\" for this reason (see line 286). \n\nIt may be confusing why we have two sets of options in some cases, like:\n\n\"capability_snapshot_support\" and \"run_snapshot_tests\"\n\nthis is for historic reasons - a long time ago, snapshots were mandatory features that share drivers had to support. So when we made them optional, we wanted a way to distinguish scheduling shares to drivers with a particular value for the \"snapshot_support\" capability; and allow tempest a way to skip snapshot tests altogether if necessary. Over time we realized this is super confusing, and unnecessary. \n\nLiron Kuchlani\u0027s refactoring all of these \"capability_xxx\" and \"run_xxx_tests\" options to be consistent with how the rest of tempest works: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/786177","commit_id":"2fb8965ab1e5eca2b3c2f9373c110f5d29e6290b"}],"manila_tempest_tests/tests/api/test_backup.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0b803dd143ab1fa56cd2ce4d94e1e1ac6819a05","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(ShareBackupTest, self).setUp()"},{"line_number":43,"context_line":"        extra_specs \u003d {"},{"line_number":44,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":45,"context_line":"            \u0027mount_snapshot_support\u0027: True,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"        share_type \u003d self.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":48,"context_line":"        share \u003d self.create_share(self.shares_v2_client.share_protocol,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a62be64e_2334dba1","side":"PARENT","line":45,"range":{"start_line":44,"start_character":37,"end_line":45,"end_character":43},"updated":"2024-04-12 00:14:01.000000000","message":"actually; having either of these extra-specs here is super weird. I don\u0027t see how they relate to backup tests; i.e., we must only enable capabilities we are testing.. Manila won\u0027t enable snapshots (or any otehr capability) on share types unless you explicitly ask for it... I don\u0027t see any snapshot tests below. \n\nIf you just drop this dict altogether, you\u0027ll be fine..","commit_id":"1687dd6ef680d13205c9cfb99396752f864987c6"}]}