)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"908e7165d5545ccd923e81a4871a386f8a9636ab","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-06-11 01:57:40 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"additional configuration options for scenario tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0f3e88d4322fecc83721e1e192e14d617281a3ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"0a807014_56ab1a5b","line":8,"updated":"2024-06-11 00:15:02.000000000","message":"Copying over an IRC conversation with edits to provide some more context to reviewers:\n\n[02:15:33 PM]  \u003cfnn45\u003e Hi gouthamr. ... We have some limitations in our system and we wold like to discuss them. I prepared mr which can help https://review.opendev.org/c/openstack/manila-tempest-plugin/+/921419. \n[02:18:15 PM]  \u003cgouthamr\u003e are all these related to the same limitation?\n[02:18:41 PM]  \u003cgouthamr\u003e all these \u003d the three settings you\u0027re tuning with config opts\n[02:21:39 PM]  \u003cfnn45\u003e Yes. Vast storage has async nature regarding to propagating capacity limits. We never bother about this because customers usually dont care if the\u0027re able to write lets say 0.5 - 1 GB more the allowed limit. But here we faced issues\n[02:27:16 PM]  \u003cgouthamr\u003e yes; that was going to be my next question \n[02:27:26 PM]  \u003cgouthamr\u003e how big of a skew is it\n[02:27:48 PM]  \u003cgouthamr\u003e if its a small/negligible percentage over the quota assigned to the user, its okay. these scenario tests are expected to enforce expectations of consistency.. i have a couple of further questions, that i can take to the patch\n[02:30:09 PM]  \u003cgouthamr\u003e and your responses there will allow us to engage other reviewers\n[02:33:39 PM]  \u003cfnn45\u003e I\u0027d underline 2 separate issues here. First: user can write more data then share capacity. How big is this overhead? For small shares (1 GB for instance) it can be around half of share iow 0.5 GB before hitting an error. For bigger shares this limit is smaller. Second issue is also about capacity propagation. After changing share capacity there is some time (up to 10 seconds) where this new limit is \n[02:33:39 PM]  \u003cfnn45\u003e invisible by vast cluster. To address these two issues I introduces additional parameters. One of them is additional blocks (64mb) to write. Second one is sleep between write operations/extend-shrink operation to make sure changes were applied properly\n[02:34:37 PM]  \u003cgouthamr\u003e thanks for sharing this context","commit_id":"732418cde54c31f36a8e33a56b1d467de45b312a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0c28d78b86245bc728e4ac004953830119d0fa93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2b6e3c6f_4a885da2","updated":"2024-07-15 21:55:54.000000000","message":"@lkuchlan@redhat.com @vhariria@redhat.com - wdyt about this?","commit_id":"732418cde54c31f36a8e33a56b1d467de45b312a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ac4431aa82b9d22e136e669e068cae004298dc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"52ccab98_abb1f679","updated":"2024-07-16 23:48:51.000000000","message":"LGTM; thank you!","commit_id":"caf8b9025c086f588d1d9340d4bc8cbbab92e868"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"cac9096dce7353b193e7a28f7d81a90473cd65db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dd90805a_ffcbaff1","updated":"2024-07-18 22:03:04.000000000","message":"Looks good.","commit_id":"caf8b9025c086f588d1d9340d4bc8cbbab92e868"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0c28d78b86245bc728e4ac004953830119d0fa93","unresolved":true,"context_lines":[{"line_number":341,"context_line":"    cfg.IntOpt(\"share_resize_sync_delay\","},{"line_number":342,"context_line":"               default\u003d0,"},{"line_number":343,"context_line":"               help\u003d\"Time to wait before the changes to the share size\""},{"line_number":344,"context_line":"                    \" are propagated to the third-party system.\"),"},{"line_number":345,"context_line":"    cfg.IntOpt(\"share_growth\","},{"line_number":346,"context_line":"               default\u003d1,"},{"line_number":347,"context_line":"               help\u003d\"Default growth size in GB for shares.\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"19550134_4d008b7d","line":344,"range":{"start_line":344,"start_character":44,"end_line":344,"end_character":55},"updated":"2024-07-15 21:55:54.000000000","message":"storage","commit_id":"732418cde54c31f36a8e33a56b1d467de45b312a"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"360762a49e7480da5865925440e3824132ff1dd0","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    cfg.IntOpt(\"share_resize_sync_delay\","},{"line_number":342,"context_line":"               default\u003d0,"},{"line_number":343,"context_line":"               help\u003d\"Time to wait before the changes to the share size\""},{"line_number":344,"context_line":"                    \" are propagated to the third-party system.\"),"},{"line_number":345,"context_line":"    cfg.IntOpt(\"share_growth\","},{"line_number":346,"context_line":"               default\u003d1,"},{"line_number":347,"context_line":"               help\u003d\"Default growth size in GB for shares.\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"1d2ff29c_b8707ec9","line":344,"range":{"start_line":344,"start_character":44,"end_line":344,"end_character":55},"in_reply_to":"19550134_4d008b7d","updated":"2024-07-16 23:45:10.000000000","message":"Done","commit_id":"732418cde54c31f36a8e33a56b1d467de45b312a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0c28d78b86245bc728e4ac004953830119d0fa93","unresolved":true,"context_lines":[{"line_number":342,"context_line":"               default\u003d0,"},{"line_number":343,"context_line":"               help\u003d\"Time to wait before the changes to the share size\""},{"line_number":344,"context_line":"                    \" are propagated to the third-party system.\"),"},{"line_number":345,"context_line":"    cfg.IntOpt(\"share_growth\","},{"line_number":346,"context_line":"               default\u003d1,"},{"line_number":347,"context_line":"               help\u003d\"Default growth size in GB for shares.\"),"},{"line_number":348,"context_line":"    cfg.BoolOpt(\"run_ipv6_tests\","}],"source_content_type":"text/x-python","patch_set":6,"id":"51107ebd_e45dd447","line":345,"range":{"start_line":345,"start_character":16,"end_line":345,"end_character":28},"updated":"2024-07-15 21:55:54.000000000","message":"i\u0027d suggest using \"share_extend_size\" or \"share_growth_size\" to match the option on line 334.","commit_id":"732418cde54c31f36a8e33a56b1d467de45b312a"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"360762a49e7480da5865925440e3824132ff1dd0","unresolved":false,"context_lines":[{"line_number":342,"context_line":"               default\u003d0,"},{"line_number":343,"context_line":"               help\u003d\"Time to wait before the changes to the share size\""},{"line_number":344,"context_line":"                    \" are propagated to the third-party system.\"),"},{"line_number":345,"context_line":"    cfg.IntOpt(\"share_growth\","},{"line_number":346,"context_line":"               default\u003d1,"},{"line_number":347,"context_line":"               help\u003d\"Default growth size in GB for shares.\"),"},{"line_number":348,"context_line":"    cfg.BoolOpt(\"run_ipv6_tests\","}],"source_content_type":"text/x-python","patch_set":6,"id":"65ca762e_ead124a2","line":345,"range":{"start_line":345,"start_character":16,"end_line":345,"end_character":28},"in_reply_to":"51107ebd_e45dd447","updated":"2024-07-16 23:45:10.000000000","message":"Done","commit_id":"732418cde54c31f36a8e33a56b1d467de45b312a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0c28d78b86245bc728e4ac004953830119d0fa93","unresolved":true,"context_lines":[{"line_number":344,"context_line":"                    \" are propagated to the third-party system.\"),"},{"line_number":345,"context_line":"    cfg.IntOpt(\"share_growth\","},{"line_number":346,"context_line":"               default\u003d1,"},{"line_number":347,"context_line":"               help\u003d\"Default growth size in GB for shares.\"),"},{"line_number":348,"context_line":"    cfg.BoolOpt(\"run_ipv6_tests\","},{"line_number":349,"context_line":"                default\u003dFalse,"},{"line_number":350,"context_line":"                help\u003d\"Enable or disable running IPv6 NFS scenario tests. \""}],"source_content_type":"text/x-python","patch_set":6,"id":"7880bf2a_760b6ef9","line":347,"range":{"start_line":347,"start_character":21,"end_line":347,"end_character":58},"updated":"2024-07-15 21:55:54.000000000","message":"The default increase in size sought by tests when validating share resizing within scenario tests.","commit_id":"732418cde54c31f36a8e33a56b1d467de45b312a"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"360762a49e7480da5865925440e3824132ff1dd0","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                    \" are propagated to the third-party system.\"),"},{"line_number":345,"context_line":"    cfg.IntOpt(\"share_growth\","},{"line_number":346,"context_line":"               default\u003d1,"},{"line_number":347,"context_line":"               help\u003d\"Default growth size in GB for shares.\"),"},{"line_number":348,"context_line":"    cfg.BoolOpt(\"run_ipv6_tests\","},{"line_number":349,"context_line":"                default\u003dFalse,"},{"line_number":350,"context_line":"                help\u003d\"Enable or disable running IPv6 NFS scenario tests. \""}],"source_content_type":"text/x-python","patch_set":6,"id":"d362860a_cde7c99f","line":347,"range":{"start_line":347,"start_character":21,"end_line":347,"end_character":58},"in_reply_to":"7880bf2a_760b6ef9","updated":"2024-07-16 23:45:10.000000000","message":"Done","commit_id":"732418cde54c31f36a8e33a56b1d467de45b312a"}]}