)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fae8c7d142be297651a4d6fa6ce2b88dba1b1159","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6e0151d2_87a2f8e7","updated":"2024-06-17 14:40:16.000000000","message":"Adding my own -1 and making this WIP so that we can hash out how to go about this.","commit_id":"9c853b59093f00ae3a5df2abca6e675108a344cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ad54973324e0f9418b7d909e8bd47745aa681f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ddf360a_dd91ee0c","updated":"2025-04-08 21:51:50.000000000","message":"@ces.eduardo98@gmail.com ty for refreshing this change. PTAL at the comment inline","commit_id":"5c196fc8af8d473be4cc289ecb0c7690a51b50ae"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"35dc970462c28f64b4558eceab6213e921749401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7b38813_e06c87e9","updated":"2025-04-04 11:13:09.000000000","message":"recheck\nUnrelated access rule issue in the dummy DHSS driver","commit_id":"5c196fc8af8d473be4cc289ecb0c7690a51b50ae"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0a90d6da487bc50c7f9daa44a8d034b0381cde30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"48748c44_dec63fd5","updated":"2025-04-16 19:33:22.000000000","message":"thanks for the review, PTAL","commit_id":"04e9e0f95bd4741ce78144460aac500356892bbe"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"ca3dfbdfef03f9b31c8fb4d76fdc0e51e1959432","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"62c6c4d5_09a75d13","updated":"2025-04-17 07:54:40.000000000","message":"Looks good, thanks for the change. Minor comment/question inline.","commit_id":"95fddb0e9fc044fecc5244d9ab90db95997e318b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6696b2c9d9402df6122533c19cd7db2a9dd43cdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0049c68e_b2a14b34","updated":"2025-04-17 13:01:41.000000000","message":"thanks for the review, PTAL","commit_id":"95fddb0e9fc044fecc5244d9ab90db95997e318b"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"8f5a94174ad286f3bb987b0b00d2bfbf0ac9d64c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"807bc6c8_48dbb8e7","updated":"2025-04-17 21:54:39.000000000","message":"LGTM, thanks.","commit_id":"94c11fc8800720d87294283f25553113c6c7e4df"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d62592b1e88db2e168fc2bbae768f2a12ee93820","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"491c688e_f58daccf","updated":"2025-05-30 00:09:51.000000000","message":"Thanks for refreshing this Carlos!","commit_id":"94c11fc8800720d87294283f25553113c6c7e4df"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"410eecad9c9f33afc9260c22d4925bdf8ed80ced","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"29a741d5_a2683430","updated":"2025-05-30 05:10:22.000000000","message":"recheck","commit_id":"94c11fc8800720d87294283f25553113c6c7e4df"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5e5f24905e3d8f380e63467935df29ce61632b91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f9064402_03d3dcd6","updated":"2025-05-30 18:19:49.000000000","message":"recheck\n\nSSH to nova VM failed in one of the tests, unrelated","commit_id":"94c11fc8800720d87294283f25553113c6c7e4df"}],"manila_tempest_tests/tests/api/test_metadata.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"21a66bbcf9d4b5ad615a305fb77713e7be11fc3b","unresolved":true,"context_lines":[{"line_number":268,"context_line":"        self.assertEqual(max_value, body_get[\"key\"])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"class SharesMetadataCEPHFSTest(SharesMetadataTest):"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":274,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c7e5d84_a8f6e7c0","line":271,"range":{"start_line":271,"start_character":0,"end_line":271,"end_character":51},"updated":"2024-06-17 14:39:29.000000000","message":"we might or might not need this class, but I think this was consistent to other tests we have implemented. The only issue now (that I am checking on CI currently) is that the tests might get duplicated and I\u0027ll have to deal with it.","commit_id":"9c853b59093f00ae3a5df2abca6e675108a344cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ad54973324e0f9418b7d909e8bd47745aa681f5","unresolved":true,"context_lines":[{"line_number":268,"context_line":"        self.assertEqual(max_value, body_get[\"key\"])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"class SharesMetadataCEPHFSTest(SharesMetadataTest):"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":274,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fc59b25_647ea86e","line":271,"range":{"start_line":271,"start_character":0,"end_line":271,"end_character":51},"in_reply_to":"3c7e5d84_a8f6e7c0","updated":"2025-04-08 21:51:50.000000000","message":"Yes, why are we inheriting/extending SharesMetadataTest? Doing this will cause all tests under SharesMetadataTest to be inherited into this class as well. \n\n\nIf you do want a separate class, I suggest parenting to the appropriate base class, and if needed create new resources within the test (or test class)","commit_id":"9c853b59093f00ae3a5df2abca6e675108a344cd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0a90d6da487bc50c7f9daa44a8d034b0381cde30","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.assertEqual(max_value, body_get[\"key\"])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"class SharesMetadataCEPHFSTest(SharesMetadataTest):"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":274,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"b826a1d8_7e9cf3d4","line":271,"range":{"start_line":271,"start_character":0,"end_line":271,"end_character":51},"in_reply_to":"3fc59b25_647ea86e","updated":"2025-04-16 19:33:22.000000000","message":"Ack, thank you! will keep the class but base it on the parent.","commit_id":"9c853b59093f00ae3a5df2abca6e675108a344cd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"21a66bbcf9d4b5ad615a305fb77713e7be11fc3b","unresolved":true,"context_lines":[{"line_number":278,"context_line":"            msg \u003d ("},{"line_number":279,"context_line":"                \"CEPH filesystem metadata tests are disabled \""},{"line_number":280,"context_line":"                \"for the %s protocol.\" % cls.protocol)"},{"line_number":281,"context_line":"            raise cls.skipException(msg)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def test_cephfs_share_contains_mount_option(self):"},{"line_number":284,"context_line":"        body_get \u003d self.shares_v2_client.get_metadata("}],"source_content_type":"text/x-python","patch_set":1,"id":"6021a26c_769f0920","line":281,"updated":"2024-06-17 14:39:29.000000000","message":"There are a couple of issues with this test, and I believe we should skip it more times, as manila-tempest-plugin is branchless.\n\nInitially I thought about adding a skip check based on the microversion that is configured, but this would not be ideal, as we would only be able to run this test on 2024.1 (and newer branches), but we have serious intentions of backporting this RFE to older branches. This would have a bad side effect of the share not being able to run the test on the older branches that we backport.\n\nDo you have any bright ideas? I thought about introducing another config option like (run_cephfs_filesystem_name_metadata_tests), but sounds a bit like overkill, as we have a single test.","commit_id":"9c853b59093f00ae3a5df2abca6e675108a344cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ad54973324e0f9418b7d909e8bd47745aa681f5","unresolved":true,"context_lines":[{"line_number":278,"context_line":"            msg \u003d ("},{"line_number":279,"context_line":"                \"CEPH filesystem metadata tests are disabled \""},{"line_number":280,"context_line":"                \"for the %s protocol.\" % cls.protocol)"},{"line_number":281,"context_line":"            raise cls.skipException(msg)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def test_cephfs_share_contains_mount_option(self):"},{"line_number":284,"context_line":"        body_get \u003d self.shares_v2_client.get_metadata("}],"source_content_type":"text/x-python","patch_set":1,"id":"a6804121_13fa54c9","line":281,"in_reply_to":"0854478f_3530c416","updated":"2025-04-08 21:51:50.000000000","message":"Time has made this concern irrelevant. Since CephFS fsname metadata was backported to older branches, including stable/2023.2, this test can now be safely merged.. \n\nthe code change exists in unmaintained/2023.1, but, we\u0027ve pinned the version of manila-tempest-plugin used against that branch, so this test will never be run there.","commit_id":"9c853b59093f00ae3a5df2abca6e675108a344cd"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e929a48b79c26a557b1afc7d377a302c40bef5e6","unresolved":true,"context_lines":[{"line_number":278,"context_line":"            msg \u003d ("},{"line_number":279,"context_line":"                \"CEPH filesystem metadata tests are disabled \""},{"line_number":280,"context_line":"                \"for the %s protocol.\" % cls.protocol)"},{"line_number":281,"context_line":"            raise cls.skipException(msg)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def test_cephfs_share_contains_mount_option(self):"},{"line_number":284,"context_line":"        body_get \u003d self.shares_v2_client.get_metadata("}],"source_content_type":"text/x-python","patch_set":1,"id":"64443708_9bcbe4ed","line":281,"in_reply_to":"6021a26c_769f0920","updated":"2024-06-18 07:47:02.000000000","message":"I think we can skip the test based on the microversion and add a TODO comment to update the skip check according to the backporting.","commit_id":"9c853b59093f00ae3a5df2abca6e675108a344cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2203066fe5d70d004e2709f8558d559e3b224ad3","unresolved":true,"context_lines":[{"line_number":278,"context_line":"            msg \u003d ("},{"line_number":279,"context_line":"                \"CEPH filesystem metadata tests are disabled \""},{"line_number":280,"context_line":"                \"for the %s protocol.\" % cls.protocol)"},{"line_number":281,"context_line":"            raise cls.skipException(msg)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def test_cephfs_share_contains_mount_option(self):"},{"line_number":284,"context_line":"        body_get \u003d self.shares_v2_client.get_metadata("}],"source_content_type":"text/x-python","patch_set":1,"id":"0854478f_3530c416","line":281,"in_reply_to":"64443708_9bcbe4ed","updated":"2024-06-27 23:37:53.000000000","message":"This is indeed tricky since the driver change isn\u0027t exactly parallel to any API microversion.. Even if we backport the change, just testing the max API microversion of a release wouldn\u0027t be correct; because someone may never upgrade manila to include the backport, but when they use the latest version of tempest, the test being added would fail. \n\nI\u0027d suggest the config option even if it looks clunky. I would really like to get Liron\u0027s refactor in though before we add any more boolean options: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/786177 \n\nMaybe we can prioritize its review and review this right after?","commit_id":"9c853b59093f00ae3a5df2abca6e675108a344cd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0a90d6da487bc50c7f9daa44a8d034b0381cde30","unresolved":false,"context_lines":[{"line_number":278,"context_line":"            msg \u003d ("},{"line_number":279,"context_line":"                \"CEPH filesystem metadata tests are disabled \""},{"line_number":280,"context_line":"                \"for the %s protocol.\" % cls.protocol)"},{"line_number":281,"context_line":"            raise cls.skipException(msg)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def test_cephfs_share_contains_mount_option(self):"},{"line_number":284,"context_line":"        body_get \u003d self.shares_v2_client.get_metadata("}],"source_content_type":"text/x-python","patch_set":1,"id":"cf271a94_246bc2f7","line":281,"in_reply_to":"a6804121_13fa54c9","updated":"2025-04-16 19:33:22.000000000","message":"Done","commit_id":"9c853b59093f00ae3a5df2abca6e675108a344cd"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"ca3dfbdfef03f9b31c8fb4d76fdc0e51e1959432","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        super(SharesMetadataCEPHFSTest, cls).skip_checks()"},{"line_number":287,"context_line":"        if not (cls.protocol in CONF.share.enable_protocols):"},{"line_number":288,"context_line":"            msg \u003d ("},{"line_number":289,"context_line":"                \"CEPH filesystem metadata tests are disabled \""},{"line_number":290,"context_line":"                \"for the %s protocol.\" % cls.protocol)"},{"line_number":291,"context_line":"            raise cls.skipException(msg)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2c51f3e4_7b9fcce3","line":289,"range":{"start_line":289,"start_character":17,"end_line":289,"end_character":21},"updated":"2025-04-17 07:54:40.000000000","message":"Minor suggestion, CEPHFS may be more explicit","commit_id":"95fddb0e9fc044fecc5244d9ab90db95997e318b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6696b2c9d9402df6122533c19cd7db2a9dd43cdc","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        super(SharesMetadataCEPHFSTest, cls).skip_checks()"},{"line_number":287,"context_line":"        if not (cls.protocol in CONF.share.enable_protocols):"},{"line_number":288,"context_line":"            msg \u003d ("},{"line_number":289,"context_line":"                \"CEPH filesystem metadata tests are disabled \""},{"line_number":290,"context_line":"                \"for the %s protocol.\" % cls.protocol)"},{"line_number":291,"context_line":"            raise cls.skipException(msg)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ef179ec0_e8cab978","line":289,"range":{"start_line":289,"start_character":17,"end_line":289,"end_character":21},"in_reply_to":"2c51f3e4_7b9fcce3","updated":"2025-04-17 13:01:41.000000000","message":"Done","commit_id":"95fddb0e9fc044fecc5244d9ab90db95997e318b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5ee2d369ba999781eba0b2e78e924beb42536cf1","unresolved":true,"context_lines":[{"line_number":268,"context_line":"        self.assertEqual(max_value, body_get[\"key\"])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"class SharesMetadataCEPHFSTest(base.BaseSharesMixedTest):"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5ad7ccbd_d01800fe","line":271,"range":{"start_line":271,"start_character":31,"end_line":271,"end_character":55},"updated":"2025-04-21 10:59:33.000000000","message":"Since this test only performs a GET request, perhaps you could inherit from SharesMetadataTest and avoid redefining the resource_setup method?","commit_id":"94c11fc8800720d87294283f25553113c6c7e4df"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"6307f9160032395bde93a9cee121caeaf11450fe","unresolved":true,"context_lines":[{"line_number":268,"context_line":"        self.assertEqual(max_value, body_get[\"key\"])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"class SharesMetadataCEPHFSTest(base.BaseSharesMixedTest):"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"284b14ed_84abab40","line":271,"range":{"start_line":271,"start_character":31,"end_line":271,"end_character":55},"in_reply_to":"15135340_546f6f86","updated":"2025-05-29 12:38:06.000000000","message":"Sorry, I missed that earlier. We can handle it by using a load_tests function, although it’s a bit tricky, so I’m fine with whichever approach you prefer.\n\nI\u0027m giving this a +2, but if you feel it\u0027s cleaner to go with load_tests, feel free to update the patch.\n\nHere’s the implementation, just place it at the bottom of the file:\n\ndef load_tests(loader, tests, _):\n    filtered_tests \u003d []\n\n    for test_suite in tests:\n        for test_case in test_suite:\n            cls \u003d type(test_case)\n            method_name \u003d test_case._testMethodName\n\n            if method_name in cls.__dict__:\n                filtered_tests.append(test_case)\n\n    return loader.suiteClass(filtered_tests)","commit_id":"94c11fc8800720d87294283f25553113c6c7e4df"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d62592b1e88db2e168fc2bbae768f2a12ee93820","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.assertEqual(max_value, body_get[\"key\"])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"class SharesMetadataCEPHFSTest(base.BaseSharesMixedTest):"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"80637e00_630d57d8","line":271,"range":{"start_line":271,"start_character":31,"end_line":271,"end_character":55},"in_reply_to":"284b14ed_84abab40","updated":"2025-05-30 00:09:51.000000000","message":"Hi Liron, yes, this pattern is useful..but in this specific case, we\u0027re only creating a share type and share in the resource_setup - so is quite lightweight","commit_id":"94c11fc8800720d87294283f25553113c6c7e4df"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"20c5521b07572616f9c3f8bb9e3bf3fbaf93682a","unresolved":true,"context_lines":[{"line_number":268,"context_line":"        self.assertEqual(max_value, body_get[\"key\"])"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"class SharesMetadataCEPHFSTest(base.BaseSharesMixedTest):"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"15135340_546f6f86","line":271,"range":{"start_line":271,"start_character":31,"end_line":271,"end_character":55},"in_reply_to":"5ad7ccbd_d01800fe","updated":"2025-05-27 13:28:52.000000000","message":"Hey, Liron! It was inheriting from the SharesMetadataTest, but at the end it ends up running all of the tests within the class, and I changed to inherit from the base.BaseSharesMixedTest after a suggestion from Goutham: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/922117/comment/3c7e5d84_a8f6e7c0/","commit_id":"94c11fc8800720d87294283f25553113c6c7e4df"}],"manila_tempest_tests/tests/api/test_scheduler_hints.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ad54973324e0f9418b7d909e8bd47745aa681f5","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        # get metadata of share"},{"line_number":73,"context_line":"        metadata_a \u003d self.shares_v2_client.get_metadata("},{"line_number":74,"context_line":"            self.share_a[\"id\"])[\u0027metadata\u0027]"},{"line_number":75,"context_line":"        # In case the share procol is CEPHFS, the driver will also set"},{"line_number":76,"context_line":"        # \u0027__mount_options\u0027 as metadata, but that is irrelevant in this test,"},{"line_number":77,"context_line":"        # so we can drop it before the assertion."},{"line_number":78,"context_line":"        metadata_a.pop(\u0027__mount_options\u0027, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2beac92c_d59f51dd","line":75,"range":{"start_line":75,"start_character":28,"end_line":75,"end_character":34},"updated":"2025-04-08 21:51:50.000000000","message":"protocol","commit_id":"5c196fc8af8d473be4cc289ecb0c7690a51b50ae"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fcac95311461d4cb461433871ec53548e5e46f9a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # get metadata of share"},{"line_number":73,"context_line":"        metadata_a \u003d self.shares_v2_client.get_metadata("},{"line_number":74,"context_line":"            self.share_a[\"id\"])[\u0027metadata\u0027]"},{"line_number":75,"context_line":"        # In case the share procol is CEPHFS, the driver will also set"},{"line_number":76,"context_line":"        # \u0027__mount_options\u0027 as metadata, but that is irrelevant in this test,"},{"line_number":77,"context_line":"        # so we can drop it before the assertion."},{"line_number":78,"context_line":"        metadata_a.pop(\u0027__mount_options\u0027, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"8e209efd_ca09b3b7","line":75,"range":{"start_line":75,"start_character":28,"end_line":75,"end_character":34},"in_reply_to":"2beac92c_d59f51dd","updated":"2025-04-16 22:40:31.000000000","message":"Done","commit_id":"5c196fc8af8d473be4cc289ecb0c7690a51b50ae"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"ca3dfbdfef03f9b31c8fb4d76fdc0e51e1959432","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        # In case the share protocol is CEPHFS, the driver will also set"},{"line_number":76,"context_line":"        # \u0027__mount_options\u0027 as metadata, but that is irrelevant in this test,"},{"line_number":77,"context_line":"        # so we can drop it before the assertion."},{"line_number":78,"context_line":"        metadata_a.pop(\u0027__mount_options\u0027, None)"},{"line_number":79,"context_line":"        md_a \u003d {\"__affinity_same_host\": \"%s\" % share_b[\"id\"]}"},{"line_number":80,"context_line":"        metadata_b \u003d self.shares_v2_client.get_metadata("},{"line_number":81,"context_line":"            share_b[\"id\"])[\u0027metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"6934c28c_8b969c15","line":78,"range":{"start_line":78,"start_character":7,"end_line":78,"end_character":47},"updated":"2025-04-17 07:54:40.000000000","message":"Is this required? ie. would the assertion pass without the option removed?","commit_id":"95fddb0e9fc044fecc5244d9ab90db95997e318b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6696b2c9d9402df6122533c19cd7db2a9dd43cdc","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # In case the share protocol is CEPHFS, the driver will also set"},{"line_number":76,"context_line":"        # \u0027__mount_options\u0027 as metadata, but that is irrelevant in this test,"},{"line_number":77,"context_line":"        # so we can drop it before the assertion."},{"line_number":78,"context_line":"        metadata_a.pop(\u0027__mount_options\u0027, None)"},{"line_number":79,"context_line":"        md_a \u003d {\"__affinity_same_host\": \"%s\" % share_b[\"id\"]}"},{"line_number":80,"context_line":"        metadata_b \u003d self.shares_v2_client.get_metadata("},{"line_number":81,"context_line":"            share_b[\"id\"])[\u0027metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"db5b026c_23766a81","line":78,"range":{"start_line":78,"start_character":7,"end_line":78,"end_character":47},"in_reply_to":"6934c28c_8b969c15","updated":"2025-04-17 13:01:41.000000000","message":"yes, the test is failing without it. This test is focusing on scheduler hints as metadata. The way the test is written, we are looking at all metadata set and only expecting the affinity related metadata to be there in the share. Now, it\u0027s not true in case it is a CEPHFS share, so we have two approaches:\n1. disregard the __mount_options metadata and only focus on the metadata for affinity/anti-affinity\n2. do the assert only in the metadata set by this test and ignore if other metadata is set.\n\nThinking again, in the long term the second approach is better. I\u0027m updating this test.","commit_id":"95fddb0e9fc044fecc5244d9ab90db95997e318b"}]}