)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"674cbe4eb73a029ee7cec6cda8aae68e3084b8dc","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Metadata for Share Export Location"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add functional testing for Export Location Metadata"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I113ea3095cdc9d5d2903ba83641afd3ee112c17d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0c5b3844_5f317e20","line":10,"updated":"2024-08-28 18:54:11.000000000","message":"Partially-implements: bp metadata-for-share-resources","commit_id":"793853ea66e56b89c26d7217dc4195e0e3bb8b17"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"96b18e520a3ebd3c18f11673be267f570858c540","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Metadata for Share Export Location"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add functional testing for Export Location Metadata"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I113ea3095cdc9d5d2903ba83641afd3ee112c17d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"010cd289_3c07b7c6","line":10,"in_reply_to":"0c5b3844_5f317e20","updated":"2024-09-04 22:17:26.000000000","message":"Done","commit_id":"793853ea66e56b89c26d7217dc4195e0e3bb8b17"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c9eb687f8a288ae978041fab542cfd85aee25ad","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Metadata for Share Export Location"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add functional testing for Export Location Metadata"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I113ea3095cdc9d5d2903ba83641afd3ee112c17d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ac3ec65e_16490598","line":10,"updated":"2024-08-29 06:27:02.000000000","message":"Also missing a \"Depends-On\"","commit_id":"ee045e6fbd84e8b5baf5683db78e36a27adbe092"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"96b18e520a3ebd3c18f11673be267f570858c540","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Metadata for Share Export Location"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add functional testing for Export Location Metadata"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I113ea3095cdc9d5d2903ba83641afd3ee112c17d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"81eeb17c_0e1ffb95","line":10,"in_reply_to":"ac3ec65e_16490598","updated":"2024-09-04 22:17:26.000000000","message":"Done","commit_id":"ee045e6fbd84e8b5baf5683db78e36a27adbe092"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5ec727e6cbb364f8aefd49878122bb6ce33a96bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"67444c4b_eceb6b31","updated":"2024-08-22 18:49:04.000000000","message":"Hey, could you please bump the version of manila-tempest-plugin? [1]\nThe tests are currently being skipped :)\n\n[1] https://github.com/openstack/manila-tempest-plugin/blob/b758fb49cc8c9d56fa83f910f3462a845eec1b1b/manila_tempest_tests/config.py#L42-L45","commit_id":"793853ea66e56b89c26d7217dc4195e0e3bb8b17"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dfad2e542ee55e7cc75051995e3574e6fe6d5276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1d472554_65eaca4f","updated":"2024-09-24 19:42:08.000000000","message":"Hey, I looked at the tests failing and here are some findings:\n\n- The tests from `manila_tempest_tests.tests.api.admin.test_export_locations.ExportLocationsTest` are mostly failing with mismatching counts while going through the `_verify_export_location_structure` method. This method is doing all of the verification, and it is pretty much defining what are the expected keys and checking if the count of keys returned by the server are the same. It won\u0027t be anymore, as we always return one additional key now: metadata. So metadata should be added to the `summary_keys` list when the microversion matches the export location metadata feature version. I believe it would be worth it coding it like a ddt and ensure that before that version we won\u0027t have metadata, and add the key only when the version matched. I believe we should be good with the 4 tests within that class once this is applied to the test.\n\n- The test failing on `manila_tempest_tests.tests.api.test_replication_export_locations.ReplicationExportLocationsTest` seems to be pretty much the same thing, but in this case, it is not only checking the amount of keys returned. It is also checking what are they. I believe that adding `metadata` to `el_summary_keys` should solve this issue. I believe ddt would also be nice here, to ensure we have preserved the behavior from previous versions.\n\nAs for the failing tests that are being introduced, I dropped a comment in one of the files that will reflect in basically all calls to the export location metadata APIs.","commit_id":"5962228bee3c8470d496cfa7952bd5912170ce84"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d74b8af685949bffa4d33c65d399cfa0e8391746","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d24f068b_68be919f","in_reply_to":"1d472554_65eaca4f","updated":"2024-09-24 19:42:38.000000000","message":"and thank you very much for pursuing these tests! it is very important to get coverage on manila-tempest-plugin :D","commit_id":"5962228bee3c8470d496cfa7952bd5912170ce84"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1c0b336cd4c2195114a2b93d41ddc09e6b7d407f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"95e9a3ba_36dee94d","updated":"2024-09-25 18:49:58.000000000","message":"Thanks for fixing the issues, I believe we\u0027re almost getting rid of the failures :D","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"055640ff_06d7f7a4","updated":"2024-10-01 23:37:39.000000000","message":"Hi @ashrod98@redhat.com - thanks for working on this.. lots to fix here; please see comments inline","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"1f22290bc47c9b89ec17b598925e127223e5b6fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9eedb0b9_dfe9ac19","updated":"2025-01-10 16:33:56.000000000","message":"recheck old logs","commit_id":"a6037fbee6099f2a144cbc51099fb65c0b75ac10"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"4ebdc6a162eeb9b33480ac90afd151f02365ab7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"17554007_e0e2ae22","updated":"2025-01-28 19:11:11.000000000","message":"Thanks for the review, waiting on new results regarding testing different clients","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9050a5dfcd9a4ecdd7197399b2179c226dee891f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"82b9173d_5a35405e","updated":"2025-01-24 20:48:46.000000000","message":"o/ sorry for the delay. I\u0027ve looked at the failures and found some issues. Please take a look at the suggestions inline","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"eab97d027c2a7017d4450f351254f41566cb8467","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"6b02ce40_00967389","updated":"2025-06-24 18:57:04.000000000","message":"recheck old logs","commit_id":"ce2d02fb22e50c2e4818c8e430f667cca42af097"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2289cd47e6f0ca1be80d0a17c75ae0175a33c4ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"d22b631c_51297166","updated":"2025-05-22 12:43:03.000000000","message":"recheck old logs","commit_id":"ce2d02fb22e50c2e4818c8e430f667cca42af097"}],"manila_tempest_tests/tests/api/admin/test_export_locations_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7cb7e6b292bb9e14bda659ffd4133ea5589db57b","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":66,"context_line":"    def test_set_get_delete_metadata(self):"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        md \u003d {u\"key3\": u\"value3\", u\"key4\": u\"value4\", u\"key.5.1\": u\"value.5\"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # get export location"},{"line_number":71,"context_line":"        export_location \u003d self.admin_client.list_share_export_locations("}],"source_content_type":"text/x-python","patch_set":4,"id":"9bb8f3ca_81881612","line":68,"range":{"start_line":68,"start_character":14,"end_line":68,"end_character":15},"updated":"2024-09-03 23:05:01.000000000","message":"this is a python2 paradigm; all strings in python3 are unicode strings, so remove this here and everywhere else..","commit_id":"c464a14b658dfcb152db2355b4a239b6271e2e78"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"96b18e520a3ebd3c18f11673be267f570858c540","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":66,"context_line":"    def test_set_get_delete_metadata(self):"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        md \u003d {u\"key3\": u\"value3\", u\"key4\": u\"value4\", u\"key.5.1\": u\"value.5\"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # get export location"},{"line_number":71,"context_line":"        export_location \u003d self.admin_client.list_share_export_locations("}],"source_content_type":"text/x-python","patch_set":4,"id":"7c43944f_42fcd417","line":68,"range":{"start_line":68,"start_character":14,"end_line":68,"end_character":15},"in_reply_to":"9bb8f3ca_81881612","updated":"2024-09-04 22:17:26.000000000","message":"Done","commit_id":"c464a14b658dfcb152db2355b4a239b6271e2e78"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dfad2e542ee55e7cc75051995e3574e6fe6d5276","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # verify metadata items"},{"line_number":59,"context_line":"        for key in md:"},{"line_number":60,"context_line":"            get_value \u003d self.shares_v2_client.get_metadata_item("},{"line_number":61,"context_line":"                export_location[\u0027id\u0027], key, resource\u003d\"share_export_location\")"},{"line_number":62,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @decorators.idempotent_id(\"dff1f417-a8ac-4837-adfb-7b08472be7d6\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"35f688cb_5c5e06cc","line":61,"range":{"start_line":60,"start_character":12,"end_line":61,"end_character":77},"updated":"2024-09-24 19:42:08.000000000","message":"```suggestion\n            get_value \u003d self.shares_v2_client.get_metadata_item(\n                export_location[\u0027id\u0027], key,\n                resource\u003d\"export_location\",\n                parent_resource\u003d\u0027shares\u0027,\n                parent_id\u003dself.share_id)[\"meta\"]\n```\nHere and in all of the calls to the export location metadata both in this file and the other new file being introduced, we will need to specify the parent resource and the parent ID, so that the json client can build the request URL correctly. It currently looks like this: `share/v2/94bdfccb7a8d428b919cd7c64b26dafa/share_export_locations/5a761c9c-8c86-42bb-9b6e-25c175c266f9/metadata/key7` and it should look like: `share/v2/shares/cb89a7b7-b1d9-42d8-a082-d4a5d9db6b86/export_locations/2af1830a-baa8-49e7-a5d7-88d85be1b3c5/metadata` so by specifying parent_resource and parent_id, it will build the URLs correctly.","commit_id":"5962228bee3c8470d496cfa7952bd5912170ce84"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"70fb563f4133d700c4d40f815dd9e79e4d43a64c","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # verify metadata items"},{"line_number":59,"context_line":"        for key in md:"},{"line_number":60,"context_line":"            get_value \u003d self.shares_v2_client.get_metadata_item("},{"line_number":61,"context_line":"                export_location[\u0027id\u0027], key, resource\u003d\"share_export_location\")"},{"line_number":62,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @decorators.idempotent_id(\"dff1f417-a8ac-4837-adfb-7b08472be7d6\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"9acdf725_ca029d1f","line":61,"range":{"start_line":60,"start_character":12,"end_line":61,"end_character":77},"in_reply_to":"35f688cb_5c5e06cc","updated":"2024-09-24 19:59:50.000000000","message":"Done","commit_id":"5962228bee3c8470d496cfa7952bd5912170ce84"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dfad2e542ee55e7cc75051995e3574e6fe6d5276","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        md2 \u003d {\"key11\": \"value11\", \"key12\": \"value12\", }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # get export location"},{"line_number":100,"context_line":"        export_location \u003d self.admin_client.list_share_export_locations("},{"line_number":101,"context_line":"            self.share_id)[\u0027export_locations\u0027][0]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # set metadata"}],"source_content_type":"text/x-python","patch_set":9,"id":"f6a9a2ae_aac6b2e4","line":100,"range":{"start_line":100,"start_character":31,"end_line":100,"end_character":43},"updated":"2024-09-24 19:42:08.000000000","message":"admin_shares_v2_client","commit_id":"5962228bee3c8470d496cfa7952bd5912170ce84"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"70fb563f4133d700c4d40f815dd9e79e4d43a64c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        md2 \u003d {\"key11\": \"value11\", \"key12\": \"value12\", }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # get export location"},{"line_number":100,"context_line":"        export_location \u003d self.admin_client.list_share_export_locations("},{"line_number":101,"context_line":"            self.share_id)[\u0027export_locations\u0027][0]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # set metadata"}],"source_content_type":"text/x-python","patch_set":9,"id":"698f47dd_cd916041","line":100,"range":{"start_line":100,"start_character":31,"end_line":100,"end_character":43},"in_reply_to":"f6a9a2ae_aac6b2e4","updated":"2024-09-24 19:59:50.000000000","message":"Done","commit_id":"5962228bee3c8470d496cfa7952bd5912170ce84"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0690e0044190a1f9d0a3174d266e2db588428f4b","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        # get metadata of export location"},{"line_number":51,"context_line":"        metadata \u003d self.shares_v2_client.get_metadata("},{"line_number":52,"context_line":"            export_location[\u0027id\u0027],"},{"line_number":53,"context_line":"            resource\u003d\"share_export_location\")[\u0027metadata\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # verify metadata"},{"line_number":56,"context_line":"        self.assertEqual(md, metadata)"}],"source_content_type":"text/x-python","patch_set":11,"id":"17f10160_01b503a1","line":53,"range":{"start_line":53,"start_character":22,"end_line":53,"end_character":43},"updated":"2024-09-25 08:28:58.000000000","message":"export_location, and also please add the parent_resource and parent_id","commit_id":"e1b1b4ff6c3b6e83758857294e62291280541f59"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"493deed0c301668a025f5494fff9cbc73e7995a8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # get metadata of export location"},{"line_number":51,"context_line":"        metadata \u003d self.shares_v2_client.get_metadata("},{"line_number":52,"context_line":"            export_location[\u0027id\u0027],"},{"line_number":53,"context_line":"            resource\u003d\"share_export_location\")[\u0027metadata\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # verify metadata"},{"line_number":56,"context_line":"        self.assertEqual(md, metadata)"}],"source_content_type":"text/x-python","patch_set":11,"id":"72c2c875_1a922d50","line":53,"range":{"start_line":53,"start_character":22,"end_line":53,"end_character":43},"in_reply_to":"17f10160_01b503a1","updated":"2024-09-25 16:42:46.000000000","message":"Done","commit_id":"e1b1b4ff6c3b6e83758857294e62291280541f59"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0690e0044190a1f9d0a3174d266e2db588428f4b","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        for key in md:"},{"line_number":60,"context_line":"            get_value \u003d self.shares_v2_client.get_metadata_item("},{"line_number":61,"context_line":"                export_location[\u0027id\u0027], key,"},{"line_number":62,"context_line":"                resource\u003d\"export_locations\","},{"line_number":63,"context_line":"                parent_resource\u003d\u0027shares\u0027,"},{"line_number":64,"context_line":"                parent_id\u003dself.share_id)[\"meta\"]"},{"line_number":65,"context_line":"            self.assertEqual(md[key], get_value[key])"}],"source_content_type":"text/x-python","patch_set":11,"id":"0f32431c_8b53879a","line":62,"range":{"start_line":62,"start_character":26,"end_line":62,"end_character":42},"updated":"2024-09-25 08:28:58.000000000","message":"```suggestion\n                resource\u003d\"export_location\",\n```\nI think this should be export_location (singular) :) that should get us past the current issues","commit_id":"e1b1b4ff6c3b6e83758857294e62291280541f59"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"493deed0c301668a025f5494fff9cbc73e7995a8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        for key in md:"},{"line_number":60,"context_line":"            get_value \u003d self.shares_v2_client.get_metadata_item("},{"line_number":61,"context_line":"                export_location[\u0027id\u0027], key,"},{"line_number":62,"context_line":"                resource\u003d\"export_locations\","},{"line_number":63,"context_line":"                parent_resource\u003d\u0027shares\u0027,"},{"line_number":64,"context_line":"                parent_id\u003dself.share_id)[\"meta\"]"},{"line_number":65,"context_line":"            self.assertEqual(md[key], get_value[key])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1832b415_0b0d7260","line":62,"range":{"start_line":62,"start_character":26,"end_line":62,"end_character":42},"in_reply_to":"0f32431c_8b53879a","updated":"2024-09-25 16:42:46.000000000","message":"Done","commit_id":"e1b1b4ff6c3b6e83758857294e62291280541f59"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55583092a5dc8c03e1be31691b22f1d719d19f9a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":12,"id":"46fdd045_df1055b3","line":1,"updated":"2024-09-25 18:49:31.000000000","message":"so I looked at the failures and even ran some tests locally. The test `manila_tempest_tests.tests.api.admin.test_export_locations_metadata.ShareExportLocationMetadataTest.test_set_and_update_metadata_by_key` failed on CI but it passed locally: https://paste.opendev.org/show/b4B76WIY2GIkV34SDv9H/\nIf we look at the failure of this test specifically, it failed because the test encountered a `preferred` metadata set, but it has never actually set that metadata key on the given share on this test, which makes me believe that the test concurrency is not being our friend here. As the same share is being reused and several tests are running within the same share, there is a chance that other tests are currently setting some values and when we get the metadata, we\u0027ll get metadata that other tests have set :/ \nI believe that in this case, creating a share for each test would be the way to go, so one test won\u0027t get in the way of the other. We can have a method that does the share creation for us and the tests only consume it, so we don\u0027t repeat ourselves. Added some suggestions inline :)","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"085ef98e4ae2f313b298ccc17e315b3f06e92ec2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":12,"id":"dbb74fb5_d9378fc3","line":1,"in_reply_to":"46fdd045_df1055b3","updated":"2024-10-11 16:50:19.000000000","message":"Done","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55583092a5dc8c03e1be31691b22f1d719d19f9a","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        cls.share_id \u003d cls.share[\"id\"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _verify_export_location_metadata(self, export_location, md):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # get metadata of export location"},{"line_number":51,"context_line":"        metadata \u003d self.shares_v2_client.get_metadata("}],"source_content_type":"text/x-python","patch_set":12,"id":"2ecda6d7_1034d191","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":68},"updated":"2024-09-25 18:49:31.000000000","message":"```suggestion\n    def _setup_share_for_metadata_test(self):\n        share_name \u003d data_utils.rand_name(\"tempest-share-name\")\n        share_desc \u003d data_utils.rand_name(\"tempest-share-description\")\n        share \u003d self.create_share(\n            name\u003dshare_name,\n            description\u003dshare_desc,\n            share_type_id\u003dself.share_type_id,\n        )\n        return share\n\n    def _verify_export_location_metadata(self, export_location, md):\n```","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"706d551aa63c2bb6be02b04fe1871c7283adb90f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        cls.share_id \u003d cls.share[\"id\"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _verify_export_location_metadata(self, export_location, md):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # get metadata of export location"},{"line_number":51,"context_line":"        metadata \u003d self.shares_v2_client.get_metadata("}],"source_content_type":"text/x-python","patch_set":12,"id":"43f83969_7c1a717a","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":68},"in_reply_to":"2ecda6d7_1034d191","updated":"2024-09-25 19:58:41.000000000","message":"Done","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55583092a5dc8c03e1be31691b22f1d719d19f9a","unresolved":true,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        md \u003d {\"key3\": \"value3\", \"key4\": \"value4\", \"key.5.1\": \"value.5\"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # get export location"},{"line_number":76,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":77,"context_line":"                           .list_share_export_locations("},{"line_number":78,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"}],"source_content_type":"text/x-python","patch_set":12,"id":"dbadfd78_01b610c2","line":75,"updated":"2024-09-25 18:49:31.000000000","message":"here and in every single test:\n```suggestion\n        share_id \u003d self._setup_share_for_metadata_test()[\u0027id\u0027]\n        # get export location\n```","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"706d551aa63c2bb6be02b04fe1871c7283adb90f","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        md \u003d {\"key3\": \"value3\", \"key4\": \"value4\", \"key.5.1\": \"value.5\"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # get export location"},{"line_number":76,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":77,"context_line":"                           .list_share_export_locations("},{"line_number":78,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"}],"source_content_type":"text/x-python","patch_set":12,"id":"1c7e12ad_ea730af5","line":75,"in_reply_to":"dbadfd78_01b610c2","updated":"2024-09-25 19:58:41.000000000","message":"Done","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55583092a5dc8c03e1be31691b22f1d719d19f9a","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            export_location[\u0027id\u0027], md,"},{"line_number":83,"context_line":"            resource\u003d\"export_location\","},{"line_number":84,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":85,"context_line":"            parent_id\u003dself.share_id)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # verify metadata"},{"line_number":88,"context_line":"        self._verify_export_location_metadata(export_location, md)"}],"source_content_type":"text/x-python","patch_set":12,"id":"65b0f5a5_ec0ab0aa","line":85,"range":{"start_line":85,"start_character":22,"end_line":85,"end_character":35},"updated":"2024-09-25 18:49:31.000000000","message":"here and in all other occurences:\n\n```suggestion\n            parent_id\u003dshare_id)\n```","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"706d551aa63c2bb6be02b04fe1871c7283adb90f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            export_location[\u0027id\u0027], md,"},{"line_number":83,"context_line":"            resource\u003d\"export_location\","},{"line_number":84,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":85,"context_line":"            parent_id\u003dself.share_id)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # verify metadata"},{"line_number":88,"context_line":"        self._verify_export_location_metadata(export_location, md)"}],"source_content_type":"text/x-python","patch_set":12,"id":"8c27be56_81d27f5a","line":85,"range":{"start_line":85,"start_character":22,"end_line":85,"end_character":35},"in_reply_to":"65b0f5a5_ec0ab0aa","updated":"2024-09-25 19:58:41.000000000","message":"Done","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55583092a5dc8c03e1be31691b22f1d719d19f9a","unresolved":true,"context_lines":[{"line_number":93,"context_line":"                export_location[\u0027id\u0027], key,"},{"line_number":94,"context_line":"                resource\u003d\"export_location\","},{"line_number":95,"context_line":"                parent_resource\u003d\u0027shares\u0027,"},{"line_number":96,"context_line":"                parent_id\u003dself.share_id)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # verify deletion of metadata"},{"line_number":99,"context_line":"        get_metadata \u003d self.shares_v2_client.get_metadata("}],"source_content_type":"text/x-python","patch_set":12,"id":"159fac47_3e606d02","line":96,"range":{"start_line":96,"start_character":26,"end_line":96,"end_character":31},"updated":"2024-09-25 18:49:31.000000000","message":"```suggestion\n                parent_id\u003dshare_id)\n```","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"706d551aa63c2bb6be02b04fe1871c7283adb90f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                export_location[\u0027id\u0027], key,"},{"line_number":94,"context_line":"                resource\u003d\"export_location\","},{"line_number":95,"context_line":"                parent_resource\u003d\u0027shares\u0027,"},{"line_number":96,"context_line":"                parent_id\u003dself.share_id)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # verify deletion of metadata"},{"line_number":99,"context_line":"        get_metadata \u003d self.shares_v2_client.get_metadata("}],"source_content_type":"text/x-python","patch_set":12,"id":"90443d8a_58b019db","line":96,"range":{"start_line":96,"start_character":26,"end_line":96,"end_character":31},"in_reply_to":"159fac47_3e606d02","updated":"2024-09-25 19:58:41.000000000","message":"Done","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55583092a5dc8c03e1be31691b22f1d719d19f9a","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            export_location[\u0027id\u0027],"},{"line_number":101,"context_line":"            resource\u003d\"export_location\","},{"line_number":102,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":103,"context_line":"            parent_id\u003dself.share_id)[\u0027metadata\u0027]"},{"line_number":104,"context_line":"        self.assertEmpty(get_metadata)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @decorators.idempotent_id(\"00f8a0a3-5b66-455b-b701-8be0-7be08a4f\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"c3829bec_2a32065e","line":103,"range":{"start_line":103,"start_character":22,"end_line":103,"end_character":27},"updated":"2024-09-25 18:49:31.000000000","message":"```suggestion\n            parent_id\u003dshare_id)[\u0027metadata\u0027]\n```","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"706d551aa63c2bb6be02b04fe1871c7283adb90f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            export_location[\u0027id\u0027],"},{"line_number":101,"context_line":"            resource\u003d\"export_location\","},{"line_number":102,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":103,"context_line":"            parent_id\u003dself.share_id)[\u0027metadata\u0027]"},{"line_number":104,"context_line":"        self.assertEmpty(get_metadata)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @decorators.idempotent_id(\"00f8a0a3-5b66-455b-b701-8be0-7be08a4f\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"a4edf71c_1b12efb7","line":103,"range":{"start_line":103,"start_character":22,"end_line":103,"end_character":27},"in_reply_to":"c3829bec_2a32065e","updated":"2024-09-25 19:58:41.000000000","message":"Done","commit_id":"6c40cf8d86cf2d4f9d919c332c133d76364950c4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8d67bd35d0ec4f9bb13cd69837611a03247e406","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        # get export location"},{"line_number":87,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":88,"context_line":"                           .list_share_export_locations("},{"line_number":89,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # set metadata"},{"line_number":92,"context_line":"        self.shares_v2_client.set_metadata("}],"source_content_type":"text/x-python","patch_set":13,"id":"9b5f08de_b95fd935","line":89,"range":{"start_line":89,"start_character":31,"end_line":89,"end_character":44},"updated":"2024-09-26 18:29:54.000000000","message":"I believe here and all of the other mentions to self.share_id should be refactored to:\n```suggestion\n                               share_id)[\u0027export_locations\u0027][0])\n```","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"d1e26a034c9256cc4252a778c9c08a1e3a7658a2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # get export location"},{"line_number":87,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":88,"context_line":"                           .list_share_export_locations("},{"line_number":89,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # set metadata"},{"line_number":92,"context_line":"        self.shares_v2_client.set_metadata("}],"source_content_type":"text/x-python","patch_set":13,"id":"fbe275fe_f3cf6bad","line":89,"range":{"start_line":89,"start_character":31,"end_line":89,"end_character":44},"in_reply_to":"9b5f08de_b95fd935","updated":"2024-09-26 20:42:35.000000000","message":"Done","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"cf4801c3_5edfef99","updated":"2024-10-01 23:37:39.000000000","message":"None of the tests in this file are \u0027admin\u0027 tests; i.e., no test case here requires the \"admin\" user to make any API calls. \n\nCan we move this under `manila_tempest_tests/tests/api/` instead? In the tests, I see that the admin client is being used to query the export locations.. Lets switch to using the regular user client for that action","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d47059d3_6a1eea8f","in_reply_to":"cf4801c3_5edfef99","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e96c73756d7ee810da8c964f9b40f8d2aa82f161","unresolved":true,"context_lines":[{"line_number":64,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":65,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # verify metadata"},{"line_number":68,"context_line":"        self.assertEqual(md, metadata)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # verify metadata items"},{"line_number":71,"context_line":"        for key in md:"}],"source_content_type":"text/x-python","patch_set":15,"id":"2e295563_8d1bb8ba","line":68,"range":{"start_line":67,"start_character":8,"end_line":68,"end_character":38},"updated":"2024-09-27 17:45:57.000000000","message":"```suggestion\n        metadata.pop(\"preferred\")\n        # verify metadata\n        self.assertEqual(md, metadata)\n```\nSo all tests are failing because everything matches, but preferred is also returned, so we need to either ensure that preferred exists or drop it from the metadata so that we don\u0027t validate it on these tests :)","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":64,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":65,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # verify metadata"},{"line_number":68,"context_line":"        self.assertEqual(md, metadata)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # verify metadata items"},{"line_number":71,"context_line":"        for key in md:"}],"source_content_type":"text/x-python","patch_set":15,"id":"6f7dd871_63058559","line":68,"range":{"start_line":67,"start_character":8,"end_line":68,"end_character":38},"in_reply_to":"2e295563_8d1bb8ba","updated":"2024-10-01 23:37:39.000000000","message":"Just in case you want to test updating the \"preferred\" export:\n```\n\nif \u0027preferred\u0027 not in md:\n   # pop the \"preferred\" key from the metadata; it\u0027s always going to exist\n   metadata.pop(\"preferred\", None)\n```","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":65,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # verify metadata"},{"line_number":68,"context_line":"        self.assertEqual(md, metadata)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # verify metadata items"},{"line_number":71,"context_line":"        for key in md:"}],"source_content_type":"text/x-python","patch_set":15,"id":"9fc6c9b5_3bdcd761","line":68,"range":{"start_line":67,"start_character":8,"end_line":68,"end_character":38},"in_reply_to":"6f7dd871_63058559","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        share_id \u003d self._setup_share_for_metadata_test()[\u0027id\u0027]"},{"line_number":86,"context_line":"        # get export location"},{"line_number":87,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":88,"context_line":"                           .list_share_export_locations("},{"line_number":89,"context_line":"                               share_id)[\u0027export_locations\u0027][0])"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"59a090cf_957fe12b","line":87,"range":{"start_line":87,"start_character":32,"end_line":87,"end_character":54},"updated":"2024-10-01 23:37:39.000000000","message":"this doesn\u0027t need the admin_shares_v2_client; shares_v2_client will work","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        share_id \u003d self._setup_share_for_metadata_test()[\u0027id\u0027]"},{"line_number":86,"context_line":"        # get export location"},{"line_number":87,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":88,"context_line":"                           .list_share_export_locations("},{"line_number":89,"context_line":"                               share_id)[\u0027export_locations\u0027][0])"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"35f671d3_7a5a5a8d","line":87,"range":{"start_line":87,"start_character":32,"end_line":87,"end_character":54},"in_reply_to":"59a090cf_957fe12b","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            resource\u003d\"export_location\","},{"line_number":113,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":114,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":115,"context_line":"        self.assertEmpty(get_metadata)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @decorators.idempotent_id(\"00f8a0a3-5b66-455b-b701-8be0-7be08a4f\")"},{"line_number":118,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9024c69b_d4319715","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":38},"updated":"2024-10-01 23:37:39.000000000","message":"This shouldn\u0027t be empty? We should always see \"preferred\"","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            resource\u003d\"export_location\","},{"line_number":113,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":114,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":115,"context_line":"        self.assertEmpty(get_metadata)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @decorators.idempotent_id(\"00f8a0a3-5b66-455b-b701-8be0-7be08a4f\")"},{"line_number":118,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bb9538a0_965baf6a","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":38},"in_reply_to":"9024c69b_d4319715","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":164,"context_line":"            resource\u003d\"export_location\","},{"line_number":165,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":166,"context_line":"            parent_id\u003dshare_id)"},{"line_number":167,"context_line":"        self.assertEmpty(get_metadata)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @decorators.idempotent_id(\"27a12a0f-d136-4c2c-8975-0dcf8215221d\")"},{"line_number":170,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":15,"id":"329d5a99_ec4e29fb","line":167,"range":{"start_line":167,"start_character":24,"end_line":167,"end_character":38},"updated":"2024-10-01 23:37:39.000000000","message":"\"preferred\" will exist","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            resource\u003d\"export_location\","},{"line_number":165,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":166,"context_line":"            parent_id\u003dshare_id)"},{"line_number":167,"context_line":"        self.assertEmpty(get_metadata)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @decorators.idempotent_id(\"27a12a0f-d136-4c2c-8975-0dcf8215221d\")"},{"line_number":170,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":15,"id":"d5e85362_fa7532d7","line":167,"range":{"start_line":167,"start_character":24,"end_line":167,"end_character":38},"in_reply_to":"329d5a99_ec4e29fb","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":213,"context_line":"            resource\u003d\"export_location\","},{"line_number":214,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":215,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":216,"context_line":"        self.assertEmpty(get_metadata)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @decorators.idempotent_id(\"418effa1-5a95-468e-ab23-4dedb70ef967\")"},{"line_number":219,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":15,"id":"409c4288_d4cb91d4","line":216,"range":{"start_line":216,"start_character":24,"end_line":216,"end_character":38},"updated":"2024-10-01 23:37:39.000000000","message":"\"preferred\" will exist","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            resource\u003d\"export_location\","},{"line_number":214,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":215,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":216,"context_line":"        self.assertEmpty(get_metadata)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @decorators.idempotent_id(\"418effa1-5a95-468e-ab23-4dedb70ef967\")"},{"line_number":219,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":15,"id":"354ea546_9119e190","line":216,"range":{"start_line":216,"start_character":24,"end_line":216,"end_character":38},"in_reply_to":"409c4288_d4cb91d4","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"}],"manila_tempest_tests/tests/api/admin/test_export_locations_metadata_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a77777f71a1db794badc4e4bb58e5ca2edb32d8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51c57f72_227f175d","line":153,"updated":"2024-08-28 18:55:25.000000000","message":"Please add a test where we can expect errors when trying to modify the preferred metadata key","commit_id":"ee045e6fbd84e8b5baf5683db78e36a27adbe092"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"96b18e520a3ebd3c18f11673be267f570858c540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"72296741_cfbe7439","line":153,"in_reply_to":"51c57f72_227f175d","updated":"2024-09-04 22:17:26.000000000","message":"Done","commit_id":"ee045e6fbd84e8b5baf5683db78e36a27adbe092"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0690e0044190a1f9d0a3174d266e2db588428f4b","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":63,"context_line":"                          self.shares_v2_client.set_metadata,"},{"line_number":64,"context_line":"                          \"wrong_export_location_id\", md,"},{"line_number":65,"context_line":"                          resource\u003d\"export_locations\","},{"line_number":66,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"},{"line_number":67,"context_line":"                          parent_id\u003dself.share_id)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"13979ae1_85cf1f1c","line":65,"range":{"start_line":65,"start_character":36,"end_line":65,"end_character":52},"updated":"2024-09-25 08:28:58.000000000","message":"```suggestion\n                          resource\u003d\"export_location\",\n```\nhere and below :)","commit_id":"e1b1b4ff6c3b6e83758857294e62291280541f59"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"493deed0c301668a025f5494fff9cbc73e7995a8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":63,"context_line":"                          self.shares_v2_client.set_metadata,"},{"line_number":64,"context_line":"                          \"wrong_export_location_id\", md,"},{"line_number":65,"context_line":"                          resource\u003d\"export_locations\","},{"line_number":66,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"},{"line_number":67,"context_line":"                          parent_id\u003dself.share_id)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"a0216598_f4805400","line":65,"range":{"start_line":65,"start_character":36,"end_line":65,"end_character":52},"in_reply_to":"13979ae1_85cf1f1c","updated":"2024-09-25 16:42:46.000000000","message":"Done","commit_id":"e1b1b4ff6c3b6e83758857294e62291280541f59"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8d67bd35d0ec4f9bb13cd69837611a03247e406","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                           .list_share_export_locations("},{"line_number":88,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":89,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":90,"context_line":"                          alt_user.shares_v2_client.update_all_metadata,"},{"line_number":91,"context_line":"                          export_location[\"id\"], md,"},{"line_number":92,"context_line":"                          resource\u003d\"export_location\","},{"line_number":93,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"8c879bf4_2284cbd0","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":72},"updated":"2024-09-26 18:29:54.000000000","message":"this request is somehow going through and updating the metadata.\nuser_project is:\ncls.user_project \u003d cls.os_admin.projects_client.show_project(\n            cls.shares_v2_client.project_id)[\u0027project\u0027]\nI believe if we create a user in the same project that the share resides, the user will be able to make modifications, as the policy is: ADMIN_OR_PROJECT_MEMBER\nI haven\u0027t tried this, only looked at the code but this would be my first guess :)","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"d1e26a034c9256cc4252a778c9c08a1e3a7658a2","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                           .list_share_export_locations("},{"line_number":88,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":89,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":90,"context_line":"                          alt_user.shares_v2_client.update_all_metadata,"},{"line_number":91,"context_line":"                          export_location[\"id\"], md,"},{"line_number":92,"context_line":"                          resource\u003d\"export_location\","},{"line_number":93,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"a7c3b945_e61ac6d8","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":72},"in_reply_to":"8c879bf4_2284cbd0","updated":"2024-09-26 20:42:35.000000000","message":"I will freely admit to being entirely confused by class inheritances as it relates to projects and clients, so lets try it with user_project being from alt_share_v2_client instead.","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                           .list_share_export_locations("},{"line_number":88,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":89,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":90,"context_line":"                          alt_user.shares_v2_client.update_all_metadata,"},{"line_number":91,"context_line":"                          export_location[\"id\"], md,"},{"line_number":92,"context_line":"                          resource\u003d\"export_location\","},{"line_number":93,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"edc0afc7_2c597930","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":72},"in_reply_to":"a7c3b945_e61ac6d8","updated":"2024-10-01 23:37:39.000000000","message":"Use \"alt_share_v2_client\" directly; that\u0027s already got a user called \"alt_demo\".. no need to create one more explicitly","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                           .list_share_export_locations("},{"line_number":88,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":89,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":90,"context_line":"                          alt_user.shares_v2_client.update_all_metadata,"},{"line_number":91,"context_line":"                          export_location[\"id\"], md,"},{"line_number":92,"context_line":"                          resource\u003d\"export_location\","},{"line_number":93,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"15380023_a4f7cc21","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":72},"in_reply_to":"edc0afc7_2c597930","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8d67bd35d0ec4f9bb13cd69837611a03247e406","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":102,"context_line":"                           .list_share_export_locations("},{"line_number":103,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":104,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":105,"context_line":"                          alt_user.shares_v2_client.delete_metadata,"},{"line_number":106,"context_line":"                          export_location[\"id\"], \"key1\","},{"line_number":107,"context_line":"                          resource\u003d\"export_location\","}],"source_content_type":"text/x-python","patch_set":13,"id":"cf721eeb_696569b3","line":104,"range":{"start_line":104,"start_character":34,"end_line":104,"end_character":43},"updated":"2024-09-26 18:29:54.000000000","message":"Api is raising not found instead:\n```\n  ...\n    return self.request(\u0027DELETE\u0027, url, extra_headers, headers, body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 762, in request\n    self._error_checker(resp, resp_body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 872, in _error_checker\n    raise exceptions.NotFound(resp_body, resp\u003dresp)\ntempest.lib.exceptions.NotFound: Object not found\nDetails: {\u0027code\u0027: 404, \u0027message\u0027: \u0027MetadataItemNotFound: Metadata item is not found.\u0027}\n```\nIt is confusing though, but I think it gets into that discussion that if we raise forbidden, someone will know that the resource exists, so that might be why not found is being raised.","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"d1e26a034c9256cc4252a778c9c08a1e3a7658a2","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":102,"context_line":"                           .list_share_export_locations("},{"line_number":103,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":104,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":105,"context_line":"                          alt_user.shares_v2_client.delete_metadata,"},{"line_number":106,"context_line":"                          export_location[\"id\"], \"key1\","},{"line_number":107,"context_line":"                          resource\u003d\"export_location\","}],"source_content_type":"text/x-python","patch_set":13,"id":"ef3000c1_53d2aedf","line":104,"range":{"start_line":104,"start_character":34,"end_line":104,"end_character":43},"in_reply_to":"cf721eeb_696569b3","updated":"2024-09-26 20:42:35.000000000","message":"given its using a different project_id, notfound seems correct.","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8d67bd35d0ec4f9bb13cd69837611a03247e406","unresolved":true,"context_lines":[{"line_number":117,"context_line":"                           .list_share_export_locations("},{"line_number":118,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":119,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":120,"context_line":"                          self.alt_shares_v2_client.update_all_metadata,"},{"line_number":121,"context_line":"                          export_location[\"id\"], md,"},{"line_number":122,"context_line":"                          resource\u003d\"export_location\","},{"line_number":123,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f8cd2d3_5e347c28","line":120,"range":{"start_line":120,"start_character":26,"end_line":120,"end_character":72},"updated":"2024-09-26 18:29:54.000000000","message":"this is actually going through:\n```\ntesttools.matchers._impl.MismatchError: \u003cbound method SharesV2Client.update_all_metadata of \u003cmanila_tempest_tests.services.share.v2.json.shares_client.SharesV2Client object at 0x7f6f34d70730\u003e\u003e returned {\u0027metadata\u0027: {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027, \u0027preferred\u0027: \u00270\u0027}}\n```\nand it might feel a bit concerning. Maybe we can try to reproduce it locally? The policy seems correct, so it might be related to the credentials in this test","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"d1e26a034c9256cc4252a778c9c08a1e3a7658a2","unresolved":true,"context_lines":[{"line_number":117,"context_line":"                           .list_share_export_locations("},{"line_number":118,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":119,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":120,"context_line":"                          self.alt_shares_v2_client.update_all_metadata,"},{"line_number":121,"context_line":"                          export_location[\"id\"], md,"},{"line_number":122,"context_line":"                          resource\u003d\"export_location\","},{"line_number":123,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1cd57758_d83792ea","line":120,"range":{"start_line":120,"start_character":26,"end_line":120,"end_character":72},"in_reply_to":"5f8cd2d3_5e347c28","updated":"2024-09-26 20:42:35.000000000","message":"investigating...","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8d67bd35d0ec4f9bb13cd69837611a03247e406","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":145,"context_line":"                           .list_share_export_locations("},{"line_number":146,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":147,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":148,"context_line":"                          self.shares_v2_client.set_metadata,"},{"line_number":149,"context_line":"                          export_location[\"id\"], {\"\": \"value\"},"},{"line_number":150,"context_line":"                          resource\u003d\"export_location\","}],"source_content_type":"text/x-python","patch_set":13,"id":"c4788b1d_a065c692","line":147,"range":{"start_line":147,"start_character":34,"end_line":147,"end_character":43},"updated":"2024-09-26 18:29:54.000000000","message":"BadRequest","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"d1e26a034c9256cc4252a778c9c08a1e3a7658a2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":145,"context_line":"                           .list_share_export_locations("},{"line_number":146,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":147,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":148,"context_line":"                          self.shares_v2_client.set_metadata,"},{"line_number":149,"context_line":"                          export_location[\"id\"], {\"\": \"value\"},"},{"line_number":150,"context_line":"                          resource\u003d\"export_location\","}],"source_content_type":"text/x-python","patch_set":13,"id":"e10f5ca5_60007b4e","line":147,"range":{"start_line":147,"start_character":34,"end_line":147,"end_character":43},"in_reply_to":"c4788b1d_a065c692","updated":"2024-09-26 20:42:35.000000000","message":"Done","commit_id":"01366c28cfb08fbf2a269024d5bdc7659f307f13"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3a3274f1_f4ac2069","updated":"2024-10-01 23:37:39.000000000","message":"same comment as the other file; this needs to be outside the \"admin\" directory\n\nA good admin test would be to check if you can set the \"preferred\" key","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f0f62735_301faf57","in_reply_to":"3a3274f1_f4ac2069","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.idempotent_id(\"6f03d065-dd7c-48a5-91f2-04d36bddb24f\")"},{"line_number":59,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":60,"context_line":"    def test_try_set_metadata_to_unexisting_EL(self):"},{"line_number":61,"context_line":"        md \u003d {\"key1\": \"value1\", \"key2\": \"value2\", }"},{"line_number":62,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":63,"context_line":"                          self.shares_v2_client.set_metadata,"}],"source_content_type":"text/x-python","patch_set":15,"id":"e5802782_1476662c","line":60,"range":{"start_line":60,"start_character":33,"end_line":60,"end_character":43},"updated":"2024-10-01 23:37:39.000000000","message":"nonexistent?","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.idempotent_id(\"6f03d065-dd7c-48a5-91f2-04d36bddb24f\")"},{"line_number":59,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":60,"context_line":"    def test_try_set_metadata_to_unexisting_EL(self):"},{"line_number":61,"context_line":"        md \u003d {\"key1\": \"value1\", \"key2\": \"value2\", }"},{"line_number":62,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":63,"context_line":"                          self.shares_v2_client.set_metadata,"}],"source_content_type":"text/x-python","patch_set":15,"id":"819e538f_3ff4f40b","line":60,"range":{"start_line":60,"start_character":33,"end_line":60,"end_character":43},"in_reply_to":"e5802782_1476662c","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    @decorators.idempotent_id(\u00278b915b9c7ef54480bb0bc88598935e9c\u0027)"},{"line_number":97,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":98,"context_line":"    def test_try_delete_metadata_with_wrong_project(self):"},{"line_number":99,"context_line":"        alt_user \u003d self.create_user_and_get_client(project\u003dself.user_project)"},{"line_number":100,"context_line":"        # get export location"},{"line_number":101,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":102,"context_line":"                           .list_share_export_locations("}],"source_content_type":"text/x-python","patch_set":15,"id":"867a1faf_3d13e30b","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":77},"updated":"2024-10-01 23:37:39.000000000","message":"same comment as above; use self.alt_shares_v2_client","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    @decorators.idempotent_id(\u00278b915b9c7ef54480bb0bc88598935e9c\u0027)"},{"line_number":97,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":98,"context_line":"    def test_try_delete_metadata_with_wrong_project(self):"},{"line_number":99,"context_line":"        alt_user \u003d self.create_user_and_get_client(project\u003dself.user_project)"},{"line_number":100,"context_line":"        # get export location"},{"line_number":101,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":102,"context_line":"                           .list_share_export_locations("}],"source_content_type":"text/x-python","patch_set":15,"id":"e5e569e6_45207a22","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":77},"in_reply_to":"867a1faf_3d13e30b","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":146,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":147,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":148,"context_line":"                          self.shares_v2_client.set_metadata,"},{"line_number":149,"context_line":"                          export_location[\"id\"], {\"\": \"value\"},"},{"line_number":150,"context_line":"                          resource\u003d\"export_location\","},{"line_number":151,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"},{"line_number":152,"context_line":"                          parent_id\u003dself.share_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"86c556fa_33bbb437","line":149,"range":{"start_line":149,"start_character":50,"end_line":149,"end_character":52},"updated":"2024-10-01 23:37:39.000000000","message":"\"preferred\" ?","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":147,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":148,"context_line":"                          self.shares_v2_client.set_metadata,"},{"line_number":149,"context_line":"                          export_location[\"id\"], {\"\": \"value\"},"},{"line_number":150,"context_line":"                          resource\u003d\"export_location\","},{"line_number":151,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"},{"line_number":152,"context_line":"                          parent_id\u003dself.share_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"60b57a85_6d1b2b6e","line":149,"range":{"start_line":149,"start_character":50,"end_line":149,"end_character":52},"in_reply_to":"86c556fa_33bbb437","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":174,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":175,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":176,"context_line":"                          self.shares_v2_client.update_all_metadata,"},{"line_number":177,"context_line":"                          export_location[\"id\"], {\"\": \"value\"},"},{"line_number":178,"context_line":"                          resource\u003d\"export_location\","},{"line_number":179,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"},{"line_number":180,"context_line":"                          parent_id\u003dself.share_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3c18a6e7_5822aa07","line":177,"range":{"start_line":177,"start_character":50,"end_line":177,"end_character":61},"updated":"2024-10-01 23:37:39.000000000","message":"empty value... `{\"key\": \"\"}` perhaps?","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":175,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":176,"context_line":"                          self.shares_v2_client.update_all_metadata,"},{"line_number":177,"context_line":"                          export_location[\"id\"], {\"\": \"value\"},"},{"line_number":178,"context_line":"                          resource\u003d\"export_location\","},{"line_number":179,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"},{"line_number":180,"context_line":"                          parent_id\u003dself.share_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"f56f64a0_c0006d9c","line":177,"range":{"start_line":177,"start_character":50,"end_line":177,"end_character":61},"in_reply_to":"3c18a6e7_5822aa07","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    @decorators.idempotent_id(\"5f7fda4d-4952-4e3d-a064-2e6cb6fddf23\")"},{"line_number":247,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":248,"context_line":"    def test_try_delete_unexisting_metadata(self):"},{"line_number":249,"context_line":"        # get export location"},{"line_number":250,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":251,"context_line":"                           .list_share_export_locations("}],"source_content_type":"text/x-python","patch_set":15,"id":"882de1f7_d5184743","line":248,"range":{"start_line":248,"start_character":24,"end_line":248,"end_character":34},"updated":"2024-10-01 23:37:39.000000000","message":"nonexistent","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    @decorators.idempotent_id(\"5f7fda4d-4952-4e3d-a064-2e6cb6fddf23\")"},{"line_number":247,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":248,"context_line":"    def test_try_delete_unexisting_metadata(self):"},{"line_number":249,"context_line":"        # get export location"},{"line_number":250,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":251,"context_line":"                           .list_share_export_locations("}],"source_content_type":"text/x-python","patch_set":15,"id":"51f430af_58b5f633","line":248,"range":{"start_line":248,"start_character":24,"end_line":248,"end_character":34},"in_reply_to":"882de1f7_d5184743","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46d61faeabcde7e9d50d09a160fe1502b6c65fae","unresolved":true,"context_lines":[{"line_number":258,"context_line":"                          parent_id\u003dself.share_id)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class ShareExportLocationMetadataRbacTest(rbac_base.ShareRbacBaseTests,"},{"line_number":262,"context_line":"                                          metaclass\u003dabc.ABCMeta):"},{"line_number":263,"context_line":"    @classmethod"},{"line_number":264,"context_line":"    def setup_clients(cls):"},{"line_number":265,"context_line":"        super(ShareExportLocationMetadataRbacTest, cls).setup_clients()"},{"line_number":266,"context_line":"        cls.persona \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":267,"context_line":"        cls.client \u003d cls.persona.share_v2.SharesV2Client()"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"class TestProjectReaderTestsNFS(ShareExportLocationMetadataRbacTest,"},{"line_number":271,"context_line":"                                base.BaseSharesTest):"},{"line_number":272,"context_line":"    credentials \u003d [\u0027project_reader\u0027]"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @decorators.idempotent_id(\u00271e038e6960484df0b79bc9e3e15e2056\u0027)"},{"line_number":275,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":276,"context_line":"    def test_try_metadata_update_with_project_reader(self):"},{"line_number":277,"context_line":"        md \u003d {\"key1\": \"value1\", \"key2\": \"value2\", }"},{"line_number":278,"context_line":"        # get export location"},{"line_number":279,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":280,"context_line":"                           .list_share_export_locations("},{"line_number":281,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":282,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":283,"context_line":"                          self.client.set_metadata,"},{"line_number":284,"context_line":"                          export_location[\"id\"], md,"},{"line_number":285,"context_line":"                          resource\u003d\"export_location\","},{"line_number":286,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"},{"line_number":287,"context_line":"                          parent_id\u003dself.share_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"0ab2971b_c6a52ecf","line":287,"range":{"start_line":261,"start_character":0,"end_line":287,"end_character":50},"updated":"2024-10-01 23:37:39.000000000","message":"these tests need to be in a separate module in a different path: `manila_tempest_plugin/tests/rbac`","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ed4e160524808ce5e4082a599ec40f5ec59ce97a","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                          parent_id\u003dself.share_id)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class ShareExportLocationMetadataRbacTest(rbac_base.ShareRbacBaseTests,"},{"line_number":262,"context_line":"                                          metaclass\u003dabc.ABCMeta):"},{"line_number":263,"context_line":"    @classmethod"},{"line_number":264,"context_line":"    def setup_clients(cls):"},{"line_number":265,"context_line":"        super(ShareExportLocationMetadataRbacTest, cls).setup_clients()"},{"line_number":266,"context_line":"        cls.persona \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":267,"context_line":"        cls.client \u003d cls.persona.share_v2.SharesV2Client()"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"class TestProjectReaderTestsNFS(ShareExportLocationMetadataRbacTest,"},{"line_number":271,"context_line":"                                base.BaseSharesTest):"},{"line_number":272,"context_line":"    credentials \u003d [\u0027project_reader\u0027]"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @decorators.idempotent_id(\u00271e038e6960484df0b79bc9e3e15e2056\u0027)"},{"line_number":275,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":276,"context_line":"    def test_try_metadata_update_with_project_reader(self):"},{"line_number":277,"context_line":"        md \u003d {\"key1\": \"value1\", \"key2\": \"value2\", }"},{"line_number":278,"context_line":"        # get export location"},{"line_number":279,"context_line":"        export_location \u003d (self.admin_shares_v2_client"},{"line_number":280,"context_line":"                           .list_share_export_locations("},{"line_number":281,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":282,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":283,"context_line":"                          self.client.set_metadata,"},{"line_number":284,"context_line":"                          export_location[\"id\"], md,"},{"line_number":285,"context_line":"                          resource\u003d\"export_location\","},{"line_number":286,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"},{"line_number":287,"context_line":"                          parent_id\u003dself.share_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"939ef890_04d6dab0","line":287,"range":{"start_line":261,"start_character":0,"end_line":287,"end_character":50},"in_reply_to":"0ab2971b_c6a52ecf","updated":"2024-10-11 16:48:26.000000000","message":"Done","commit_id":"8ae546265f84d705c59497ca8e62625d067adb69"}],"manila_tempest_tests/tests/api/test_export_locations_metadata.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9050a5dfcd9a4ecdd7197399b2179c226dee891f","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":120,"context_line":"        self.assertEqual(1, len(get_metadata))"},{"line_number":121,"context_line":"        pref \u003d {\"preferred\": \"1\"}"},{"line_number":122,"context_line":"        self.assertDictContainsSubset(pref, get_metadata)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @decorators.idempotent_id(\"00f8a0a3-5b66-455b-b701-8be0-7be08a4f\")"},{"line_number":125,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":23,"id":"6b810eae_8a24c9a4","line":122,"range":{"start_line":122,"start_character":13,"end_line":122,"end_character":37},"updated":"2025-01-24 20:48:46.000000000","message":"this method is mostly used in other components, but we don\u0027t have an implementation for it here. Maybe we can use:\nself.assertIn(\"preferred\", get_metadata.keys())","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"4ebdc6a162eeb9b33480ac90afd151f02365ab7a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":120,"context_line":"        self.assertEqual(1, len(get_metadata))"},{"line_number":121,"context_line":"        pref \u003d {\"preferred\": \"1\"}"},{"line_number":122,"context_line":"        self.assertDictContainsSubset(pref, get_metadata)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @decorators.idempotent_id(\"00f8a0a3-5b66-455b-b701-8be0-7be08a4f\")"},{"line_number":125,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":23,"id":"93db9918_1984d3e6","line":122,"range":{"start_line":122,"start_character":13,"end_line":122,"end_character":37},"in_reply_to":"6b810eae_8a24c9a4","updated":"2025-01-28 19:11:11.000000000","message":"Done","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9050a5dfcd9a4ecdd7197399b2179c226dee891f","unresolved":true,"context_lines":[{"line_number":173,"context_line":"            parent_id\u003dshare_id)"},{"line_number":174,"context_line":"        self.assertEqual(1, len(get_metadata))"},{"line_number":175,"context_line":"        pref \u003d {\"preferred\": \"1\"}"},{"line_number":176,"context_line":"        self.assertDictContainsSubset(pref, get_metadata)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @decorators.idempotent_id(\"27a12a0f-d136-4c2c-8975-0dcf8215221d\")"},{"line_number":179,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":23,"id":"84706848_f8ff22c3","line":176,"range":{"start_line":176,"start_character":13,"end_line":176,"end_character":37},"updated":"2025-01-24 20:48:46.000000000","message":"same as above","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"4ebdc6a162eeb9b33480ac90afd151f02365ab7a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            parent_id\u003dshare_id)"},{"line_number":174,"context_line":"        self.assertEqual(1, len(get_metadata))"},{"line_number":175,"context_line":"        pref \u003d {\"preferred\": \"1\"}"},{"line_number":176,"context_line":"        self.assertDictContainsSubset(pref, get_metadata)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @decorators.idempotent_id(\"27a12a0f-d136-4c2c-8975-0dcf8215221d\")"},{"line_number":179,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":23,"id":"2e2885a4_5b4335bc","line":176,"range":{"start_line":176,"start_character":13,"end_line":176,"end_character":37},"in_reply_to":"84706848_f8ff22c3","updated":"2025-01-28 19:11:11.000000000","message":"Done","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9050a5dfcd9a4ecdd7197399b2179c226dee891f","unresolved":true,"context_lines":[{"line_number":224,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":225,"context_line":"        self.assertEqual(1, len(get_metadata))"},{"line_number":226,"context_line":"        pref \u003d {\"preferred\": \"1\"}"},{"line_number":227,"context_line":"        self.assertDictContainsSubset(pref, get_metadata)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @decorators.idempotent_id(\"418effa1-5a95-468e-ab23-4dedb70ef967\")"},{"line_number":230,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":23,"id":"4b8d7d91_9f88185e","line":227,"range":{"start_line":227,"start_character":13,"end_line":227,"end_character":37},"updated":"2025-01-24 20:48:46.000000000","message":"same","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"4ebdc6a162eeb9b33480ac90afd151f02365ab7a","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":225,"context_line":"        self.assertEqual(1, len(get_metadata))"},{"line_number":226,"context_line":"        pref \u003d {\"preferred\": \"1\"}"},{"line_number":227,"context_line":"        self.assertDictContainsSubset(pref, get_metadata)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @decorators.idempotent_id(\"418effa1-5a95-468e-ab23-4dedb70ef967\")"},{"line_number":230,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":23,"id":"f2c6ea80_de987c16","line":227,"range":{"start_line":227,"start_character":13,"end_line":227,"end_character":37},"in_reply_to":"4b8d7d91_9f88185e","updated":"2025-01-28 19:11:11.000000000","message":"Done","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9050a5dfcd9a4ecdd7197399b2179c226dee891f","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            resource\u003d\"export_location\","},{"line_number":431,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":432,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":433,"context_line":"        self.assertEqual(data, body_get)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    @decorators.idempotent_id(\"5a08bcb9-7169-4fc6-92e6-86351c0975dc\")"},{"line_number":436,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5015b429_e21cc273","line":433,"range":{"start_line":433,"start_character":31,"end_line":433,"end_character":39},"updated":"2025-01-24 20:48:46.000000000","message":"preferred is always being returned as part of the response, so this dict should be updated.","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"4ebdc6a162eeb9b33480ac90afd151f02365ab7a","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            resource\u003d\"export_location\","},{"line_number":431,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":432,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":433,"context_line":"        self.assertEqual(data, body_get)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    @decorators.idempotent_id(\"5a08bcb9-7169-4fc6-92e6-86351c0975dc\")"},{"line_number":436,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":23,"id":"a064471e_36e91e61","line":433,"range":{"start_line":433,"start_character":31,"end_line":433,"end_character":39},"in_reply_to":"5015b429_e21cc273","updated":"2025-01-28 19:11:11.000000000","message":"Done","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9050a5dfcd9a4ecdd7197399b2179c226dee891f","unresolved":true,"context_lines":[{"line_number":455,"context_line":"            resource\u003d\"export_location\","},{"line_number":456,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":457,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":458,"context_line":"        self.assertEqual(data, body_get)"}],"source_content_type":"text/x-python","patch_set":23,"id":"f4fde32d_09337487","line":458,"range":{"start_line":458,"start_character":25,"end_line":458,"end_character":29},"updated":"2025-01-24 20:48:46.000000000","message":"preferred is always being returned as part of the response, so this dict should be updated.","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"4ebdc6a162eeb9b33480ac90afd151f02365ab7a","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            resource\u003d\"export_location\","},{"line_number":456,"context_line":"            parent_resource\u003d\u0027shares\u0027,"},{"line_number":457,"context_line":"            parent_id\u003dshare_id)[\u0027metadata\u0027]"},{"line_number":458,"context_line":"        self.assertEqual(data, body_get)"}],"source_content_type":"text/x-python","patch_set":23,"id":"61c92f01_fcfee853","line":458,"range":{"start_line":458,"start_character":25,"end_line":458,"end_character":29},"in_reply_to":"f4fde32d_09337487","updated":"2025-01-28 19:11:11.000000000","message":"Done","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"}],"manila_tempest_tests/tests/api/test_export_locations_metadata_negative.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9050a5dfcd9a4ecdd7197399b2179c226dee891f","unresolved":true,"context_lines":[{"line_number":83,"context_line":"                           .list_share_export_locations("},{"line_number":84,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":85,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":86,"context_line":"                          self.alt_shares_v2_client.update_all_metadata,"},{"line_number":87,"context_line":"                          export_location[\"id\"], md,"},{"line_number":88,"context_line":"                          resource\u003d\"export_location\","},{"line_number":89,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"36c38790_8ff02a6d","line":86,"range":{"start_line":86,"start_character":26,"end_line":86,"end_character":71},"updated":"2025-01-24 20:48:46.000000000","message":"somehow this is going through, maybe we need another client on this request","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9050a5dfcd9a4ecdd7197399b2179c226dee891f","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                           .list_share_export_locations("},{"line_number":113,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":114,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":115,"context_line":"                          self.alt_shares_v2_client.update_all_metadata,"},{"line_number":116,"context_line":"                          export_location[\"id\"], md,"},{"line_number":117,"context_line":"                          resource\u003d\"export_location\","},{"line_number":118,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"f61cd7f8_d987c3b5","line":115,"range":{"start_line":115,"start_character":26,"end_line":115,"end_character":72},"updated":"2025-01-24 20:48:46.000000000","message":"somehow this is going through, maybe we need another client on this request","commit_id":"5e6595e40334660b8181a7f9bc7b88a207289d9b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8743ea88bb58ce0a425275e49c4f54d2525d6f95","unresolved":true,"context_lines":[{"line_number":83,"context_line":"                           .list_share_export_locations("},{"line_number":84,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":85,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":86,"context_line":"                          self.admin_project_member_client.update_all_metadata,"},{"line_number":87,"context_line":"                          export_location[\"id\"], md,"},{"line_number":88,"context_line":"                          resource\u003d\"export_location\","},{"line_number":89,"context_line":"                          parent_resource\u003d\u0027shares\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"2cdbe95c_924ab21d","line":86,"range":{"start_line":86,"start_character":26,"end_line":86,"end_character":79},"updated":"2025-02-19 19:38:11.000000000","message":"cls.admin_project_member_client.shares_v2_client.update_all_metadata","commit_id":"ff7bff006e89f924f64515d2c5062693c5fb0cc9"}],"manila_tempest_tests/tests/rbac/test_export_location_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9bfa29faeb1b4d5fc61689929270ffb716277107","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        # get export location"},{"line_number":41,"context_line":"        export_location \u003d (self.shares_v2_client"},{"line_number":42,"context_line":"                           .list_share_export_locations("},{"line_number":43,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":44,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":45,"context_line":"                          self.client.set_metadata,"},{"line_number":46,"context_line":"                          export_location[\"id\"], md,"}],"source_content_type":"text/x-python","patch_set":26,"id":"f54c02b1_af669787","line":43,"range":{"start_line":43,"start_character":36,"end_line":43,"end_character":44},"updated":"2025-02-19 19:40:03.000000000","message":"This share needs to be created perhaps in a setup method using a member client","commit_id":"ff7bff006e89f924f64515d2c5062693c5fb0cc9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"81eab89a628f7e4b5beddc02ef950a24ad063070","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # get export location"},{"line_number":41,"context_line":"        export_location \u003d (self.shares_v2_client"},{"line_number":42,"context_line":"                           .list_share_export_locations("},{"line_number":43,"context_line":"                               self.share_id)[\u0027export_locations\u0027][0])"},{"line_number":44,"context_line":"        self.assertRaises(lib_exc.Forbidden,"},{"line_number":45,"context_line":"                          self.client.set_metadata,"},{"line_number":46,"context_line":"                          export_location[\"id\"], md,"}],"source_content_type":"text/x-python","patch_set":26,"id":"b0fd9bf1_b87f3fcb","line":43,"range":{"start_line":43,"start_character":36,"end_line":43,"end_character":44},"in_reply_to":"f54c02b1_af669787","updated":"2025-06-26 16:59:05.000000000","message":"Done","commit_id":"ff7bff006e89f924f64515d2c5062693c5fb0cc9"}]}