)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4bd84b2a375b409a4d5008a5698523b15b6bf0","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some drivers do not support looking up shares/snapshots by using"},{"line_number":10,"context_line":"their export paths. In such cases, the drivers will search for the"},{"line_number":11,"context_line":"shares by using their identificators in the storage back end, so"},{"line_number":12,"context_line":"to adapt to that scenario, this change:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- Introduces a new configuration option so that we can configure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2c6a1e7c_3cd38e49","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":36},"updated":"2024-09-25 22:44:37.000000000","message":"identifiers","commit_id":"e5dfb025b49ad82c067fb8373030e96624cc5c77"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"93f6c63f91a329c8079d0c38522df8ea49f99fff","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some drivers do not support looking up shares/snapshots by using"},{"line_number":10,"context_line":"their export paths. In such cases, the drivers will search for the"},{"line_number":11,"context_line":"shares by using their identificators in the storage back end, so"},{"line_number":12,"context_line":"to adapt to that scenario, this change:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- Introduces a new configuration option so that we can configure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"28bd75aa_59567637","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":36},"in_reply_to":"2c6a1e7c_3cd38e49","updated":"2024-10-01 14:14:58.000000000","message":"Done","commit_id":"e5dfb025b49ad82c067fb8373030e96624cc5c77"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e607c55df0903f026295d8c3b999828b71fbaa5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3703cb20_982e3e0d","updated":"2024-09-01 07:37:11.000000000","message":"Thanks Carlos,\nThis should also be updated:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/rbac/test_share_manage.py#L60","commit_id":"4b1efef898ffc71ed91123abf8ba86e73fd51944"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2dff90a6042dddbb8a67b1f74943bcc0a0a9adcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"079a0bb9_ff17e93f","updated":"2024-08-30 13:39:12.000000000","message":"Thanks for the review, please take a look at the changes and replies inline :)","commit_id":"4b1efef898ffc71ed91123abf8ba86e73fd51944"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4bd84b2a375b409a4d5008a5698523b15b6bf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"407b8b76_6a756a40","updated":"2024-09-25 22:44:37.000000000","message":"Some minor comments inline","commit_id":"e5dfb025b49ad82c067fb8373030e96624cc5c77"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d78aec9c299f37ebfefbf5e628d666f100647838","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46f4bb65_b4da4335","updated":"2024-09-17 21:20:42.000000000","message":"Updated an RBAC test, as suggested by @lkuchlan@redhat.com\nPlease take a look at the most recent PS :)","commit_id":"e5dfb025b49ad82c067fb8373030e96624cc5c77"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"48218be8bd281e1b4b99535c4b42c237347e8c18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b48d2f28_90443fde","updated":"2024-11-22 20:10:42.000000000","message":"Looks good, thanks Carlos. +2 vote pending further debug in live env.","commit_id":"e43fdbf222edd6d6fbfb8f00bc13fdaa68ad7d85"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4841a8efe9f2feaeb5ef7f1148fccafe5453f68d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9aabd96e_da912f78","updated":"2024-10-02 00:01:54.000000000","message":"Looks good; thanks Carlos.. would like to see these changes take effect in https://review.opendev.org/c/openstack/manila-tempest-plugin/+/924774","commit_id":"e43fdbf222edd6d6fbfb8f00bc13fdaa68ad7d85"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3e8f5214c8adf2e6f5d3c6388e56c19e794aa8dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"01ffe086_f64f5416","updated":"2026-02-10 19:15:26.000000000","message":"recheck\n\nsetuptools has been pinned in devstack\u0027s stable branches. lets see if this works now","commit_id":"0e3e743a4c06e72da5f60ced4a4d70119f5b99df"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"420aae0ba9f18731ec8ad0c191ee61098038d596","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"28ce730d_73984a6f","updated":"2026-02-23 20:53:16.000000000","message":"I suspect the tox issue maybe related to https://review.opendev.org/c/openstack/tempest/+/935737 / https://bugs.launchpad.net/cinder/+bug/2089051","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bbe9a79bce982b1771f9267ada672a1f011b4cbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"35caa1b9_17efba1e","updated":"2026-02-11 20:31:49.000000000","message":"recheck\nJust pushed a new version of the previous PS","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4f0fd82f817b309da5a4e8c0bdecb9156afead42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"28d048f8_33304848","updated":"2026-02-23 15:59:19.000000000","message":"recheck\npkg_resources issue has been fixed","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c5152ed496fab1efa2e4b4e9af32fabeb5ff9840","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ccb61365_2759ff71","in_reply_to":"117a4751_5a0241bd","updated":"2026-02-24 15:12:40.000000000","message":"Ack, thanks for the update, Luigi!","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"be6a1c28eb21c7c4f1473a5f2d7013c79197e21e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f6be2972_7e9f2745","in_reply_to":"28ce730d_73984a6f","updated":"2026-02-24 13:37:33.000000000","message":"Agreed! Thanks for the pointer - I think that issue should be fixed at this point, as the change has merged. I\u0027ll upload a new PS addressing the comments in the change and will see how it goes.\nThank you, Luigi!","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"564c692327a3c0850b32764c7f957c256db481ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"117a4751_5a0241bd","in_reply_to":"f6be2972_7e9f2745","updated":"2026-02-24 14:15:44.000000000","message":"So I was wrong, the issue is a bit more subtle, but it is still in tempest. Basically we need a new version of tempest which includes https://review.opendev.org/c/openstack/tempest/+/947714","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9488ccc8adefee6dad08abd534f06c34fbcc0e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b0a46ef3_e2cc2391","updated":"2026-03-16 18:48:48.000000000","message":"Good stuff..","commit_id":"aad355898cf64c6bbac88f32eafc315ff4ff0127"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"694c5f914834eac3d36e63cf93855cb24d3805cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b95c8f50_e901ce42","updated":"2026-02-24 21:39:21.000000000","message":"LGTM, thank you..","commit_id":"aad355898cf64c6bbac88f32eafc315ff4ff0127"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"425c85b81db962e1902a5472498fe970fc7d2e38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"93dbc659_446a9884","updated":"2026-02-25 15:28:26.000000000","message":"Looks good, thanks!","commit_id":"aad355898cf64c6bbac88f32eafc315ff4ff0127"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7f05ce602178389c980f0def8eb30aaf43cad3cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1819ad70_548ef89d","updated":"2026-03-16 17:05:25.000000000","message":"The changes this depends on are merged, can we get this in and include the testing for manage/unmanage from now on? :)","commit_id":"aad355898cf64c6bbac88f32eafc315ff4ff0127"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"47f0340d53e9078a95e38cbf0eb5dc054685edeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6b15f788_64d12450","updated":"2026-02-26 21:54:26.000000000","message":"recheck\nTempest had a new release, this should be fixed","commit_id":"aad355898cf64c6bbac88f32eafc315ff4ff0127"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c85a8f217c17a9f34af4492f4c995cedf41c9d4b","unresolved":true,"context_lines":[{"line_number":371,"context_line":"    cfg.DictOpt(\"driver_assisted_backup_test_driver_options\","},{"line_number":372,"context_line":"                default\u003d{\u0027dummy\u0027: True},"},{"line_number":373,"context_line":"                help\u003d\"Share backup driver options specified as dict.\"),"},{"line_number":374,"context_line":"    cfg.BoolOpt(\"use_share_instance_id_instead_of_location_on_manage\","},{"line_number":375,"context_line":"                default\u003dFalse,"},{"line_number":376,"context_line":"                help\u003d\"Whether the driver should filter shares using the \""},{"line_number":377,"context_line":"                     \"export location or the previous share identificator \""}],"source_content_type":"text/x-python","patch_set":1,"id":"cdea7e8a_60df5e3d","line":374,"range":{"start_line":374,"start_character":17,"end_line":374,"end_character":68},"updated":"2024-08-30 05:34:37.000000000","message":"\"manage_with_share_or_snapshot_id\" perhaps? because you\u0027re using this for both shares and snapshots\n\nignore the \"instance\" detail; i think this issue with be with Ceph alone..","commit_id":"59b57f825b192ac4e44889222646fcc786ccbf0a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2dff90a6042dddbb8a67b1f74943bcc0a0a9adcf","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    cfg.DictOpt(\"driver_assisted_backup_test_driver_options\","},{"line_number":372,"context_line":"                default\u003d{\u0027dummy\u0027: True},"},{"line_number":373,"context_line":"                help\u003d\"Share backup driver options specified as dict.\"),"},{"line_number":374,"context_line":"    cfg.BoolOpt(\"use_share_instance_id_instead_of_location_on_manage\","},{"line_number":375,"context_line":"                default\u003dFalse,"},{"line_number":376,"context_line":"                help\u003d\"Whether the driver should filter shares using the \""},{"line_number":377,"context_line":"                     \"export location or the previous share identificator \""}],"source_content_type":"text/x-python","patch_set":1,"id":"539437ea_f6c7dc49","line":374,"range":{"start_line":374,"start_character":17,"end_line":374,"end_character":68},"in_reply_to":"cdea7e8a_60df5e3d","updated":"2024-08-30 13:39:12.000000000","message":"Done","commit_id":"59b57f825b192ac4e44889222646fcc786ccbf0a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c85a8f217c17a9f34af4492f4c995cedf41c9d4b","unresolved":true,"context_lines":[{"line_number":374,"context_line":"    cfg.BoolOpt(\"use_share_instance_id_instead_of_location_on_manage\","},{"line_number":375,"context_line":"                default\u003dFalse,"},{"line_number":376,"context_line":"                help\u003d\"Whether the driver should filter shares using the \""},{"line_number":377,"context_line":"                     \"export location or the previous share identificator \""},{"line_number":378,"context_line":"                     \"during the manage operation.\"),"},{"line_number":379,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"696e3d20_8cb2597c","line":377,"range":{"start_line":377,"start_character":60,"end_line":377,"end_character":73},"updated":"2024-08-30 05:34:37.000000000","message":"identifier","commit_id":"59b57f825b192ac4e44889222646fcc786ccbf0a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2dff90a6042dddbb8a67b1f74943bcc0a0a9adcf","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    cfg.BoolOpt(\"use_share_instance_id_instead_of_location_on_manage\","},{"line_number":375,"context_line":"                default\u003dFalse,"},{"line_number":376,"context_line":"                help\u003d\"Whether the driver should filter shares using the \""},{"line_number":377,"context_line":"                     \"export location or the previous share identificator \""},{"line_number":378,"context_line":"                     \"during the manage operation.\"),"},{"line_number":379,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9843e916_80cd80b3","line":377,"range":{"start_line":377,"start_character":60,"end_line":377,"end_character":73},"in_reply_to":"696e3d20_8cb2597c","updated":"2024-08-30 13:39:12.000000000","message":"Done","commit_id":"59b57f825b192ac4e44889222646fcc786ccbf0a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4bd84b2a375b409a4d5008a5698523b15b6bf0","unresolved":true,"context_lines":[{"line_number":373,"context_line":"                help\u003d\"Share backup driver options specified as dict.\"),"},{"line_number":374,"context_line":"    cfg.BoolOpt(\"manage_with_share_or_snapshot_id\","},{"line_number":375,"context_line":"                default\u003dFalse,"},{"line_number":376,"context_line":"                help\u003d\"Whether the driver should filter shares using the \""},{"line_number":377,"context_line":"                     \"export location or the previous share identifier \""},{"line_number":378,"context_line":"                     \"during the manage operation.\"),"},{"line_number":379,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"89a57595_74076c33","line":378,"range":{"start_line":376,"start_character":22,"end_line":378,"end_character":50},"updated":"2024-09-25 22:44:37.000000000","message":"```suggestion\n                help\u003d\"Whether the driver should find shares/snapshots using \"\n                     \"their previous identifier (share or snapshot instance ID) \"\n                     \"during the manage operation.\"),\n```","commit_id":"e5dfb025b49ad82c067fb8373030e96624cc5c77"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"93f6c63f91a329c8079d0c38522df8ea49f99fff","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                help\u003d\"Share backup driver options specified as dict.\"),"},{"line_number":374,"context_line":"    cfg.BoolOpt(\"manage_with_share_or_snapshot_id\","},{"line_number":375,"context_line":"                default\u003dFalse,"},{"line_number":376,"context_line":"                help\u003d\"Whether the driver should filter shares using the \""},{"line_number":377,"context_line":"                     \"export location or the previous share identifier \""},{"line_number":378,"context_line":"                     \"during the manage operation.\"),"},{"line_number":379,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"05268cc8_72219119","line":378,"range":{"start_line":376,"start_character":22,"end_line":378,"end_character":50},"in_reply_to":"89a57595_74076c33","updated":"2024-10-01 14:14:58.000000000","message":"Done","commit_id":"e5dfb025b49ad82c067fb8373030e96624cc5c77"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"48218be8bd281e1b4b99535c4b42c237347e8c18","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"26aad6c7_a013bb85","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":30},"updated":"2024-11-22 20:10:42.000000000","message":"Pls update","commit_id":"e43fdbf222edd6d6fbfb8f00bc13fdaa68ad7d85"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4f0fd82f817b309da5a4e8c0bdecb9156afead42","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"855436b5_d32b1e10","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":30},"in_reply_to":"26aad6c7_a013bb85","updated":"2026-02-23 15:59:19.000000000","message":"Done","commit_id":"e43fdbf222edd6d6fbfb8f00bc13fdaa68ad7d85"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"48218be8bd281e1b4b99535c4b42c237347e8c18","unresolved":true,"context_lines":[{"line_number":373,"context_line":"                help\u003d\"Share backup driver options specified as dict.\"),"},{"line_number":374,"context_line":"    cfg.BoolOpt(\"manage_with_share_or_snapshot_id\","},{"line_number":375,"context_line":"                default\u003dFalse,"},{"line_number":376,"context_line":"                help\u003d\"Whether the driver should find shares/snapshots using \""},{"line_number":377,"context_line":"                     \"their previous identifier (share or snapshot instance \""},{"line_number":378,"context_line":"                     \"ID) during the manage operation.\"),"},{"line_number":379,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"45dd3e94_a75c3098","line":376,"updated":"2024-11-22 20:10:42.000000000","message":"Consider adding \"Set, Configure or alike\"","commit_id":"e43fdbf222edd6d6fbfb8f00bc13fdaa68ad7d85"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6cb5c27a2fa186dc949a3703e7a025f7d496c0b8","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                help\u003d\"Share backup driver options specified as dict.\"),"},{"line_number":374,"context_line":"    cfg.BoolOpt(\"manage_with_share_or_snapshot_id\","},{"line_number":375,"context_line":"                default\u003dFalse,"},{"line_number":376,"context_line":"                help\u003d\"Whether the driver should find shares/snapshots using \""},{"line_number":377,"context_line":"                     \"their previous identifier (share or snapshot instance \""},{"line_number":378,"context_line":"                     \"ID) during the manage operation.\"),"},{"line_number":379,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dc445bc2_752e3ef3","line":376,"in_reply_to":"45dd3e94_a75c3098","updated":"2026-02-06 16:21:29.000000000","message":"I think we\u0027re going for a lookup here, so I\u0027ll try rewording it in a different way","commit_id":"e43fdbf222edd6d6fbfb8f00bc13fdaa68ad7d85"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9c02e04845567048fe835a0d3770b3766feb69a","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                help\u003d\"Enable or disable share encryption tests.\"),"},{"line_number":397,"context_line":"    cfg.BoolOpt(\"manage_with_share_or_snapshot_id\","},{"line_number":398,"context_line":"                default\u003dFalse,"},{"line_number":399,"context_line":"                help\u003d\"Whether the driver should lookup shares/snapshots using \""},{"line_number":400,"context_line":"                     \"their previous identifier (share or snapshot instance \""},{"line_number":401,"context_line":"                     \"ID) during the manage operation.\"),"},{"line_number":402,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"d4cc8f56_dba301fc","line":399,"updated":"2026-02-23 22:51:17.000000000","message":"The help text describes driver behavior (\"Whether the driver\nshould lookup...\") but this is a tempest config option. Consider\nrewording from the test perspective, e.g., \"When True, manage\ntests will use the share instance ID or snapshot ID as the\nexport path/provider location instead of the actual values.\"","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d6ef54ffb90affa26a04dc1d12dc005239410f43","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                help\u003d\"Enable or disable share encryption tests.\"),"},{"line_number":397,"context_line":"    cfg.BoolOpt(\"manage_with_share_or_snapshot_id\","},{"line_number":398,"context_line":"                default\u003dFalse,"},{"line_number":399,"context_line":"                help\u003d\"Whether the driver should lookup shares/snapshots using \""},{"line_number":400,"context_line":"                     \"their previous identifier (share or snapshot instance \""},{"line_number":401,"context_line":"                     \"ID) during the manage operation.\"),"},{"line_number":402,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"b5dc2578_b7830c2f","line":399,"in_reply_to":"d4cc8f56_dba301fc","updated":"2026-02-24 14:43:07.000000000","message":"Done","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"}],"manila_tempest_tests/tests/api/admin/test_share_manage.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c85a8f217c17a9f34af4492f4c995cedf41c9d4b","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            \u0027version\u0027: version,"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        if CONF.share.use_share_instance_id_instead_of_location_on_manage:"},{"line_number":103,"context_line":"            manage_params[\u0027export_path\u0027] \u003d share[\u0027instances\u0027][0][\u0027id\u0027]"},{"line_number":104,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":105,"context_line":"            manage_params[\u0027share_server_id\u0027] \u003d share[\u0027share_server_id\u0027]"},{"line_number":106,"context_line":"        managed_share \u003d self.shares_v2_client.manage_share("}],"source_content_type":"text/x-python","patch_set":1,"id":"cc70b524_948f2c21","line":103,"range":{"start_line":103,"start_character":43,"end_line":103,"end_character":61},"updated":"2024-08-30 05:34:37.000000000","message":"the share obj doesn\u0027t return its instances like this.. \nSee lines 82-84.. \n\n/me how is this working?","commit_id":"59b57f825b192ac4e44889222646fcc786ccbf0a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2dff90a6042dddbb8a67b1f74943bcc0a0a9adcf","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            \u0027version\u0027: version,"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        if CONF.share.use_share_instance_id_instead_of_location_on_manage:"},{"line_number":103,"context_line":"            manage_params[\u0027export_path\u0027] \u003d share[\u0027instances\u0027][0][\u0027id\u0027]"},{"line_number":104,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":105,"context_line":"            manage_params[\u0027share_server_id\u0027] \u003d share[\u0027share_server_id\u0027]"},{"line_number":106,"context_line":"        managed_share \u003d self.shares_v2_client.manage_share("}],"source_content_type":"text/x-python","patch_set":1,"id":"306b3ec9_f6f8525d","line":103,"range":{"start_line":103,"start_character":43,"end_line":103,"end_character":61},"in_reply_to":"cc70b524_948f2c21","updated":"2024-08-30 13:39:12.000000000","message":"yes, normally it would not, but it is because of the modifications I did here: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/926097/1/manila_tempest_tests/tests/api/base.py#1154\nso now whenever we call _create_share_for_manage in the base method, we are also doing an additional call to get the shares\u0027 instances and populating the share to make it easier for using those values later on.","commit_id":"59b57f825b192ac4e44889222646fcc786ccbf0a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e607c55df0903f026295d8c3b999828b71fbaa5e","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            \u0027version\u0027: version,"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        if CONF.share.manage_with_share_or_snapshot_id:"},{"line_number":103,"context_line":"            manage_params[\u0027export_path\u0027] \u003d share[\u0027instances\u0027][0][\u0027id\u0027]"},{"line_number":104,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":105,"context_line":"            manage_params[\u0027share_server_id\u0027] \u003d share[\u0027share_server_id\u0027]"},{"line_number":106,"context_line":"        managed_share \u003d self.shares_v2_client.manage_share("}],"source_content_type":"text/x-python","patch_set":2,"id":"e830ce2b_6e157428","line":103,"updated":"2024-09-01 07:37:11.000000000","message":"I\u0027m not comfortable with this. The key suggests that it\u0027s an export location, but it\u0027s actually the ID of an instance. I believe this requires a change in Manila. We should consider adding a new parameter to the body of the request or perhaps renaming the export_location key to something more general, like identifier. However, I don\u0027t want to cause any delays, so maybe we could add a comment for now and make the change later ?","commit_id":"4b1efef898ffc71ed91123abf8ba86e73fd51944"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4bd84b2a375b409a4d5008a5698523b15b6bf0","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            \u0027version\u0027: version,"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        if CONF.share.manage_with_share_or_snapshot_id:"},{"line_number":103,"context_line":"            manage_params[\u0027export_path\u0027] \u003d share[\u0027instances\u0027][0][\u0027id\u0027]"},{"line_number":104,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":105,"context_line":"            manage_params[\u0027share_server_id\u0027] \u003d share[\u0027share_server_id\u0027]"},{"line_number":106,"context_line":"        managed_share \u003d self.shares_v2_client.manage_share("}],"source_content_type":"text/x-python","patch_set":2,"id":"1e00ef59_ebc7ce85","line":103,"in_reply_to":"dff531be_269cc2c2","updated":"2024-09-25 22:44:37.000000000","message":"I think we can alias the parameter in the API and call it \"identifier\".. for now a docs update is at least necessary; Since this is an administrator API, we can accept this sub optimal UX :( \n\nChanging the API will mean an API version bump; but the CephFS manage/unmanage feature has merged already - so, presumably if we write the documentation well, Administrators may end up using it in the desired way, and accept the confusing UX where \"export_path\" really means \"identifier\"","commit_id":"4b1efef898ffc71ed91123abf8ba86e73fd51944"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9ee957dc0801499ca168b486e5f689af7551ebca","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            \u0027version\u0027: version,"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        if CONF.share.manage_with_share_or_snapshot_id:"},{"line_number":103,"context_line":"            manage_params[\u0027export_path\u0027] \u003d share[\u0027instances\u0027][0][\u0027id\u0027]"},{"line_number":104,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":105,"context_line":"            manage_params[\u0027share_server_id\u0027] \u003d share[\u0027share_server_id\u0027]"},{"line_number":106,"context_line":"        managed_share \u003d self.shares_v2_client.manage_share("}],"source_content_type":"text/x-python","patch_set":2,"id":"dff531be_269cc2c2","line":103,"in_reply_to":"e830ce2b_6e157428","updated":"2024-09-12 21:22:11.000000000","message":"Yeah, I\u0027m not very comfortable with it as well. This can be misleading to the people that are attempting to manage a share. However, when we decided to do it like this was mostly because there is a chance that some drivers don\u0027t support looking up a share using their export paths for it (as it is the case with the CephFS drivers), so instead, we\u0027ll naturally specify an identifier which the backend can use internally to look up the share. We can think of making API updates, yes, but renaming the parameter would mean a lot of drivers being impacted at the moment, as all of them until this release were using the export paths :/","commit_id":"4b1efef898ffc71ed91123abf8ba86e73fd51944"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9c02e04845567048fe835a0d3770b3766feb69a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \u0027is_public\u0027: is_public,"},{"line_number":100,"context_line":"            \u0027version\u0027: version,"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        if CONF.share.manage_with_share_or_snapshot_id:"},{"line_number":103,"context_line":"            manage_params[\u0027export_path\u0027] \u003d share[\u0027instances\u0027][0][\u0027id\u0027]"},{"line_number":104,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":105,"context_line":"            manage_params[\u0027share_server_id\u0027] \u003d share[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"5850ca94_0ab4f576","line":102,"updated":"2026-02-23 22:51:17.000000000","message":"This is just a nit, but, it feels like you could move the export path\ninitialization down here in the same conditional.\n\"else: \u003cget export path from first export location\u003e\". Just makes it more\nreadable","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d6ef54ffb90affa26a04dc1d12dc005239410f43","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \u0027is_public\u0027: is_public,"},{"line_number":100,"context_line":"            \u0027version\u0027: version,"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        if CONF.share.manage_with_share_or_snapshot_id:"},{"line_number":103,"context_line":"            manage_params[\u0027export_path\u0027] \u003d share[\u0027instances\u0027][0][\u0027id\u0027]"},{"line_number":104,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":105,"context_line":"            manage_params[\u0027share_server_id\u0027] \u003d share[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"d4114019_b0bd12f2","line":102,"in_reply_to":"5850ca94_0ab4f576","updated":"2026-02-24 14:43:07.000000000","message":"That validation is happening inside the \u003e\u003d 2.08 api version validation, but this should be harmless, as at that time we didn\u0027t have any drivers needing this behavior, so I moved it up a bit.","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e5a0e20024e03f8a49b277e7a56fa5edf074da97","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \u0027is_public\u0027: is_public,"},{"line_number":100,"context_line":"            \u0027version\u0027: version,"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        if CONF.share.manage_with_share_or_snapshot_id:"},{"line_number":103,"context_line":"            manage_params[\u0027export_path\u0027] \u003d share[\u0027instances\u0027][0][\u0027id\u0027]"},{"line_number":104,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":105,"context_line":"            manage_params[\u0027share_server_id\u0027] \u003d share[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"c339196d_6a9e3fd8","line":102,"in_reply_to":"d4114019_b0bd12f2","updated":"2026-02-24 15:15:38.000000000","message":"so it does cause an issue. As tempest is branchless and we don\u0027t have a microversion tied to the manage/unmanage work in cephfs, the request goes through (even on version 2.05), as the driver supports it - I will \"roll back\" but move the validation closer to the export path variable assignment for better readability as you suggested.","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"}],"manila_tempest_tests/tests/api/admin/test_share_manage_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9c02e04845567048fe835a0d3770b3766feb69a","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            self._delete_share_server_and_wait("},{"line_number":265,"context_line":"                managed_share[\u0027share_server_id\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _update_manage_export_path(self, manage_params, share):"},{"line_number":268,"context_line":"        if CONF.share.manage_with_share_or_snapshot_id:"},{"line_number":269,"context_line":"            manage_params[\u0027export_path\u0027] \u003d share[\u0027instances\u0027][0][\u0027id\u0027]"},{"line_number":270,"context_line":"        return manage_params"}],"source_content_type":"text/x-python","patch_set":12,"id":"5de0a683_4695f538","line":267,"updated":"2026-02-23 22:51:17.000000000","message":"nit: move this helper method near the other helpers\n(`_manage_share_and_wait`, `_get_manage_params_from_share`)\nat the top of the class.","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d6ef54ffb90affa26a04dc1d12dc005239410f43","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            self._delete_share_server_and_wait("},{"line_number":265,"context_line":"                managed_share[\u0027share_server_id\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _update_manage_export_path(self, manage_params, share):"},{"line_number":268,"context_line":"        if CONF.share.manage_with_share_or_snapshot_id:"},{"line_number":269,"context_line":"            manage_params[\u0027export_path\u0027] \u003d share[\u0027instances\u0027][0][\u0027id\u0027]"},{"line_number":270,"context_line":"        return manage_params"}],"source_content_type":"text/x-python","patch_set":12,"id":"fb43c772_77536342","line":267,"in_reply_to":"5de0a683_4695f538","updated":"2026-02-24 14:43:07.000000000","message":"Done","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"}],"manila_tempest_tests/tests/api/admin/test_snapshot_manage_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9c02e04845567048fe835a0d3770b3766feb69a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        )"},{"line_number":130,"context_line":"        self.shares_v2_client.unmanage_snapshot(invalid_snap[\u0027id\u0027])"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Manage it properly and delete"},{"line_number":133,"context_line":"        managed_snap \u003d self.shares_v2_client.manage_snapshot("},{"line_number":134,"context_line":"            self.share[\u0027id\u0027],"},{"line_number":135,"context_line":"            snap[\u0027provider_location\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"459c1956_bbaa3e5a","line":132,"updated":"2026-02-23 22:51:17.000000000","message":"`snap[\u0027provider_location\u0027]` needs an update, doesn\u0027t it? it should be\nsnapshot[\u0027id\u0027] if CONF.share.manage_with_share_or_snapshot_id is set to\nTrue","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d6ef54ffb90affa26a04dc1d12dc005239410f43","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        )"},{"line_number":130,"context_line":"        self.shares_v2_client.unmanage_snapshot(invalid_snap[\u0027id\u0027])"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Manage it properly and delete"},{"line_number":133,"context_line":"        managed_snap \u003d self.shares_v2_client.manage_snapshot("},{"line_number":134,"context_line":"            self.share[\u0027id\u0027],"},{"line_number":135,"context_line":"            snap[\u0027provider_location\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"2faec46d_76ac9959","line":132,"in_reply_to":"459c1956_bbaa3e5a","updated":"2026-02-24 14:43:07.000000000","message":"good catch :)","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9c02e04845567048fe835a0d3770b3766feb69a","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"                share[\"id\"])[\u0027export_locations\u0027]"},{"line_number":1180,"context_line":"            share[\"export_locations\"] \u003d el"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        share_instances \u003d ("},{"line_number":1183,"context_line":"            self.shares_v2_client.get_instances_of_share(share[\u0027id\u0027])"},{"line_number":1184,"context_line":"        )[\u0027share_instances\u0027]"},{"line_number":1185,"context_line":"        share[\u0027instances\u0027] \u003d share_instances"}],"source_content_type":"text/x-python","patch_set":12,"id":"3bb97d7f_f270d19a","line":1182,"updated":"2026-02-23 22:51:17.000000000","message":"nit: not a biggie, but this call `get_instances_of_share` is\nunnecessary if CONF.share.manage_with_share_or_snapshot_id is False\n(default)","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d6ef54ffb90affa26a04dc1d12dc005239410f43","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"                share[\"id\"])[\u0027export_locations\u0027]"},{"line_number":1180,"context_line":"            share[\"export_locations\"] \u003d el"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        share_instances \u003d ("},{"line_number":1183,"context_line":"            self.shares_v2_client.get_instances_of_share(share[\u0027id\u0027])"},{"line_number":1184,"context_line":"        )[\u0027share_instances\u0027]"},{"line_number":1185,"context_line":"        share[\u0027instances\u0027] \u003d share_instances"}],"source_content_type":"text/x-python","patch_set":12,"id":"e2c5c833_519e136e","line":1182,"in_reply_to":"3bb97d7f_f270d19a","updated":"2026-02-24 14:43:07.000000000","message":"Done :)","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"}],"manila_tempest_tests/tests/rbac/test_share_manage.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9c02e04845567048fe835a0d3770b3766feb69a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            self.admin_shares_v2_client.wait_for_resource_deletion("},{"line_number":68,"context_line":"                share_id\u003dshare_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if CONF.share.manage_with_share_or_snapshot_id:"},{"line_number":71,"context_line":"            share_instances \u003d ("},{"line_number":72,"context_line":"                self.admin_shares_v2_client.get_instances_of_share("},{"line_number":73,"context_line":"                    share_info[\"id\"])[\u0027share_instances\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3199786c_67e845bf","line":70,"updated":"2026-02-23 22:51:17.000000000","message":"You need to parse share instances before the unmanage handling\nabove. If someone were to reuse this method along with unmanaging,\nthis code will result in 404.","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d6ef54ffb90affa26a04dc1d12dc005239410f43","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            self.admin_shares_v2_client.wait_for_resource_deletion("},{"line_number":68,"context_line":"                share_id\u003dshare_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if CONF.share.manage_with_share_or_snapshot_id:"},{"line_number":71,"context_line":"            share_instances \u003d ("},{"line_number":72,"context_line":"                self.admin_shares_v2_client.get_instances_of_share("},{"line_number":73,"context_line":"                    share_info[\"id\"])[\u0027share_instances\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"60374457_b582d50c","line":70,"in_reply_to":"3199786c_67e845bf","updated":"2026-02-24 14:43:07.000000000","message":"Done","commit_id":"02dbb0fab28581968729534446b29d25fbf832b4"}]}