)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"ddd0692f386211853abe2e586b9f6c54bc3f03da","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This commit introduces a new configuration option, `nfs_version`,"},{"line_number":10,"context_line":"to allow specifying the NFS protocol version used when mounting NFS"},{"line_number":11,"context_line":"shares in Tempest tests. The option supports selecting specific"},{"line_number":12,"context_line":"versions, such as NFSv3 or NFSv4, enabling compatibility with environments"},{"line_number":13,"context_line":"where certain NFS versions are required."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- Option Name: `nfs_version`"},{"line_number":16,"context_line":"- Default: Blank (uses system default NFS version)"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf0e85c3_23a32081","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":0},"updated":"2024-11-11 11:50:11.000000000","message":"Pls revisit the line length","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"64050b7b29bb9a3b981b6bedb1a83b0148ad0100","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit introduces a new configuration option, `nfs_version`,"},{"line_number":10,"context_line":"to allow specifying the NFS protocol version used when mounting NFS"},{"line_number":11,"context_line":"shares in Tempest tests. The option supports selecting specific"},{"line_number":12,"context_line":"versions, such as NFSv3 or NFSv4, enabling compatibility with environments"},{"line_number":13,"context_line":"where certain NFS versions are required."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- Option Name: `nfs_version`"},{"line_number":16,"context_line":"- Default: Blank (uses system default NFS version)"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5b873ee5_cd2c81fb","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":0},"in_reply_to":"bf0e85c3_23a32081","updated":"2024-11-14 07:07:59.000000000","message":"Done","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"ddd0692f386211853abe2e586b9f6c54bc3f03da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"44acaff0_de2e18df","updated":"2024-11-11 11:50:11.000000000","message":"Looks good, thanks Liron. Pls see my comments.","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e5e993dc6d226f536a11e1aa7e921d65ea327fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ced8f874_534ff776","updated":"2024-11-11 19:17:58.000000000","message":"Thank you for working on this change, Liron! I have added some thoughts inline. Please take a look :)","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2a9c5868315d8511cf30b894c65b3ff072aadb2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb896c35_ce4c5f97","updated":"2024-11-14 07:00:52.000000000","message":"Thank you, Vida and Carlos, for your feedback!","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"58cb46855a3261361c0267aea3fb1ab2b3169c32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6d7b8579_42315128","updated":"2024-12-04 16:25:49.000000000","message":"LGTM, thank you Liron!","commit_id":"b5d6f2997f325bd3b59f663bd9def88f068d8f9b"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e5e993dc6d226f536a11e1aa7e921d65ea327fa","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    cfg.ListOpt(\"enable_ro_access_level_for_protocols\","},{"line_number":109,"context_line":"                default\u003d[\"nfs\", ],"},{"line_number":110,"context_line":"                help\u003d\"List of protocols to run tests with ro access level.\"),"},{"line_number":111,"context_line":"    cfg.StrOpt("},{"line_number":112,"context_line":"        \"nfs_version\","},{"line_number":113,"context_line":"        default\u003d\"\","},{"line_number":114,"context_line":"        help\u003d\"Specifies the NFS protocol version to use when mounting an NFS \""}],"source_content_type":"text/x-python","patch_set":3,"id":"fb0e42cd_0cd09ee7","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":2},"updated":"2024-11-11 19:17:58.000000000","message":"I\u0027m good with this option and I was also thinking this could be a list, which could be passed to a ddt and we\u0027d force the tests to be run in all of the protocols within that list. It would make the tests runs take longer when multiple versions are enabled, but I believe people that know it would know the tradeoffs.\n\nAnother thought is: when we want to run tests for multiple NFS versions, we will end up creating more jobs that inherit from the base job, in order to have multiple NFS versions being run at the same time. On the main upstream jobs, we currently don\u0027t have a lot of people asking that these tests are run, so this is likely not a problem for now.\n\nIf other reviewers are good with this nfs_versions config option as a string, I am also good with it.","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2a9c5868315d8511cf30b894c65b3ff072aadb2c","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    cfg.ListOpt(\"enable_ro_access_level_for_protocols\","},{"line_number":109,"context_line":"                default\u003d[\"nfs\", ],"},{"line_number":110,"context_line":"                help\u003d\"List of protocols to run tests with ro access level.\"),"},{"line_number":111,"context_line":"    cfg.StrOpt("},{"line_number":112,"context_line":"        \"nfs_version\","},{"line_number":113,"context_line":"        default\u003d\"\","},{"line_number":114,"context_line":"        help\u003d\"Specifies the NFS protocol version to use when mounting an NFS \""}],"source_content_type":"text/x-python","patch_set":3,"id":"6c86f229_5d42cd42","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":2},"in_reply_to":"fb0e42cd_0cd09ee7","updated":"2024-11-14 07:00:52.000000000","message":"I\u0027m also unsure which option is better.\nLet\u0027s see what others think.","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e5e993dc6d226f536a11e1aa7e921d65ea327fa","unresolved":true,"context_lines":[{"line_number":109,"context_line":"                default\u003d[\"nfs\", ],"},{"line_number":110,"context_line":"                help\u003d\"List of protocols to run tests with ro access level.\"),"},{"line_number":111,"context_line":"    cfg.StrOpt("},{"line_number":112,"context_line":"        \"nfs_version\","},{"line_number":113,"context_line":"        default\u003d\"\","},{"line_number":114,"context_line":"        help\u003d\"Specifies the NFS protocol version to use when mounting an NFS \""},{"line_number":115,"context_line":"             \"share. Set to \u00273\u0027 for NFSv3 or \u00274\u0027 for NFSv4. Leave blank to \""},{"line_number":116,"context_line":"             \"use the default version.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7c7e8c1f_eb0d4655","line":113,"range":{"start_line":112,"start_character":8,"end_line":113,"end_character":19},"updated":"2024-11-11 19:17:58.000000000","message":"```suggestion\n        \"nfs_version\",\n        choices\u003d[\"3\", \"4\", \"4.1\"],\n        default\u003d\"\",\n```","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2a9c5868315d8511cf30b894c65b3ff072aadb2c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                default\u003d[\"nfs\", ],"},{"line_number":110,"context_line":"                help\u003d\"List of protocols to run tests with ro access level.\"),"},{"line_number":111,"context_line":"    cfg.StrOpt("},{"line_number":112,"context_line":"        \"nfs_version\","},{"line_number":113,"context_line":"        default\u003d\"\","},{"line_number":114,"context_line":"        help\u003d\"Specifies the NFS protocol version to use when mounting an NFS \""},{"line_number":115,"context_line":"             \"share. Set to \u00273\u0027 for NFSv3 or \u00274\u0027 for NFSv4. Leave blank to \""},{"line_number":116,"context_line":"             \"use the default version.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"cf2fa675_72ce959a","line":113,"range":{"start_line":112,"start_character":8,"end_line":113,"end_character":19},"in_reply_to":"7c7e8c1f_eb0d4655","updated":"2024-11-14 07:00:52.000000000","message":"Done","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e5e993dc6d226f536a11e1aa7e921d65ea327fa","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        \"nfs_version\","},{"line_number":113,"context_line":"        default\u003d\"\","},{"line_number":114,"context_line":"        help\u003d\"Specifies the NFS protocol version to use when mounting an NFS \""},{"line_number":115,"context_line":"             \"share. Set to \u00273\u0027 for NFSv3 or \u00274\u0027 for NFSv4. Leave blank to \""},{"line_number":116,"context_line":"             \"use the default version.\"),"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    # Capabilities"}],"source_content_type":"text/x-python","patch_set":3,"id":"5d5d3986_7e966a34","line":116,"range":{"start_line":115,"start_character":21,"end_line":116,"end_character":39},"updated":"2024-11-11 19:17:58.000000000","message":"```suggestion\n             \"share. Set to \u00273\u0027 for NFSv3, and \u00274\u0027 or \u00274.1\u0027 for NFSv4. Leave \"\n             \"it blank to use the default version.\"),\n```","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2a9c5868315d8511cf30b894c65b3ff072aadb2c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        \"nfs_version\","},{"line_number":113,"context_line":"        default\u003d\"\","},{"line_number":114,"context_line":"        help\u003d\"Specifies the NFS protocol version to use when mounting an NFS \""},{"line_number":115,"context_line":"             \"share. Set to \u00273\u0027 for NFSv3 or \u00274\u0027 for NFSv4. Leave blank to \""},{"line_number":116,"context_line":"             \"use the default version.\"),"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    # Capabilities"}],"source_content_type":"text/x-python","patch_set":3,"id":"c5c51800_1169ae5c","line":116,"range":{"start_line":115,"start_character":21,"end_line":116,"end_character":39},"in_reply_to":"5d5d3986_7e966a34","updated":"2024-11-14 07:00:52.000000000","message":"Done","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"}],"manila_tempest_tests/tests/scenario/manager_share.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"ddd0692f386211853abe2e586b9f6c54bc3f03da","unresolved":true,"context_lines":[{"line_number":755,"context_line":"        version_option \u003d (f\"-o vers\u003d{CONF.share.nfs_version}\""},{"line_number":756,"context_line":"                          if CONF.share.nfs_version else \"\")"},{"line_number":757,"context_line":"        ssh_client.exec_command("},{"line_number":758,"context_line":"            \"sudo mount -vt nfs %s \\\"%s\\\" %s\" % ("},{"line_number":759,"context_line":"                version_option, location, target_dir)"},{"line_number":760,"context_line":"        )"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1260b1ac_2b4ee6a2","line":759,"range":{"start_line":758,"start_character":12,"end_line":759,"end_character":53},"updated":"2024-11-11 11:50:11.000000000","message":"Pls confirm the mount command option, per docs \"mount -t nfs4 \".","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e5e993dc6d226f536a11e1aa7e921d65ea327fa","unresolved":true,"context_lines":[{"line_number":755,"context_line":"        version_option \u003d (f\"-o vers\u003d{CONF.share.nfs_version}\""},{"line_number":756,"context_line":"                          if CONF.share.nfs_version else \"\")"},{"line_number":757,"context_line":"        ssh_client.exec_command("},{"line_number":758,"context_line":"            \"sudo mount -vt nfs %s \\\"%s\\\" %s\" % ("},{"line_number":759,"context_line":"                version_option, location, target_dir)"},{"line_number":760,"context_line":"        )"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ca58adda_dd182a00","line":759,"range":{"start_line":758,"start_character":12,"end_line":759,"end_character":52},"updated":"2024-11-11 19:17:58.000000000","message":"maybe we can turn this into an f string?","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e5e993dc6d226f536a11e1aa7e921d65ea327fa","unresolved":true,"context_lines":[{"line_number":755,"context_line":"        version_option \u003d (f\"-o vers\u003d{CONF.share.nfs_version}\""},{"line_number":756,"context_line":"                          if CONF.share.nfs_version else \"\")"},{"line_number":757,"context_line":"        ssh_client.exec_command("},{"line_number":758,"context_line":"            \"sudo mount -vt nfs %s \\\"%s\\\" %s\" % ("},{"line_number":759,"context_line":"                version_option, location, target_dir)"},{"line_number":760,"context_line":"        )"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f26d6dbf_fc330edc","line":759,"range":{"start_line":758,"start_character":12,"end_line":759,"end_character":53},"in_reply_to":"1260b1ac_2b4ee6a2","updated":"2024-11-11 19:17:58.000000000","message":"I believe it will work with the (-o) option too, and the -t flag is already applied, so maybe we are good?","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2a9c5868315d8511cf30b894c65b3ff072aadb2c","unresolved":true,"context_lines":[{"line_number":755,"context_line":"        version_option \u003d (f\"-o vers\u003d{CONF.share.nfs_version}\""},{"line_number":756,"context_line":"                          if CONF.share.nfs_version else \"\")"},{"line_number":757,"context_line":"        ssh_client.exec_command("},{"line_number":758,"context_line":"            \"sudo mount -vt nfs %s \\\"%s\\\" %s\" % ("},{"line_number":759,"context_line":"                version_option, location, target_dir)"},{"line_number":760,"context_line":"        )"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1c62927d_5645cc76","line":759,"range":{"start_line":758,"start_character":12,"end_line":759,"end_character":52},"in_reply_to":"ca58adda_dd182a00","updated":"2024-11-14 07:00:52.000000000","message":"I intentionally left this unchanged to maintain consistency with the other places.\nWe can address the width adjustment across all places in a separate patch.","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2a9c5868315d8511cf30b894c65b3ff072aadb2c","unresolved":true,"context_lines":[{"line_number":755,"context_line":"        version_option \u003d (f\"-o vers\u003d{CONF.share.nfs_version}\""},{"line_number":756,"context_line":"                          if CONF.share.nfs_version else \"\")"},{"line_number":757,"context_line":"        ssh_client.exec_command("},{"line_number":758,"context_line":"            \"sudo mount -vt nfs %s \\\"%s\\\" %s\" % ("},{"line_number":759,"context_line":"                version_option, location, target_dir)"},{"line_number":760,"context_line":"        )"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"67804601_00e47f7b","line":759,"range":{"start_line":758,"start_character":12,"end_line":759,"end_character":53},"in_reply_to":"f26d6dbf_fc330edc","updated":"2024-11-14 07:00:52.000000000","message":"Based on my findings, the correct way to specify NFS version 4 is to use -t nfs along with -o vers\u003d4.","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"}],"releasenotes/notes/nfs-version-6886a2dd1bab094f.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e5e993dc6d226f536a11e1aa7e921d65ea327fa","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    A new configuration option, nfs_version, has been added to control"},{"line_number":5,"context_line":"    the NFS protocol version used for mounting NFS shares during testing."},{"line_number":6,"context_line":"    This option allows users to specify which version of NFS should be used,"},{"line_number":7,"context_line":"    supporting environments where compatibility with specific versions is required."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d66badf9_f66bd8a0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"updated":"2024-11-11 19:17:58.000000000","message":"Please wrap it at 79 characters :)\n```suggestion\n    supporting environments where compatibility with specific versions is\n    required.\n```","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2a9c5868315d8511cf30b894c65b3ff072aadb2c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    A new configuration option, nfs_version, has been added to control"},{"line_number":5,"context_line":"    the NFS protocol version used for mounting NFS shares during testing."},{"line_number":6,"context_line":"    This option allows users to specify which version of NFS should be used,"},{"line_number":7,"context_line":"    supporting environments where compatibility with specific versions is required."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4d6085be_238d81fb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"in_reply_to":"d66badf9_f66bd8a0","updated":"2024-11-14 07:00:52.000000000","message":"Done","commit_id":"38da69c0c9d253c2ec2a34021ca5832b65229265"}]}