)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"7d9d390e46d3d07ecc20ce2342a61b7a426c399d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ebfa123_4c3993af","updated":"2024-12-13 15:17:32.000000000","message":"LGTM ..!","commit_id":"21620a340454ca6f3c66bc85d99fd83dac57866c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3d8213f0f6384ec6d7c7c791adb34e0c18ef407c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04b59df7_b8599907","updated":"2024-12-18 03:27:49.000000000","message":"LGTM，thanks","commit_id":"21620a340454ca6f3c66bc85d99fd83dac57866c"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"d55818fc71d3f89800213a166d2bed4ca453d37d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ef509418_cc759ef4","updated":"2024-12-17 15:20:11.000000000","message":"Looks good, pls see my comment.","commit_id":"21620a340454ca6f3c66bc85d99fd83dac57866c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"960dbc2491db6044072e4b6cf8058c0e92ae5051","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eb78ddf9_1a9853c9","updated":"2024-12-23 19:24:34.000000000","message":"Hey, Kiran! Thanks for working on this change. I think we should not only be testing RBAC things. We should also be adding postive and negative tests to the access rules. Please propose more test scenarios.","commit_id":"16322e4fb4efe00c16ac661039ab3db8fa0831a7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5af09015f3d414d0897deaf167726929c9481527","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"746f2f87_70e0d450","updated":"2024-12-20 01:07:15.000000000","message":"LGTM,thanks.","commit_id":"16322e4fb4efe00c16ac661039ab3db8fa0831a7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2f1defbdea07ab1f92c107e48a99fa5b90f299fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1c53944b_84646f46","updated":"2024-12-19 08:08:54.000000000","message":"recheck","commit_id":"16322e4fb4efe00c16ac661039ab3db8fa0831a7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2c9577ca1ab4db228540fe3f55281d8363dd4fd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"90353ed3_ced48ac3","updated":"2024-12-19 09:51:53.000000000","message":"recheck","commit_id":"16322e4fb4efe00c16ac661039ab3db8fa0831a7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"bb1de231ad8c9b30eedf9b4a3652c7e9203e7a92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"77cbad11_83a96ab0","updated":"2024-12-19 11:47:58.000000000","message":"recheck\n\ntimeout for dhss test","commit_id":"16322e4fb4efe00c16ac661039ab3db8fa0831a7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"043a819cf99b98f4bd9a397daf91f1043f96a56c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8afdca94_e3f93588","updated":"2024-12-19 15:39:49.000000000","message":"recheck \n\nmanila-tempest-plugin-lvm-2023.2 failed","commit_id":"16322e4fb4efe00c16ac661039ab3db8fa0831a7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e1188a1c41ca9a2daf764ccb06e7fb7187a8c190","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9b7435cf_f7c97012","in_reply_to":"eb78ddf9_1a9853c9","updated":"2024-12-29 04:56:28.000000000","message":"added","commit_id":"16322e4fb4efe00c16ac661039ab3db8fa0831a7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"fcf8fb380e93654648216e8b05f7540c3676c6fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"86c9cb88_3c650c43","updated":"2024-12-30 02:24:26.000000000","message":"LGTM， thanks for add more tests.","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1f1f47ff7a3e4721bfc8bc0d8238891120c34aa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dea95ce5_b1133fa1","updated":"2025-01-02 10:26:31.000000000","message":"Thank you, Kiran, for your efforts on this!\nPlease review the comments provided.","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2ad2d4d0e60fe424f9b52686122b28a090e9193b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c4990f4a_24162d27","updated":"2025-01-05 09:07:28.000000000","message":"Thanks Kiran!\nI think we should add a release note for this RFE under releasenotes/notes. Additionally, we need to update the documentation at https://docs.openstack.org/api-ref/shared-file-system/, though the documentation update is outside the scope of this patch.","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6d99f89329a1af936414352022bb47a94901965a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"682a71fe_c5c2ccc2","updated":"2025-01-02 16:57:53.000000000","message":"recheck","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"06e8025ccfa4cfa7b2aceb8fdde782525cae5b28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e94a76de_f9ea8cf7","updated":"2025-01-03 03:49:20.000000000","message":"recheck\n\ndevstack installtion failed","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2206fbb514986d0609499c52f465ae5a2f6634a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bb93d55c_d57f1820","in_reply_to":"c4990f4a_24162d27","updated":"2025-01-06 13:53:38.000000000","message":"ok, I had not added releasenotes for tempest earlier so was not aware. Added now. Hope this is good to go and docs changes will be tracked via another PR.","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"20b05e1449923359d9e3735420c04bb3677030c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d72c7aac_2638ac0c","updated":"2025-01-06 20:04:23.000000000","message":"Thanks\nJust one last comment, and we\u0027re good to go!","commit_id":"e78a59a265fe35ea6813a05a0d609f8b6c896f11"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f816eb26a890ac9ae6caec329e6e0dca86351618","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f8184bed_5e623775","updated":"2025-01-08 06:33:37.000000000","message":"Hi Liron,\nPlease approve and merge dependent PR, otherwise this wont be merged AFAIK.","commit_id":"7ff4509dbd643216175a62e84342510d65e6bcd4"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"79fb148c55685cb45a32ad5970216092ed8cc3e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a43fcd0d_99e04962","updated":"2025-01-07 21:11:40.000000000","message":"LGTM, ty.","commit_id":"7ff4509dbd643216175a62e84342510d65e6bcd4"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a958e66c3d0ae1c88280f2df617b586f11887226","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2c070d1c_756f7918","updated":"2025-01-08 06:27:36.000000000","message":"Thanks Kiran!","commit_id":"7ff4509dbd643216175a62e84342510d65e6bcd4"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"d55818fc71d3f89800213a166d2bed4ca453d37d","unresolved":true,"context_lines":[{"line_number":40,"context_line":"                    \"This value is only used to validate the versions \""},{"line_number":41,"context_line":"                    \"response from Manila.\"),"},{"line_number":42,"context_line":"    cfg.StrOpt(\"max_api_microversion\","},{"line_number":43,"context_line":"               default\u003d\"2.88\","},{"line_number":44,"context_line":"               help\u003d\"The maximum api microversion is configured to be the \""},{"line_number":45,"context_line":"                    \"value of the latest microversion supported by Manila.\"),"},{"line_number":46,"context_line":"    cfg.StrOpt(\"region\","}],"source_content_type":"text/x-python","patch_set":2,"id":"851983f2_e1201498","line":43,"updated":"2024-12-17 15:20:11.000000000","message":"Please annotate this change in commit message","commit_id":"21620a340454ca6f3c66bc85d99fd83dac57866c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5d688cf169ebb93c7337c5076e58837373d0a781","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                    \"This value is only used to validate the versions \""},{"line_number":41,"context_line":"                    \"response from Manila.\"),"},{"line_number":42,"context_line":"    cfg.StrOpt(\"max_api_microversion\","},{"line_number":43,"context_line":"               default\u003d\"2.88\","},{"line_number":44,"context_line":"               help\u003d\"The maximum api microversion is configured to be the \""},{"line_number":45,"context_line":"                    \"value of the latest microversion supported by Manila.\"),"},{"line_number":46,"context_line":"    cfg.StrOpt(\"region\","}],"source_content_type":"text/x-python","patch_set":2,"id":"773e3de2_ba344b5c","line":43,"in_reply_to":"851983f2_e1201498","updated":"2024-12-18 15:49:45.000000000","message":"Done","commit_id":"21620a340454ca6f3c66bc85d99fd83dac57866c"}],"manila_tempest_tests/tests/api/test_rules.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1f1f47ff7a3e4721bfc8bc0d8238891120c34aa9","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        \"cifs\" not in CONF.share.enable_ro_access_level_for_protocols,"},{"line_number":203,"context_line":"        \"RO access rule tests are disabled for CIFS protocol.\")"},{"line_number":204,"context_line":"    def test_create_update_delete_rw_access_rule(self):"},{"line_number":205,"context_line":"        rule \u003d _create_delete_ro_access_rule(self, LATEST_MICROVERSION)"},{"line_number":206,"context_line":"        rule \u003d self.shares_v2_client.update_access_rule("},{"line_number":207,"context_line":"            access_id\u003drule[\u0027id\u0027], access_level\u003d\u0027rw\u0027)[\u0027access\u0027]"},{"line_number":208,"context_line":"        waiters.wait_for_resource_status("},{"line_number":209,"context_line":"            self.shares_v2_client, self.share[\u0027id\u0027], status\u003d\u0027active\u0027,"},{"line_number":210,"context_line":"            resource_name\u003d\u0027access_rule\u0027, rule_id\u003drule[\u0027id\u0027])"},{"line_number":211,"context_line":"        self.assertEqual(rule[\u0027access_level\u0027], \u0027rw\u0027)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":6,"id":"fdddf890_8d9beaef","line":211,"range":{"start_line":205,"start_character":0,"end_line":211,"end_character":52},"updated":"2025-01-02 10:26:31.000000000","message":"This class inherits from ShareIpRulesForNFSTest, where the test is already implemented. Therefore, these lines of code can be removed as they are redundant.","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7ac6accef7f11edc76ea6995e9aa00136e1a8b4a","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        \"cifs\" not in CONF.share.enable_ro_access_level_for_protocols,"},{"line_number":203,"context_line":"        \"RO access rule tests are disabled for CIFS protocol.\")"},{"line_number":204,"context_line":"    def test_create_update_delete_rw_access_rule(self):"},{"line_number":205,"context_line":"        rule \u003d _create_delete_ro_access_rule(self, LATEST_MICROVERSION)"},{"line_number":206,"context_line":"        rule \u003d self.shares_v2_client.update_access_rule("},{"line_number":207,"context_line":"            access_id\u003drule[\u0027id\u0027], access_level\u003d\u0027rw\u0027)[\u0027access\u0027]"},{"line_number":208,"context_line":"        waiters.wait_for_resource_status("},{"line_number":209,"context_line":"            self.shares_v2_client, self.share[\u0027id\u0027], status\u003d\u0027active\u0027,"},{"line_number":210,"context_line":"            resource_name\u003d\u0027access_rule\u0027, rule_id\u003drule[\u0027id\u0027])"},{"line_number":211,"context_line":"        self.assertEqual(rule[\u0027access_level\u0027], \u0027rw\u0027)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":6,"id":"a43ac8c7_ba2db5fb","line":211,"range":{"start_line":205,"start_character":0,"end_line":211,"end_character":52},"in_reply_to":"fdddf890_8d9beaef","updated":"2025-01-02 11:24:16.000000000","message":"Done","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1f1f47ff7a3e4721bfc8bc0d8238891120c34aa9","unresolved":true,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"@ddt.ddt"},{"line_number":293,"context_line":"class ShareUserRulesForCIFSTest(ShareUserRulesForNFSTest):"},{"line_number":294,"context_line":"    protocol \u003d \"cifs\""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @decorators.idempotent_id(\u0027ee11084d-6c1d-4856-8044-9aa9e6c670fb\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5d6bc645_3582a071","line":293,"range":{"start_line":293,"start_character":6,"end_line":293,"end_character":58},"updated":"2025-01-02 10:26:31.000000000","message":"Since this class inherits from ShareUserRulesForNFSTest, it runs the new test you added but with an incorrect skip condition. To address this, you should override the test with the appropriate skip condition.","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7ac6accef7f11edc76ea6995e9aa00136e1a8b4a","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"@ddt.ddt"},{"line_number":293,"context_line":"class ShareUserRulesForCIFSTest(ShareUserRulesForNFSTest):"},{"line_number":294,"context_line":"    protocol \u003d \"cifs\""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @decorators.idempotent_id(\u0027ee11084d-6c1d-4856-8044-9aa9e6c670fb\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"8867b61d_e85115f2","line":293,"range":{"start_line":293,"start_character":6,"end_line":293,"end_character":58},"in_reply_to":"5d6bc645_3582a071","updated":"2025-01-02 11:24:16.000000000","message":"removed, user not supported (at least for now)","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2ad2d4d0e60fe424f9b52686122b28a090e9193b","unresolved":true,"context_lines":[{"line_number":172,"context_line":"    @testtools.skipIf("},{"line_number":173,"context_line":"        \"nfs\" not in CONF.share.enable_ro_access_level_for_protocols,"},{"line_number":174,"context_line":"        \"RO access rule tests are disabled for NFS protocol.\")"},{"line_number":175,"context_line":"    def test_create_update_delete_rw_access_rule(self):"},{"line_number":176,"context_line":"        rule \u003d _create_delete_ro_access_rule(self, LATEST_MICROVERSION)"},{"line_number":177,"context_line":"        rule \u003d self.shares_v2_client.update_access_rule("},{"line_number":178,"context_line":"            access_id\u003drule[\u0027id\u0027], access_level\u003d\u0027rw\u0027)[\u0027access\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"a9f3da42_5e3b5a28","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":48},"updated":"2025-01-05 09:07:28.000000000","message":"Please rename this to test_update_access_rule, as the primary purpose of the test is to verify the update operation, even though it also involves creating and deleting the access rule.","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2206fbb514986d0609499c52f465ae5a2f6634a2","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    @testtools.skipIf("},{"line_number":173,"context_line":"        \"nfs\" not in CONF.share.enable_ro_access_level_for_protocols,"},{"line_number":174,"context_line":"        \"RO access rule tests are disabled for NFS protocol.\")"},{"line_number":175,"context_line":"    def test_create_update_delete_rw_access_rule(self):"},{"line_number":176,"context_line":"        rule \u003d _create_delete_ro_access_rule(self, LATEST_MICROVERSION)"},{"line_number":177,"context_line":"        rule \u003d self.shares_v2_client.update_access_rule("},{"line_number":178,"context_line":"            access_id\u003drule[\u0027id\u0027], access_level\u003d\u0027rw\u0027)[\u0027access\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"36d5c487_4cd3374b","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":48},"in_reply_to":"a9f3da42_5e3b5a28","updated":"2025-01-06 13:53:38.000000000","message":"Done","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"}],"manila_tempest_tests/tests/api/test_rules_negative.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1f1f47ff7a3e4721bfc8bc0d8238891120c34aa9","unresolved":true,"context_lines":[{"line_number":373,"context_line":"    def test_update_access_rule_with_worng_level(self):"},{"line_number":374,"context_line":"        access_type, access_to \u003d utils.get_access_rule_data_from_config("},{"line_number":375,"context_line":"            self.protocol)"},{"line_number":376,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":377,"context_line":"            return"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        rule \u003d self.allow_access("},{"line_number":380,"context_line":"            self.share[\"id\"], client\u003dself.shares_v2_client,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ba570dc_885a7a81","line":377,"range":{"start_line":376,"start_character":0,"end_line":377,"end_character":18},"updated":"2025-01-02 10:26:31.000000000","message":"If the test runs with an access_type other than ip, it will indicate that the test has passed. You should skip the test with an appropriate comment explaining the reason\nWhat is the reason for testing only the ip access type? Are other access types not supported?","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7ac6accef7f11edc76ea6995e9aa00136e1a8b4a","unresolved":false,"context_lines":[{"line_number":373,"context_line":"    def test_update_access_rule_with_worng_level(self):"},{"line_number":374,"context_line":"        access_type, access_to \u003d utils.get_access_rule_data_from_config("},{"line_number":375,"context_line":"            self.protocol)"},{"line_number":376,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":377,"context_line":"            return"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        rule \u003d self.allow_access("},{"line_number":380,"context_line":"            self.share[\"id\"], client\u003dself.shares_v2_client,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7db8bb18_0227e3db","line":377,"range":{"start_line":376,"start_character":0,"end_line":377,"end_character":18},"in_reply_to":"3ba570dc_885a7a81","updated":"2025-01-02 11:24:16.000000000","message":"The use-case is to allow update access_level for access_type which is tested for type \u0027ip\u0027 only. So I have put restriction. In future, if use-case support other access_type, the test can be modified accordingly.","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"}],"manila_tempest_tests/tests/rbac/test_rules.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1f1f47ff7a3e4721bfc8bc0d8238891120c34aa9","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @decorators.idempotent_id(\u002701939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":159,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":160,"context_line":"    def test_update_access(self):"},{"line_number":161,"context_line":"        access_type, access_to \u003d ("},{"line_number":162,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":163,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":164,"context_line":"            return"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        access \u003d self.allow_access(self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":167,"context_line":"        rule \u003d self.share_member_client.update_access_rule("},{"line_number":168,"context_line":"            access_id\u003daccess[\u0027id\u0027], access_level\u003d\u0027ro\u0027)[\u0027access\u0027]"},{"line_number":169,"context_line":"        waiters.wait_for_resource_status("},{"line_number":170,"context_line":"            self.share_member_client, self.share[\u0027id\u0027], status\u003d\u0027active\u0027,"},{"line_number":171,"context_line":"            resource_name\u003d\u0027access_rule\u0027, rule_id\u003drule[\u0027id\u0027])"},{"line_number":172,"context_line":"        self.assertEqual(rule[\u0027access_level\u0027], \u0027ro\u0027)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @decorators.idempotent_id(\u0027b4d7a91c-a75e-4ad9-93cb-8e5234fea97a\u0027)"},{"line_number":175,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":6,"id":"d4ab344a_e2f6e34c","line":172,"range":{"start_line":160,"start_character":0,"end_line":172,"end_character":52},"updated":"2025-01-02 10:26:31.000000000","message":"In RBAC tests, we focus solely on verifying permissions for specific operations. For this purpose, we use the do_request method, and you can find numerous examples here.\n\nAdditionally, this method should be abstract. Please add the following lines to the ShareRbacRulesTests class:\n@abc.abstractmethod\ndef test_update_access(self):\n    pass","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7ac6accef7f11edc76ea6995e9aa00136e1a8b4a","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @decorators.idempotent_id(\u002701939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":159,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":160,"context_line":"    def test_update_access(self):"},{"line_number":161,"context_line":"        access_type, access_to \u003d ("},{"line_number":162,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":163,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":164,"context_line":"            return"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        access \u003d self.allow_access(self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":167,"context_line":"        rule \u003d self.share_member_client.update_access_rule("},{"line_number":168,"context_line":"            access_id\u003daccess[\u0027id\u0027], access_level\u003d\u0027ro\u0027)[\u0027access\u0027]"},{"line_number":169,"context_line":"        waiters.wait_for_resource_status("},{"line_number":170,"context_line":"            self.share_member_client, self.share[\u0027id\u0027], status\u003d\u0027active\u0027,"},{"line_number":171,"context_line":"            resource_name\u003d\u0027access_rule\u0027, rule_id\u003drule[\u0027id\u0027])"},{"line_number":172,"context_line":"        self.assertEqual(rule[\u0027access_level\u0027], \u0027ro\u0027)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @decorators.idempotent_id(\u0027b4d7a91c-a75e-4ad9-93cb-8e5234fea97a\u0027)"},{"line_number":175,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":6,"id":"a0af71ba_9887c5e0","line":172,"range":{"start_line":160,"start_character":0,"end_line":172,"end_character":52},"in_reply_to":"d4ab344a_e2f6e34c","updated":"2025-01-02 11:24:16.000000000","message":"Done","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1f1f47ff7a3e4721bfc8bc0d8238891120c34aa9","unresolved":true,"context_lines":[{"line_number":304,"context_line":"    @decorators.idempotent_id(\u002702939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":305,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":306,"context_line":"    def test_update_access(self):"},{"line_number":307,"context_line":"        access_type, access_to \u003d ("},{"line_number":308,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":309,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":310,"context_line":"            return"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":313,"context_line":"        access \u003d self.allow_access(share_client, self.share[\u0027id\u0027])"},{"line_number":314,"context_line":"        rule \u003d share_client.update_access_rule("},{"line_number":315,"context_line":"            access_id\u003daccess[\u0027id\u0027], access_level\u003d\u0027ro\u0027)[\u0027access\u0027]"},{"line_number":316,"context_line":"        waiters.wait_for_resource_status("},{"line_number":317,"context_line":"            share_client, self.share[\u0027id\u0027], status\u003d\u0027active\u0027,"},{"line_number":318,"context_line":"            resource_name\u003d\u0027access_rule\u0027, rule_id\u003drule[\u0027id\u0027])"},{"line_number":319,"context_line":"        self.assertEqual(rule[\u0027access_level\u0027], \u0027ro\u0027)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    @decorators.idempotent_id(\u002761cf6f6c-5d7c-48d7-9d5a-e6ea288afdbc\u0027)"},{"line_number":322,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":6,"id":"51c14b91_42fc71b5","line":319,"range":{"start_line":307,"start_character":0,"end_line":319,"end_character":52},"updated":"2025-01-02 10:26:31.000000000","message":"Same","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7ac6accef7f11edc76ea6995e9aa00136e1a8b4a","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    @decorators.idempotent_id(\u002702939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":305,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":306,"context_line":"    def test_update_access(self):"},{"line_number":307,"context_line":"        access_type, access_to \u003d ("},{"line_number":308,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":309,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":310,"context_line":"            return"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":313,"context_line":"        access \u003d self.allow_access(share_client, self.share[\u0027id\u0027])"},{"line_number":314,"context_line":"        rule \u003d share_client.update_access_rule("},{"line_number":315,"context_line":"            access_id\u003daccess[\u0027id\u0027], access_level\u003d\u0027ro\u0027)[\u0027access\u0027]"},{"line_number":316,"context_line":"        waiters.wait_for_resource_status("},{"line_number":317,"context_line":"            share_client, self.share[\u0027id\u0027], status\u003d\u0027active\u0027,"},{"line_number":318,"context_line":"            resource_name\u003d\u0027access_rule\u0027, rule_id\u003drule[\u0027id\u0027])"},{"line_number":319,"context_line":"        self.assertEqual(rule[\u0027access_level\u0027], \u0027ro\u0027)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    @decorators.idempotent_id(\u002761cf6f6c-5d7c-48d7-9d5a-e6ea288afdbc\u0027)"},{"line_number":322,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":6,"id":"4608d8fd_9ae21dda","line":319,"range":{"start_line":307,"start_character":0,"end_line":319,"end_character":52},"in_reply_to":"51c14b91_42fc71b5","updated":"2025-01-02 11:24:16.000000000","message":"Done","commit_id":"38cd20b9aca6797628bebd6743310011f4eeac5d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"303cea129766b301c47a6e59e565a5fed6f70448","unresolved":true,"context_lines":[{"line_number":164,"context_line":"    def test_update_access(self):"},{"line_number":165,"context_line":"        access_type, access_to \u003d ("},{"line_number":166,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":167,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":168,"context_line":"            return"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        access \u003d self.allow_access(self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":171,"context_line":"        rule \u003d self.do_request("}],"source_content_type":"text/x-python","patch_set":7,"id":"aa850251_775b524b","line":168,"range":{"start_line":167,"start_character":0,"end_line":168,"end_character":18},"updated":"2025-01-02 13:18:52.000000000","message":"Please skip the test in the same way you did above.","commit_id":"2745aa62419ea39a7db1ec02d5cf4889928a0357"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d5fef40171aa8a6bcb4c98de62a76878dc5d47c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def test_update_access(self):"},{"line_number":165,"context_line":"        access_type, access_to \u003d ("},{"line_number":166,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":167,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":168,"context_line":"            return"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        access \u003d self.allow_access(self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":171,"context_line":"        rule \u003d self.do_request("}],"source_content_type":"text/x-python","patch_set":7,"id":"0f01a418_8e788163","line":168,"range":{"start_line":167,"start_character":0,"end_line":168,"end_character":18},"in_reply_to":"aa850251_775b524b","updated":"2025-01-02 14:18:10.000000000","message":"Done","commit_id":"2745aa62419ea39a7db1ec02d5cf4889928a0357"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"303cea129766b301c47a6e59e565a5fed6f70448","unresolved":true,"context_lines":[{"line_number":174,"context_line":"        waiters.wait_for_resource_status("},{"line_number":175,"context_line":"            self.share_member_client, self.share[\u0027id\u0027], status\u003d\u0027active\u0027,"},{"line_number":176,"context_line":"            resource_name\u003d\u0027access_rule\u0027, rule_id\u003drule[\u0027id\u0027])"},{"line_number":177,"context_line":"        self.assertEqual(rule[\u0027access_level\u0027], \u0027ro\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @decorators.idempotent_id(\u0027b4d7a91c-a75e-4ad9-93cb-8e5234fea97a\u0027)"},{"line_number":180,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"e6e8feef_e91cdb19","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":52},"updated":"2025-01-02 13:18:52.000000000","message":"In RBAC, we focus solely on verifying the user\u0027s permissions for the operation. This verification is performed within the api library.","commit_id":"2745aa62419ea39a7db1ec02d5cf4889928a0357"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d5fef40171aa8a6bcb4c98de62a76878dc5d47c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        waiters.wait_for_resource_status("},{"line_number":175,"context_line":"            self.share_member_client, self.share[\u0027id\u0027], status\u003d\u0027active\u0027,"},{"line_number":176,"context_line":"            resource_name\u003d\u0027access_rule\u0027, rule_id\u003drule[\u0027id\u0027])"},{"line_number":177,"context_line":"        self.assertEqual(rule[\u0027access_level\u0027], \u0027ro\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @decorators.idempotent_id(\u0027b4d7a91c-a75e-4ad9-93cb-8e5234fea97a\u0027)"},{"line_number":180,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"4a6ec152_37e6dadb","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":52},"in_reply_to":"e6e8feef_e91cdb19","updated":"2025-01-02 14:18:10.000000000","message":"Done","commit_id":"2745aa62419ea39a7db1ec02d5cf4889928a0357"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"303cea129766b301c47a6e59e565a5fed6f70448","unresolved":true,"context_lines":[{"line_number":311,"context_line":"    def test_update_access(self):"},{"line_number":312,"context_line":"        access_type, access_to \u003d ("},{"line_number":313,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":314,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":315,"context_line":"            return"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":318,"context_line":"        access \u003d self.allow_access(share_client, self.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1c065292_9e654032","line":315,"range":{"start_line":314,"start_character":0,"end_line":315,"end_character":18},"updated":"2025-01-02 13:18:52.000000000","message":"Same","commit_id":"2745aa62419ea39a7db1ec02d5cf4889928a0357"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d5fef40171aa8a6bcb4c98de62a76878dc5d47c","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def test_update_access(self):"},{"line_number":312,"context_line":"        access_type, access_to \u003d ("},{"line_number":313,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":314,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":315,"context_line":"            return"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        share_client \u003d getattr(self, \u0027share_member_client\u0027, self.client)"},{"line_number":318,"context_line":"        access \u003d self.allow_access(share_client, self.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"47ff185c_c8b181d0","line":315,"range":{"start_line":314,"start_character":0,"end_line":315,"end_character":18},"in_reply_to":"1c065292_9e654032","updated":"2025-01-02 14:18:10.000000000","message":"Done","commit_id":"2745aa62419ea39a7db1ec02d5cf4889928a0357"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"303cea129766b301c47a6e59e565a5fed6f70448","unresolved":true,"context_lines":[{"line_number":322,"context_line":"        waiters.wait_for_resource_status("},{"line_number":323,"context_line":"            share_client, self.share[\u0027id\u0027], status\u003d\u0027active\u0027,"},{"line_number":324,"context_line":"            resource_name\u003d\u0027access_rule\u0027, rule_id\u003drule[\u0027id\u0027])"},{"line_number":325,"context_line":"        self.assertEqual(rule[\u0027access_level\u0027], \u0027ro\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    @decorators.idempotent_id(\u002761cf6f6c-5d7c-48d7-9d5a-e6ea288afdbc\u0027)"},{"line_number":328,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"46b993a9_9aa9e6e0","line":325,"range":{"start_line":325,"start_character":0,"end_line":325,"end_character":52},"updated":"2025-01-02 13:18:52.000000000","message":"Same","commit_id":"2745aa62419ea39a7db1ec02d5cf4889928a0357"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d5fef40171aa8a6bcb4c98de62a76878dc5d47c","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        waiters.wait_for_resource_status("},{"line_number":323,"context_line":"            share_client, self.share[\u0027id\u0027], status\u003d\u0027active\u0027,"},{"line_number":324,"context_line":"            resource_name\u003d\u0027access_rule\u0027, rule_id\u003drule[\u0027id\u0027])"},{"line_number":325,"context_line":"        self.assertEqual(rule[\u0027access_level\u0027], \u0027ro\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    @decorators.idempotent_id(\u002761cf6f6c-5d7c-48d7-9d5a-e6ea288afdbc\u0027)"},{"line_number":328,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"810e6c76_aa94927c","line":325,"range":{"start_line":325,"start_character":0,"end_line":325,"end_character":52},"in_reply_to":"46b993a9_9aa9e6e0","updated":"2025-01-02 14:18:10.000000000","message":"Done","commit_id":"2745aa62419ea39a7db1ec02d5cf4889928a0357"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"303cea129766b301c47a6e59e565a5fed6f70448","unresolved":true,"context_lines":[{"line_number":433,"context_line":"    @decorators.idempotent_id(\u002703939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":434,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":435,"context_line":"    def test_update_access(self):"},{"line_number":436,"context_line":"        super(TestProjectReaderTestsNFS, self).test_update_access()"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @decorators.idempotent_id(\u0027ace870f9-af91-4259-8760-dc7d7107b7ff\u0027)"},{"line_number":439,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a1e0bb97_097f746c","line":436,"range":{"start_line":436,"start_character":8,"end_line":436,"end_character":66},"updated":"2025-01-02 13:18:52.000000000","message":"A Reader user can\u0027t perform this action, so please update the test accordingly.","commit_id":"2745aa62419ea39a7db1ec02d5cf4889928a0357"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d5fef40171aa8a6bcb4c98de62a76878dc5d47c","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    @decorators.idempotent_id(\u002703939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":434,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":435,"context_line":"    def test_update_access(self):"},{"line_number":436,"context_line":"        super(TestProjectReaderTestsNFS, self).test_update_access()"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @decorators.idempotent_id(\u0027ace870f9-af91-4259-8760-dc7d7107b7ff\u0027)"},{"line_number":439,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"}],"source_content_type":"text/x-python","patch_set":7,"id":"588e3f09_462d697b","line":436,"range":{"start_line":436,"start_character":8,"end_line":436,"end_character":66},"in_reply_to":"a1e0bb97_097f746c","updated":"2025-01-02 14:18:10.000000000","message":"Done","commit_id":"2745aa62419ea39a7db1ec02d5cf4889928a0357"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2ad2d4d0e60fe424f9b52686122b28a090e9193b","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @decorators.idempotent_id(\u002701939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":163,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":164,"context_line":"    def test_update_access(self):"},{"line_number":165,"context_line":"        access_type, access_to \u003d ("},{"line_number":166,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":167,"context_line":"        if access_type !\u003d \u0027ip\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ea3dcdd2_3ddacfe6","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":26},"updated":"2025-01-05 09:07:28.000000000","message":"Sorry, I missed this earlier. Please ensure you cover the scenario where the resource is created in a different project by using self.alt_project_share_v2_client, as this is consistently covered across all test cases.","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2206fbb514986d0609499c52f465ae5a2f6634a2","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @decorators.idempotent_id(\u002701939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":163,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":164,"context_line":"    def test_update_access(self):"},{"line_number":165,"context_line":"        access_type, access_to \u003d ("},{"line_number":166,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":167,"context_line":"        if access_type !\u003d \u0027ip\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"6b1d4a98_122698ad","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":26},"in_reply_to":"ea3dcdd2_3ddacfe6","updated":"2025-01-06 13:53:38.000000000","message":"Done","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2ad2d4d0e60fe424f9b52686122b28a090e9193b","unresolved":true,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @decorators.idempotent_id(\u002702939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":310,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":311,"context_line":"    def test_update_access(self):"},{"line_number":312,"context_line":"        access_type, access_to \u003d ("},{"line_number":313,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":314,"context_line":"        if access_type !\u003d \u0027ip\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9af6d02b_680180c3","line":311,"range":{"start_line":311,"start_character":8,"end_line":311,"end_character":26},"updated":"2025-01-05 09:07:28.000000000","message":"Same","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2206fbb514986d0609499c52f465ae5a2f6634a2","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @decorators.idempotent_id(\u002702939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":310,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":311,"context_line":"    def test_update_access(self):"},{"line_number":312,"context_line":"        access_type, access_to \u003d ("},{"line_number":313,"context_line":"            utils.get_access_rule_data_from_config(self.protocol))"},{"line_number":314,"context_line":"        if access_type !\u003d \u0027ip\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"0fd5ad4c_4b1d99b6","line":311,"range":{"start_line":311,"start_character":8,"end_line":311,"end_character":26},"in_reply_to":"9af6d02b_680180c3","updated":"2025-01-06 13:53:38.000000000","message":"Done","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"2ad2d4d0e60fe424f9b52686122b28a090e9193b","unresolved":true,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    @decorators.idempotent_id(\u002703939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":434,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":435,"context_line":"    def test_update_access(self):"},{"line_number":436,"context_line":"        access \u003d self.allow_access(self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":437,"context_line":"        self.do_request("},{"line_number":438,"context_line":"            \u0027update_access_rule\u0027, expected_status\u003dlib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":8,"id":"30051bbf_dd2b819a","line":435,"range":{"start_line":435,"start_character":8,"end_line":435,"end_character":26},"updated":"2025-01-05 09:07:28.000000000","message":"Same","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2206fbb514986d0609499c52f465ae5a2f6634a2","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    @decorators.idempotent_id(\u002703939b69-ef9b-75cf-abf7-5171fec7c397\u0027)"},{"line_number":434,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":435,"context_line":"    def test_update_access(self):"},{"line_number":436,"context_line":"        access \u003d self.allow_access(self.share_member_client, self.share[\u0027id\u0027])"},{"line_number":437,"context_line":"        self.do_request("},{"line_number":438,"context_line":"            \u0027update_access_rule\u0027, expected_status\u003dlib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":8,"id":"d96a681e_de36b65b","line":435,"range":{"start_line":435,"start_character":8,"end_line":435,"end_character":26},"in_reply_to":"30051bbf_dd2b819a","updated":"2025-01-06 13:53:38.000000000","message":"Done","commit_id":"1adaa26f27cb9d4c37b436e253d35fe62f4ad747"}],"releasenotes/notes/update-access-rules-e43b4d0fbabdb596.yaml":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"20b05e1449923359d9e3735420c04bb3677030c4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added tests to verify share access rule update operation. Update is"},{"line_number":5,"context_line":"    allowed only for admin and project member. Also supported microversion is"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9268c900_faaf0dd1","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2025-01-06 20:04:23.000000000","message":"I believe \"features\" is the most appropriate option here.\n\nPlease rename this file to add-update-access-rules... for better clarity and consistency.","commit_id":"e78a59a265fe35ea6813a05a0d609f8b6c896f11"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"21b89ea3ffef395f2f6a1c828502c534ebded65d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added tests to verify share access rule update operation. Update is"},{"line_number":5,"context_line":"    allowed only for admin and project member. Also supported microversion is"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a6f1f058_9240bff0","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"9268c900_faaf0dd1","updated":"2025-01-07 12:44:33.000000000","message":"Done","commit_id":"e78a59a265fe35ea6813a05a0d609f8b6c896f11"}]}