)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"105ff8b14860b641a90de336e3e408a9e52141a2","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure Manila shares are created in the same availability Zone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This update ensures that Manila shares are consistently created"},{"line_number":10,"context_line":"within the same AZ, addressing issues where mismatched AZs lead"},{"line_number":11,"context_line":"to test failures."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ied7d75fc3e26c1963744df6e9e5af6ae0e605158"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"146f9225_e572703e","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":17},"updated":"2025-02-13 20:24:37.000000000","message":"the problem here doesn\u0027t seem related to AZs.. the two tests you\u0027re modifying seem to need the same backend/host. i.e., we need the shares to be collocated on the same host for the negative scenarios being tested:\n\nwhether you can reuse a CephX user id within a ceph cluster across OpenStack tenants - where the tests create shares in two different OpenStack projects and provide access to the same user ID\n\n\nthe only way an end user can ensure that two shares are on the same backend host is by using affinity hints: https://docs.openstack.org/manila/latest/user/create-and-manage-shares.html#:~:text\u003dCreate%20a%20share%20using%20scheduler%20hints%20to%20specify%20the%20host.","commit_id":"6b39ec6e6a4481837f6568912b64eeb7ff5cc5d7"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8e89bcc9fd499d0ad3f72d24dc66696f47c962b6","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure Manila shares are created in the same availability Zone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This update ensures that Manila shares are consistently created"},{"line_number":10,"context_line":"within the same AZ, addressing issues where mismatched AZs lead"},{"line_number":11,"context_line":"to test failures."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ied7d75fc3e26c1963744df6e9e5af6ae0e605158"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6815dccf_d612ece0","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":17},"in_reply_to":"0a15ac24_379ba98d","updated":"2025-02-16 08:18:11.000000000","message":"You\u0027re definitely right. This requires using admin credentials instead of alt credentials, but it doesn\u0027t really matter. I\u0027ve updated the patch accordingly.","commit_id":"6b39ec6e6a4481837f6568912b64eeb7ff5cc5d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5de3f1f1f3dc0625fe17c31d8eba0868e8a08da7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure Manila shares are created in the same availability Zone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This update ensures that Manila shares are consistently created"},{"line_number":10,"context_line":"within the same AZ, addressing issues where mismatched AZs lead"},{"line_number":11,"context_line":"to test failures."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ied7d75fc3e26c1963744df6e9e5af6ae0e605158"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0a15ac24_379ba98d","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":17},"in_reply_to":"146f9225_e572703e","updated":"2025-02-13 20:26:32.000000000","message":"@vhariria@redhat.com told me that the environment you hit this problem in has one backend per AZ where all backends match the share type being created by tempest, so your current code fix will fix the problem in that specific sort of environment.. but imagine someone enabling a second backend in one of these AZs, the tests will fail again.","commit_id":"6b39ec6e6a4481837f6568912b64eeb7ff5cc5d7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e4be9aed95f75017962b47c6b469c3d7508077de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a3c37a25_6e4b5440","updated":"2025-02-13 14:13:58.000000000","message":"LGTM, thanks Liron!\nAs an alternative, we could also let the scheduler create the share and later fetch the share\u0027s availability zone and reuse it at the tests, but that will mean some extra requests while the test is being run. I am okay with this approach :)","commit_id":"6b39ec6e6a4481837f6568912b64eeb7ff5cc5d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"105ff8b14860b641a90de336e3e408a9e52141a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67bdf242_20596efe","updated":"2025-02-13 20:24:37.000000000","message":"Thanks Liron, please see my comment on the logic here","commit_id":"6b39ec6e6a4481837f6568912b64eeb7ff5cc5d7"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1e555597e9e575aaf700584e524c1d5456e43a5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37e1129c_cd4e1d6a","in_reply_to":"a3c37a25_6e4b5440","updated":"2025-02-13 14:27:20.000000000","message":"Thanks Carlos!\nRight, this is what I initially had in mind, but I ultimately went with this approach.","commit_id":"6b39ec6e6a4481837f6568912b64eeb7ff5cc5d7"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"e41ad75d12ce3f12b33c1e5ebbcf98f54b1f650c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"959a7232_9fba0a43","updated":"2025-02-24 11:39:20.000000000","message":"Checks out, thanks Liron.","commit_id":"58903bdd47ad33cc82fd29bd1066f4c4f1245143"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"13878c20f980a729cd3e4ceff3bdb31ed98e6392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a23d074_786f81be","updated":"2025-02-20 13:16:31.000000000","message":"LGTM, thanks Liron","commit_id":"58903bdd47ad33cc82fd29bd1066f4c4f1245143"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"83a218c3390ec1ebfff17eac12a207d9d3a752b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e6982de6_4f2bbcde","updated":"2025-02-25 00:55:13.000000000","message":"Thanks, minor comments inline.. there\u0027s no need to address these though..","commit_id":"58903bdd47ad33cc82fd29bd1066f4c4f1245143"}],"manila_tempest_tests/tests/api/test_rules_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"83a218c3390ec1ebfff17eac12a207d9d3a752b7","unresolved":true,"context_lines":[{"line_number":525,"context_line":"        # Grant access to the share"},{"line_number":526,"context_line":"        self.allow_access(self.share[\u0027id\u0027], access_to\u003dself.access_to)"},{"line_number":527,"context_line":"        # Create second share by the new user"},{"line_number":528,"context_line":"        share2 \u003d self.create_share(client\u003dself.admin_shares_v2_client,"},{"line_number":529,"context_line":"                                   share_protocol\u003dself.protocol,"},{"line_number":530,"context_line":"                                   share_type_id\u003dself.share_type_id,"},{"line_number":531,"context_line":"                                   scheduler_hints\u003dscheduler_hint)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c64b6864_960d53ca","line":528,"range":{"start_line":528,"start_character":47,"end_line":528,"end_character":69},"updated":"2025-02-25 00:55:13.000000000","message":"Think we need a comment clarifying why we\u0027re using the admin user.. it\u0027s because we need a new user in a new project that can specify affinity to a share in a different project.. there are only two ways to do this:\n\n1) The original share is \"public\" (by default only admin users can create public shares)\n2) The user creating the new share is admin..","commit_id":"58903bdd47ad33cc82fd29bd1066f4c4f1245143"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"83a218c3390ec1ebfff17eac12a207d9d3a752b7","unresolved":true,"context_lines":[{"line_number":537,"context_line":"                          access_to\u003dself.access_to, status\u003d\u0027error\u0027,"},{"line_number":538,"context_line":"                          raise_rule_in_error_state\u003dFalse)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        share_alt_updated \u003d self.admin_shares_v2_client.get_share("},{"line_number":541,"context_line":"            share2[\u0027id\u0027])[\u0027share\u0027]"},{"line_number":542,"context_line":"        self.assertEqual(\u0027error\u0027, share_alt_updated[\u0027access_rules_status\u0027])"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b4228962_4b40d01d","line":540,"range":{"start_line":540,"start_character":8,"end_line":540,"end_character":25},"updated":"2025-02-25 00:55:13.000000000","message":"share2_updated perhaps","commit_id":"58903bdd47ad33cc82fd29bd1066f4c4f1245143"}]}