)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3a3391a566ed83a7dbead952c9cf3a3375e1ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b3e17b0d_bd3c21dc","updated":"2025-07-10 23:35:18.000000000","message":"don\u0027t think it\u0027s wise to use a python SDK within tempest code like this; there\u0027s even a guideline against doing this: https://docs.openstack.org/tempest/16.1.0/field_guide/index.html\n\nWhen barbican-tempest-plugin exists in the test python environment, you could use it\u0027s client directly, like:\n\nhttps://opendev.org/openstack/whitebox-tempest-plugin/src/commit/e056798f095f7758ed7221fcb8c9a25b6a33d692/whitebox_tempest_plugin/api/compute/test_vtpm.py#L50-L53\n\n\nIf that doesn\u0027t work, others have implemented a client within the tempest code, like:\n\nhttps://opendev.org/x/vmware-nsx-tempest-plugin/src/commit/60f9c54df7d06a251708d1e35364cdf2b94e46fb/vmware_nsx_tempest_plugin/services/openstack_network_clients.py#L516-L581 \n\nhttps://opendev.org/openstack/octavia-tempest-plugin/src/commit/13cb2ec83d8457189030ab1be209c28186d85c69/octavia_tempest_plugin/common/barbican_client_mgr.py#L24","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"d47d3c1dff979e60d32ec1ff48ea899ef24cac3a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a9236d3d_ea58f2a8","in_reply_to":"05f4e361_a4f5fa16","updated":"2025-10-02 22:56:13.000000000","message":"octavia-tempest-plugin does it wrong, it shouldn\u0027t use barbicanclient. \nPlease make sure to use the *tempest* client as advised.","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"70a7090e3c935b9d2ab479c7811b687f563b51e7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"05f4e361_a4f5fa16","in_reply_to":"0e4513c4_59fb393b","updated":"2025-09-24 07:39:01.000000000","message":"but the code is already implemented as suggested using https://opendev.org/openstack/octavia-tempest-plugin/src/commit/13cb2ec83d8457189030ab1be209c28186d85c69/octavia_tempest_plugin/common/barbican_client_mgr.py#L24 \n\nWhat is missing here ?","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b72e7d1caf371fb6e87696f62ca254cb6e7145f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c767529c_e8dc0bc5","in_reply_to":"158816d0_6330d896","updated":"2025-10-24 06:44:19.000000000","message":"fixed","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6db57b65a0f2d577398193f29a16b2164506c4dd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"158816d0_6330d896","in_reply_to":"4688c591_cb246688","updated":"2025-10-10 11:23:54.000000000","message":"Oct 10 10:25:57.406011 npd10c4fadd7424 manila-share[49160]: INFO manila.share.manager [None req-2abe7295-d7aa-4028-a2b1-0a5349c1c1fb tempest-SharesAdminQuotasUpdateTest-1773026574 None] Share instance 60046848-654d-48d8-ae4e-1676318a143b: deleted successfully.\nOct 10 10:25:57.542597 npd10c4fadd7424 manila-share[49161]: DEBUG barbicanclient.client [None req-42a6ab28-1833-4ed6-bc05-2f6aaceab628 tempest-ShareEncryptionCIFSTest-1329157076 None] Response status 403 {{(pid\u003d49161) _check_status_code /opt/stack/data/venv/lib/python3.12/site-packages/barbicanclient/client.py:87}}\nOct 10 10:25:57.543199 npd10c4fadd7424 manila-share[49161]: ERROR barbicanclient.client [None req-42a6ab28-1833-4ed6-bc05-2f6aaceab628 tempest-ShareEncryptionCIFSTest-1329157076 None] 4xx Client error: Forbidden: SecretACL(s) Update attempt not allowed - please review your user/project privileges\nOct 10 10:25:57.543830 npd10c4fadd7424 manila-share[49161]: ERROR manila.keymgr.barbican [None req-42a6ab28-1833-4ed6-bc05-2f6aaceab628 tempest-ShareEncryptionCIFSTest-1329157076 None] Failed to create secret ACL. Error: Forbidden: SecretACL(s) Update attempt not allowed - please review your user/project privileges: barbicanclient.exceptions.HTTPClientError: Forbidden: SecretACL(s) Update attempt not allowed - please review your user/project privileges","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"50bbd432342033f40d1377dbc04bd9392e6339e9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4688c591_cb246688","in_reply_to":"6c52cf44_4a3329f9","updated":"2025-10-10 09:58:04.000000000","message":"Adding that dependenacy in requirements.txt\n\nhttps://zuul.opendev.org/t/openstack/build/28871780a2bc485eac8d184b389a5a4d","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"eacc2cb92ed8549dd1e61d301f66df0beed1436c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3f713dc_e6ca2150","in_reply_to":"a9236d3d_ea58f2a8","updated":"2025-10-07 07:17:58.000000000","message":"@ltoscano@redhat.com \ncan you check latest patchset, the key-manager does not exist in tempest clients. Do I need to update tempest to add \u0027key-manager\u0027 or implement rest API client internally ?\n\n How code mentioned at https://opendev.org/openstack/whitebox-tempest-plugin/src/commit/19f39aba511ddf6ecddd0e7dd5ae2440e57bdbbd/whitebox_tempest_plugin/api/compute/test_vtpm.py is working.","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"079f314ddb766699265b0b88e1f0a82edb5e571e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0e4513c4_59fb393b","in_reply_to":"b3e17b0d_bd3c21dc","updated":"2025-09-23 16:15:15.000000000","message":"Unresolving this because it\u0027s still a concern..","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ef1ad99cbbc2cd988abf05893c7391337a6d38c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6c52cf44_4a3329f9","in_reply_to":"f3f713dc_e6ca2150","updated":"2025-10-09 22:36:28.000000000","message":"@kinpaa@gmail.com\n\nwhitebox-tempest-plugin adds a dependency on the barbican tempest plugin that provides this service client:\n\nhttps://opendev.org/openstack/whitebox-tempest-plugin/src/commit/19f39aba511ddf6ecddd0e7dd5ae2440e57bdbbd/requirements.txt#L18-L19","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"93f24f4b4bb3bb0e876215dc9a05e578f47b37ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d05ce58b_26b5e681","updated":"2025-07-17 09:34:00.000000000","message":"Addressed.","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4d5399a4fb82ef4edf307ba3be4cead12470d1d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d93fa39f_cb8a27f9","updated":"2025-07-17 09:32:52.000000000","message":"Thank you for working on this Kiran. I have tested this code and provided some comments. Please address them.","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4035e78552137817b0a43aec7f82b498c8846dca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"30b39b93_1c94e7b1","updated":"2025-07-14 08:23:48.000000000","message":"the test failing currently is share creation since it needs barbican connection","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"04457f398c2691f2e69b0ce2f2508c683108c8e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4a5fa166_b46c4784","updated":"2025-07-17 09:56:59.000000000","message":"Thank you for addressing the comments. I have run the NFS/Negative tests locally and are passing.\n\n\n(venv) stack@ostack-ubuntu-15-sai:~/tempest$ tempest -v run -r manila_tempest_tests.tests.api.test_share_encryption.ShareEncryptionNFSTest\ntempest initialize_app\nprepare_to_run_command TempestRun\n{0} manila_tempest_tests.tests.api.test_share_encryption.ShareEncryptionNFSTest.test_create_share_with_encryption_key_ref_1_True [40.378257s] ... ok\n{0} manila_tempest_tests.tests.api.test_share_encryption.ShareEncryptionNFSTest.test_create_share_with_encryption_key_ref_2_False [62.301680s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 2 tests in 102.6915 sec.\n - Passed: 2\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 102.6799 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (2 tests) \u003d\u003e 0:01:42.691504\ntempest clean_up TempestRun\n(venv) stack@ostack-ubuntu-15-sai:~/tempest$ \n\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\n(venv) stack@ostack-ubuntu-15-sai:~/tempest$ tempest -v run -r manila_tempest_tests.tests.api.test_share_encryption_negative\ntempest initialize_app\nprepare_to_run_command TempestRun\n{0} manila_tempest_tests.tests.api.test_share_encryption_negative.SharesEncryptionNegativeTest.test_create_share_with_encryption_key_ref_absent_in_barbican [0.017477s] ... ok\n{0} manila_tempest_tests.tests.api.test_share_encryption_negative.SharesEncryptionNegativeTest.test_create_share_with_invalid_encryption_key_ref [0.017477s] ... ok\n{0} manila_tempest_tests.tests.api.test_share_encryption_negative.SharesEncryptionNegativeTest.test_create_share_with_invalid_share_type [0.017196s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 3 tests in 0.0566 sec.\n - Passed: 3\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 0.0522 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (3 tests) \u003d\u003e 0:00:00.056628\ntempest clean_up TempestRun\n(venv) stack@ostack-ubuntu-15-sai:~/tempest$ \n\n\n\n\nFor CIFS tests, it needs security services to be added to network and we can\u0027t provide security service credentials in tempest. This particular tests will be run and tested against dummy driver once we add barbican install plug-in as part of manila DevStack deployment.","commit_id":"3110f6ed4616446c29c807094c43249955630efb"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6e58766bc3c815aba7d240d16a6069e52f6291ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bf6cb9dd_a3cbada4","updated":"2025-07-24 08:13:45.000000000","message":"Added PR from Sai as depends-On","commit_id":"af196d7670aeebb5e5cbd64803122b318644fe4f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d6cdeeaba4dc7f4c20744422f8916d15e6272fa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4205e5e4_af0bd6af","updated":"2025-07-25 06:31:35.000000000","message":"recheck","commit_id":"55da5e1f82ee1351fe2b1078de55a022bf291916"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7762b0b0aa9b567828b838946cbef3eb6f38ccb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a44c92f5_89603dad","updated":"2025-07-24 10:59:54.000000000","message":"recheck\n\nadded encryption_support for dummy driver in manila patch.","commit_id":"55da5e1f82ee1351fe2b1078de55a022bf291916"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a793cd31a193b23d67caf6eb71f371c88707bf6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8540d2c0_9c0e2d10","updated":"2025-08-06 10:20:02.000000000","message":"Removed barbican href positive test.","commit_id":"e10f0526229bd808528504abb64744985cede60e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a01c4c41588aafebc33ecb331e6e7b38dcee9810","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a6975ecc_ff7bd395","updated":"2025-08-19 10:33:53.000000000","message":"recheck","commit_id":"e10f0526229bd808528504abb64744985cede60e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48cfb2d24749a5df5f98d612b6bc97b760cfa5d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c74e7a28_0e53486d","updated":"2025-10-02 21:42:32.000000000","message":"Thanks for the changes per our collab review meeting..\n\nI\u0027d like to make another comment for the NetApp folks for a follow up\n\n@saikumar1016@gmail.com @gawasthi2010@gmail.com @anoop.shukla@netapp.com @jayaanand.borra@netapp.com:\n\ni recall very early on during the feature design that you were keen on preventing the abuse of encryption key references wrt share networks; i.e., you wanted to avoid tenants causing the creation of multiple share servers just by specifying new encryption keys. Is it possible to add a test to ensure this behavior works with the quota logic that was ultimately implemented?\n\ni.e., you have an \"encryption_keys\" quota that you can assign to a project or a project\u0027s user or to a project with a specific share type; to satisfy your use case, you\u0027d probably set this quota to 1 or a few.. would this suffice?","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ae985307604f3beb3cc90dbb1af8e67172442df6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"855986c0_37a0e986","updated":"2025-10-06 15:51:53.000000000","message":"I tried using the way suggested but face error of\n\n\u0027ServiceClients\u0027 object has no attribute \u0027secret_v1\u0027. Did you mean: \u0027share_v1\u0027?\n\n@gouthampravi@gmail.com\nI tried to add barbican-tempest-plugin in requirements.txt, but it throws error as nothing exist in openstack/requirements. \n\nIs above mentioned example of https://opendev.org/openstack/whitebox-tempest-plugin/src/commit/19f39aba511ddf6ecddd0e7dd5ae2440e57bdbbd/whitebox_tempest_plugin/api/compute/test_vtpm.py working code ??","commit_id":"45236fe6ef8356b8e1a79f30b9c2ccf5f8426dbc"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4947d517f0f4b8f4b7916dc582781dac2867873c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b91fbac6_b554dec3","in_reply_to":"855986c0_37a0e986","updated":"2025-10-06 16:26:00.000000000","message":"https://zuul.opendev.org/t/openstack/stream/3d947eb88d8b461da6fc5155eed30d79?logfile\u003dconsole.log","commit_id":"45236fe6ef8356b8e1a79f30b9c2ccf5f8426dbc"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ce78b2a62dda63204db65302d2c7b864450cf97b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"219a4a21_e2d37229","updated":"2025-10-10 11:22:42.000000000","message":"The secret are created using os_primary credentials while the share is created using some other user and hence manila fails to grant ACL via barbican.\n\n@gouthampravi@gmail.com\nIs it possible to run test as os_primary user only ?","commit_id":"e933314cd9960dace3eeb52fa9a5f8234f917b85"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3946f51041101ae017a2f913a1b82763f4e9bfa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"5659ea54_3bc6d8be","updated":"2025-10-14 09:35:40.000000000","message":"Goutham/Luigi\ncan you please reply at https://review.opendev.org/c/openstack/requirements/+/963685 ?\n\nthe requirement team is not allowing for this dependency","commit_id":"fe868063d757ee4d4303472c753e320679eaed23"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c68e7d1ad465d9ee1e3f4d7008e83a5af06b46ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"a91b8aec_24dde27c","updated":"2025-10-20 18:16:55.000000000","message":"LGTM, thank you.. A comment inline in case you make another patch.","commit_id":"fe868063d757ee4d4303472c753e320679eaed23"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"30bddd8161168974240936250f8e00d9a1826ff3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"4dbc6b87_e6700617","updated":"2025-11-11 19:37:20.000000000","message":"LGTM, thanks for working on this change, Kiran","commit_id":"fe868063d757ee4d4303472c753e320679eaed23"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"c6b70c2a10d34eb33ce6b9ee288f3f00a714a2cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"1c9c4883_d453bc14","updated":"2025-11-06 13:20:00.000000000","message":"Looks good, thanks for the coverage.","commit_id":"fe868063d757ee4d4303472c753e320679eaed23"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"dd62cb13e7a7d77fe884ed3b04898f83a3b3b2f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"e325332b_733def64","updated":"2025-10-14 21:43:07.000000000","message":"recheck to pickup new patchset in https://review.opendev.org/c/openstack/requirements/+/963685","commit_id":"fe868063d757ee4d4303472c753e320679eaed23"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ce380f5e5044f86599d09e8e6430b1def959178c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"81353c39_8da373d0","in_reply_to":"5659ea54_3bc6d8be","updated":"2025-10-14 10:33:16.000000000","message":"It is not correct that the requirement team has blocked the dependency. The requirement team is thinking about how to best handle the requirement.","commit_id":"fe868063d757ee4d4303472c753e320679eaed23"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0b86d93d12aa77ecf905435b36bc70985a69a31c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"802a69eb_cd3621a3","in_reply_to":"81353c39_8da373d0","updated":"2025-10-14 20:59:30.000000000","message":"I replied in the requirement change, you need to add barbican-tempest-plugin in the denylist.txt instead of g-r and upperconstraints - https://github.com/openstack/requirements/blob/73fb1fe9fc5f158ec49e33a79be73ba3641800f3/denylist.txt#L45","commit_id":"fe868063d757ee4d4303472c753e320679eaed23"}],"manila_tempest_tests/common/barbican_client_mgr.py":[{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4d5399a4fb82ef4edf307ba3be4cead12470d1d8","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        :returns: The barbican secret_ref."},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        manila_secret \u003d self.barbican.secrets.create("},{"line_number":70,"context_line":"            algorithm\u003d\u0027AES\u0027,"},{"line_number":71,"context_line":"            bit_length\u003d\u0027128\u0027,"},{"line_number":72,"context_line":"            secret_type\u003d\u0027symmetric\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ce7aa778_cfa1ca61","line":69,"updated":"2025-07-17 09:32:52.000000000","message":"Please generate the payload like below,\n\n key \u003d secrets.token_bytes(32)\n         manila_secret \u003d self.barbican.secrets.create(\n             algorithm\u003d\u0027AES\u0027,\n-            bit_length\u003d\u0027128\u0027,\n+            bit_length\u003d256,\n             secret_type\u003d\u0027symmetric\u0027,\n-            payload\u003d\u0027test\u0027\n+            payload \u003d base64.b64encode(key).decode(),\n+            payload_content_type \u003d \u0027application/octet-stream\u0027,\n+            payload_content_encoding \u003d \u0027base64\u0027,\n+            mode \u003d \u0027CBC\u0027\n         )\n\nAdd imports,\n+import secrets\n+import base64","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"93f24f4b4bb3bb0e876215dc9a05e578f47b37ff","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        :returns: The barbican secret_ref."},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        manila_secret \u003d self.barbican.secrets.create("},{"line_number":70,"context_line":"            algorithm\u003d\u0027AES\u0027,"},{"line_number":71,"context_line":"            bit_length\u003d\u0027128\u0027,"},{"line_number":72,"context_line":"            secret_type\u003d\u0027symmetric\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c05db729_a5298823","line":69,"in_reply_to":"ce7aa778_cfa1ca61","updated":"2025-07-17 09:34:00.000000000","message":"Done","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"54b7a7a4242d1156b88da4b4bfe71b7cb3babe8a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"import base64"},{"line_number":16,"context_line":"import secrets"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from barbicanclient import client"},{"line_number":19,"context_line":"from keystoneauth1 import identity"},{"line_number":20,"context_line":"from keystoneauth1 import session"},{"line_number":21,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":12,"id":"6526deea_372b6b61","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":33},"updated":"2025-10-02 21:27:40.000000000","message":"@ltoscano@redhat.com @gmaan@ghanshyammann.com:\n\nI\u0027m checking with you folks for guidance regarding this. I see references in tempest\u0027s documentation that we shouldn\u0027t use python-*-clients to interact with OpenStack services (e.g.: https://docs.openstack.org/tempest/latest/HACKING.html#tempest-specific-commandments) \n\nHow can one prevent the use of the service\u0027s client SDK in these sort of cases?","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"d47d3c1dff979e60d32ec1ff48ea899ef24cac3a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"import base64"},{"line_number":16,"context_line":"import secrets"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from barbicanclient import client"},{"line_number":19,"context_line":"from keystoneauth1 import identity"},{"line_number":20,"context_line":"from keystoneauth1 import session"},{"line_number":21,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":12,"id":"c6faf986_44df1c03","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":33},"in_reply_to":"6526deea_372b6b61","updated":"2025-10-02 22:56:13.000000000","message":"By not merging the patches which uses those clients... No other way sadly.","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"eacc2cb92ed8549dd1e61d301f66df0beed1436c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import base64"},{"line_number":16,"context_line":"import secrets"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from barbicanclient import client"},{"line_number":19,"context_line":"from keystoneauth1 import identity"},{"line_number":20,"context_line":"from keystoneauth1 import session"},{"line_number":21,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":12,"id":"855a7228_f321dfc4","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":33},"in_reply_to":"c6faf986_44df1c03","updated":"2025-10-07 07:17:58.000000000","message":"Acknowledged","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"c6b70c2a10d34eb33ce6b9ee288f3f00a714a2cb","unresolved":true,"context_lines":[{"line_number":40,"context_line":"                    \"This value is only used to validate the versions \""},{"line_number":41,"context_line":"                    \"response from Manila.\"),"},{"line_number":42,"context_line":"    cfg.StrOpt(\"max_api_microversion\","},{"line_number":43,"context_line":"               default\u003d\"2.90\","},{"line_number":44,"context_line":"               help\u003d\"The maximum api microversion is configured to be the \""},{"line_number":45,"context_line":"                    \"value of the latest microversion supported by Manila.\"),"},{"line_number":46,"context_line":"    cfg.StrOpt(\"region\","}],"source_content_type":"text/x-python","patch_set":2,"id":"5162a45a_ed19cf99","line":43,"range":{"start_line":43,"start_character":15,"end_line":43,"end_character":30},"updated":"2025-11-06 13:20:00.000000000","message":"Max in 2025.1/Epoxy is 2.89","commit_id":"fbdf440b4773b744b7da5338fd49c6c8dc37c50c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1e8e69f50604ac0978dfd4368cf13bd1792a1e0e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                    \"This value is only used to validate the versions \""},{"line_number":41,"context_line":"                    \"response from Manila.\"),"},{"line_number":42,"context_line":"    cfg.StrOpt(\"max_api_microversion\","},{"line_number":43,"context_line":"               default\u003d\"2.90\","},{"line_number":44,"context_line":"               help\u003d\"The maximum api microversion is configured to be the \""},{"line_number":45,"context_line":"                    \"value of the latest microversion supported by Manila.\"),"},{"line_number":46,"context_line":"    cfg.StrOpt(\"region\","}],"source_content_type":"text/x-python","patch_set":2,"id":"62b1b89a_dfc6a4b4","line":43,"range":{"start_line":43,"start_character":15,"end_line":43,"end_character":30},"in_reply_to":"5162a45a_ed19cf99","updated":"2025-11-06 13:22:12.000000000","message":"the encryption key is introduced with 2.90. So the tests will fails with 2.89.","commit_id":"fbdf440b4773b744b7da5338fd49c6c8dc37c50c"}],"manila_tempest_tests/tests/api/test_share_encryption.py":[{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4d5399a4fb82ef4edf307ba3be4cead12470d1d8","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        # create share_type"},{"line_number":48,"context_line":"        cls.share_type_enc \u003d cls.create_share_type("},{"line_number":49,"context_line":"            extra_specs\u003d{"},{"line_number":50,"context_line":"                \u0027encryption_support\u0027: \u0027share_server\u0027,"},{"line_number":51,"context_line":"            })"},{"line_number":52,"context_line":"        cls.share_type_enc_id \u003d cls.share_type_enc[\u0027id\u0027]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7d53926a_99461562","line":50,"updated":"2025-07-17 09:32:52.000000000","message":"Please add DHSS param,\n\u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"93f24f4b4bb3bb0e876215dc9a05e578f47b37ff","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # create share_type"},{"line_number":48,"context_line":"        cls.share_type_enc \u003d cls.create_share_type("},{"line_number":49,"context_line":"            extra_specs\u003d{"},{"line_number":50,"context_line":"                \u0027encryption_support\u0027: \u0027share_server\u0027,"},{"line_number":51,"context_line":"            })"},{"line_number":52,"context_line":"        cls.share_type_enc_id \u003d cls.share_type_enc[\u0027id\u0027]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bd746214_5efbabdf","line":50,"in_reply_to":"7d53926a_99461562","updated":"2025-07-17 09:34:00.000000000","message":"Done","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4d5399a4fb82ef4edf307ba3be4cead12470d1d8","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    def _store_secret(cls):"},{"line_number":60,"context_line":"        new_secret_ref \u003d cls.barbican_mgr.store_secret()"},{"line_number":61,"context_line":"        cls.addClassResourceCleanup(cls.barbican_mgr.delete_secret,"},{"line_number":62,"context_line":"                                    new_secret_ref)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @decorators.idempotent_id(\u002721ad41fb-04cf-493c-bc2f-66c80220898c\u0027)"},{"line_number":65,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"}],"source_content_type":"text/x-python","patch_set":4,"id":"cefae435_155e7eb4","line":62,"updated":"2025-07-17 09:32:52.000000000","message":"Please add return here,\n return new_secret_ref","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"93f24f4b4bb3bb0e876215dc9a05e578f47b37ff","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def _store_secret(cls):"},{"line_number":60,"context_line":"        new_secret_ref \u003d cls.barbican_mgr.store_secret()"},{"line_number":61,"context_line":"        cls.addClassResourceCleanup(cls.barbican_mgr.delete_secret,"},{"line_number":62,"context_line":"                                    new_secret_ref)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @decorators.idempotent_id(\u002721ad41fb-04cf-493c-bc2f-66c80220898c\u0027)"},{"line_number":65,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a123ac2f_af8e9e97","line":62,"in_reply_to":"cefae435_155e7eb4","updated":"2025-07-17 09:34:00.000000000","message":"Done","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4d5399a4fb82ef4edf307ba3be4cead12470d1d8","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        secret_href \u003d self._store_secret()"},{"line_number":75,"context_line":"        secret_href_uuid \u003d self.barbican_mgr.ref_to_uuid(secret_href)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        share \u003d self.shares_v2_client.create_share("},{"line_number":78,"context_line":"            share_protocol\u003dself.protocol,"},{"line_number":79,"context_line":"            share_type_id\u003dself.share_type_enc_id,"},{"line_number":80,"context_line":"            size\u003d1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"4726b02c_8728e434","line":77,"updated":"2025-07-17 09:32:52.000000000","message":"Have share network created and use it in self.create_share method instead of \" self.shares_v2_client.get_share\" like below,\n\n+        share_network_id \u003d self.create_share_network(\n+            cleanup_in_class\u003dFalse)[\u0027id\u0027]\n+        share \u003d self.create_share(\n+            share_protocol\u003d\u0027nfs\u0027,\n+            share_network_id \u003d share_network_id,","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"93f24f4b4bb3bb0e876215dc9a05e578f47b37ff","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        secret_href \u003d self._store_secret()"},{"line_number":75,"context_line":"        secret_href_uuid \u003d self.barbican_mgr.ref_to_uuid(secret_href)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        share \u003d self.shares_v2_client.create_share("},{"line_number":78,"context_line":"            share_protocol\u003dself.protocol,"},{"line_number":79,"context_line":"            share_type_id\u003dself.share_type_enc_id,"},{"line_number":80,"context_line":"            size\u003d1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"381c26e5_8982fb26","line":77,"in_reply_to":"4726b02c_8728e434","updated":"2025-07-17 09:34:00.000000000","message":"Done","commit_id":"b44daf308f4ac372810eb203e63c1c913b64d10e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48cfb2d24749a5df5f98d612b6bc97b760cfa5d0","unresolved":true,"context_lines":[{"line_number":29,"context_line":"@ddt.ddt"},{"line_number":30,"context_line":"class ShareEncryptionNFSTest(base.BaseSharesMixedTest):"},{"line_number":31,"context_line":"    \"\"\"Covers share functionality, that is related to NFS share type.\"\"\""},{"line_number":32,"context_line":"    protocol \u003d \"nfs\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff7f487_b0934da3","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":20},"updated":"2025-10-02 21:42:32.000000000","message":"Why worry about the protocol in these tests? Can we just use self.protocol and let the tests be generic?","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"eacc2cb92ed8549dd1e61d301f66df0beed1436c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"@ddt.ddt"},{"line_number":30,"context_line":"class ShareEncryptionNFSTest(base.BaseSharesMixedTest):"},{"line_number":31,"context_line":"    \"\"\"Covers share functionality, that is related to NFS share type.\"\"\""},{"line_number":32,"context_line":"    protocol \u003d \"nfs\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"e6c7b538_1ed2e1d5","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":20},"in_reply_to":"32e66dd3_174944df","updated":"2025-10-07 07:17:58.000000000","message":"Acknowledged","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ae985307604f3beb3cc90dbb1af8e67172442df6","unresolved":true,"context_lines":[{"line_number":29,"context_line":"@ddt.ddt"},{"line_number":30,"context_line":"class ShareEncryptionNFSTest(base.BaseSharesMixedTest):"},{"line_number":31,"context_line":"    \"\"\"Covers share functionality, that is related to NFS share type.\"\"\""},{"line_number":32,"context_line":"    protocol \u003d \"nfs\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"32e66dd3_174944df","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":20},"in_reply_to":"bff7f487_b0934da3","updated":"2025-10-06 15:51:53.000000000","message":"I followed share create scenario from manila_tempest_tests/tests/api/test_shares.py. Assuming Netapp support only NFS and CIFS. Do I have to remove the protocol and keep generic ?","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48cfb2d24749a5df5f98d612b6bc97b760cfa5d0","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(ShareEncryptionNFSTest, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.share.multitenancy_enabled:"},{"line_number":38,"context_line":"            raise cls.skipException(\u0027Multitenancy tests are disabled.\u0027)"},{"line_number":39,"context_line":"        if not CONF.share.run_encryption_tests:"},{"line_number":40,"context_line":"            raise cls.skipException(\u0027Encryption tests are disabled.\u0027)"},{"line_number":41,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.90\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"25293da8_6b0effb8","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":71},"updated":"2025-10-02 21:42:32.000000000","message":"let\u0027s drop this, we don\u0027t expect anyone setting \"run_encryption_tests\" by accident, and even if they do, they\u0027ll soon realize the feature doesn\u0027t work","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ae985307604f3beb3cc90dbb1af8e67172442df6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(ShareEncryptionNFSTest, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.share.multitenancy_enabled:"},{"line_number":38,"context_line":"            raise cls.skipException(\u0027Multitenancy tests are disabled.\u0027)"},{"line_number":39,"context_line":"        if not CONF.share.run_encryption_tests:"},{"line_number":40,"context_line":"            raise cls.skipException(\u0027Encryption tests are disabled.\u0027)"},{"line_number":41,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.90\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f9be5f2_e5b2e5ca","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":71},"in_reply_to":"25293da8_6b0effb8","updated":"2025-10-06 15:51:53.000000000","message":"Done","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48cfb2d24749a5df5f98d612b6bc97b760cfa5d0","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":"        if \u0027share_server\u0027 in CONF.share.capability_encryption_support:"},{"line_number":55,"context_line":"            extra_specs.update({\u0027encryption_support\u0027: \u0027share_server\u0027})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # create share_type"},{"line_number":58,"context_line":"        cls.share_type_enc \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":59,"context_line":"        cls.share_type_enc_id \u003d cls.share_type_enc[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"ec7d8930_f4e87c44","line":56,"updated":"2025-10-02 21:42:32.000000000","message":"```\nelse:\n  extra_specs.update({\u0027encryption_support\u0027: \u0027share\u0027})\n```","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ae985307604f3beb3cc90dbb1af8e67172442df6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":"        if \u0027share_server\u0027 in CONF.share.capability_encryption_support:"},{"line_number":55,"context_line":"            extra_specs.update({\u0027encryption_support\u0027: \u0027share_server\u0027})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # create share_type"},{"line_number":58,"context_line":"        cls.share_type_enc \u003d cls.create_share_type(extra_specs\u003dextra_specs)"},{"line_number":59,"context_line":"        cls.share_type_enc_id \u003d cls.share_type_enc[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"5bb9a51f_bbf4ef27","line":56,"in_reply_to":"ec7d8930_f4e87c44","updated":"2025-10-06 15:51:53.000000000","message":"Done","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48cfb2d24749a5df5f98d612b6bc97b760cfa5d0","unresolved":true,"context_lines":[{"line_number":73,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":74,"context_line":"    def test_create_share_with_share_server_encryption_key_ref(self):"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if \u0027share_server\u0027 not in CONF.share.capability_encryption_support:"},{"line_number":77,"context_line":"            raise self.skipException(\"Only \u0027share_server\u0027 encryption \""},{"line_number":78,"context_line":"                                     \"support tests are enabled.\")"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        secret_href \u003d self._store_secret()"},{"line_number":81,"context_line":"        secret_href_uuid \u003d self.barbican_mgr.ref_to_uuid(secret_href)"}],"source_content_type":"text/x-python","patch_set":12,"id":"b26c87e0_cd66f3ad","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":66},"updated":"2025-10-02 21:42:32.000000000","message":"No need to double check this","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ae985307604f3beb3cc90dbb1af8e67172442df6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":74,"context_line":"    def test_create_share_with_share_server_encryption_key_ref(self):"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if \u0027share_server\u0027 not in CONF.share.capability_encryption_support:"},{"line_number":77,"context_line":"            raise self.skipException(\"Only \u0027share_server\u0027 encryption \""},{"line_number":78,"context_line":"                                     \"support tests are enabled.\")"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        secret_href \u003d self._store_secret()"},{"line_number":81,"context_line":"        secret_href_uuid \u003d self.barbican_mgr.ref_to_uuid(secret_href)"}],"source_content_type":"text/x-python","patch_set":12,"id":"96c2697c_8b4f669f","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":66},"in_reply_to":"b26c87e0_cd66f3ad","updated":"2025-10-06 15:51:53.000000000","message":"Done","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48cfb2d24749a5df5f98d612b6bc97b760cfa5d0","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        secret_href \u003d self._store_secret()"},{"line_number":81,"context_line":"        secret_href_uuid \u003d self.barbican_mgr.ref_to_uuid(secret_href)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        share_network_id \u003d self.create_share_network("},{"line_number":84,"context_line":"            cleanup_in_class\u003dFalse)[\u0027id\u0027]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        share \u003d self.create_share("},{"line_number":87,"context_line":"            share_protocol\u003dself.protocol,"}],"source_content_type":"text/x-python","patch_set":12,"id":"8411127e_506b73c8","line":84,"range":{"start_line":83,"start_character":27,"end_line":84,"end_character":41},"updated":"2025-10-02 21:42:32.000000000","message":"wouldn\u0027t you be able to use self.shares_v2_client.share_network_id?","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ae985307604f3beb3cc90dbb1af8e67172442df6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        secret_href \u003d self._store_secret()"},{"line_number":81,"context_line":"        secret_href_uuid \u003d self.barbican_mgr.ref_to_uuid(secret_href)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        share_network_id \u003d self.create_share_network("},{"line_number":84,"context_line":"            cleanup_in_class\u003dFalse)[\u0027id\u0027]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        share \u003d self.create_share("},{"line_number":87,"context_line":"            share_protocol\u003dself.protocol,"}],"source_content_type":"text/x-python","patch_set":12,"id":"79505b40_dac30c55","line":84,"range":{"start_line":83,"start_character":27,"end_line":84,"end_character":41},"in_reply_to":"8411127e_506b73c8","updated":"2025-10-06 15:51:53.000000000","message":"Done","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c68e7d1ad465d9ee1e3f4d7008e83a5af06b46ef","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u002721ad41fb-04cf-493c-bc2f-66c80220898c\u0027)"},{"line_number":71,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":72,"context_line":"    def test_create_share_with_share_server_encryption_key_ref(self):"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        secret_href \u003d self.barbican_mgr.store_secret()"},{"line_number":75,"context_line":"        secret_href_uuid \u003d self.barbican_mgr.ref_to_uuid(secret_href)"}],"source_content_type":"text/x-python","patch_set":26,"id":"c3ef465b_02300740","line":72,"range":{"start_line":72,"start_character":26,"end_line":72,"end_character":43},"updated":"2025-10-20 18:16:55.000000000","message":"i\u0027d drop \"with_share_server\" from this test name","commit_id":"fe868063d757ee4d4303472c753e320679eaed23"}],"manila_tempest_tests/tests/api/test_share_encryption_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48cfb2d24749a5df5f98d612b6bc97b760cfa5d0","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def skip_checks(cls):"},{"line_number":30,"context_line":"        super(SharesEncryptionNegativeTest, cls).skip_checks()"},{"line_number":31,"context_line":"        if not CONF.share.multitenancy_enabled:"},{"line_number":32,"context_line":"            raise cls.skipException(\u0027Multitenancy tests are disabled.\u0027)"},{"line_number":33,"context_line":"        if not CONF.share.run_encryption_tests:"},{"line_number":34,"context_line":"            raise cls.skipException(\u0027Encryption tests are disabled.\u0027)"},{"line_number":35,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.90\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"873894d0_504852ba","line":32,"range":{"start_line":30,"start_character":62,"end_line":32,"end_character":71},"updated":"2025-10-02 21:42:32.000000000","message":"remove","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ae985307604f3beb3cc90dbb1af8e67172442df6","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def skip_checks(cls):"},{"line_number":30,"context_line":"        super(SharesEncryptionNegativeTest, cls).skip_checks()"},{"line_number":31,"context_line":"        if not CONF.share.multitenancy_enabled:"},{"line_number":32,"context_line":"            raise cls.skipException(\u0027Multitenancy tests are disabled.\u0027)"},{"line_number":33,"context_line":"        if not CONF.share.run_encryption_tests:"},{"line_number":34,"context_line":"            raise cls.skipException(\u0027Encryption tests are disabled.\u0027)"},{"line_number":35,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.90\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"495d786d_6c11eb8b","line":32,"range":{"start_line":30,"start_character":62,"end_line":32,"end_character":71},"in_reply_to":"873894d0_504852ba","updated":"2025-10-06 15:51:53.000000000","message":"Done","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48cfb2d24749a5df5f98d612b6bc97b760cfa5d0","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    def resource_setup(cls):"},{"line_number":39,"context_line":"        super(SharesEncryptionNegativeTest, cls).resource_setup()"},{"line_number":40,"context_line":"        # create share_type"},{"line_number":41,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":42,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":43,"context_line":"        cls.share_type_enc \u003d cls.create_share_type("},{"line_number":44,"context_line":"            extra_specs\u003d{"},{"line_number":45,"context_line":"                \u0027encryption_support\u0027: \u0027share_server\u0027,"},{"line_number":46,"context_line":"            })"},{"line_number":47,"context_line":"        cls.share_type_enc_id \u003d cls.share_type_enc[\u0027id\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @decorators.idempotent_id(\u0027b8097d56-067e-4d7c-8401-31bc7021fe81\u0027)"},{"line_number":50,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dd283c0d_40c8fb09","line":47,"range":{"start_line":41,"start_character":8,"end_line":47,"end_character":56},"updated":"2025-10-02 21:42:32.000000000","message":"```suggestion\n        cls.no_encryption_type \u003d cls.create_share_type()\n        cls.no_encryption_type_id \u003d cls.no_encryption_type[\u0027id\u0027]\n        cls.encryption_type \u003d cls.create_share_type(\n            extra_specs\u003d{\n                \u0027encryption_support\u0027: \u0027share_server\u0027,\n            })\n        cls.encryption_type_id \u003d cls.encryption_type[\u0027id\u0027]\n```","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ae985307604f3beb3cc90dbb1af8e67172442df6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def resource_setup(cls):"},{"line_number":39,"context_line":"        super(SharesEncryptionNegativeTest, cls).resource_setup()"},{"line_number":40,"context_line":"        # create share_type"},{"line_number":41,"context_line":"        cls.share_type \u003d cls.create_share_type()"},{"line_number":42,"context_line":"        cls.share_type_id \u003d cls.share_type[\u0027id\u0027]"},{"line_number":43,"context_line":"        cls.share_type_enc \u003d cls.create_share_type("},{"line_number":44,"context_line":"            extra_specs\u003d{"},{"line_number":45,"context_line":"                \u0027encryption_support\u0027: \u0027share_server\u0027,"},{"line_number":46,"context_line":"            })"},{"line_number":47,"context_line":"        cls.share_type_enc_id \u003d cls.share_type_enc[\u0027id\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @decorators.idempotent_id(\u0027b8097d56-067e-4d7c-8401-31bc7021fe81\u0027)"},{"line_number":50,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":12,"id":"64dbc487_3f43314d","line":47,"range":{"start_line":41,"start_character":8,"end_line":47,"end_character":56},"in_reply_to":"dd283c0d_40c8fb09","updated":"2025-10-06 15:51:53.000000000","message":"Done","commit_id":"621a9c9115c57d0f71588a1151e327bd2576d2c7"}],"manila_tempest_tests/tests/api/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf93aa30ca54671e41bea3599ff6ae5f2a19df96","unresolved":true,"context_lines":[{"line_number":128,"context_line":"                          self.shares_v2_client.get_share,"},{"line_number":129,"context_line":"                          share[\u0027id\u0027])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @decorators.idempotent_id(\u002721ad41fb-04cf-493c-bc2f-66c80220898c\u0027)"},{"line_number":132,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":133,"context_line":"    def test_create_share_with_encryption_key_ref(self):"},{"line_number":134,"context_line":"        try:"},{"line_number":135,"context_line":"            ks_loading.register_auth_conf_options(self.conf,"},{"line_number":136,"context_line":"                                                  \u0027keystone_authtoken\u0027)"},{"line_number":137,"context_line":"            auth \u003d ks_loading.load_auth_from_conf_options(self.conf,"}],"source_content_type":"text/x-python","patch_set":3,"id":"b67e2b86_af946d97","line":134,"range":{"start_line":131,"start_character":3,"end_line":134,"end_character":3},"updated":"2025-07-10 23:48:37.000000000","message":"For extensibility, I suggest creating a separate module and test class for encryption tests, you can have positive and negative test modules as is the pattern in this repository","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8a73677e21421cf1e6772422f9e41b89a1890372","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                          self.shares_v2_client.get_share,"},{"line_number":129,"context_line":"                          share[\u0027id\u0027])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @decorators.idempotent_id(\u002721ad41fb-04cf-493c-bc2f-66c80220898c\u0027)"},{"line_number":132,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":133,"context_line":"    def test_create_share_with_encryption_key_ref(self):"},{"line_number":134,"context_line":"        try:"},{"line_number":135,"context_line":"            ks_loading.register_auth_conf_options(self.conf,"},{"line_number":136,"context_line":"                                                  \u0027keystone_authtoken\u0027)"},{"line_number":137,"context_line":"            auth \u003d ks_loading.load_auth_from_conf_options(self.conf,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c0a976f6_91e6c5bb","line":134,"range":{"start_line":131,"start_character":3,"end_line":134,"end_character":3},"in_reply_to":"b67e2b86_af946d97","updated":"2025-07-11 14:44:50.000000000","message":"Done","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf93aa30ca54671e41bea3599ff6ae5f2a19df96","unresolved":true,"context_lines":[{"line_number":147,"context_line":"                                         secret_type\u003d\u0027symmetric\u0027,"},{"line_number":148,"context_line":"                                         mode\u003dNone,"},{"line_number":149,"context_line":"                                         payload\u003d\u0027test\u0027)"},{"line_number":150,"context_line":"        secret_href \u003d secret.store()"},{"line_number":151,"context_line":"        secret_href_uuid \u003d secret_href.rpartition(\u0027/\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        share_type_enc \u003d self.create_share_type("},{"line_number":154,"context_line":"            extra_specs\u003d{"}],"source_content_type":"text/x-python","patch_set":3,"id":"93a4333c_a3e81833","line":151,"range":{"start_line":150,"start_character":8,"end_line":151,"end_character":54},"updated":"2025-07-10 23:48:37.000000000","message":"when you use the implementation from barbican\u0027s tempest client:\n\n\nhttps://opendev.org/openstack/barbican-tempest-plugin/src/commit/2cd185133a86242c58d721e66c2db753a369fe60/barbican_tempest_plugin/services/key_manager/json/secret_client.py#L48","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8a73677e21421cf1e6772422f9e41b89a1890372","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                                         secret_type\u003d\u0027symmetric\u0027,"},{"line_number":148,"context_line":"                                         mode\u003dNone,"},{"line_number":149,"context_line":"                                         payload\u003d\u0027test\u0027)"},{"line_number":150,"context_line":"        secret_href \u003d secret.store()"},{"line_number":151,"context_line":"        secret_href_uuid \u003d secret_href.rpartition(\u0027/\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        share_type_enc \u003d self.create_share_type("},{"line_number":154,"context_line":"            extra_specs\u003d{"}],"source_content_type":"text/x-python","patch_set":3,"id":"21bcc5fc_fffb7961","line":151,"range":{"start_line":150,"start_character":8,"end_line":151,"end_character":54},"in_reply_to":"93a4333c_a3e81833","updated":"2025-07-11 14:44:50.000000000","message":"Done","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf93aa30ca54671e41bea3599ff6ae5f2a19df96","unresolved":true,"context_lines":[{"line_number":158,"context_line":"            share_protocol\u003dself.protocol,"},{"line_number":159,"context_line":"            share_type_id\u003dshare_type_enc[\u0027id\u0027],"},{"line_number":160,"context_line":"            size\u003d1,"},{"line_number":161,"context_line":"            name\u003d\"encyrpted_share\","},{"line_number":162,"context_line":"            encryption_key_ref\u003dsecret_href)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self.assertIn(share[\u0027status\u0027], (\u0027creating\u0027, \u0027available\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"a1f84af9_314fec26","line":161,"range":{"start_line":161,"start_character":18,"end_line":161,"end_character":33},"updated":"2025-07-10 23:48:37.000000000","message":"typo","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8a73677e21421cf1e6772422f9e41b89a1890372","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            share_protocol\u003dself.protocol,"},{"line_number":159,"context_line":"            share_type_id\u003dshare_type_enc[\u0027id\u0027],"},{"line_number":160,"context_line":"            size\u003d1,"},{"line_number":161,"context_line":"            name\u003d\"encyrpted_share\","},{"line_number":162,"context_line":"            encryption_key_ref\u003dsecret_href)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self.assertIn(share[\u0027status\u0027], (\u0027creating\u0027, \u0027available\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a7987e5_58d910e2","line":161,"range":{"start_line":161,"start_character":18,"end_line":161,"end_character":33},"in_reply_to":"a1f84af9_314fec26","updated":"2025-07-11 14:44:50.000000000","message":"Done","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf93aa30ca54671e41bea3599ff6ae5f2a19df96","unresolved":true,"context_lines":[{"line_number":174,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":175,"context_line":"                          self.shares_v2_client.get_share,"},{"line_number":176,"context_line":"                          share[\u0027id\u0027])"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @decorators.idempotent_id(\u0027775f8f87-5727-4bb7-b69f-9ce6b9bdb140\u0027)"},{"line_number":179,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":180,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"}],"source_content_type":"text/x-python","patch_set":3,"id":"64ef9248_87714f3f","line":177,"updated":"2025-07-10 23:48:37.000000000","message":"a few things:\n\n1) this test is only appropriate for DHSS\u003dTrue, so it needs to be skipped when multitenancy_enabled \u003d False\n2) Test needs to be skipped for API versions \u003c 2.90\n3) Most feature based tests have a config opt as well that controls whether the test can be run, and for optional features, the config opt defaults to False\n4) Also assert that the share network\u0027s encryption_key_ref is what the user supplied.","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8a73677e21421cf1e6772422f9e41b89a1890372","unresolved":true,"context_lines":[{"line_number":174,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":175,"context_line":"                          self.shares_v2_client.get_share,"},{"line_number":176,"context_line":"                          share[\u0027id\u0027])"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @decorators.idempotent_id(\u0027775f8f87-5727-4bb7-b69f-9ce6b9bdb140\u0027)"},{"line_number":179,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":180,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d2ab9fb7_7834d5d3","line":177,"in_reply_to":"64ef9248_87714f3f","updated":"2025-07-11 14:44:50.000000000","message":"All added except 4. Its share server encryption key ref and not share network.","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e1dcff60166f0f636cfd0c179e723a63f9c4fd46","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":175,"context_line":"                          self.shares_v2_client.get_share,"},{"line_number":176,"context_line":"                          share[\u0027id\u0027])"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @decorators.idempotent_id(\u0027775f8f87-5727-4bb7-b69f-9ce6b9bdb140\u0027)"},{"line_number":179,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":180,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4deefef3_0aba41aa","line":177,"in_reply_to":"d2ab9fb7_7834d5d3","updated":"2025-07-25 07:22:26.000000000","message":"Jul 25 07:04:38.094674 np3bf064cc4b5f4 manila-share[48837]: DEBUG manila.tests.share.drivers.dummy [None req-819690f4-2a25-4abd-ac05-5cc85ee49dbb tempest-ShareEncryptionNFSTest-671080646 None] Generated encryption_key_href https://10.209.32.111/key-manager/v1/secrets/0e54dbc5-6435-4835-91f9-df40ef52a16e for share create request. {{(pid\u003d48837) _create_share /opt/stack/manila/manila/tests/share/drivers/dummy.py:266}}\n\nThis validates encryption_key_ref is what user supplied in API.","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"}],"manila_tempest_tests/tests/api/test_shares_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf93aa30ca54671e41bea3599ff6ae5f2a19df96","unresolved":true,"context_lines":[{"line_number":317,"context_line":"    @decorators.idempotent_id(\u0027b8097d56-067e-4d7c-8401-31bc7021fe81\u0027)"},{"line_number":318,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":319,"context_line":"    def test_create_share_with_invalid_share_type(self):"},{"line_number":320,"context_line":"        # should not create share when key ref is invalid UUID"},{"line_number":321,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":322,"context_line":"                          self.shares_v2_client.create_share,"},{"line_number":323,"context_line":"                          share_type_id\u003dself.share_type_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"191f317a_2daf722d","line":320,"range":{"start_line":320,"start_character":39,"end_line":320,"end_character":62},"updated":"2025-07-10 23:48:37.000000000","message":"encryption isn\u0027t supported by share type","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8a73677e21421cf1e6772422f9e41b89a1890372","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    @decorators.idempotent_id(\u0027b8097d56-067e-4d7c-8401-31bc7021fe81\u0027)"},{"line_number":318,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":319,"context_line":"    def test_create_share_with_invalid_share_type(self):"},{"line_number":320,"context_line":"        # should not create share when key ref is invalid UUID"},{"line_number":321,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":322,"context_line":"                          self.shares_v2_client.create_share,"},{"line_number":323,"context_line":"                          share_type_id\u003dself.share_type_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c41927cc_c32a4b09","line":320,"range":{"start_line":320,"start_character":39,"end_line":320,"end_character":62},"in_reply_to":"191f317a_2daf722d","updated":"2025-07-11 14:44:50.000000000","message":"Done","commit_id":"6609029b6ae14cbdb203450fd56566f545d48fa3"}]}