)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"31f9e307148a5264a45cabe75168c8a7bfca08d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"92b69a0a_bbd5627c","updated":"2025-07-21 12:36:58.000000000","message":"recheck","commit_id":"d0db1075d09552d7ddeac118553e02599dd0e29b"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2787cec1a8773ca9cc0164ad04a24cba821d4caf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4e3433e5_d3a1b745","updated":"2025-07-29 03:39:44.000000000","message":"LGTM","commit_id":"dcae9879282d1a4817485057d7a90bb0076bbf4e"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"86db49493aad407bf7b501bf48d36dfb1f977d5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"613695a7_464164a3","updated":"2025-07-30 12:05:21.000000000","message":"LGTM ..!","commit_id":"dcae9879282d1a4817485057d7a90bb0076bbf4e"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"6a4fe04571ab9c2d34db105d9766440998511a7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a39d46df_13a5505d","updated":"2025-07-28 17:37:21.000000000","message":"Looks good, thanks.","commit_id":"dcae9879282d1a4817485057d7a90bb0076bbf4e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ddf739ad40c13e56db2c376effc9c9442b203d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e2a18e9c_7400489b","updated":"2025-07-31 14:58:48.000000000","message":"Since this won\u0027t merge yet because of the dependency, could you please update this based on the comment inline?","commit_id":"dcae9879282d1a4817485057d7a90bb0076bbf4e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"88717914b8e8c2ae9ee2d9316e24bfad81477a00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6fb95085_a9dc52d2","updated":"2025-07-24 12:21:55.000000000","message":"Tested","commit_id":"dcae9879282d1a4817485057d7a90bb0076bbf4e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"897abc1431abd98b3e4ffc5834e4988f7bdb4b91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"aa778d6c_72789ebd","updated":"2025-08-04 17:26:51.000000000","message":"LGTM, thanks Sai","commit_id":"7dba712f422e93897d52ce6bb77dd96c702d0730"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"f0c3d191dfc61cb1cf5341d1caf48b5ddacbdd34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"23adeba2_a940ccb0","updated":"2025-08-04 14:34:13.000000000","message":"Thank you for your feedback Goutham. Addressed the comments.","commit_id":"7dba712f422e93897d52ce6bb77dd96c702d0730"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c8b38784427c098b48507d61972e111fd4e14c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1ac10105_9060dffc","updated":"2025-09-11 18:09:00.000000000","message":"recheck\n\ndependent patches have merged","commit_id":"7dba712f422e93897d52ce6bb77dd96c702d0730"}],"zuul.d/manila-tempest-jobs.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4ffdd91613e7f5f8b120f53451e076746e742bb4","unresolved":true,"context_lines":[{"line_number":704,"context_line":"    parent: manila-tempest-plugin-standalone-base"},{"line_number":705,"context_line":"    required-projects:"},{"line_number":706,"context_line":"      - openstack/barbican"},{"line_number":707,"context_line":"    vars:"},{"line_number":708,"context_line":"      devstack_localrc:"},{"line_number":709,"context_line":"        SHARE_DRIVER: manila.tests.share.drivers.dummy.DummyDriver"},{"line_number":710,"context_line":"        MANILA_CONFIGURE_GROUPS: alpha,beta,gamma,membernet,adminnet,netapp_active_iq"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9d0f61c5_1efd4028","line":707,"range":{"start_line":707,"start_character":4,"end_line":707,"end_character":9},"updated":"2025-07-18 21:01:33.000000000","message":"please add barbican as an enabled plugin","commit_id":"eb29d9c7790e246457e6a98d9268dff9a96da3ed"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c90eb7df78e271cd8e168b965d1f4c52ae47af71","unresolved":false,"context_lines":[{"line_number":704,"context_line":"    parent: manila-tempest-plugin-standalone-base"},{"line_number":705,"context_line":"    required-projects:"},{"line_number":706,"context_line":"      - openstack/barbican"},{"line_number":707,"context_line":"    vars:"},{"line_number":708,"context_line":"      devstack_localrc:"},{"line_number":709,"context_line":"        SHARE_DRIVER: manila.tests.share.drivers.dummy.DummyDriver"},{"line_number":710,"context_line":"        MANILA_CONFIGURE_GROUPS: alpha,beta,gamma,membernet,adminnet,netapp_active_iq"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1288f6fd_987dce92","line":707,"range":{"start_line":707,"start_character":4,"end_line":707,"end_character":9},"in_reply_to":"4f6b377c_80389eaf","updated":"2025-07-24 07:42:09.000000000","message":"Resolved","commit_id":"eb29d9c7790e246457e6a98d9268dff9a96da3ed"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c23ddb29abd81876e9d852ee7022ebbc7f4cc0f0","unresolved":true,"context_lines":[{"line_number":704,"context_line":"    parent: manila-tempest-plugin-standalone-base"},{"line_number":705,"context_line":"    required-projects:"},{"line_number":706,"context_line":"      - openstack/barbican"},{"line_number":707,"context_line":"    vars:"},{"line_number":708,"context_line":"      devstack_localrc:"},{"line_number":709,"context_line":"        SHARE_DRIVER: manila.tests.share.drivers.dummy.DummyDriver"},{"line_number":710,"context_line":"        MANILA_CONFIGURE_GROUPS: alpha,beta,gamma,membernet,adminnet,netapp_active_iq"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4f6b377c_80389eaf","line":707,"range":{"start_line":707,"start_character":4,"end_line":707,"end_character":9},"in_reply_to":"9d0f61c5_1efd4028","updated":"2025-07-24 07:41:53.000000000","message":"Done.","commit_id":"eb29d9c7790e246457e6a98d9268dff9a96da3ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c506c943655de47a18d10ac0030f71bceffc483","unresolved":true,"context_lines":[{"line_number":750,"context_line":"        MANILA_OPTGROUP_gamma_driver_handles_share_servers: false"},{"line_number":751,"context_line":"        MANILA_OPTGROUP_gamma_share_backend_name: GAMMA"},{"line_number":752,"context_line":"        MANILA_OPTGROUP_gamma_share_driver: manila.tests.share.drivers.dummy.DummyDriver"},{"line_number":753,"context_line":"        SERVICE_PROTOCOL: https"},{"line_number":754,"context_line":"      devstack_local_conf:"},{"line_number":755,"context_line":"        test-config:"},{"line_number":756,"context_line":"          \"$TEMPEST_CONFIG\":"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"00f7b561_bac1b639","line":753,"range":{"start_line":753,"start_character":8,"end_line":753,"end_character":31},"updated":"2025-07-31 04:43:22.000000000","message":"why is this necessary?\n\nWe always enable tls-proxy (see line 39), so all service endpoints would be exposed with https.","commit_id":"dcae9879282d1a4817485057d7a90bb0076bbf4e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"2fce3e23426c6c57903f6835dd28fe50d7b4c319","unresolved":true,"context_lines":[{"line_number":750,"context_line":"        MANILA_OPTGROUP_gamma_driver_handles_share_servers: false"},{"line_number":751,"context_line":"        MANILA_OPTGROUP_gamma_share_backend_name: GAMMA"},{"line_number":752,"context_line":"        MANILA_OPTGROUP_gamma_share_driver: manila.tests.share.drivers.dummy.DummyDriver"},{"line_number":753,"context_line":"        SERVICE_PROTOCOL: https"},{"line_number":754,"context_line":"      devstack_local_conf:"},{"line_number":755,"context_line":"        test-config:"},{"line_number":756,"context_line":"          \"$TEMPEST_CONFIG\":"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f478907_31de1920","line":753,"range":{"start_line":753,"start_character":8,"end_line":753,"end_character":31},"in_reply_to":"00f7b561_bac1b639","updated":"2025-07-31 11:39:18.000000000","message":"Hi Goutham/Carloss,\n\nhost_href in barbican.conf is by default coming as http and we wanted https. \n\nEarlier: https://zuul.opendev.org/t/openstack/build/cd226c33eb494eb2968dd582340ed4d6/log/controller/logs/etc/barbican/barbican_conf.txt#7\n\nAfter updating service_protocol to https,\nhttps://zuul.opendev.org/t/openstack/build/7b6e5c8d9b3b4d6e971dbdc97c317775/log/controller/logs/etc/barbican/barbican_conf.txt#7\n\nYes Carloss, attempted and seeing http only. \n\nOur ONTAP team wanted hist_href to be https by default in barbican.conf so had to update the service_protocol as discussed with you. \n\nThank you!!","commit_id":"dcae9879282d1a4817485057d7a90bb0076bbf4e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"08852e14882c1b437cb19087145a9025d79cdaa5","unresolved":true,"context_lines":[{"line_number":750,"context_line":"        MANILA_OPTGROUP_gamma_driver_handles_share_servers: false"},{"line_number":751,"context_line":"        MANILA_OPTGROUP_gamma_share_backend_name: GAMMA"},{"line_number":752,"context_line":"        MANILA_OPTGROUP_gamma_share_driver: manila.tests.share.drivers.dummy.DummyDriver"},{"line_number":753,"context_line":"        SERVICE_PROTOCOL: https"},{"line_number":754,"context_line":"      devstack_local_conf:"},{"line_number":755,"context_line":"        test-config:"},{"line_number":756,"context_line":"          \"$TEMPEST_CONFIG\":"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ade69ee_7d90fcb8","line":753,"range":{"start_line":753,"start_character":8,"end_line":753,"end_character":31},"in_reply_to":"00f7b561_bac1b639","updated":"2025-07-31 09:43:03.000000000","message":"I questioned the same thing while on a call with @saikumar1016@gmail.com... At the end, he mentioned that even though it was the default, endpoints would still be using http instead of https. Sai: have you attempted a recent devstack installation without this http flag to ensure it wouldn\u0027t really have https by default?","commit_id":"dcae9879282d1a4817485057d7a90bb0076bbf4e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ddf739ad40c13e56db2c376effc9c9442b203d2","unresolved":true,"context_lines":[{"line_number":750,"context_line":"        MANILA_OPTGROUP_gamma_driver_handles_share_servers: false"},{"line_number":751,"context_line":"        MANILA_OPTGROUP_gamma_share_backend_name: GAMMA"},{"line_number":752,"context_line":"        MANILA_OPTGROUP_gamma_share_driver: manila.tests.share.drivers.dummy.DummyDriver"},{"line_number":753,"context_line":"        SERVICE_PROTOCOL: https"},{"line_number":754,"context_line":"      devstack_local_conf:"},{"line_number":755,"context_line":"        test-config:"},{"line_number":756,"context_line":"          \"$TEMPEST_CONFIG\":"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bd5d49e1_5cf0c888","line":753,"range":{"start_line":753,"start_character":8,"end_line":753,"end_character":31},"in_reply_to":"7f478907_31de1920","updated":"2025-07-31 14:58:48.000000000","message":"Hmmm, not your fault - Barbican\u0027s devstack plugin doesn\u0027t automatically assume tls-proxy would need the SERVICE_PROTOCOL to be overridden with \"https\" like its done by all devstack scripts, including manila\u0027s . \n\nNot a biggie, but, we could just move this into the base job and add a comment that not all services use tls-proxy to also mean enabling https endpoints... \n\n\nhttps://github.com/openstack/barbican/blob/bfd1e72bf070a6a169882ad0abb88687f443a7da/devstack/lib/barbican#L13\n\nhttps://github.com/openstack/manila/blob/076231a7dcb41a2ff9eb3c6cda8ae1a49ebf7b49/devstack/plugin.sh#L292","commit_id":"dcae9879282d1a4817485057d7a90bb0076bbf4e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"f0c3d191dfc61cb1cf5341d1caf48b5ddacbdd34","unresolved":true,"context_lines":[{"line_number":750,"context_line":"        MANILA_OPTGROUP_gamma_driver_handles_share_servers: false"},{"line_number":751,"context_line":"        MANILA_OPTGROUP_gamma_share_backend_name: GAMMA"},{"line_number":752,"context_line":"        MANILA_OPTGROUP_gamma_share_driver: manila.tests.share.drivers.dummy.DummyDriver"},{"line_number":753,"context_line":"        SERVICE_PROTOCOL: https"},{"line_number":754,"context_line":"      devstack_local_conf:"},{"line_number":755,"context_line":"        test-config:"},{"line_number":756,"context_line":"          \"$TEMPEST_CONFIG\":"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"308cc539_4c40ca9d","line":753,"range":{"start_line":753,"start_character":8,"end_line":753,"end_character":31},"in_reply_to":"bd5d49e1_5cf0c888","updated":"2025-08-04 14:34:13.000000000","message":"Moved it to the base job and added a comment. Thank you Goutham.","commit_id":"dcae9879282d1a4817485057d7a90bb0076bbf4e"}]}
