)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9394e9719bd4c77c97366e881422c3ab00b0d48d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d35aaa85_2b427f45","updated":"2026-01-19 12:24:11.000000000","message":"recheck","commit_id":"73d557d646083bc3b517bf75ea88ad73a8bc4dac"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f9ac45899457f09fceceb60b1873f307ce64179d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f65d0847_2bc92c1b","updated":"2026-01-19 10:39:57.000000000","message":"recheck","commit_id":"73d557d646083bc3b517bf75ea88ad73a8bc4dac"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0e3f14e5c2fdec6dc34668996644c13fe55e16e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"eee12f27_bd356411","updated":"2026-02-05 09:00:06.000000000","message":"recheck","commit_id":"bf4f1169f72df6b4a7f4deb0aae7272444ab3395"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"938424c38b5a19cbcc7565dccfcfd4ca6cb3d05b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f590108c_0c5d58ab","updated":"2026-02-23 04:56:06.000000000","message":"Run-NetApp CI","commit_id":"7dec90115dc95ae38e898d26bd3acb1998972268"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8d9497ce3806d6dcac1e234d4dbf4b764efcc4bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a6241274_81fe94da","updated":"2026-02-19 15:44:53.000000000","message":"recheck","commit_id":"7dec90115dc95ae38e898d26bd3acb1998972268"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5b7598745d6c3f9d0dab7ad0bb023acff4645e40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b0b6fdb9_02d7194f","updated":"2026-02-20 11:28:44.000000000","message":"recheck","commit_id":"7dec90115dc95ae38e898d26bd3acb1998972268"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7320486397b32354a302cecfe0ac0d2a7c0c9d74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bf3cbc5f_ed16d859","updated":"2026-02-19 13:11:57.000000000","message":"recheck","commit_id":"7dec90115dc95ae38e898d26bd3acb1998972268"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"6a1d50e0ec79f2be71d39ab7eae1dc2d8f78aaef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"53e4b655_3aa38995","updated":"2026-02-23 05:03:56.000000000","message":"run-NetApp CI","commit_id":"7dec90115dc95ae38e898d26bd3acb1998972268"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c74a41f509a628a188d4692ada95b86099827516","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"139ea82e_9c10fea0","updated":"2026-03-02 08:13:39.000000000","message":"recheck","commit_id":"b6a4483c64d0bec1ab8a0406cd2078d1bc1fe1c1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d43f3675930b3bc86fa1a9a2411074aec78822be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3bf462cc_92e79e0c","updated":"2026-03-12 15:35:04.000000000","message":"recheck","commit_id":"b6a4483c64d0bec1ab8a0406cd2078d1bc1fe1c1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"735ab9ed7f3a5241ebe0fd7e2f9921a84d829d19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4a5260f4_c80967b9","updated":"2026-03-10 14:32:13.000000000","message":"recheck","commit_id":"b6a4483c64d0bec1ab8a0406cd2078d1bc1fe1c1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"be9333a22b5335d6bb360e0d264cb100a1fcf3ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8a6b5818_bb868939","updated":"2026-02-26 18:32:26.000000000","message":"recheck","commit_id":"b6a4483c64d0bec1ab8a0406cd2078d1bc1fe1c1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b8050726c6b451519a440fccaa39a720053339bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"02e63ea7_67b648b4","updated":"2026-03-31 15:58:05.000000000","message":"recheck","commit_id":"2f3cd5dcc125977bc24bbac8bcb6c73fbc89774a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a2fad88686ca1bd799beb88d70363353c480ca23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0c35127f_6ea60ea1","updated":"2026-03-17 03:46:29.000000000","message":"recheck","commit_id":"2f3cd5dcc125977bc24bbac8bcb6c73fbc89774a"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2c84bf95_ff3edded","updated":"2026-06-12 18:27:06.000000000","message":"@kiranpawarpict2010@gmail.com thank you for working on this change. Please see my feedback inline.","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"0723ec20e5f24701499a78badbaaf793856d1f0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1f1f1eec_7eb65512","updated":"2026-06-11 15:23:03.000000000","message":"LGTM.","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2b2db1ea_fe7cd7e9","in_reply_to":"2c84bf95_ff3edded","updated":"2026-06-16 08:50:43.000000000","message":"Acknowledged","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":2661,"context_line":"                        version\u003dLATEST_MICROVERSION, **kwargs):"},{"line_number":2662,"context_line":"        post_body \u003d {"},{"line_number":2663,"context_line":"            \u0027name\u0027: name,"},{"line_number":2664,"context_line":"            \u0027specs\u0027: kwargs.get(\u0027specs\u0027),"},{"line_number":2665,"context_line":"        }"},{"line_number":2666,"context_line":"        if kwargs.get(\u0027description\u0027):"},{"line_number":2667,"context_line":"            post_body[\u0027description\u0027] \u003d kwargs.get(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fcc4aab6_efdbfd98","line":2664,"range":{"start_line":2664,"start_character":12,"end_line":2664,"end_character":41},"updated":"2026-06-12 18:27:06.000000000","message":"Suggest bellow change, so the API always returns None\n\u0027specs\u0027: kwargs.get(\u0027specs\u0027) or {},","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":2661,"context_line":"                        version\u003dLATEST_MICROVERSION, **kwargs):"},{"line_number":2662,"context_line":"        post_body \u003d {"},{"line_number":2663,"context_line":"            \u0027name\u0027: name,"},{"line_number":2664,"context_line":"            \u0027specs\u0027: kwargs.get(\u0027specs\u0027),"},{"line_number":2665,"context_line":"        }"},{"line_number":2666,"context_line":"        if kwargs.get(\u0027description\u0027):"},{"line_number":2667,"context_line":"            post_body[\u0027description\u0027] \u003d kwargs.get(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"f7116eca_30e1e850","line":2664,"range":{"start_line":2664,"start_character":12,"end_line":2664,"end_character":41},"in_reply_to":"fcc4aab6_efdbfd98","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"}],"manila_tempest_tests/tests/api/admin/test_qos_types.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ddt"},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":13,"id":"6020d408_9a1bd57f","line":17,"updated":"2026-06-12 18:27:06.000000000","message":"ddt is imported but not used","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ddt"},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":13,"id":"14ed2069_ef399d5e","line":17,"in_reply_to":"6020d408_9a1bd57f","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@ddt.ddt"},{"line_number":33,"context_line":"class QosTypesTest(base.BaseSharesAdminTest):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"716af4a2_0ec8201c","line":32,"updated":"2026-06-12 18:27:06.000000000","message":"ddt is imported but not used","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@ddt.ddt"},{"line_number":33,"context_line":"class QosTypesTest(base.BaseSharesAdminTest):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"a40b30f1_20a9f613","line":32,"in_reply_to":"716af4a2_0ec8201c","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":39,"context_line":"            constants.QOS_TYPE_VERSION)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @decorators.idempotent_id(\u002783a65d3e-550d-4967-a0b6-0d403f0fb592\u0027)"},{"line_number":42,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":43,"context_line":"    def test_qos_type_create_delete(self):"},{"line_number":44,"context_line":"        specs \u003d {"},{"line_number":45,"context_line":"            \"policy_type\": \u0027adaptive\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"d8ce1821_23b84aa3","line":42,"range":{"start_line":42,"start_character":3,"end_line":42,"end_character":58},"updated":"2026-06-12 18:27:06.000000000","message":"QoS type create/delete doesn\u0027t need a backend, consider change tag to TAG_API","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            constants.QOS_TYPE_VERSION)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @decorators.idempotent_id(\u002783a65d3e-550d-4967-a0b6-0d403f0fb592\u0027)"},{"line_number":42,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":43,"context_line":"    def test_qos_type_create_delete(self):"},{"line_number":44,"context_line":"        specs \u003d {"},{"line_number":45,"context_line":"            \"policy_type\": \u0027adaptive\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3dcebebe_64636e93","line":42,"range":{"start_line":42,"start_character":3,"end_line":42,"end_character":58},"in_reply_to":"d8ce1821_23b84aa3","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"}],"manila_tempest_tests/tests/api/admin/test_qos_types_specs.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        self.admin_shares_v2_client.create_qos_type_specs("},{"line_number":72,"context_line":"            qos_type[\u0027id\u0027], self.specs)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.specs[\"key1\"] \u003d \"fake_value1_updated\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Update spec of qos type"},{"line_number":77,"context_line":"        update_one \u003d self.admin_shares_v2_client.update_qos_type_spec("}],"source_content_type":"text/x-python","patch_set":13,"id":"fc4f5ebe_444087e8","line":74,"range":{"start_line":74,"start_character":7,"end_line":74,"end_character":50},"updated":"2026-06-12 18:27:06.000000000","message":"Consider using a local copy of specs instead,\nupdated_specs \u003d dict(self.specs)                                                                                                                                                                     \nupdated_specs[\"key1\"] \u003d \"fake_value1_updated\"","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.admin_shares_v2_client.create_qos_type_specs("},{"line_number":72,"context_line":"            qos_type[\u0027id\u0027], self.specs)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.specs[\"key1\"] \u003d \"fake_value1_updated\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Update spec of qos type"},{"line_number":77,"context_line":"        update_one \u003d self.admin_shares_v2_client.update_qos_type_spec("}],"source_content_type":"text/x-python","patch_set":13,"id":"216d2c80_1b5cd5ab","line":74,"range":{"start_line":74,"start_character":7,"end_line":74,"end_character":50},"in_reply_to":"fc4f5ebe_444087e8","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Update spec of qos type"},{"line_number":77,"context_line":"        update_one \u003d self.admin_shares_v2_client.update_qos_type_spec("},{"line_number":78,"context_line":"            qos_type[\u0027id\u0027], \"key1\", self.specs[\"key1\"])"},{"line_number":79,"context_line":"        self.assertEqual({\"key1\": self.specs[\"key1\"]}, update_one)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        get \u003d self.admin_shares_v2_client.get_qos_type_specs("}],"source_content_type":"text/x-python","patch_set":13,"id":"574b9ffb_3b5ce147","line":78,"range":{"start_line":78,"start_character":11,"end_line":78,"end_character":55},"updated":"2026-06-12 18:27:06.000000000","message":"related to L:74 suggestion\nupdated_specs[\"key1\"]","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Update spec of qos type"},{"line_number":77,"context_line":"        update_one \u003d self.admin_shares_v2_client.update_qos_type_spec("},{"line_number":78,"context_line":"            qos_type[\u0027id\u0027], \"key1\", self.specs[\"key1\"])"},{"line_number":79,"context_line":"        self.assertEqual({\"key1\": self.specs[\"key1\"]}, update_one)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        get \u003d self.admin_shares_v2_client.get_qos_type_specs("}],"source_content_type":"text/x-python","patch_set":13,"id":"b2398ab1_a382b6ed","line":78,"range":{"start_line":78,"start_character":11,"end_line":78,"end_character":55},"in_reply_to":"574b9ffb_3b5ce147","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        # Update spec of qos type"},{"line_number":77,"context_line":"        update_one \u003d self.admin_shares_v2_client.update_qos_type_spec("},{"line_number":78,"context_line":"            qos_type[\u0027id\u0027], \"key1\", self.specs[\"key1\"])"},{"line_number":79,"context_line":"        self.assertEqual({\"key1\": self.specs[\"key1\"]}, update_one)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        get \u003d self.admin_shares_v2_client.get_qos_type_specs("},{"line_number":82,"context_line":"            qos_type[\u0027id\u0027])[\u0027specs\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"7df69cce_52ec3422","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":66},"updated":"2026-06-12 18:27:06.000000000","message":"related to L:74 suggestion\nupdated_specs[\"key1\"]","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # Update spec of qos type"},{"line_number":77,"context_line":"        update_one \u003d self.admin_shares_v2_client.update_qos_type_spec("},{"line_number":78,"context_line":"            qos_type[\u0027id\u0027], \"key1\", self.specs[\"key1\"])"},{"line_number":79,"context_line":"        self.assertEqual({\"key1\": self.specs[\"key1\"]}, update_one)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        get \u003d self.admin_shares_v2_client.get_qos_type_specs("},{"line_number":82,"context_line":"            qos_type[\u0027id\u0027])[\u0027specs\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"21e25e43_a414b38e","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":66},"in_reply_to":"7df69cce_52ec3422","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        get \u003d self.admin_shares_v2_client.get_qos_type_specs("},{"line_number":82,"context_line":"            qos_type[\u0027id\u0027])[\u0027specs\u0027]"},{"line_number":83,"context_line":"        self.assertEqual(self.specs, get)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @decorators.idempotent_id(\u00271db3ff90-7263-434d-892f-4d28d7e6ac56\u0027)"},{"line_number":86,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1abc9aa4_aabfe2c2","line":83,"range":{"start_line":83,"start_character":7,"end_line":83,"end_character":41},"updated":"2026-06-12 18:27:06.000000000","message":"related to L:74 suggestion\nupdated_specs[\"key1\"]","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        get \u003d self.admin_shares_v2_client.get_qos_type_specs("},{"line_number":82,"context_line":"            qos_type[\u0027id\u0027])[\u0027specs\u0027]"},{"line_number":83,"context_line":"        self.assertEqual(self.specs, get)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @decorators.idempotent_id(\u00271db3ff90-7263-434d-892f-4d28d7e6ac56\u0027)"},{"line_number":86,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":13,"id":"916e6f17_2ea3444f","line":83,"range":{"start_line":83,"start_character":7,"end_line":83,"end_character":41},"in_reply_to":"1abc9aa4_aabfe2c2","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"}],"manila_tempest_tests/tests/api/admin/test_qos_types_specs_negative.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from tempest import config"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":13,"id":"04be1d33_3260fd74","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"updated":"2026-06-12 18:27:06.000000000","message":"defined but not used","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from tempest import config"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":13,"id":"cce4e1fe_cf158aa8","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"in_reply_to":"04be1d33_3260fd74","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":28,"context_line":"CONF \u003d config.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@ddt.ddt"},{"line_number":32,"context_line":"class QosTypeSpecsAdminNegativeTest(base.BaseSharesMixedTest):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"c3182f3e_597ab7a9","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":8},"updated":"2026-06-12 18:27:06.000000000","message":"defined but not used","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":28,"context_line":"CONF \u003d config.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@ddt.ddt"},{"line_number":32,"context_line":"class QosTypeSpecsAdminNegativeTest(base.BaseSharesMixedTest):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"23f07d86_95d65491","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":8},"in_reply_to":"c3182f3e_597ab7a9","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"0723ec20e5f24701499a78badbaaf793856d1f0d","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    @decorators.idempotent_id(\u0027b60aa991-0253-4af2-8e85-fe856b7514d3\u0027)"},{"line_number":96,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":97,"context_line":"    def test_try_set_too_long_value_with_update(self):"},{"line_number":98,"context_line":"        too_big_value \u003d \"v\" * 1024"},{"line_number":99,"context_line":"        qos_type \u003d self.create_qos_type(specs\u003dself.specs)"},{"line_number":100,"context_line":"        self.admin_shares_v2_client.create_qos_type_specs("},{"line_number":101,"context_line":"            qos_type[\"id\"],"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ffa5188_d6840202","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":34},"updated":"2026-06-11 15:23:03.000000000","message":"What is the actual current value that is allowed btw, out of curosity?","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"16744cacbc4e17f4e113733809d4a846029cd83e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    @decorators.idempotent_id(\u0027b60aa991-0253-4af2-8e85-fe856b7514d3\u0027)"},{"line_number":96,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":97,"context_line":"    def test_try_set_too_long_value_with_update(self):"},{"line_number":98,"context_line":"        too_big_value \u003d \"v\" * 1024"},{"line_number":99,"context_line":"        qos_type \u003d self.create_qos_type(specs\u003dself.specs)"},{"line_number":100,"context_line":"        self.admin_shares_v2_client.create_qos_type_specs("},{"line_number":101,"context_line":"            qos_type[\"id\"],"}],"source_content_type":"text/x-python","patch_set":13,"id":"654f3c96_1a3e2f91","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":34},"in_reply_to":"9ffa5188_d6840202","updated":"2026-06-11 15:27:57.000000000","message":"key \u003d Column(String(255), nullable\u003dFalse)\n    value \u003d Column(String(255), nullable\u003dFalse)","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":1284,"context_line":"    def create_qos_type(cls, name\u003dNone, client\u003dNone, cleanup_in_class\u003dTrue,"},{"line_number":1285,"context_line":"                        specs\u003dNone, **kwargs):"},{"line_number":1286,"context_line":"        name \u003d name or data_utils.rand_name("},{"line_number":1287,"context_line":"            cls.__class__.__name__ + \u0027qos-type\u0027)"},{"line_number":1288,"context_line":"        client \u003d client or cls.admin_shares_v2_client"},{"line_number":1289,"context_line":"        specs \u003d specs if specs else {}"},{"line_number":1290,"context_line":"        qos_type \u003d client.create_qos_type(name,"}],"source_content_type":"text/x-python","patch_set":13,"id":"a4b3cd08_b0451ff7","line":1287,"range":{"start_line":1287,"start_character":12,"end_line":1287,"end_character":48},"updated":"2026-06-12 18:27:06.000000000","message":"Do you mean cls.__name__ + \u0027qos-type\u0027)?","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"    def create_qos_type(cls, name\u003dNone, client\u003dNone, cleanup_in_class\u003dTrue,"},{"line_number":1285,"context_line":"                        specs\u003dNone, **kwargs):"},{"line_number":1286,"context_line":"        name \u003d name or data_utils.rand_name("},{"line_number":1287,"context_line":"            cls.__class__.__name__ + \u0027qos-type\u0027)"},{"line_number":1288,"context_line":"        client \u003d client or cls.admin_shares_v2_client"},{"line_number":1289,"context_line":"        specs \u003d specs if specs else {}"},{"line_number":1290,"context_line":"        qos_type \u003d client.create_qos_type(name,"}],"source_content_type":"text/x-python","patch_set":13,"id":"6a16272c_8fcb9da4","line":1287,"range":{"start_line":1287,"start_character":12,"end_line":1287,"end_character":48},"in_reply_to":"a4b3cd08_b0451ff7","updated":"2026-06-16 08:50:43.000000000","message":"its similar to how share type is created in same file.","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"}],"manila_tempest_tests/tests/api/test_qos_types_negative.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from tempest import config"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":13,"id":"7adda2ff_a942a70e","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"updated":"2026-06-12 18:27:06.000000000","message":"Same","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from tempest import config"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":13,"id":"26e7da80_cefe6a5a","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"in_reply_to":"7adda2ff_a942a70e","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d config.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LATEST_MICROVERSION \u003d CONF.share.max_api_microversion"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":13,"id":"5879f160_572163af","line":30,"updated":"2026-06-12 18:27:06.000000000","message":"LATEST_MICROVERSION defined but not used","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d config.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LATEST_MICROVERSION \u003d CONF.share.max_api_microversion"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":13,"id":"78945e98_7018810f","line":30,"in_reply_to":"5879f160_572163af","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":30,"context_line":"LATEST_MICROVERSION \u003d CONF.share.max_api_microversion"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@ddt.ddt"},{"line_number":34,"context_line":"class QosTypesNegativeTest(base.BaseSharesMixedTest):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"b37439fa_40f10113","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":8},"updated":"2026-06-12 18:27:06.000000000","message":"Same","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LATEST_MICROVERSION \u003d CONF.share.max_api_microversion"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@ddt.ddt"},{"line_number":34,"context_line":"class QosTypesNegativeTest(base.BaseSharesMixedTest):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"a43c62fc_ef6970bb","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":8},"in_reply_to":"b37439fa_40f10113","updated":"2026-06-16 08:50:43.000000000","message":"Done","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b43f10c344367061f47b7128bb712d69caf4cb34","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u0027f962c88c-e4f7-4d37-8449-e3faf8e30a4a\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":79,"context_line":"    def test_share_create_with_invalid_share_type(self):"},{"line_number":80,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":81,"context_line":"                          self.create_share,"},{"line_number":82,"context_line":"                          size\u003d1,"}],"source_content_type":"text/x-python","patch_set":13,"id":"43c5622d_fe4ed15e","line":79,"range":{"start_line":79,"start_character":4,"end_line":79,"end_character":56},"updated":"2026-06-12 18:27:06.000000000","message":"The test name says \"invalid share type\" but the share type is valid, QoS type it points to doesn\u0027t exist. Consider changing to something like test_share_create_with_invalid_share_type","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b84376e8d9bb770ddb0c47bcd0dcdc16f2d46a67","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u0027f962c88c-e4f7-4d37-8449-e3faf8e30a4a\u0027)"},{"line_number":78,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":79,"context_line":"    def test_share_create_with_invalid_share_type(self):"},{"line_number":80,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":81,"context_line":"                          self.create_share,"},{"line_number":82,"context_line":"                          size\u003d1,"}],"source_content_type":"text/x-python","patch_set":13,"id":"8c81a5ab_aa124501","line":79,"range":{"start_line":79,"start_character":4,"end_line":79,"end_character":56},"in_reply_to":"43c5622d_fe4ed15e","updated":"2026-06-16 08:50:43.000000000","message":"changed to test_share_create_with_invalid_share_type_extra_specs","commit_id":"40db696af9e539382e7983ec6dcc1dd26019baa9"}]}