)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"aa8da89c334403d7bf85926aaacfa1d42f06533a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7716d2a6_ee6834ec","updated":"2026-02-19 06:18:33.000000000","message":"LGTM","commit_id":"cbb61263a456345f97d427c281251745eb960521"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"67665818775621c3714a155807cb1ba1fee60dc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"930265e3_651b273a","updated":"2026-02-27 10:35:50.000000000","message":"LGTM","commit_id":"cbb61263a456345f97d427c281251745eb960521"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4655cf7695109b01c5094cecd7475a097d02cacc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"96793a31_1c5328cd","updated":"2026-03-10 05:43:13.000000000","message":"recheck","commit_id":"cbb61263a456345f97d427c281251745eb960521"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e34f5c80b4d21378dd39e07261c54be8f8dbd7cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"791ccc9e_ec1ad842","updated":"2026-03-13 12:06:49.000000000","message":"recheck","commit_id":"fd065035885b60e15e899cde36f8442150bfe2ea"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"10a6a4d032a1f04872075985c8c1f8a086e77069","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7373a0da_2ddc85fe","updated":"2026-04-20 12:28:58.000000000","message":"LGTM","commit_id":"1b0fe5f6d630f0ffcc168f196124674ba2694d93"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a9da19828a3dbe886f4f9de29b494c58b89af868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3db88782_1aae1fcf","updated":"2026-04-20 12:06:56.000000000","message":"LGTM ..!","commit_id":"1b0fe5f6d630f0ffcc168f196124674ba2694d93"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"834fcc14e75b90445494e3d1202115319d66c38b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c94dfe2f_d568a5b4","updated":"2026-04-20 12:04:47.000000000","message":"LGTM!","commit_id":"1b0fe5f6d630f0ffcc168f196124674ba2694d93"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2fcdadea879ed94c2f45b4b9b07076946dc1fb80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ee4b88c5_0c9d8559","updated":"2026-05-04 11:26:04.000000000","message":"Thanks for working on this change, Sai. This looks good in terms of test coverage. I have two concerns inline though. Please take a look at them.","commit_id":"1b0fe5f6d630f0ffcc168f196124674ba2694d93"}],"manila_tempest_tests/tests/api/test_share_replica_metadata.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6c0c15c5eaca30cae7a8c06ca18faa8e19f41027","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def skip_checks(cls):"},{"line_number":29,"context_line":"        super(ShareReplicaMetadataTest, cls).skip_checks()"},{"line_number":30,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.92\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9251a2d5_644fd303","line":30,"updated":"2026-02-03 13:36:17.000000000","message":"please skip if replication tests are not enabled","commit_id":"beb43e9d40cfe14b4cacd496ac66a1230bdd2f8a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"998df99497fbf7d17478bf49efc230269725d3c6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def skip_checks(cls):"},{"line_number":29,"context_line":"        super(ShareReplicaMetadataTest, cls).skip_checks()"},{"line_number":30,"context_line":"        utils.check_skip_if_microversion_not_supported(\"2.92\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ce70302c_71d4bbae","line":30,"in_reply_to":"9251a2d5_644fd303","updated":"2026-02-03 17:09:34.000000000","message":"Done. Thanks Carloss.","commit_id":"beb43e9d40cfe14b4cacd496ac66a1230bdd2f8a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2fcdadea879ed94c2f45b4b9b07076946dc1fb80","unresolved":true,"context_lines":[{"line_number":32,"context_line":"            raise cls.skipException(\u0027Replication tests are disabled.\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def resource_setup(cls):"},{"line_number":36,"context_line":"        super(ShareReplicaMetadataTest, cls).resource_setup()"},{"line_number":37,"context_line":"        cls.replication_type \u003d CONF.share.backend_replication_type"},{"line_number":38,"context_line":"        cls.multitenancy_enabled \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"b59d9528_396c2e0f","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":2},"updated":"2026-05-04 11:26:04.000000000","message":"I\u0027ve noticed that a bunch of the resource setup is code duplication from https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/api/test_replication.py#L53C5-L97C60 - which is robust and well tested. Any reason why not to reuse it with class inheritance instead and just overload the resource setup with what you will need?\n\nAdditionally, your resource setup is missing the check on the replication types, as the other class.","commit_id":"1b0fe5f6d630f0ffcc168f196124674ba2694d93"}]}