)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"1d1bca96765ce90ac7a5fb87766ae555716a88bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a9e56b0_7a3b9da8","updated":"2026-06-01 04:27:11.000000000","message":"LGTM.","commit_id":"008c8c2babe7a050a23fe83fc27ef6e7769e5f64"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"29f9727d0ed18eb543b5ca2ad326aa38ffef88c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d025ffcf_dd29090e","updated":"2026-06-02 14:22:44.000000000","message":"Please take a look at the comment.","commit_id":"008c8c2babe7a050a23fe83fc27ef6e7769e5f64"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"29f9727d0ed18eb543b5ca2ad326aa38ffef88c8","unresolved":true,"context_lines":[{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":"    def migration_get_progress(self, share_id, version\u003dLATEST_MICROVERSION,"},{"line_number":1829,"context_line":"                               action_name\u003d\u0027migration_get_progress\u0027):"},{"line_number":1830,"context_line":"        if utils.is_microversion_ge("},{"line_number":1831,"context_line":"                version,"},{"line_number":1832,"context_line":"                constants.SHARE_MIGRATION_GET_PROGRESS_GET_VERSION):"},{"line_number":1833,"context_line":"            resp, body \u003d self.get("},{"line_number":1834,"context_line":"                \u0027shares/%s/migration_get_progress\u0027 % share_id,"},{"line_number":1835,"context_line":"                version\u003dversion)"},{"line_number":1836,"context_line":"            body \u003d json.loads(body)"},{"line_number":1837,"context_line":"            return rest_client.ResponseBody(resp, body)"},{"line_number":1838,"context_line":""},{"line_number":1839,"context_line":"        post_body \u003d {"},{"line_number":1840,"context_line":"            action_name: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c27112ba_70eaadf4","line":1837,"range":{"start_line":1830,"start_character":8,"end_line":1837,"end_character":55},"updated":"2026-06-02 14:22:44.000000000","message":"should we move this code block to another method rather than putting the handling in the same method?","commit_id":"008c8c2babe7a050a23fe83fc27ef6e7769e5f64"},{"author":{"_account_id":39161,"name":"Medha Choudhary (netapp)","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"0898eff6aa0e33e0e3db8bd355f0d2fa8cf186d5","unresolved":false,"context_lines":[{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":"    def migration_get_progress(self, share_id, version\u003dLATEST_MICROVERSION,"},{"line_number":1829,"context_line":"                               action_name\u003d\u0027migration_get_progress\u0027):"},{"line_number":1830,"context_line":"        if utils.is_microversion_ge("},{"line_number":1831,"context_line":"                version,"},{"line_number":1832,"context_line":"                constants.SHARE_MIGRATION_GET_PROGRESS_GET_VERSION):"},{"line_number":1833,"context_line":"            resp, body \u003d self.get("},{"line_number":1834,"context_line":"                \u0027shares/%s/migration_get_progress\u0027 % share_id,"},{"line_number":1835,"context_line":"                version\u003dversion)"},{"line_number":1836,"context_line":"            body \u003d json.loads(body)"},{"line_number":1837,"context_line":"            return rest_client.ResponseBody(resp, body)"},{"line_number":1838,"context_line":""},{"line_number":1839,"context_line":"        post_body \u003d {"},{"line_number":1840,"context_line":"            action_name: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff421c59_6a0c4407","line":1837,"range":{"start_line":1830,"start_character":8,"end_line":1837,"end_character":55},"in_reply_to":"c27112ba_70eaadf4","updated":"2026-06-03 09:58:48.000000000","message":"The if/else microversion-branching within a single method is generic pattern across the tempest client — several other methods in shares_client.py follow the same approach. Keeping it in one method also makes it simpler for test writers, who just call migration_get_progress(share_id, version\u003d...) and the correct path (GET or POST) is chosen automatically based on the microversion, without needing to know which underlying method to call.","commit_id":"008c8c2babe7a050a23fe83fc27ef6e7769e5f64"}]}