)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b38a40dfa5899dda76f4b3d5ba550819d1a00e7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f2e0fd0e_fc2f757e","updated":"2026-07-22 21:31:07.000000000","message":"Hi @gmaan.os14@gmail.com - thanks for working on this; agree with all the manila side changes, but, some observations inline","commit_id":"c655b41fe398cf3e85996d98b518361cc10f50ed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ca17ec21f95878dbec619c0ecd986a98f7e2b177","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"99dbd431_7de1aba0","updated":"2026-07-22 20:44:22.000000000","message":"LGTM, thank you!","commit_id":"c655b41fe398cf3e85996d98b518361cc10f50ed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7e59e50e1bb2fea2a010e63f0e421839103391cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"52392a18_47beb889","updated":"2026-07-24 17:45:38.000000000","message":"LGTM, thank you!","commit_id":"86500cdf2beeefd36cea93ea8a1b8f784d8d387e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"65882ce010b06fef2de8d149da7c4ed7319f7310","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f002aeb_b1a2dc31","updated":"2026-07-24 02:22:04.000000000","message":"Thank you @gmaan.os14@gmail.com","commit_id":"86500cdf2beeefd36cea93ea8a1b8f784d8d387e"}],"zuul.d/manila-tempest-jobs.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b5ebe3141a6faaf838d621bd1bae510c04e03351","unresolved":true,"context_lines":[{"line_number":817,"context_line":"              enable_ro_access_level_for_protocols: \"\""},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"- job:"},{"line_number":820,"context_line":"    name: manila-tempest-plugin-dummy-no-dhss-rbac"},{"line_number":821,"context_line":"    parent: manila-tempest-plugin-dummy-no-dhss"},{"line_number":822,"context_line":"    description: |"},{"line_number":823,"context_line":"      This job runs the devstack with RBAC old defaults,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b16dd558_881f3d3d","line":820,"range":{"start_line":820,"start_character":10,"end_line":820,"end_character":50},"updated":"2026-07-20 15:08:52.000000000","message":"This is used in stable branches so shouldn\u0027t be directly updated (because stable branches may have legacy roles instead)\nAlternatively we can use a single job with variations defined with branch pattern.","commit_id":"c389ca4ca7c095019074c77dbff5dce3eae7b7c5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f20c58f7df8980ae7b1f3d332654d2aa7b2ff94b","unresolved":false,"context_lines":[{"line_number":817,"context_line":"              enable_ro_access_level_for_protocols: \"\""},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"- job:"},{"line_number":820,"context_line":"    name: manila-tempest-plugin-dummy-no-dhss-rbac"},{"line_number":821,"context_line":"    parent: manila-tempest-plugin-dummy-no-dhss"},{"line_number":822,"context_line":"    description: |"},{"line_number":823,"context_line":"      This job runs the devstack with RBAC old defaults,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1c8a1939_735b5426","line":820,"range":{"start_line":820,"start_character":10,"end_line":820,"end_character":50},"in_reply_to":"b16dd558_881f3d3d","updated":"2026-07-20 17:47:13.000000000","message":"I think let\u0027s add a new job for old defaults and keep this one to run on stable branches. branch variants can also work but add little complexity.","commit_id":"c389ca4ca7c095019074c77dbff5dce3eae7b7c5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b38a40dfa5899dda76f4b3d5ba550819d1a00e7b","unresolved":true,"context_lines":[{"line_number":820,"context_line":"# by default since 2026.2. But we need this job for stable jobs to"},{"line_number":821,"context_line":"# continue testing the old as well as new defaults. Once 2026.2 is not"},{"line_number":822,"context_line":"# supported in manila-tempest-plugin then we can remove this job."},{"line_number":823,"context_line":"- job:"},{"line_number":824,"context_line":"    name: manila-tempest-plugin-dummy-no-dhss-rbac"},{"line_number":825,"context_line":"    parent: manila-tempest-plugin-dummy-no-dhss"},{"line_number":826,"context_line":"    description: |"},{"line_number":827,"context_line":"      This job runs the devstack with scope checks enabled,"},{"line_number":828,"context_line":"      on the Dummy driver with DHSS\u003dFalse."},{"line_number":829,"context_line":"    vars:"},{"line_number":830,"context_line":"      tempest_test_regex: \u0027manila_tempest_tests.tests.rbac\u0027"},{"line_number":831,"context_line":"      devstack_localrc:"},{"line_number":832,"context_line":"        MANILA_ENFORCE_NEW_DEFAULTS: true"},{"line_number":833,"context_line":"      devstack_local_conf:"},{"line_number":834,"context_line":"        test-config:"},{"line_number":835,"context_line":"          \"$TEMPEST_CONFIG\":"},{"line_number":836,"context_line":"            share:"},{"line_number":837,"context_line":"              default_share_type_name: default"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"- job:"},{"line_number":840,"context_line":"    name: manila-tempest-plugin-dummy-no-dhss-old-rbac"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0f07b371_9cc9b824","line":837,"range":{"start_line":823,"start_character":0,"end_line":837,"end_character":46},"updated":"2026-07-22 21:31:07.000000000","message":"The parameter \"MANILA_ENFORCE_NEW_DEFAULTS\" won\u0027t exist in stable/2025.2 or stable/2026.1 or stable/2025.1 \n\n\nsince `MANILA_ENFORCE_NEW_DEFAULTS` is available and True by default in master and beyond, shouldn\u0027t the right fix here be to restrict this job to only the currently maintained stable branches (still referencing \"MANILA_ENFORCE_SCOPE: true\")?\n\nWe can run rbac tests in the regular dummy driver jobs for master/2026.2 and beyond","commit_id":"c655b41fe398cf3e85996d98b518361cc10f50ed"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95b50b66f81b21c33c9d8c2ceb420069dabef733","unresolved":false,"context_lines":[{"line_number":820,"context_line":"# by default since 2026.2. But we need this job for stable jobs to"},{"line_number":821,"context_line":"# continue testing the old as well as new defaults. Once 2026.2 is not"},{"line_number":822,"context_line":"# supported in manila-tempest-plugin then we can remove this job."},{"line_number":823,"context_line":"- job:"},{"line_number":824,"context_line":"    name: manila-tempest-plugin-dummy-no-dhss-rbac"},{"line_number":825,"context_line":"    parent: manila-tempest-plugin-dummy-no-dhss"},{"line_number":826,"context_line":"    description: |"},{"line_number":827,"context_line":"      This job runs the devstack with scope checks enabled,"},{"line_number":828,"context_line":"      on the Dummy driver with DHSS\u003dFalse."},{"line_number":829,"context_line":"    vars:"},{"line_number":830,"context_line":"      tempest_test_regex: \u0027manila_tempest_tests.tests.rbac\u0027"},{"line_number":831,"context_line":"      devstack_localrc:"},{"line_number":832,"context_line":"        MANILA_ENFORCE_NEW_DEFAULTS: true"},{"line_number":833,"context_line":"      devstack_local_conf:"},{"line_number":834,"context_line":"        test-config:"},{"line_number":835,"context_line":"          \"$TEMPEST_CONFIG\":"},{"line_number":836,"context_line":"            share:"},{"line_number":837,"context_line":"              default_share_type_name: default"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"- job:"},{"line_number":840,"context_line":"    name: manila-tempest-plugin-dummy-no-dhss-old-rbac"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fcc71bca_f6af0e50","line":837,"range":{"start_line":823,"start_character":0,"end_line":837,"end_character":46},"in_reply_to":"0f07b371_9cc9b824","updated":"2026-07-23 18:03:06.000000000","message":"yeah, Takashi made similar point so i created separate job for old RBAC which will run on current master (2026.2) onwards but forgot to keep this job variable same.","commit_id":"c655b41fe398cf3e85996d98b518361cc10f50ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b38a40dfa5899dda76f4b3d5ba550819d1a00e7b","unresolved":true,"context_lines":[{"line_number":852,"context_line":"          \"$TEMPEST_CONFIG\":"},{"line_number":853,"context_line":"            share:"},{"line_number":854,"context_line":"              default_share_type_name: default"},{"line_number":855,"context_line":"            # NOTE: This is to enable the RBAC tests in Tempest run"},{"line_number":856,"context_line":"            # and does not control any setting on oslo.policy side."},{"line_number":857,"context_line":"            enforce_scope:"},{"line_number":858,"context_line":"              manila: True"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"- job:"},{"line_number":861,"context_line":"    name: manila-tempest-plugin-lvm-fips-base"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"26cd346a_7171dc82","line":858,"range":{"start_line":855,"start_character":12,"end_line":858,"end_character":26},"updated":"2026-07-22 21:31:07.000000000","message":"this must be added to the base job (or the two regular dummy driver jobs) so we can enhance the regex to pick up both API and rbac tests always\n\n(no point running rbac tests on all the other jobs, they only test the API and we don\u0027t gain much with extra coverage)","commit_id":"c655b41fe398cf3e85996d98b518361cc10f50ed"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95b50b66f81b21c33c9d8c2ceb420069dabef733","unresolved":true,"context_lines":[{"line_number":852,"context_line":"          \"$TEMPEST_CONFIG\":"},{"line_number":853,"context_line":"            share:"},{"line_number":854,"context_line":"              default_share_type_name: default"},{"line_number":855,"context_line":"            # NOTE: This is to enable the RBAC tests in Tempest run"},{"line_number":856,"context_line":"            # and does not control any setting on oslo.policy side."},{"line_number":857,"context_line":"            enforce_scope:"},{"line_number":858,"context_line":"              manila: True"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"- job:"},{"line_number":861,"context_line":"    name: manila-tempest-plugin-lvm-fips-base"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8d77c7e1_4b1b5346","line":858,"range":{"start_line":855,"start_character":12,"end_line":858,"end_character":26},"in_reply_to":"26cd346a_7171dc82","updated":"2026-07-23 18:03:06.000000000","message":"this is set based on MANILA_ENFORCE_NEW_DEFAULTS so if that is true then no need to set this config sepratly. This is only needed to be set to True when MANILA_ENFORCE_NEW_DEFAULTS is false.\n\n- https://github.com/openstack/manila/blob/master/devstack/plugin.sh#L859","commit_id":"c655b41fe398cf3e85996d98b518361cc10f50ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"65882ce010b06fef2de8d149da7c4ed7319f7310","unresolved":false,"context_lines":[{"line_number":852,"context_line":"          \"$TEMPEST_CONFIG\":"},{"line_number":853,"context_line":"            share:"},{"line_number":854,"context_line":"              default_share_type_name: default"},{"line_number":855,"context_line":"            # NOTE: This is to enable the RBAC tests in Tempest run"},{"line_number":856,"context_line":"            # and does not control any setting on oslo.policy side."},{"line_number":857,"context_line":"            enforce_scope:"},{"line_number":858,"context_line":"              manila: True"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"- job:"},{"line_number":861,"context_line":"    name: manila-tempest-plugin-lvm-fips-base"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"39410617_a04e1c75","line":858,"range":{"start_line":855,"start_character":12,"end_line":858,"end_character":26},"in_reply_to":"8d77c7e1_4b1b5346","updated":"2026-07-24 02:22:04.000000000","message":"Ah, great. Thank you. That works for me.. i think we could consolidate the dummy driver jobs (run both api and rbac tests in the same job); but that can come in another commit","commit_id":"c655b41fe398cf3e85996d98b518361cc10f50ed"}]}