)]}'
{"manila_ui/dashboards/admin/shares/views.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"405847350055827de9a979d60ece5c36dbcfda13","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            {\u0027server_name\u0027: share_server_display_name}"},{"line_number":179,"context_line":"        return context"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @memoized.memoized_method"},{"line_number":182,"context_line":"    def get_data(self):"},{"line_number":183,"context_line":"        try:"},{"line_number":184,"context_line":"            share_serv_id \u003d self.kwargs[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_ec35d444","line":181,"range":{"start_line":181,"start_character":3,"end_line":181,"end_character":29},"updated":"2016-05-17 21:11:47.000000000","message":"The get_data return value should change whenever a new share is added for shares_list. It doesn\u0027t seem like you\u0027d want to return cached value.","commit_id":"dd3848a4fc7668369b3ef7b1645df694a1aba0c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"21913d0186ce490414ff47b84937d2803f8e6300","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            {\u0027server_name\u0027: share_server_display_name}"},{"line_number":179,"context_line":"        return context"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @memoized.memoized_method"},{"line_number":182,"context_line":"    def get_data(self):"},{"line_number":183,"context_line":"        try:"},{"line_number":184,"context_line":"            share_serv_id \u003d self.kwargs[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_c109a5df","line":181,"range":{"start_line":181,"start_character":3,"end_line":181,"end_character":29},"in_reply_to":"dab17558_ec35d444","updated":"2016-05-18 09:00:28.000000000","message":"It is useful only for call from two other method: \"get_context_data\" and \"get_tabs\". With each page refresh this method is executed again. So, this cache works for these two methods that are called at once for single page request.","commit_id":"dd3848a4fc7668369b3ef7b1645df694a1aba0c4"}],"manila_ui/dashboards/project/shares/snapshots/forms.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6c01c0a62ed0be7cc29a12ee030923572afc2a03","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                                    data[\u0027share_id\u0027],"},{"line_number":59,"context_line":"                                                    data[\u0027name\u0027],"},{"line_number":60,"context_line":"                                                    data[\u0027description\u0027],"},{"line_number":61,"context_line":"                                                    force\u003dforce)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            messages.success(request, message)"},{"line_number":64,"context_line":"            return snapshot"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_d8f68ad6","side":"PARENT","line":61,"updated":"2016-05-07 03:49:05.000000000","message":"Why is the handling of \"force\" removed?","commit_id":"e1d878f3a0635b11a90524c24509c5de998290ff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7693ad920902856e1d035bbc516882c5833cb449","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                                    data[\u0027share_id\u0027],"},{"line_number":59,"context_line":"                                                    data[\u0027name\u0027],"},{"line_number":60,"context_line":"                                                    data[\u0027description\u0027],"},{"line_number":61,"context_line":"                                                    force\u003dforce)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            messages.success(request, message)"},{"line_number":64,"context_line":"            return snapshot"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_3f7940fd","side":"PARENT","line":61,"in_reply_to":"dab17558_538d5d30","updated":"2016-05-16 04:50:39.000000000","message":"Oh, okay.","commit_id":"e1d878f3a0635b11a90524c24509c5de998290ff"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e9168c03d68ad69bbd225e6bf4b427c351ac2920","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                                    data[\u0027share_id\u0027],"},{"line_number":59,"context_line":"                                                    data[\u0027name\u0027],"},{"line_number":60,"context_line":"                                                    data[\u0027description\u0027],"},{"line_number":61,"context_line":"                                                    force\u003dforce)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            messages.success(request, message)"},{"line_number":64,"context_line":"            return snapshot"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_538d5d30","side":"PARENT","line":61,"in_reply_to":"dab17558_d8f68ad6","updated":"2016-05-07 06:41:37.000000000","message":"Xing, it is Cinder\u0027s code. We do not have status \"in-use\" that triggers attr \"force\".","commit_id":"e1d878f3a0635b11a90524c24509c5de998290ff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6c01c0a62ed0be7cc29a12ee030923572afc2a03","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def handle(self, request, data):"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            snapshot \u003d manila.share_snapshot_create("},{"line_number":50,"context_line":"                request, data[\u0027share_id\u0027], data[\u0027name\u0027], data[\u0027description\u0027])"},{"line_number":51,"context_line":"            message \u003d _(\u0027Creating share snapshot \"%s\".\u0027) % data[\u0027name\u0027]"},{"line_number":52,"context_line":"            messages.success(request, message)"},{"line_number":53,"context_line":"            return snapshot"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_1818121d","line":50,"updated":"2016-05-07 03:49:05.000000000","message":"I\u0027m not sure why this is in this patch. Please either move this to a separate patch or add comments in the commit message on what this change is about.","commit_id":"255048d46105ce7328f72e1f15779f4186c18dcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e9168c03d68ad69bbd225e6bf4b427c351ac2920","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def handle(self, request, data):"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            snapshot \u003d manila.share_snapshot_create("},{"line_number":50,"context_line":"                request, data[\u0027share_id\u0027], data[\u0027name\u0027], data[\u0027description\u0027])"},{"line_number":51,"context_line":"            message \u003d _(\u0027Creating share snapshot \"%s\".\u0027) % data[\u0027name\u0027]"},{"line_number":52,"context_line":"            messages.success(request, message)"},{"line_number":53,"context_line":"            return snapshot"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_53943d36","line":50,"in_reply_to":"dab17558_1818121d","updated":"2016-05-07 06:41:37.000000000","message":"Commit adds test coverage. And here I remove redundant code to avoid redundant test coverage. Original code with \"force\" key is dead code. Behavior is not changed. It works as was.","commit_id":"255048d46105ce7328f72e1f15779f4186c18dcd"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7693ad920902856e1d035bbc516882c5833cb449","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def handle(self, request, data):"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            snapshot \u003d manila.share_snapshot_create("},{"line_number":50,"context_line":"                request, data[\u0027share_id\u0027], data[\u0027name\u0027], data[\u0027description\u0027])"},{"line_number":51,"context_line":"            message \u003d _(\u0027Creating share snapshot \"%s\".\u0027) % data[\u0027name\u0027]"},{"line_number":52,"context_line":"            messages.success(request, message)"},{"line_number":53,"context_line":"            return snapshot"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_f68a3663","line":50,"in_reply_to":"dab17558_53943d36","updated":"2016-05-16 04:50:39.000000000","message":"I see. It\u0027s still good to add a comment about this change in the commit message as it is not obvious why this change was made.","commit_id":"255048d46105ce7328f72e1f15779f4186c18dcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"74625a1485817f9efe7ffdb58a64c5f739f970ef","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def handle(self, request, data):"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            snapshot \u003d manila.share_snapshot_create("},{"line_number":50,"context_line":"                request, data[\u0027share_id\u0027], data[\u0027name\u0027], data[\u0027description\u0027])"},{"line_number":51,"context_line":"            message \u003d _(\u0027Creating share snapshot \"%s\".\u0027) % data[\u0027name\u0027]"},{"line_number":52,"context_line":"            messages.success(request, message)"},{"line_number":53,"context_line":"            return snapshot"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_b5ffad32","line":50,"in_reply_to":"dab17558_f68a3663","updated":"2016-05-17 13:42:11.000000000","message":"Done","commit_id":"255048d46105ce7328f72e1f15779f4186c18dcd"}],"manila_ui/dashboards/project/shares/snapshots/views.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"61983c2528779c21c55bd7274451d7d37351f911","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            {\u0027snapshot_display_name\u0027: snapshot_display_name}"},{"line_number":46,"context_line":"        return context"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @memoized"},{"line_number":49,"context_line":"    def get_data(self):"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            snapshot_id \u003d self.kwargs[\u0027snapshot_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_14070e1e","line":48,"updated":"2016-05-04 12:20:42.000000000","message":"Nit: please use memoized_method for class methods. It\u0027s currently the same as memoized, however some day it may be changed to include some class-specific things.","commit_id":"82e2830f201bab076a378451edb44cf4f8ed01fd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ca5e9d9adfe724df54b6e349cf6a9d943179b7d1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            {\u0027snapshot_display_name\u0027: snapshot_display_name}"},{"line_number":46,"context_line":"        return context"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @memoized"},{"line_number":49,"context_line":"    def get_data(self):"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            snapshot_id \u003d self.kwargs[\u0027snapshot_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_204bda5a","line":48,"in_reply_to":"1a122d0e_14070e1e","updated":"2016-05-04 15:47:23.000000000","message":"Done","commit_id":"82e2830f201bab076a378451edb44cf4f8ed01fd"}]}
