)]}'
{"manila_ui/dashboards/project/shares/security_services/views.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bcaee6a4a377c9ea12b4f0ee3db78f16fa7083a","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":60,"context_line":"        context \u003d super(UpdateView, self).get_context_data(**kwargs)"},{"line_number":61,"context_line":"        args \u003d (self.get_object().id,)"},{"line_number":62,"context_line":"        context[\u0027submit_url\u0027] \u003d reverse(self.submit_url, args\u003dargs)"},{"line_number":63,"context_line":"        return context"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_initial(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c99d52bd","line":62,"range":{"start_line":61,"start_character":8,"end_line":62,"end_character":67},"updated":"2016-06-15 11:19:25.000000000","message":"This part of code is not tested for the moment, at all.\n\nPlease, add unit tests. Examples you can find in [1] or [2].\n\n[1] https://github.com/openstack/manila-ui/commit/fe06503a\n\n[2] https://github.com/openstack/manila-ui/commit/c11d8fb5","commit_id":"4946cdd9dedf9162a9863bf5a6624f5da8483b26"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dbb60dced95258a481017327d4cc36435204cb55","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":60,"context_line":"        context \u003d super(UpdateView, self).get_context_data(**kwargs)"},{"line_number":61,"context_line":"        args \u003d (self.get_object().id,)"},{"line_number":62,"context_line":"        context[\u0027submit_url\u0027] \u003d reverse(self.submit_url, args\u003dargs)"},{"line_number":63,"context_line":"        return context"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_initial(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_3dae8de7","line":62,"range":{"start_line":61,"start_character":8,"end_line":62,"end_character":67},"in_reply_to":"7aa08908_3744211a","updated":"2016-06-16 14:10:24.000000000","message":"My thinking is available, for example, at [1]. \n\nChanged code - added tests. It also overlaps with one of your commits [2].\n\nThen, how \"test coverage\" can be out of scope? You change code and it is not tested in CI at all. Too risky. Only manual testing can save us here, the most resource consuming thing.\n\n[1] https://review.openstack.org/#/c/319377\n[2] https://review.openstack.org/#/c/330504","commit_id":"4946cdd9dedf9162a9863bf5a6624f5da8483b26"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"800661334e20ce30ac84c7687f400fb295360bc6","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":60,"context_line":"        context \u003d super(UpdateView, self).get_context_data(**kwargs)"},{"line_number":61,"context_line":"        args \u003d (self.get_object().id,)"},{"line_number":62,"context_line":"        context[\u0027submit_url\u0027] \u003d reverse(self.submit_url, args\u003dargs)"},{"line_number":63,"context_line":"        return context"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_initial(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d2e3b6d6","line":62,"range":{"start_line":61,"start_character":8,"end_line":62,"end_character":67},"in_reply_to":"7aa08908_3dae8de7","updated":"2016-06-17 14:44:15.000000000","message":"Yes, \"changed code - added tests\" is a great motto for everyone! I suggest an additional one: \"new code - new tests\" because it seems that the same part of code is not covered with unit tests everywhere in manila-ui. :)\n\nOkay, now to this patch: you are right, it doesn\u0027t matter why this code is not tested now, what really matters is to add a test while we are here. :)","commit_id":"4946cdd9dedf9162a9863bf5a6624f5da8483b26"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"31d755d51a8b1575d3f50c914205abbe1dcdbad8","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":60,"context_line":"        context \u003d super(UpdateView, self).get_context_data(**kwargs)"},{"line_number":61,"context_line":"        args \u003d (self.get_object().id,)"},{"line_number":62,"context_line":"        context[\u0027submit_url\u0027] \u003d reverse(self.submit_url, args\u003dargs)"},{"line_number":63,"context_line":"        return context"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_initial(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_3744211a","line":62,"range":{"start_line":61,"start_character":8,"end_line":62,"end_character":67},"in_reply_to":"7aa08908_c99d52bd","updated":"2016-06-15 15:32:58.000000000","message":"Sure, no problem. IMO it\u0027s slightly out of the blueprint scope however. I suggest to file a separate bug and add units tests in different patch set (or patch sets -- if there more places not covered with unit tests). What do you think?","commit_id":"4946cdd9dedf9162a9863bf5a6624f5da8483b26"}]}
